[From nobody Tue Oct 23 02:08:15 2007 Return-Path: xorp-cvs-bounces@icir.org Delivery-Date: Tue Oct 23 02:00:00 2007 Delivery-Date: Tue, 23 Oct 2007 02:00:00 -0700 Received: from pork.ICSI.Berkeley.EDU (pork.ICSI.Berkeley.EDU [192.150.186.19]) by tigger.icir.org (8.12.11/8.13.6) with ESMTP id l9N90036040931 for <atanu@tigger.icir.org>; Tue, 23 Oct 2007 02:00:00 -0700 (PDT) (envelope-from xorp-cvs-bounces@icir.org) Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake [192.150.186.11]) by pork.ICSI.Berkeley.EDU (8.12.11.20060308/8.12.11) with ESMTP id l9N8xxNS027138 for <atanu@icir.org>; Tue, 23 Oct 2007 01:59:59 -0700 Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1]) by fruitcake.ICSI.Berkeley.EDU (8.12.11.20060614/8.12.11) with ESMTP id l9N8xv5k023316; Tue, 23 Oct 2007 01:59:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on cheddar.ICSI.Berkeley.EDU X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS autolearn=disabled version=3.1.8 Received: from pork.ICSI.Berkeley.EDU (pork [192.150.186.19]) by fruitcake.ICSI.Berkeley.EDU (8.12.11.20060614/8.12.11) with ESMTP id l9N8xtfM023304 for <xorp-cvs@icsi.berkeley.edu>; Tue, 23 Oct 2007 01:59:55 -0700 (PDT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by pork.ICSI.Berkeley.EDU (8.12.11.20060308/8.12.11) with ESMTP id l9N8xt3Y027134 for <xorp-cvs@icir.org>; Tue, 23 Oct 2007 01:59:55 -0700 Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l9N8xtbh078229 for <xorp-cvs@icir.org>; Tue, 23 Oct 2007 01:59:55 -0700 (PDT) (envelope-from atanu@xorpc.icir.org) Received: (from atanu@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id l9N8xt6s078228 for xorp-cvs@icir.org; Tue, 23 Oct 2007 08:59:55 GMT (envelope-from atanu) Date: Tue, 23 Oct 2007 08:59:55 GMT From: Atanu Ghosh <atanu@icir.org> Message-Id: <200710230859.l9N8xt6s078228@xorpc.icir.org> To: xorp-cvs@icir.org X-XORP-CVS-Branch: HEAD Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf X-BeenThere: xorp-cvs@icir.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org> List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>, <mailto:xorp-cvs-request@icir.org?subject=unsubscribe> List-Archive: <http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-cvs> List-Post: <mailto:xorp-cvs@icir.org> List-Help: <mailto:xorp-cvs-request@icir.org?subject=help> List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>, <mailto:xorp-cvs-request@icir.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xorp-cvs-bounces@icir.org Errors-To: xorp-cvs-bounces@icir.org CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2007-10-23 08:59:55 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: The neighbour data structure contained a single timer to handle retransmissions the assumption being that only one was required as the states transitioned towards the full state. The problem is that if an adjacency is in the Exchange or Loading states it is perfectly legal for an LSA arriving from another neighbour to be sent to this peer. If the router was the master for the database exchange sending a LSA cancelled the database exchange timer and replaced it with the LSA retransmit (and LSA requests) timer. Leaving the adjacency stuck in state Exchange. The neighbour structure now has two timers one to handle the database exchange and another to handle LSA requests and retransmissions. Bug found by: Ben Greear <greearb AT candelatech.com> Revision Changes Path 1.300 +26 -22; commitid: 13177471db80a7ea6; xorp/ospf/peer.cc 1.147 +25 -8; commitid: 13177471db80a7ea6; xorp/ospf/peer.hh _______________________________________________ Xorp-cvs mailing list Xorp-cvs@icir.org http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs ]