Hey Ben,<div>Yeah I got it working with OSPF and RIP in CORE, I didn't include OSPF just for simplicity. </div><div><br></div><div>Thanks,</div><div>JM<br><div class="gmail_quote">On Thu, Jan 10, 2013 at 12:19 PM, Ben Greear <span dir="ltr"><<a href="mailto:greearb@candelatech.com" target="_blank">greearb@candelatech.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 01/10/2013 09:13 AM, Jean Michel MacKay wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey,<br>
I realize now that I might of sent this patch at a bad time (right before the holidays). I was just wondering if anyone had time or will have time to look at it.<br>
<br>
Here is a little description:<br>
<br>
This patch allows admin distances to be changed through the config file.<br>
<br>
I've mapped the token 'distance', currently only in RIP (also works for OSPF), to the RIB's set_protocol_admin_distance. Now the origin table is already created<br>
once set_protocol_admin_distance is called, so it fails. I assume that it fails because you shouldn't change the AD once the origin table exists, since it<br>
would comprise all the merge tables using that origin table.<br>
<br>
How I got around this was to implement change_admin_distance in the class OriginTable and only allow the AD to be changed if they are no routes in the<br>
OriginTable. Since that should keep the integrity of the merge tables.<br>
<br>
Does this sound right? I'm worried that I'm missing something about the design of the RIB.<br>
</blockquote>
<br></div>
The patch looks harmless enough to me. You've tested it and it works<br>
for you?<br>
<br>
Thanks,<br>
Ben<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Ben Greear <<a href="mailto:greearb@candelatech.com" target="_blank">greearb@candelatech.com</a>><br>
Candela Technologies Inc <a href="http://www.candelatech.com" target="_blank">http://www.candelatech.com</a><br>
<br>
</font></span></blockquote></div><br></div>