[Bro-Dev] #681: Control characters is ASCII output

[Bro Tracker]

#681: Control characters is ASCII output
---------------------+--------------------
 Reporter:  robin    |      Owner:
     Type:  Problem  |     Status:  new
 Priority:  Normal   |  Milestone:  Bro2.0
Component:  Bro      |    Version:
 Keywords:           |
---------------------+--------------------
 Im still seeing occasional `\x09` in the logging output. It's not
 reproducible but happens from time to time with different files produced
 by the `external` tests. I valgrined and it might be triggered by what's
 reported here:

 {{{
 ==3494== Invalid read of size 1
 ==3494==    at 0x52C865: ODesc::AddBytes(void const*, unsigned int)
 (Desc.cc:264)
 ==3494==    by 0x5AA134: LogWriterAscii::DoWriteOne(ODesc*, LogVal*,
 LogField const*) (Desc.h:63)
 ==3494==    by 0x5AA449: LogWriterAscii::DoWrite(int, LogField const*
 const*, LogVal**) (LogWriterAscii.cc:272)
 ==3494==    by 0x5A96D2: LogWriter::Write(int, LogVal**) (LogWriter.cc:65)
 ==3494==    by 0x5A77A7: LogMgr::Write(EnumVal*, RecordVal*)
 (LogMgr.cc:1041)
 ==3494==    by 0x56C605: BifFunc::Log::bro___write(Frame*, ValPList*)
 (logging.bif:46)
 ==3494==    by 0x56913E: BuiltinFunc::Call(ValPList*, Frame*) const
 (Func.cc:476)
 ==3494==    by 0x560515: CallExpr::Eval(Frame*) const (Expr.cc:4651)
 ==3494==    by 0x5FD938: StmtList::Exec(Frame*, stmt_flow_type&) const
 (Stmt.cc:1402)
 ==3494==    by 0x582C75: BroFunc::Call(ValPList*, Frame*) const
 (Func.cc:333)
 ==3494==    by 0x560515: CallExpr::Eval(Frame*) const (Expr.cc:4651)
 ==3494==    by 0x600F7F: ExprStmt::Exec(Frame*, stmt_flow_type&) const
 (Stmt.cc:367)
 ==3494==  Address 0x79e6751 is 0 bytes after a block of size 1 alloc'd
 ==3494==    at 0x4A059F7: operator new[](unsigned long)
 (vg_replace_malloc.c:305)
 ==3494==    by 0x5A9F50: LogWriterAscii::LogWriterAscii()
 (LogWriterAscii.cc:53)
 ==3494==    by 0x5A8269: LogWriterAscii::Instantiate() (in
 /da/home/robin/bro/master/build/src/bro)
 ==3494==    by 0x5A69C6: LogMgr::CreateWriter(EnumVal*, EnumVal*,
 std::string, int, LogField**) (LogMgr.cc:1278)
 ==3494==    by 0x5A7B22: LogMgr::Write(EnumVal*, RecordVal*)
 (LogMgr.cc:1001)
 ==3494==    by 0x56C605: BifFunc::Log::bro___write(Frame*, ValPList*)
 (logging.bif:46)
 ==3494==    by 0x56913E: BuiltinFunc::Call(ValPList*, Frame*) const
 (Func.cc:476)
 ==3494==    by 0x560515: CallExpr::Eval(Frame*) const (Expr.cc:4651)
 ==3494==    by 0x5FD938: StmtList::Exec(Frame*, stmt_flow_type&) const
 (Stmt.cc:1402)
 ==3494==    by 0x582C75: BroFunc::Call(ValPList*, Frame*) const
 (Func.cc:333)
 ==3494==    by 0x560515: CallExpr::Eval(Frame*) const (Expr.cc:4651)
 ==3494==    by 0x600F7F: ExprStmt::Exec(Frame*, stmt_flow_type&) const
 (Stmt.cc:367)
 }}}

 there are some more of these, but they all look similar.
 This was generated running with connection `MGyaVigCcXk` from the `bro-
 testing`.

 (We discussed this before but I don't think a ticket was filed; at least I
 don't find one).

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/681>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker