[Bro-Dev] #752: topic/jsiwek/brofiler

[Bro Tracker]

#752: topic/jsiwek/brofiler
----------------------------+----------------------
  Reporter:  jsiwek         |      Owner:  jsiwek
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:  Bro2.1
 Component:  Bro            |    Version:
Resolution:                 |   Keywords:
----------------------------+----------------------

Comment (by jsiwek):

 > I don't think I changed anything relevant. I  renamed BROFILER_FILE to
 BRO_PROFILER_FILE for consistency with other env variables though.

 Looks like a few places didn't get adapted to the new name:

 {{{
 $ grep -R BROFILER_FILE .
 ./testing/btest/coverage/coverage-blacklist.bro:# @TEST-EXEC:
 BROFILER_FILE=coverage bro -b %INPUT
 ./testing/external/bro-testing/btest.cfg:BROFILER_FILE=%(testbase)s/.tmp
 /script-coverage
 ./testing/external/subdir-btest.cfg:BROFILER_FILE=%(testbase)s/.tmp
 /script-coverage
 ./testing/scripts/btest-bg-run:BROFILER_FILE=`mktemp -t script-coverage`
 $BTEST_PATH/btest-bg-run $@
 }}}

 The last one is the reason for the errors -- the tests involving
 communication go through that wrapper script so that each Bro process gets
 a unique coverage file to write to, otherwise they may write
 simultaneously to the same file.  Want to try again after fixing those?

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/752#comment:5>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker