[Bro-Dev] #968: Add bytestring_to_uint16, uint32, uint64 functions

Bro Tracker bro at tracker.bro.org
Mon Apr 22 14:36:43 PDT 2013


#968: Add bytestring_to_uint16, uint32, uint64 functions
----------------------------+------------------------
  Reporter:  yun            |      Owner:
      Type:  Merge Request  |     Status:  new
  Priority:  Low            |  Milestone:  Bro2.2
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:  bytestring
----------------------------+------------------------
Changes (by jsiwek):

 * type:  Patch => Merge Request


Comment:

 > Normally you would expect it to be in network-order/big-endian, but
 Metasploit sends the size in little-endian.. So if I read this from the
 packet, I definitely want to ensure that I read it from the known order.

 Ok, makes sense to me now for the flag to indicate LE vs. BE so that we
 can handle either case as the canonical network form.  The patch seemed
 ok, so changing to a merge request just to draw more attention from Robin.

-- 
Ticket URL: <http://tracker.bro.org/bro/ticket/968#comment:35>
Bro Tracker <http://tracker.bro.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list