[Bro-Dev] #983: Deep typing bug

[Bro Tracker]

#983: Deep typing bug
----------------------+------------------------
  Reporter:  seth     |      Owner:
      Type:  Problem  |     Status:  new
  Priority:  High     |  Milestone:  Bro2.2
 Component:  Bro      |    Version:  git/master
Resolution:           |   Keywords:
----------------------+------------------------
Description changed by seth:

Old description:

> This looks like an issue where the automatic typing is digging down one
> layer (beyond the set to the first record) but then doesn't auto type the
> record a layer deeper and gives an error.  This is kind of a major
> usability issue for the 2.2 release because of how the vulnerable
> software version script works.
>
> Example script:
> {{{
> @load frameworks/software/vulnerable
> redef Software::vulnerable_versions += {
>         ["Java"] = set([$max=[$major=1,$minor=5,$minor2=999]],
>                        [$min=[$major=1,$minor=6],
> $max=[$major=1,$minor=6,$minor2=0,$minor3=43]],
>                        [$min=[$major=1,$minor=7],
> $max=[$major=1,$minor=7,$minor2=0,$minor3=20]])
> };
> }}}
>
> Gives the output:
> {{{
> error in ./test-vuln.bro, line 3: type error in initialization
> ([$max=[$major=1, $minor=5, $minor2=999]], [$min=[$major=1, $minor=6],
> $max=[$major=1, $minor=6, $minor2=0, $minor3=43]], [$min=[$major=1,
> $minor=7], $max=[$major=1, $minor=7, $minor2=0, $minor3=20]])
> }}}

New description:

 This looks like an issue where the automatic typing is digging down one
 layer (beyond the set to the first record) but then doesn't auto type the
 record a layer deeper and gives an error.  This is kind of a major
 usability issue for the 2.2 release because of how the vulnerable software
 version script works.

 Example script:
 {{{
 @load frameworks/software/vulnerable
 redef Software::vulnerable_versions += {
         ["Java"] = set([$max=[$major=1,$minor=6,$minor2=0,$minor3=43]],
                        [$min=[$major=1,$minor=7],
 $max=[$major=1,$minor=7,$minor2=0,$minor3=20]])
 };
 }}}

 Gives the output:
 {{{
 error in ./test-vuln.bro, line 3: type error in initialization
 ([$max=[$major=1, $minor=6, $minor2=0, $minor3=43]], [$min=[$major=1,
 $minor=7], $max=[$major=1, $minor=7, $minor2=0, $minor3=20]])}}}

--

-- 
Ticket URL: <http://tracker.bro.org/bro/ticket/983#comment:1>
Bro Tracker <http://tracker.bro.org/bro>
Bro Issue Tracker