[Bro-Dev] [JIRA] (BIT-1564) BroControl incorrectly references ok attribute of results even when None type is returned

[Scott Knick (JIRA)]

Scott Knick created BIT-1564:
--------------------------------

             Summary: BroControl incorrectly references ok attribute of results even when None type is returned
                 Key: BIT-1564
                 URL: https://bro-tracker.atlassian.net/browse/BIT-1564
             Project: Bro Issue Tracker
          Issue Type: Problem
          Components: BroControl
            Reporter: Scott Knick
            Priority: Low


The various do_xxxx methods in bin/broctl attempt to reference the "ok" attribute of the results object returned from the BroCtl class' corresponding method. However, these methods can return the None type which has no "ok" attribute. This results in errors like this from BroControl:

{{[root at system spool]# /usr/local/bro/bin/broctl install
error: Unable to do xyz in plugin
Error: 'NoneType' object has no attribute 'ok'}}

I discovered this when returning False from the cmd_install_pre() method of my custom BroControl plugin.



--
This message was sent by Atlassian JIRA
(v7.2.0-OD-05-023#72002)