<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://bro-tracker.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/57391484b688fbd298c2356e4fa0421d?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="dnthayer" id="email_dnthayer" href="https://bro-tracker.atlassian.net/secure/ViewProfile.jspa?name=dnthayer" style="color:#3b73af;; color: #3b73af; text-decoration: none">Daniel Thayer</a> <strong>commented</strong> on an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff; border-bottom: 1px solid #ccc; border-bottom: none; padding-bottom: 0px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text" style="padding: 0px; border-collapse: collapse; padding: 0px; padding-left: 16px; padding-bottom: 10px; border-left: 1px solid #ccc">
<p style="margin: 10px 0 0 0">Responding to Robin's comments:</p>
<p style="margin: 10px 0 0 0">> - there's code to remove quotes, but that seems to work only if there's<br /> just a single variable in the env_vars (i.e., not if individual variables<br /> are quoted). Is that intended? What's the situation here that's addressed,<br /> i.e, why would there be quotes in the first place?</p>
<p style="margin: 10px 0 0 0">The code to remove quotes is intended to handle this situation:<br /> env_vars="VAR1=1 VAR2=2"<br /> I thought someone might try this because they might think the<br /> quotes are needed (they're not needed) due to the space<br /> between the two environment variables.<br /> In this case, if we don't remove the quotes, then the shell<br /> interprets "VAR1=1 VAR2=2" as a command (which fails obviously,<br /> but the user wouldn't get useful feedback of what's happening,<br /> so that's why I'm just removing such quotes if they are found).</p>
<p style="margin: 10px 0 0 0">> - I suggest changing the node's env_vars to a dictionary<br /> internally. Maintaining the space-separated list seems error-prone, in<br /> particular when plugins modify it. _makeEnvParams() would then build<br /> the string. That could also solve the quotation problem.</p>
<p style="margin: 10px 0 0 0">That would make the debug output easier to read (no chance of having duplicate<br /> environment variables in the output in the case where a user tries to override a <br /> value set by a plugin), but I should mention that the space-separated list<br /> is user-supplied (in node.cfg, we'd have this:<br /> env_vars=VAR1=1 VAR2=2), so if we use a dictionary then<br /> we'd first need to separate that list. Another<br /> approach would be to force users to specify multiple<br /> env_vars entries (one for each environment variable),<br /> like this:<br /> env_vars=VAR1=1<br /> env_vars=VAR2=2<br /> But, currently the config file parser only uses the last entry<br /> and ignores all previous values (so in this example Bro would<br /> see VAR2=2, but no variable named VAR1), so the config file<br /> parser would need to be changed to support this. </p>
<p style="margin: 10px 0 0 0">> - the Myricom plugin is overriding the existing variables, that should<br /> probably be adding to them instead?</p>
<p style="margin: 10px 0 0 0">Not sure I understand. Are you saying that the myricom plugin<br /> is doing something different than the PF_RING plugin?<br /> I think both plugins are behaving the same way (i.e., if a user<br /> sets "XYZ=3" in node.cfg, and a plugin sets "XYZ=15", then<br /> Bro sees "XYZ=3"). </p>
<p style="margin: 10px 0 0 0">> - I'm not seeing the broctl.cfg option?</p>
<p style="margin: 10px 0 0 0">Right, I did not implement that feature yet.</p>
<p style="margin: 10px 0 0 0">> - The option documentation should specify the format.</p>
<p style="margin: 10px 0 0 0">I've added a usage example in the documentation.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="page-title-pattern-first-line" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 16px"> <a href="https://bro-tracker.atlassian.net/browse/BIT" style="color: #3b73af; text-decoration: none">Bro Issue Tracker</a> / <a href="https://bro-tracker.atlassian.net/browse/BIT-1010" style="color: #3b73af; text-decoration: none"><img src="https://bro-tracker.atlassian.net/images/icons/issuetypes/task.png" height="16" width="16" border="0" align="absmiddle" alt="Task" /></a> <a href="https://bro-tracker.atlassian.net/browse/BIT-1010" style="color: #3b73af; text-decoration: none">BIT-1010</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" id="page-title-pattern-header-container"> <span id="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://bro-tracker.atlassian.net/browse/BIT-1010" style="color: #3b73af; text-decoration: none">BroControl plugin for adding environment variables</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 0 0 0 24px; vertical-align: middle; padding-left: 0px">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://bro-tracker.atlassian.net/browse/BIT-1010#add-comment" target="_blank" title="{getText($action.text)}" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="https://bro-tracker.atlassian.net/images/mail/comment-icon.png" alt="Add Comment" title="{Add Comment}-icon" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://bro-tracker.atlassian.net/browse/BIT-1010#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your <a style="color:#3b73af;; color: #3b73af; text-decoration: none" href="https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa">JIRA administrators</a><br /> For more information on JIRA, see: <a style="color:#3b73af;; color: #3b73af; text-decoration: none" href="http://www.atlassian.com/software/jira">http://www.atlassian.com/software/jira</a>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://bro-tracker.atlassian.net/images/mail/footer-desktop-logo.png" alt="JIRA logo" title="JIRA logo" width="92" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>