<p dir="ltr">I moved that line from NetVar to my plugin source. I also moved some things from bifs to the plugin source (honestly, just copied and pasted). Posting just the plugin directory won't show which lines in the core I moved to the plugin. Should I make a branch off master? What are the general conventions for doing this?</p>
<p dir="ltr">-AK</p>
<div class="gmail_quote">On Oct 15, 2014 8:28 AM, "Seth Hall" <<a href="mailto:seth@icir.org">seth@icir.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Oct 15, 2014, at 10:46 AM, Siwek, Jon <<a href="mailto:jsiwek@illinois.edu">jsiwek@illinois.edu</a>> wrote:<br>
<br>
> Maybe that can just be completely removed if Bro proper no longer relies on that type since all the related functionality is now provided by the plugin?<br>
<br>
Agreed. Any code related to GeoIP should move into the plugin, including types.<br>
<br>
.Seth<br>
<br>
--<br>
Seth Hall<br>
International Computer Science Institute<br>
(Bro) because everyone has a network<br>
<a href="http://www.bro.org/" target="_blank">http://www.bro.org/</a><br>
<br>
</blockquote></div>