<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div>No idea what’s in master. It should be trivial if you don’t remove the dhcp analyzer completely.</div><div><br>On Jun 16, 2018, at 6:07 AM, Vlad Grigorescu <<a href="mailto:vlad@es.net">vlad@es.net</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Yep, already working on it. :-)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 16, 2018 at 6:26 AM, Seth Hall <span dir="ltr"><<a href="mailto:seth@corelight.com" target="_blank">seth@corelight.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
On 15 Jun 2018, at 17:22, Azoff, Justin S wrote:<br>
<br>
> The fix is a little trickier, you can't handle both events because the <br>
> DHCP::Msg type no longer exists and you need to wrap the old event <br>
> with<br>
><br>
> @ifdef (DHCP::Msg)<br>
> @endif<br>
<br>
</span>Ugh, I didn't consider that. Bro has re-reached the point where <br>
touching any number of things can set off an avalanche of problems like <br>
this.<br>
<br>
Anyone on this thread up for submitting a patch which makes Bro cope <br>
with the changes automatically? You can then even mark the old events <br>
as deprecated. :)<br>
<span class="im HOEnZb"><br>
.Seth<br>
<br>
--<br>
Seth Hall * Corelight, Inc * <a href="http://www.corelight.com" rel="noreferrer" target="_blank">www.corelight.com</a><br>
</span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
bro-dev mailing list<br>
<a href="mailto:bro-dev@bro.org">bro-dev@bro.org</a><br>
<a href="http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev" rel="noreferrer" target="_blank">http://mailman.icsi.berkeley.<wbr>edu/mailman/listinfo/bro-dev</a><br>
</div></div></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>bro-dev mailing list</span><br><span><a href="mailto:bro-dev@bro.org">bro-dev@bro.org</a></span><br><span><a href="http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev">http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev</a></span><br></div></blockquote></body></html>