[Bro] Segmentation fault when installing a rotate timer in BroFile

[Vern Paxson]

> Program received signal SIGSEGV, Segmentation fault.
> 0x080eed0d in BroFile::InstallRotateTimer (this=0x90b4030) at File.cc:562
> 562             timer_mgr->Add(rotate_timer);

This came up a little while ago on the mailing list.  See if the following
does the trick.

		Vern


Date:  Wed, 19 Sep 2007 12:50:23 +0800
From:  "CS Lee" <geek00l at gmail.com>
Subject:  Re: [Bro] Rotate log time issue - bro seg fault
To:  "Vern Paxson" <vern at icir.org>
Cc:  bro at icsi.berkeley.edu

------=_Part_17020_2333909.1190177423900
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Vern,

The patch works! There's no more segfault after the patch is applied.

Thanks.

On 9/19/07, Vern Paxson <vern at icir.org> wrote:
>
> > The bro-1.3.2. that we installed having the same revision which is 4657
> -
>
> Ah.  Then please try this one.
>
>                 Vern
>
>
> Index: File.cc
> ===================================================================
> --- File.cc     (revision 4763)
> +++ File.cc     (revision 4773)
> @@ -539,6 +539,9 @@
>
> void BroFile::InstallRotateTimer()
>         {
> +       if ( terminating )
> +               return;
> +
>         if ( rotate_timer )
>                 {
>                 timer_mgr->Cancel(rotate_timer);
>



-- 
Best Regards,

CS Lee<geekooL[at]gmail.com>

------=_Part_17020_2333909.1190177423900
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Vern,<br><br>The patch works! There&#39;s no more segfault after the patch is applied. <br><br>Thanks.<br><br><div><span class="gmail_quote">On 9/19/07, <b class="gmail_sendername">Vern Paxson</b> &lt;<a href="mailto:vern at icir.org">
vern at icir.org</a>&gt; wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
&gt; The bro-1.3.2. that we installed having the same revision which is 4657 -<br><br>Ah.&nbsp;&nbsp;Then please try this one.<br><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Vern<br><br><br>Index: File.cc<br>===================================================================
<br>--- File.cc&nbsp;&nbsp;&nbsp;&nbsp; (revision 4763)<br>+++ File.cc&nbsp;&nbsp;&nbsp;&nbsp; (revision 4773)<br>@@ -539,6 +539,9 @@<br><br> void BroFile::InstallRotateTimer()<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;{<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if ( terminating )<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return;<br>+<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if ( rotate_timer )
<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;{<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;timer_mgr-&gt;Cancel(rotate_timer);<br></blockquote></div><br><br clear="all"><br>-- <br>Best Regards,<br><br>CS Lee&lt;geekooL[at]gmail.com&gt; 

------=_Part_17020_2333909.1190177423900--