From pavlin@icir.org Fri Jul 1 17:57:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 16:57:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/libcomm Message-ID: <200507011657.j61GvPM7092100@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 16:57:25 UTC XORP CVS repository Modified files: libxorp xorp.h libcomm comm_api.h Log message: Move the temporary definitions of xsock_t, XORP_BAD_SOCKET and XORP_SOCKOPT_CAST from libcomm/comm_api.h to libxorp/xorp.h so they can be used by other XORP code that deals with sockets. Revision Changes Path 1.18 +1 -11; commitid: 1677242c5754b7ea6; xorp/libcomm/comm_api.h 1.10 +11 -1; commitid: 1677242c5754b7ea6; xorp/libxorp/xorp.h From pavlin@icir.org Fri Jul 1 19:14:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 18:14:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507011814.j61IEjfD069977@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 18:14:44 UTC XORP CVS repository Modified files: rtrmgr util.cc Log message: The maximum storage for a path name should be MAXPATHLEN instead of MAXPATHLEN + 1, because MAXPATHLEN already includes the trailing '\0'. Revision Changes Path 1.14 +3 -3; commitid: 1114042c587d47ea6; xorp/rtrmgr/util.cc From pavlin@icir.org Fri Jul 1 19:39:20 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 18:39:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507011839.j61IdK3a079499@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 18:39:20 UTC XORP CVS repository Modified files: libxorp Makefile.am Makefile.in utils.hh Added files: libxorp test_utils.cc utils.cc Log message: * Add new utility function "xorp_make_temporary_file()" that can be used to create a temporary file with unique name. The kdoc header in utils.hh describes its usage. * Add new test program test_utils.cc that tests the above function. Revision Changes Path 1.35 +5 -1; commitid: 1364442c58c907ea6; xorp/libxorp/Makefile.am 1.48 +23 -10; commitid: 1364442c58c907ea6; xorp/libxorp/Makefile.in 1.1 +210 -0 xorp/libxorp/test_utils.cc (new) 1.1 +97 -0 xorp/libxorp/utils.cc (new) 1.5 +42 -1; commitid: 1364442c58c907ea6; xorp/libxorp/utils.hh From pavlin@icir.org Fri Jul 1 19:40:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 18:40:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507011840.j61Ie76h079573@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 18:40:07 UTC XORP CVS repository Modified files: libxorp .cvsignore Log message: Add test_utils to the list of files to ignore. Revision Changes Path 1.11 +1 -0; commitid: 136b842c58dfc7ea6; xorp/libxorp/.cvsignore From pavlin@icir.org Fri Jul 1 20:06:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 19:06:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200507011906.j61J6SwL001659@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 19:06:28 UTC XORP CVS repository Modified files: fea ifconfig_set_click.cc Log message: Use the xorp_make_temporary_file() function to create a temporary file, and remove the old implementation. Revision Changes Path 1.24 +7 -34; commitid: 64342c593cb7ea6; xorp/fea/ifconfig_set_click.cc From abittau@icir.org Fri Jul 1 23:54:38 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 1 Jul 2005 22:54:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/common xorp/policy/test Message-ID: <200507012254.j61Mscij011576@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-01 22:54:38 UTC XORP CVS repository Modified files: policy Makefile.am Makefile.in code_generator.cc configuration.cc configuration.hh export_code_generator.cc lex.yy_policy_parser.cc policy.l policy.y policy_map.cc policy_map.hh policy_statement.cc policy_statement.hh policy_target.cc policy_target.hh set_map.cc source_match_code_generator.cc term.cc term.hh var_map.cc var_map.hh visitor.hh visitor_semantic.cc visitor_setdep.cc xorp_policy.cc xrl_target.cc xrl_target.hh yacc.yy_policy_parser.cc yacc.yy_policy_parser.cc.h policy/common element.cc policy/test Makefile.am Makefile.in compilepolicy.cc compilepolicy.l compilepolicy.y dummy_test.sh lex.yy_compile_policy.cc policy1.src policy1.var policy2.src policy2.var policyvarmap.conf yacc.yy_compile_policy.cc yacc.yy_compile_policy.cc.h Added files: policy visitor_printer.cc visitor_printer.hh policy/test compilepolicy.hh Log message: Added support for ordering statements when configuring the front end. Configuration of varmap done via XRLs. Minor refactoring. Revision Changes Path 1.10 +3 -1; commitid: 2c9042c5c9727ea6; xorp/policy/Makefile.am 1.25 +278 -292; commitid: 2c9042c5c9727ea6; xorp/policy/Makefile.in 1.3 +8 -8; commitid: 2c9042c5c9727ea6; xorp/policy/code_generator.cc 1.3 +2 -2; commitid: 2c9042c5c9727ea6; xorp/policy/common/element.cc 1.3 +55 -49; commitid: 2c9042c5c9727ea6; xorp/policy/configuration.cc 1.3 +37 -36; commitid: 2c9042c5c9727ea6; xorp/policy/configuration.hh 1.3 +6 -6; commitid: 2c9042c5c9727ea6; xorp/policy/export_code_generator.cc 1.2 +1051 -1102; commitid: 2c9042c5c9727ea6; xorp/policy/lex.yy_policy_parser.cc 1.2 +0 -2; commitid: 2c9042c5c9727ea6; xorp/policy/policy.l 1.2 +4 -4; commitid: 2c9042c5c9727ea6; xorp/policy/policy.y 1.3 +35 -9; commitid: 2c9042c5c9727ea6; xorp/policy/policy_map.cc 1.3 +12 -4; commitid: 2c9042c5c9727ea6; xorp/policy/policy_map.hh 1.3 +36 -38; commitid: 2c9042c5c9727ea6; xorp/policy/policy_statement.cc 1.3 +5 -9; commitid: 2c9042c5c9727ea6; xorp/policy/policy_statement.hh 1.3 +50 -45; commitid: 2c9042c5c9727ea6; xorp/policy/policy_target.cc 1.3 +44 -55; commitid: 2c9042c5c9727ea6; xorp/policy/policy_target.hh 1.3 +15 -10; commitid: 2c9042c5c9727ea6; xorp/policy/set_map.cc 1.3 +5 -5; commitid: 2c9042c5c9727ea6; xorp/policy/source_match_code_generator.cc 1.7 +62 -70; commitid: 2c9042c5c9727ea6; xorp/policy/term.cc 1.6 +34 -44; commitid: 2c9042c5c9727ea6; xorp/policy/term.hh 1.4 +2 -1; commitid: 2c9042c5c9727ea6; xorp/policy/test/Makefile.am 1.7 +245 -263; commitid: 2c9042c5c9727ea6; xorp/policy/test/Makefile.in 1.4 +34 -4; commitid: 2c9042c5c9727ea6; xorp/policy/test/compilepolicy.cc 1.1 +32 -0 xorp/policy/test/compilepolicy.hh (new) 1.2 +13 -35; commitid: 2c9042c5c9727ea6; xorp/policy/test/compilepolicy.l 1.2 +99 -26; commitid: 2c9042c5c9727ea6; xorp/policy/test/compilepolicy.y 1.4 +1 -2; commitid: 2c9042c5c9727ea6; xorp/policy/test/dummy_test.sh 1.2 +1185 -1228; commitid: 2c9042c5c9727ea6; xorp/policy/test/lex.yy_compile_policy.cc 1.2 +2 -2; commitid: 2c9042c5c9727ea6; xorp/policy/test/policy1.src 1.2 +1 -1; commitid: 2c9042c5c9727ea6; xorp/policy/test/policy1.var 1.2 +5 -8; commitid: 2c9042c5c9727ea6; xorp/policy/test/policy2.src 1.2 +2 -1; commitid: 2c9042c5c9727ea6; xorp/policy/test/policy2.var 1.2 +3 -3; commitid: 2c9042c5c9727ea6; xorp/policy/test/policyvarmap.conf 1.2 +160 -69; commitid: 2c9042c5c9727ea6; xorp/policy/test/yacc.yy_compile_policy.cc 1.2 +20 -15; commitid: 2c9042c5c9727ea6; xorp/policy/test/yacc.yy_compile_policy.cc.h 1.3 +34 -38; commitid: 2c9042c5c9727ea6; xorp/policy/var_map.cc 1.3 +5 -6; commitid: 2c9042c5c9727ea6; xorp/policy/var_map.hh 1.3 +2 -9; commitid: 2c9042c5c9727ea6; xorp/policy/visitor.hh 1.1 +154 -0 xorp/policy/visitor_printer.cc (new) 1.1 +55 -0 xorp/policy/visitor_printer.hh (new) 1.3 +9 -9; commitid: 2c9042c5c9727ea6; xorp/policy/visitor_semantic.cc 1.3 +13 -11; commitid: 2c9042c5c9727ea6; xorp/policy/visitor_setdep.cc 1.4 +8 -14; commitid: 2c9042c5c9727ea6; xorp/policy/xorp_policy.cc 1.3 +77 -86; commitid: 2c9042c5c9727ea6; xorp/policy/xrl_target.cc 1.3 +21 -29; commitid: 2c9042c5c9727ea6; xorp/policy/xrl_target.hh 1.2 +69 -69; commitid: 2c9042c5c9727ea6; xorp/policy/yacc.yy_policy_parser.cc 1.2 +6 -7; commitid: 2c9042c5c9727ea6; xorp/policy/yacc.yy_policy_parser.cc.h From abittau@icir.org Fri Jul 1 23:55:10 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 1 Jul 2005 22:55:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507012255.j61MtArb011658@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-01 22:55:10 UTC XORP CVS repository Modified files: xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Log message: new interface to policy. Statements are now inserted and deleted line by line. [terms too]. Revision Changes Path 1.3 +28 -11; commitid: 2d4042c5c9b47ea6; xorp/xrl/interfaces/policy.xif 1.5 +70 -92; commitid: 2d4042c5c9b47ea6; xorp/xrl/interfaces/policy_xif.cc 1.4 +68 -48; commitid: 2d4042c5c9b47ea6; xorp/xrl/interfaces/policy_xif.hh 1.5 +36 -12; commitid: 2d4042c5c9b47ea6; xorp/xrl/targets/policy.xrls 1.5 +64 -89; commitid: 2d4042c5c9b47ea6; xorp/xrl/targets/policy_base.cc 1.5 +55 -27; commitid: 2d4042c5c9b47ea6; xorp/xrl/targets/policy_base.hh From pavlin@icir.org Sat Jul 2 00:36:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 1 Jul 2005 23:36:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507012336.j61Na06P012067@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-01 23:36:00 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Add missing set_operator(OP_ASSIGN) for new leaf nodes that were created by the xorpsh "set" command. Previously, if we were assigning the value of a leaf node for a very first time (e.g., it didn't have even a default value in the rtrmgr template file), then its operator type was OP_NONE, and the ConfigTreeNode::show_subtree() method failed to show its value. Bug found by: Andrea Bittau Revision Changes Path 1.66 +2 -1; commitid: 2edb42c5d25e7ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Sat Jul 2 01:08:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 00:08:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507020008.j6208YUq012483@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 00:08:34 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc conf_tree_node.cc Log message: Editorial nits. Revision Changes Path 1.30 +3 -3; commitid: 30a842c5daf57ea6; xorp/rtrmgr/conf_tree.cc 1.68 +2 -2; commitid: 30a842c5daf57ea6; xorp/rtrmgr/conf_tree_node.cc From pavlin@icir.org Sat Jul 2 01:15:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 00:15:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507020015.j620Fc5D012610@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 00:15:38 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc Log message: If XrlAction::check_xrl_is_valid() fails, then print the module name as part of the error string. Requested by: Andrea Bittau Revision Changes Path 1.52 +24 -17; commitid: 30e542c5db247ea6; xorp/rtrmgr/template_commands.cc From pavlin@icir.org Sat Jul 2 01:19:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 00:19:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507020019.j620JvOo012687@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 00:19:57 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc Log message: Fix TemplateTreeNode::find_parent_varname_node() so it searches properly the tree even if we have reached the root node of the template tree. This allows us to refer to a variable name across the templates of different modules. Bug found by: Andrea Bittau Revision Changes Path 1.41 +12 -1; commitid: 316142c5dcbf7ea6; xorp/rtrmgr/template_tree_node.cc From pavlin@icir.org Sat Jul 2 03:06:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 02:06:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507020206.j62267AY031391@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 02:06:07 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc template_commands.hh Log message: * Add new methods XrlAction::related_module() and ProgramAction::related_module() that return the name of the module the contains the configuration that will invoke the action. Note that this module may be different from the module that an XRL action may be sent to. * Use related_module() instead of affected_module() to add XRL and program actions to the task manager. Thus, each action will be associated with the module where the action is defined instead of, say, the XRL target. This allows us to write rtrmgr templates like: protocols { bgp { ... %modinfo: depends policy; ... import { %set: xrl "$(policy.targetname)/policy/0.1/foo } ... } } In the above example, the %set XRL will be invoked in order together with the rest of the bgp module's XRLs instead of the policy's XRLs. Though, obviously, to have this working the bgp module MUST depend on the policy module. Bug found by: Andrea Bittau Revision Changes Path 1.53 +21 -3; commitid: 7a2b42c5f49d7ea6; xorp/rtrmgr/template_commands.cc 1.26 +5 -1; commitid: 7a2b42c5f49d7ea6; xorp/rtrmgr/template_commands.hh From pavlin@icir.org Sat Jul 2 03:53:12 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 02:53:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507020253.j622rCg0031829@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 02:53:12 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc Log message: Bug fix when adding a segment to a configuration node whose template has no children. Previously, the code assumed that the added segment is a terminal value for a leaf node, but this sometimes allows to have garbage in the configuration if we have a multi-value template node with no children. Now we explicitly check that this is a leaf node before assigning a value to it; if not a leaf node, then this is a syntax error. Bug found by: Andrea Bittau Revision Changes Path 1.31 +15 -7; commitid: 7c1842c600707ea6; xorp/rtrmgr/conf_tree.cc From pavlin@icir.org Sat Jul 2 04:08:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 03:08:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507020308.j623876k033109@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 03:08:07 UTC XORP CVS repository Modified files: etc/templates policy.tp Log message: Temporary comment-out some of the XRLs (until the new policy.tp file is committed) because they don't match the new XRLs after the policy XRL interface update. Revision Changes Path 1.3 +5 -5; commitid: 812942c604847ea6; xorp/etc/templates/policy.tp From pavlin@icir.org Sat Jul 2 05:20:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 2 Jul 2005 04:20:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/policy xorp/policy/test xorp/rtrmgr xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507020420.j624KNjU034457@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-02 04:20:23 UTC XORP CVS repository Modified files: etc/templates Makefile.am Makefile.in policy Makefile.in policy/test Makefile.in rtrmgr cli.cc cli.hh master_conf_tree.cc master_conf_tree.hh slave_conf_tree.cc slave_conf_tree.hh xorpsh_main.cc xorpsh_main.hh xrl_rtrmgr_interface.cc xrl_rtrmgr_interface.hh xrl_xorpsh_interface.cc xrl_xorpsh_interface.hh xrl/interfaces rtrmgr.xif rtrmgr_client.xif rtrmgr_client_xif.cc rtrmgr_client_xif.hh rtrmgr_xif.cc rtrmgr_xif.hh xrl/targets rtrmgr.xrls rtrmgr_base.cc rtrmgr_base.hh xorpsh.xrls xorpsh_base.cc xorpsh_base.hh Added files: etc/templates rtrmgr.tp Log message: * Add support to the rtrmgr to run external programs when loading or saving the configuration. The load and save xorpsh commands are still same as before (e.g., "load " and "save "), but now we recognize the following filename types: - FILE URL (file://...) - FTP URL (ftp://...) - HTTP URL (http://...) - TFTP URL (tftp://...) Any other file names are assumed to be a load or a save operation from/to a local file, and in that case we use the previously existing code for loading/saving to/from the local file system. * Add new template file rtrmgr.tp that can be used to (re)configure the external commands (per URL type) that are to be executed when we try to load or save the configuration. Currently, only some of the load commands have meaningful default values in the rtrmgr.tp template file. * Change the XRL mechanism between the xorpsh and the rtrmgr for saving the configuration. Previously the save operation was syncronous, because it was eventually immediately saved to the disk. Now the operation is asyncronous (xorpsh waits to receive config_saved_done XRL to complete the operation) similar to the configuration load mechanism. Revision Changes Path 1.14 +2 -1; commitid: 850b42c6126d7ea6; xorp/etc/templates/Makefile.am 1.22 +1 -1; commitid: 850b42c6126d7ea6; xorp/etc/templates/Makefile.in 1.1 +198 -0 xorp/etc/templates/rtrmgr.tp (new) 1.26 +293 -277; commitid: 850b42c6126d7ea6; xorp/policy/Makefile.in 1.8 +262 -244; commitid: 850b42c6126d7ea6; xorp/policy/test/Makefile.in 1.67 +37 -12; commitid: 850b42c6126d7ea6; xorp/rtrmgr/cli.cc 1.28 +4 -2; commitid: 850b42c6126d7ea6; xorp/rtrmgr/cli.hh 1.48 +714 -4; commitid: 850b42c6126d7ea6; xorp/rtrmgr/master_conf_tree.cc 1.27 +34 -1; commitid: 850b42c6126d7ea6; xorp/rtrmgr/master_conf_tree.hh 1.27 +31 -1; commitid: 850b42c6126d7ea6; xorp/rtrmgr/slave_conf_tree.cc 1.17 +6 -1; commitid: 850b42c6126d7ea6; xorp/rtrmgr/slave_conf_tree.hh 1.41 +37 -5; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xorpsh_main.cc 1.21 +16 -2; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xorpsh_main.hh 1.35 +78 -38; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc 1.21 +10 -1; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xrl_rtrmgr_interface.hh 1.21 +22 -6; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xrl_xorpsh_interface.cc 1.12 +6 -1; commitid: 850b42c6126d7ea6; xorp/rtrmgr/xrl_xorpsh_interface.hh 1.3 +2 -2; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr.xif 1.4 +3 -1; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr_client.xif 1.15 +35 -1; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr_client_xif.cc 1.13 +16 -1; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr_client_xif.hh 1.15 +3 -1; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr_xif.cc 1.12 +2 -1; commitid: 850b42c6126d7ea6; xorp/xrl/interfaces/rtrmgr_xif.hh 1.12 +12 -4; commitid: 850b42c6126d7ea6; xorp/xrl/targets/rtrmgr.xrls 1.18 +4 -3; commitid: 850b42c6126d7ea6; xorp/xrl/targets/rtrmgr_base.cc 1.18 +12 -3; commitid: 850b42c6126d7ea6; xorp/xrl/targets/rtrmgr_base.hh 1.10 +3 -1; commitid: 850b42c6126d7ea6; xorp/xrl/targets/xorpsh.xrls 1.17 +32 -1; commitid: 850b42c6126d7ea6; xorp/xrl/targets/xorpsh_base.cc 1.17 +8 -1; commitid: 850b42c6126d7ea6; xorp/xrl/targets/xorpsh_base.hh From mjh@icir.org Sat Jul 2 17:53:53 2005 From: mjh@icir.org (Mark Handley) Date: Sat, 2 Jul 2005 16:53:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507021653.j62GrrGe053954@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-02 16:53:52 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh template_tree_node.cc Log message: Add support for retrieving the config operator from a node via a template file variable. The normal template file syntax for a node's value is $(@). The additional syntax for a node's operator is $(<>). Operators don't make much sense on anything other than a terminal node, so don't request the operator from interior nodes. This isn't fabulously well tested, as I've no XRLs that need operators on which to test. I'm assuming Andrea will test this more completely. Let me know if you have any problems with this. Revision Changes Path 1.69 +36 -1; commitid: d27d42c6c5767ea6; xorp/rtrmgr/conf_tree_node.cc 1.35 +2 -2; commitid: d27d42c6c5767ea6; xorp/rtrmgr/conf_tree_node.hh 1.42 +14 -4; commitid: d27d42c6c5767ea6; xorp/rtrmgr/template_tree_node.cc From bms@spc.org Sat Jul 2 20:27:23 2005 From: bms@spc.org (Bruce M Simpson) Date: Sat, 2 Jul 2005 20:27:23 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/libcomm In-Reply-To: <200507011657.j61GvPM7092100@xorpc.icir.org> References: <200507011657.j61GvPM7092100@xorpc.icir.org> Message-ID: <20050702192723.GB6586@empiric.icir.org> On Fri, Jul 01, 2005 at 04:57:25PM +0000, Pavlin Radoslavov wrote: > Log message: > Move the temporary definitions of xsock_t, XORP_BAD_SOCKET and > XORP_SOCKOPT_CAST from libcomm/comm_api.h to libxorp/xorp.h > so they can be used by other XORP code that deals with > sockets. Eeep. I just caught this in a p4 merge. This commit doesn't have to be backed out but please note the warning which was at the top of comm_api.h, this may cause complications during future merges. Regards, BMS From mjh@icir.org Sun Jul 3 15:24:28 2005 From: mjh@icir.org (Mark Handley) Date: Sun, 3 Jul 2005 14:24:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507031424.j63EOSef066908@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-03 14:24:28 UTC XORP CVS repository Modified files: rtrmgr boot.ll boot.yy conf_tree.cc conf_tree.hh lex.boot.cc lex.opcmd.cc lex.tplt.cc y.boot_tab.cc y.boot_tab.h y.opcmd_tab.cc y.tplt_tab.cc Log message: Change to parser to allow node numbers to be expressed. Node numbers are not yet used internally though. Revision Changes Path 1.22 +6 -0; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/boot.ll 1.14 +61 -52; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/boot.yy 1.32 +3 -2; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/conf_tree.cc 1.21 +2 -2; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/conf_tree.hh 1.13 +7420 -7397; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/lex.boot.cc 1.12 +11 -5; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/lex.opcmd.cc 1.13 +11 -5; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/lex.tplt.cc 1.16 +174 -145; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/y.boot_tab.cc 1.6 +1 -0; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/y.boot_tab.h 1.16 +10 -7; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/y.opcmd_tab.cc 1.19 +10 -7; commitid: 1052e42c7f4ba7ea6; xorp/rtrmgr/y.tplt_tab.cc From mjh@icir.org Sun Jul 3 22:06:01 2005 From: mjh@icir.org (Mark Handley) Date: Sun, 3 Jul 2005 21:06:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507032106.j63L616r071762@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-03 21:06:01 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh master_conf_tree.cc master_conf_tree.hh master_conf_tree_node.cc master_conf_tree_node.hh slave_conf_tree.cc slave_conf_tree.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_tree.cc template_tree.hh xrl_rtrmgr_interface.cc Log message: Add most of the framework for node numbering. Rtrmgr and xorpsh can now exchange node numbers as part of the configuration. HEADS UP: config files exchanged back and forth between xorpsh and rtrmgr now include node numbers. Anything talking to the rtrmgr to extract the config needs to expect to see the nodes numbered. Eg: %10% interfaces { %20% interface xl0 { %30% disable: false } } The node numbers aren't visible to the user, either through xorpsh or through saved configs. If you want to see them in xorpsh though, change the false to a true at line 2634 of cli.cc (show_subtree). Autonumbering of nodes isn't yet done properly, and you can't yet get at the node number from the template file, but at least node numbers are parsed, stored, and passed around correctly. Revision Changes Path 1.68 +10 -5; commitid: 117c742c851807ea6; xorp/rtrmgr/cli.cc 1.33 +27 -21; commitid: 117c742c851807ea6; xorp/rtrmgr/conf_tree.cc 1.22 +25 -10; commitid: 117c742c851807ea6; xorp/rtrmgr/conf_tree.hh 1.70 +45 -10; commitid: 117c742c851807ea6; xorp/rtrmgr/conf_tree_node.cc 1.36 +7 -2; commitid: 117c742c851807ea6; xorp/rtrmgr/conf_tree_node.hh 1.49 +11 -10; commitid: 117c742c851807ea6; xorp/rtrmgr/master_conf_tree.cc 1.28 +2 -1; commitid: 117c742c851807ea6; xorp/rtrmgr/master_conf_tree.hh 1.12 +10 -8; commitid: 117c742c851807ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.11 +6 -3; commitid: 117c742c851807ea6; xorp/rtrmgr/master_conf_tree_node.hh 1.28 +8 -7; commitid: 117c742c851807ea6; xorp/rtrmgr/slave_conf_tree.cc 1.18 +2 -1; commitid: 117c742c851807ea6; xorp/rtrmgr/slave_conf_tree.hh 1.20 +5 -3; commitid: 117c742c851807ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.11 +5 -2; commitid: 117c742c851807ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.32 +6 -5; commitid: 117c742c851807ea6; xorp/rtrmgr/template_tree.cc 1.19 +4 -2; commitid: 117c742c851807ea6; xorp/rtrmgr/template_tree.hh 1.36 +3 -3; commitid: 117c742c851807ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc From mjh@icir.org Mon Jul 4 15:45:47 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 4 Jul 2005 14:45:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507041445.j64EjlVL082607@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-04 14:45:47 UTC XORP CVS repository Modified files: rtrmgr boot.yy y.boot_tab.cc y.opcmd_tab.cc y.tplt_tab.cc Log message: replace atoll with strtoll Revision Changes Path 1.15 +2 -2; commitid: 1429042c94b867ea6; xorp/rtrmgr/boot.yy 1.17 +9 -12; commitid: 1429042c94b867ea6; xorp/rtrmgr/y.boot_tab.cc 1.17 +7 -10; commitid: 1429042c94b867ea6; xorp/rtrmgr/y.opcmd_tab.cc 1.20 +7 -10; commitid: 1429042c94b867ea6; xorp/rtrmgr/y.tplt_tab.cc From mjh@icir.org Tue Jul 5 09:29:20 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 5 Jul 2005 08:29:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507050829.j658TK9c093164@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-05 08:29:20 UTC XORP CVS repository Modified files: rtrmgr boot.yy conf_tree.cc y.boot_tab.cc Log message: Fix longstanding bug in parser that freed memory twice. Revision Changes Path 1.16 +16 -16; commitid: 16bcf42ca44c67ea6; xorp/rtrmgr/boot.yy 1.34 +5 -2; commitid: 16bcf42ca44c67ea6; xorp/rtrmgr/conf_tree.cc 1.18 +16 -16; commitid: 16bcf42ca44c67ea6; xorp/rtrmgr/y.boot_tab.cc From mjh@icir.org Tue Jul 5 09:55:52 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 5 Jul 2005 08:55:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507050855.j658tqr7093598@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-05 08:55:52 UTC XORP CVS repository Modified files: rtrmgr boot.yy conf_tree.cc conf_tree.hh y.boot_tab.cc Log message: Better solution: don't use C strings. Revision Changes Path 1.17 +18 -19; commitid: 16d7f42ca4b057ea6; xorp/rtrmgr/boot.yy 1.35 +4 -4; commitid: 16d7f42ca4b057ea6; xorp/rtrmgr/conf_tree.cc 1.23 +2 -2; commitid: 16d7f42ca4b057ea6; xorp/rtrmgr/conf_tree.hh 1.19 +20 -21; commitid: 16d7f42ca4b057ea6; xorp/rtrmgr/y.boot_tab.cc From pavlin@icir.org Tue Jul 5 19:08:27 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 5 Jul 2005 18:08:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507051808.j65I8Rdu010626@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-05 18:08:27 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc slave_conf_tree_node.cc Log message: Replace printf() with debug_msg() Revision Changes Path 1.36 +3 -3; commitid: 296642cacc927ea6; xorp/rtrmgr/conf_tree.cc 1.21 +5 -3; commitid: 296642cacc927ea6; xorp/rtrmgr/slave_conf_tree_node.cc From mjh@icir.org Tue Jul 5 20:15:49 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 5 Jul 2005 19:15:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507051915.j65JFnYO011420@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-05 19:15:49 UTC XORP CVS repository Modified files: rtrmgr boot.yy lex.boot.cc lex.opcmd.cc lex.tplt.cc y.boot_tab.cc Log message: Partially revert previous changes, and fix the real problem. Also fix memory leak with comparison operators. Note to self: first understand problem, then fix code. Revision Changes Path 1.18 +28 -22; commitid: 2c6742cadc067ea6; xorp/rtrmgr/boot.yy 1.14 +5 -11; commitid: 2c6742cadc067ea6; xorp/rtrmgr/lex.boot.cc 1.13 +5 -11; commitid: 2c6742cadc067ea6; xorp/rtrmgr/lex.opcmd.cc 1.14 +5 -11; commitid: 2c6742cadc067ea6; xorp/rtrmgr/lex.tplt.cc 1.20 +64 -58; commitid: 2c6742cadc067ea6; xorp/rtrmgr/y.boot_tab.cc From mjh@icir.org Tue Jul 5 21:28:05 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 5 Jul 2005 20:28:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507052028.j65KS5eW012132@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-05 20:28:05 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh template_tree_node.cc Log message: Add template file support for extracting the node number of a configuration node. The template file syntax is "$(#)" Note that node numbers are not currently guaranteed to have any meaningful values. However if you load the config from a config file (as opposed to enter it in xorpsh), the default node numbers will be vaguely sensible. Any nodes entered from xorpsh current get a node number of 0. A proper node number allocation algorithm is next on the to-do list. Revision Changes Path 1.71 +36 -2; commitid: 2f2842caec847ea6; xorp/rtrmgr/conf_tree_node.cc 1.37 +3 -2; commitid: 2f2842caec847ea6; xorp/rtrmgr/conf_tree_node.hh 1.43 +11 -2; commitid: 2f2842caec847ea6; xorp/rtrmgr/template_tree_node.cc From zec@icir.org Tue Jul 5 22:37:27 2005 From: zec@icir.org (Marko Zec) Date: Tue, 5 Jul 2005 21:37:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rip xorp/etc/templates Message-ID: <200507052137.j65LbRp1013100@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-05 21:37:27 UTC XORP CVS repository Modified files: rip port.cc etc/templates rip.tp ripng.tp Log message: RIP / RIPng: change the default values in per-interface config for accept-default-route and advertise-default-route from false to true. Revision Changes Path 1.20 +3 -3; commitid: 32fc42cafd8a7ea6; xorp/etc/templates/rip.tp 1.21 +3 -3; commitid: 32fc42cafd8a7ea6; xorp/etc/templates/ripng.tp 1.43 +3 -3; commitid: 32fc42cafd8a7ea6; xorp/rip/port.cc From atanu@icir.org Wed Jul 6 00:57:48 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 5 Jul 2005 23:57:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507052357.j65NvmcQ014463@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-05 23:57:48 UTC XORP CVS repository Modified files: bgp dump_iterators.cc Log message: Change a printf to a XLOG_INFO. Revision Changes Path 1.29 +3 -2; commitid: 386442cb1e7a7ea6; xorp/bgp/dump_iterators.cc From pavlin@icir.org Wed Jul 6 01:11:20 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 6 Jul 2005 00:11:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/fea xorp/rtrmgr Message-ID: <200507060011.j660BK8d014724@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-06 00:11:20 UTC XORP CVS repository Modified files: libxorp utils.hh utils.cc test_utils.cc fea ifconfig_set.hh ifconfig_set_click.cc rtrmgr master_conf_tree.cc Log message: * Change the return type for xorp_make_temporary_file() to return a (FILE*) pointer instead of xsock_t. [ Change suggested by Bruce M. Simpson for better Windows portability.] * Change the Windows-related internals of xorp_make_temporary_file() to use GetTempPath() and GetTempFileName(). Note that those changes haven't been tested yet. * Modify the rest of the XORP code to use the new return type of xorp_make_temporary_file() Revision Changes Path 1.36 +2 -2; commitid: 38f642cb20337ea6; xorp/fea/ifconfig_set.hh 1.25 +12 -12; commitid: 38f642cb20337ea6; xorp/fea/ifconfig_set_click.cc 1.2 +6 -6; commitid: 38f642cb20337ea6; xorp/libxorp/test_utils.cc 1.2 +64 -13; commitid: 38f642cb20337ea6; xorp/libxorp/utils.cc 1.6 +13 -10; commitid: 38f642cb20337ea6; xorp/libxorp/utils.hh 1.50 +13 -13; commitid: 38f642cb20337ea6; xorp/rtrmgr/master_conf_tree.cc From pavlin@icir.org Wed Jul 6 01:21:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 05 Jul 2005 17:21:05 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Atanu Ghosh of "Tue, 05 Jul 2005 23:57:48 GMT." <200507052357.j65NvmcQ014463@xorpc.icir.org> Message-ID: <200507060021.j660L57H046056@possum.icir.org> > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: atanu@xorpc.icir.org 2005-07-05 23:57:48 UTC > > XORP CVS repository > > > Modified files: > bgp dump_iterators.cc > > Log message: > Change a printf to a XLOG_INFO. Is XLOG_INFO() the right message here? XLOG_INFO() is suppose to be used for high-level stuff the user cares about such as protocol started/stopped, interface added/deleted, etc. In this particular case, the "iterator has moved" message looks to me more like a debug message, so debug_msg() is probably a better choice. Pavlin > > Revision Changes Path > 1.29 +3 -2; commitid: 386442cb1e7a7ea6; xorp/bgp/dump_iterators.cc > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From atanu@ICSI.Berkeley.EDU Wed Jul 6 01:25:48 2005 From: atanu@ICSI.Berkeley.EDU (Atanu Ghosh) Date: Tue, 05 Jul 2005 17:25:48 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Pavlin Radoslavov of "Tue, 05 Jul 2005 17:21:05 PDT." <200507060021.j660L57H046056@possum.icir.org> Message-ID: <18161.1120609548@tigger.icir.org> I want the user to tell me if this message appears just before BGP crashes. Atanu. >>>>> "Pavlin" == Pavlin Radoslavov writes: >> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: >> atanu@xorpc.icir.org 2005-07-05 23:57:48 UTC >> >> XORP CVS repository >> >> >> Modified files: bgp dump_iterators.cc >> >> Log message: Change a printf to a XLOG_INFO. Pavlin> Is XLOG_INFO() the right message here? XLOG_INFO() is Pavlin> suppose to be used for high-level stuff the user cares about Pavlin> such as protocol started/stopped, interface added/deleted, Pavlin> etc. In this particular case, the "iterator has moved" Pavlin> message looks to me more like a debug message, so Pavlin> debug_msg() is probably a better choice. Pavlin> Pavlin >> Revision Changes Path 1.29 +3 -2; commitid: 386442cb1e7a7ea6; >> xorp/bgp/dump_iterators.cc >> _______________________________________________ Xorp-cvs mailing >> list Xorp-cvs@icir.org >> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Wed Jul 6 01:32:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 05 Jul 2005 17:32:06 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Atanu Ghosh of "Tue, 05 Jul 2005 17:25:48 PDT." <18161.1120609548@tigger.icir.org> Message-ID: <200507060032.j660W6Mx046235@possum.icir.org> > I want the user to tell me if this message appears just before BGP > crashes. Then I presume this XLOG_INFO() will be temporary there until the problem is fixed, because from the CVS log message I got the impression this is a permanent change :) Pavlin > > Atanu. > > >>>>> "Pavlin" == Pavlin Radoslavov writes: > > >> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: > >> atanu@xorpc.icir.org 2005-07-05 23:57:48 UTC > >> > >> XORP CVS repository > >> > >> > >> Modified files: bgp dump_iterators.cc > >> > >> Log message: Change a printf to a XLOG_INFO. > > Pavlin> Is XLOG_INFO() the right message here? XLOG_INFO() is > Pavlin> suppose to be used for high-level stuff the user cares about > Pavlin> such as protocol started/stopped, interface added/deleted, > Pavlin> etc. In this particular case, the "iterator has moved" > Pavlin> message looks to me more like a debug message, so > Pavlin> debug_msg() is probably a better choice. > > Pavlin> Pavlin > > >> Revision Changes Path 1.29 +3 -2; commitid: 386442cb1e7a7ea6; > >> xorp/bgp/dump_iterators.cc > >> _______________________________________________ Xorp-cvs mailing > >> list Xorp-cvs@icir.org > >> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Wed Jul 6 01:50:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 6 Jul 2005 00:50:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/pim Message-ID: <200507060050.j660oohj015119@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-06 00:50:50 UTC XORP CVS repository Modified files: pim TODO Log message: Add PIM-SM spec related TODO entry. Revision Changes Path 1.117 +16 -1; commitid: 3aee42cb2ada7ea6; xorp/pim/TODO From mjh@icir.org Wed Jul 6 09:19:46 2005 From: mjh@icir.org (Mark Handley) Date: Wed, 6 Jul 2005 08:19:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507060819.j668JkKj059941@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-06 08:19:46 UTC XORP CVS repository Modified files: libxipc finder_constants.hh Log message: g++ 3.3 doesn't like "static inline" Revision Changes Path 1.7 +3 -3; commitid: ea0c42cb940e7ea6; xorp/libxipc/finder_constants.hh From bms@icir.org Wed Jul 6 14:23:37 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 6 Jul 2005 13:23:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200507061323.j66DNbqD064066@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-06 13:23:36 UTC XORP CVS repository Modified files: libcomm comm_api.h comm_sock.c Log message: Diff minimization with XORP/Win32. 1. Import the comm_sock_pair() function. This is an implementation of socketpair() which is missing on Win32; on systems which have socketpair(), it simply wraps the system call. 2. Fix bugs in comm_sock_set_blocking() for Win32. 3. No functional changes for non-Windows systems. Revision Changes Path 1.19 +23 -1; commitid: fa1d42cbdb387ea6; xorp/libcomm/comm_api.h 1.23 +143 -3; commitid: fa1d42cbdb387ea6; xorp/libcomm/comm_sock.c From pavlin@icir.org Wed Jul 6 17:17:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 6 Jul 2005 16:17:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507061617.j66GHPAg067801@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-06 16:17:25 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc master_conf_tree.hh Log message: Refactor the mechanism for removing the temporary configuration file to make sure that we don't leave it around in case the user interrupts the rtrmgr during loading or saving the configuration. Revision Changes Path 1.51 +102 -41; commitid: 1078b42cc03fe7ea6; xorp/rtrmgr/master_conf_tree.cc 1.29 +4 -2; commitid: 1078b42cc03fe7ea6; xorp/rtrmgr/master_conf_tree.hh From pavlin@icir.org Wed Jul 6 17:33:53 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 6 Jul 2005 16:33:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507061633.j66GXq2i088160@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-06 16:33:52 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc Log message: Set inside MasterConfigTree::delete_entire_config() the _commit_cb callback value to invoke MasterConfigTree::config_done() Otherwise, if the callback value was changed previously (e.g., inside MasterConfigTree::commit_changes_pass1()), then the wrong callback will be invoked when we gracefully kill the rtrmgr. Revision Changes Path 1.52 +2 -1; commitid: 1581d42cc06ed7ea6; xorp/rtrmgr/master_conf_tree.cc From pavlin@icir.org Wed Jul 6 20:34:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 6 Jul 2005 19:34:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200507061934.j66JYv9b095394@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-06 19:34:56 UTC XORP CVS repository Modified files: fea ifconfig_set.hh ifconfig_set_click.cc Log message: Get rid of the _tmp_fp FILE* pointer inside ClickConfigGenerator, because it is not really needed. Instead, keep only the temporary file name inside _tmp_filename so we can use that name to remove the file later when we don't need it. Revision Changes Path 1.37 +1 -2; commitid: 16c1a42cc31c97ea6; xorp/fea/ifconfig_set.hh 1.26 +7 -13; commitid: 16c1a42cc31c97ea6; xorp/fea/ifconfig_set_click.cc From atanu@icir.org Fri Jul 8 02:27:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 8 Jul 2005 01:27:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507080127.j681RDBC087629@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-08 01:27:13 UTC XORP CVS repository Modified files: libxorp utils.cc Log message: The gcc 4.0 compiler on a Mac doesn't like a statement after the return statement. The offending statement was UNUSED(dirname). Only declare dirname if the HOST_OS is windows. Revision Changes Path 1.3 +3 -3; commitid: 1563442cdd66f7ea6; xorp/libxorp/utils.cc From abittau@icir.org Fri Jul 8 03:06:25 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 02:06:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/fea xorp/fib2mrib xorp/libxipc xorp/policy xorp/policy/backend xorp/policy/common xorp/policy/test xorp/rib xorp/rip xorp/rtrmgr xorp/static_routes Message-ID: <200507080206.j6826P5o088355@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 02:06:25 UTC XORP CVS repository Modified files: bgp Makefile.am Makefile.in bgp_varrw.cc bgp_varrw.hh path_attribute.cc path_attribute.hh plumbing.cc plumbing.hh route_table_policy.cc route_table_policy.hh route_table_ribin.cc etc/templates bgp.tp policy.tp static_routes.tp fea rawsock4.hh rawsock6.hh fib2mrib fib2mrib_node.cc libxipc finder_messenger.hh test_finder_messenger.cc policy Makefile.in code_generator.cc configuration.cc lex.yy_policy_parser.cc policy.l semantic_varrw.cc term.cc var_map.cc var_map.hh yacc.yy_policy_parser.cc policy/backend Makefile.am Makefile.in iv_exec.cc policy_filter.cc policy_filter.hh policy_filters.cc policy_filters.hh single_varrw.hh policy/common Makefile.am Makefile.in dispatcher.hh varrw.hh policy/test Makefile.am Makefile.in execpolicy.cc policy1.src rib parser.hh rt_tab_pol_conn.cc rip output.hh route_db.cc static_routes static_routes_node.cc Added files: bgp bgp_varrw_export.cc bgp_varrw_export.hh route_table_policy_ex.cc route_table_policy_ex.hh etc/templates policy_bgp.tp policy/common varrw.cc Removed files: rtrmgr policyvarmap.conf Log message: * Initial integration of policy manager and rtrmgr. * Some support for BGP policies via rtrmgr. * Initial support for policy tracing on a "per route / policy" basis. * Fixes for gcc41 [compiles with gcc version 4.1.0 20050625 (experimental)] * Hopefully regression tests won't die. I will have all tomorrow to sort them if they do. * Support for "complex" BGP policies coming soon. And route pushing too. Revision Changes Path 1.36 +5 -1; commitid: 157a042cddf177ea6; xorp/bgp/Makefile.am 1.51 +16 -11; commitid: 157a042cddf177ea6; xorp/bgp/Makefile.in 1.8 +73 -34; commitid: 157a042cddf177ea6; xorp/bgp/bgp_varrw.cc 1.7 +24 -14; commitid: 157a042cddf177ea6; xorp/bgp/bgp_varrw.hh 1.1 +37 -0 xorp/bgp/bgp_varrw_export.cc (new) 1.1 +56 -0 xorp/bgp/bgp_varrw_export.hh (new) 1.57 +11 -1; commitid: 157a042cddf177ea6; xorp/bgp/path_attribute.cc 1.33 +2 -1; commitid: 157a042cddf177ea6; xorp/bgp/path_attribute.hh 1.67 +12 -11; commitid: 157a042cddf177ea6; xorp/bgp/plumbing.cc 1.31 +2 -1; commitid: 157a042cddf177ea6; xorp/bgp/plumbing.hh 1.6 +26 -15; commitid: 157a042cddf177ea6; xorp/bgp/route_table_policy.cc 1.6 +16 -4; commitid: 157a042cddf177ea6; xorp/bgp/route_table_policy.hh 1.1 +49 -0 xorp/bgp/route_table_policy_ex.cc (new) 1.1 +60 -0 xorp/bgp/route_table_policy_ex.hh (new) 1.40 +3 -3; commitid: 157a042cddf177ea6; xorp/bgp/route_table_ribin.cc 1.41 +3 -19; commitid: 157a042cddf177ea6; xorp/etc/templates/bgp.tp 1.4 +82 -62; commitid: 157a042cddf177ea6; xorp/etc/templates/policy.tp 1.1 +215 -0 xorp/etc/templates/policy_bgp.tp (new) 1.17 +29 -7; commitid: 157a042cddf177ea6; xorp/etc/templates/static_routes.tp 1.7 +2 -2; commitid: 157a042cddf177ea6; xorp/fea/rawsock4.hh 1.8 +2 -2; commitid: 157a042cddf177ea6; xorp/fea/rawsock6.hh 1.23 +3 -15; commitid: 157a042cddf177ea6; xorp/fib2mrib/fib2mrib_node.cc 1.15 +2 -2; commitid: 157a042cddf177ea6; xorp/libxipc/finder_messenger.hh 1.12 +9 -1; commitid: 157a042cddf177ea6; xorp/libxipc/test_finder_messenger.cc 1.27 +1 -1; commitid: 157a042cddf177ea6; xorp/policy/Makefile.in 1.4 +2 -1; commitid: 157a042cddf177ea6; xorp/policy/backend/Makefile.am 1.7 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/backend/Makefile.in 1.3 +8 -8; commitid: 157a042cddf177ea6; xorp/policy/backend/iv_exec.cc 1.3 +53 -9; commitid: 157a042cddf177ea6; xorp/policy/backend/policy_filter.cc 1.3 +2 -6; commitid: 157a042cddf177ea6; xorp/policy/backend/policy_filter.hh 1.3 +12 -13; commitid: 157a042cddf177ea6; xorp/policy/backend/policy_filters.cc 1.3 +2 -3; commitid: 157a042cddf177ea6; xorp/policy/backend/policy_filters.hh 1.4 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/backend/single_varrw.hh 1.4 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/code_generator.cc 1.4 +2 -1; commitid: 157a042cddf177ea6; xorp/policy/common/Makefile.am 1.7 +5 -3; commitid: 157a042cddf177ea6; xorp/policy/common/Makefile.in 1.3 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/common/dispatcher.hh 1.1 +71 -0 xorp/policy/common/varrw.cc (new) 1.3 +49 -2; commitid: 157a042cddf177ea6; xorp/policy/common/varrw.hh 1.4 +5 -3; commitid: 157a042cddf177ea6; xorp/policy/configuration.cc 1.3 +5 -1; commitid: 157a042cddf177ea6; xorp/policy/lex.yy_policy_parser.cc 1.3 +5 -1; commitid: 157a042cddf177ea6; xorp/policy/policy.l 1.3 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/semantic_varrw.cc 1.8 +20 -3; commitid: 157a042cddf177ea6; xorp/policy/term.cc 1.5 +2 -1; commitid: 157a042cddf177ea6; xorp/policy/test/Makefile.am 1.9 +2 -2; commitid: 157a042cddf177ea6; xorp/policy/test/Makefile.in 1.3 +12 -7; commitid: 157a042cddf177ea6; xorp/policy/test/execpolicy.cc 1.3 +1 -0; commitid: 157a042cddf177ea6; xorp/policy/test/policy1.src 1.4 +24 -1; commitid: 157a042cddf177ea6; xorp/policy/var_map.cc 1.4 +34 -14; commitid: 157a042cddf177ea6; xorp/policy/var_map.hh 1.3 +1 -1; commitid: 157a042cddf177ea6; xorp/policy/yacc.yy_policy_parser.cc 1.17 +7 -1; commitid: 157a042cddf177ea6; xorp/rib/parser.hh 1.6 +2 -7; commitid: 157a042cddf177ea6; xorp/rib/rt_tab_pol_conn.cc 1.9 +3 -9; commitid: 157a042cddf177ea6; xorp/rip/output.hh 1.22 +4 -19; commitid: 157a042cddf177ea6; xorp/rip/route_db.cc 1.2 +0 -50 xorp/rtrmgr/policyvarmap.conf (dead) 1.26 +3 -15; commitid: 157a042cddf177ea6; xorp/static_routes/static_routes_node.cc From abittau@icir.org Fri Jul 8 03:17:44 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 02:17:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507080217.j682Hiva088521@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 02:17:44 UTC XORP CVS repository Modified files: rtrmgr Makefile.am Makefile.in Log message: get rid of varmap.conf which we don't need anymore Revision Changes Path 1.52 +1 -2; commitid: 159ae42cde23f7ea6; xorp/rtrmgr/Makefile.am 1.64 +1 -1; commitid: 159ae42cde23f7ea6; xorp/rtrmgr/Makefile.in From abittau@icir.org Fri Jul 8 03:53:24 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 02:53:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200507080253.j682rO8U098046@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 02:53:24 UTC XORP CVS repository Modified files: policy/common dispatcher.cc dispatcher.hh element_factory.cc Log message: attempt to fix compilation on: gcc version 4.1.0 20050618 (experimental) WARNING: may [most likely will!!!] break compilation on other compilers! Please inform me exactly on which compilers the dispatcher doesn't work. This portion of code is actually the heart of the policy backend. It is subtle, but I would like to keep the code the way it is. Trying to re-write it may make it loose some power it currently has. Revision Changes Path 1.3 +59 -14; commitid: 17ee142cdea4b7ea6; xorp/policy/common/dispatcher.cc 1.4 +8 -56; commitid: 17ee142cdea4b7ea6; xorp/policy/common/dispatcher.hh 1.3 +10 -8; commitid: 17ee142cdea4b7ea6; xorp/policy/common/element_factory.cc From abittau@icir.org Fri Jul 8 05:01:52 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 04:01:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200507080401.j6841qBQ098960@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 04:01:52 UTC XORP CVS repository Modified files: policy/common dispatcher.cc dispatcher.hh Log message: supidly forgot i don't do explicit template instantiations.... will sort out the compilation error another time. However, it seems that it DOES work with: gcc version 4.1.0 20050625 (experimental) Revision Changes Path 1.4 +1 -48; commitid: 1827042cdfa787ea6; xorp/policy/common/dispatcher.cc 1.5 +41 -3; commitid: 1827042cdfa787ea6; xorp/policy/common/dispatcher.hh From pavlin@icir.org Fri Jul 8 08:06:48 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:06:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507080706.j6876moF001619@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:06:48 UTC XORP CVS repository Modified files: bgp Makefile.am Makefile.in Log message: Fix the alphabetical ordering of some of the *.hh and *.cc files. Revision Changes Path 1.37 +3 -3; commitid: 62742ce25d97ea6; xorp/bgp/Makefile.am 1.52 +2 -2; commitid: 62742ce25d97ea6; xorp/bgp/Makefile.in From pavlin@icir.org Fri Jul 8 08:07:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:07:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200507080707.j6877kbn001687@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:07:46 UTC XORP CVS repository Modified files: policy Makefile.in Log message: Re-generate to remove a bogus TODO file Revision Changes Path 1.28 +1 -1; commitid: 67c42ce26207ea6; xorp/policy/Makefile.in From pavlin@icir.org Fri Jul 8 08:09:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:09:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507080709.j6879Qio001800@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:09:25 UTC XORP CVS repository Modified files: libxipc finder_messenger.hh Log message: Remove old TODO leftover comment. Revision Changes Path 1.16 +1 -3; commitid: 6ea42ce269b7ea6; xorp/libxipc/finder_messenger.hh From pavlin@icir.org Fri Jul 8 08:10:04 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:10:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507080710.j687A4FV001852@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:10:04 UTC XORP CVS repository Modified files: libxipc test_finder_messenger.cc Log message: Replace C-style comment with C++ style comment. Revision Changes Path 1.13 +12 -9; commitid: 71f42ce26b57ea6; xorp/libxipc/test_finder_messenger.cc From pavlin@icir.org Fri Jul 8 08:13:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:13:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507080713.j687Dbiu001931@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:13:37 UTC XORP CVS repository Modified files: libxorp test_main.hh Log message: * Cleanup: replace "if(" with "if (", etc. * Improve the declaration of "operator=" by returning "Arg&" instead of "Aarg". Revision Changes Path 1.11 +28 -30; commitid: 76842ce27087ea6; xorp/libxorp/test_main.hh From pavlin@icir.org Fri Jul 8 08:17:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 07:17:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/libxorp xorp/policy Message-ID: <200507080717.j687H7Fd002055@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 07:17:07 UTC XORP CVS repository Modified files: fea rawsock4.hh rawsock6.hh libxorp timer.hh policy dependancy.hh node.hh Log message: Improve the declaration of "operator=" by returning "Foo&" instead of "Foo". [Change inspired by Andrea's gcc-4.1 compilation fix for fea/rawsock{4,6}.hh] Revision Changes Path 1.8 +3 -3; commitid: 7af42ce27fa7ea6; xorp/fea/rawsock4.hh 1.9 +3 -3; commitid: 7af42ce27fa7ea6; xorp/fea/rawsock6.hh 1.24 +2 -2; commitid: 7af42ce27fa7ea6; xorp/libxorp/timer.hh 1.3 +2 -2; commitid: 7af42ce27fa7ea6; xorp/policy/dependancy.hh 1.3 +2 -2; commitid: 7af42ce27fa7ea6; xorp/policy/node.hh From abittau@icir.org Fri Jul 8 16:33:24 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 15:33:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/test Message-ID: <200507081533.j68FXO5k062013@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 15:33:24 UTC XORP CVS repository Modified files: policy yacc.yy_policy_parser.cc policy/test yacc.yy_compile_policy.cc Log message: fix compilation on some systems [hopefully] Revision Changes Path 1.3 +1 -1; commitid: f20f42ce9cb07ea6; xorp/policy/test/yacc.yy_compile_policy.cc 1.4 +1 -1; commitid: f20f42ce9cb07ea6; xorp/policy/yacc.yy_policy_parser.cc From pavlin@icir.org Fri Jul 8 17:33:16 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 16:33:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507081633.j68GXGnw088396@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 16:33:16 UTC XORP CVS repository Modified files: libxorp run_command.cc run_command.hh Log message: Add new class RunCommand::ExecId that can be used to set the execution ID (currently composed of user ID and group ID) when running the command. Revision Changes Path 1.6 +142 -1; commitid: 1592b42ceaa877ea6; xorp/libxorp/run_command.cc 1.5 +132 -1; commitid: 1592b42ceaa877ea6; xorp/libxorp/run_command.hh From pavlin@icir.org Fri Jul 8 17:42:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 16:42:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507081642.j68Gga0P088569@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 16:42:36 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc master_conf_tree.hh task.cc task.hh xrl_rtrmgr_interface.cc Log message: * Add support for setting the execution ID (user ID and group ID) when the router is reconfigured or when we load or save the configuration via running external programs. Note that the setting of the execution ID does not apply for running the XORP processes (e.g., xorp_fea, etc). Instead, it applies only for the external programs that may be used to reconfigure those processes (or to load/save the configuration). Currently, the setting of the execution ID is disabled by default. To enable it, the value of MasterConfigTree::_enable_program_exec_id needs to be set to true inside the MasterConfigTree constructor (inside file master_conf_tree.cc). * Remove the existing code for setting the user ID and group ID and use the new RunCommand::ExecId class instead. * Add a new method MasterConfigTree::apply_config_change() and use it everywhere instead of commit_changes_pass1(). * Minor cleanup. Revision Changes Path 1.53 +101 -97; commitid: 1598342ceaaec7ea6; xorp/rtrmgr/master_conf_tree.cc 1.30 +33 -27; commitid: 1598342ceaaec7ea6; xorp/rtrmgr/master_conf_tree.hh 1.51 +53 -20; commitid: 1598342ceaaec7ea6; xorp/rtrmgr/task.cc 1.32 +48 -13; commitid: 1598342ceaaec7ea6; xorp/rtrmgr/task.hh 1.37 +58 -58; commitid: 1598342ceaaec7ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc From abittau@icir.org Fri Jul 8 18:49:14 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 8 Jul 2005 17:49:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/backend Message-ID: <200507081749.j68HnEL5006382@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-08 17:49:14 UTC XORP CVS repository Modified files: policy/backend iv_exec.hh Log message: fixed compilation with: gcc version 4.1.0 20050618 (experimental) Please let me know for which other compilers the policy code dies. Revision Changes Path 1.3 +3 -11; commitid: 18d542cebc777ea6; xorp/policy/backend/iv_exec.hh From pavlin@icir.org Fri Jul 8 20:20:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 19:20:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507081920.j68JKuQG007453@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 19:20:56 UTC XORP CVS repository Modified files: bgp route_table_ribin.cc Log message: Comment-out the debug_msg() controls, because they shouldn't be enabled by default: #define DEBUG_LOGGING #define DEBUG_PRINT_FUNCTION_NAME Revision Changes Path 1.41 +3 -3; commitid: 1ce642ced1a97ea6; xorp/bgp/route_table_ribin.cc From mjh@icir.org Fri Jul 8 21:45:03 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 8 Jul 2005 20:45:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507082045.j68Kj3lY009558@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-08 20:45:03 UTC XORP CVS repository Modified files: xrl/interfaces rtrmgr.xif rtrmgr_xif.cc rtrmgr_xif.hh xrl/targets rtrmgr.xrls rtrmgr_base.cc rtrmgr_base.hh Log message: Change rtrmgr<->xorpsh interface to support rtrmgr allocating a client ID. Revision Changes Path 1.4 +3 -2; commitid: 251d42cee5ac7ea6; xorp/xrl/interfaces/rtrmgr.xif 1.16 +9 -7; commitid: 251d42cee5ac7ea6; xorp/xrl/interfaces/rtrmgr_xif.cc 1.13 +2 -2; commitid: 251d42cee5ac7ea6; xorp/xrl/interfaces/rtrmgr_xif.hh 1.13 +2 -2; commitid: 251d42cee5ac7ea6; xorp/xrl/targets/rtrmgr.xrls 1.19 +5 -2; commitid: 251d42cee5ac7ea6; xorp/xrl/targets/rtrmgr_base.cc 1.19 +3 -2; commitid: 251d42cee5ac7ea6; xorp/xrl/targets/rtrmgr_base.hh From mjh@icir.org Fri Jul 8 21:51:18 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 8 Jul 2005 20:51:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507082051.j68KpIEk009784@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-08 20:51:18 UTC XORP CVS repository Modified files: rtrmgr Makefile.am boot.yy cli.cc cli.hh conf_tree_node.cc conf_tree_node.hh master_conf_tree_node.cc master_conf_tree_node.hh slave_conf_tree.cc slave_conf_tree.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_base_command.cc template_base_command.hh template_tree_node.cc userdb.hh xorpsh_main.cc xorpsh_main.hh xrl_rtrmgr_interface.cc xrl_rtrmgr_interface.hh y.boot_tab.cc y.boot_tab.h y.opcmd_tab.cc y.opcmd_tab.h y.tplt_tab.cc y.tplt_tab.h Log message: Properly allocate node IDs. Communicate clientid from rtrmgr to xorpsh, which is used in uniquely allocating node IDs. Add the start of support for an %allow-operator command, to limit the operators that can be specified for a particular template tree node. Revision Changes Path 1.53 +5 -1; commitid: 25e842cee7267ea6; xorp/rtrmgr/Makefile.am 1.19 +53 -59; commitid: 25e842cee7267ea6; xorp/rtrmgr/boot.yy 1.69 +24 -6; commitid: 25e842cee7267ea6; xorp/rtrmgr/cli.cc 1.29 +2 -1; commitid: 25e842cee7267ea6; xorp/rtrmgr/cli.hh 1.72 +118 -23; commitid: 25e842cee7267ea6; xorp/rtrmgr/conf_tree_node.cc 1.38 +10 -19; commitid: 25e842cee7267ea6; xorp/rtrmgr/conf_tree_node.hh 1.13 +6 -3; commitid: 25e842cee7267ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.12 +3 -2; commitid: 25e842cee7267ea6; xorp/rtrmgr/master_conf_tree_node.hh 1.29 +7 -4; commitid: 25e842cee7267ea6; xorp/rtrmgr/slave_conf_tree.cc 1.19 +4 -2; commitid: 25e842cee7267ea6; xorp/rtrmgr/slave_conf_tree.hh 1.22 +10 -8; commitid: 25e842cee7267ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.12 +5 -2; commitid: 25e842cee7267ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.4 +92 -3; commitid: 25e842cee7267ea6; xorp/rtrmgr/template_base_command.cc 1.3 +26 -9; commitid: 25e842cee7267ea6; xorp/rtrmgr/template_base_command.hh 1.44 +15 -1; commitid: 25e842cee7267ea6; xorp/rtrmgr/template_tree_node.cc 1.9 +8 -1; commitid: 25e842cee7267ea6; xorp/rtrmgr/userdb.hh 1.42 +5 -3; commitid: 25e842cee7267ea6; xorp/rtrmgr/xorpsh_main.cc 1.22 +5 -2; commitid: 25e842cee7267ea6; xorp/rtrmgr/xorpsh_main.hh 1.38 +36 -7; commitid: 25e842cee7267ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc 1.22 +6 -2; commitid: 25e842cee7267ea6; xorp/rtrmgr/xrl_rtrmgr_interface.hh 1.21 +127 -165; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.boot_tab.cc 1.7 +0 -4; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.boot_tab.h 1.18 +33 -65; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.opcmd_tab.cc 1.5 +0 -4; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.opcmd_tab.h 1.21 +33 -65; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.tplt_tab.cc 1.6 +0 -4; commitid: 25e842cee7267ea6; xorp/rtrmgr/y.tplt_tab.h From mjh@icir.org Fri Jul 8 21:54:20 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 8 Jul 2005 20:54:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507082054.j68KsKJT009863@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-08 20:54:20 UTC XORP CVS repository Added files: rtrmgr config_operators.cc config_operators.hh Log message: Add files to hold functions for converting from and to config operators. Revision Changes Path 1.1 +92 -0 xorp/rtrmgr/config_operators.cc (new) 1.1 +42 -0 xorp/rtrmgr/config_operators.hh (new) From mjh@icir.org Fri Jul 8 21:55:04 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 8 Jul 2005 20:55:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507082055.j68Kt4aa009900@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-08 20:55:04 UTC XORP CVS repository Modified files: rtrmgr Makefile.in Log message: Regenerate Revision Changes Path 1.65 +8 -4; commitid: 269042cee8087ea6; xorp/rtrmgr/Makefile.in From mjh@icir.org Fri Jul 8 22:11:45 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 8 Jul 2005 21:11:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507082111.j68LBjpQ010156@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-08 21:11:45 UTC XORP CVS repository Modified files: rtrmgr Makefile.am Makefile.in Log message: Add config_operators to test targets. Revision Changes Path 1.54 +11 -5; commitid: 279142ceebfd7ea6; xorp/rtrmgr/Makefile.am 1.66 +32 -31; commitid: 279142ceebfd7ea6; xorp/rtrmgr/Makefile.in From pavlin@icir.org Sat Jul 9 00:16:39 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 23:16:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/harness Message-ID: <200507082316.j68NGdND011548@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 23:16:39 UTC XORP CVS repository Modified files: bgp bgp.hh iptuple.cc iptuple.hh bgp/harness peer.cc peer.hh trie_payload.hh Log message: Improve the declaration of "operator=" by returning "Foo&" instead of "Foo". [Change inspired by Andrea's gcc-4.1 compilation fix for fea/rawsock{4,6}.hh Revision Changes Path 1.41 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/bgp.hh 1.63 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/harness/peer.cc 1.17 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/harness/peer.hh 1.7 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/harness/trie_payload.hh 1.12 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/iptuple.cc 1.8 +2 -2; commitid: 2ce142cf093e7ea6; xorp/bgp/iptuple.hh From pavlin@icir.org Sat Jul 9 00:17:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 8 Jul 2005 23:17:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507082317.j68NHhV9011617@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-08 23:17:43 UTC XORP CVS repository Modified files: rtrmgr config_operators.hh xorpsh_main.hh Log message: Nits. Revision Changes Path 1.2 +3 -2; commitid: 2d4642cf09937ea6; xorp/rtrmgr/config_operators.hh 1.23 +2 -3; commitid: 2d4642cf09937ea6; xorp/rtrmgr/xorpsh_main.hh From abittau@icir.org Sat Jul 9 01:32:48 2005 From: abittau@icir.org (Andrea Bittau) Date: Sat, 9 Jul 2005 00:32:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/policy xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507090032.j690Wm0T012376@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-09 00:32:48 UTC XORP CVS repository Modified files: etc/templates policy.tp policy_bgp.tp rip.tp static_routes.tp policy configuration.cc configuration.hh export_code_generator.cc export_code_generator.hh policy_list.cc policy_statement.cc policy_statement.hh policy_target.cc policy_target.hh source_match_code_generator.cc source_match_code_generator.hh term.cc term.hh visitor_semantic.cc xrl_target.cc xrl_target.hh xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Log message: * Use 64bit line numbers. TODO: xrl u64 would be cleaner. * Allow empty source blocks in export policies. The semantics is "match anything which passes". Note... this will not cause a re-distribution however. Say a bgp export policy is: term a { source {} action { med: 10 } } The most likeley event of this is that all routes going out through BGP will get a med of 10. This will most likeley mean BGP routes. It would cause redistribution from say, static, ospf or whatever. This is normally useful in the following scenario: // cause redistribution from rip,ospf -> bgp term a { source { protocol: rip } } term b { source { protocol: ospf } } // default action for all routes exiting bgp term c { action { med: 10 } } None of this is really tested. Testing and BGP route pushing are the main priority for the next 2 weeks. Revision Changes Path 1.5 +14 -14; commitid: 2fa242cf1a5f7ea6; xorp/etc/templates/policy.tp 1.2 +53 -53; commitid: 2fa242cf1a5f7ea6; xorp/etc/templates/policy_bgp.tp 1.21 +7 -1; commitid: 2fa242cf1a5f7ea6; xorp/etc/templates/rip.tp 1.18 +6 -6; commitid: 2fa242cf1a5f7ea6; xorp/etc/templates/static_routes.tp 1.5 +42 -35; commitid: 2fa242cf1a5f7ea6; xorp/policy/configuration.cc 1.4 +4 -11; commitid: 2fa242cf1a5f7ea6; xorp/policy/configuration.hh 1.4 +26 -19; commitid: 2fa242cf1a5f7ea6; xorp/policy/export_code_generator.cc 1.3 +8 -10; commitid: 2fa242cf1a5f7ea6; xorp/policy/export_code_generator.hh 1.3 +40 -47; commitid: 2fa242cf1a5f7ea6; xorp/policy/policy_list.cc 1.4 +2 -2; commitid: 2fa242cf1a5f7ea6; xorp/policy/policy_statement.cc 1.4 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/policy/policy_statement.hh 1.4 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/policy/policy_target.cc 1.4 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/policy/policy_target.hh 1.4 +41 -16; commitid: 2fa242cf1a5f7ea6; xorp/policy/source_match_code_generator.cc 1.3 +22 -5; commitid: 2fa242cf1a5f7ea6; xorp/policy/source_match_code_generator.hh 1.9 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/policy/term.cc 1.7 +4 -4; commitid: 2fa242cf1a5f7ea6; xorp/policy/term.hh 1.4 +42 -35; commitid: 2fa242cf1a5f7ea6; xorp/policy/visitor_semantic.cc 1.4 +7 -5; commitid: 2fa242cf1a5f7ea6; xorp/policy/xrl_target.cc 1.4 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/policy/xrl_target.hh 1.4 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/interfaces/policy.xif 1.6 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/interfaces/policy_xif.cc 1.5 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/interfaces/policy_xif.hh 1.6 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/targets/policy.xrls 1.6 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/targets/policy_base.cc 1.6 +3 -3; commitid: 2fa242cf1a5f7ea6; xorp/xrl/targets/policy_base.hh From pavlin@icir.org Sat Jul 9 03:27:51 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 9 Jul 2005 02:27:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507090227.j692Rpje018017@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-09 02:27:51 UTC XORP CVS repository Modified files: libxipc test_finder_messenger.cc Log message: Fix the ~DummyFinder() destructor so now it deletes properly the _messenger. Previously, the problem was that if we delete _messenger, its ~FinderTcpMessenger destructor tries to use a pointer to its manager() to announce the messenger's death event. However, at the time we call the ~DummyFinder destructor the _messenger's manager() pointer may be invalid because the manager() may have been deleted. Hence, the solution is to unhook the _messenger's manager() before deleting the _messenger itself inside the ~DummyFinder(). Note that the above problem applies only for this particular test which defines internally the DummyFinder, and the libxipc library itself should be fine. Revision Changes Path 1.14 +6 -13; commitid: 45df42cf33997ea6; xorp/libxipc/test_finder_messenger.cc From mjh@icir.org Sat Jul 9 20:47:41 2005 From: mjh@icir.org (Mark Handley) Date: Sat, 9 Jul 2005 19:47:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507091947.j69JlfdL043610@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-09 19:47:41 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc template_commands.hh Log message: Fix buggy template xrl cleaning code. As far as I can tell, the variable expansion code works fine, and doesn't need change. Now the following works (hacking an existing XRL for test purposes): %set: xrl "$(interfaces.targetname)/ifmgr/0.1/set_mtu?tid:u32=$(interfaces.TID)&ifname:txt=blah $(#) $(<>) $(@) foo&mtu:u32=$(@)"; Note the three-variable expansion in ifname. This expands the way you'd expect: [ 19518 +62 unexpanded_xrl.cc ] XRL expanded to fea/ifmgr/0.1/set_mtu?tid:u32=0&ifname:txt=blah 10200000000 : 3 foo&mtu:u32=3 Now be careful you don't go and put any & into your variables, or I've no idea what will happen. I've only tested this in no-execute mode, so it's possible there will be some issue trapped by the XRL library, but I don't see why that would be. Revision Changes Path 1.54 +35 -12; commitid: a82d42d0280c7ea6; xorp/rtrmgr/template_commands.cc 1.27 +3 -1; commitid: a82d42d0280c7ea6; xorp/rtrmgr/template_commands.hh From mjh@icir.org Mon Jul 11 00:14:44 2005 From: mjh@icir.org (Mark Handley) Date: Sun, 10 Jul 2005 23:14:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507102314.j6ANEiJ9060168@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-10 23:14:44 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree_node.cc template_base_command.cc template_tree_node.cc Log message: Connect up the %allow-operator command. If the allow operator command is not specified, the only operator allowed on a node is ":". Example: %allow_operator: "<" ">" "==" "!=" This allows the operator set to be constrained to only those that are meaningful for a specific node. Revision Changes Path 1.14 +32 -1; commitid: eae442d1ab557ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.5 +2 -2; commitid: eae442d1ab557ea6; xorp/rtrmgr/template_base_command.cc 1.45 +3 -1; commitid: eae442d1ab557ea6; xorp/rtrmgr/template_tree_node.cc From bms@spc.org Mon Jul 11 09:40:48 2005 From: bms@spc.org (Bruce M Simpson) Date: Mon, 11 Jul 2005 09:40:48 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200507091947.j69JlfdL043610@xorpc.icir.org> References: <200507091947.j69JlfdL043610@xorpc.icir.org> Message-ID: <20050711084048.GB1049@empiric.icir.org> On Sat, Jul 09, 2005 at 07:47:41PM +0000, Mark Handley wrote: > Now the following works (hacking an existing XRL for test purposes): > > %set: xrl "$(interfaces.targetname)/ifmgr/0.1/set_mtu?tid:u32=$(interfaces.TID)&ifname:txt=blah $(#) $(<>) $(@) foo&mtu:u32=$(@)"; > > Note the three-variable expansion in ifname. This expands the way you'd expect: > > [ 19518 +62 unexpanded_xrl.cc ] XRL expanded to fea/ifmgr/0.1/set_mtu?tid:u32=0&ifname:txt=blah 10200000000 : 3 foo&mtu:u32=3 > > Now be careful you don't go and put any & into your variables, or I've > no idea what will happen. Hopefully there aren't any Win32 NDIS drivers out there which name their adapter instances with a & in the stem string. I haven't seen any in the wild that I can think of. Can we support UTF-8 for 'txt' values? FriendlyNames are meant to be unicode, but Microsoft's APIs for dealing with them are inconsistent; some calls are ASCII only. BMS From mjh@icir.org Mon Jul 11 19:29:13 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 11 Jul 2005 18:29:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507111829.j6BITDH7073012@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-11 18:29:13 UTC XORP CVS repository Modified files: rtrmgr y.boot_tab.cc y.boot_tab.h y.opcmd_tab.cc y.opcmd_tab.h y.tplt_tab.cc y.tplt_tab.h Log message: Regenerate yacc output on a FreeBSD 4.x system. - Mark Revision Changes Path 1.22 +65 -33; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.boot_tab.cc 1.8 +4 -0; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.boot_tab.h 1.19 +65 -33; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.opcmd_tab.cc 1.6 +4 -0; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.opcmd_tab.h 1.22 +65 -33; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.tplt_tab.cc 1.7 +4 -0; commitid: 11d1142d2ba637ea6; xorp/rtrmgr/y.tplt_tab.h From pavlin@icir.org Mon Jul 11 22:33:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 21:33:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112133.j6BLXuM6075484@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 21:33:56 UTC XORP CVS repository Modified files: rtrmgr template_tree.cc Log message: Minor edits. Revision Changes Path 1.33 +9 -10; commitid: 126c342d2e5bf7ea6; xorp/rtrmgr/template_tree.cc From pavlin@icir.org Mon Jul 11 22:49:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 21:49:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112149.j6BLnUX9075717@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 21:49:30 UTC XORP CVS repository Modified files: rtrmgr main_rtrmgr.cc master_template_tree.cc master_template_tree.hh master_template_tree_node.cc master_template_tree_node.hh module_command.cc module_command.hh template_commands.cc template_commands.hh Log message: * Add support for post-processing the template tree after all template files have been loaded. Previously, the template files processing was done on-the-fly in the order the template files were read (i.e., in alphabetical order). For example, all actions per module were created on the fly in the order they were read from the template files. This created a problem with declaring actions in one module that are related to some other module. The success for such declaration would depend on the alphabetical ordering of the template files. Now the post-processing of the template tree eliminates this problem. * Add support for checking the the module-specific methods (the startup, shutdown, status method, etc) during the check_template_tree() step when the rtrmgr is started. Revision Changes Path 1.61 +5 -1; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/main_rtrmgr.cc 1.3 +9 -2; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/master_template_tree.cc 1.3 +3 -2; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/master_template_tree.hh 1.3 +61 -5; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/master_template_tree_node.cc 1.4 +2 -1; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/master_template_tree_node.hh 1.33 +61 -1; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/module_command.cc 1.23 +4 -1; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/module_command.hh 1.55 +65 -22; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/template_commands.cc 1.28 +7 -3; commitid: 126ee42d2e5cf7ea6; xorp/rtrmgr/template_commands.hh From pavlin@icir.org Mon Jul 11 23:09:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 22:09:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112209.j6BM9iEG076107@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 22:09:44 UTC XORP CVS repository Modified files: rtrmgr template_base_command.cc Log message: Update a parse error message inside AllowOperatorsCommand::add_action() to match the code. Revision Changes Path 1.6 +2 -2; commitid: 1291642d2edfe7ea6; xorp/rtrmgr/template_base_command.cc From pavlin@icir.org Mon Jul 11 23:10:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 22:10:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112210.j6BMAvgS076205@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 22:10:57 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc Log message: printf() -> debug_msg() Revision Changes Path 1.46 +3 -3; commitid: 1299342d2ee6b7ea6; xorp/rtrmgr/template_tree_node.cc From mjh@icir.org Mon Jul 11 23:50:34 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 11 Jul 2005 22:50:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112250.j6BMoYal076849@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-11 22:50:34 UTC XORP CVS repository Modified files: rtrmgr template.ll Log message: Transplant much better string scanner from boot.ll to template.ll This should mean the lexical analyzer will allow just about any string, including newlines, and backslash-escaped newlines. Hopefully this fixes Andrea's problem with ";" in xrl templates. Bug found by: Andrea Revision Changes Path 1.14 +36 -5; commitid: 12c0342d2f7537ea6; xorp/rtrmgr/template.ll From mjh@icir.org Mon Jul 11 23:51:33 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 11 Jul 2005 22:51:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112251.j6BMpXpq076898@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-11 22:51:33 UTC XORP CVS repository Modified files: rtrmgr lex.boot.cc lex.opcmd.cc lex.tplt.cc Log message: Regenerate Revision Changes Path 1.15 +0 -0; commitid: 12c4542d2f7d37ea6; xorp/rtrmgr/lex.boot.cc 1.14 +0 -0; commitid: 12c4542d2f7d37ea6; xorp/rtrmgr/lex.opcmd.cc 1.15 +6860 -6795; commitid: 12c4542d2f7d37ea6; xorp/rtrmgr/lex.tplt.cc From pavlin@icir.org Tue Jul 12 00:11:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 23:11:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112311.j6BNBjeb077256@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 23:11:45 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc template_commands.hh Log message: Update ProgramAction::check_program_is_valid() to use mode_stack when parsing the program action (similar to the recent changes to XrlAction::check_xrl_is_valid()). Revision Changes Path 1.56 +22 -13; commitid: 12d8942d2fc417ea6; xorp/rtrmgr/template_commands.cc 1.29 +3 -3; commitid: 12d8942d2fc417ea6; xorp/rtrmgr/template_commands.hh From pavlin@icir.org Tue Jul 12 00:14:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 11 Jul 2005 23:14:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507112314.j6BNEqos077350@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-11 23:14:52 UTC XORP CVS repository Modified files: rtrmgr main_rtrmgr.cc master_template_tree.cc master_template_tree.hh Log message: Add new method MasterTemplateTree::load_template_tree() that loads, expands, and checks the template tree. Thus, when a master template tree is created, we need to call only MasterTemplateTree::load_template_tree() instead of calling several methods. This fixes a failure in test_sample_config that was introduced with the previous commit. Bug found by: Mark Handley Revision Changes Path 1.62 +1 -9; commitid: 12df242d2fcc37ea6; xorp/rtrmgr/main_rtrmgr.cc 1.4 +17 -1; commitid: 12df242d2fcc37ea6; xorp/rtrmgr/master_template_tree.cc 1.4 +5 -3; commitid: 12df242d2fcc37ea6; xorp/rtrmgr/master_template_tree.hh From a.bittau@cs.ucl.ac.uk Mon Jul 11 14:42:15 2005 From: a.bittau@cs.ucl.ac.uk (Andrea Bittau) Date: Mon, 11 Jul 2005 06:42:15 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <20050711084048.GB1049@empiric.icir.org> References: <200507091947.j69JlfdL043610@xorpc.icir.org> <20050711084048.GB1049@empiric.icir.org> Message-ID: <20050711134215.GB11661@tribal.sorbonet.org> > > Now be careful you don't go and put any & into your variables, or I've > > no idea what will happen. > > Can we support UTF-8 for 'txt' values? FriendlyNames are meant to be unicode, > but Microsoft's APIs for dealing with them are inconsistent; some calls are > ASCII only. I think it may become necessary to be able to put any type of character in these XRL commands. I was suggesting maybe allowing them to be escaped with \ or allow a %HEX syntax [like %20 for space] like in URLs. For unicode I guess we can use %XXXX style syntax. Today I will test this feature with the policy. I hope the current code allows characters such as =, +, *, (, ) which will be needed right from the start. From abittau@icir.org Tue Jul 12 01:47:54 2005 From: abittau@icir.org (Andrea Bittau) Date: Tue, 12 Jul 2005 00:47:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/policy xorp/policy/test xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507120047.j6C0lsn5007784@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-12 00:47:54 UTC XORP CVS repository Modified files: etc/templates bgp.tp policy.tp static_routes.tp policy configuration.cc configuration.hh lex.yy_policy_parser.cc parser.cc parser.hh policy.l policy.y policy_parser.hh policy_target.cc policy_target.hh term.cc term.hh xrl_target.cc xrl_target.hh yacc.yy_policy_parser.cc policy/test compilepolicy.hh compilepolicy.l compilepolicy.y lex.yy_compile_policy.cc policy1.src policy2.src yacc.yy_compile_policy.cc yacc.yy_compile_policy.cc.h xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Removed files: etc/templates policy_bgp.tp Log message: New policy interface. This actually looks very close to the "ultimate" one. i.e. a position and a statement. The only fix which remains is to transmit the position [line number] as a u64 and not a txt. Revision Changes Path 1.42 +194 -1; commitid: 1db942d312d67ea6; xorp/etc/templates/bgp.tp 1.6 +13 -13; commitid: 1db942d312d67ea6; xorp/etc/templates/policy.tp 1.3 +0 -215 xorp/etc/templates/policy_bgp.tp (dead) 1.19 +3 -3; commitid: 1db942d312d67ea6; xorp/etc/templates/static_routes.tp 1.6 +3 -5; commitid: 1db942d312d67ea6; xorp/policy/configuration.cc 1.5 +3 -7; commitid: 1db942d312d67ea6; xorp/policy/configuration.hh 1.4 +106 -96; commitid: 1db942d312d67ea6; xorp/policy/lex.yy_policy_parser.cc 1.3 +7 -12; commitid: 1db942d312d67ea6; xorp/policy/parser.cc 1.3 +6 -4; commitid: 1db942d312d67ea6; xorp/policy/parser.hh 1.4 +18 -18; commitid: 1db942d312d67ea6; xorp/policy/policy.l 1.3 +0 -7; commitid: 1db942d312d67ea6; xorp/policy/policy.y 1.3 +7 -7; commitid: 1db942d312d67ea6; xorp/policy/policy_parser.hh 1.5 +3 -5; commitid: 1db942d312d67ea6; xorp/policy/policy_target.cc 1.5 +3 -7; commitid: 1db942d312d67ea6; xorp/policy/policy_target.hh 1.10 +28 -29; commitid: 1db942d312d67ea6; xorp/policy/term.cc 1.8 +22 -19; commitid: 1db942d312d67ea6; xorp/policy/term.hh 1.2 +2 -7; commitid: 1db942d312d67ea6; xorp/policy/test/compilepolicy.hh 1.3 +23 -26; commitid: 1db942d312d67ea6; xorp/policy/test/compilepolicy.l 1.3 +6 -13; commitid: 1db942d312d67ea6; xorp/policy/test/compilepolicy.y 1.3 +1235 -1188; commitid: 1db942d312d67ea6; xorp/policy/test/lex.yy_compile_policy.cc 1.4 +3 -3; commitid: 1db942d312d67ea6; xorp/policy/test/policy1.src 1.3 +4 -4; commitid: 1db942d312d67ea6; xorp/policy/test/policy2.src 1.4 +40 -49; commitid: 1db942d312d67ea6; xorp/policy/test/yacc.yy_compile_policy.cc 1.3 +1 -1; commitid: 1db942d312d67ea6; xorp/policy/test/yacc.yy_compile_policy.cc.h 1.5 +3 -6; commitid: 1db942d312d67ea6; xorp/policy/xrl_target.cc 1.5 +2 -4; commitid: 1db942d312d67ea6; xorp/policy/xrl_target.hh 1.5 +35 -38; commitid: 1db942d312d67ea6; xorp/policy/yacc.yy_policy_parser.cc 1.5 +5 -7; commitid: 1db942d312d67ea6; xorp/xrl/interfaces/policy.xif 1.7 +3 -7; commitid: 1db942d312d67ea6; xorp/xrl/interfaces/policy_xif.cc 1.6 +4 -11; commitid: 1db942d312d67ea6; xorp/xrl/interfaces/policy_xif.hh 1.7 +4 -9; commitid: 1db942d312d67ea6; xorp/xrl/targets/policy.xrls 1.7 +4 -6; commitid: 1db942d312d67ea6; xorp/xrl/targets/policy_base.cc 1.7 +4 -11; commitid: 1db942d312d67ea6; xorp/xrl/targets/policy_base.hh From mjh@icir.org Tue Jul 12 20:12:23 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 12 Jul 2005 19:12:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507121912.j6CJCNKD028222@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-12 19:12:22 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Don't ask for operators on tags when comparing nodes. This fixes the problem Andrea has with loading configs. Bug found by: Andrea Revision Changes Path 1.73 +5 -3; commitid: 6e2542d415e57ea6; xorp/rtrmgr/conf_tree_node.cc From abittau@icir.org Tue Jul 12 23:07:24 2005 From: abittau@icir.org (Andrea Bittau) Date: Tue, 12 Jul 2005 22:07:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy xorp/policy/backend xorp/policy/common Message-ID: <200507122207.j6CM7Oic037933@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-12 22:07:24 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc etc/templates bgp.tp policy lex.yy_policy_parser.cc policy.l policy.y visitor_semantic.cc yacc.yy_policy_parser.cc yacc.yy_policy_parser.cc.h policy/backend backend.l backend.y lex.yy_policy_backend_parser.cc yacc.yy_policy_backend_parser.cc yacc.yy_policy_backend_parser.cc.h policy/common elem_null.hh operator.hh register_operations.cc Log message: * Users can't set as-path directly... rather only through as-path-prepend and as-path-expand. * Added an operator "head" in the policy language which takes the head of a "list/set". [i wouldn't mind implementing a functional language in the backend ;D ] * TODO: need to refactor [use factory for creating operators, etc]. Revision Changes Path 1.9 +10 -6; commitid: 932042d43ebf7ea6; xorp/bgp/bgp_varrw.cc 1.43 +15 -10; commitid: 932042d43ebf7ea6; xorp/etc/templates/bgp.tp 1.2 +9 -24; commitid: 932042d43ebf7ea6; xorp/policy/backend/backend.l 1.2 +2 -16; commitid: 932042d43ebf7ea6; xorp/policy/backend/backend.y 1.2 +139 -138; commitid: 932042d43ebf7ea6; xorp/policy/backend/lex.yy_policy_backend_parser.cc 1.2 +63 -58; commitid: 932042d43ebf7ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc 1.2 +11 -10; commitid: 932042d43ebf7ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc.h 1.3 +2 -1; commitid: 932042d43ebf7ea6; xorp/policy/common/elem_null.hh 1.3 +12 -13; commitid: 932042d43ebf7ea6; xorp/policy/common/operator.hh 1.4 +45 -36; commitid: 932042d43ebf7ea6; xorp/policy/common/register_operations.cc 1.5 +1132 -1089; commitid: 932042d43ebf7ea6; xorp/policy/lex.yy_policy_parser.cc 1.5 +8 -4; commitid: 932042d43ebf7ea6; xorp/policy/policy.l 1.4 +3 -2; commitid: 932042d43ebf7ea6; xorp/policy/policy.y 1.5 +2 -1; commitid: 932042d43ebf7ea6; xorp/policy/visitor_semantic.cc 1.6 +113 -99; commitid: 932042d43ebf7ea6; xorp/policy/yacc.yy_policy_parser.cc 1.3 +19 -18; commitid: 932042d43ebf7ea6; xorp/policy/yacc.yy_policy_parser.cc.h From pavlin@icir.org Tue Jul 12 23:22:33 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 12 Jul 2005 22:22:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507122222.j6CMMXCX057413@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-12 22:22:33 UTC XORP CVS repository Modified files: rtrmgr boot.ll lex.boot.cc lex.opcmd.cc lex.tplt.cc template.ll Log message: * Fix the lex rule for parsing C-style quoted newlines. This eliminates the printing of few bogus '\' during the startup of xorpsh and the rtrmgr. * Don't increment the line number when a C-style quoted newline is encountered inside the text, because the line number in the original file is same. * Add few comments. Revision Changes Path 1.23 +4 -2; commitid: e00142d442067ea6; xorp/rtrmgr/boot.ll 1.16 +2094 -2092; commitid: e00142d442067ea6; xorp/rtrmgr/lex.boot.cc 1.15 +0 -0; commitid: e00142d442067ea6; xorp/rtrmgr/lex.opcmd.cc 1.16 +6045 -6041; commitid: e00142d442067ea6; xorp/rtrmgr/lex.tplt.cc 1.15 +4 -2; commitid: e00142d442067ea6; xorp/rtrmgr/template.ll From mjh@icir.org Wed Jul 13 18:44:08 2005 From: mjh@icir.org (Mark Handley) Date: Wed, 13 Jul 2005 17:44:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507131744.j6DHi8oT081790@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-13 17:44:08 UTC XORP CVS repository Modified files: rtrmgr boot.ll boot.yy config_operators.cc config_operators.hh lex.boot.cc lex.opcmd.cc lex.tplt.cc template_base_command.cc y.boot_tab.cc y.boot_tab.h Log message: Allow all config operators on all types of terminal node. The choice of operator should be made by what is specified in an %allow-operator command (":" is still the default) rather than hardwired in the parser. This should allow the use of operators to modify communities, which Andrea needs to do. Revision Changes Path 1.24 +7 -15; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/boot.ll 1.20 +38 -75; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/boot.yy 1.2 +8 -14; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/config_operators.cc 1.3 +6 -6; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/config_operators.hh 1.17 +7422 -7437; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/lex.boot.cc 1.16 +0 -0; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/lex.opcmd.cc 1.17 +0 -0; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/lex.tplt.cc 1.7 +2 -6; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/template_base_command.cc 1.23 +122 -175; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/y.boot_tab.cc 1.9 +3 -4; commitid: 13ed942d5525c7ea6; xorp/rtrmgr/y.boot_tab.h From bms@spc.org Wed Jul 13 16:22:54 2005 From: bms@spc.org (Bruce M Simpson) Date: Wed, 13 Jul 2005 16:22:54 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200507111829.j6BITDH7073012@xorpc.icir.org> References: <200507111829.j6BITDH7073012@xorpc.icir.org> Message-ID: <20050713152254.GA820@empiric.icir.org> On Mon, Jul 11, 2005 at 06:29:13PM +0000, Mark Handley wrote: > Log message: > Regenerate yacc output on a FreeBSD 4.x system. There are a few interesting hacks which are needed to not break the build on Win32 when regenerating bison and flex generated files. I'll try to summarise later; currently I'm working on Windows specific I/O event dispatch. BMS From abittau@icir.org Wed Jul 13 22:58:41 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 13 Jul 2005 21:58:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy xorp/policy/backend xorp/policy/common Message-ID: <200507132158.j6DLwfaC002008@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-13 21:58:41 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc bgp_varrw.hh path_attribute.cc path_attribute.hh etc/templates bgp.tp policy lex.yy_policy_parser.cc policy.l policy.y yacc.yy_policy_parser.cc yacc.yy_policy_parser.cc.h policy/backend backend.l backend.y lex.yy_policy_backend_parser.cc yacc.yy_policy_backend_parser.cc yacc.yy_policy_backend_parser.cc.h policy/common dispatcher.cc elem_set.cc elem_set.hh operator.hh policy_utils.cc policy_utils.hh register_operations.cc register_operations.hh Log message: * Initial support for BGP communities in policy. * Support for an interesting operator called "ctr". It takes 2 arguments. A string representing the type to be constructed, and any type of element to construct it from. Think of it as a cast---powerful but dangerous. Currently used to construct sets from strings [communities in BGP are sets but entered as strings in configuration]. * Coming soon: prefix lists, aspath lists, and community lists. Revision Changes Path 1.10 +45 -3; commitid: 73842d58e0b7ea6; xorp/bgp/bgp_varrw.cc 1.8 +16 -1; commitid: 73842d58e0b7ea6; xorp/bgp/bgp_varrw.hh 1.58 +11 -1; commitid: 73842d58e0b7ea6; xorp/bgp/path_attribute.cc 1.34 +2 -1; commitid: 73842d58e0b7ea6; xorp/bgp/path_attribute.hh 1.44 +16 -5; commitid: 73842d58e0b7ea6; xorp/etc/templates/bgp.tp 1.3 +4 -0; commitid: 73842d58e0b7ea6; xorp/policy/backend/backend.l 1.3 +3 -1; commitid: 73842d58e0b7ea6; xorp/policy/backend/backend.y 1.3 +121 -101; commitid: 73842d58e0b7ea6; xorp/policy/backend/lex.yy_policy_backend_parser.cc 1.3 +47 -31; commitid: 73842d58e0b7ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc 1.3 +12 -10; commitid: 73842d58e0b7ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc.h 1.5 +28 -3; commitid: 73842d58e0b7ea6; xorp/policy/common/dispatcher.cc 1.3 +74 -23; commitid: 73842d58e0b7ea6; xorp/policy/common/elem_set.cc 1.3 +26 -5; commitid: 73842d58e0b7ea6; xorp/policy/common/elem_set.hh 1.4 +5 -1; commitid: 73842d58e0b7ea6; xorp/policy/common/operator.hh 1.4 +2 -1; commitid: 73842d58e0b7ea6; xorp/policy/common/policy_utils.cc 1.3 +2 -1; commitid: 73842d58e0b7ea6; xorp/policy/common/policy_utils.hh 1.5 +55 -14; commitid: 73842d58e0b7ea6; xorp/policy/common/register_operations.cc 1.3 +17 -1; commitid: 73842d58e0b7ea6; xorp/policy/common/register_operations.hh 1.6 +1097 -1082; commitid: 73842d58e0b7ea6; xorp/policy/lex.yy_policy_parser.cc 1.6 +3 -0; commitid: 73842d58e0b7ea6; xorp/policy/policy.l 1.5 +5 -3; commitid: 73842d58e0b7ea6; xorp/policy/policy.y 1.7 +149 -117; commitid: 73842d58e0b7ea6; xorp/policy/yacc.yy_policy_parser.cc 1.4 +20 -18; commitid: 73842d58e0b7ea6; xorp/policy/yacc.yy_policy_parser.cc.h From mjh@icir.org Thu Jul 14 01:08:30 2005 From: mjh@icir.org (Mark Handley) Date: Thu, 14 Jul 2005 00:08:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507140008.j6E08U8H015185@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-14 00:08:30 UTC XORP CVS repository Modified files: rtrmgr task.cc template_commands.cc template_commands.hh unexpanded_xrl.cc Log message: Complete re-write of the code to expand variables in Xrls. Previously the code used Xrl quoting to quote variables, but this didn't work if the template provided part of the value. The new code builds up an Xrl an atom at a time, and supports escaping (with a "\") of special characters like &, so then can be included in the template of an without confusing the Xrl constructor. Hopefully this allows Andrea to include "+" again in Xrl templates. This is a pretty complex piece of code, and we don't have much test coverage over this, so there may well be bugs. Let me know if you see anything odd... Revision Changes Path 1.52 +16 -43; commitid: 3afa42d5ab637ea6; xorp/rtrmgr/task.cc 1.57 +196 -53; commitid: 3afa42d5ab637ea6; xorp/rtrmgr/template_commands.cc 1.30 +8 -1; commitid: 3afa42d5ab637ea6; xorp/rtrmgr/template_commands.hh 1.13 +7 -1; commitid: 3afa42d5ab637ea6; xorp/rtrmgr/unexpanded_xrl.cc From pavlin@icir.org Thu Jul 14 02:10:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 14 Jul 2005 01:10:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200507140110.j6E1AN7v029959@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-14 01:10:23 UTC XORP CVS repository Modified files: policy/common dispatcher.cc Log message: Include header file to fix a compilation problem with gcc-2.95.x on FreeBSD-4.10 Revision Changes Path 1.6 +5 -2; commitid: 707a42d5bb567ea6; xorp/policy/common/dispatcher.cc From atanu@icir.org Thu Jul 14 02:48:08 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 14 Jul 2005 01:48:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/tools xorp/cli xorp/fea xorp/fib2mrib xorp/libcomm xorp/libfeaclient xorp/libproto xorp/libxipc xorp/libxorp xorp/mibs xorp/mld6igmp xorp/pim xorp/policy xorp/rib xorp/rip xorp/rtrmgr xorp/static_routes Message-ID: <200507140148.j6E1m8G2053292@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-14 01:48:08 UTC XORP CVS repository Modified files: bgp bgp_module.h bgp/tools bgptools_module.h cli cli_module.h fea fea_module.h mfea_module.h fib2mrib fib2mrib_module.h libcomm comm_module.h libfeaclient libfeaclient_module.h libproto libproto_module.h libxipc finder_module.h ipc_module.h xrl_module.h libxorp libxorp_module.h mibs bgp4_mib_module.h xorp_if_module.h xorp_netsnmp_module.h mld6igmp mld6igmp_module.h pim pim_module.h policy policy_module.h rib rib_module.h rip rip_module.h rtrmgr rtrmgr_module.h static_routes static_routes_module.h Log message: The defines 'XORP_MODULE_NAME' and 'XORP_MODULE_VERSION' will only be defined in the header files if they have not already been defined. This should allow the setting of these defines in Makefile. As well as making it easier for code to shared between directories. Revision Changes Path 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/bgp/bgp_module.h 1.5 +10 -2; commitid: cea242d5c44a7ea6; xorp/bgp/tools/bgptools_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/cli/cli_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/fea/fea_module.h 1.4 +9 -2; commitid: cea242d5c44a7ea6; xorp/fea/mfea_module.h 1.4 +9 -2; commitid: cea242d5c44a7ea6; xorp/fib2mrib/fib2mrib_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/libcomm/comm_module.h 1.5 +6 -1; commitid: cea242d5c44a7ea6; xorp/libfeaclient/libfeaclient_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/libproto/libproto_module.h 1.9 +8 -1; commitid: cea242d5c44a7ea6; xorp/libxipc/finder_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/libxipc/ipc_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/libxipc/xrl_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/libxorp/libxorp_module.h 1.5 +10 -2; commitid: cea242d5c44a7ea6; xorp/mibs/bgp4_mib_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/mibs/xorp_if_module.h 1.4 +9 -2; commitid: cea242d5c44a7ea6; xorp/mibs/xorp_netsnmp_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/mld6igmp/mld6igmp_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/pim/pim_module.h 1.5 +10 -1; commitid: cea242d5c44a7ea6; xorp/policy/policy_module.h 1.4 +9 -2; commitid: cea242d5c44a7ea6; xorp/rib/rib_module.h 1.4 +9 -1; commitid: cea242d5c44a7ea6; xorp/rip/rip_module.h 1.5 +9 -2; commitid: cea242d5c44a7ea6; xorp/rtrmgr/rtrmgr_module.h 1.4 +9 -2; commitid: cea242d5c44a7ea6; xorp/static_routes/static_routes_module.h From pavlin@icir.org Thu Jul 14 03:21:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 14 Jul 2005 02:21:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/xorpdev_101 Message-ID: <200507140221.j6E2Lutp054155@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-14 02:21:56 UTC XORP CVS repository Modified files: docs/xorpdev_101 xorpdev_101.tex Log message: Update the sample code from the "static_routes_module.h" file. Revision Changes Path 1.12 +5 -1; commitid: d37242d5cc307ea6; xorp/docs/xorpdev_101/xorpdev_101.tex From pavlin@icir.org Thu Jul 14 03:26:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 14 Jul 2005 02:26:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/tools xorp/cli xorp/contrib/ospfd/xorp xorp/fea xorp/fib2mrib xorp/libfeaclient xorp/libproto xorp/libxipc xorp/libxorp xorp/mibs xorp/mld6igmp xorp/mrt xorp/pim xorp/policy xorp/rib xorp/rip xorp/rtrmgr ... Message-ID: <200507140226.j6E2QQ6k054638@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-14 02:26:26 UTC XORP CVS repository Modified files: bgp bgp_module.h bgp/tools bgptools_module.h cli cli_module.h contrib/ospfd/xorp ospf_module.h fea fea_module.h mfea_module.h fib2mrib fib2mrib_module.h libfeaclient libfeaclient_module.h libproto libproto_module.h libxipc finder_module.h ipc_module.h xrl_module.h libxorp libxorp_module.h mibs bgp4_mib_module.h xorp_if_module.h xorp_netsnmp_module.h mld6igmp mld6igmp_module.h mrt mrt_module.h pim pim_module.h policy policy_module.h rib rib_module.h rip rip_module.h rtrmgr rtrmgr_module.h static_routes static_routes_module.h Log message: * Fix some of the names in the #ifndef ... #define ... #endif header wrappers to match the file name. * Use C-style comments instead of C++ style comments. * Conditionally define XORP_MODULE_NAME and XORP_MODULE_VERSION in few remaining files (mrt_module.h and ospf_module.h). Revision Changes Path 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/bgp/bgp_module.h 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/bgp/tools/bgptools_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/cli/cli_module.h 1.6 +9 -2; commitid: d3a242d5cc727ea6; xorp/contrib/ospfd/xorp/ospf_module.h 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/fea/fea_module.h 1.5 +2 -2; commitid: d3a242d5cc727ea6; xorp/fea/mfea_module.h 1.5 +2 -2; commitid: d3a242d5cc727ea6; xorp/fib2mrib/fib2mrib_module.h 1.6 +2 -3; commitid: d3a242d5cc727ea6; xorp/libfeaclient/libfeaclient_module.h 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/libproto/libproto_module.h 1.10 +2 -2; commitid: d3a242d5cc727ea6; xorp/libxipc/finder_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/libxipc/ipc_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/libxipc/xrl_module.h 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/libxorp/libxorp_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/mibs/bgp4_mib_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/mibs/xorp_if_module.h 1.5 +2 -2; commitid: d3a242d5cc727ea6; xorp/mibs/xorp_netsnmp_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/mld6igmp/mld6igmp_module.h 1.5 +9 -2; commitid: d3a242d5cc727ea6; xorp/mrt/mrt_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/pim/pim_module.h 1.6 +4 -4; commitid: d3a242d5cc727ea6; xorp/policy/policy_module.h 1.5 +2 -2; commitid: d3a242d5cc727ea6; xorp/rib/rib_module.h 1.5 +2 -2; commitid: d3a242d5cc727ea6; xorp/rip/rip_module.h 1.6 +2 -2; commitid: d3a242d5cc727ea6; xorp/rtrmgr/rtrmgr_module.h 1.5 +4 -4; commitid: d3a242d5cc727ea6; xorp/static_routes/static_routes_module.h From pavlin@icir.org Thu Jul 14 19:37:27 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 14 Jul 2005 18:37:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507141837.j6EIbRB8053976@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-14 18:37:27 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc Log message: * Fix the logic inside XrlAction::expand_vars() for expanding variables that are within '`'. * Minor nits. Bug found by: Andrea Bittau Revision Changes Path 1.58 +19 -17; commitid: d23742d6af157ea6; xorp/rtrmgr/template_commands.cc From abittau@icir.org Thu Jul 14 20:37:17 2005 From: abittau@icir.org (Andrea Bittau) Date: Thu, 14 Jul 2005 19:37:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507141937.j6EJbHgL055068@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-14 19:37:16 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc Log message: fix a bug in the parsing of xrl arguments. If the argument contained multiple = or : the parsing would fail. Revision Changes Path 1.59 +3 -1; commitid: d6fe42d6beba7ea6; xorp/rtrmgr/template_commands.cc From mjh@icir.org Fri Jul 15 00:21:56 2005 From: mjh@icir.org (Mark Handley) Date: Thu, 14 Jul 2005 23:21:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507142321.j6ENLujh057389@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-07-14 23:21:56 UTC XORP CVS repository Modified files: rtrmgr template_commands.cc Log message: Explicitly xrl encode the xrl args before creating an XrlAtom. For reasons best known to itself, an XrlAtom constructor assumes the value passed to it is already Xrl encoded. It then proceeds to decode it. Thus we have to pre-encode it so it can decode it. Odd. Revision Changes Path 1.60 +5 -3; commitid: dfdd42d6f3017ea6; xorp/rtrmgr/template_commands.cc From abittau@icir.org Fri Jul 15 03:27:12 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 15 Jul 2005 02:27:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy xorp/policy/backend xorp/policy/common xorp/policy/test xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200507150227.j6F2RCJ4059575@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-15 02:27:12 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc etc/templates bgp.tp policy.tp policy code_generator.cc code_generator.hh configuration.cc configuration.hh filter_manager.cc node.hh policy.y policy_target.cc policy_target.hh set_map.cc set_map.hh source_match_code_generator.cc source_match_code_generator.hh var_map.cc visitor.hh visitor_printer.cc visitor_printer.hh visitor_semantic.cc visitor_semantic.hh visitor_setdep.cc visitor_setdep.hh xrl_target.cc xrl_target.hh yacc.yy_policy_parser.cc policy/backend backend.y instr_visitor.hh instruction.hh iv_exec.cc iv_exec.hh policytags.cc yacc.yy_policy_backend_parser.cc policy/common elem_set.cc elem_set.hh element.hh element_factory.cc element_factory.hh policy_utils.cc policy_utils.hh register_elements.cc register_elements.hh register_operations.cc policy/test compilepolicy.y policy1.var policy2.var yacc.yy_compile_policy.cc xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Log message: * Support for sets of different types. - Strictly speaking, they aren't sets anymore... but rather references. Anywhere in the policy configuration you may create such a "set/reference" of any type. This may be reference from any policy statement by using the SET operator. * Initial support for route lists, community lists, and aspath lists. NEXT: route pushing! Revision Changes Path 1.11 +8 -10; commitid: e79642d71e727ea6; xorp/bgp/bgp_varrw.cc 1.45 +41 -7; commitid: e79642d71e727ea6; xorp/etc/templates/bgp.tp 1.7 +21 -14; commitid: e79642d71e727ea6; xorp/etc/templates/policy.tp 1.4 +5 -8; commitid: e79642d71e727ea6; xorp/policy/backend/backend.y 1.3 +2 -9; commitid: e79642d71e727ea6; xorp/policy/backend/instr_visitor.hh 1.3 +2 -72; commitid: e79642d71e727ea6; xorp/policy/backend/instruction.hh 1.4 +40 -39; commitid: e79642d71e727ea6; xorp/policy/backend/iv_exec.cc 1.4 +1 -7; commitid: e79642d71e727ea6; xorp/policy/backend/iv_exec.hh 1.3 +11 -9; commitid: e79642d71e727ea6; xorp/policy/backend/policytags.cc 1.4 +62 -65; commitid: e79642d71e727ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc 1.5 +40 -36; commitid: e79642d71e727ea6; xorp/policy/code_generator.cc 1.3 +2 -6; commitid: e79642d71e727ea6; xorp/policy/code_generator.hh 1.4 +99 -42; commitid: e79642d71e727ea6; xorp/policy/common/elem_set.cc 1.4 +59 -29; commitid: e79642d71e727ea6; xorp/policy/common/elem_set.hh 1.3 +18 -2; commitid: e79642d71e727ea6; xorp/policy/common/element.hh 1.4 +7 -1; commitid: e79642d71e727ea6; xorp/policy/common/element_factory.cc 1.3 +6 -29; commitid: e79642d71e727ea6; xorp/policy/common/element_factory.hh 1.5 +40 -8; commitid: e79642d71e727ea6; xorp/policy/common/policy_utils.cc 1.4 +10 -1; commitid: e79642d71e727ea6; xorp/policy/common/policy_utils.hh 1.3 +33 -64; commitid: e79642d71e727ea6; xorp/policy/common/register_elements.cc 1.3 +5 -1; commitid: e79642d71e727ea6; xorp/policy/common/register_elements.hh 1.6 +74 -54; commitid: e79642d71e727ea6; xorp/policy/common/register_operations.cc 1.7 +9 -3; commitid: e79642d71e727ea6; xorp/policy/configuration.cc 1.6 +4 -2; commitid: e79642d71e727ea6; xorp/policy/configuration.hh 1.3 +35 -25; commitid: e79642d71e727ea6; xorp/policy/filter_manager.cc 1.4 +2 -40; commitid: e79642d71e727ea6; xorp/policy/node.hh 1.6 +1 -3; commitid: e79642d71e727ea6; xorp/policy/policy.y 1.6 +5 -7; commitid: e79642d71e727ea6; xorp/policy/policy_target.cc 1.6 +5 -3; commitid: e79642d71e727ea6; xorp/policy/policy_target.hh 1.4 +7 -8; commitid: e79642d71e727ea6; xorp/policy/set_map.cc 1.3 +5 -3; commitid: e79642d71e727ea6; xorp/policy/set_map.hh 1.5 +4 -3; commitid: e79642d71e727ea6; xorp/policy/source_match_code_generator.cc 1.4 +5 -6; commitid: e79642d71e727ea6; xorp/policy/source_match_code_generator.hh 1.4 +6 -5; commitid: e79642d71e727ea6; xorp/policy/test/compilepolicy.y 1.3 +1 -1; commitid: e79642d71e727ea6; xorp/policy/test/policy1.var 1.3 +1 -1; commitid: e79642d71e727ea6; xorp/policy/test/policy2.var 1.5 +36 -33; commitid: e79642d71e727ea6; xorp/policy/test/yacc.yy_compile_policy.cc 1.5 +6 -2; commitid: e79642d71e727ea6; xorp/policy/var_map.cc 1.4 +2 -9; commitid: e79642d71e727ea6; xorp/policy/visitor.hh 1.2 +1 -10; commitid: e79642d71e727ea6; xorp/policy/visitor_printer.cc 1.2 +1 -2; commitid: e79642d71e727ea6; xorp/policy/visitor_printer.hh 1.6 +6 -27; commitid: e79642d71e727ea6; xorp/policy/visitor_semantic.cc 1.3 +2 -16; commitid: e79642d71e727ea6; xorp/policy/visitor_semantic.hh 1.4 +20 -28; commitid: e79642d71e727ea6; xorp/policy/visitor_setdep.cc 1.3 +2 -18; commitid: e79642d71e727ea6; xorp/policy/visitor_setdep.hh 1.6 +5 -3; commitid: e79642d71e727ea6; xorp/policy/xrl_target.cc 1.6 +3 -2; commitid: e79642d71e727ea6; xorp/policy/xrl_target.hh 1.8 +100 -100; commitid: e79642d71e727ea6; xorp/policy/yacc.yy_policy_parser.cc 1.6 +3 -2; commitid: e79642d71e727ea6; xorp/xrl/interfaces/policy.xif 1.8 +3 -1; commitid: e79642d71e727ea6; xorp/xrl/interfaces/policy_xif.cc 1.7 +4 -1; commitid: e79642d71e727ea6; xorp/xrl/interfaces/policy_xif.hh 1.8 +4 -2; commitid: e79642d71e727ea6; xorp/xrl/targets/policy.xrls 1.8 +4 -3; commitid: e79642d71e727ea6; xorp/xrl/targets/policy_base.cc 1.8 +4 -1; commitid: e79642d71e727ea6; xorp/xrl/targets/policy_base.hh From pavlin@icir.org Fri Jul 15 06:59:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 05:59:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507150559.j6F5xawd062318@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 05:59:36 UTC XORP CVS repository Modified files: rtrmgr xrl_rtrmgr_interface.cc Log message: Modify the ordering for sending various info by the rtrmgr to its clients (i.e., xorpsh). Now the rtrmgr sends first the module status info, and then the configuration. Previously, the rtrmgr was sending first the configuration, and then the module status. However, this created a race condition in the xorpsh during startup. Xorpsh would receive first the configuration, which would trigger its state to become "ready" for accepting commands from the user. Soon after that it would receive the status about which modules are running, but in the mean time the xorpsh operational commands for those modules weren't available. If xorpsh is running in interactive mode, the very short delay during startup is practically unnoticeable, but it becomes a problem if xorpsh is running in non-interactive mode (e.g., as part of UNIX pipe, etc). Revision Changes Path 1.39 +28 -18; commitid: f2eb42d74ed07ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc From pavlin@icir.org Fri Jul 15 07:04:40 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 06:04:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507150604.j6F64eCu062580@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 06:04:40 UTC XORP CVS repository Modified files: rtrmgr op_commands.cc op_commands.hh op_commands.yy y.opcmd_tab.cc Log message: Add mechnanism to test the OpCommandList instance whether it is "done" (i.e., there are no more running operational commands). Revision Changes Path 1.48 +30 -4; commitid: f45142d751bf7ea6; xorp/rtrmgr/op_commands.cc 1.26 +8 -2; commitid: f45142d751bf7ea6; xorp/rtrmgr/op_commands.hh 1.13 +1 -1; commitid: f45142d751bf7ea6; xorp/rtrmgr/op_commands.yy 1.20 +1 -1; commitid: f45142d751bf7ea6; xorp/rtrmgr/y.opcmd_tab.cc From pavlin@icir.org Fri Jul 15 07:33:22 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 06:33:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/rtrmgr Message-ID: <200507150633.j6F6XMP2063323@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 06:33:22 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_node.cc cli_node.hh cli_node_net.cc rtrmgr cli.cc cli.hh xorpsh_main.cc xorpsh_main.hh Log message: Fix the xorpsh so now it can be run in non-interactive mode. Now xorpsh can be used as following in non-interactive mode: (1) As part of UNIX command-line pipes. E.g.: echo "show host os" | ./xorpsh cat filename | ./xorpsh ./xorpsh < filename (2) As part of a shell script. E.g.: #!/bin/sh ./xorpsh < ') child.sendline('show host os') child.sendeof() while 1: line = child.readline() if not line: break print line, child.close() Some of the high-level changes are: * Now the CLI library makes cleaner distinction whether the CliClient is a network connection (i.e., telnet) or corresponds to a tty. * Now the CliClient has two separate file descriptors: one for reading the commands, and one for writing the output. * If more input data is received while a previous command is hasn't completed execution, the new data is buffered inside the CLI library for later processing. However, we always check the data for Ctrl-C, and if found we stop the currently executed program and discard the buffered input data. * Improve some of the CLI library API for creating CliClient instances. * Modify xorpsh so it uses the new imroved CLI API. * Implement a new -c "command(s)" xorpsh command-line option for executing xorpsh commands. Internally, it is implemented by opening a pipe(2): the CliClient reads from one side of the pipe, while the command(s) are written to the other side of the pipe. * Improve the xorpsh shutdown logic. E.g., now it won't exit if there are still running operational commands. Note that there are still few more things that need polishing. E.g., if xorpsh is running in non-interactive mode, then it should automatically suppress its internal pager for long command outputs, etc. [Some of the above changes are based on a patch by "Michael Larson" ] Revision Changes Path 1.30 +94 -33; commitid: f50142d7528e7ea6; xorp/cli/cli_client.cc 1.16 +62 -18; commitid: f50142d7528e7ea6; xorp/cli/cli_client.hh 1.26 +18 -5; commitid: f50142d7528e7ea6; xorp/cli/cli_node.cc 1.19 +19 -9; commitid: f50142d7528e7ea6; xorp/cli/cli_node.hh 1.37 +185 -75; commitid: f50142d7528e7ea6; xorp/cli/cli_node_net.cc 1.70 +130 -112; commitid: f50142d7528e7ea6; xorp/rtrmgr/cli.cc 1.30 +7 -3; commitid: f50142d7528e7ea6; xorp/rtrmgr/cli.hh 1.43 +108 -25; commitid: f50142d7528e7ea6; xorp/rtrmgr/xorpsh_main.cc 1.24 +8 -4; commitid: f50142d7528e7ea6; xorp/rtrmgr/xorpsh_main.hh From pavlin@icir.org Fri Jul 15 07:39:09 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 06:39:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507150639.j6F6d9iX063503@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 06:39:08 UTC XORP CVS repository Modified files: rtrmgr xorpsh_main.cc xorpsh_main.hh Log message: Move the XrlXorpshInterface field member inside the XorpShell class to be the last field member of that class. This fixes initialization problem for the XrlXorpshInterface::_verbose flag. Revision Changes Path 1.44 +3 -3; commitid: f7ef42d7598e7ea6; xorp/rtrmgr/xorpsh_main.cc 1.25 +4 -2; commitid: f7ef42d7598e7ea6; xorp/rtrmgr/xorpsh_main.hh From pavlin@icir.org Fri Jul 15 07:48:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 06:48:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507150648.j6F6mQvr063725@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 06:48:26 UTC XORP CVS repository Modified files: libxorp asyncio.cc Log message: Replace XLOG_WARNING messages inside is_pseudo_error() with debug_msg(). There is no need to pring a warning message if, say, a read(2) or write(2) were interrupted, because they will be restarted by the libxorp async I/O facility. Revision Changes Path 1.16 +3 -3; commitid: f87c42d75b257ea6; xorp/libxorp/asyncio.cc From pavlin@icir.org Fri Jul 15 08:05:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 07:05:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507150705.j6F75TTU063993@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 07:05:29 UTC XORP CVS repository Modified files: cli cli_node.cc cli_node.hh Log message: * Add a flag to enable XLOG_TRACE() output * Replace XLOG_INFO() messages with XLOG_TRACE() when we start/stop/enable/disable the CliNode, because this information is not really useful when CliNode is used as part of some process/module. Revision Changes Path 1.27 +7 -6; commitid: f9ba42d75fbc7ea6; xorp/cli/cli_node.cc 1.20 +28 -1; commitid: f9ba42d75fbc7ea6; xorp/cli/cli_node.hh From pavlin@icir.org Fri Jul 15 10:34:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 09:34:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507150934.j6F9YIGK065720@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 09:34:18 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_command_pipe.cc cli_node_net.cc Log message: * Replace method CliClient::is_tty() with is_input_tty() and is_output_tty() that apply for the input and output respectively. * Add new method CliClient::is_interactive() that returns true if CliClient is run in interactive mode. * If the CliClient is not in interactive mode, then the CliClient is automatically in "no-more" mode for the printed output. The above modifications now allow to run xorpsh in non-interactive mode without requiring that each command with potentially long output must be run like "foo | no-more". Revision Changes Path 1.31 +20 -2; commitid: 1008342d782227ea6; xorp/cli/cli_client.cc 1.17 +18 -2; commitid: 1008342d782227ea6; xorp/cli/cli_client.hh 1.8 +3 -2; commitid: 1008342d782227ea6; xorp/cli/cli_command_pipe.cc 1.38 +5 -5; commitid: 1008342d782227ea6; xorp/cli/cli_node_net.cc From abittau@icir.org Fri Jul 15 18:03:41 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 15 Jul 2005 17:03:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/backend xorp/policy/common Message-ID: <200507151703.j6FH3exk072493@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-15 17:03:40 UTC XORP CVS repository Modified files: policy/backend policytags.cc policy/common policy_utils.cc Log message: fix compilation on some systems [gcc 2.95] Revision Changes Path 1.4 +21 -16; commitid: 11aff42d7ec5c7ea6; xorp/policy/backend/policytags.cc 1.6 +2 -1; commitid: 11aff42d7ec5c7ea6; xorp/policy/common/policy_utils.cc From pavlin@icir.org Fri Jul 15 20:38:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 15 Jul 2005 19:38:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/pim Message-ID: <200507151938.j6FJc56w074308@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-15 19:38:05 UTC XORP CVS repository Modified files: pim pim_proto.h pim_proto_hello.cc Log message: Remove the definition and usage of PIM_HELLO_ADDRESS_LIST_PRIVATE_OPTION (defined to have value of 65001 from the private option space). Previously PIM Hello option 65001 has been used by Cisco and pim6sd to send the list of secondary addresses per interface. The lastest PIM-SM I-D defines option 24 for this purpose (which we have implemented already). Previously we accepted the 65001 option so we could talk with pim6sd and IPv6 Cisco, but recent versions of those implementations already implement the spec-defined option 24. It is not worth to continue dealing with 65001, because currently both pim6sd and Cisco send the same secondary addresses twice (inside option 24 and then again inside option 65001). Dealing with duplicated secondary addresses spread across different options is going to complicate the implementation, and anyway in the long run we don't want to deal with options from the private numbering space. Revision Changes Path 1.15 +1 -2; commitid: 121e942d80e5e7ea6; xorp/pim/pim_proto.h 1.22 +1 -2; commitid: 121e942d80e5e7ea6; xorp/pim/pim_proto_hello.cc From abittau@icir.org Sat Jul 16 00:37:31 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 15 Jul 2005 23:37:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy Message-ID: <200507152337.j6FNbVEC076641@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-15 23:37:31 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc etc/templates bgp.tp policy.tp static_routes.tp policy term.cc Log message: * Change %create to %set in templates. This allows modifying an existing policy directive and actually making it work. i.e. changing localpref: 123 to localpref: 100 will work... without needing to delete localpref and re-create it. * If a line is not empty and written to, previously it is an error. Now it isn't. The old line is replaced with the new one. This is necessary in order for %set to work. * Get rid of an unref() of subnet route in the bgp varrw. This could mean that there is a memory leak if policies are configured. However, hopefully route pushing / modification in BGP will be solved next week. The reason I did this is because it now seems to "work". I can modify, for example, MEDs on import filters without crashing. Revision Changes Path 1.12 +4 -3; commitid: 12ad242d848197ea6; xorp/bgp/bgp_varrw.cc 1.46 +32 -32; commitid: 12ad242d848197ea6; xorp/etc/templates/bgp.tp 1.8 +8 -8; commitid: 12ad242d848197ea6; xorp/etc/templates/policy.tp 1.20 +2 -2; commitid: 12ad242d848197ea6; xorp/etc/templates/static_routes.tp 1.11 +10 -2; commitid: 12ad242d848197ea6; xorp/policy/term.cc From pavlin@icir.org Sat Jul 16 01:27:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 16 Jul 2005 00:27:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200507160027.j6G0RSop077334@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-16 00:27:28 UTC XORP CVS repository Modified files: policy visitor_semantic.cc Log message: Use XORP_UINT_CAST() to fix a compilation error on MacOS X 10.4 with gcc-4.0 Revision Changes Path 1.7 +2 -2; commitid: 12df842d854517ea6; xorp/policy/visitor_semantic.cc From pavlin@icir.org Sat Jul 16 02:56:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 16 Jul 2005 01:56:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200507160156.j6G1uaZi078194@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-16 01:56:36 UTC XORP CVS repository Modified files: fea xrl_socket_server.cc Log message: * Modify the return error message inside valid_addr_port() to include the problematic address or port. * Sync the IPv6 socket-related code with the IPv4 version. This fixes few IPv6-related bugs with checking the local_addr when the local_addr is IPv6::ANY() (e.g., when RIPng tries to bind to UDP socket). Bug found by: Marko Zec Revision Changes Path 1.24 +28 -8; commitid: 1312142d867407ea6; xorp/fea/xrl_socket_server.cc From pavlin@icir.org Mon Jul 18 22:26:55 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 18 Jul 2005 21:26:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli/tools Message-ID: <200507182126.j6ILQtUi022830@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-18 21:26:55 UTC XORP CVS repository Modified files: cli/tools send_cli_processor_xrl.cc Log message: If the command failed, then exit with exit code of 1. Revision Changes Path 1.7 +29 -11; commitid: 58f042dc1e827ea6; xorp/cli/tools/send_cli_processor_xrl.cc From pavlin@icir.org Mon Jul 18 22:32:53 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 18 Jul 2005 21:32:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507182132.j6ILWrqG023424@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-18 21:32:53 UTC XORP CVS repository Modified files: rtrmgr task.cc task.hh Log message: Fix the ProgramFoo destructors to cleanup the RunCommand instance leftovers. Revision Changes Path 1.53 +27 -2; commitid: 5b2642dc1fce7ea6; xorp/rtrmgr/task.cc 1.33 +4 -4; commitid: 5b2642dc1fce7ea6; xorp/rtrmgr/task.hh From pavlin@icir.org Mon Jul 18 22:35:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 18 Jul 2005 21:35:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507182135.j6ILZcsv023752@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-18 21:35:38 UTC XORP CVS repository Modified files: rtrmgr cli.cc op_commands.cc op_commands.hh Log message: Update the OpInstance implementation so now it uses the RunCommand class (instead of its own internal implementation) to run external commands. Revision Changes Path 1.71 +4 -5; commitid: 5c5242dc20717ea6; xorp/rtrmgr/cli.cc 1.49 +81 -150; commitid: 5c5242dc20717ea6; xorp/rtrmgr/op_commands.cc 1.27 +19 -27; commitid: 5c5242dc20717ea6; xorp/rtrmgr/op_commands.hh From pavlin@icir.org Mon Jul 18 22:56:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 18 Jul 2005 21:56:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507182156.j6ILuQN8025295@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-18 21:56:25 UTC XORP CVS repository Modified files: etc/templates misc.cmds Log message: Fix the comment for the traceroute command. Revision Changes Path 1.4 +4 -4; commitid: 62a742dc257b7ea6; xorp/etc/templates/misc.cmds From pavlin@icir.org Mon Jul 18 23:29:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 18 Jul 2005 22:29:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507182229.j6IMTIH8025729@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-18 22:29:18 UTC XORP CVS repository Modified files: rtrmgr op_commands.cc op_commands.hh Log message: Fix the mechanism for tracking the number of existing OpCommand instances. Revision Changes Path 1.50 +17 -5; commitid: 645c42dc2d207ea6; xorp/rtrmgr/op_commands.cc 1.28 +2 -1; commitid: 645c42dc2d207ea6; xorp/rtrmgr/op_commands.hh From pavlin@icir.org Tue Jul 19 08:08:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 19 Jul 2005 07:08:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/rtrmgr Message-ID: <200507190708.j6J78I9V072949@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-19 07:08:18 UTC XORP CVS repository Modified files: cli cli_command.hh cli_command.cc rtrmgr cli.cc cli.hh op_commands.cc op_commands.hh Log message: Add new class CliCommandMatch and use it to pass information around about CliCommand nodes (e.g., when using callbacks to dynamically add children nodes on-the-fly). This allows us to pass more information about child CliCommand nodes, and to set properly some of their properties (e.g., whether a CliCommand node is executable, etc). The above change fixes a bug with the executional permissions of some commands. E.g., previously a command like, say, "show igmp interface" was allowed to be dispatched even though the IGMP module was not running. Revision Changes Path 1.15 +14 -17; commitid: 11c5d42dca5987ea6; xorp/cli/cli_command.cc 1.13 +23 -5; commitid: 11c5d42dca5987ea6; xorp/cli/cli_command.hh 1.72 +84 -51; commitid: 11c5d42dca5987ea6; xorp/rtrmgr/cli.cc 1.31 +5 -10; commitid: 11c5d42dca5987ea6; xorp/rtrmgr/cli.hh 1.51 +31 -35; commitid: 11c5d42dca5987ea6; xorp/rtrmgr/op_commands.cc 1.29 +3 -7; commitid: 11c5d42dca5987ea6; xorp/rtrmgr/op_commands.hh From pavlin@icir.org Wed Jul 20 00:16:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 19 Jul 2005 23:16:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200507192316.j6JNGUEd084056@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-19 23:16:30 UTC XORP CVS repository Modified files: docs/user_manual cli_intro.tex Log message: Added a section that describes running xorpsh in non-interactive mode. Revision Changes Path 1.5 +68 -1; commitid: 1483f42dd89bf7ea6; xorp/docs/user_manual/cli_intro.tex From pavlin@icir.org Wed Jul 20 00:17:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 19 Jul 2005 23:17:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200507192317.j6JNHcXT084107@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-19 23:17:38 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Added release notes for xorpsh and CLI. Revision Changes Path 1.80 +3 -3; commitid: 1487242dd8a077ea6; xorp/RELEASE_NOTES From pavlin@icir.org Wed Jul 20 00:36:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 19 Jul 2005 23:36:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507192336.j6JNa6iY084273@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-19 23:36:06 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh Log message: Added a new method CliClient::done() that returns true when the processing of any pending commands or pending data has completed. Revision Changes Path 1.32 +13 -1; commitid: 1490042dd8df27ea6; xorp/cli/cli_client.cc 1.18 +11 -2; commitid: 1490042dd8df27ea6; xorp/cli/cli_client.hh From pavlin@icir.org Wed Jul 20 00:38:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 19 Jul 2005 23:38:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507192338.j6JNcPFD084328@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-19 23:38:25 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh xorpsh_main.cc Log message: Added a new method RouterCLI::done() and use it during shutdown before exiting. Now xorpsh can be used in non-interactive mode to configure the router. Revision Changes Path 1.73 +13 -1; commitid: 1494b42dd8e8b7ea6; xorp/rtrmgr/cli.cc 1.32 +2 -1; commitid: 1494b42dd8e8b7ea6; xorp/rtrmgr/cli.hh 1.45 +2 -2; commitid: 1494b42dd8e8b7ea6; xorp/rtrmgr/xorpsh_main.cc From abittau@icir.org Wed Jul 20 02:29:24 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 20 Jul 2005 01:29:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/policy xorp/policy/backend xorp/policy/common Message-ID: <200507200129.j6K1TOml096229@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-20 01:29:24 UTC XORP CVS repository Modified files: bgp bgp.hh bgp_varrw.cc bgp_varrw.hh bgp_varrw_export.cc route_table_filter.cc route_table_policy.cc route_table_policy_im.cc subnet_route.cc subnet_route.hh policy node.hh policy/backend Makefile.am Makefile.in policy_filter.hh policy_filters.cc policy_filters.hh single_varrw.cc policy/common element.hh varrw.cc varrw.hh Added files: policy/backend filter_base.hh version_filter.cc version_filter.hh version_filters.cc version_filters.hh Log message: Initial support for filters with versions. Basically its like the other policy filters, but the filter will frist read from the route a pointer to a filter to execute, and it will run that. It is up to the routes / implementor of varmap, to keep these pointers reference counted. Once the reference count reaches 0, the filter will be destroyed. If a route has a filter of 0, it will be assigned the latest filter. BGP now uses these filters. TODO: proper route pushing in BGP! Revision Changes Path 1.42 +3 -3; commitid: 1776542dda87f7ea6; xorp/bgp/bgp.hh 1.13 +59 -2; commitid: 1776542dda87f7ea6; xorp/bgp/bgp_varrw.cc 1.9 +3 -1; commitid: 1776542dda87f7ea6; xorp/bgp/bgp_varrw.hh 1.2 +2 -1; commitid: 1776542dda87f7ea6; xorp/bgp/bgp_varrw_export.cc 1.30 +3 -1; commitid: 1776542dda87f7ea6; xorp/bgp/route_table_filter.cc 1.7 +108 -4; commitid: 1776542dda87f7ea6; xorp/bgp/route_table_policy.cc 1.5 +39 -8; commitid: 1776542dda87f7ea6; xorp/bgp/route_table_policy_im.cc 1.17 +20 -1; commitid: 1776542dda87f7ea6; xorp/bgp/subnet_route.cc 1.18 +7 -2; commitid: 1776542dda87f7ea6; xorp/bgp/subnet_route.hh 1.5 +7 -2; commitid: 1776542dda87f7ea6; xorp/policy/backend/Makefile.am 1.8 +7 -2; commitid: 1776542dda87f7ea6; xorp/policy/backend/Makefile.in 1.1 +56 -0 xorp/policy/backend/filter_base.hh (new) 1.4 +7 -3; commitid: 1776542dda87f7ea6; xorp/policy/backend/policy_filter.hh 1.4 +24 -8; commitid: 1776542dda87f7ea6; xorp/policy/backend/policy_filters.cc 1.4 +7 -5; commitid: 1776542dda87f7ea6; xorp/policy/backend/policy_filters.hh 1.5 +4 -1; commitid: 1776542dda87f7ea6; xorp/policy/backend/single_varrw.cc 1.1 +87 -0 xorp/policy/backend/version_filter.cc (new) 1.1 +78 -0 xorp/policy/backend/version_filter.hh (new) 1.1 +31 -0 xorp/policy/backend/version_filters.cc (new) 1.1 +48 -0 xorp/policy/backend/version_filters.hh (new) 1.4 +15 -2; commitid: 1776542dda87f7ea6; xorp/policy/common/element.hh 1.2 +3 -1; commitid: 1776542dda87f7ea6; xorp/policy/common/varrw.cc 1.4 +3 -4; commitid: 1776542dda87f7ea6; xorp/policy/common/varrw.hh 1.5 +1 -3; commitid: 1776542dda87f7ea6; xorp/policy/node.hh From atanu@icir.org Wed Jul 20 02:33:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 20 Jul 2005 01:33:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/harness Message-ID: <200507200133.j6K1XFW2096333@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-20 01:33:15 UTC XORP CVS repository Modified files: bgp next_hop_resolver.cc next_hop_resolver.hh bgp/harness test_rib_fea1.sh Log message: Changing the nexthop associated with a route was causing a de-registration failure with the RIB. The tests "test5" and "test6" demonstrate this problem. Update1: Route1 - NextHop1 Update2: Route1 - NextHop2 Nexthop1: does not resolve. Nexthop2: resolves. Consider the following sequence of events: 1) Update1 causes a registration for NextHop1 with the RIB. 2) Update2 causes a registration for Nexthop2 with the RIB 3) Nexthop2 resolves so Route1 is sent as a route add to the RIB 4) Nexthop1 suddenly resolves as it falls within the Route1 subnet. 5) The RIB sends an invalidate to BGP. 6) Meanwhile BGP no longer has any interest in NextHop1 so de-registers interest. 7) The RIB no nolonger has any state about NextHop1 when the de-register arrives. It has just sent an invalidate. It returns an error. 8) The BGP receives the failed response from the de-register and then the invalidate. In BGP if a de-register fails expect to see an invalidate in the future. Previously the failed de-register was a fatal error. Very strangely even if NextHop1 does not fall within Route1 an invalidate is sent by the RIB which doesn't seem correct. This behaviour can be verified with "test6". Bug found by: Andrea Bittau Revision Changes Path 1.13 +96 -2; commitid: 1781b42dda9d97ea6; xorp/bgp/harness/test_rib_fea1.sh 1.42 +45 -5; commitid: 1781b42dda9d97ea6; xorp/bgp/next_hop_resolver.cc 1.28 +10 -1; commitid: 1781b42dda9d97ea6; xorp/bgp/next_hop_resolver.hh From pavlin@icir.org Wed Jul 20 02:55:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 20 Jul 2005 01:55:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507200155.j6K1t7jn097209@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-20 01:55:06 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: If we are deleting a subtree, then mark the whole subtree so later the scanning of the tree will invoke the appropriate method for each node. Note that this changes the %delete semantics for the rtrmgr template trees (per other developers' request). Now if a node that is deleted does not have a %delete command, then the %delete commands of its children are called instead. This rule is applied recursively for each child that does not have a %delete command. Previously, we had to add practically almost everywhere %delete methods (in each level of the template tree hierarchy) otherwise deleting a non-leaf node with no %delete method wouldn't invoke the %delete methods below it. Revision Changes Path 1.74 +7 -1; commitid: 17b6f42ddacd47ea6; xorp/rtrmgr/conf_tree_node.cc From pavlin@icir.org Wed Jul 20 02:57:02 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 20 Jul 2005 01:57:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200507200157.j6K1v2Nu097277@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-20 01:57:02 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: Add description of the new semantics of the %delete command. Revision Changes Path 1.34 +6 -1; commitid: 17be442ddaf5b7ea6; xorp/docs/rtrmgr/rtrmgr.tex From abittau@icir.org Wed Jul 20 03:06:28 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 20 Jul 2005 02:06:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/backend Message-ID: <200507200206.j6K26SEk097787@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-20 02:06:28 UTC XORP CVS repository Modified files: policy/backend version_filter.cc Log message: fix variable name clash, add typeinfo include Revision Changes Path 1.2 +3 -2; commitid: 17de242ddb1997ea6; xorp/policy/backend/version_filter.cc From atanu@icir.org Wed Jul 20 03:26:24 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 20 Jul 2005 02:26:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507200226.j6K2QOtw098135@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-20 02:26:24 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc Log message: Add typeinfo include. Revision Changes Path 1.14 +2 -1; commitid: 17f3c42ddb64e7ea6; xorp/bgp/bgp_varrw.cc From abittau@icir.org Wed Jul 20 17:23:12 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 20 Jul 2005 16:23:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507201623.j6KGNCxK035819@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-20 16:23:12 UTC XORP CVS repository Modified files: bgp route_table_policy_im.cc Log message: disable debug logging - I always seem to forget this... [sorry... but things are moving quite fast!] Revision Changes Path 1.6 +3 -3; commitid: 8bd242de7a607ea6; xorp/bgp/route_table_policy_im.cc From m.handley@cs.ucl.ac.uk Wed Jul 20 08:42:23 2005 From: m.handley@cs.ucl.ac.uk (Mark Handley) Date: Wed, 20 Jul 2005 08:42:23 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200507200155.j6K1t7jn097209@xorpc.icir.org> References: <200507200155.j6K1t7jn097209@xorpc.icir.org> Message-ID: <84a612dd0507200042200e21f5@mail.gmail.com> Sounds like this is different from the %delete-explicit behaviour I suggested before. - Marj On 7/20/05, Pavlin Radoslavov wrote: > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: pavlin@xorpc.icir.org 2005-07-20 01:55:06 UTC > > XORP CVS repository > > > Modified files: > rtrmgr conf_tree_node.cc > > Log message: > If we are deleting a subtree, then mark the whole subtree so > later the scanning of the tree will invoke the appropriate > method for each node. > > Note that this changes the %delete semantics for the rtrmgr template > trees (per other developers' request). > > Now if a node that is deleted does not have a %delete command, then > the %delete commands of its children are called instead. > This rule is applied recursively for each child that does not have > a %delete command. > > Previously, we had to add practically almost everywhere %delete methods > (in each level of the template tree hierarchy) otherwise deleting > a non-leaf node with no %delete method wouldn't invoke the %delete methods > below it. > > Revision Changes Path > 1.74 +7 -1; commitid: 17b6f42ddacd47ea6; xorp/rtrmgr/conf_tree_node.cc > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > From zec@icir.org Wed Jul 20 17:56:52 2005 From: zec@icir.org (Marko Zec) Date: Wed, 20 Jul 2005 16:56:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy/common Message-ID: <200507201656.j6KGuqK0036300@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-20 16:56:52 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc etc/templates bgp.tp policy/common elem_set.cc elem_set.hh element.cc element.hh register_elements.cc register_operations.cc Log message: Add a new "com32" element type in policy framework to allow for a more flexible specification of BGP communities. The preferred format is now in a MSW:LSW form, where MSW and LSW are 16-bit unsigned integers. MSW will typically take a value of an AS number. It is however still legal to specify a community without a ":" sign, in which case it will be interpreted as 32-bit unsigned int. The numbers can be specified in base 10 or in hex if prepended by an "0x" string. The three well-known communities specified in RFC1997 can be specified symbolically (the values are hardcoded): NO_EXPORT, NO_ADVERTISE, NO_EXPORT_SUBCONFED. TODO: update the docs. Revision Changes Path 1.15 +4 -4; commitid: 8cd342de7e717ea6; xorp/bgp/bgp_varrw.cc 1.47 +8 -8; commitid: 8cd342de7e717ea6; xorp/etc/templates/bgp.tp 1.5 +4 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/elem_set.cc 1.5 +2 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/elem_set.hh 1.4 +62 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/element.cc 1.5 +26 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/element.hh 1.4 +2 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/register_elements.cc 1.7 +12 -1; commitid: 8cd342de7e717ea6; xorp/policy/common/register_operations.cc From pavlin@icir.org Wed Jul 20 23:03:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 20 Jul 2005 22:03:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507202203.j6KM3gMx058983@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-20 22:03:41 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc template_tree_node.hh Log message: Added new method TemplateTreeNode::is_module_root_node() that returns true if this is the top-level template node for a module. Revision Changes Path 1.47 +16 -1; commitid: e64142deca057ea6; xorp/rtrmgr/template_tree_node.cc 1.29 +2 -1; commitid: e64142deca057ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Wed Jul 20 23:12:17 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 20 Jul 2005 22:12:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507202212.j6KMCHHP059121@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-20 22:12:17 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree_node.cc Log message: Modify some of the logic that considers whether a module is active. Previously, if we deleted practically all child nodes of the module then the module is considered non active anymore, and would be shutdown. For example, if we delete the last configured interface: "delete interfaces interface foo" then committing the deletion will shutdown module "interfaces". This may not be the desired intention so it is better not to shutdown the module. Now the above command will delete only interface foo, and module "interfaces" will continue running. If we really want to shutdown the module, the correct command is "delete interfaces". Bug found by: "Michael Larson" Revision Changes Path 1.15 +29 -8; commitid: e68d42deca4e7ea6; xorp/rtrmgr/master_conf_tree_node.cc From pavlin@icir.org Wed Jul 20 23:55:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 20 Jul 2005 15:55:45 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Mark Handley of "Wed, 20 Jul 2005 08:42:23 BST." <84a612dd0507200042200e21f5@mail.gmail.com> Message-ID: <200507202255.j6KMtjoB003045@possum.icir.org> > Sounds like this is different from the %delete-explicit behaviour I > suggested before. I don't know, because my memory is failing trying to recollect the %delete-explicit conversation, and I couldn't find any email that describes its behavior. Pavlin > > - Marj > > On 7/20/05, Pavlin Radoslavov wrote: > > CVSROOT: /usr/local/share/doc/apache/cvs > > Module name: xorp > > Changes by: pavlin@xorpc.icir.org 2005-07-20 01:55:06 UTC > > > > XORP CVS repository > > > > > > Modified files: > > rtrmgr conf_tree_node.cc > > > > Log message: > > If we are deleting a subtree, then mark the whole subtree so > > later the scanning of the tree will invoke the appropriate > > method for each node. > > > > Note that this changes the %delete semantics for the rtrmgr template > > trees (per other developers' request). > > > > Now if a node that is deleted does not have a %delete command, then > > the %delete commands of its children are called instead. > > This rule is applied recursively for each child that does not have > > a %delete command. > > > > Previously, we had to add practically almost everywhere %delete methods > > (in each level of the template tree hierarchy) otherwise deleting > > a non-leaf node with no %delete method wouldn't invoke the %delete methods > > below it. > > > > Revision Changes Path > > 1.74 +7 -1; commitid: 17b6f42ddacd47ea6; xorp/rtrmgr/conf_tree_node.cc > > _______________________________________________ > > Xorp-cvs mailing list > > Xorp-cvs@icir.org > > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > > > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From zec@icir.org Thu Jul 21 00:01:40 2005 From: zec@icir.org (Marko Zec) Date: Wed, 20 Jul 2005 23:01:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507202301.j6KN1e4E060758@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-20 23:01:40 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc Log message: Fix to properly support nonempty set intersection operator on communities Revision Changes Path 1.16 +3 -3; commitid: ecfa42ded7007ea6; xorp/bgp/bgp_varrw.cc From abittau@icir.org Thu Jul 21 00:35:10 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 20 Jul 2005 23:35:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/policy/backend Message-ID: <200507202335.j6KNZA3c061285@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-20 23:35:10 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc bgp_varrw.hh route_table_filter.cc route_table_policy.cc policy/backend policy_filter.cc Log message: Fix some bugs: * Propagate flags in static filters. * sync varrw in case of empty policies. Possibly introduced a memleak in bgp_varrw.cc in the case in which routes have only policytags / filter pointers updated. In this case, the is_changed() flags is not set, so the route won't be cached [as only "metarouting info" changed] [actually, maybe we should cache modified policytags?] Anyway, there have been discussions on re-designing the subnet route structure, so that should come soon and "solve" this. Revision Changes Path 1.17 +50 -34; commitid: eef142dedef67ea6; xorp/bgp/bgp_varrw.cc 1.10 +2 -1; commitid: eef142dedef67ea6; xorp/bgp/bgp_varrw.hh 1.31 +2 -1; commitid: eef142dedef67ea6; xorp/bgp/route_table_filter.cc 1.8 +28 -4; commitid: eef142dedef67ea6; xorp/bgp/route_table_policy.cc 1.4 +8 -2; commitid: eef142dedef67ea6; xorp/policy/backend/policy_filter.cc From pavlin@icir.org Thu Jul 21 10:01:51 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 21 Jul 2005 09:01:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507210901.j6L91pNl067120@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-21 09:01:51 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh Log message: * Changed the operational mode "show" command so now it doesn't show the parameters that have default values. Ideally, we would prefer that the "show" command shows all parameters that had their value explicitly set in the configuration file or interactively by xorpsh (even though those values are same as the default values). Implementing this may not be trivial, because the XRLs from the rtrmgr to the xorpsh clients contain the complete configuration (including the default values) as a single string. The problem is that the string with the configuration does not contain information where each parameter's value came from (e.g., from the configuration file, a default template value, or modified by another xorpsh user). The following bugzilla entry contains the request for the above enhancement: http://www.xorp.org/bugzilla/show_bug.cgi?id=144 * Added new operational command "show -all" that shows all configuration including the parameters with default values. Note that the particular choice of the command name ("show -all") is not final and may be changed to something else. Revision Changes Path 1.74 +82 -30; commitid: 104d342df5fbc7ea6; xorp/rtrmgr/cli.cc 1.37 +8 -5; commitid: 104d342df5fbc7ea6; xorp/rtrmgr/conf_tree.cc 1.24 +2 -2; commitid: 104d342df5fbc7ea6; xorp/rtrmgr/conf_tree.hh 1.75 +70 -28; commitid: 104d342df5fbc7ea6; xorp/rtrmgr/conf_tree_node.cc 1.39 +6 -2; commitid: 104d342df5fbc7ea6; xorp/rtrmgr/conf_tree_node.hh From pavlin@icir.org Thu Jul 21 10:06:21 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 21 Jul 2005 09:06:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200507210906.j6L96LFv067232@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-21 09:06:21 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Added release notes for xorpsh. Revision Changes Path 1.81 +8 -1; commitid: 1068742df65867ea6; xorp/RELEASE_NOTES From pavlin@icir.org Thu Jul 21 19:54:48 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 21 Jul 2005 18:54:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200507211854.j6LIsmHB085629@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-21 18:54:48 UTC XORP CVS repository Modified files: docs/user_manual cli_intro.tex Log message: * Update the documentation to reflect the fact that now the "show" command in configurational mode doesn't show the parameters that have default values. * Add a brief description of the "show -all" configurational mode command that shows all the configuration (including the parameters that have default values). * Replace "./xorpsh" with "xorpsh" in the examples when running xorpsh in non-interactive mode. Revision Changes Path 1.6 +37 -29; commitid: 14e5a42dfeef27ea6; xorp/docs/user_manual/cli_intro.tex From zec@icir.org Thu Jul 21 20:42:19 2005 From: zec@icir.org (Marko Zec) Date: Thu, 21 Jul 2005 19:42:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/policy/common Message-ID: <200507211942.j6LJgJrK086190@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-21 19:42:19 UTC XORP CVS repository Modified files: etc/templates bgp.tp policy/common register_operations.cc Log message: Allow the use of operators "==" "!=" "<" ">" "<=" ">=" for comparisson of communities (community sets). Note: looks like the operator "!=" breaks the rtrmgr parser so can't be used right now. Revision Changes Path 1.48 +3 -2; commitid: 1504942dff9987ea6; xorp/etc/templates/bgp.tp 1.8 +3 -3; commitid: 1504942dff9987ea6; xorp/policy/common/register_operations.cc From pavlin@icir.org Fri Jul 22 01:31:31 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 00:31:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507220031.j6M0VVTl088798@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 00:31:31 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc Log message: Bug fix: If the MasterConfigTree::commit_pass1_done() callback is called indicating a failure, then reset the _commit_in_progress flag. Otherwise, the rtrmgr is locked and no xorpsh instances can be started. This fixes the second half of Bugzilla entry #129 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=129 Revision Changes Path 1.54 +2 -1; commitid: 15a9242e03daa7ea6; xorp/rtrmgr/master_conf_tree.cc From abittau@icir.org Fri Jul 22 02:20:12 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 22 Jul 2005 01:20:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507220120.j6M1KCP9089547@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-22 01:20:12 UTC XORP CVS repository Modified files: bgp plumbing.cc route_table_policy_im.cc route_table_policy_sm.cc route_table_policy_sm.hh subnet_route.cc Log message: * some fixes in export policies. * background route dumping. Currently a policy route dump, will cause a delete followed by an add. I can get replace to work if I flag the internal message. Using the "clone route" trick won't work. Why? Because the cache table will spot the old route, and send its cached copy downstream, which has the correct parent pointer [same to the new route] which now has the null pointers in the new route. Doing it the other way around, i.e. cloning the new route, probably messes things up even more. Anyway... we will fix this soon, somehow. Next: MEMORY MANAGEMENT. Revision Changes Path 1.68 +3 -2; commitid: 15d4d42e049017ea6; xorp/bgp/plumbing.cc 1.7 +26 -48; commitid: 15d4d42e049017ea6; xorp/bgp/route_table_policy_im.cc 1.4 +33 -5; commitid: 15d4d42e049017ea6; xorp/bgp/route_table_policy_sm.cc 1.4 +13 -2; commitid: 15d4d42e049017ea6; xorp/bgp/route_table_policy_sm.hh 1.18 +3 -1; commitid: 15d4d42e049017ea6; xorp/bgp/subnet_route.cc From atanu@icir.org Fri Jul 22 02:41:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 22 Jul 2005 01:41:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200507220141.j6M1fJrM089882@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-22 01:41:19 UTC XORP CVS repository Modified files: rib register_server.cc rt_tab_register.cc Log message: Add debugging defines (commented out). Revision Changes Path 1.18 +3 -2; commitid: 15efd42e04ebd7ea6; xorp/rib/register_server.cc 1.27 +4 -1; commitid: 15efd42e04ebd7ea6; xorp/rib/rt_tab_register.cc From pavlin@icir.org Fri Jul 22 02:55:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 01:55:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220155.j6M1tFTr090165@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 01:55:15 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: * Remove "set-parameter" node because it is not needed anymore * Add missing type declaration for "as-path-list" and "community-list" inside node "policy policy-statement term source" Approved by: Atanu Ghosh, Andrea Bittau, Marko Zec Revision Changes Path 1.49 +3 -5; commitid: 15f8a42e04f2c7ea6; xorp/etc/templates/bgp.tp From pavlin@icir.org Fri Jul 22 03:00:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:00:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220200.j6M20niO090341@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:00:49 UTC XORP CVS repository Modified files: etc/templates policy.tp Log message: Replace %set with %create inside nodes "accept" and "reject", because those are statement nodes that don't have values. Approved by: Andrea Bittau, Atanu Ghosh Revision Changes Path 1.9 +3 -3; commitid: 160a242e052e67ea6; xorp/etc/templates/policy.tp From pavlin@icir.org Fri Jul 22 03:06:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:06:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220206.j6M26otj090443@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:06:50 UTC XORP CVS repository Modified files: etc/templates rip.tp Log message: * Fix some of the names of the leaf nodes, because there was a mismatch between the name in the declaration section and the action section: trigger-update-min-secs -> triggered-update-min-secs trigger-update-max-secs -> triggered-update-max-secs * Fix the "protocols rip interface vif address autnentication" node: replace the %set with %activate and %update methods, because %set should be used only for (leaf) nodes that have values that can be changed. This should fix a bug with modifying the RIP autnentication via xorpsh. Revision Changes Path 1.22 +5 -4; commitid: 1610442e053667ea6; xorp/etc/templates/rip.tp From pavlin@icir.org Fri Jul 22 03:09:58 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:09:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220209.j6M29woB090565@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:09:58 UTC XORP CVS repository Modified files: etc/templates ripng.tp Log message: * Fix some of the names of the leaf nodes, because there was a mismatch between the name in the declaration section and the action section: accept-non-ripng-requests -> accept-non-rip-requests trigger-update-min-secs -> triggered-update-min-secs trigger-update-max-secs -> triggered-update-max-secs Revision Changes Path 1.22 +4 -4; commitid: 1616d42e054ce7ea6; xorp/etc/templates/ripng.tp From pavlin@icir.org Fri Jul 22 03:12:21 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:12:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220212.j6M2CLCT090647@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:12:21 UTC XORP CVS repository Modified files: etc/templates pimsm4.tp pimsm6.tp Log message: Replace %set command with %create command inside the "alternative-subnet @" multi-value template node. A multi-value node cannot have a %set command inside, because its value is assigned when the node is created, but it cannot be modified later. Revision Changes Path 1.25 +2 -2; commitid: 161fc42e0559c7ea6; xorp/etc/templates/pimsm4.tp 1.25 +2 -2; commitid: 161fc42e0559c7ea6; xorp/etc/templates/pimsm6.tp From pavlin@icir.org Fri Jul 22 03:13:27 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:13:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507220213.j6M2DRFa090714@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:13:27 UTC XORP CVS repository Modified files: etc/templates rtrmgr.tp Log message: Remove empty %set commands inside the multi-value "load @" and "set @" template nodes. A multi-value node cannot have a %set command inside, because its value is assigned when the node is created, but it cannot be modified later. Revision Changes Path 1.2 +1 -9; commitid: 1623142e056187ea6; xorp/etc/templates/rtrmgr.tp From pavlin@icir.org Fri Jul 22 03:27:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:27:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200507220227.j6M2RIA2091063@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:27:18 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: Add extra explanation for the %set template command. Revision Changes Path 1.35 +9 -2; commitid: 1639e42e059787ea6; xorp/docs/rtrmgr/rtrmgr.tex From pavlin@icir.org Fri Jul 22 03:34:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:34:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507220234.j6M2YTvT091226@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:34:29 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc template_tree_node.cc template_tree_node.hh Log message: * Add new method TemplateTreeNode::is_leaf() * Use the above TemplateTreeNode::is_leaf() inside method ConfigTreeNode::is_leaf() Revision Changes Path 1.76 +2 -4; commitid: 1643842e05b0d7ea6; xorp/rtrmgr/conf_tree_node.cc 1.48 +10 -1; commitid: 1643842e05b0d7ea6; xorp/rtrmgr/template_tree_node.cc 1.30 +2 -1; commitid: 1643842e05b0d7ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Fri Jul 22 03:52:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 02:52:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507220252.j6M2qhQ3091530@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 02:52:43 UTC XORP CVS repository Modified files: rtrmgr master_template_tree_node.cc template_tree_node.cc Log message: Add explicit check for the %set command. The %set command only applies to leaf nodes that have values and only if the value is allowed to be changed. This fixes the first part of Bugzilla entry #129 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=129 Revision Changes Path 1.4 +17 -2; commitid: 1654542e05e177ea6; xorp/rtrmgr/master_template_tree_node.cc 1.49 +23 -6; commitid: 1654542e05e177ea6; xorp/rtrmgr/template_tree_node.cc From pavlin@icir.org Fri Jul 22 11:37:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 10:37:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507221037.j6MAb1x3097012@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 10:37:00 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc template_tree_node.hh Log message: Fix a NULL pointer problem in some of the default_str() methods. Now if the _default pointer is NULL, the default_str() method returns an empty string. Obtained from: "Marat Nepomnyashy" Revision Changes Path 1.50 +79 -34; commitid: 17a9642e0cb977ea6; xorp/rtrmgr/template_tree_node.cc 1.31 +6 -6; commitid: 17a9642e0cb977ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Fri Jul 22 11:47:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 10:47:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507221047.j6MAla6n097235@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 10:47:36 UTC XORP CVS repository Modified files: rtrmgr Makefile.am Makefile.in cli.cc cli.hh slave_conf_tree.cc slave_conf_tree.hh xorpsh_main.hh Added files: rtrmgr xorpsh_base.hh Log message: Split the XorpShell into two classes: abstract base class XorpShellBase and derived class XorpShell. This split makes it easier to reuse some of the xorpsh code. Obtained from: "Marat Nepomnyashy" Revision Changes Path 1.55 +2 -1; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/Makefile.am 1.67 +1 -1; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/Makefile.in 1.75 +9 -9; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/cli.cc 1.33 +8 -5; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/cli.hh 1.30 +8 -7; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/slave_conf_tree.cc 1.20 +8 -7; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/slave_conf_tree.hh 1.1 +95 -0 xorp/rtrmgr/xorpsh_base.hh (new) 1.26 +6 -25; commitid: 17b0e42e0cc7f7ea6; xorp/rtrmgr/xorpsh_main.hh From pavlin@icir.org Fri Jul 22 20:01:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 19:01:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507221901.j6MJ1OwJ004213@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 19:01:24 UTC XORP CVS repository Modified files: rtrmgr boot.yy y.boot_tab.cc Log message: Modify the configuration parser to accept literals that are strings surrounded by " " quotes. This allows us to specify, say, an interface name that contains spaces. E.g.: interfaces { interface "Friendly interface name" { description: "primary" vif eth65540 { address 10.10.10.10 { prefix-length: 24 } } } } Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=141 Revision Changes Path 1.21 +1 -0; commitid: 102342e141f27ea6; xorp/rtrmgr/boot.yy 1.24 +108 -101; commitid: 102342e141f27ea6; xorp/rtrmgr/y.boot_tab.cc From pavlin@icir.org Fri Jul 22 20:25:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 19:25:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200507221925.j6MJPsdT004495@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 19:25:54 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: Added an example that describes the %delete method's new semantics. Revision Changes Path 1.36 +6 -1; commitid: 117142e1482f7ea6; xorp/docs/rtrmgr/rtrmgr.tex From pavlin@icir.org Fri Jul 22 20:38:53 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 19:38:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507221938.j6MJcrMq004648@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 19:38:53 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc Log message: Change the invalid prefix length messages to use IPv4::addr_bitlen() and IPv6::addr_bitlen() instead of hard-coded values. Revision Changes Path 1.51 +5 -3; commitid: 120a42e14b187ea6; xorp/rtrmgr/template_tree_node.cc From pavlin@icir.org Fri Jul 22 22:43:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 22 Jul 2005 21:43:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507222143.j6MLhSQ7005945@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-22 21:43:28 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc Log message: * Fix TemplateTreeNode::check_variable_name() so now it checks that the variable name doesn't end at a tag. This fixes bugzilla entry #25 * Cosmetic refactoring of Fix TemplateTreeNode::check_variable_name() Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=25 Revision Changes Path 1.52 +46 -28; commitid: 172042e1680b7ea6; xorp/rtrmgr/template_tree_node.cc From abittau@icir.org Fri Jul 22 22:46:41 2005 From: abittau@icir.org (Andrea Bittau) Date: Fri, 22 Jul 2005 21:46:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507222146.j6MLkf2T006075@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-22 21:46:41 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc route_table_policy.cc route_table_policy_im.cc Log message: vague attempt to fix memory leaks in policy. Revision Changes Path 1.18 +24 -16; commitid: 179e42e169337ea6; xorp/bgp/bgp_varrw.cc 1.9 +16 -1; commitid: 179e42e169337ea6; xorp/bgp/route_table_policy.cc 1.8 +37 -2; commitid: 179e42e169337ea6; xorp/bgp/route_table_policy_im.cc From abittau@icir.org Sat Jul 23 01:32:05 2005 From: abittau@icir.org (Andrea Bittau) Date: Sat, 23 Jul 2005 00:32:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507230032.j6N0W5MX007953@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-23 00:32:05 UTC XORP CVS repository Modified files: bgp route_table_policy_im.cc Log message: quick fix for IBGP. Basically if you are pushing a non changed route, then send a delete followed by an add with that same route. i.e. no need to copy as cache table "ignores" non changed routes. Revision Changes Path 1.9 +4 -3; commitid: 1eeb42e18fbd7ea6; xorp/bgp/route_table_policy_im.cc From pavlin@icir.org Sat Jul 23 02:20:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 23 Jul 2005 01:20:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507230120.j6N1KuxV008503@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-23 01:20:56 UTC XORP CVS repository Modified files: rtrmgr master_template_tree_node.cc Log message: Modify an error message to print a slightly better info. Revision Changes Path 1.5 +4 -3; commitid: 211d42e19b5f7ea6; xorp/rtrmgr/master_template_tree_node.cc From pavlin@icir.org Sat Jul 23 02:22:13 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 23 Jul 2005 01:22:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507230122.j6N1MDMD008559@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-23 01:22:13 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh conf_tree.cc conf_tree_node.cc conf_tree_node.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_tree_node.cc template_tree_node.hh Log message: * Add an extra "include_leaf_value_nodes" argument to method SlaveConfigTreeNode::create_command_tree() and set its value as appropriate when creating the following subtrees in xorpsh configuration mode: "edit", "delete", "set", "show". This fixes Bugzilla entry 52 * Fix a bug when we attempt to create a leaf value node inside xorpsh, but we forget the value itself. Previously, xorpsh printed an error message, but didn't cleanup properly the temporary state. * Remove "%get" from the list of commands used to build the "show" subtree in xorpsh configuration mode, because we don't really use "%get". * Rename: - Argument "include_intermediates" to "include_intermediate_nodes" - Method "ConfigTreeNode::is_leaf()" to "is_leaf_value()" - Method "TemplateTreeNode::is_leaf()" to "is_leaf_value()" * Add few extra XLOG_ASSERT() Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=52 Revision Changes Path 1.76 +41 -28; commitid: 214342e19b897ea6; xorp/rtrmgr/cli.cc 1.34 +3 -3; commitid: 214342e19b897ea6; xorp/rtrmgr/cli.hh 1.38 +2 -2; commitid: 214342e19b897ea6; xorp/rtrmgr/conf_tree.cc 1.77 +8 -8; commitid: 214342e19b897ea6; xorp/rtrmgr/conf_tree_node.cc 1.40 +2 -2; commitid: 214342e19b897ea6; xorp/rtrmgr/conf_tree_node.hh 1.23 +21 -13; commitid: 214342e19b897ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.13 +7 -5; commitid: 214342e19b897ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.53 +7 -6; commitid: 214342e19b897ea6; xorp/rtrmgr/template_tree_node.cc 1.32 +4 -3; commitid: 214342e19b897ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Sat Jul 23 02:40:21 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 23 Jul 2005 01:40:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507230140.j6N1eLdW008787@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-23 01:40:21 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: Remove old code that has been "#if 0" for long time. Revision Changes Path 1.77 +1 -361; commitid: 222642e19ff67ea6; xorp/rtrmgr/cli.cc 1.35 +1 -44; commitid: 222642e19ff67ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Sun Jul 24 18:10:14 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 24 Jul 2005 17:10:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507241710.j6OHAEMt034946@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-24 17:10:14 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Modify the "show" command output: in configuration mode all deleted (and uncommitted) entries are prefixed with "-". This fixes bugzilla entry #68 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=68 Revision Changes Path 1.78 +29 -15; commitid: 885042e3caf57ea6; xorp/rtrmgr/conf_tree_node.cc From pavlin@icir.org Sun Jul 24 18:12:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 24 Jul 2005 17:12:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200507241712.j6OHCOLj034994@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-24 17:12:24 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Add a release note for xorpsh re. the modified configurational mode "show" output. Revision Changes Path 1.82 +4 -1; commitid: 889942e3cbce7ea6; xorp/RELEASE_NOTES From pavlin@icir.org Sun Jul 24 18:19:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 24 Jul 2005 17:19:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200507241719.j6OHJosR035104@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-24 17:19:50 UTC XORP CVS repository Modified files: docs/user_manual cli_intro.tex Log message: Document modification to the configuration mode "show" command output: all deleted (and uncommitted) entries are prefixed with "-". Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=68 Revision Changes Path 1.7 +13 -4; commitid: 890142e3cd527ea6; xorp/docs/user_manual/cli_intro.tex From zec@icir.org Mon Jul 25 08:08:18 2005 From: zec@icir.org (Marko Zec) Date: Mon, 25 Jul 2005 07:08:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507250708.j6P78IiB043529@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-25 07:08:18 UTC XORP CVS repository Modified files: libxorp ipnet.hh Added files: libxorp range.hh Log message: Add new (templatized) classes U32Range IPv4Range and IPv6Range. Intended use is in policy framework for checking whether a value is inside or outside a given range defined by lower and upper boundaries. Add operators to IPNet template for checking the prefix length against the newly defined U32Range class. Revision Changes Path 1.15 +68 -2; commitid: a98742e48db87ea6; xorp/libxorp/ipnet.hh 1.1 +175 -0 xorp/libxorp/range.hh (new) From zec@icir.org Mon Jul 25 08:11:01 2005 From: zec@icir.org (Marko Zec) Date: Mon, 25 Jul 2005 07:11:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507250711.j6P7B1j5043613@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-25 07:11:01 UTC XORP CVS repository Modified files: libxorp range.hh Log message: Hopefully fix the ID header line... Revision Changes Path 1.2 +1 -0; commitid: aa4442e4906a7ea6; xorp/libxorp/range.hh From zec@icir.org Mon Jul 25 08:23:03 2005 From: zec@icir.org (Marko Zec) Date: Mon, 25 Jul 2005 07:23:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507250723.j6P7N3D7043884@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-25 07:23:03 UTC XORP CVS repository Modified files: rtrmgr boot.ll boot.yy conf_tree.cc template.ll template.yy template_tree.cc template_tree_node.cc template_tree_node.hh Log message: Teach rtrmgr's parser about new syntax for expressing ranges. In other words, add support for: UINTRANGE_VALUE: [0-9]+".."[0-9]+ IPV4RANGE_VALUE: {RE_IPV4}".."{RE_IPV4} IPV6RANGE_VALUE: {RE_IPV6}".."{RE_IPV6} Only UINTRANGE syntax is verifyed to work properly at the moment. NOTE: gmake flex; gmake yacc has to be done in rtrmgr/ dir for changes to take effect. Revision Changes Path 1.25 +16 -1; commitid: aac742e491507ea6; xorp/rtrmgr/boot.ll 1.22 +18 -0; commitid: aac742e491507ea6; xorp/rtrmgr/boot.yy 1.39 +5 -1; commitid: aac742e491507ea6; xorp/rtrmgr/conf_tree.cc 1.16 +30 -0; commitid: aac742e491507ea6; xorp/rtrmgr/template.ll 1.16 +22 -0; commitid: aac742e491507ea6; xorp/rtrmgr/template.yy 1.34 +4 -1; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree.cc 1.54 +59 -1; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree_node.cc 1.33 +22 -2; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree_node.hh From zec@icir.org Mon Jul 25 08:37:19 2005 From: zec@icir.org (Marko Zec) Date: Mon, 25 Jul 2005 07:37:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/common Message-ID: <200507250737.j6P7bJev044097@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-25 07:37:19 UTC XORP CVS repository Modified files: policy lex.yy_policy_parser.cc policy.l policy.y yacc.yy_policy_parser.cc yacc.yy_policy_parser.cc.h policy/common element.cc element.hh register_elements.cc register_operations.cc Log message: Implement comparing of prefix length against uint32 and uint32range. Revision Changes Path 1.5 +4 -1; commitid: abe242e495887ea6; xorp/policy/common/element.cc 1.6 +4 -1; commitid: abe242e495887ea6; xorp/policy/common/element.hh 1.5 +4 -1; commitid: abe242e495887ea6; xorp/policy/common/register_elements.cc 1.9 +17 -1; commitid: abe242e495887ea6; xorp/policy/common/register_operations.cc 1.7 +2135 -1157; commitid: abe242e495887ea6; xorp/policy/lex.yy_policy_parser.cc 1.7 +14 -0; commitid: abe242e495887ea6; xorp/policy/policy.l 1.7 +5 -2; commitid: abe242e495887ea6; xorp/policy/policy.y 1.9 +173 -146; commitid: abe242e495887ea6; xorp/policy/yacc.yy_policy_parser.cc 1.5 +34 -31; commitid: abe242e495887ea6; xorp/policy/yacc.yy_policy_parser.cc.h From zec@icir.org Mon Jul 25 08:47:53 2005 From: zec@icir.org (Marko Zec) Date: Mon, 25 Jul 2005 07:47:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507250747.j6P7lrMY044268@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-25 07:47:53 UTC XORP CVS repository Modified files: etc/templates policy.tp Log message: Add support for comparing prefix lengths in policy template for IPv4. Supported operators are < > <= >= == and != A few examples of valid statements: prefix-length4 == 24 prefix-length4 > 16 prefix-length4 == 24..32 // match if prefix is within the range prefix-length4 != 16..23 // match if prefix is outside the range TODO: prefix-lenght6 Revision Changes Path 1.10 +9 -1; commitid: ac5f42e4973f7ea6; xorp/etc/templates/policy.tp From abittau@icir.org Mon Jul 25 18:48:00 2005 From: abittau@icir.org (Andrea Bittau) Date: Mon, 25 Jul 2005 17:48:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507251748.j6PHm0pI053495@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-25 17:48:00 UTC XORP CVS repository Modified files: libxorp Makefile.am Makefile.in range.hh Log message: * Add range.hh in makefile * Fix compilation errors: When referring to non private members in base classes, use BaseClass::var syntax. Revision Changes Path 1.36 +2 -1; commitid: d0d542e525aa7ea6; xorp/libxorp/Makefile.am 1.49 +1 -1; commitid: d0d542e525aa7ea6; xorp/libxorp/Makefile.in 1.3 +12 -9; commitid: d0d542e525aa7ea6; xorp/libxorp/range.hh From pavlin@icir.org Mon Jul 25 23:15:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 22:15:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507252215.j6PMFFEr056256@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-25 22:15:15 UTC XORP CVS repository Modified files: libxorp ipnet.hh Log message: * Reorder some of the methods (e.g., all the operators for IPNet operand are together). * Remove printf() leftover. * Modify some of the method's arguments so they are passed-by-reference. * Modify the implementation of some of the comparison operators, so the operator in the implementation matches the implemented operator. Revision Changes Path 1.16 +52 -50; commitid: db8d42e563777ea6; xorp/libxorp/ipnet.hh From pavlin@icir.org Mon Jul 25 23:16:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 22:16:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507252216.j6PMGptL056313@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-25 22:16:51 UTC XORP CVS repository Modified files: libxorp range.hh Log message: * Use string::size_type instead of "int" as the type of the index when searching a C++ string. * Modify the copyright year to be 2001-2005 (for consistency with the rest of the files). Revision Changes Path 1.4 +7 -7; commitid: dbe042e5648b7ea6; xorp/libxorp/range.hh From pavlin@icir.org Mon Jul 25 23:17:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 22:17:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507252217.j6PMHnYp056372@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-25 22:17:49 UTC XORP CVS repository Modified files: rtrmgr template.yy Log message: Remove INTRANGE_TYPE, because it looks like an leftover that is not used. Revision Changes Path 1.17 +0 -1; commitid: dc1b42e564fe7ea6; xorp/rtrmgr/template.yy From pavlin@icir.org Mon Jul 25 23:19:02 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 22:19:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507252219.j6PMJ26m056427@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-25 22:19:02 UTC XORP CVS repository Modified files: rtrmgr lex.boot.cc lex.opcmd.cc lex.tplt.cc y.boot_tab.cc y.boot_tab.h y.tplt_tab.cc y.tplt_tab.h Log message: Regenerate. Revision Changes Path 1.18 +8757 -7444; commitid: dc4642e565507ea6; xorp/rtrmgr/lex.boot.cc 1.17 +0 -0; commitid: dc4642e565507ea6; xorp/rtrmgr/lex.opcmd.cc 1.18 +7953 -6796; commitid: dc4642e565507ea6; xorp/rtrmgr/lex.tplt.cc 1.25 +188 -138; commitid: dc4642e565507ea6; xorp/rtrmgr/y.boot_tab.cc 1.10 +18 -15; commitid: dc4642e565507ea6; xorp/rtrmgr/y.boot_tab.h 1.23 +257 -204; commitid: dc4642e565507ea6; xorp/rtrmgr/y.tplt_tab.cc 1.8 +34 -28; commitid: dc4642e565507ea6; xorp/rtrmgr/y.tplt_tab.h From pavlin@icir.org Mon Jul 25 23:22:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 15:22:26 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Marko Zec of "Mon, 25 Jul 2005 07:23:03 GMT." <200507250723.j6P7N3D7043884@xorpc.icir.org> Message-ID: <200507252222.j6PMMQCo070386@possum.icir.org> > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: zec@xorpc.icir.org 2005-07-25 07:23:03 UTC > > XORP CVS repository > > > Modified files: > rtrmgr boot.ll boot.yy conf_tree.cc template.ll > template.yy template_tree.cc template_tree_node.cc > template_tree_node.hh > > Log message: > Teach rtrmgr's parser about new syntax for expressing ranges. > In other words, add support for: > > UINTRANGE_VALUE: [0-9]+".."[0-9]+ > IPV4RANGE_VALUE: {RE_IPV4}".."{RE_IPV4} > IPV6RANGE_VALUE: {RE_IPV6}".."{RE_IPV6} > > Only UINTRANGE syntax is verifyed to work properly at the moment. > > NOTE: gmake flex; gmake yacc has to be done in rtrmgr/ dir for > changes to take effect. Marko, Please don't forget to update the rtrmgr documentation (xorp/docs/rtrmgr/rtrmgr.tex, Section 2.1 "Template Tree Node Types") to include the new template types :) Pavlin > > Revision Changes Path > 1.25 +16 -1; commitid: aac742e491507ea6; xorp/rtrmgr/boot.ll > 1.22 +18 -0; commitid: aac742e491507ea6; xorp/rtrmgr/boot.yy > 1.39 +5 -1; commitid: aac742e491507ea6; xorp/rtrmgr/conf_tree.cc > 1.16 +30 -0; commitid: aac742e491507ea6; xorp/rtrmgr/template.ll > 1.16 +22 -0; commitid: aac742e491507ea6; xorp/rtrmgr/template.yy > 1.34 +4 -1; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree.cc > 1.54 +59 -1; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree_node.cc > 1.33 +22 -2; commitid: aac742e491507ea6; xorp/rtrmgr/template_tree_node.hh > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Tue Jul 26 00:01:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 25 Jul 2005 23:01:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507252301.j6PN1nMU066156@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-25 23:01:49 UTC XORP CVS repository Modified files: libxorp ipnet.hh Log message: Reverse-back the previous modification of some of the comparison operators. Apparently, the compiler doesn't like it when we compare, say, "prefix_len() < range", so indeed we have to use "range > prefix_len()". If we really want to use "prefix_len() < range", eventually the fix would be to define "operator<" for type uint32_t and "range"'s type(s), but for the time being we don't really need to do that. Revision Changes Path 1.17 +7 -7; commitid: 1022d42e56e187ea6; xorp/libxorp/ipnet.hh From pavlin@icir.org Tue Jul 26 05:11:13 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 04:11:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260411.j6Q4BDP9030859@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 04:11:12 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh Log message: Add new methods: ConfTreeNode::undelete_subtree() and ConfTreeNode::undelete_node_and_ancestors() Revision Changes Path 1.79 +27 -1; commitid: 787042e5b7a07ea6; xorp/rtrmgr/conf_tree_node.cc 1.41 +3 -1; commitid: 787042e5b7a07ea6; xorp/rtrmgr/conf_tree_node.hh From pavlin@icir.org Tue Jul 26 05:17:04 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 04:17:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260417.j6Q4H41Y030996@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 04:17:04 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: If we try to re-create a node that was previously deleted (but the deletion wasn't committed), then first undelete that node and its ancestors. Also, if we are re-creating a node that is not a tag, then undelete the subtree below that node. This fixes bugzilla entry #97 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=97 Revision Changes Path 1.78 +15 -1; commitid: 78aa42e5b8007ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Tue Jul 26 05:32:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 04:32:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260432.j6Q4WvlI031124@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 04:32:57 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Print an error if we attempt inside xorpsh to create a node that already exists. This fixes Bugzilla entry #98 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=98 Revision Changes Path 1.79 +22 -12; commitid: 797b42e5bc887ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Tue Jul 26 06:20:51 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 05:20:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260520.j6Q5KpDo031623@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 05:20:51 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh Log message: Add a new argument "bool show_top" to ConfigTree::show_subtree() and ConfigTreeNode::show_subtree() that can be used to decide whether to show the top-level node. Now if we delete a whole subtree (e.g., "delete protocols static") inside xorpsh, the "Deleting:" message will print properly the top-level deleted node. Revision Changes Path 1.80 +4 -3; commitid: 7b2342e5c6ac7ea6; xorp/rtrmgr/cli.cc 1.40 +13 -6; commitid: 7b2342e5c6ac7ea6; xorp/rtrmgr/conf_tree.cc 1.25 +2 -2; commitid: 7b2342e5c6ac7ea6; xorp/rtrmgr/conf_tree.hh 1.80 +14 -14; commitid: 7b2342e5c6ac7ea6; xorp/rtrmgr/conf_tree_node.cc 1.42 +2 -2; commitid: 7b2342e5c6ac7ea6; xorp/rtrmgr/conf_tree_node.hh From pavlin@icir.org Tue Jul 26 07:39:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 06:39:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507260639.j6Q6dUD6032375@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 06:39:30 UTC XORP CVS repository Modified files: cli cli_client.hh cli_node_net.cc Log message: Refactor the mechanism for processing the input data. This fixes an XLOG_ASSERT() coredump problem that was triggered if the user presses while the previous command's processing hasn't been completed. Revision Changes Path 1.19 +2 -2; commitid: 7e5742e5da3b7ea6; xorp/cli/cli_client.hh 1.39 +60 -36; commitid: 7e5742e5da3b7ea6; xorp/cli/cli_node_net.cc From pavlin@icir.org Tue Jul 26 07:49:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 06:49:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507260649.j6Q6nqkq032563@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 06:49:52 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_node_net.cc Log message: Add flag "ignore_current_character" that is passed as a reference to methods CliClient::process_char() and CliClient::preprocess_char() Revision Changes Path 1.33 +7 -3; commitid: 7f1142e5dce57ea6; xorp/cli/cli_client.cc 1.20 +5 -3; commitid: 7f1142e5dce57ea6; xorp/cli/cli_client.hh 1.40 +7 -6; commitid: 7f1142e5dce57ea6; xorp/cli/cli_node_net.cc From pavlin@icir.org Tue Jul 26 08:17:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 07:17:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260717.j6Q7HTaa032980@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 07:17:29 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Rebuild the whole command tree after we load new configuration. This fixes Bugzilla entry #120. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=120 Revision Changes Path 1.81 +10 -1; commitid: 7ff642e5e05c7ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Tue Jul 26 08:51:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 07:51:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507260751.j6Q7po8j033423@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 07:51:50 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: If we set the value of an existing node by using the "create" command, set the flag that changes have been made to the configuration tree. This fixes bugzilla entry #126. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=126 Revision Changes Path 1.82 +2 -1; commitid: 826c42e5eb5d7ea6; xorp/rtrmgr/cli.cc From bms@icir.org Tue Jul 26 13:12:19 2005 From: bms@icir.org (Bruce Simpson) Date: Tue, 26 Jul 2005 12:12:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200507261212.j6QCCJdE036727@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-26 12:12:19 UTC XORP CVS repository Modified files: libcomm comm_api.h comm_sock.c Log message: Diff reduction with Windows branch: Introduce a global switch _comm_squelch_accept. If this is set to a non-zero value, then the libcomm library will clear WinSock event notification masks on sockets during accept and close operations. This is done by calling WSAEventSelect() with empty arguments, which is documented to clear such masks. The reason for doing this is to prevent the WinSock infrastructure from signalling event conditions before clients of EventLoop have had a chance to wire up I/O event callbacks to service them. Revision Changes Path 1.20 +2 -1; commitid: 8f3942e628087ea6; xorp/libcomm/comm_api.h 1.24 +27 -0; commitid: 8f3942e628087ea6; xorp/libcomm/comm_sock.c From pavlin@icir.org Tue Jul 26 17:58:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 09:58:49 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm In-Reply-To: Message from Bruce Simpson of "Tue, 26 Jul 2005 12:12:19 GMT." <200507261212.j6QCCJdE036727@xorpc.icir.org> Message-ID: <200507261658.j6QGwnBt022241@possum.icir.org> > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms@xorpc.icir.org 2005-07-26 12:12:19 UTC > > XORP CVS repository > > > Modified files: > libcomm comm_api.h comm_sock.c > > Log message: > Diff reduction with Windows branch: > > Introduce a global switch _comm_squelch_accept. If this is set to a > non-zero value, then the libcomm library will clear WinSock event > notification masks on sockets during accept and close operations. > > This is done by calling WSAEventSelect() with empty arguments, which is > documented to clear such masks. > > The reason for doing this is to prevent the WinSock infrastructure > from signalling event conditions before clients of EventLoop have had > a chance to wire up I/O event callbacks to service them. Is the _comm_squelch_accept flag suppose to be used/set externally (outside file comm_sock.c), etc? If no, then shouldn't it be declared as "static"? Pavlin From bms@spc.org Tue Jul 26 18:26:05 2005 From: bms@spc.org (Bruce M Simpson) Date: Tue, 26 Jul 2005 18:26:05 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm In-Reply-To: <200507261658.j6QGwnBt022241@possum.icir.org> References: <200507261212.j6QCCJdE036727@xorpc.icir.org> <200507261658.j6QGwnBt022241@possum.icir.org> Message-ID: <20050726172605.GB759@empiric.icir.org> On Tue, Jul 26, 2005 at 09:58:49AM -0700, Pavlin Radoslavov wrote: > Is the _comm_squelch_accept flag suppose to be used/set externally > (outside file comm_sock.c), etc? > If no, then shouldn't it be declared as "static"? It is possible I may wish to change dispatchers without the inconvenience of recompiling XORP on Windows... as the WSAAsyncSelect() based dispatcher has too much latency at the moment. The Win32 select() based I/O dispatcher does not need the 'squelch' behaviour and could turn it off to save some API calls; the WinSock event related API calls can potentially be expensive because they may involve the creation and deletion of a helper thread. BMS From pavlin@icir.org Tue Jul 26 20:24:08 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 19:24:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200507261924.j6QJO8B2042988@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 19:24:08 UTC XORP CVS repository Modified files: fea ifconfig_set_ioctl.cc Log message: Add missing dummy implementations of IfConfigSetIoctl::add_vif_address4() and IfConfigSetIoctl::add_vif_address6() in case HAVE_IOCTL_SIOCGIFCONF is not defined. Bug found by: Weaver John-JWEAVER1 Revision Changes Path 1.37 +63 -1; commitid: a7c842e68d9a7ea6; xorp/fea/ifconfig_set_ioctl.cc From pavlin@icir.org Wed Jul 27 00:54:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 26 Jul 2005 23:54:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507262354.j6QNs1X0045802@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-26 23:54:01 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: If we "exit discard" the xorpsh configurational mode, then reset the "_changes_made" flag. This fixes Bugzilla entry #138 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=138 Revision Changes Path 1.83 +2 -1; commitid: b2d142e6ccef7ea6; xorp/rtrmgr/cli.cc From zec@icir.org Wed Jul 27 01:19:43 2005 From: zec@icir.org (Marko Zec) Date: Wed, 27 Jul 2005 00:19:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200507270019.j6R0JhHM046077@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-27 00:19:43 UTC XORP CVS repository Modified files: policy/common register_operations.cc Log message: Register operators for comparing IPv6Net against U32Range. Needed for checking the prefix length. Revision Changes Path 1.10 +3 -1; commitid: b3df42e6d2a07ea6; xorp/policy/common/register_operations.cc From zec@icir.org Wed Jul 27 01:34:19 2005 From: zec@icir.org (Marko Zec) Date: Wed, 27 Jul 2005 00:34:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507270034.j6R0YJL3046264@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-27 00:34:19 UTC XORP CVS repository Modified files: etc/templates policy.tp Log message: Allow for network4 network6 network4-list prefix-length4 and prefix-lenght6 to be looked at in the "dest" section of policy terms / rules. Revision Changes Path 1.11 +42 -2; commitid: b49342e6d5e97ea6; xorp/etc/templates/policy.tp From pavlin@icir.org Wed Jul 27 01:49:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 00:49:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507270049.j6R0n6pu046424@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 00:49:06 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Fix some of the logic inside ConfigTreeNode::check_config_tree() by considering whether a configuration tree node has been deleted. This fixes Bugzilla entry #131. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=131 Revision Changes Path 1.81 +6 -3; commitid: b53f42e6d9cc7ea6; xorp/rtrmgr/conf_tree_node.cc From zec@icir.org Wed Jul 27 02:04:13 2005 From: zec@icir.org (Marko Zec) Date: Wed, 27 Jul 2005 01:04:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507270104.j6R14DrC046564@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-27 01:04:13 UTC XORP CVS repository Modified files: libxorp ipnet.hh range.hh Log message: Rearrange (again) the ordering of arguments for comparisons between uint32_t and U32Range arguments. We should now settle for the convention to keep uint32_t args always on the left and U32Range on the right side of the operand. Revision Changes Path 1.18 +7 -7; commitid: b5c942e6dd057ea6; xorp/libxorp/ipnet.hh 1.5 +73 -25; commitid: b5c942e6dd057ea6; xorp/libxorp/range.hh From pavlin@icir.org Wed Jul 27 02:08:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 01:08:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507270108.j6R18c3I046714@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 01:08:38 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: If we use a command "show foo" in configurational mode, but node "foo" doesn't exist, then print an error message. Revision Changes Path 1.84 +14 -2; commitid: b65c42e6de767ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Wed Jul 27 02:14:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 01:14:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507270114.j6R1ElKs046805@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 01:14:47 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Add a comment inside method RouterCLI::show_func() Revision Changes Path 1.85 +8 -1; commitid: b6b442e6dfee7ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Wed Jul 27 05:37:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 04:37:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507270437.j6R4bSS4019226@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 04:37:28 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: * Add new method RouterCLI::makepath() that takes a vector of strings and returns a concatenated string (with spaces between the original segments). * Use the above new method inside RouterCLI::show_func() * Test for error conditions inside method RouterCLI::delete_func() and print an error as appropriate. This fixes Bugzilla entry #132 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=132 Revision Changes Path 1.86 +46 -10; commitid: 4ae142e70eda7ea6; xorp/rtrmgr/cli.cc 1.36 +2 -1; commitid: 4ae142e70eda7ea6; xorp/rtrmgr/cli.hh From zec@icir.org Wed Jul 27 08:00:33 2005 From: zec@icir.org (Marko Zec) Date: Wed, 27 Jul 2005 07:00:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200507270700.j6R70XIP020656@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-27 07:00:33 UTC XORP CVS repository Modified files: etc/templates bgp.tp policy.tp static_routes.tp Log message: Modify templates so med and localpref (bgp) and metric (static) can be compared against uint ranges instead of only a single integer. Extend the list of operators for above route attributes from only ":" to ":" "==" "!=" "<" ">" "<=" ">=" Provide support for network6-list (actually a set of IPv6Nets) analogous to network4-list(s). TODO #1: check what's up with RIP and policy (metric) TODO #2: testing... Revision Changes Path 1.50 +9 -5; commitid: 504042e72f897ea6; xorp/etc/templates/bgp.tp 1.12 +22 -1; commitid: 504042e72f897ea6; xorp/etc/templates/policy.tp 1.21 +2 -2; commitid: 504042e72f897ea6; xorp/etc/templates/static_routes.tp From zec@icir.org Wed Jul 27 08:04:52 2005 From: zec@icir.org (Marko Zec) Date: Wed, 27 Jul 2005 07:04:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200507270704.j6R74q3W020790@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-07-27 07:04:52 UTC XORP CVS repository Modified files: policy/common elem_set.cc elem_set.hh register_elements.cc register_operations.cc Log message: Register comparison operations for uint32 against uint ranges in policy. Register set_ipv6net as a valid type in policy. Revision Changes Path 1.6 +4 -1; commitid: 50b842e7311e7ea6; xorp/policy/common/elem_set.cc 1.6 +2 -1; commitid: 50b842e7311e7ea6; xorp/policy/common/elem_set.hh 1.6 +2 -1; commitid: 50b842e7311e7ea6; xorp/policy/common/register_elements.cc 1.11 +6 -2; commitid: 50b842e7311e7ea6; xorp/policy/common/register_operations.cc From abittau@icir.org Wed Jul 27 18:59:48 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 27 Jul 2005 17:59:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507271759.j6RHxmj5029258@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-27 17:59:48 UTC XORP CVS repository Modified files: bgp route_table_filter.cc route_table_policy.cc Log message: * get rid of assert in static filter table. On a route_lookup, if a static filter modifies the route, it must not think it had to be in cache. The policy filter could have dropped that modified route before it reached cache! Policy table has this assert. * On lookup route, rtmsg were created with a NULL peer handler. That is not good, as policies may match neighbor and screw up when filtering in lookup_route. How do we obtain the peerhandle? Walk up the tables until ribin and get it from there. A bit of a hack I know... Revision Changes Path 1.32 +6 -1; commitid: 721c42e7cb227ea6; xorp/bgp/route_table_filter.cc 1.10 +16 -6; commitid: 721c42e7cb227ea6; xorp/bgp/route_table_policy.cc From abittau@icir.org Wed Jul 27 20:13:00 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 27 Jul 2005 19:13:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200507271913.j6RJCxt1030031@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-07-27 19:12:59 UTC XORP CVS repository Modified files: bgp route_table_policy.cc Log message: sort out more memory leaks? Revision Changes Path 1.11 +24 -13; commitid: 753642e7dcb57ea6; xorp/bgp/route_table_policy.cc From pavlin@icir.org Thu Jul 28 00:32:53 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 23:32:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507272332.j6RNWrKO032611@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 23:32:53 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_command.cc cli_command.hh Log message: Add initial support for wildcard commands. The support is very basic and currently has very limited applications. Basically, if a CliCommand node in the CLI command tree is marked as wildcard, then it will match any token from the command line, but the executed command itself will include the particular token itself instead of the global name of that CliCommand node. Revision Changes Path 1.34 +19 -4; commitid: 7f2042e818e07ea6; xorp/cli/cli_client.cc 1.21 +2 -1; commitid: 7f2042e818e07ea6; xorp/cli/cli_client.hh 1.16 +22 -1; commitid: 7f2042e818e07ea6; xorp/cli/cli_command.cc 1.14 +18 -3; commitid: 7f2042e818e07ea6; xorp/cli/cli_command.hh From pavlin@icir.org Thu Jul 28 00:52:21 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 27 Jul 2005 23:52:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507272352.j6RNqLur032975@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-27 23:52:20 UTC XORP CVS repository Modified files: rtrmgr op_commands.cc Log message: Add support for setting the wildcard flag for commands like "ping " where "" is a mandatory argument that can have any value. This fixes a bug with the execution of the "ping" and "traceroute" commands inside xorpsh. Bug found by: Michael Larson Revision Changes Path 1.52 +20 -5; commitid: 809942e81dd57ea6; xorp/rtrmgr/op_commands.cc From atanu@icir.org Thu Jul 28 03:54:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 28 Jul 2005 02:54:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507280254.j6S2sxiR034506@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-28 02:54:59 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: The implementation of string that comes with the gcc 2.95 doesn't support the method clear. Assign the string with the empty string. Revision Changes Path 1.35 +5 -3; commitid: 86af42e849027ea6; xorp/cli/cli_client.cc From atanu@icir.org Thu Jul 28 04:38:44 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 28 Jul 2005 03:38:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507280338.j6S3cixt035002@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-07-28 03:38:44 UTC XORP CVS repository Modified files: rtrmgr xrl_rtrmgr_interface.cc Log message: Check that the iterator is still valid before attempting to dereference it. Revision Changes Path 1.40 +2 -2; commitid: 889f42e853447ea6; xorp/rtrmgr/xrl_rtrmgr_interface.cc From pavlin@icir.org Thu Jul 28 06:19:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 05:19:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507280519.j6S5Judf052639@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 05:19:55 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: Remove commented-out code. Revision Changes Path 1.36 +1 -3; commitid: ccc842e86af27ea6; xorp/cli/cli_client.cc From pavlin@icir.org Thu Jul 28 07:16:48 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 06:16:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200507280616.j6S6GmSW063520@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 06:16:47 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: Fix some of the logic for assembling the command_global_name while we search for a match. Now the result is much closer to the previous result before the "wildcard" commands were introduced. This fixes a "create foo" bug where the "create" command wasn't recognized. Apparently, the RouterCLI::text_entry_func() doesn't expect that the first token of the command global name is "create". To complicate things further, the CliCommand entry for "create" has name of "create", but its global name (i.e., full path name) is empty. As a result of that we need to be extra careful inside CliClient::process_command() how exactly the full-path command name is assembled. Sigh... Bug found by: Michael Larson Revision Changes Path 1.37 +13 -4; commitid: f7d342e876c97ea6; xorp/cli/cli_client.cc From pavlin@icir.org Thu Jul 28 08:26:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 07:26:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507280726.j6S7Qs1b072928@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 07:26:54 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: * Reset the _cli_client_ptr inside method RouterCLI::logout_func() after the CliClient object has been deleted. This fixes a bug where the xorpsh didn't quit after executing the "quit" command in operational mode. * If necessary, delete the _cli_client_ptr object inside the RouterCLI destructor. This fixes a bug restoring the terminal when we run xorpsh inside sh. Bug found by: Atanu Ghosh Revision Changes Path 1.87 +6 -4; commitid: 11ca742e887957ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Fri Jul 29 00:11:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 23:11:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507282311.j6SNBPRB085903@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 23:11:25 UTC XORP CVS repository Modified files: rtrmgr util.cc util.hh Log message: Added a new function has_empty_space() to test whether a C++ string contains an empty space inside (i.e., or ). Revision Changes Path 1.15 +16 -1; commitid: 14f6042e965bb7ea6; xorp/rtrmgr/util.cc 1.9 +9 -1; commitid: 14f6042e965bb7ea6; xorp/rtrmgr/util.hh From pavlin@icir.org Fri Jul 29 00:18:32 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 23:18:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507282318.j6SNIWrB086028@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 23:18:32 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh Log message: * Move the existing code for quoting a text value to a new method ConfigTreeNode::quoted_value(). * If we print the name of a multi-value node of type text, and if that name contains an empty space, then print the name in quotes. Otherwise, just print the name without quotes. This fixes a problem where the rtrmgr can accept configuration like: interfaces { interface "foo bar" { } } but later when the configuration is sent to xorpsh the quotes around the "foo bar" interface name would disappear and xorpsh cannot parse it. Revision Changes Path 1.82 +28 -16; commitid: 14fb142e9664d7ea6; xorp/rtrmgr/conf_tree_node.cc 1.43 +2 -1; commitid: 14fb142e9664d7ea6; xorp/rtrmgr/conf_tree_node.hh From pavlin@icir.org Fri Jul 29 00:20:35 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 23:20:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200507282320.j6SNKZUW086162@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 23:20:35 UTC XORP CVS repository Modified files: rtrmgr util.hh Log message: Fix a kdoc comment. Revision Changes Path 1.10 +2 -2; commitid: 1507442e9683c7ea6; xorp/rtrmgr/util.hh From pavlin@icir.org Fri Jul 29 00:26:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 28 Jul 2005 23:26:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/rtrmgr Message-ID: <200507282326.j6SNQOAc086276@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-07-28 23:26:24 UTC XORP CVS repository Modified files: cli cli_command.cc cli_command.hh cli_node.cc cli_node_internal_commands.cc test_cli.cc rtrmgr cli.cc Log message: * Add an extra "is_multilevel_command" argument/flag to the various CliCommand::add_command() methods. Only if it is true, then the "init_command_name" string is presumed to contain a command name across multi-levels (e.g., "show a b c", where "c" is a child of "b", and "b" is a child of "a"). Otherwise, it is presumed that "show a b c" is the name of a child command. * Change all the code elsewhere to use the new flag as appropriate. This fixes a coredump problem when we use the following command inside xorpsh: create interfaces interface "foo bar" Revision Changes Path 1.17 +28 -14; commitid: 150ae42e968597ea6; xorp/cli/cli_command.cc 1.15 +44 -18; commitid: 150ae42e968597ea6; xorp/cli/cli_command.hh 1.28 +4 -4; commitid: 150ae42e968597ea6; xorp/cli/cli_node.cc 1.13 +14 -6; commitid: 150ae42e968597ea6; xorp/cli/cli_node_internal_commands.cc 1.37 +21 -15; commitid: 150ae42e968597ea6; xorp/cli/test_cli.cc 1.88 +31 -24; commitid: 150ae42e968597ea6; xorp/rtrmgr/cli.cc From bms@icir.org Fri Jul 29 18:33:02 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 17:33:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507291733.j6THX2C1009606@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 17:33:02 UTC XORP CVS repository Modified files: libxipc call_xrl.cc Log message: Eliminate dependency on strsep(), which does not exist in the Microsoft Visual C++ Runtime. Obtained from: XORP/Win32 Revision Changes Path 1.32 +6 -5; commitid: 256d42ea682e7ea6; xorp/libxipc/call_xrl.cc From bms@icir.org Fri Jul 29 18:34:04 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 17:34:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507291734.j6THY48r009651@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 17:34:04 UTC XORP CVS repository Modified files: libxipc call_xrl.cc Log message: Use include guards. Put config.h at top. Obtained from: XORP/Win32 Revision Changes Path 1.33 +9 -2; commitid: 259a42ea68717ea6; xorp/libxipc/call_xrl.cc From bms@icir.org Fri Jul 29 18:52:40 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 17:52:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/harness xorp/fea xorp/libfeaclient xorp/libproto xorp/libxipc xorp/libxorp xorp/mibs xorp/rib xorp/rip xorp/rtrmgr xorp/xrl/tests Message-ID: <200507291752.j6THqesq010162@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 17:52:40 UTC XORP CVS repository Modified files: bgp Makefile.am bgp/harness Makefile.am fea Makefile.am libfeaclient Makefile.am libproto Makefile.am libxipc Makefile.am libxorp Makefile.am mibs Makefile.am rib Makefile.am rip Makefile.am rtrmgr Makefile.am xrl/tests Makefile.am Log message: Diff reduction: Bring in the fixes for the Auto-makefiles which allow the regression tests for XORP to be built and run on Windows. This includes the following: - Add EXEEXT where appropriate to ensure the correct binaries are built. - Sort tests where needed. - Introduce explicit dependency rules where necessary to deal with situations where Automake can't quite figure out that an .EXE needs to be built. This does NOT include: - changes to primaries which reference files which are currently only present in XORP/Win32. - regeneration of the Makefile.in template files (to follow). Obtained from: XORP/Win32 Revision Changes Path 1.38 +12 -13; commitid: 26b142ea6cc67ea6; xorp/bgp/Makefile.am 1.17 +14 -14; commitid: 26b142ea6cc67ea6; xorp/bgp/harness/Makefile.am 1.59 +11 -11; commitid: 26b142ea6cc67ea6; xorp/fea/Makefile.am 1.9 +6 -5; commitid: 26b142ea6cc67ea6; xorp/libfeaclient/Makefile.am 1.12 +5 -5; commitid: 26b142ea6cc67ea6; xorp/libproto/Makefile.am 1.43 +15 -14; commitid: 26b142ea6cc67ea6; xorp/libxipc/Makefile.am 1.37 +32 -30; commitid: 26b142ea6cc67ea6; xorp/libxorp/Makefile.am 1.34 +3 -3; commitid: 26b142ea6cc67ea6; xorp/mibs/Makefile.am 1.39 +12 -10; commitid: 26b142ea6cc67ea6; xorp/rib/Makefile.am 1.35 +13 -17; commitid: 26b142ea6cc67ea6; xorp/rip/Makefile.am 1.56 +9 -9; commitid: 26b142ea6cc67ea6; xorp/rtrmgr/Makefile.am 1.9 +4 -4; commitid: 26b142ea6cc67ea6; xorp/xrl/tests/Makefile.am From bms@icir.org Fri Jul 29 18:56:07 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 17:56:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/harness xorp/fea xorp/libfeaclient xorp/libproto xorp/libxipc xorp/libxorp xorp/mibs xorp/rib xorp/rip xorp/rtrmgr xorp/xrl/tests Message-ID: <200507291756.j6THu7KI010473@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 17:56:07 UTC XORP CVS repository Modified files: bgp Makefile.in bgp/harness Makefile.in fea Makefile.in libfeaclient Makefile.in libproto Makefile.in libxipc Makefile.in libxorp Makefile.in mibs Makefile.in rib Makefile.in rip Makefile.in rtrmgr Makefile.in xrl/tests Makefile.in Log message: Regen. Revision Changes Path 1.53 +10 -10; commitid: 27e242ea6d9d7ea6; xorp/bgp/Makefile.in 1.33 +5 -4; commitid: 27e242ea6d9d7ea6; xorp/bgp/harness/Makefile.in 1.74 +7 -8; commitid: 27e242ea6d9d7ea6; xorp/fea/Makefile.in 1.16 +3 -3; commitid: 27e242ea6d9d7ea6; xorp/libfeaclient/Makefile.in 1.27 +3 -3; commitid: 27e242ea6d9d7ea6; xorp/libproto/Makefile.in 1.62 +3 -5; commitid: 27e242ea6d9d7ea6; xorp/libxipc/Makefile.in 1.50 +6 -5; commitid: 27e242ea6d9d7ea6; xorp/libxorp/Makefile.in 1.43 +2 -2; commitid: 27e242ea6d9d7ea6; xorp/mibs/Makefile.in 1.53 +8 -6; commitid: 27e242ea6d9d7ea6; xorp/rib/Makefile.in 1.50 +6 -4; commitid: 27e242ea6d9d7ea6; xorp/rip/Makefile.in 1.68 +6 -4; commitid: 27e242ea6d9d7ea6; xorp/rtrmgr/Makefile.in 1.24 +3 -3; commitid: 27e242ea6d9d7ea6; xorp/xrl/tests/Makefile.in From pavlin@icir.org Fri Jul 29 18:58:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 29 Jul 2005 10:58:05 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc In-Reply-To: Message from Bruce Simpson of "Fri, 29 Jul 2005 17:34:04 GMT." <200507291734.j6THY48r009651@xorpc.icir.org> Message-ID: <200507291758.j6THw5WK075206@possum.icir.org> > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms@xorpc.icir.org 2005-07-29 17:34:04 UTC > > XORP CVS repository > > > Modified files: > libxipc call_xrl.cc > > Log message: > Use include guards. Put config.h at top. The "libxorp/xorp.h" header file already includes "config.h", and "libxorp/xorp.h" should be included everywhere. Hence, shouldn't we add the "#ifdef HAVE_CONFIG_H" ... "#endif" wrapper inside "libxorp/xorp.h" and stop including "config.h" elsewhere? Pavlin P.S. Including inside call_xrl.cc breaks the compilation on FreeBSD-4.10 : g++34 -DHAVE_CONFIG_H -I. -I/home/possum/u0/pavlin/xorp/libxipc -I.. -I/home/possum/u0/pavlin/xorp -g -W -Wall -Wwrite-strings -Wcast-qual -Werror -Wpointer-arith -Wcast-align -Woverloaded-virtual -ftemplate-depth-22 -pipe -c -o call_xrl.o `test -f /home/possum/u0/pavlin/xorp/libxipc/call_xrl.cc || echo '/home/possum/u0/pavlin/xorp/libxipc/'`/home/possum/u0/pavlin/xorp/libxipc/call_xrl.cc In file included from /home/possum/u0/pavlin/xorp/libxipc/call_xrl.cc:30: /usr/local/include/getopt.h:115: error: declaration of C function `int getopt()' conflicts with /usr/include/unistd.h:112: error: previous declaration `int getopt(int, char* const*, const char*)' here /usr/local/include/getopt.h: In function `int main(int, char* const*)': /usr/local/include/getopt.h:115: error: too many arguments to function `int getopt()' /home/possum/u0/pavlin/xorp/libxipc/call_xrl.cc:255: error: at this point in file From bms@icir.org Fri Jul 29 19:13:34 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 18:13:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507291813.j6TIDYRH010954@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 18:13:34 UTC XORP CVS repository Modified files: libxipc test_finder_deaths.sh Log message: Diff reduction: Use kill -0 in lieu of ps -p as it's a more portable idiom, and will work with the MinGW MSYS environment on Windows. Obtained from: XORP/Win32 Revision Changes Path 1.4 +3 -3; commitid: 2aa742ea71a37ea6; xorp/libxipc/test_finder_deaths.sh From bms@icir.org Fri Jul 29 21:00:17 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 20:00:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507292000.j6TK0HbR012176@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 20:00:17 UTC XORP CVS repository Modified files: libxipc finder.hh finder_client_observer.cc finder_main.cc finder_tcp.hh finder_tcp_messenger.cc header.cc header.hh test_finder_events.cc test_finder_messenger.cc test_finder_msgs.cc test_finder_tcp.cc test_finder_to.cc test_stcppf.cc test_xrl_args.cc test_xrl_atom.cc test_xrl_parser.cc test_xrl_receiver.cc test_xrl_sender.cc xrl_args.hh xrl_atom.cc xrl_atom_encoding.cc xrl_cmd_map.cc xrl_error.cc xrl_error.hh xrl_parser_input.cc xrl_pf_factory.cc xrl_pf_inproc.cc xrl_pf_kill.cc xrl_pf_stcp.cc xrl_pf_stcp_ph.cc xrl_pf_sudp.cc xrl_router.cc xrl_router.hh xuid.cc Log message: Diff reduction with XORP/Win32: bring in include file guards. These generally reference defined from config.h, but it is also wrapped by a guard, in case configure is not in use for some reason. Obtained from: XORP/Win32 Revision Changes Path 1.18 +3 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/finder.hh 1.6 +4 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/finder_client_observer.cc 1.16 +21 -4; commitid: 2f2442ea8ac27ea6; xorp/libxipc/finder_main.cc 1.15 +9 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/finder_tcp.hh 1.25 +4 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/finder_tcp_messenger.cc 1.9 +3 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/header.cc 1.8 +5 -3; commitid: 2f2442ea8ac27ea6; xorp/libxipc/header.hh 1.17 +11 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_finder_events.cc 1.15 +9 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_finder_messenger.cc 1.7 +9 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_finder_msgs.cc 1.17 +11 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_finder_tcp.cc 1.10 +8 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_finder_to.cc 1.7 +5 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_stcppf.cc 1.10 +10 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_xrl_args.cc 1.10 +5 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_xrl_atom.cc 1.7 +5 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_xrl_parser.cc 1.9 +10 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_xrl_receiver.cc 1.13 +10 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/test_xrl_sender.cc 1.12 +5 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_args.hh 1.20 +14 -6; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_atom.cc 1.10 +4 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_atom_encoding.cc 1.12 +6 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_cmd_map.cc 1.9 +5 -3; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_error.cc 1.13 +5 -2; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_error.hh 1.9 +6 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_parser_input.cc 1.13 +3 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_factory.cc 1.24 +21 -9; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_inproc.cc 1.5 +24 -10; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_kill.cc 1.41 +9 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_stcp.cc 1.9 +16 -4; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_stcp_ph.cc 1.39 +22 -8; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_pf_sudp.cc 1.49 +16 -3; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_router.cc 1.33 +4 -1; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xrl_router.hh 1.8 +31 -10; commitid: 2f2442ea8ac27ea6; xorp/libxipc/xuid.cc From bms@icir.org Fri Jul 29 21:05:41 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 20:05:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507292005.j6TK5fge012256@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 20:05:41 UTC XORP CVS repository Modified files: libxorp c_format.cc Log message: Diff reduction: Add include file guards. Add a workaround for the bug whereby vnsprintf() on Win32 could introduce an infinite loop when called from the XRL layer. Obtained from: XORP/Win32 Revision Changes Path 1.8 +24 -2; commitid: 2fc742ea8c047ea6; xorp/libxorp/c_format.cc From bms@icir.org Fri Jul 29 21:06:34 2005 From: bms@icir.org (Bruce Simpson) Date: Fri, 29 Jul 2005 20:06:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507292006.j6TK6YHL012377@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-29 20:06:34 UTC XORP CVS repository Modified files: libxorp asnum.hh buffered_asyncio.hh c_format.hh callback.cc callback.hh debug.c ipv4.cc ipv4.hh ipv6.cc ipv6.hh ipvx.cc mac.hh ref_ptr.cc ref_ptr.hh service.cc test_config_param.cc test_heap.cc test_ipnet.cc test_ipv4.cc test_ipv4net.cc test_ipv6.cc test_ipv6net.cc test_ipvx.cc test_ipvxnet.cc test_mac.cc test_profile.cc test_ref_ptr.cc test_service.cc test_test_main.cc test_time_slice.cc test_timer.cc test_timeval.cc test_utils.cc test_vif.cc time_slice.hh timer.hh timeval.hh transaction.hh utility.c xlog.c Log message: Diff reduction: Add include file guards. Obtained from: XORP/Win32 Revision Changes Path 1.11 +11 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/asnum.hh 1.3 +6 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/buffered_asyncio.hh 1.7 +5 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/c_format.hh 1.5 +4 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/callback.cc 1.17 +4 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/callback.hh 1.7 +11 -4; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/debug.c 1.19 +13 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ipv4.cc 1.23 +12 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ipv4.hh 1.18 +14 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ipv6.cc 1.22 +12 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ipv6.hh 1.17 +10 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ipvx.cc 1.8 +5 -2; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/mac.hh 1.10 +5 -2; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ref_ptr.cc 1.18 +4 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/ref_ptr.hh 1.6 +4 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/service.cc 1.6 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_config_param.cc 1.4 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_heap.cc 1.10 +13 -4; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipnet.cc 1.16 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipv4.cc 1.9 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipv4net.cc 1.16 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipv6.cc 1.9 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipv6net.cc 1.16 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipvx.cc 1.8 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ipvxnet.cc 1.6 +4 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_mac.cc 1.3 +7 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_profile.cc 1.6 +9 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_ref_ptr.cc 1.8 +7 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_service.cc 1.9 +4 -2; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_test_main.cc 1.6 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_time_slice.cc 1.11 +9 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_timer.cc 1.4 +9 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_timeval.cc 1.3 +5 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_utils.cc 1.10 +8 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/test_vif.cc 1.7 +3 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/time_slice.hh 1.25 +5 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/timer.hh 1.21 +6 -2; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/timeval.hh 1.7 +3 -1; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/transaction.hh 1.5 +11 -3; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/utility.c 1.9 +10 -11; commitid: 2ff242ea8c3b7ea6; xorp/libxorp/xlog.c From bms@icir.org Sun Jul 31 03:03:55 2005 From: bms@icir.org (Bruce Simpson) Date: Sun, 31 Jul 2005 02:03:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200507310203.j6V23tc5028084@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-31 02:03:55 UTC XORP CVS repository Modified files: libxorp xlog.c Log message: Include where needed to fix build. Revision Changes Path 1.10 +4 -1; commitid: 6d9b42ec315e7ea6; xorp/libxorp/xlog.c From bms@icir.org Sun Jul 31 11:09:17 2005 From: bms@icir.org (Bruce Simpson) Date: Sun, 31 Jul 2005 10:09:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507311009.j6VA9Hsw032114@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-31 10:09:17 UTC XORP CVS repository Modified files: libxipc test_finder_tcp.cc Log message: Remove a reference to which crept in during the merge. Revision Changes Path 1.18 +1 -2; commitid: 7d5942eca3347ea6; xorp/libxipc/test_finder_tcp.cc From bms@icir.org Sun Jul 31 11:11:12 2005 From: bms@icir.org (Bruce Simpson) Date: Sun, 31 Jul 2005 10:11:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200507311011.j6VABCVJ032181@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-31 10:11:12 UTC XORP CVS repository Modified files: libxipc test_finder_events.cc test_xrl_receiver.cc test_xrl_sender.cc Log message: Remove references to xorpfd.hh which crept in during the merge. Revision Changes Path 1.18 +1 -2; commitid: 7d9842eca3b17ea6; xorp/libxipc/test_finder_events.cc 1.10 +1 -2; commitid: 7d9842eca3b17ea6; xorp/libxipc/test_xrl_receiver.cc 1.14 +1 -2; commitid: 7d9842eca3b17ea6; xorp/libxipc/test_xrl_sender.cc From bms@icir.org Sun Jul 31 12:13:14 2005 From: bms@icir.org (Bruce Simpson) Date: Sun, 31 Jul 2005 11:13:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200507311113.j6VBDE1k032849@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-07-31 11:13:14 UTC XORP CVS repository Modified files: . config.h.in configure configure.in Log message: Hack the meaning of HAVE_GETOPT_H to mean 'need getopt.h', and add a kludge to detect if getopt() was already defined in unistd.h and if so, do not invoke the test which would define HAVE_GETOPT_H. Revision Changes Path 1.44 +3 -6; commitid: 803442ecb2297ea6; xorp/config.h.in 1.148 +109 -56; commitid: 803442ecb2297ea6; xorp/configure 1.137 +19 -7; commitid: 803442ecb2297ea6; xorp/configure.in