[Xorp-cvs] XORP cvs commit: xorp/bgp

[Pavlin Radoslavov]

> I want the user to tell me if this message appears just before BGP
> crashes.

Then I presume this XLOG_INFO() will be temporary there until the
problem is fixed, because from the CVS log message I got the
impression this is a permanent change :)

Pavlin

> 
> 	Atanu.
> 
> >>>>> "Pavlin" == Pavlin Radoslavov <pavlin@icir.org> writes:
> 
>     >> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by:
>     >> atanu@xorpc.icir.org 2005-07-05 23:57:48 UTC
>     >> 
>     >> XORP CVS repository
>     >> 
>     >> 
>     >> Modified files: bgp dump_iterators.cc
>     >> 
>     >> Log message: Change a printf to a XLOG_INFO.
> 
>     Pavlin> Is XLOG_INFO() the right message here?  XLOG_INFO() is
>     Pavlin> suppose to be used for high-level stuff the user cares about
>     Pavlin> such as protocol started/stopped, interface added/deleted,
>     Pavlin> etc.  In this particular case, the "iterator has moved"
>     Pavlin> message looks to me more like a debug message, so
>     Pavlin> debug_msg() is probably a better choice.
> 
>     Pavlin> Pavlin
> 
>     >>  Revision Changes Path 1.29 +3 -2; commitid: 386442cb1e7a7ea6;
>     >> xorp/bgp/dump_iterators.cc
>     >> _______________________________________________ Xorp-cvs mailing
>     >> list Xorp-cvs@icir.org
>     >> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs
> 
> _______________________________________________
> Xorp-cvs mailing list
> Xorp-cvs@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs