[Xorp-cvs] XORP cvs commit: xorp/libcomm

Bruce M Simpson bms@spc.org
Tue, 26 Jul 2005 18:26:05 +0100


On Tue, Jul 26, 2005 at 09:58:49AM -0700, Pavlin Radoslavov wrote:
> Is the _comm_squelch_accept flag suppose to be used/set externally
> (outside file comm_sock.c), etc?
> If no, then shouldn't it be declared as "static"?

It is possible I may wish to change dispatchers without the inconvenience of
recompiling XORP on Windows... as the WSAAsyncSelect() based dispatcher has
too much latency at the moment.

The Win32 select() based I/O dispatcher does not need the 'squelch' behaviour
and could turn it off to save some API calls; the WinSock event related
API calls can potentially be expensive because they may involve the creation
and deletion of a helper thread.

BMS