No subject
Fri Dec 13 14:38:56 2002
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 13 Dec 2002 14:39:03 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.3/8.12.3) with ESMTP id gBDMd2h1006107
for <atanu@tigger.icir.org>; Fri, 13 Dec 2002 14:39:02 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.3/8.12.3) with ESMTP id gBDMd2wP066889
for <atanu@icir.org>; Fri, 13 Dec 2002 14:39:02 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by ICSI.Berkeley.EDU (8.9.0/8.9.0) with ESMTP id OAA11168
for <atanu@icsi.berkeley.edu>; Fri, 13 Dec 2002 14:39:02 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by ICSI.Berkeley.EDU (8.9.0/8.9.0) with ESMTP id OAA11161
for <xorp-cvs@icsi.berkeley.edu>; Fri, 13 Dec 2002 14:38:56 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.3/8.12.3) with ESMTP id gBDMcuwP066887
for <xorp-cvs@icir.org>; Fri, 13 Dec 2002 14:38:56 -0800 (PST)
(envelope-from rizzo@xorpc.icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.3/8.12.3) with ESMTP id gBDMcuTO018455
for <xorp-cvs@icir.org>; Fri, 13 Dec 2002 14:38:56 -0800 (PST)
(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
by xorpc.icir.org (8.12.3/8.12.3/Submit) id gBDMcuEp018454;
Fri, 13 Dec 2002 14:38:56 -0800 (PST)
(envelope-from rizzo)
From: Luigi Rizzo <rizzo@icir.org>
Message-Id: <200212132238.gBDMcuEp018454@xorpc.icir.org>
Date: Fri, 13 Dec 2002 14:38:56 ()
To: xorp-cvs@icir.org
Reply-To: rizzo@icir.org
Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/ aspath.cc aspath.hh aspath_test.cc bgp_trie.hh local_data.cc local_data.hh packet_coding_test.cc packet_test.cc path_attribute.cc peer.cc peer_data.cc plumbing_test.cc route_queue.cc route_queue.hh ...test_cache.reference ...test_decision.reference ...test_deletion.reference ...test_dump.reference ...test_fanout.reference ...test_filter.reference ...test_nhlookup.reference ...test_ribin.reference ...test_ribout.reference ...update_test.cc xorp/bgp/harness/ peer.cc
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/share/doc/apache/cvs
Module name: xorp
Repository: xorp/bgp/harness/
Changes by: rizzo@xorpc.icir.org. 02/12/13 14:38:56
Modified files:
xorp/bgp/: aspath.cc aspath.hh aspath_test.cc bgp_trie.hh
local_data.cc local_data.hh packet_coding_test.cc
packet_test.cc path_attribute.cc peer.cc peer_data.cc
plumbing_test.cc route_queue.cc route_queue.hh
test_cache.reference test_decision.reference
test_deletion.reference test_dump.reference
test_fanout.reference test_filter.reference
test_nhlookup.reference test_ribin.reference
test_ribout.reference update_test.cc
xorp/bgp/harness/: peer.cc
Log message:
Major cleanup of the AsPath and related classes:
Use a single class for AS_SET and AS_SEQUENCES, simplify
the internal representation, fix printing, remove some redundant
methods, etc. etc.
The code passes all checks though there are surely some memory leaks
as a result of a change in AsPath::encode() routine that I am going
to address next when revising the Packet class.
This code might still enjoy some work -- e.g. the external
representation of AsPaths (the one used in packets) is quite compact
and fast and easy to parse, which makes me wonder why we are not
using the same one (or something very similar) for internal
representation.
Also, the way the code is structured now, it makes a lot of
possibly unnecessary memory allocations and copies. Once the Packet
class has been revised, we might try to optimize things so that we
construct packets in preallocated buffers.
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs