No subject



Mon Sep 29 21:20:09 2003
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Mon, 29 Sep 2003 21:21:05 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.9p1/8.12.3) with ESMTP id h8U4L5fw073292
	for <atanu@tigger.icir.org>; Mon, 29 Sep 2003 21:21:05 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.3) with ESMTP id h8U4L1H5047216;
	Mon, 29 Sep 2003 21:21:01 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.9/8.12.9) with ESMTP id h8U4L0wG012737;
	Mon, 29 Sep 2003 21:21:01 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.9/8.12.9) with ESMTP id h8U4KAwG012722
	for <xorp-cvs@icsi.berkeley.edu>; Mon, 29 Sep 2003 21:20:10 -0700 (PDT)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.3) with ESMTP id h8U4K9H5047208;
	Mon, 29 Sep 2003 21:20:09 -0700 (PDT)
	(envelope-from pavlin@possum.icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.9p1/8.12.3) with ESMTP id h8U4K9IK019532;
	Mon, 29 Sep 2003 21:20:09 -0700 (PDT)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200309300420.h8U4K9IK019532@possum.icir.org>
To: Orion Hodson <hodson@icir.org>
cc: pavlin@icir.org, xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/bgp/ bgp.cc next_hop_resolver.cc next_hop_resolver.hh test_next_hop_resolver.cc update_attrib.hh xorp/bgp/harness/ real_trie.hh xorp/etc/templates/ fea.tp xorp/fea/ ifconfig_click.cc ifconfig_click.hh ifconfig_get_proc_linux.cc ifconfig_parse_ifaddrs.cc ifconfig_parse_ifreq.cc ifconfig_parse_nlm.cc ifconfig_parse_rtm.cc ifconfig_set_ioctl.cc ...ifmanager_transaction.hh ...iftree.cc ...iftree.hh ...routing_socket_utils.cc ...test_ifmanager.cc ...xrl_shell_funcs.sh ...xrl_target.cc ...xrl_target.hh xorp/libfeaclient/ ifmgr_atoms.cc ifmgr_atoms.hh ifmgr_cmd_queue.cc ifmgr_cmds.cc ifmgr_cmds.hh ifmgr_xrl_mirror.cc xorp/libxorp/ ipnet.hh ipv4.cc ipv4.hh ipv6.cc ipv6.hh ipvx.cc ipvx.hh ipvxnet.hh old_trie.hh test_ipnet.cc test_ipv4.cc test_ipv6.cc test_ipvx.cc xorp/mld6igmp/ Makefile.am Makefile.in! xorp/ospf! rt_tab_merged.cc test_register_xrls.cc xrl_target.cc xrl_target.hh xorp/rip/ packets.hh xorp/rtrmgr/ config.template xorp/xrl/i!
 nterfaces/ fea_ifmgr.xif fea_ifmgr_mirror.xif fea_ifmgr_mirror_xif.ccfea_ifmgr_mirror_xif.hh fea_ifmgr_xif.cc fea_ifmgr_xif.hh rib.xif rib_xif.cc ...rib_xif.hh xorp/xrl/targets/ fea.xrls fea_base.cc fea_base.hh fea_ifmgr_mirror.xrls fea_ifmgr_mirror_base.cc fea_ifmgr_mirror_base.hh rib.xrls rib_base.cc ...rib_base.hh 
In-Reply-To: Message from Orion Hodson <hodson@icir.org> 
   of "Mon, 29 Sep 2003 21:06:39 PDT." <200309300406.h8U46dCu041280@puma.icir.org> 
Date: Mon, 29 Sep 2003 21:20:09 -0700
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> /-- Pavlin Radoslavov wrote:
> | CVSROOT:	/usr/local/share/doc/apache/cvs
> | Module name:	xorp
> | Repository:	xorp/xrl/targets/
> | Changes by:	pavlin@xorpc.icir.org.	03/09/29 20:08:05
> | 
> | Modified files:
> | 	xorp/bgp/: bgp.cc next_hop_resolver.cc next_hop_resolver.hh 
> | 	           test_next_hop_resolver.cc update_attrib.hh 
> | 	xorp/bgp/harness/: real_trie.hh 
> | 	xorp/etc/templates/: fea.tp 
> | 	xorp/fea/: ifconfig_click.cc ifconfig_click.hh 
> | 	           ifconfig_get_proc_linux.cc ifconfig_parse_ifaddrs.cc 
> | 	           ifconfig_parse_ifreq.cc ifconfig_parse_nlm.cc 
> | 	           ifconfig_parse_rtm.cc ifconfig_set_ioctl.cc 
> | 	           ifmanager_transaction.hh iftree.cc iftree.hh 
> | 	           routing_socket_utils.cc test_ifmanager.cc 
> | 	           xrl_shell_funcs.sh xrl_target.cc xrl_target.hh 
> | 	xorp/libfeaclient/: ifmgr_atoms.cc ifmgr_atoms.hh 
> | 	                    ifmgr_cmd_queue.cc ifmgr_cmds.cc 
> | 	                    ifmgr_cmds.hh ifmgr_xrl_mirror.cc 
> | 	xorp/libxorp/: ipnet.hh ipv4.cc ipv4.hh ipv6.cc ipv6.hh ipvx.cc 
> | 	               ipvx.hh ipvxnet.hh old_trie.hh test_ipnet.cc 
> | 	               test_ipv4.cc test_ipv6.cc test_ipvx.cc 
> | 	xorp/mld6igmp/: Makefile.am Makefile.in 
> | 	xorp/ospfd/xorp/: system.C 
> | 	xorp/rib/: rt_tab_base.hh rt_tab_extint.cc rt_tab_merged.cc 
> | 	           test_register_xrls.cc xrl_target.cc xrl_target.hh 
> | 	xorp/rip/: packets.hh 
> | 	xorp/rtrmgr/: config.template 
> | 	xorp/xrl/interfaces/: fea_ifmgr.xif fea_ifmgr_mirror.xif 
> | 	                      fea_ifmgr_mirror_xif.cc 
> | 	                      fea_ifmgr_mirror_xif.hh fea_ifmgr_xif.cc 
> | 	                      fea_ifmgr_xif.hh rib.xif rib_xif.cc 
> | 	                      rib_xif.hh 
> | 	xorp/xrl/targets/: fea.xrls fea_base.cc fea_base.hh 
> | 	                   fea_ifmgr_mirror.xrls 
> | 	                   fea_ifmgr_mirror_base.cc 
> | 	                   fea_ifmgr_mirror_base.hh rib.xrls rib_base.cc 
> | 	                   rib_base.hh 
> | 
> | Log message:
> | 	Methods and variables renaming (for consistency and clarity):
> | 	
> | 	* prefix -> prefix_len
> | 	The renaming is for class methods and variable names when we
> | 	refer to prefix length of integer type; those are the majority
> | 	of the changes.
> | 	* preflen -> prefix_len
> | 	* IPv{4,6,X}::mask_by_prefix() -> mask_by_prefix_len()
> | 	* IPv{4,6,X}::prefix_length() -> masklen()
> 
> By the same rationale that replaced preflen with prefix_len, shouldn't masklen 
> be replaced by mask_len?

I thought about that, but "masklen" itself didn't sound that bad as
a single word :)

Either way is fine for me, so for the sake of consistency I will
rename masklen to mask_len, unless other people have objections to
that.

Pavlin
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs