No subject



Thu Mar 18 20:27:35 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Thu, 18 Mar 2004 20:28:01 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i2J4S1ZK008913
	for <atanu@tigger.icir.org>; Thu, 18 Mar 2004 20:28:01 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i2J4S0BR049320
	for <atanu@icir.org>; Thu, 18 Mar 2004 20:28:00 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i2J4S0HH029252;
	Thu, 18 Mar 2004 20:28:00 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i2J4RlHH029242
	for <xorp-cvs@icsi.berkeley.edu>; Thu, 18 Mar 2004 20:27:47 -0800 (PST)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i2J4RZBR049316;
	Thu, 18 Mar 2004 20:27:35 -0800 (PST)
	(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.9p1/8.12.8) with ESMTP id i2J4RZRj021238;
	Thu, 18 Mar 2004 20:27:35 -0800 (PST)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200403190427.i2J4RZRj021238@possum.icir.org>
To: Orion Hodson <hodson@icir.org>
cc: pavlin@icir.org, xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/rip/ xrl_target_ripng.cc 
In-Reply-To: Message from Orion Hodson <hodson@icir.org> 
   of "Thu, 18 Mar 2004 18:54:44 PST." <200403190254.i2J2sieh035600@puma.icir.org> 
Date: Thu, 18 Mar 2004 20:27:35 -0800
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> /-- Pavlin Radoslavov wrote:
> | CVSROOT:	/usr/local/share/doc/apache/cvs
> | Module name:	xorp
> | Repository:	xorp/rip/
> | Changes by:	pavlin@xorpc.icir.org.	04/03/18 17:46:27
> | 
> | Modified files:
> | 	xorp/rip/: xrl_target_ripng.cc 
> | 
> | Log message:
> | 	Include "rip_module.h"
> 
> And it's not needed here either.

I heard that the first time :)

After I replaced assert() with XLOG_ASSERT() in libxorp/trie.hh and
libxorp/ref_trie.hh I got a compilation error in the above file and
the other files I commited before (because the xlog stuff requires
XORP_MODULE_NAME being defined).
The reason the compilation error got propagated into rip is because
libxorp/trie.hh is included by rip/route_db.hh (even though I
don't know whether the Trie stuff is really used).
If you don't need to include trie.hh, then there is no need to
include rip_module.h as well.

In any case, feel free to provide an alternative solution.

Thanks,
Pavlin
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs