No subject
Sat Mar 20 19:14:08 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Sat, 20 Mar 2004 19:15:01 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i2L3F1ZK098401
for <atanu@tigger.icir.org>; Sat, 20 Mar 2004 19:15:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i2L3F1BR080915
for <atanu@icir.org>; Sat, 20 Mar 2004 19:15:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i2L3F0Gv022807;
Sat, 20 Mar 2004 19:15:01 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i2L3EAGv022784
for <xorp-cvs@icsi.berkeley.edu>; Sat, 20 Mar 2004 19:14:10 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i2L3E9BR080910
for <xorp-cvs@icir.org>; Sat, 20 Mar 2004 19:14:09 -0800 (PST)
(envelope-from hodson@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i2L3E9RS018062
for <xorp-cvs@icir.org>; Sat, 20 Mar 2004 19:14:09 -0800 (PST)
(envelope-from hodson@xorpc.icir.org)
Received: (from hodson@localhost)
by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i2L3E9VL018061;
Sat, 20 Mar 2004 19:14:09 -0800 (PST)
(envelope-from hodson)
From: Orion Hodson <hodson@icir.org>
Message-Id: <200403210314.i2L3E9VL018061@xorpc.icir.org>
Date: Sat, 20 Mar 2004 19:14:08 ()
To: xorp-cvs@icir.org
Reply-To: hodson@icir.org
Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm/ comm_api.h comm_private.h comm_sock.c comm_user.c
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/www/data/cvs
Module name: xorp
Repository: xorp/libcomm/
Changes by: hodson@xorpc.icir.org. 04/03/20 19:14:08
Modified files:
xorp/libcomm/: comm_api.h comm_private.h comm_sock.c comm_user.c
Log message:
o Unconditionally present ipv6 method prototypes in comm_api.h.
o Add comm_ipv4_present() and comm_ipv6_present() to indicate support.
The latter can be used as an alternative to testing for HAVE_IPV6.
o Add comm_sock_no_ipv6(const char* method, ...) to report calls to
IPv6 methods when not support is not present and swallow unused args.
o Implement IPv6 methods when IPv6 support is not present to call
comm_sock_no_ipv6() and return XORP_ERROR.
o Replace "assert(false); XLOG_ERROR(...)" with "XLOG_FATAL(...)"
These changes mean that libcomm methods need to be conditionally
called based on whether HAVE_IPV6 is defined. This allows us to
improve readability in IPv6 code paths and worry less about build
system variations. Should we ever find a system without the basic
IPv6 types we'll need to define them ourselves, but we'd need to this
for libxorp anyway.
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs