No subject
Thu Apr 01 12:12:52 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Thu, 01 Apr 2004 12:13:02 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i31KD1Jw063402
for <atanu@tigger.icir.org>; Thu, 1 Apr 2004 12:13:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i31KD1b0070777
for <atanu@icir.org>; Thu, 1 Apr 2004 12:13:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i31KD1eB000016;
Thu, 1 Apr 2004 12:13:01 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i31KCseB000007
for <xorp-cvs@icsi.berkeley.edu>; Thu, 1 Apr 2004 12:12:54 -0800 (PST)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i31KCqb0070775;
Thu, 1 Apr 2004 12:12:52 -0800 (PST)
(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
by possum.icir.org (8.12.9p1/8.12.8) with ESMTP id i31KCqr6005312;
Thu, 1 Apr 2004 12:12:52 -0800 (PST)
(envelope-from pavlin@possum.icir.org)
Message-Id: <200404012012.i31KCqr6005312@possum.icir.org>
To: mjh@icir.org
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/bgp/ bgp_trie.cc bgp_trie.hh dump_iterators.cc internal_message.cc next_hop_resolver.hh path_attribute.cc peer.cc peer.hh peer_handler.cc plumbing.cc rib_ipc_handler.cc rib_ipc_handler.hh ...route_table_cache.cc ...route_table_cache.hh ...route_table_debug.cc ...route_table_decision.cc ...route_table_deletion.cc ...route_table_dump.cc ...route_table_fanout.cc ...route_table_filter.cc ...route_table_nhlookup.cc ...route_table_ribin.cc ...route_table_ribin.hh ...route_table_ribout.cc ...subnet_route.cc ...subnet_route.hh ...test_decision.cc ...test_dump.cc ...test_next_hop_resolver.cc xorp/bgp/harness/ peer.cc test_peering2.sh test_trie.cc xorp/libxorp/ callback-gen.py callback_debug.hh callback_nodebug.hh nexthop.cc ref_trie.hh xorp/mrt/ mrt.hh xorp/pim/ pim_proto_register.cc xorp/policy/ policy_route.cc xorp/rib/ rib.cc rt_tab_deletion.cc rt_tab_expect.cc ! ! rt_tab_export.cc rt_tab_extint.cc rt_tab_log.cc rt_tab_log.hh rt_tab_me!
rged.cc rt_tab_origin.cc rt_tab_redist.cc rt_tab_register.cc ...rt_tab_register.hh xorp/utils/flower_malloc/ flower_malloc.c
In-Reply-To: Message from Mark Handley <mjh@icir.org>
of "Thu, 01 Apr 2004 11:54:13." <200404011954.i31JsDbe069429@xorpc.icir.org>
Date: Thu, 01 Apr 2004 12:12:52 -0800
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
> xorp/pim/: pim_proto_register.cc
Mark,
The gcc-3.4 changes in the above file are like:
OLD:
source_addr.copy_out(ip6_header.ip6_src);
NEW:
source_addr.copy_out((uint8_t*)&(ip6_header.ip6_src));
Where source_addr is IPvX, and ip6_header.ip6_src is defined in
<netinet/ip6.h> as "struct in6_addr".
Inside libxorp/ipvx.hh there is already method
IPvX::copy_out(in6_addr& to_in6_addr);
Why would the above copy_out method fail with gcc-3.4 so it requires
the (uint8_t*) casting?
Does it have to do something with the fact that the IPvX::copy_out()
argument type is "in6_addr" instead of "struct in6_addr"?
Pavlin
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs