No subject
Sun May 30 3:06:05 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Sun, 30 May 2004 03:07:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i4UA71NG043775
for <atanu@tigger.icir.org>; Sun, 30 May 2004 03:07:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i4UA71PA046438
for <atanu@icir.org>; Sun, 30 May 2004 03:07:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i4UA71Yq006124;
Sun, 30 May 2004 03:07:01 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i4UA65Yq006113
for <xorp-cvs@icsi.berkeley.edu>; Sun, 30 May 2004 03:06:05 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i4UA65PA046420
for <xorp-cvs@icir.org>; Sun, 30 May 2004 03:06:05 -0700 (PDT)
(envelope-from pavlin@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i4UA65gd095283
for <xorp-cvs@icir.org>; Sun, 30 May 2004 03:06:05 -0700 (PDT)
(envelope-from pavlin@xorpc.icir.org)
Received: (from pavlin@localhost)
by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i4UA65Ut095282;
Sun, 30 May 2004 03:06:05 -0700 (PDT)
(envelope-from pavlin)
From: Pavlin Radoslavov <pavlin@icir.org>
Message-Id: <200405301006.i4UA65Ut095282@xorpc.icir.org>
Date: Sun, 30 May 2004 3:06:05 ()
To: xorp-cvs@icir.org
Reply-To: pavlin@icir.org
Subject: [Xorp-cvs] XORP cvs commit: xorp/pim/ pim_mfc.cc
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/share/doc/apache/cvs
Module name: xorp
Repository: xorp/pim/
Changes by: pavlin@xorpc.icir.org. 04/05/30 03:06:05
Modified files:
xorp/pim/: pim_mfc.cc
Log message:
Remove code in PimMfc::recompute_iif_olist_mfc() that
unnecessary removes the PimMfc entry if its old olist was NULL.
Originally, the code was needed so once the PimMfc entry is
deleted, then the NOCACHE upcall will not only recreate it,
but will also trigger recomputation of the SPT bit for the
corresponding (S,G) entry.
However, the side effect of removing a PimMfc entry was that
the (S,G) KeepAlive timer was automatically cancelled.
The KeepAlive timer cancellation would eventually affect
the (S,G) routing state and would result in other various side
effects and undesired behavior.
Now this code can be removed, because the state-dependency
tracking machinery takes care of the SPT bit so we don't
need to re-create the PimMfc entry just to update that bit.
[Bug report by Marian Durkovic <md@bts.sk>]
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs