No subject



Tue Jun 01 19:55:37 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Tue, 01 Jun 2004 11:56:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i51Iu1NG087213
	for <atanu@tigger.icir.org>; Tue, 1 Jun 2004 11:56:01 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i51Iu0PA084099
	for <atanu@icir.org>; Tue, 1 Jun 2004 11:56:00 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i51Iu0Yq010900;
	Tue, 1 Jun 2004 11:56:00 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i51ItdYq010877
	for <xorp-cvs@icsi.berkeley.edu>; Tue, 1 Jun 2004 11:55:39 -0700 (PDT)
Received: from aardvark.cs.ucl.ac.uk (aardvark.cs.ucl.ac.uk [128.16.11.150])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i51ItcPA084095;
	Tue, 1 Jun 2004 11:55:38 -0700 (PDT)
	(envelope-from mjh@cs.ucl.ac.uk)
Received: from aardvark.cs.ucl.ac.uk (localhost [127.0.0.1])
	by aardvark.cs.ucl.ac.uk (8.12.9p2/8.12.8) with ESMTP id i51ItbxF011012;
	Tue, 1 Jun 2004 19:55:37 +0100 (BST)
	(envelope-from mjh@aardvark.cs.ucl.ac.uk)
From: Mark Handley <M.Handley@cs.ucl.ac.uk>
X-Organisation: UCL
To: pavlin@icir.org
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr/ cli.cc cli.hh 
In-reply-to: Your message of "Mon, 31 May 2004 21:39:54."
             <200406010439.i514dst4039658@xorpc.icir.org> 
Date: Tue, 01 Jun 2004 19:55:37 +0100
Message-ID: <11011.1086116137@aardvark.cs.ucl.ac.uk>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>


>	Add new "create" configuration-mode command that is used to
>	invoke the xorpsh built-in configuration creation+editing mode.
>	
>	Previously, typing just a template path (e.g., "protocols bgp")
>	would invoke that mode. Now we must use the command "create".
>	E.g., "create protocols bgp" or "create protocols bgp {"


Personally I rather liked the old behaviour :-) I agree that the mode
change entering direct entry mode was confusing.  I'd probably have
solved this by printing a message "[Entering create mode]" or
something similar.

However, given that you've changed it, I thought I should probably see
what Juniper do.  It's not easy to find the right documentation, but
here it is:

  http://www.juniper.net/techpubs/software/junos/junos63/swconfig63-system-basics/frameset.htm

Somehow I must have been rather confused when I coded the old behaviour.
Basically Juniper use both the "set" and "edit" commands to extend the
current configuration, as well as to navigate it.

Now, the current solution with "create" is definitely workable.  But
it leads to the question of whether we want to be more Juniper-like,
or whether we're happy with the current solution for this release?

 - Mark
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs