No subject

Fri Jun 04 05:00:56 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 04 Jun 2004 05:01:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i54C11NG016679
	for <atanu@tigger.icir.org>; Fri, 4 Jun 2004 05:01:01 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i54C10MV005087
	for <atanu@icir.org>; Fri, 4 Jun 2004 05:01:00 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i54C10Yq015991;
	Fri, 4 Jun 2004 05:01:00 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i54C0wYq015984
	for <xorp-cvs@icsi.berkeley.edu>; Fri, 4 Jun 2004 05:00:58 -0700 (PDT)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i54C0uMV005081;
	Fri, 4 Jun 2004 05:00:56 -0700 (PDT)
	(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.9p1/8.12.8) with ESMTP id i54C0uKh073607;
	Fri, 4 Jun 2004 05:00:56 -0700 (PDT)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200406041200.i54C0uKh073607@possum.icir.org>
To: mjh@icir.org
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr/ config.boot 
In-Reply-To: Message from Mark Handley <mjh@icir.org> 
   of "Fri, 04 Jun 2004 02:51:37." <200406040951.i549pbSU075527@xorpc.icir.org> 
Date: Fri, 04 Jun 2004 05:00:56 -0700
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> CVSROOT:	/usr/local/share/doc/apache/cvs
> Module name:	xorp
> Repository:	xorp/rtrmgr/
> Changes by:	mjh@xorpc.icir.org.	04/06/04 02:51:37
> 
> Modified files:
> 	xorp/rtrmgr/: config.boot 
> 
> Log message:
> 	XORP config files are supposed to start with "/*XORP" so we can
> 	identify them, and avoid the risk of rtrmgr overwriting something it
> 	shouldn't.

Mark,

For consistency with the XORP coding style, can we add spaces after
the beginning and before the end of the comment (the same applies
also for the auto-generated header when the configuration is saved
from within xorpsh). E.g.,:
OLD:   /*XORP Configuration File*/
NEW:   /* XORP Configuration File */

Also, while on the subject, when a file is saved from within xorpsh,
what about we start using now a simple template header with some
basic info about that file. E.g., off the top of my head:

/*
 * XORP Configuration File
 *
 * XORP Version: 1.0
 * File Format Version: 1.0
 * Generated: Fri Jun  4 04:47:49 PDT 2004
 * Created by: mjh
 */

The "XORP Version" string may be useful if we ask someone to save
their configuration file from within xorpsh and send it to us.

The "File Format Version" string eventually corresponds to the
configuration file format that should be independent from the XORP
release version. Thus if, say, in the future something about the
file format changes, then we may be able to use it for backward
compatibility support.

Pavlin
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs