No subject
Fri Jun 04 13:45:59 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 04 Jun 2004 05:47:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.9p1/8.12.8) with ESMTP id i54Cl1NG024644
for <atanu@tigger.icir.org>; Fri, 4 Jun 2004 05:47:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i54Cl1MV005653
for <atanu@icir.org>; Fri, 4 Jun 2004 05:47:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i54Cl1Yq017218;
Fri, 4 Jun 2004 05:47:01 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i54Ck3Yq017194
for <xorp-cvs@icsi.berkeley.edu>; Fri, 4 Jun 2004 05:46:03 -0700 (PDT)
Received: from aardvark.cs.ucl.ac.uk (aardvark.cs.ucl.ac.uk [128.16.11.150])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i54Ck2MV005647;
Fri, 4 Jun 2004 05:46:02 -0700 (PDT)
(envelope-from mjh@cs.ucl.ac.uk)
Received: from aardvark.cs.ucl.ac.uk (localhost [127.0.0.1])
by aardvark.cs.ucl.ac.uk (8.12.9p2/8.12.8) with ESMTP id i54CjxxF045703;
Fri, 4 Jun 2004 13:45:59 +0100 (BST)
(envelope-from mjh@aardvark.cs.ucl.ac.uk)
From: Mark Handley <M.Handley@cs.ucl.ac.uk>
X-Organisation: UCL
To: Pavlin Radoslavov <pavlin@icir.org>
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr/ config.boot
In-reply-to: Your message of "Fri, 04 Jun 2004 05:00:56 PDT."
<200406041200.i54C0uKh073607@possum.icir.org>
Date: Fri, 04 Jun 2004 13:45:59 +0100
Message-ID: <45702.1086353159@aardvark.cs.ucl.ac.uk>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
>For consistency with the XORP coding style, can we add spaces after
>the beginning and before the end of the comment (the same applies
>also for the auto-generated header when the configuration is saved
>from within xorpsh). E.g.,:
>OLD: /*XORP Configuration File*/
>NEW: /* XORP Configuration File */
I'd be OK with this. I was thinking of this as the equivalent of the
postscript comment: %!PS
The sole purpose is to have a tag at the start of the file, so that if
the user gets brain-fade, they can't overwrite anything that isn't
already a XORP config file.
Currently it searches for only /*XORP, but we should probably be more
liberal than this.
>Also, while on the subject, when a file is saved from within xorpsh,
>what about we start using now a simple template header with some
>basic info about that file. E.g., off the top of my head:
>
>/*
> * XORP Configuration File
> *
> * XORP Version: 1.0
> * File Format Version: 1.0
> * Generated: Fri Jun 4 04:47:49 PDT 2004
> * Created by: mjh
> */
>
>The "XORP Version" string may be useful if we ask someone to save
>their configuration file from within xorpsh and send it to us.
>
>The "File Format Version" string eventually corresponds to the
>configuration file format that should be independent from the XORP
>release version. Thus if, say, in the future something about the
>file format changes, then we may be able to use it for backward
>compatibility support.
Good idea.
I think both of these can wait til after the release - they're good
suggestions, but not critical.
- Mark
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs