No subject
Thu Aug 19 02:00:21 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Wed, 18 Aug 2004 19:01:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id i7J211i8062305
for <atanu@tigger.icir.org>; Wed, 18 Aug 2004 19:01:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i7J211ZN018082
for <atanu@icir.org>; Wed, 18 Aug 2004 19:01:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.icsi.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i7J211jS014408;
Wed, 18 Aug 2004 19:01:01 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.icsi.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i7J20MjS014344
for <xorp-cvs@icsi.berkeley.edu>; Wed, 18 Aug 2004 19:00:22 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i7J20LZN018079
for <xorp-cvs@icir.org>; Wed, 18 Aug 2004 19:00:21 -0700 (PDT)
(envelope-from pavlin@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i7J20L8M093434
for <xorp-cvs@icir.org>; Wed, 18 Aug 2004 19:00:21 -0700 (PDT)
(envelope-from pavlin@xorpc.icir.org)
Received: (from pavlin@localhost)
by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i7J20Lsf093433
for xorp-cvs@icir.org; Thu, 19 Aug 2004 02:00:21 GMT
(envelope-from pavlin)
Date: Thu, 19 Aug 2004 02:00:21 GMT
From: Pavlin Radoslavov <pavlin@icir.org>
Message-Id: <200408190200.i7J20Lsf093433@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/share/doc/apache/cvs
Module name: xorp
Changes by: pavlin@xorpc.icir.org 2004-08-19 02:00:21 UTC
XORP CVS repository
Modified files:
rtrmgr Makefile.am Makefile.in conf_tree_node.cc
conf_tree_node.hh main_rtrmgr.cc main_rtrmgr.hh
module_manager.cc module_manager.hh
test_module_manager.cc test_sample_config.cc
Log message:
Added a mechanism for the rtrmgr to restart a process that has
unexpectedly died.
Currently, the mechanism is based on observing the child process
status of a processes that was forked by the rtrmgr.
However, if the child process was killed by SIGTERM or SIGKILL,
then that process is NOT restarted; the assumption is that
the user really wanted that process killed.
However, the restarting does not always work properly. E.g.,
if a process fails during reconfiguration via xorpsh, then
the rtrmgr itself may coredump. One of the reasons for the
coredump is because there are outstanding XRLs that haven't
been completed (or failed) when the child process failed,
and restarting is possible only if the previous state was clean.
Fixing the problem requires some non-trivial changes to the rtrmgr.
Therefore, the restarting mechanism is disabled by default,
and can be enabled by the new "-r" rtrmgr command-line option.
Ideally, we would use the finder to observe the XRL status of those
processes, therefore in the future this mechanism may be removed.
The code for restarting failed processes is based on a patch
provided by "Ray Qiu <ray.qiu@gmail.com>"
Submitted by: Ray Qiu <ray.qiu@gmail.com>
Revision Changes Path
1.29 +5 -1 xorp/rtrmgr/Makefile.am
1.40 +14 -14 xorp/rtrmgr/Makefile.in
1.52 +15 -1 xorp/rtrmgr/conf_tree_node.cc
1.26 +2 -1 xorp/rtrmgr/conf_tree_node.hh
1.52 +28 -5 xorp/rtrmgr/main_rtrmgr.cc
1.9 +3 -1 xorp/rtrmgr/main_rtrmgr.hh
1.34 +54 -4 xorp/rtrmgr/module_manager.cc
1.23 +16 -2 xorp/rtrmgr/module_manager.hh
1.12 +5 -2 xorp/rtrmgr/test_module_manager.cc
1.17 +4 -2 xorp/rtrmgr/test_sample_config.cc
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs