No subject
Wed Aug 25 06:23:52 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Tue, 24 Aug 2004 23:24:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id i7P6O104078766
for <atanu@tigger.icir.org>; Tue, 24 Aug 2004 23:24:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i7P6O1ZN026342
for <atanu@icir.org>; Tue, 24 Aug 2004 23:24:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i7P6O1NB027064;
Tue, 24 Aug 2004 23:24:01 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i7P6NqNB027056
for <xorp-cvs@icsi.berkeley.edu>; Tue, 24 Aug 2004 23:23:52 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i7P6NqZN026339
for <xorp-cvs@icir.org>; Tue, 24 Aug 2004 23:23:52 -0700 (PDT)
(envelope-from pavlin@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i7P6Nq8M080476
for <xorp-cvs@icir.org>; Tue, 24 Aug 2004 23:23:52 -0700 (PDT)
(envelope-from pavlin@xorpc.icir.org)
Received: (from pavlin@localhost)
by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i7P6NqDa080475
for xorp-cvs@icir.org; Wed, 25 Aug 2004 06:23:52 GMT
(envelope-from pavlin)
Date: Wed, 25 Aug 2004 06:23:52 GMT
From: Pavlin Radoslavov <pavlin@icir.org>
Message-Id: <200408250623.i7P6NqDa080475@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/pim
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/share/doc/apache/cvs
Module name: xorp
Changes by: pavlin@xorpc.icir.org 2004-08-25 06:23:52 UTC
XORP CVS repository
Modified files:
fea mfea_proto_comm.cc
pim configure_pim pim_proto_register.cc
Log message:
Add explicit casting when directly accessing fields in "struct ip":
ipvx.copy_out(ip->ip_src) ->
ipvx.copy_out(static_cast<struct in_addr&>(ip->ip_src));
The cast is a work-around because of a probably broken
gcc-3.4.2 compiler on FreeBSD-5.3-x that gives the following error:
g++ -DHAVE_CONFIG_H -I. -I. -I.. -I.. -g -W -Wall -Wwrite-strings
-Wcast-qual -Werror -Wpointer-arith -Wcast-align -Woverloaded-virtual
-ftemplate-depth-20 -c -o mfea_proto_comm.o `test -f mfea_proto_comm.cc
|| echo './'`mfea_proto_comm.cc
mfea_proto_comm.cc: In member function
`int ProtoComm::proto_socket_write(uint16_t, const IPvX&, const IPvX&,
int, int, bool, const uint8_t*, size_t)':
mfea_proto_comm.cc:1521: error: cannot bind packed field `ip->ip::ip_src'
to `in_addr&'
mfea_proto_comm.cc:1522: error: cannot bind packed field `ip->ip::ip_dst'
to `in_addr&'
The reason for the compilation error is because "struct ip" has been
defined as __packed.
Bug found by: Dikshie <dikshie@lapi.itb.ac.id>
Revision Changes Path
1.19 +3 -3 xorp/fea/mfea_proto_comm.cc
1.35 +2 -2 xorp/pim/configure_pim
1.16 +3 -3 xorp/pim/pim_proto_register.cc
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs