No subject



Sun Sep 26 22:35:15 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Sun, 26 Sep 2004 22:36:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id i8R5a18K065120
	for <atanu@tigger.icir.org>; Sun, 26 Sep 2004 22:36:01 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i8R5a0NK093994
	for <atanu@icir.org>; Sun, 26 Sep 2004 22:36:01 -0700 (PDT)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i8R5a0GF027540;
	Sun, 26 Sep 2004 22:36:00 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i8R5ZFGF027520
	for <xorp-cvs@icsi.berkeley.edu>; Sun, 26 Sep 2004 22:35:15 -0700 (PDT)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i8R5ZFNK093989;
	Sun, 26 Sep 2004 22:35:15 -0700 (PDT)
	(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.9p1/8.12.8) with ESMTP id i8R5ZFwK057150;
	Sun, 26 Sep 2004 22:35:15 -0700 (PDT)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200409270535.i8R5ZFwK057150@possum.icir.org>
To: Pavlin Radoslavov <pavlin@icir.org>
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/policy/test 
In-Reply-To: Message from Pavlin Radoslavov <pavlin@icir.org> 
   of "Mon, 27 Sep 2004 04:58:39 GMT." <200409270458.i8R4wdL4020310@xorpc.icir.org> 
Date: Sun, 26 Sep 2004 22:35:15 -0700
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> CVSROOT:	/usr/local/share/doc/apache/cvs
> Module name:	xorp
> Changes by:	pavlin@xorpc.icir.org	2004-09-27 04:58:39 UTC
> 
> XORP CVS repository
> 
> 
> Modified files:
> 	policy/test   file_varrw.cc 
> 
> Log message:
> 	Bug fix: refactor the mechanism to obtain the third field (the value)
> 	from the iss input string stream.
> 	
> 	Previously, method in_avail() was used incorrectly as a method
> 	that returns how any characters are available in the buffer.
> 	The return value of in_avail() should be used only to indicate whether
> 	there is any data available in the buffer.

The above comment is incorrect. In the original code, in_avail() was
used correctly; however, it appears that the STL implementation with
gcc-2.9.x on Linux (e.g. RedHat-7.3) is buggy: in_avail() returns 1
if there is any data in the buffer, and 0 otherwise.

In other words, the new refactored code is a work-around for such
buggy STL implementation.

Pavlin

> 
> Revision  Changes    Path
> 1.2       +9 -11     xorp/policy/test/file_varrw.cc
> _______________________________________________
> Xorp-cvs mailing list
> Xorp-cvs@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs

_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs