No subject
Mon Sep 27 10:35:15 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Mon, 27 Sep 2004 03:36:01 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id i8RAa1qD026566
for <atanu@tigger.icir.org>; Mon, 27 Sep 2004 03:36:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i8RAa1NK097220
for <atanu@icir.org>; Mon, 27 Sep 2004 03:36:01 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i8RAa0GF004093;
Mon, 27 Sep 2004 03:36:00 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i8RAZGGF004078
for <xorp-cvs@icsi.berkeley.edu>; Mon, 27 Sep 2004 03:35:16 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i8RAZGNK097217
for <xorp-cvs@icir.org>; Mon, 27 Sep 2004 03:35:16 -0700 (PDT)
(envelope-from abittau@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i8RAZFIb023012
for <xorp-cvs@icir.org>; Mon, 27 Sep 2004 03:35:15 -0700 (PDT)
(envelope-from abittau@xorpc.icir.org)
Received: (from abittau@localhost)
by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i8RAZFVA023011
for xorp-cvs@icir.org; Mon, 27 Sep 2004 10:35:15 GMT
(envelope-from abittau)
Date: Mon, 27 Sep 2004 10:35:15 GMT
From: Andrea Bittau <abittau@icir.org>
Message-Id: <200409271035.i8RAZFVA023011@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/www/data/cvs
Module name: xorp
Changes by: abittau@xorpc.icir.org 2004-09-27 10:35:15 UTC
XORP CVS repository
Modified files:
bgp bgp_varrw.cc bgp_varrw.hh
Log message:
The bug technically lies in route_table_policy.cc but I preferred a more generic
fix.
If a route is modified but rejected, the caller should obtain the filtered
message and delete it. This does not occur in route_table_policy.cc. A scenario
depicting this is actually present in policy/test/policy2.src.
If BGPVarRW was used, there would have been a memory leak.
As a fix, the BGPVarRW will check if the caller obtained the filtered message.
If it didn't, BGPVarRW will delete the filtered message upon its destruction.
Revision Changes Path
1.4 +11 -2 xorp/bgp/bgp_varrw.cc
1.4 +15 -10 xorp/bgp/bgp_varrw.hh
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs