No subject
Tue Oct 19 08:26:48 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Tue, 19 Oct 2004 01:27:03 -0700
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id i9J8R3Qr019301
for <atanu@tigger.icir.org>; Tue, 19 Oct 2004 01:27:03 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i9J8R2ag053218
for <atanu@icir.org>; Tue, 19 Oct 2004 01:27:02 -0700 (PDT)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i9J8R2fG016211;
Tue, 19 Oct 2004 01:27:02 -0700 (PDT)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id i9J8QmfG016188
for <xorp-cvs@icsi.berkeley.edu>; Tue, 19 Oct 2004 01:26:48 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id i9J8Qmag053214
for <xorp-cvs@icir.org>; Tue, 19 Oct 2004 01:26:48 -0700 (PDT)
(envelope-from bms@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id i9J8QmL6016425
for <xorp-cvs@icir.org>; Tue, 19 Oct 2004 01:26:48 -0700 (PDT)
(envelope-from bms@xorpc.icir.org)
Received: (from bms@localhost)
by xorpc.icir.org (8.12.11/8.12.3/Submit) id i9J8QmYu016424
for xorp-cvs@icir.org; Tue, 19 Oct 2004 08:26:48 GMT
(envelope-from bms)
Date: Tue, 19 Oct 2004 08:26:48 GMT
From: Bruce Simpson <bms@icir.org>
Message-Id: <200410190826.i9J8QmYu016424@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: other/tinderbox/scripts
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/www/data/cvs
Module name: other
Changes by: bms@xorpc.icir.org 2004-10-19 08:26:48 UTC
XORP CVS repository
Modified files:
tinderbox/scripts build_xorp.sh
Log message:
Major maintenance updates:
* Add a commented ident at the top of the file.
* Remove the timeout() function as it is now unused.
* Remove the funkster() function as it is unused.
* Comment the completion token mechanism used in this script.
* Beautify the whitespace around the build command
subshell invocation.
* Record and print the build subshell exit status.
* Add a comment about how additional improvements might be
made to the subshell invocation.
* Miscellaneous comment improvements.
* Use POSIX shell arithmetic expansion instead of
backtick-escaping the expr(1) command.
* Use POSIX shell command substitution syntax instead of
legacy backticks.
* Do not call the timeout() function from within the loop
used to poll for subshell completion; instead, set a
variable ${timed_out} and check it upon exit.
* If the subshell times out, kill only the subshell which
timed out, not this shell's process group.
NOTE: This script could benefit from further review
regarding the use of POSIX /bin/sh job control, and that
the use of such job control on FreeBSD requires that the
process have a controlling terminal (i.e. that /dev/tty
point to a real file descriptor), and that this can be
forcibly created by ssh(1) with the switches '-t -t'.
Revision Changes Path
1.8 +74 -43 other/tinderbox/scripts/build_xorp.sh
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs