No subject



Thu Nov 18 11:30:30 2004
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Thu, 18 Nov 2004 11:31:02 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id iAIJV2FR065386
	for <atanu@tigger.icir.org>; Thu, 18 Nov 2004 11:31:02 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id iAIJV129054049
	for <atanu@icir.org>; Thu, 18 Nov 2004 11:31:01 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id iAIJV1N1015484;
	Thu, 18 Nov 2004 11:31:01 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id iAIJUUN1015454
	for <xorp-cvs@icsi.berkeley.edu>; Thu, 18 Nov 2004 11:30:30 -0800 (PST)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id iAIJUU29054047;
	Thu, 18 Nov 2004 11:30:30 -0800 (PST)
	(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.11/8.12.8) with ESMTP id iAIJUUr3019321;
	Thu, 18 Nov 2004 11:30:30 -0800 (PST)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200411181930.iAIJUUr3019321@possum.icir.org>
To: Bruce Simpson <bms@icir.org>
cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/fea 
In-Reply-To: Message from Bruce Simpson <bms@icir.org> 
   of "Thu, 18 Nov 2004 14:39:57 GMT." <200411181439.iAIEdvVi010746@xorpc.icir.org> 
Date: Thu, 18 Nov 2004 11:30:30 -0800
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> CVSROOT:	/usr/local/www/data/cvs
> Module name:	xorp
> Changes by:	bms@xorpc.icir.org	2004-11-18 14:39:57 UTC
> 
> XORP CVS repository
> 
> 
> Modified files:
> 	fea           xrl_fti.cc xrl_fti.hh 
> 
> Log message:
> 	Push the event filtering preferences expressed
> 	by FEA FIB clients down into the FibClient
> 	object, and pay attention to them when it's
> 	time to send a FIB event.
> 	
> 	Requested by:   atanu

Nice work!

BTW, when it comes to propagating the updated or unresolved routes,
and if a client has requested to receive, say, only the updates
then is it suppose to receive the unresolved routes as well?
I believe the answer is no. If this is correct, then you you may
want to apply the following simple patch.

Thanks,
Pavlin

Index: xrl_fti.cc
===================================================================
RCS file: /usr/local/share/doc/apache/cvs/xorp/fea/xrl_fti.cc,v
retrieving revision 1.13
diff -c -u -r1.13 xrl_fti.cc
--- xrl_fti.cc	18 Nov 2004 14:39:57 -0000	1.13
+++ xrl_fti.cc	18 Nov 2004 19:26:23 -0000
@@ -483,7 +483,7 @@
     // If FIB updates were requested by the client, then send notification
     // of a route being added or deleted.
     //
-    if (_send_updates) {
+    if (_send_updates && !fte.is_unresolved()) {
 	if (!fte.is_deleted()) {
 	    // Send notification of a route being added
 	    success = _xftm.send_fib_client_add_route(_target_name, fte);

> 
> Revision  Changes    Path
> 1.13      +24 -14    xorp/fea/xrl_fti.cc
> 1.12      +11 -2     xorp/fea/xrl_fti.hh
> _______________________________________________
> Xorp-cvs mailing list
> Xorp-cvs@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs

_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs