No subject
Fri Jan 14 01:35:15 2005
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Thu, 13 Jan 2005 17:36:01 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0E1a1vq022311
for <atanu@tigger.icir.org>; Thu, 13 Jan 2005 17:36:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0E1a1IY068823
for <atanu@icir.org>; Thu, 13 Jan 2005 17:36:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0E1a16p017680;
Thu, 13 Jan 2005 17:36:01 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0E1ZG6p017632
for <xorp-cvs@icsi.berkeley.edu>; Thu, 13 Jan 2005 17:35:16 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0E1ZGIY068809
for <xorp-cvs@icir.org>; Thu, 13 Jan 2005 17:35:16 -0800 (PST)
(envelope-from pavlin@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id j0E1ZFSm091473
for <xorp-cvs@icir.org>; Thu, 13 Jan 2005 17:35:15 -0800 (PST)
(envelope-from pavlin@xorpc.icir.org)
Received: (from pavlin@localhost)
by xorpc.icir.org (8.12.11/8.12.3/Submit) id j0E1ZFfW091472
for xorp-cvs@icir.org; Fri, 14 Jan 2005 01:35:15 GMT
(envelope-from pavlin)
Date: Fri, 14 Jan 2005 01:35:15 GMT
From: Pavlin Radoslavov <pavlin@icir.org>
Message-Id: <200501140135.j0E1ZFfW091472@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/share/doc/apache/cvs
Module name: xorp
Changes by: pavlin@xorpc.icir.org 2005-01-14 01:35:15 UTC
XORP CVS repository
Modified files:
libxipc xrl_atom.cc
Log message:
Bug fix:
Fix the check whether a number of values are all true.
OLD:
return mn == mt == md == mv == true;
NEW:
return ((mn == true) && (mt == true) && (md == true) && (mv == true));
The "==" operator is evaluated left-to-right, hence there
are a number of cases when the old code will fail.
For example, the old code will return true even if the variables have,
say, the following values:
mn = true;
mt = false;
md = false;
mv = true;
Note that the bug is in the XrlAtom::operator== implementation,
which is used in many places by the XRL code. It appears
that so far it hasn't created any notable issues.
After the fix, a single rtrmgr template XRL mismatch was discovered,
and "gmake check" appears to succeed.
Bug found by: "edrt" <edrt@citiz.net>
Revision Changes Path
1.15 +2 -2 xorp/libxipc/xrl_atom.cc
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs