No subject

Fri Jan 28 20:44:37 2005
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 28 Jan 2005 12:45:01 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0SKj16x007161
	for <atanu@tigger.icir.org>; Fri, 28 Jan 2005 12:45:01 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SKj11x014624
	for <atanu@icir.org>; Fri, 28 Jan 2005 12:45:01 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SKj1Ip018879;
	Fri, 28 Jan 2005 12:45:01 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SKiFIp018844
	for <xorp-cvs@icsi.berkeley.edu>; Fri, 28 Jan 2005 12:44:19 -0800 (PST)
Received: from arginine.spc.org ([83.167.185.2])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SKiE1x014614;
	Fri, 28 Jan 2005 12:44:14 -0800 (PST)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id A63026538B; Fri, 28 Jan 2005 20:42:48 +0000 (GMT)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 21029-01; Fri, 28 Jan 2005 20:42:48 +0000 (GMT)
Received: from empiric.dek.spc.org (unknown [213.210.24.3])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 579F2652FE; Fri, 28 Jan 2005 20:42:45 +0000 (GMT)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 6377D63D5; Fri, 28 Jan 2005 20:44:38 +0000 (GMT)
Date: Fri, 28 Jan 2005 20:44:37 +0000
From: Bruce M Simpson <bms@spc.org>
To: Pavlin Radoslavov <pavlin@icir.org>
Cc: xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/libxorp
Message-ID: <20050128204437.GL24432@dhcp120.icir.org>
References: <200501280330.j0S3UFqt081185@xorpc.icir.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200501280330.j0S3UFqt081185@xorpc.icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

On Fri, Jan 28, 2005 at 03:30:15AM +0000, Pavlin Radoslavov wrote:
> Log message:
> 	Remove <net/route.h> and <arpa/inet.h> from the list of included
> 	files, because they shouldn't be here.

This change breaks my uncommitted fix for bug# 110, which needs <arpa/inet.h>
to print a meaningful error message when bind() fails.

I've reintroduced the required includes to socket.cc itself on my
private branch, do you have suggestions as to how/where we should
detect that inet_ntop() is defined?

Or would it be better to cast the sockaddrs to XORP IPvX library types?

Regards,
BMS
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs