No subject



Fri Jan 28 15:35:34 2005
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 28 Jan 2005 15:36:00 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0SNa0lk041331
	for <atanu@tigger.icir.org>; Fri, 28 Jan 2005 15:36:00 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SNa01x016665
	for <atanu@icir.org>; Fri, 28 Jan 2005 15:36:00 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SNa0Ip024487;
	Fri, 28 Jan 2005 15:36:00 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SNZYIp024466
	for <xorp-cvs@icsi.berkeley.edu>; Fri, 28 Jan 2005 15:35:34 -0800 (PST)
Received: from tigger.icir.org (tigger.icir.org [192.150.187.78])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SNZY1x016661;
	Fri, 28 Jan 2005 15:35:34 -0800 (PST)
	(envelope-from atanu@icir.org)
Received: from tigger.icir.org (localhost [127.0.0.1])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0SNZY7D041214;
	Fri, 28 Jan 2005 15:35:34 -0800 (PST)
	(envelope-from atanu@tigger.icir.org)
To: Bruce M Simpson <bms@spc.org>
cc: Pavlin Radoslavov <pavlin@icir.org>, xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/libxorp 
In-Reply-To: Message from Bruce M Simpson <bms@spc.org> 
   of "Fri, 28 Jan 2005 21:34:03 GMT." <20050128213403.GN24432@dhcp120.icir.org> 
From: Atanu Ghosh <atanu@ICSI.Berkeley.EDU>
Reply-To: atanu@ICSI.Berkeley.EDU
X-Organisation: The International Computer Science Institute
X-Phone: +1 510 666 2966
X-Fax: +1 510 666 2956
X-Url: <http://www.icir.org/atanu>
X-Mailer: MH-E 7.4.2; nmh 1.0.3; XEmacs 21.4 (patch 14)
Date: Fri, 28 Jan 2005 15:35:34 -0800
Message-ID: <41213.1106955334@tigger.icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

The rest of the fix is in xrl_target.cc.

We allow an arbitary string to be passed as an address, this allows
IPv4, IPV6 and FQDN. Lets not get into if this is a good idea or
not. One bug was a FQDN that didn't resolve would cause a problem. I
believe that case that triggered the problem was am empty string. The
class Ituple does this lookup. It has always thrown an exception. My fix
was to catch it in xrl_target.cc.

You have now fixed the low level bind problem. There are two common
reasons that the bind will fail. The user is not root, or the local
address not match an inteface address. If might be nice to look at errno
and print a more meaningful error if either of these conditions arises.

You didn't include the patch for bgp.cc, the caller.

I am intending to leave the TCP support in BGP we will use a switch to
enable/disable its use.

       Atanu.

>>>>> "Bruce" == Bruce M Simpson <Bruce> writes:

    Bruce> On Fri, Jan 28, 2005 at 09:16:35PM +0000, Bruce M Simpson
    Bruce> wrote:
    >> Wait, no worries, I've written a fix which uses IPvX::str()
    >> instead of trying to use inet_ntop() directly now.

    Bruce> Here is my diff as it currently stands.  [p4x diff2 -dbuw
    Bruce> //depot/vendor/xorp/bgp/socket.cc
    Bruce> //depot/user/bms/xorp_ng/bgp/socket.cc]

    Bruce> Atanu, you mentioned a change further up in bgp which catches
    Bruce> an exception and might make the function signature / return
    Bruce> value checks in my diff unnecessary.

    Bruce> Can you point me at this change (off the top of your head) ?

    Bruce> [I appreciate that moving BGP to use the FEA for sockets is
    Bruce> what we want to do long term, but I would consider it better
    Bruce> to fix the issue in the short term.]

    Bruce> I'd like to merge a fix for this we're happy with so we can
    Bruce> kill off the bug, so review would be much appreciated!

    Bruce> Pavlin: I agree that the presence/absence of inet_ntop() is a
    Bruce> separate issue (IPvX et al wrap it), let's get the bugs
    Bruce> smashed and worry about portability later.

    Bruce> Thanks, BMS
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs