No subject
Mon Jan 31 01:22:51 2005
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Sun, 30 Jan 2005 17:23:01 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0V1N1K5036861
for <atanu@tigger.icir.org>; Sun, 30 Jan 2005 17:23:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0V1N01x048125
for <atanu@icir.org>; Sun, 30 Jan 2005 17:23:01 -0800 (PST)
(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0V1N0Ip004296;
Sun, 30 Jan 2005 17:23:00 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0V1MpIp004289
for <xorp-cvs@icsi.berkeley.edu>; Sun, 30 Jan 2005 17:22:51 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0V1Mp1x048123
for <xorp-cvs@icir.org>; Sun, 30 Jan 2005 17:22:51 -0800 (PST)
(envelope-from bms@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id j0V1MpAD017769
for <xorp-cvs@icir.org>; Sun, 30 Jan 2005 17:22:51 -0800 (PST)
(envelope-from bms@xorpc.icir.org)
Received: (from bms@localhost)
by xorpc.icir.org (8.12.11/8.12.3/Submit) id j0V1MpHK017768
for xorp-cvs@icir.org; Mon, 31 Jan 2005 01:22:51 GMT
(envelope-from bms)
Date: Mon, 31 Jan 2005 01:22:51 GMT
From: Bruce Simpson <bms@icir.org>
Message-Id: <200501310122.j0V1MpHK017768@xorpc.icir.org>
To: xorp-cvs@icir.org
X-XORP-CVS-Branch: HEAD
Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>
CVSROOT: /usr/local/www/data/cvs
Module name: xorp
Changes by: bms@xorpc.icir.org 2005-01-31 01:22:51 UTC
XORP CVS repository
Modified files:
rtrmgr op_commands.cc
Log message:
Fix an operator precedence bug in the code used to locate
XORP commands in the router manager's path.
Use eaccess() to determine if the desired executable may
be invoked with the router manager's EUID.
Add a comment. Tweak style.
Notes:
1. An S_ISLNK() test is redundant because stat() will
dereference any symlinks in the path.
2. Whilst [e]access() may create race conditions if
used inappropriately, this is no worse than the
previous code because there is no way to protect
against such a race in the case of execv(); it isn't
possible to defeat the race by open()-ing the file
which Module::shell_execute() is about to execv(),
because the exec*() syscalls don't accept file
descriptors instead of pathnames.
Reviewed by: mjh (with input from rwatson at FreeBSD dot org)
Revision Changes Path
1.40 +8 -7 xorp/rtrmgr/op_commands.cc
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs