From atanu@icir.org Tue Nov 1 01:36:02 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 01:36:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511010136.jA11a2nA064456@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 01:36:02 UTC XORP CVS repository Modified files: bgp peer_list.cc peer_list.hh Log message: Add a method to detach a peer that doesn't free the memory for the peer. Add documentation strings to the methods. Revision Changes Path 1.21 +8 -3; commitid: fbab4366c6807ea6; xorp/bgp/peer_list.cc 1.9 +45 -1; commitid: fbab4366c6807ea6; xorp/bgp/peer_list.hh From atanu@icir.org Tue Nov 1 01:38:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 01:38:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511010138.jA11cFOa064530@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 01:38:15 UTC XORP CVS repository Modified files: bgp peer.cc peer.hh Log message: Move the initialising of all the stats counters from the constructor into a separate method. Revision Changes Path 1.99 +16 -10; commitid: fbf54366c7067ea6; xorp/bgp/peer.cc 1.25 +5 -1; commitid: fbf54366c7067ea6; xorp/bgp/peer.hh From atanu@icir.org Tue Nov 1 02:13:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 02:13:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511010213.jA12Djtm064856@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 02:13:45 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh Log message: When a request is made to delete a peer it cannot be deleted immediately because it is necessary to send a notification message with a cease. Move the "deleted" peer to a deleted peer list so that that protocol interactions can complete. If an attempt is made to re-create the peer the deleted peer list is searched revive the peer and all the stats are reset. Revision Changes Path 1.57 +64 -15; commitid: fd3b4366cf587ea6; xorp/bgp/bgp.cc 1.46 +36 -2; commitid: fd3b4366cf587ea6; xorp/bgp/bgp.hh From atanu@icir.org Tue Nov 1 03:14:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 03:14:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib xorp/rip Message-ID: <200511010314.jA13EfZZ065584@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 03:14:41 UTC XORP CVS repository Modified files: rib rib_varrw.cc rip rip_varrw.cc Log message: With this compiler: gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-53) This construct was generating an error: template Element* RIBVarRW::single_read(const Id& /* id */) { XLOG_UNREACHABLE(); } Add return 0. Revision Changes Path 1.9 +3 -1; commitid: 100004366dda07ea6; xorp/rib/rib_varrw.cc 1.8 +3 -1; commitid: 100004366dda07ea6; xorp/rip/rip_varrw.cc From pavlin@icir.org Tue Nov 1 03:57:09 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 03:57:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511010357.jA13v9GT066003@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 03:57:09 UTC XORP CVS repository Modified files: rib rib.cc Log message: * Bug fix when deleting an interface address: delete the address from the local vifs as well. This fixes one of the bugs in bugzilla entry #297: now the connected routes should be updated properly when an address is deleted from one interface and then added to another interface. * Minor cosmetic edits. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=297 Revision Changes Path 1.57 +10 -9; commitid: 1019b4366e6b67ea6; xorp/rib/rib.cc From pavlin@icir.org Tue Nov 1 04:31:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 04:31:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fib2mrib xorp/static_routes xorp/libfeaclient Message-ID: <200511010431.jA14V1xd066435@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 04:31:01 UTC XORP CVS repository Modified files: fib2mrib fib2mrib_node.cc static_routes static_routes_node.cc libfeaclient ifmgr_atoms.cc ifmgr_atoms.hh Log message: Modify the IfMgrIfTree:is_directly_connected() methods to return by reference the name of the corresonding interface and vif (if a directly connected address). Revision Changes Path 1.25 +10 -4; commitid: 103234366ef327ea6; xorp/fib2mrib/fib2mrib_node.cc 1.12 +33 -10; commitid: 103234366ef327ea6; xorp/libfeaclient/ifmgr_atoms.cc 1.22 +25 -4; commitid: 103234366ef327ea6; xorp/libfeaclient/ifmgr_atoms.hh 1.28 +10 -4; commitid: 103234366ef327ea6; xorp/static_routes/static_routes_node.cc From atanu@icir.org Tue Nov 1 04:58:26 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 04:58:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511010458.jA14wQDb066695@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 04:58:26 UTC XORP CVS repository Modified files: bgp peer.cc Log message: If a notify message is received during session setup previously the peer was left in state idle, the reasoning being that the peer had been misconfigured. The state is now left active not idle, therefore allowing incoming connections and the connect retry timer is started. Revision Changes Path 1.100 +6 -1; commitid: 1046c4366f5f17ea6; xorp/bgp/peer.cc From pavlin@icir.org Tue Nov 1 07:31:55 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 07:31:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fib2mrib xorp/static_routes Message-ID: <200511010731.jA17VtS9068201@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 07:31:55 UTC XORP CVS repository Modified files: fib2mrib fib2mrib_node.cc static_routes static_routes_node.cc Log message: Fix the mechanism for updating the routes when the address of an interface is moved to another interface. This fixes one of the bugs in bugzilla entry #297: now the static routes should be updated properly when an address is deleted from one interface and then added to another interface. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=297 Revision Changes Path 1.26 +67 -42; commitid: 109f84367184b7ea6; xorp/fib2mrib/fib2mrib_node.cc 1.29 +67 -42; commitid: 109f84367184b7ea6; xorp/static_routes/static_routes_node.cc From atanu@icir.org Tue Nov 1 08:16:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 08:16:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511010816.jA18GJfh068758@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 08:16:19 UTC XORP CVS repository Modified files: bgp peer.cc Log message: If an open message is received with bad parameters such as an incorrect as number after sending the notify take the peer to idle, rather immediately trying to form a new connection. Revision Changes Path 1.101 +4 -4; commitid: 10c7b436724527ea6; xorp/bgp/peer.cc From atanu@icir.org Tue Nov 1 08:31:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 08:31:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511010831.jA18V7B7069050@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 08:31:07 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: The recommended default value for the holdtime is 90 not 120 seconds. Revision Changes Path 1.59 +2 -2; commitid: 10d9f436727ca7ea6; xorp/etc/templates/bgp.tp From pavlin@icir.org Tue Nov 1 08:35:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 08:35:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511010835.jA18ZO8V069138@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 08:35:24 UTC XORP CVS repository Modified files: rib vifmanager.cc Log message: Refactor the mechanism for updating the interface information: - first delete old vifs and then add new vifs. - delete all obsolete addresses on all interfaces before adding new addresses. This fixes a bug with an atomic moving of an IP address from one interface to another. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=297 Revision Changes Path 1.39 +121 -115; commitid: 10de54367285b7ea6; xorp/rib/vifmanager.cc From pavlin@icir.org Tue Nov 1 08:49:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 08:49:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511010849.jA18nceD069313@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 08:49:38 UTC XORP CVS repository Modified files: rib vifmanager.cc Log message: Remove debug statement that was added by accident in the previous commit. Revision Changes Path 1.40 +1 -3; commitid: 10ea843672bf77ea6; xorp/rib/vifmanager.cc From pavlin@icir.org Tue Nov 1 09:16:16 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 09:16:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200511010916.jA19GGGV069671@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 09:16:16 UTC XORP CVS repository Modified files: fea mfea_node.cc Log message: Refactor the mechanism for updating the interface information: - first delete old vifs and then add and update new vifs. - delete all obsolete addresses on all interfaces before adding new addresses. Revision Changes Path 1.58 +25 -5; commitid: 10ff6436732177ea6; xorp/fea/mfea_node.cc From pavlin@icir.org Tue Nov 1 11:03:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 11:03:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511011103.jA1B3TZG070913@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 11:03:29 UTC XORP CVS repository Modified files: ospf debug_io.hh io.hh ospf.cc xrl_io.cc xrl_io.hh Log message: Fix/refactor the mechanism for updating the network interface status: * Add separate callbacks to update the status of network interfaces and/or vifs and/or addresses. * First delete and modify existing interfaces/vifs/addresses, and then add new entries. * Add separate methods to test whether an interface and/or a vif and/or an address is enabled: is_interface_enabled(), is_vif_enabled(), is_address_enabled(). Revision Changes Path 1.12 +32 -2; commitid: 1144343674a8e7ea6; xorp/ospf/debug_io.hh 1.15 +52 -8; commitid: 1144343674a8e7ea6; xorp/ospf/io.hh 1.48 +2 -2; commitid: 1144343674a8e7ea6; xorp/ospf/ospf.cc 1.21 +230 -71; commitid: 1144343674a8e7ea6; xorp/ospf/xrl_io.cc 1.15 +19 -4; commitid: 1144343674a8e7ea6; xorp/ospf/xrl_io.hh From pavlin@icir.org Tue Nov 1 11:46:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 11:46:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511011146.jA1BkY2I071451@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 11:46:34 UTC XORP CVS repository Modified files: rib xrl_target.cc Log message: Fix a typo inside a debug_msg() Revision Changes Path 1.54 +2 -2; commitid: 117024367558e7ea6; xorp/rib/xrl_target.cc From pavlin@icir.org Tue Nov 1 17:49:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 17:49:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200511011749.jA1Hn5G9076524@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 17:49:05 UTC XORP CVS repository Modified files: fea ifconfig_set.cc Log message: When setting the MTU of an interface, if the interface is up, then explicitly take down the interface before the change and then take it up. We need to do this because of a limitation imposed by the Linux kernel. Note that for the sake of consistency we do it for all OS-es. Bug found by: Michael Larson Revision Changes Path 1.36 +24 -1; commitid: 12ad34367a9f07ea6; xorp/fea/ifconfig_set.cc From kristian@juniks.net Tue Nov 1 18:25:09 2005 From: kristian@juniks.net (Kristian Larsson) Date: Tue, 1 Nov 2005 19:25:09 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/fea In-Reply-To: <200511011749.jA1Hn5G9076524@xorpc.icir.org> References: <200511011749.jA1Hn5G9076524@xorpc.icir.org> Message-ID: <20051101182509.GI3639@juniks.net> Is this really necessary? It seams wrong that all OSes should suffer due to the bad behaviour introduced by Linux. Kristian. On Tue, Nov 01, 2005 at 05:49:05PM +0000, Pavlin Radoslavov wrote: > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: pavlin@xorpc.icir.org 2005-11-01 17:49:05 UTC > > XORP CVS repository > > > Modified files: > fea ifconfig_set.cc > > Log message: > When setting the MTU of an interface, if the interface is up, > then explicitly take down the interface before the change > and then take it up. > > We need to do this because of a limitation imposed by the Linux kernel. > Note that for the sake of consistency we do it for all OS-es. > > Bug found by: Michael Larson > > Revision Changes Path > 1.36 +24 -1; commitid: 12ad34367a9f07ea6; xorp/fea/ifconfig_set.cc > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Tue Nov 1 18:55:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 18:55:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511011855.jA1ItvOr077300@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 18:55:57 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh Log message: * Add new method ConfigTreeNode::set_value_without_verification() that allows setting the value of a configuration node without internal verification. The value of that node can be verified at later stage with the new method ConfigTreeNode::check_allowed_value(string& error_msg). Note that currently we don't really need this method in vanilla XORP, because we always use the existing set_value() method that internally verifies the value and eventually rejects it if it is invalud. However, the new set_value_without_verification() method provides more design freedom to us if we modify the xorpsh design and to other developers if they are to use the xorpsh/rtrmgr code as a library. * Minor cleanup. Submitted by: Marat Nepomnyashy Revision Changes Path 1.98 +23 -9; commitid: 12d844367b7e87ea6; xorp/rtrmgr/conf_tree_node.cc 1.57 +3 -1; commitid: 12d844367b7e87ea6; xorp/rtrmgr/conf_tree_node.hh From pavlin@icir.org Tue Nov 1 19:10:59 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 01 Nov 2005 11:10:59 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp/fea In-Reply-To: Message from Kristian Larsson of "Tue, 01 Nov 2005 19:25:09 +0100." <20051101182509.GI3639@juniks.net> Message-ID: <200511011910.jA1JAxdA019439@possum.icir.org> > Is this really necessary? Yes, if we want to keep the code relatively clean and to be more consistent with how the FEA behaves across different OS-es. Also, we know that for Linux we have to do it, but for the sake of simplicity of porting the code to other platforms we don't want to start testing each platform whether it requires the same modification. > It seams wrong that all OSes should suffer due to > the bad behaviour introduced by Linux. Modifying the MTU would be relatively infrequent operation, and the sides effects of taking an interface down and up right before and after the operation that modifies the MTU are (presumably) minor. Only if we see that this creates major issues then we can add more complexity to the code to deal with the problem on OS-based granularity, but for now the preference is to keep the code cleaner and the behavior more uniform across all platforms. Pavlin P.S. FYI, we were doing this already for setting the MAC address. > > Kristian. > > On Tue, Nov 01, 2005 at 05:49:05PM +0000, Pavlin Radoslavov wrote: > > CVSROOT: /usr/local/share/doc/apache/cvs > > Module name: xorp > > Changes by: pavlin@xorpc.icir.org 2005-11-01 17:49:05 UTC > > > > XORP CVS repository > > > > > > Modified files: > > fea ifconfig_set.cc > > > > Log message: > > When setting the MTU of an interface, if the interface is up, > > then explicitly take down the interface before the change > > and then take it up. > > > > We need to do this because of a limitation imposed by the Linux kernel. > > Note that for the sake of consistency we do it for all OS-es. > > > > Bug found by: Michael Larson > > > > Revision Changes Path > > 1.36 +24 -1; commitid: 12ad34367a9f07ea6; xorp/fea/ifconfig_set.cc > > _______________________________________________ > > Xorp-cvs mailing list > > Xorp-cvs@icir.org > > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From atanu@icir.org Tue Nov 1 20:18:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 20:18:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511012018.jA1KIj0M078275@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 20:18:45 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Don't allow the local port or peer port to be changed the protocol requires that port 179 is used. In order to change the port number the previous value is required and this information is not available from the template file. Revision Changes Path 1.60 +5 -3; commitid: 131a84367cda47ea6; xorp/etc/templates/bgp.tp From atanu@icir.org Tue Nov 1 20:21:37 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 20:21:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511012021.jA1KLbiB078443@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 20:21:37 UTC XORP CVS repository Modified files: bgp peer.hh Log message: Allow the peer specific data in a peering to be changed with new values. Revision Changes Path 1.26 +13 -1; commitid: 132504367ce507ea6; xorp/bgp/peer.hh From atanu@icir.org Tue Nov 1 21:52:03 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 1 Nov 2005 21:52:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511012152.jA1Lq3bM079384@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-01 21:52:03 UTC XORP CVS repository Modified files: bgp route_table_decision.cc Log message: Add some extra debugging to print out the peers BGP ID. Revision Changes Path 1.39 +3 -2; commitid: 135fd4367e3827ea6; xorp/bgp/route_table_decision.cc From pavlin@icir.org Tue Nov 1 23:33:16 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 1 Nov 2005 23:33:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libfeaclient Message-ID: <200511012333.jA1NXGKW080547@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-01 23:33:16 UTC XORP CVS repository Modified files: libfeaclient ifmgr_xrl_replicator.cc ifmgr_xrl_replicator.hh Log message: Refactor the mechanism for sending the commands to the remote targets by introducing a centralized queue for all commands. We need this centralized mechanism to ensure that the commands are sent to the remote targets in the order the targets are listed. Otherwise, there could be a race condition if some of the targets try to communicate with each other immediately after they receive the updates. For example, if an IP address is moved from one interface to another, the static_routes target may receive the interface update and send a route update to RIB before the RIB has even received the interface update. The result of such race condition is unpredictable: e.g., routes with incorrect next-hop interface, or routes that are rejected by the RIB. This fixes the remaining issue in bugzilla entry #297 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=297 Revision Changes Path 1.12 +116 -7; commitid: 13a694367fa157ea6; xorp/libfeaclient/ifmgr_xrl_replicator.cc 1.9 +59 -2; commitid: 13a694367fa157ea6; xorp/libfeaclient/ifmgr_xrl_replicator.hh From atanu@icir.org Wed Nov 2 01:09:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 2 Nov 2005 01:09:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511020109.jA219SC9081521@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-02 01:09:28 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh xrl_target.cc Log message: Allow peer specific state to be modified. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=104 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=281 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=283 Revision Changes Path 1.58 +194 -4; commitid: 13e52436811c77ea6; xorp/bgp/bgp.cc 1.47 +93 -1; commitid: 13e52436811c77ea6; xorp/bgp/bgp.hh 1.46 +62 -14; commitid: 13e52436811c77ea6; xorp/bgp/xrl_target.cc From pavlin@icir.org Wed Nov 2 01:33:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 01:33:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511020133.jA21XFXf081852@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 01:33:15 UTC XORP CVS repository Modified files: rib rib.cc rib.hh test_register.cc vifmanager.cc Log message: * Cleanup the mechanism for updating the interface information inside each RIB table and fix few bugs in the process. * Consider the status of each interface (enabled and link no-carrier flags), and appropriately add or delete the connected routes. This fixes the RIB-related issue raised in bugzilla entry #168 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=168 Revision Changes Path 1.58 +148 -105; commitid: 13f8e436816a67ea6; xorp/rib/rib.cc 1.34 +29 -1; commitid: 13f8e436816a67ea6; xorp/rib/rib.hh 1.21 +4 -1; commitid: 13f8e436816a67ea6; xorp/rib/test_register.cc 1.41 +6 -3; commitid: 13f8e436816a67ea6; xorp/rib/vifmanager.cc From pavlin@icir.org Wed Nov 2 02:19:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 02:19:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/mld6igmp xorp/pim Message-ID: <200511020219.jA22JirM082308@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 02:19:44 UTC XORP CVS repository Modified files: mld6igmp mld6igmp_config.cc pim pim_config.cc Log message: Refactor the mechanism for updating the interface information: - first delete old vifs and then add and update new vifs. - delete all obsolete addresses on all interfaces before adding new addresses. Revision Changes Path 1.11 +41 -30; commitid: 141564368222f7ea6; xorp/mld6igmp/mld6igmp_config.cc 1.44 +44 -36; commitid: 141564368222f7ea6; xorp/pim/pim_config.cc From pavlin@icir.org Wed Nov 2 02:27:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 02:27:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fib2mrib xorp/libfeaclient xorp/ospf xorp/rip xorp/static_routes Message-ID: <200511020227.jA22RNW4082533@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 02:27:23 UTC XORP CVS repository Modified files: fea mfea_node.cc fib2mrib fib2mrib_node.cc libfeaclient ifmgr_atoms.cc ospf xrl_io.cc rip xrl_port_manager.cc static_routes static_routes_node.cc Log message: Consider the "no-carrier" link state flag when deciding if an interface is up or whether routes that use that link should be withdrawn from the RIB. This fixes bugzilla entry #168 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=168 Revision Changes Path 1.59 +5 -2; commitid: 141cf436823267ea6; xorp/fea/mfea_node.cc 1.27 +27 -5; commitid: 141cf436823267ea6; xorp/fib2mrib/fib2mrib_node.cc 1.13 +5 -5; commitid: 141cf436823267ea6; xorp/libfeaclient/ifmgr_atoms.cc 1.22 +39 -14; commitid: 141cf436823267ea6; xorp/ospf/xrl_io.cc 1.21 +2 -2; commitid: 141cf436823267ea6; xorp/rip/xrl_port_manager.cc 1.30 +27 -5; commitid: 141cf436823267ea6; xorp/static_routes/static_routes_node.cc From pavlin@icir.org Wed Nov 2 02:40:39 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 02:40:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511020240.jA22edqA082656@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 02:40:39 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Change the default XORP prompt in configurational mode from "XORP> " to "XORP# " so now it is more distinguishable, and is more familiar to people, because it is closer to JunOS. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=304 Approved by: Atanu Ghosh Revision Changes Path 1.104 +4 -4; commitid: 142b3436826517ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Wed Nov 2 02:49:33 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 02:49:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511020249.jA22nXBB082784@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 02:49:33 UTC XORP CVS repository Modified files: etc/templates igmp.tp mfea4.tp mfea6.tp mld.tp pimsm4.tp pimsm6.tp Log message: Fix the %delete method specification for the "traceoptions flag all" so the tracing is disabled when the traceoptions node is deleted from the configuration. Bug found by: Atanu Ghosh Revision Changes Path 1.15 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/igmp.tp 1.12 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/mfea4.tp 1.12 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/mfea6.tp 1.15 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/mld.tp 1.27 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/pimsm4.tp 1.27 +2 -2; commitid: 14336436828f17ea6; xorp/etc/templates/pimsm6.tp From pavlin@icir.org Wed Nov 2 03:28:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 03:28:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511020328.jA23SuIR083200@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 03:28:56 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: * Modify the default value for the "traceoptions flag all disable" flag from true to false so it is consistent with the other template files that have traceoptions. * Fix the %delete method specification for the "traceoptions flag all" so the tracing is disabled when the traceoptions node is deleted from the configuration. Bug found by: Atanu Ghosh Revision Changes Path 1.18 +3 -3; commitid: 144d04368321f7ea6; xorp/etc/templates/ospfv2.tp From pavlin@icir.org Wed Nov 2 03:59:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 2 Nov 2005 03:59:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib/tools Message-ID: <200511020359.jA23xn7A083501@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-02 03:59:49 UTC XORP CVS repository Modified files: rib/tools show_routes.cc Log message: Use better formatting for the terse output of the routes. Before: XORP# run show route table ipv4 unicast final terse Destination P Prf Metric 1 Next hop 10.10.10.0/24 c 0 0 eth0/eth0 192.168.100.128/30 s 1 1 10.10.10.1 After: XORP# run show route table ipv4 unicast final terse Destination P Prf Metric 1 Next hop 10.10.10.0/24 c 0 0 eth0/eth0 192.168.100.128/30 s 1 1 10.10.10.1 XORP# XORP# run show route table ipv6 unicast final terse Destination P Prf Metric 1 Next hop 2001:db8:5009:beef::/64 c 0 0 eth0/eth0 3ffe::/64 s 1 1 2001:db8:5009:beef:dead:beef:dead:beef This change is from bugzilla entry #162 attachment (id=76) Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=162 Submitted by: Hasso Tepper Revision Changes Path 1.17 +21 -21; commitid: 14612436838e77ea6; xorp/rib/tools/show_routes.cc From atanu@icir.org Wed Nov 2 07:32:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 2 Nov 2005 07:32:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511020732.jA27Wlxh018655@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-02 07:32:47 UTC XORP CVS repository Modified files: bgp/harness test_peering2.sh Log message: test12 was incorrectly waiting for both peerings to be established at the end of the test. Revision Changes Path 1.46 +1 -2; commitid: 48c443686b9d7ea6; xorp/bgp/harness/test_peering2.sh From atanu@icir.org Wed Nov 2 07:36:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 2 Nov 2005 07:36:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511020736.jA27aDZZ018806@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-02 07:36:13 UTC XORP CVS repository Modified files: bgp peer.cc peer.hh peer_handler.hh rib_ipc_handler.cc rib_ipc_handler.hh route_table_decision.cc route_table_decision.hh Log message: Each BGP peer now has a unique internal ID that can be used for sorting by the decision process. Previously the peers router ID was being used which was problematic. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=101 Revision Changes Path 1.102 +3 -2; commitid: 494f43686c6b7ea6; xorp/bgp/peer.cc 1.27 +16 -1; commitid: 494f43686c6b7ea6; xorp/bgp/peer.hh 1.18 +8 -1; commitid: 494f43686c6b7ea6; xorp/bgp/peer_handler.hh 1.68 +2 -1; commitid: 494f43686c6b7ea6; xorp/bgp/rib_ipc_handler.cc 1.38 +5 -1; commitid: 494f43686c6b7ea6; xorp/bgp/rib_ipc_handler.hh 1.40 +7 -7; commitid: 494f43686c6b7ea6; xorp/bgp/route_table_decision.cc 1.21 +2 -2; commitid: 494f43686c6b7ea6; xorp/bgp/route_table_decision.hh From atanu@icir.org Wed Nov 2 07:38:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 2 Nov 2005 07:38:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511020738.jA27cDmZ018890@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-02 07:38:13 UTC XORP CVS repository Modified files: bgp/harness test_peering2.sh Log message: Enable test10, test11 and test12. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=101 Revision Changes Path 1.47 +4 -4; commitid: 49af43686ce57ea6; xorp/bgp/harness/test_peering2.sh From atanu@icir.org Wed Nov 2 10:00:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 2 Nov 2005 10:00:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511021000.jA2A0k45020789@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-02 10:00:46 UTC XORP CVS repository Modified files: bgp/harness test_routing2.sh Log message: A regression test, test12 that demonstrates the bug #296 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=296 Revision Changes Path 1.18 +25 -2; commitid: 511a43688e4e7ea6; xorp/bgp/harness/test_routing2.sh From pavlin@icir.org Thu Nov 3 08:50:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 3 Nov 2005 08:50:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511030850.jA38o1th035564@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-03 08:50:00 UTC XORP CVS repository Modified files: rib xrl_target.cc Log message: Automatically assign the vif flags when a new vif is added by the rib/0.1/new_vif XRL. This XRL interface remains only for testing purpose and should go away in the future. Hence, instead of expanding this XRL interface (and to risk to break the test scripts that use it), for simplicity we just assign the vif flags internally with the appropriate values. Previously, vifs added with this test XRL interface (e.g., by some of the BGP test scripts) were considered DOWN. After the recent RIB refactoring to consider the UP/DOWN vif flag, some of those tests were failing because the RIB didn't have any interfaces that are UP. Bug found by: Atanu Ghosh Revision Changes Path 1.55 +13 -1; commitid: 8abb4369ce1b7ea6; xorp/rib/xrl_target.cc From pavlin@icir.org Thu Nov 3 17:18:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 3 Nov 2005 17:18:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511031718.jA3HIuZN043317@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-03 17:18:56 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh master_conf_tree_node.cc master_conf_tree_node.hh Log message: * Rename "response" and "errmsg" to "error_msg" (for consistency with other part of the code). Note that there are remaining files that still need similar cleanup. * Minor cleanup. Revision Changes Path 1.49 +3 -3; commitid: a904436a45ff7ea6; xorp/rtrmgr/conf_tree.cc 1.29 +2 -2; commitid: a904436a45ff7ea6; xorp/rtrmgr/conf_tree.hh 1.99 +28 -26; commitid: a904436a45ff7ea6; xorp/rtrmgr/conf_tree_node.cc 1.58 +4 -4; commitid: a904436a45ff7ea6; xorp/rtrmgr/conf_tree_node.hh 1.18 +55 -48; commitid: a904436a45ff7ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.16 +3 -3; commitid: a904436a45ff7ea6; xorp/rtrmgr/master_conf_tree_node.hh From pavlin@icir.org Thu Nov 3 17:27:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 3 Nov 2005 17:27:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511031727.jA3HRqOB043454@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-03 17:27:52 UTC XORP CVS repository Modified files: rtrmgr generic_module_manager.cc generic_module_manager.hh master_conf_tree.cc master_conf_tree.hh module_manager.cc module_manager.hh slave_module_manager.cc slave_module_manager.hh task.cc task.hh test_module_manager.cc xorpsh_main.cc Log message: If we change the running configuration via xorpsh and If the binary for one of the new modules is missing, then just print an error rather than unconditionally exit the rtrmgr. However, on startup we still exit the rtrmgr if the configuration refers to a missing binary. This fixes bugzilla entry #180 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=180 Revision Changes Path 1.6 +6 -5; commitid: a974436a47ee7ea6; xorp/rtrmgr/generic_module_manager.cc 1.8 +2 -2; commitid: a974436a47ee7ea6; xorp/rtrmgr/generic_module_manager.hh 1.66 +274 -248; commitid: a974436a47ee7ea6; xorp/rtrmgr/master_conf_tree.cc 1.34 +5 -5; commitid: a974436a47ee7ea6; xorp/rtrmgr/master_conf_tree.hh 1.51 +26 -20; commitid: a974436a47ee7ea6; xorp/rtrmgr/module_manager.cc 1.35 +7 -4; commitid: a974436a47ee7ea6; xorp/rtrmgr/module_manager.hh 1.21 +6 -3; commitid: a974436a47ee7ea6; xorp/rtrmgr/slave_module_manager.cc 1.20 +2 -2; commitid: a974436a47ee7ea6; xorp/rtrmgr/slave_module_manager.hh 1.56 +11 -7; commitid: a974436a47ee7ea6; xorp/rtrmgr/task.cc 1.36 +3 -3; commitid: a974436a47ee7ea6; xorp/rtrmgr/task.hh 1.17 +14 -6; commitid: a974436a47ee7ea6; xorp/rtrmgr/test_module_manager.cc 1.55 +4 -2; commitid: a974436a47ee7ea6; xorp/rtrmgr/xorpsh_main.cc From pavlin@icir.org Thu Nov 3 17:35:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 3 Nov 2005 17:35:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511031735.jA3HZitt043611@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-03 17:35:44 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree_node.cc Log message: * Fix a compilation error * Minor cleanup Revision Changes Path 1.19 +12 -10; commitid: aa42436a4a637ea6; xorp/rtrmgr/master_conf_tree_node.cc From atanu@icir.org Fri Nov 4 01:02:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 4 Nov 2005 01:02:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511040102.jA412Z7R047481@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-04 01:02:35 UTC XORP CVS repository Modified files: ospf xrl_io.cc xrl_target.cc Log message: Comment out DEBUG_LOGGING and DEBUG_PRINT_FUNCTION_NAME to allow; ./configure --enable-debug-fnames Bug found by: Kristian Larsson Revision Changes Path 1.23 +3 -3; commitid: b952436ab2ed7ea6; xorp/ospf/xrl_io.cc 1.19 +3 -3; commitid: b952436ab2ed7ea6; xorp/ospf/xrl_target.cc From atanu@icir.org Fri Nov 4 07:50:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 4 Nov 2005 07:50:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511040750.jA47oMja051088@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-04 07:50:22 UTC XORP CVS repository Modified files: ospf external.cc routing_table.cc trace.hh Log message: Add trace points for input and export policies. Revision Changes Path 1.13 +5 -1; commitid: c771436b12bd7ea6; xorp/ospf/external.cc 1.25 +44 -4; commitid: c771436b12bd7ea6; xorp/ospf/routing_table.cc 1.8 +8 -3; commitid: c771436b12bd7ea6; xorp/ospf/trace.hh From atanu@icir.org Fri Nov 4 18:56:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 4 Nov 2005 18:56:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511041856.jA4IuSS5060529@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-04 18:56:28 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh peer.cc peer.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: The list of neighbours and individual neighbour info is now available via XRLs. The valid field has been removed as it was not useful and a deadtime field has been added. All of the timer values current return zero. Revision Changes Path 1.49 +19 -1; commitid: ec16436baed77ea6; xorp/ospf/ospf.cc 1.66 +34 -1; commitid: ec16436baed77ea6; xorp/ospf/ospf.hh 1.172 +76 -1; commitid: ec16436baed77ea6; xorp/ospf/peer.cc 1.103 +40 -1; commitid: ec16436baed77ea6; xorp/ospf/peer.hh 1.71 +36 -1; commitid: ec16436baed77ea6; xorp/ospf/peer_manager.cc 1.50 +16 -1; commitid: ec16436baed77ea6; xorp/ospf/peer_manager.hh 1.20 +45 -16; commitid: ec16436baed77ea6; xorp/ospf/xrl_target.cc 1.13 +3 -3; commitid: ec16436baed77ea6; xorp/ospf/xrl_target.hh 1.8 +5 -5; commitid: ec16436baed77ea6; xorp/xrl/interfaces/ospfv2.xif 1.9 +4 -4; commitid: ec16436baed77ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.9 +2 -2; commitid: ec16436baed77ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.11 +4 -4; commitid: ec16436baed77ea6; xorp/xrl/targets/ospfv2.xrls 1.11 +4 -4; commitid: ec16436baed77ea6; xorp/xrl/targets/ospfv2_base.cc 1.11 +4 -4; commitid: ec16436baed77ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Fri Nov 4 20:54:36 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 4 Nov 2005 20:54:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto xorp/libxorp xorp/ospf Message-ID: <200511042054.jA4Ksaa4062073@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-04 20:54:36 UTC XORP CVS repository Modified files: libproto test_spt.cc libxorp test_profile.cc ospf test_checksum.cc test_packet.cc test_peering.cc test_routing.cc Log message: Put guards around the defines DEBUG_LOGGING and DEBUG_PRINT_FUNCTION_NAME so they can be unconditionally enabled and not conflict with the configure option "--enable-debug-fnames". Revision Changes Path 1.9 +5 -1; commitid: f22e436bca8a7ea6; xorp/libproto/test_spt.cc 1.5 +8 -4; commitid: f22e436bca8a7ea6; xorp/libxorp/test_profile.cc 1.3 +8 -4; commitid: f22e436bca8a7ea6; xorp/ospf/test_checksum.cc 1.33 +8 -4; commitid: f22e436bca8a7ea6; xorp/ospf/test_packet.cc 1.49 +8 -4; commitid: f22e436bca8a7ea6; xorp/ospf/test_peering.cc 1.10 +8 -4; commitid: f22e436bca8a7ea6; xorp/ospf/test_routing.cc From pavlin@icir.org Sat Nov 5 01:37:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 01:37:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511050137.jA51biR6064692@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 01:37:44 UTC XORP CVS repository Modified files: bgp/harness test_rib_fea1.sh Log message: Add missing "enable_interface" configuration statements. This fixes some of the tests that were failing after the RIB was refactored to consider the "enable" flag for both the interface and the vif. Revision Changes Path 1.14 +7 -1; commitid: fc96436c0caf7ea6; xorp/bgp/harness/test_rib_fea1.sh From pavlin@icir.org Sat Nov 5 01:44:20 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 01:44:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511050144.jA51iKsa064794@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 01:44:20 UTC XORP CVS repository Modified files: rib rt_tab_extint.cc Log message: Bug fix when adding an IGP route: check whether there is an EGP route with a directly connected nexthop and delete that route if necessary. This fixes bugzilla entry #296 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=296 Revision Changes Path 1.27 +43 -11; commitid: fcd6436c0d5b7ea6; xorp/rib/rt_tab_extint.cc From pavlin@icir.org Sat Nov 5 02:10:22 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 02:10:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511050210.jA52AMnP065594@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 02:10:21 UTC XORP CVS repository Modified files: rib parser_direct_cmds.hh Log message: Enable each new vif by default. Revision Changes Path 1.19 +4 -1; commitid: 1000d436c146f7ea6; xorp/rib/parser_direct_cmds.hh From atanu@icir.org Sat Nov 5 04:36:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 04:36:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/ospf/tools Message-ID: <200511050436.jA54akr9066860@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 04:36:46 UTC XORP CVS repository Modified files: ospf ospf.hh ospf/tools print_lsas.cc Log message: Move the routine that returns the XRL target name into the common header file. Revision Changes Path 1.67 +20 -1; commitid: 104fc436c36dc7ea6; xorp/ospf/ospf.hh 1.13 +3 -22; commitid: 104fc436c36dc7ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Sat Nov 5 04:41:33 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 04:41:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050441.jA54fXum066950@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 04:41:33 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Slight refactoring of the method that returns the neighbour information, the BDR is now sent in network order and the deadtime field is set. Revision Changes Path 1.173 +19 -8; commitid: 1056b436c37fc7ea6; xorp/ospf/peer.cc From pavlin@icir.org Sat Nov 5 04:48:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 04:48:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200511050448.jA54mFqD067106@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 04:48:15 UTC XORP CVS repository Modified files: rib rib.cc Log message: When adding a route and matching it against vifs for directly connected routes, then explicitly check that the vif is UP. If the vif is down toward a router on the same subnet as this vif, then the router is not considered to be directly-connected. Revision Changes Path 1.59 +11 -8; commitid: 10604436c39027ea6; xorp/rib/rib.cc From atanu@icir.org Sat Nov 5 05:12:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 05:12:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200511050512.jA55Cc2l067452@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 05:12:38 UTC XORP CVS repository Modified files: ospf/tools Makefile.am Makefile.in Added files: ospf/tools print_neighbours.cc Log message: Operational command to print OSPF neighbour information. Revision Changes Path 1.2 +6 -2; commitid: 1075d436c3f457ea6; xorp/ospf/tools/Makefile.am 1.2 +22 -5; commitid: 1075d436c3f457ea6; xorp/ospf/tools/Makefile.in 1.1 +399 -0 xorp/ospf/tools/print_neighbours.cc (new) From atanu@icir.org Sat Nov 5 05:40:44 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 05:40:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200511050540.jA55ei0a067842@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 05:40:44 UTC XORP CVS repository Modified files: ospf/tools print_neighbours.cc Log message: Catch any exceptions thrown by malformed address strings. Revision Changes Path 1.2 +4 -2; commitid: 108e7436c45db7ea6; xorp/ospf/tools/print_neighbours.cc From atanu@icir.org Sat Nov 5 05:41:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 05:41:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511050541.jA55fJdb067897@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 05:41:19 UTC XORP CVS repository Modified files: etc/templates ospfv2.cmds Log message: Add the neighbour command. Revision Changes Path 1.5 +39 -1; commitid: 1091e436c45ff7ea6; xorp/etc/templates/ospfv2.cmds From atanu@icir.org Sat Nov 5 06:16:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 06:16:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200511050616.jA56Gqbd068469@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 06:16:52 UTC XORP CVS repository Modified files: ospf/tools print_neighbours.cc Log message: Slight formatting nit. Revision Changes Path 1.3 +2 -3; commitid: 10b58436c4e537ea6; xorp/ospf/tools/print_neighbours.cc From atanu@icir.org Sat Nov 5 06:17:57 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 06:17:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050617.jA56HvCg068529@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 06:17:57 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Propogate back any errors returned from the peer when extracting the neighbour info. Revision Changes Path 1.72 +2 -3; commitid: 10b96436c4e947ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Sat Nov 5 06:20:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 06:20:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050620.jA56Kc8M068643@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 06:20:38 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: Store the creation time as well as full adjacency time for the neighbour and return in neighbour info requests. Revision Changes Path 1.174 +17 -4; commitid: 10c06436c4f347ea6; xorp/ospf/peer.cc 1.104 +5 -1; commitid: 10c06436c4f347ea6; xorp/ospf/peer.hh From atanu@icir.org Sat Nov 5 06:38:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 06:38:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050638.jA56cFQt068895@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 06:38:15 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: When replacing a route pass in the area that the original route came from, the replace route was being passed in with the new area and was causing hitting an assert in the summary removal code. Revision Changes Path 1.26 +5 -4; commitid: 10d02436c53567ea6; xorp/ospf/routing_table.cc 1.26 +3 -2; commitid: 10d02436c53567ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Sat Nov 5 06:48:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 06:48:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200511050648.jA56mluT069207@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 06:48:47 UTC XORP CVS repository Modified files: ospf/tools .cvsignore Log message: Add print_neighbours to the list of CVS ignored files. Revision Changes Path 1.2 +1 -0; commitid: 10e37436c55bd7ea6; xorp/ospf/tools/.cvsignore From atanu@icir.org Sat Nov 5 08:49:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 08:49:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050849.jA58neJA070433@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 08:49:40 UTC XORP CVS repository Modified files: ospf area_router.cc lsa.cc packet.cc peer.cc Log message: Initialise the variables that the optimiser is complaining about. Revision Changes Path 1.134 +2 -2; commitid: 11300436c72237ea6; xorp/ospf/area_router.cc 1.57 +15 -15; commitid: 11300436c72237ea6; xorp/ospf/lsa.cc 1.28 +3 -3; commitid: 11300436c72237ea6; xorp/ospf/packet.cc 1.175 +9 -9; commitid: 11300436c72237ea6; xorp/ospf/peer.cc From atanu@icir.org Sat Nov 5 09:32:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 09:32:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511050932.jA59Wnmj070951@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 09:32:49 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Remove an unused variable. Revision Changes Path 1.176 +1 -2; commitid: 1150c436c7c407ea6; xorp/ospf/peer.cc From pavlin@icir.org Sat Nov 5 09:53:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 09:53:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/pim Message-ID: <200511050953.jA59run4071221@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 09:53:56 UTC XORP CVS repository Modified files: pim pim_vif.cc Log message: Bug fix: move the check of the message type after we discover the message type. Bug found by: Atanu Ghosh Revision Changes Path 1.58 +22 -22; commitid: 1160d436c80fd7ea6; xorp/pim/pim_vif.cc From abittau@icir.org Sat Nov 5 13:47:27 2005 From: abittau@icir.org (Andrea Bittau) Date: Sat, 5 Nov 2005 13:47:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200511051347.jA5DlRx2073764@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-11-05 13:47:26 UTC XORP CVS repository Modified files: policy dependancy.hh policy_map.cc Log message: fixed dependency issues. Policies should now be deletable. The policy manager code sucks [no offense to the author] Revision Changes Path 1.4 +13 -5; commitid: 12009436cb7c97ea6; xorp/policy/dependancy.hh 1.5 +2 -2; commitid: 12009436cb7c97ea6; xorp/policy/policy_map.cc From bms@icir.org Sat Nov 5 17:56:22 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 17:56:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200511051756.jA5HuMjB079862@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 17:56:22 UTC XORP CVS repository Modified files: . configure.in Log message: Remove -lpdcurses -ltermcap from the Win32 link line as they are no longer needed by XORP. Also, -ltermcap causes XORP binaries to become tainted with the GPL license. Pending regen on HEAD. Obtained from: XORP/Win32 Revision Changes Path 1.150 +3 -3; commitid: 137da436cf1fd7ea6; xorp/configure.in From bms@icir.org Sat Nov 5 17:58:55 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 17:58:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511051758.jA5HwtC5079920@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 17:58:55 UTC XORP CVS repository Modified files: libxorp test_run_command.cc Log message: Allow the base directory for the MinGW/MSYS installation to be set in the environment using the variable MSYSROOT, when running test commands. Set default path to C:\MINGW. This eliminates a dependency on a hard-coded path for developers wishing to try XORP under Win32. Obtained from: XORP/Win32 Revision Changes Path 1.10 +27 -12; commitid: 13817436cf2d47ea6; xorp/libxorp/test_run_command.cc From bms@icir.org Sat Nov 5 18:01:46 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 18:01:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/cli/libtecla xorp/libxorp xorp/policy/backend xorp/policy/common xorp/rtrmgr Message-ID: <200511051801.jA5I1kG0080124@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 18:01:46 UTC XORP CVS repository Modified files: cli cli_command_pipe.hh cli/libtecla direader.c homedir.c pathutil.c libxorp random.c policy/backend instruction.hh policy/common policy_utils.cc rtrmgr util.cc Log message: Header file fixes for new Win32 toolchain. The latest version of MinGW has a problem with the include file. The latest version of PCRE from GnuWin32 requires that be included before . Add HAVE_CONFIG_H guard to rtrmgr/util.cc. Obtained from: XORP/Win32 Revision Changes Path 1.11 +2 -1; commitid: 13876436cf37e7ea6; xorp/cli/cli_command_pipe.hh 1.2 +2 -0; commitid: 13876436cf37e7ea6; xorp/cli/libtecla/direader.c 1.3 +1 -1; commitid: 13876436cf37e7ea6; xorp/cli/libtecla/homedir.c 1.4 +2 -0; commitid: 13876436cf37e7ea6; xorp/cli/libtecla/pathutil.c 1.4 +3 -1; commitid: 13876436cf37e7ea6; xorp/libxorp/random.c 1.6 +2 -1; commitid: 13876436cf37e7ea6; xorp/policy/backend/instruction.hh 1.8 +2 -1; commitid: 13876436cf37e7ea6; xorp/policy/common/policy_utils.cc 1.22 +5 -1; commitid: 13876436cf37e7ea6; xorp/rtrmgr/util.cc From bms@icir.org Sat Nov 5 18:05:35 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 18:05:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511051805.jA5I5Z3Q080186@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 18:05:35 UTC XORP CVS repository Modified files: libxorp win_dispatcher.cc win_dispatcher.hh Log message: Fix a grievous bug whereby we would potentially block forever in WaitForMultipleObjectsEx() if there were pollable objects and a timeout was specified by the EventLoop::run() call in the frame above. Do not add HANDLEs to _eventsocks in a way which could cause duplicates. Only remove a HANDLE from _eventsocks if it should be removed. Don't walk the ioevent callback map if no events occurred after calling WSAEnumNetworkEvents(). Update comments. Eliminate dead prototype for the WndProc. Revision Changes Path 1.5 +26 -15; commitid: 13906436cf3c87ea6; xorp/libxorp/win_dispatcher.cc 1.5 +7 -12; commitid: 13906436cf3c87ea6; xorp/libxorp/win_dispatcher.hh From bms@icir.org Sat Nov 5 18:07:18 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 18:07:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200511051807.jA5I7I8J080226@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 18:07:18 UTC XORP CVS repository Modified files: libxipc xrl_pf_inproc.cc Log message: Pass correct arguments to GetComputerNameExA(). Revision Changes Path 1.27 +8 -2; commitid: 13944436cf4bc7ea6; xorp/libxipc/xrl_pf_inproc.cc From bms@icir.org Sat Nov 5 18:08:17 2005 From: bms@icir.org (Bruce Simpson) Date: Sat, 5 Nov 2005 18:08:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511051808.jA5I8Hhw080281@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-05 18:08:17 UTC XORP CVS repository Modified files: libxorp popen.cc Log message: Since we stopped using 'sh -c' to execute all external commands, popen2() broke under Win32; fix the underlying problem. Force argv[0] to be quoted with double quotes. Apply the MSVCRT quoting rules to the rest of any command line arguments which we pass to CreateProcess(). With this change, the RunCommand regression test now passes on Win32 again. Revision Changes Path 1.9 +42 -33; commitid: 13971436cf4e77ea6; xorp/libxorp/popen.cc From atanu@icir.org Sat Nov 5 19:25:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 19:25:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511051925.jA5JPtCM081098@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 19:25:55 UTC XORP CVS repository Modified files: ospf debug_io.hh io.hh ospf.cc ospf.hh xrl_io.cc xrl_io.hh Log message: Make the sending to router alerts in packets conditional and change the default to false. Revision Changes Path 1.13 +2 -1; commitid: 13ca5436d07427ea6; xorp/ospf/debug_io.hh 1.16 +2 -1; commitid: 13ca5436d07427ea6; xorp/ospf/io.hh 1.50 +4 -3; commitid: 13ca5436d07427ea6; xorp/ospf/ospf.cc 1.68 +16 -1; commitid: 13ca5436d07427ea6; xorp/ospf/ospf.hh 1.24 +9 -5; commitid: 13ca5436d07427ea6; xorp/ospf/xrl_io.cc 1.16 +2 -1; commitid: 13ca5436d07427ea6; xorp/ospf/xrl_io.hh From pavlin@icir.org Sat Nov 5 20:10:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 05 Nov 2005 12:10:43 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp In-Reply-To: Message from Bruce Simpson of "Sat, 05 Nov 2005 17:56:22 GMT." <200511051756.jA5HuMjB079862@xorpc.icir.org> Message-ID: <200511052010.jA5KAh42057726@possum.icir.org> > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms@xorpc.icir.org 2005-11-05 17:56:22 UTC > > XORP CVS repository > > > Modified files: > . configure.in > > Log message: > Remove -lpdcurses -ltermcap from the Win32 link line as they > are no longer needed by XORP. > > Also, -ltermcap causes XORP binaries to become tainted with > the GPL license. > > Pending regen on HEAD. Bruce, is the non-generation of "configure" itself intentional or is it because you don't have the necessary autoconf/automake tools installed? If the latter, then I can regenerate and commit it. Pavlin > > Obtained from: XORP/Win32 > > Revision Changes Path > 1.150 +3 -3; commitid: 137da436cf1fd7ea6; xorp/configure.in > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Sat Nov 5 20:12:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 20:12:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511052012.jA5KCcdU081923@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 20:12:38 UTC XORP CVS repository Modified files: libxorp test_run_command.cc Log message: Rename AWK_UNIX_PATH to AWK_VIA_SHELL_PATH and use it for both UNIX and Windows. Revision Changes Path 1.11 +9 -12; commitid: 13fea436d11e87ea6; xorp/libxorp/test_run_command.cc From pavlin@icir.org Sat Nov 5 20:13:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 20:13:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200511052013.jA5KDsiK082017@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 20:13:54 UTC XORP CVS repository Modified files: libxipc xrl_pf_inproc.cc Log message: Replace abort() with XLOG_FATAL() Revision Changes Path 1.28 +3 -3; commitid: 14048436d12727ea6; xorp/libxipc/xrl_pf_inproc.cc From pavlin@icir.org Sat Nov 5 20:13:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 5 Nov 2005 20:13:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511052013.jA5KD1D2081966@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-05 20:13:01 UTC XORP CVS repository Modified files: libxorp popen.cc Log message: Fix a typo. Revision Changes Path 1.10 +2 -2; commitid: 14015436d12497ea6; xorp/libxorp/popen.cc From atanu@icir.org Sat Nov 5 20:43:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 20:43:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511052043.jA5KhnDp082309@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 20:43:49 UTC XORP CVS repository Modified files: ospf debug_io.hh io.hh ospf.cc ospf.hh xrl_io.cc xrl_io.hh Log message: No longer save the router alert state in the main class, store it in the generic IO class. Sending router alerts is again default. Move the defines for logging before debug.h so they actually have an affect. Revision Changes Path 1.14 +1 -2; commitid: 14160436d19847ea6; xorp/ospf/debug_io.hh 1.17 +19 -2; commitid: 14160436d19847ea6; xorp/ospf/io.hh 1.51 +10 -4; commitid: 14160436d19847ea6; xorp/ospf/ospf.cc 1.69 +3 -13; commitid: 14160436d19847ea6; xorp/ospf/ospf.hh 1.25 +12 -9; commitid: 14160436d19847ea6; xorp/ospf/xrl_io.cc 1.17 +1 -2; commitid: 14160436d19847ea6; xorp/ospf/xrl_io.hh From atanu@icir.org Sat Nov 5 21:08:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 21:08:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511052108.jA5L8G9c082716@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 21:08:16 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp ospf xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Allow the setting of the router alert option via configuration. Something on our network is not forwarding packets with the router alert option set. If we have this issue so will other people. Revision Changes Path 1.19 +11 -1; commitid: 142b8436d1f3e7ea6; xorp/etc/templates/ospfv2.tp 1.21 +10 -1; commitid: 142b8436d1f3e7ea6; xorp/ospf/xrl_target.cc 1.14 +8 -1; commitid: 142b8436d1f3e7ea6; xorp/ospf/xrl_target.hh 1.9 +6 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/interfaces/ospfv2.xif 1.10 +33 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.10 +21 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.12 +6 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/targets/ospfv2.xrls 1.12 +31 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/targets/ospfv2_base.cc 1.12 +12 -1; commitid: 142b8436d1f3e7ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Sat Nov 5 21:12:57 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 21:12:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/ospf Message-ID: <200511052112.jA5LCv7n082840@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 21:12:57 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp ospf io.hh Log message: Set the default for the router alert option to false both in the template and in the code. Revision Changes Path 1.20 +2 -2; commitid: 14368436d20587ea6; xorp/etc/templates/ospfv2.tp 1.18 +2 -2; commitid: 14368436d20587ea6; xorp/ospf/io.hh From atanu@icir.org Sat Nov 5 23:26:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 5 Nov 2005 23:26:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511052326.jA5NQMj8083797@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-05 23:26:22 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: Replace route is current implemented by calling delete then add route. The replace route code was deleting and adding summary information, which the add route and delete code was also doing, leading to inconsistencies in summary generation. The replace route code is no longer manipulating summary information. Revision Changes Path 1.27 +1 -4; commitid: 1473a436d3f9e7ea6; xorp/ospf/routing_table.cc From atanu@icir.org Sun Nov 6 02:40:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 6 Nov 2005 02:40:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511060240.jA62eNmb085545@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-06 02:40:23 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: When in state ExStart, the slave was ignoring LSA headers in Data Description packets. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=298 Bug found by: Hasso Tepper Revision Changes Path 1.177 +51 -39; commitid: 14e0c436d6d167ea6; xorp/ospf/peer.cc 1.105 +10 -1; commitid: 14e0c436d6d167ea6; xorp/ospf/peer.hh From atanu@icir.org Mon Nov 7 05:08:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 05:08:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070508.jA758ZnS008116@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 05:08:35 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Set the n-bit in the options field of packets in NSSA areas. Revision Changes Path 1.73 +6 -1; commitid: 1f99436ee1527ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Mon Nov 7 05:17:10 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 05:17:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070517.jA75HAeM008238@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 05:17:09 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Verify that the N-bit recieved from neighbours matches the peers own N-Bit setting. Revision Changes Path 1.178 +10 -1; commitid: 2013436ee3547ea6; xorp/ospf/peer.cc From atanu@icir.org Mon Nov 7 06:45:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 06:45:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070645.jA76jV69009025@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 06:45:31 UTC XORP CVS repository Modified files: ospf packet.hh Log message: Defines for the P-bit which is the same option bit as the N-bit but is called the P-bit when set in a Type-7 LSA header. Revision Changes Path 1.24 +5 -1; commitid: 2326436ef8087ea6; xorp/ospf/packet.hh From atanu@icir.org Mon Nov 7 07:12:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 07:12:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070712.jA77CnQf009304@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 07:12:49 UTC XORP CVS repository Modified files: ospf lsa.cc lsa.hh Log message: Add the NSSA translation bit to the Router-LSA. Revision Changes Path 1.58 +13 -5; commitid: 243b436efe707ea6; xorp/ospf/lsa.cc 1.71 +13 -3; commitid: 243b436efe707ea6; xorp/ospf/lsa.hh From atanu@icir.org Mon Nov 7 08:21:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 08:21:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070821.jA78LoNE010149@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 08:21:50 UTC XORP CVS repository Modified files: ospf lsa.cc lsa.hh test_packet.cc Log message: Type-7 LSA inherit from an AS-External-LSA. Revision Changes Path 1.59 +2 -2; commitid: 2786436f0e9c7ea6; xorp/ospf/lsa.cc 1.72 +57 -2; commitid: 2786436f0e9c7ea6; xorp/ospf/lsa.hh 1.34 +67 -8; commitid: 2786436f0e9c7ea6; xorp/ospf/test_packet.cc From atanu@icir.org Mon Nov 7 08:29:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 08:29:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511070829.jA78T57n010318@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 08:29:05 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow the area types to be set. Revision Changes Path 1.21 +1 -3; commitid: 2833436f10507ea6; xorp/etc/templates/ospfv2.tp From bms@spc.org Mon Nov 7 08:31:59 2005 From: bms@spc.org (Bruce M Simpson) Date: Mon, 7 Nov 2005 08:31:59 +0000 Subject: [Xorp-cvs] XORP cvs commit: xorp In-Reply-To: <200511052010.jA5KAh42057726@possum.icir.org> References: <200511051756.jA5HuMjB079862@xorpc.icir.org> <200511052010.jA5KAh42057726@possum.icir.org> Message-ID: <20051107083159.GA753@empiric.icir.org> On Sat, Nov 05, 2005 at 12:10:43PM -0800, Pavlin Radoslavov wrote: > Bruce, is the non-generation of "configure" itself intentional or is > it because you don't have the necessary autoconf/automake tools > installed? > If the latter, then I can regenerate and commit it. Fire at will. The MSYS-DTK autotools don't work properly just now. BMS From atanu@icir.org Mon Nov 7 09:15:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 7 Nov 2005 09:15:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511070915.jA79FqrR010891@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-07 09:15:52 UTC XORP CVS repository Modified files: ospf lsa.cc Log message: The incorrect value was being set for the Nt bit. Revision Changes Path 1.60 +5 -5; commitid: 2a70436f1b487ea6; xorp/ospf/lsa.cc From pavlin@icir.org Mon Nov 7 22:33:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 7 Nov 2005 22:33:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200511072233.jA7MXs5g020911@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-07 22:33:54 UTC XORP CVS repository Modified files: . configure Log message: Regenerate after configure.in change: Remove -lpdcurses -ltermcap from the Win32 link line as they are no longer needed by XORP. Also, -ltermcap causes XORP binaries to become tainted with the GPL license. Obtained from: XORP/Win32 Requested by: Bruce M Simpson Revision Changes Path 1.170 +2 -2; commitid: 5196436fd6257ea6; xorp/configure From pavlin@icir.org Mon Nov 7 22:34:08 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 07 Nov 2005 14:34:08 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp In-Reply-To: Message from Bruce M Simpson of "Mon, 07 Nov 2005 08:31:59 GMT." <20051107083159.GA753@empiric.icir.org> Message-ID: <200511072234.jA7MY8XR044789@possum.icir.org> > On Sat, Nov 05, 2005 at 12:10:43PM -0800, Pavlin Radoslavov wrote: > > Bruce, is the non-generation of "configure" itself intentional or is > > it because you don't have the necessary autoconf/automake tools > > installed? > > If the latter, then I can regenerate and commit it. > > Fire at will. The MSYS-DTK autotools don't work properly just now. Done. Pavlin From atanu@icir.org Tue Nov 8 00:16:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 8 Nov 2005 00:16:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511080016.jA80GL0T021949@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-08 00:16:21 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Track how many of each type of area exists. Required for deciding if Type-7 LSAs need to be generated. Revision Changes Path 1.74 +45 -1; commitid: 55a0436fee557ea6; xorp/ospf/peer_manager.cc 1.51 +19 -2; commitid: 55a0436fee557ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Tue Nov 8 00:17:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 8 Nov 2005 00:17:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511080017.jA80HtOo022013@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-08 00:17:55 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh ospf.hh Log message: Translator role type for NSSAs, defaults to candidate. Revision Changes Path 1.135 +3 -2; commitid: 55de436feeb27ea6; xorp/ospf/area_router.cc 1.78 +4 -1; commitid: 55de436feeb27ea6; xorp/ospf/area_router.hh 1.70 +10 -2; commitid: 55de436feeb27ea6; xorp/ospf/ospf.hh From pavlin@icir.org Tue Nov 8 22:10:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 8 Nov 2005 22:10:06 GMT Subject: [Xorp-cvs] XORP cvs commit: other/testbed/config Message-ID: <200511082210.jA8MA6FN041428@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: other Changes by: pavlin@xorpc.icir.org 2005-11-08 22:10:06 UTC XORP CVS repository Modified files: testbed/config config11.xt Log message: Fix the labeling in the diagram: exchange xorp12.t1 with xorp12.t3 Revision Changes Path 1.2 +2 -2; commitid: a1b7437122127ea6; other/testbed/config/config11.xt From pavlin@icir.org Tue Nov 8 23:09:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 8 Nov 2005 23:09:34 GMT Subject: [Xorp-cvs] XORP cvs commit: other/testbed/config Message-ID: <200511082309.jA8N9YTH042138@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: other Changes by: pavlin@xorpc.icir.org 2005-11-08 23:09:34 UTC XORP CVS repository Added files: testbed/config config12.xt Log message: Add a new config file with a topology designed for OSPF testing. Requested by: Atanu Ghosh Revision Changes Path 1.1 +40 -0 other/testbed/config/config12.xt (new) From atanu@icir.org Wed Nov 9 02:18:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 9 Nov 2005 02:18:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511090218.jA92IgL9044245@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-09 02:18:42 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Fix typo in comment. Revision Changes Path 1.136 +2 -2; commitid: acba43715c817ea6; xorp/ospf/area_router.cc From pavlin@icir.org Wed Nov 9 02:33:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 9 Nov 2005 02:33:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200511090233.jA92Xb4Q044440@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-09 02:33:37 UTC XORP CVS repository Modified files: policy lex.yy_policy_parser.cc policy.l policy.y yacc.yy_policy_parser.cc yacc.yy_policy_parser.cc.h Log message: Add support to the lex/yacc parser for boolean policy terms. Revision Changes Path 1.12 +2273 -2127; commitid: ad7743715fe87ea6; xorp/policy/lex.yy_policy_parser.cc 1.12 +8 -0; commitid: ad7743715fe87ea6; xorp/policy/policy.l 1.10 +2 -1; commitid: ad7743715fe87ea6; xorp/policy/policy.y 1.13 +165 -157; commitid: ad7743715fe87ea6; xorp/policy/yacc.yy_policy_parser.cc 1.6 +37 -36; commitid: ad7743715fe87ea6; xorp/policy/yacc.yy_policy_parser.cc.h From pavlin@icir.org Wed Nov 9 02:46:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 9 Nov 2005 02:46:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/policy/test Message-ID: <200511090246.jA92kaE9044715@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-09 02:46:36 UTC XORP CVS repository Modified files: bgp bgp_varrw.hh bgp_varrw.cc etc/templates bgp.tp policy/test policyvarmap.conf Log message: Add policy-based support to remove MEDs from the routes advertised by BGP to its peers. The new BGP specific policy term is in the "then" block is the boolean med-remove which if set to true will remove the MEDs from the UPDATEs. E.g., to remove the MEDs from all UPDATEs: protocols { bgp { ... export: "bgp-meds" } } policy { policy-statement bgp-meds { term foo1 { then { /* med: 10 */ med-remove: true } } } } Note that "med-remove" has priority over the "med" modifier. I.e., if "med: 10" is uncommented, then the MEDs are still removed. Also, note that similar to the rest of the BGP policy code, if the med-remove's value is changed, all UPDATEs are resent with the MEDs being added/deleted as appropriate. Requested by: Atanu Ghosh Revision Changes Path 1.21 +32 -1; commitid: ae1b437160e07ea6; xorp/bgp/bgp_varrw.cc 1.14 +4 -1; commitid: ae1b437160e07ea6; xorp/bgp/bgp_varrw.hh 1.61 +7 -1; commitid: ae1b437160e07ea6; xorp/etc/templates/bgp.tp 1.4 +1 -0; commitid: ae1b437160e07ea6; xorp/policy/test/policyvarmap.conf From bms@icir.org Wed Nov 9 13:07:28 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 9 Nov 2005 13:07:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200511091307.jA9D7SEa051273@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-09 13:07:28 UTC XORP CVS repository Modified files: libcomm comm_sock.c Log message: Teach comm_sock_pair() to support AF_INET6 on Windows systems. It is a peculiarity of Windows networking that at least one physical interface on the system must be configured with the desired address family in order for a loopback interface to be present (AF_INET, AF_INET6). Note that if AF_UNIX is requested, AF_INET is still used. Use sockaddr_storage. Update comments. Obtained from: XORP/Win32 Revision Changes Path 1.29 +55 -20; commitid: c82a4371f47e7ea6; xorp/libcomm/comm_sock.c From atanu@icir.org Wed Nov 9 20:26:25 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 9 Nov 2005 20:26:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511092026.jA9KQPU5056182@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-09 20:26:25 UTC XORP CVS repository Modified files: ospf external.cc Log message: Slight refactoring an AS-External-LSA in no longer created before the step that may filter it out. Also fixes a memory leak that would have occurred if the route had been filtered. Revision Changes Path 1.14 +7 -7; commitid: db5b43725b707ea6; xorp/ospf/external.cc From atanu@icir.org Thu Nov 10 09:03:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 09:03:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511100903.jAA93LIZ062294@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 09:03:21 UTC XORP CVS repository Modified files: ospf lsa.cc lsa.hh Log message: Add a virtual method donew() to the ASExternalLSA class that the decoder can use to make a new LSA instance, allowing the use of the same decoder for AS-External-LSAs and Type-7 LSAs. Revision Changes Path 1.61 +3 -2; commitid: f33943730cd87ea6; xorp/ospf/lsa.cc 1.73 +16 -2; commitid: f33943730cd87ea6; xorp/ospf/lsa.hh From atanu@icir.org Thu Nov 10 09:30:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 09:30:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511100930.jAA9UgxK062724@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 09:30:42 UTC XORP CVS repository Modified files: ospf external.cc Log message: Reordering to reduce the chance of leaking memory in the future. Revision Changes Path 1.15 +3 -2; commitid: f4e9437313427ea6; xorp/ospf/external.cc From atanu@icir.org Thu Nov 10 09:40:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 09:40:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511100940.jAA9eM4C062964@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 09:40:22 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Support the generation of Type-7-LSAs are required for NSSAs. Use the AS-External-LSA machinery, but generate a distinct Type-7-LSA per area as opposed to the single copy of as AS-External-LSA that is kept for all areas. Revision Changes Path 1.137 +111 -9; commitid: f5d7437315847ea6; xorp/ospf/area_router.cc 1.79 +19 -3; commitid: f5d7437315847ea6; xorp/ospf/area_router.hh From atanu@icir.org Thu Nov 10 10:36:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 10:36:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511101036.jAAAaINR063764@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 10:36:18 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: In the base Lsa class external() is no longer pure virtual, it returns false so only ASExternalLSA and Type7 now have to define this method. Also added a type7() method to the base class to make it easy to identify Type-7-LSAs. Revision Changes Path 1.74 +13 -26; commitid: f8f9437322a07ea6; xorp/ospf/lsa.hh From atanu@icir.org Thu Nov 10 11:42:48 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 11:42:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511101142.jAABgmOS064711@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 11:42:48 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh ospf.hh Log message: If a Type-7-LSA has the propogate bit set and the router is a border router with translator state elected or enabled, then generate an AS-External-LSA. Revision Changes Path 1.138 +89 -14; commitid: fca8437332357ea6; xorp/ospf/area_router.cc 1.80 +18 -4; commitid: fca8437332357ea6; xorp/ospf/area_router.hh 1.71 +10 -1; commitid: fca8437332357ea6; xorp/ospf/ospf.hh From atanu@icir.org Thu Nov 10 17:57:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 17:57:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511101757.jAAHvZtx070689@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 17:57:35 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When refreshing a Type-7-LSA update the sequence number and age fields. Revision Changes Path 1.139 +4 -1; commitid: 1140643738a0d7ea6; xorp/ospf/area_router.cc From atanu@icir.org Thu Nov 10 19:15:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 19:15:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511101915.jAAJFqNk071473@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 19:15:52 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Only accept: * AS-External-LSAs in normal areas. * Type-7-LSAs in nssa areas. Revision Changes Path 1.140 +9 -1; commitid: 1171643739c667ea6; xorp/ospf/area_router.cc From atanu@icir.org Thu Nov 10 21:08:12 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 21:08:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511102108.jAAL8CXo072383@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 21:08:12 UTC XORP CVS repository Added files: ospf test_routing_table.cc Log message: Simple test to verify that the internal routing table entry when faced with routes of the same cost from different areas selects the route with largest area ID. Revision Changes Path 1.1 +116 -0 xorp/ospf/test_routing_table.cc (new) From atanu@icir.org Thu Nov 10 21:09:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 21:09:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511102109.jAAL99P9072447@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 21:09:09 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in Log message: Add test_routing_table.cc. Revision Changes Path 1.21 +5 -1; commitid: 11ae24373b6f47ea6; xorp/ospf/Makefile.am 1.18 +35 -6; commitid: 11ae24373b6f47ea6; xorp/ospf/Makefile.in From atanu@icir.org Thu Nov 10 21:27:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 10 Nov 2005 21:27:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511102127.jAALRFBv072691@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-10 21:27:15 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: The internal routing table entry was not correctly handing the same route from more than one area. Now when the costs match the route that came from the area with the largest router ID wins. Revision Changes Path 1.28 +11 -1; commitid: 11bd84373bb327ea6; xorp/ospf/routing_table.cc From pavlin@icir.org Thu Nov 10 23:55:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 10 Nov 2005 23:55:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511102355.jAANtfe7073864@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-10 23:55:41 UTC XORP CVS repository Modified files: rtrmgr template_base_command.cc template_base_command.hh template_tree_node.cc template_tree_node.hh Log message: * Add new methods AllowOperatorsCommand::allowed_operators() and TemplateTreeNode::allowed_operators() that can be used to return a list of the allowed operators per template tree node. * Minor bug fixes in the text of error messages. Revision Changes Path 1.10 +18 -2; commitid: 120434373dd9b7ea6; xorp/rtrmgr/template_base_command.cc 1.5 +2 -1; commitid: 120434373dd9b7ea6; xorp/rtrmgr/template_base_command.hh 1.64 +21 -3; commitid: 120434373dd9b7ea6; xorp/rtrmgr/template_tree_node.cc 1.39 +4 -1; commitid: 120434373dd9b7ea6; xorp/rtrmgr/template_tree_node.hh From atanu@icir.org Fri Nov 11 00:43:08 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 00:43:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511110043.jAB0h8jV074364@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 00:43:08 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: In order to support NSSAs the original LSA that contributed to a route can now be stored with the route. Revision Changes Path 1.27 +11 -1; commitid: 122614373e91c7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Fri Nov 11 01:29:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 01:29:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511110129.jAB1TJmY074776@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 01:29:19 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Consider Type-7-LSAs when updating the routing table. Revision Changes Path 1.141 +67 -9; commitid: 123fb4373f3ee7ea6; xorp/ospf/area_router.cc 1.81 +20 -1; commitid: 123fb4373f3ee7ea6; xorp/ospf/area_router.hh From pavlin@icir.org Fri Nov 11 01:55:27 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 01:55:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511110155.jAB1tRCF075055@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 01:55:27 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc template_tree_node.hh Log message: Cleanup the formatting of some of the error messages. Revision Changes Path 1.65 +231 -211; commitid: 125004373f9f37ea6; xorp/rtrmgr/template_tree_node.cc 1.40 +20 -20; commitid: 125004373f9f37ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Fri Nov 11 02:08:33 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 02:08:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511110208.jAB28XxM075233@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 02:08:33 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: * Add support for specifying the operator for a leaf node with value (e.g., for policy configuration). This fixes bugzilla #348. * Minor cleanup. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=348 Revision Changes Path 1.105 +260 -171; commitid: 125b74373fc937ea6; xorp/rtrmgr/cli.cc 1.38 +11 -4; commitid: 125b74373fc937ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Fri Nov 11 03:25:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 03:25:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200511110325.jAB3PnRB075885@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 03:25:49 UTC XORP CVS repository Modified files: cli cli_private.hh Log message: Change the libcli default config prompt from "XORP> " to "XORP# " for consistency with xorpsh. Revision Changes Path 1.7 +2 -2; commitid: 1283a43740f0b7ea6; xorp/cli/cli_private.hh From pavlin@icir.org Fri Nov 11 04:22:17 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 04:22:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200511110422.jAB4MHk9076400@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 04:22:17 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_node.cc cli_node.hh cli_node_net.cc Log message: Refactor the setting of the startup CLI prompt so now it can be specified as an argument when a new client is added. Revision Changes Path 1.44 +4 -3; commitid: 12a4f43741c557ea6; xorp/cli/cli_client.cc 1.24 +4 -2; commitid: 12a4f43741c557ea6; xorp/cli/cli_client.hh 1.30 +9 -9; commitid: 12a4f43741c557ea6; xorp/cli/cli_node.cc 1.23 +7 -3; commitid: 12a4f43741c557ea6; xorp/cli/cli_node.hh 1.45 +5 -4; commitid: 12a4f43741c557ea6; xorp/cli/cli_node_net.cc From pavlin@icir.org Fri Nov 11 04:38:31 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 04:38:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511110438.jAB4cVmk076579@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 04:38:31 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: * Change the default operational and configuration mode prompts from "Xorp> " and "XORP> " to "user@host> " and "user@hostname# " respectively. * On startup check the environmental variables XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT and if defined use them to overwrite the operational and configuration mode prompts respectively. * Minor refactoring in getting the user name. This fixes bugzilla entry #188. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=188 Revision Changes Path 1.106 +100 -27; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.cc 1.39 +6 -1; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Fri Nov 11 04:49:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 04:49:49 GMT Subject: [Xorp-cvs] XORP cvs commit: www www/html_src Message-ID: <200511110449.jAB4nnHK076785@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: www Changes by: pavlin@xorpc.icir.org 2005-11-11 04:49:49 UTC XORP CVS repository Modified files: . getting_started.html html_src getting_started.html Log message: Update the documentation to reflect the fact that now the operational and configuration mode prompts are "user@hostname> " and "user@hostname# " respectively. Revision Changes Path 1.52 +3 -3; commitid: 12bbe437422cc7ea6; www/getting_started.html 1.26 +2 -2; commitid: 12bbe437422cc7ea6; www/html_src/getting_started.html From pavlin@icir.org Fri Nov 11 04:50:35 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 04:50:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511110450.jAB4oZ1K076869@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 04:50:35 UTC XORP CVS repository Modified files: ospf .cvsignore Log message: Add test_routing_table to the list of ignored files by CVS. Revision Changes Path 1.4 +1 -0; commitid: 12c24437423087ea6; xorp/ospf/.cvsignore From pavlin@icir.org Fri Nov 11 05:28:09 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 05:28:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200511110528.jAB5S9mW077242@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 05:28:09 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Add release notes for the xorpsh prompt modifications. Revision Changes Path 1.88 +9 -1; commitid: 12d9d43742bd67ea6; xorp/RELEASE_NOTES From pavlin@icir.org Fri Nov 11 06:24:03 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 06:24:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200511110624.jAB6O3dU077861@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 06:24:03 UTC XORP CVS repository Modified files: docs/user_manual bgp.tex cli_intro.tex diagnostics.tex forwarding.tex igmp.tex interfaces.tex livecd.tex multicast_topology.tex pimsm.tex rip.tex static_routes.tex Log message: * Update the documentation to reflect the fact that now the operational and configuration mode prompts are "user@hostname> " and "user@hostname# " respectively. * Add a new subsection for configuring xorpsh behavior and document the XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT environmental variables. Revision Changes Path 1.13 +6 -6; commitid: 12ff3437438697ea6; xorp/docs/user_manual/bgp.tex 1.9 +68 -41; commitid: 12ff3437438697ea6; xorp/docs/user_manual/cli_intro.tex 1.4 +7 -7; commitid: 12ff3437438697ea6; xorp/docs/user_manual/diagnostics.tex 1.8 +4 -4; commitid: 12ff3437438697ea6; xorp/docs/user_manual/forwarding.tex 1.19 +4 -4; commitid: 12ff3437438697ea6; xorp/docs/user_manual/igmp.tex 1.9 +3 -3; commitid: 12ff3437438697ea6; xorp/docs/user_manual/interfaces.tex 1.2 +2 -2; commitid: 12ff3437438697ea6; xorp/docs/user_manual/livecd.tex 1.5 +3 -3; commitid: 12ff3437438697ea6; xorp/docs/user_manual/multicast_topology.tex 1.22 +11 -11; commitid: 12ff3437438697ea6; xorp/docs/user_manual/pimsm.tex 1.10 +2 -2; commitid: 12ff3437438697ea6; xorp/docs/user_manual/rip.tex 1.10 +4 -4; commitid: 12ff3437438697ea6; xorp/docs/user_manual/static_routes.tex From atanu@icir.org Fri Nov 11 07:52:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 07:52:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511110752.jAB7qEMA078822@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 07:52:14 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Deal with summaries from other areas into a nssa area the same way that they are dealt with into stub areas. Revision Changes Path 1.142 +2 -4; commitid: 133cb43744dad7ea6; xorp/ospf/area_router.cc From atanu@icir.org Fri Nov 11 07:58:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 07:58:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511110758.jAB7wIiO078945@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 07:58:18 UTC XORP CVS repository Modified files: ospf TODO Log message: Reconfiguring areas. Revision Changes Path 1.56 +4 -1; commitid: 1344643744f197ea6; xorp/ospf/TODO From atanu@icir.org Fri Nov 11 11:03:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 11:03:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511111103.jABB3q6Z081502@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 11:03:52 UTC XORP CVS repository Modified files: ospf packet.cc packet.hh Log message: Store the raw data associated with packet for possible later use for authentication. Revision Changes Path 1.29 +5 -1; commitid: 13e4143747a957ea6; xorp/ospf/packet.cc 1.25 +18 -1; commitid: 13e4143747a957ea6; xorp/ospf/packet.hh From atanu@icir.org Fri Nov 11 11:06:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 11:06:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511111106.jABB6Dls081628@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 11:06:13 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in peer.cc peer.hh peer_manager.cc Added files: ospf auth.cc auth.hh Log message: Start of authentication routines. Revision Changes Path 1.22 +4 -2; commitid: 13eb543747b237ea6; xorp/ospf/Makefile.am 1.19 +8 -5; commitid: 13eb543747b237ea6; xorp/ospf/Makefile.in 1.1 +16 -0 xorp/ospf/auth.cc (new) 1.1 +126 -0 xorp/ospf/auth.hh (new) 1.179 +2 -1; commitid: 13eb543747b237ea6; xorp/ospf/peer.cc 1.106 +4 -1; commitid: 13eb543747b237ea6; xorp/ospf/peer.hh 1.75 +2 -1; commitid: 13eb543747b237ea6; xorp/ospf/peer_manager.cc From bms@spc.org Fri Nov 11 13:52:13 2005 From: bms@spc.org (Bruce M Simpson) Date: Fri, 11 Nov 2005 13:52:13 +0000 Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf In-Reply-To: <200511111106.jABB6Dls081628@xorpc.icir.org> References: <200511111106.jABB6Dls081628@xorpc.icir.org> Message-ID: <20051111135213.GA733@empiric.icir.org> On Fri, Nov 11, 2005 at 11:06:13AM +0000, Atanu Ghosh wrote: > Log message: > Start of authentication routines. If you import MD5 in the same way as for libxipc then this should compile out of the box on Win32. The configure script has been taught how to look for the GnuWin32 package of OpenSSL which installs its DLLs with the same names as ssleay always did, though the import libraries have UNIX-style names (-lcrypto). BMS From zec@icir.org Fri Nov 11 15:23:29 2005 From: zec@icir.org (Marko Zec) Date: Fri, 11 Nov 2005 15:23:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511111523.jABFNTRR084786@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-11 15:23:29 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc bgp_varrw.hh route_table_base.hh route_table_filter.cc route_table_filter.hh subnet_route.cc subnet_route.hh Log message: Modify existing infrastructure to provide support for BGP route aggregation, as follows: Store aggregation tags/flags in SubnetRoute's _flags field. The size of SubnetRoute was not influenced by this change. Provide methods for accessing / modifying aggregation tags/flags. Add AGGREGATION_TABLE as another enum RouteRableType. Implement static outbound filters for filtering out products of the aggregation process, depending whether the branch is EBGP or IBGP. Provide varw interface for marking a route as a candidate for aggregation, by writing the prefix length of the requested aggregate to SubnetRoute. NOTE: this commit does NOT include the aggregation code itself nor the necessary plumbings, those will follow soon after resolving a few critical remaining issues. Revision Changes Path 1.22 +40 -1; commitid: 14b034374b71d7ea6; xorp/bgp/bgp_varrw.cc 1.15 +11 -1; commitid: 14b034374b71d7ea6; xorp/bgp/bgp_varrw.hh 1.13 +4 -3; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_base.hh 1.35 +62 -1; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_filter.cc 1.17 +20 -1; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_filter.hh 1.19 +13 -1; commitid: 14b034374b71d7ea6; xorp/bgp/subnet_route.cc 1.19 +57 -7; commitid: 14b034374b71d7ea6; xorp/bgp/subnet_route.hh From zec@icir.org Fri Nov 11 15:26:27 2005 From: zec@icir.org (Marko Zec) Date: Fri, 11 Nov 2005 15:26:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511111526.jABFQR5l084858@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-11 15:26:27 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Extend BGP template file to allow for marking of routes as aggregation candidates with desired aggregate-prefix-len. Revision Changes Path 1.62 +8 -1; commitid: 14b3f4374b79b7ea6; xorp/etc/templates/bgp.tp From deathdealer@gmx.net Fri Nov 11 16:19:02 2005 From: deathdealer@gmx.net (Patrick Preuss) Date: Fri, 11 Nov 2005 17:19:02 +0100 Subject: AW: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200511110438.jAB4cVmk076579@xorpc.icir.org> Message-ID: <000301c5e6db$a21c5800$760b000a@dedus737> Hello Pavlin, Nice would I be possible to change Prompt in the way that the domain is stript off: on my system I see root@dedus033.rscdus.retail-sc.com> but it would be nicer to have: root@dedus033# The Part with the Environment Vars. Is nice but when running as cli you don't have the chance to set this, wouldn't It be nicer to do this in the config somewhere below rtrmgr I think. Gruss    Patrick Marc Preuss -----Ursprüngliche Nachricht----- Von: xorp-cvs-admin@icir.org [mailto:xorp-cvs-admin@icir.org] Im Auftrag von Pavlin Radoslavov Gesendet: Freitag, 11. November 2005 05:39 An: xorp-cvs@icir.org Betreff: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-11 04:38:31 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: * Change the default operational and configuration mode prompts from "Xorp> " and "XORP> " to "user@host> " and "user@hostname# " respectively. * On startup check the environmental variables XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT and if defined use them to overwrite the operational and configuration mode prompts respectively. * Minor refactoring in getting the user name. This fixes bugzilla entry #188. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=188 Revision Changes Path 1.106 +100 -27; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.cc 1.39 +6 -1; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.hh _______________________________________________ Xorp-cvs mailing list Xorp-cvs@icir.org http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From atanu@icir.org Fri Nov 11 16:30:02 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 16:30:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511111630.jABGU2rc086900@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 16:30:02 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Add a new method to ASExternalLsa that allows the forwarding address to be extracted with using the address family specific routine directly (templates). Revision Changes Path 1.75 +14 -1; commitid: 153594374c7097ea6; xorp/ospf/lsa.hh From atanu@icir.org Fri Nov 11 16:33:11 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 16:33:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511111633.jABGXBbU087022@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 16:33:11 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Don't translate Type-7-LSAs to AS-External-LSAs if the forwarding address is zero OSPFv2 or the forwarding address is not present OSPFv3. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=349 Submitted by: Hasso Tepper Revision Changes Path 1.143 +12 -1; commitid: 153d34374c7c67ea6; xorp/ospf/area_router.cc From pavlin@icir.org Fri Nov 11 17:06:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 09:06:43 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Marko Zec of "Fri, 11 Nov 2005 15:23:29 GMT." <200511111523.jABFNTRR084786@xorpc.icir.org> Message-ID: <200511111706.jABH6hJP097173@possum.icir.org> > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: zec@xorpc.icir.org 2005-11-11 15:23:29 UTC > > XORP CVS repository > > > Modified files: > bgp bgp_varrw.cc bgp_varrw.hh route_table_base.hh > route_table_filter.cc route_table_filter.hh > subnet_route.cc subnet_route.hh > > Log message: > Modify existing infrastructure to provide support for BGP route > aggregation, as follows: > > Store aggregation tags/flags in SubnetRoute's _flags field. The size of > SubnetRoute was not influenced by this change. > > Provide methods for accessing / modifying aggregation tags/flags. > > Add AGGREGATION_TABLE as another enum RouteRableType. > > Implement static outbound filters for filtering out products of the > aggregation process, depending whether the branch is EBGP or IBGP. > > Provide varw interface for marking a route as a candidate for aggregation, > by writing the prefix length of the requested aggregate to SubnetRoute. > > NOTE: this commit does NOT include the aggregation code itself nor the > necessary plumbings, those will follow soon after resolving a few > critical remaining issues. Marko, Presumably, the new aggregate-prefix-len inside the BGP policy template will be hooked with the bgp_varrw.{hh,cc} modifications. According to the recent modification to bgp.tp the variable is registered as "aggregate_prefix_len" with the policy. In that case, I believe the new BGPVarRW methods must match the variable name and must be named read_aggregate_prefix_len() and write_aggregate_prefix_len() instead of read_aggr_pref_len() and write_aggr_pref_len() respectively (Andrea please correct me if this is not the case). While there, if the reading should never happen (as indicated by the printf() inside read_aggr_pref_len()), then you could just make/register the aggregate_prefix_len policy variable write-only so you can just remove that method. Also, I presume you meant to use debug_msg() instead of printf() inside the committed code :) Pavlin > > Revision Changes Path > 1.22 +40 -1; commitid: 14b034374b71d7ea6; xorp/bgp/bgp_varrw.cc > 1.15 +11 -1; commitid: 14b034374b71d7ea6; xorp/bgp/bgp_varrw.hh > 1.13 +4 -3; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_base.hh > 1.35 +62 -1; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_filter.cc > 1.17 +20 -1; commitid: 14b034374b71d7ea6; xorp/bgp/route_table_filter.hh > 1.19 +13 -1; commitid: 14b034374b71d7ea6; xorp/bgp/subnet_route.cc > 1.19 +57 -7; commitid: 14b034374b71d7ea6; xorp/bgp/subnet_route.hh > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Fri Nov 11 17:38:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 09:38:52 -0800 Subject: AW: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from "Patrick Preuss" of "Fri, 11 Nov 2005 17:19:02 +0100." <000301c5e6db$a21c5800$760b000a@dedus737> Message-ID: <200511111738.jABHcq2Q097616@possum.icir.org> > Nice would I be possible to change Prompt in the way that the domain is > stript off: on my system I see > > root@dedus033.rscdus.retail-sc.com> > > but it would be nicer to have: > > root@dedus033# I just checked with Juniper, and they don't strip the domain part. Hence, for consistency reason I'd prefer to keep it the way it is. > The Part with the Environment Vars. Is nice but when running as cli you > don't have the chance to set this, wouldn't It be nicer to do this in the > config somewhere below rtrmgr I think. Yes, we would like to make the xorpsh behavior more configurable, but this will be a major task on its own and currently such task is not high on our priority list. Once we have it implemented, eventually it could allow you to reconfigure xorpsh to strip the domain part. In the mean time you could use a simple shell wrapper like this one to call xorpsh and to set the prompt with the domain name stripped-off: #!/bin/sh username=`id -un` hostname=`hostname -s` export XORP_OPERATIONAL_MODE_PROMPT="${username}@${hostname}> " export XORP_CONFIGURATION_MODE_PROMPT="${username}@${hostname}# " /usr/local/xorp/bin/xorpsh If you name the above script "xorpsh", just make sure that its location is in your path before /usr/local/xorp/bin (or whatever place the real xorpsh is installed in). Pavlin > > Gruss >    Patrick Marc Preuss > > > -----Ursprüngliche Nachricht----- > Von: xorp-cvs-admin@icir.org [mailto:xorp-cvs-admin@icir.org] Im Auftrag von > Pavlin Radoslavov > Gesendet: Freitag, 11. November 2005 05:39 > An: xorp-cvs@icir.org > Betreff: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr > > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: pavlin@xorpc.icir.org 2005-11-11 04:38:31 UTC > > XORP CVS repository > > > Modified files: > rtrmgr cli.cc cli.hh > > Log message: > * Change the default operational and configuration mode prompts > from "Xorp> " and "XORP> " to "user@host> " and "user@hostname# " > respectively. > > * On startup check the environmental variables > XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT > and if defined use them to overwrite the operational and > configuration mode prompts respectively. > > * Minor refactoring in getting the user name. > > This fixes bugzilla entry #188. > > Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=188 > > Revision Changes Path > 1.106 +100 -27; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.cc > 1.39 +6 -1; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.hh > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > > > > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From zec@icir.org Fri Nov 11 17:38:41 2005 From: zec@icir.org (Marko Zec) Date: Fri, 11 Nov 2005 18:38:41 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: <200511111706.jABH6hJP097173@possum.icir.org> References: <200511111706.jABH6hJP097173@possum.icir.org> Message-ID: <200511111838.41182.zec@icir.org> On Friday 11 November 2005 18:06, Pavlin Radoslavov wrote: > Presumably, the new aggregate-prefix-len inside the BGP policy > template will be hooked with the bgp_varrw.{hh,cc} modifications. > According to the recent modification to bgp.tp the variable is > registered as "aggregate_prefix_len" with the policy. > In that case, I believe the new BGPVarRW methods must match the > variable name and must be named read_aggregate_prefix_len() and > write_aggregate_prefix_len() instead of read_aggr_pref_len() and > write_aggr_pref_len() respectively (Andrea please correct me if this > is not the case). I tested the bgp_varrw interface with the latest modifications from Andrea and it seems to work OK as is. Whether there is a new naming convention that needs to be followed is another story, I am / was not aware of that. I'll change the naming of the funcions as you suggest if needed, but I'd prefer not to have exceedingly long method names if not absolutely necessary. > While there, if the reading should never happen (as indicated by > the printf() inside read_aggr_pref_len()), then you could just > make/register the aggregate_prefix_len policy variable write-only so > you can just remove that method. Agreed, but for the time being I'd like to leave it as-is for testing purposes. If I would turn on debugging in bgp_varrw then this message could be easily lost in the noise of other stuff. > Also, I presume you meant to use > debug_msg() instead of printf() inside the committed code :) Actually the printf() will go away... Onve reading the preflen becomes prohibited using the varmap (as you suggested above) there will be no need for the printf at all, even in the form of debug_msg(). The issue is that in the outbound filters one might wish to read the contents of the preflen, but under a different name -> there it should read as a boolean telling us whether the route has been aggregated or not. But let's see first if this aggregation thing will work at all :-) Marko From zec@icir.org Fri Nov 11 17:52:37 2005 From: zec@icir.org (Marko Zec) Date: Fri, 11 Nov 2005 17:52:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511111752.jABHqb6b088127@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-11 17:52:37 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc Log message: Remove a _really_ unnecessary printf() in write_aggr_pref_len() Requested by: Pavlin Revision Changes Path 1.23 +1 -2; commitid: 158204374da297ea6; xorp/bgp/bgp_varrw.cc From pavlin@icir.org Fri Nov 11 17:56:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 11 Nov 2005 09:56:28 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Marko Zec of "Fri, 11 Nov 2005 18:38:41 +0100." <200511111838.41182.zec@icir.org> Message-ID: <200511111756.jABHuSo6097830@possum.icir.org> > On Friday 11 November 2005 18:06, Pavlin Radoslavov wrote: > > Presumably, the new aggregate-prefix-len inside the BGP policy > > template will be hooked with the bgp_varrw.{hh,cc} modifications. > > According to the recent modification to bgp.tp the variable is > > registered as "aggregate_prefix_len" with the policy. > > In that case, I believe the new BGPVarRW methods must match the > > variable name and must be named read_aggregate_prefix_len() and > > write_aggregate_prefix_len() instead of read_aggr_pref_len() and > > write_aggr_pref_len() respectively (Andrea please correct me if this > > is not the case). > > I tested the bgp_varrw interface with the latest modifications from > Andrea and it seems to work OK as is. Whether there is a new naming > convention that needs to be followed is another story, I am / was not > aware of that. I'll change the naming of the funcions as you suggest > if needed, but I'd prefer not to have exceedingly long method names if > not absolutely necessary. On second thought, I think you are right. Initially I had brain failure on trying to understand how exactly the policy code matches a policy variable like "aggregate_prefix_len" introduced by some of the rtrmgr templates with its corresponding read_aggr_pref_len() and write_aggr_pref_len() methods. I simply overlooked the fact that the VAR_FOO enum values inside class BGPVarRW actually do match the values introduced by the add_varmap XRLs. Nevertheless, given that the rest of the policy code uses same naming scheme for the variable, for the enum, and the rw methods, for the sake of consistency I'd recommend that you use similar naming even if it means longer method names. Pavlin From deathdealer@gmx.net Fri Nov 11 19:46:44 2005 From: deathdealer@gmx.net (Patrick Preuss) Date: Fri, 11 Nov 2005 20:46:44 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200511111738.jABHcq2Q097616@possum.icir.org> Message-ID: <000301c5e6f8$a5cb9e30$1608000a@dedus737> > I just checked with Juniper, and they don't strip the domain > part. Hence, for consistency reason I'd prefer to keep it the way it > is. Ok I haven't checked it on juniper, it is ok when they do this, so we could also, it was a little confusing because I am more familiar with the cisco's and the do not, and also my shell do not display it, so I was a little confused. May thanks for the script;-) Patrick From atanu@icir.org Fri Nov 11 22:16:08 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 22:16:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511112216.jABMG8qs090488@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 22:16:07 UTC XORP CVS repository Modified files: ospf auth.hh peer.cc peer.hh Log message: The MD5 authentication method adds a 16 byte trailer to the packet. Add a method to the extract the size of the trailer allowing the OSPF packet to be made smaller by the specified amount. The auth class can now also return any errors generated by the verification stage. One auth structure for all outbound packets and one auth structure per neighbour for inbound packets. The authentication method and password can now be configured. All inbound and outbound packets are now passed through an authentication state. Only null authentication is currently supported. Revision Changes Path 1.2 +36 -1; commitid: 16159437518267ea6; xorp/ospf/auth.hh 1.180 +72 -3; commitid: 16159437518267ea6; xorp/ospf/peer.cc 1.107 +42 -4; commitid: 16159437518267ea6; xorp/ospf/peer.hh From atanu@icir.org Fri Nov 11 22:58:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 11 Nov 2005 22:58:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511112258.jABMwMM8091815@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-11 22:58:22 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: If when redistributing from another protocol into a NSSA the Type-7-LSA is already in the database stop processing, its not an error. Bug found by: Pavlin Radoslavov Revision Changes Path 1.144 +22 -8; commitid: 1668a4375220d7ea6; xorp/ospf/area_router.cc 1.82 +4 -2; commitid: 1668a4375220d7ea6; xorp/ospf/area_router.hh From a.bittau@cs.ucl.ac.uk Fri Nov 11 20:31:34 2005 From: a.bittau@cs.ucl.ac.uk (Andrea Bittau) Date: Fri, 11 Nov 2005 20:31:34 +0000 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: <200511111756.jABHuSo6097830@possum.icir.org> References: <200511111838.41182.zec@icir.org> <200511111756.jABHuSo6097830@possum.icir.org> Message-ID: <20051111203134.GA805@tribal.sorbonet.org> On Fri, Nov 11, 2005 at 09:56:28AM -0800, Pavlin Radoslavov wrote: > On second thought, I think you are right. Initially I had brain > failure on trying to understand how exactly the policy code matches > a policy variable like "aggregate_prefix_len" introduced by some of > the rtrmgr templates with its corresponding read_aggr_pref_len() and > write_aggr_pref_len() methods. I simply overlooked the fact that the Yea originally it would just do string matching. So it would do read("aggregate_prefix_len"); If read called another method, the method name could be anything. In fact I don't think there is a way to call a specific method based on a variable in C++ [something like java reflect =D]. Currently, it uses numerical ids for performance issues. So you get read(1) for variable X, read(2) for variable Y etc etc. This way there is no longer the need to construct strings and perform any string matching. From pavlin@icir.org Sat Nov 12 05:49:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 05:49:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511120549.jAC5nONM094987@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 05:49:24 UTC XORP CVS repository Modified files: etc/templates static_routes.tp Log message: Fix the protocol name to match the remaped name "static" instead of the target name. Revision Changes Path 1.27 +3 -3; commitid: 172ed437582417ea6; xorp/etc/templates/static_routes.tp From pavlin@icir.org Sat Nov 12 05:50:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 05:50:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511120550.jAC5o6E9095035@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 05:50:06 UTC XORP CVS repository Modified files: ospf policy_varrw.cc Log message: Bug fix in setting the _e_bit value. Revision Changes Path 1.5 +2 -4; commitid: 1731f4375827f7ea6; xorp/ospf/policy_varrw.cc From pavlin@icir.org Sat Nov 12 05:56:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 05:56:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511120556.jAC5u5DP095128@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 05:56:05 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: * Change the protocol policy name from the targetname to ospf4. * Add the OSPF-specific policy statements: nexthop4 - Read Write metric - Read Write ebit - Read Write tag - Read Write Note that network4 (read-only) is also used by OSPF, but it is part of the policy.tp template. Requested by: Atanu Ghosh Revision Changes Path 1.22 +103 -11; commitid: 17366437582c07ea6; xorp/etc/templates/ospfv2.tp From pavlin@icir.org Sat Nov 12 06:18:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 06:18:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511120618.jAC6I0es095343@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 06:18:00 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Don't set a default value for med-remove, because it is BGP-specific variable, and the corresponding XRL will be executed even if we are not running BGP which will trigger an error. E.g., if we are running, say, only OSPF, an OSPF export policy like the following would have trigger the med-remove XRL and the result error will prevent XORP from starting: policy { policy-statement export_static { term static { from { protocol: "static" } then { tag: 10 } } } } Bug found by: Atanu Ghosh Revision Changes Path 1.63 +2 -2; commitid: 1744a4375886d7ea6; xorp/etc/templates/bgp.tp From pavlin@icir.org Sat Nov 12 08:59:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 08:59:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511120859.jAC8xo7u096761@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 08:59:50 UTC XORP CVS repository Modified files: etc/templates rib.tp rip.tp Log message: * Add a policy name mapping between "rib" and "connected". Note that now the name of the protocol that identifies the connected routes (for policy-related needs) is "connected", while previously it was the ambiguous "rib" (the RIB targetname). * Move the "connected"-related policy template stuff to rib.tp Revision Changes Path 1.17 +14 -1; commitid: 179c34375ae547ea6; xorp/etc/templates/rib.tp 1.26 +1 -7; commitid: 179c34375ae547ea6; xorp/etc/templates/rip.tp From atanu@icir.org Sat Nov 12 21:14:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 12 Nov 2005 21:14:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511122114.jACLElK4007995@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-12 21:14:47 UTC XORP CVS repository Modified files: ospf TODO packet.hh Log message: Add constants in the Packet class that provide the offsets and sizes for authentication. Revision Changes Path 1.57 +4 -1; commitid: 1f1e43765b467ea6; xorp/ospf/TODO 1.26 +9 -4; commitid: 1f1e43765b467ea6; xorp/ospf/packet.hh From atanu@icir.org Sat Nov 12 21:42:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 12 Nov 2005 21:42:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511122142.jACLgFhb008297@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-12 21:42:15 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc Log message: Fix to allow this file to compile with the optimiser. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=323 Submitted by: Hasso Tepper Revision Changes Path 1.66 +2 -2; commitid: 204e437661b67ea6; xorp/rtrmgr/template_tree_node.cc From atanu@icir.org Sat Nov 12 23:09:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 12 Nov 2005 23:09:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511122309.jACN9KhG009046@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-12 23:09:20 UTC XORP CVS repository Modified files: ospf peer.cc Log message: The type OspfTypes::RouterID was originally IPv4 it was later changed to unsigned integer. A construct of the form OspfTypes::RouterID("0.0.0.0") used to yield zero. It now returns the the address of the string "0.0.0.0" as it is now a cast, the joys of C++. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=354 Submitted by: Hasso Tepper Revision Changes Path 1.181 +2 -3; commitid: 233b4376761e7ea6; xorp/ospf/peer.cc From pavlin@icir.org Sat Nov 12 23:37:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 23:37:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200511122337.jACNbhPi009274@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 23:37:43 UTC XORP CVS repository Modified files: policy term.cc Log message: Fix the logic inside method Term::del_block() Revision Changes Path 1.15 +14 -11; commitid: 242143767cb87ea6; xorp/policy/term.cc From pavlin@icir.org Sat Nov 12 23:38:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 12 Nov 2005 23:38:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511122338.jACNcFNs009325@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-12 23:38:15 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Fix the policy-related template for OSPF. Revision Changes Path 1.23 +4 -4; commitid: 245443767cdc7ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Sat Nov 12 23:42:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 12 Nov 2005 23:42:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511122342.jACNg9LR009430@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-12 23:42:09 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Don't allow authentication to be set in OSPFv3. Revision Changes Path 1.182 +9 -1; commitid: 24bb43767dd07ea6; xorp/ospf/peer.cc From atanu@icir.org Sat Nov 12 23:43:24 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 12 Nov 2005 23:43:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511122343.jACNhNVH009566@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-12 23:43:23 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Allow authentication to be configured via XRLs. Revision Changes Path 1.52 +19 -1; commitid: 250743767e187ea6; xorp/ospf/ospf.cc 1.72 +8 -1; commitid: 250743767e187ea6; xorp/ospf/ospf.hh 1.76 +14 -1; commitid: 250743767e187ea6; xorp/ospf/peer_manager.cc 1.52 +7 -1; commitid: 250743767e187ea6; xorp/ospf/peer_manager.hh 1.22 +20 -1; commitid: 250743767e187ea6; xorp/ospf/xrl_target.cc 1.15 +12 -1; commitid: 250743767e187ea6; xorp/ospf/xrl_target.hh 1.10 +10 -1; commitid: 250743767e187ea6; xorp/xrl/interfaces/ospfv2.xif 1.11 +41 -1; commitid: 250743767e187ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.11 +25 -1; commitid: 250743767e187ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.13 +6 -1; commitid: 250743767e187ea6; xorp/xrl/targets/ospfv2.xrls 1.13 +35 -1; commitid: 250743767e187ea6; xorp/xrl/targets/ospfv2_base.cc 1.13 +16 -1; commitid: 250743767e187ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Sun Nov 13 05:32:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 05:32:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130532.jAD5WTNc012479@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 05:32:29 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Save the authentication method and password. When a new neighbour is created use the saved authentication values to prime the neighbour authentiation state. Revision Changes Path 1.183 +5 -4; commitid: 30a44376cfeb7ea6; xorp/ospf/peer.cc From atanu@icir.org Sun Nov 13 05:34:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 05:34:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130534.jAD5YKet012562@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 05:34:20 UTC XORP CVS repository Modified files: ospf auth.cc auth.hh Log message: Simple password authentication. Revision Changes Path 1.2 +64 -1; commitid: 30f54376d05b7ea6; xorp/ospf/auth.cc 1.3 +10 -2; commitid: 30f54376d05b7ea6; xorp/ospf/auth.hh From atanu@icir.org Sun Nov 13 05:35:56 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 05:35:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511130535.jAD5ZupR012647@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 05:35:56 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow authentication to be configured. Revision Changes Path 1.24 +12 -1; commitid: 314c4376d0bb7ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Sun Nov 13 06:55:10 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 06:55:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130655.jAD6tAw9013397@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 06:55:10 UTC XORP CVS repository Modified files: ospf ospf.hh Log message: Add consts for the various kinds of authentication. Revision Changes Path 1.73 +4 -1; commitid: 343a4376e34d7ea6; xorp/ospf/ospf.hh From atanu@icir.org Sun Nov 13 06:55:56 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 06:55:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130655.jAD6tuGk013466@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 06:55:56 UTC XORP CVS repository Modified files: ospf packet.hh Log message: Add consts for the checksum offset. Revision Changes Path 1.27 +2 -1; commitid: 347f4376e37b7ea6; xorp/ospf/packet.hh From atanu@icir.org Sun Nov 13 07:11:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 07:11:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130711.jAD7B5Lx013760@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 07:11:05 UTC XORP CVS repository Modified files: ospf packet.cc Log message: If cryptographic authentication is being used then the checksum is not used so don't verify it. Revision Changes Path 1.30 +5 -2; commitid: 35a54376e7097ea6; xorp/ospf/packet.cc From atanu@icir.org Sun Nov 13 08:02:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 08:02:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511130802.jAD82tmj014283@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 08:02:55 UTC XORP CVS repository Modified files: ospf auth.cc auth.hh Log message: Add MD5 support. For the simple password case incrementally adjust rhe checksum. Revision Changes Path 1.3 +98 -1; commitid: 37ae4376f32e7ea6; xorp/ospf/auth.cc 1.4 +16 -3; commitid: 37ae4376f32e7ea6; xorp/ospf/auth.hh From pavlin@icir.org Sun Nov 13 09:21:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 13 Nov 2005 09:21:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200511130921.jAD9LU73015117@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-13 09:21:30 UTC XORP CVS repository Modified files: cli cli_client.cc cli_client.hh cli_command.cc Log message: If we try to use to complete the creation of a multi-value node, then print the expected type(s) of the multi-value node(s). This fixes bugzilla entry #185. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=185 Revision Changes Path 1.45 +32 -10; commitid: 3aac437703dd7ea6; xorp/cli/cli_client.cc 1.25 +3 -2; commitid: 3aac437703dd7ea6; xorp/cli/cli_client.hh 1.21 +11 -6; commitid: 3aac437703dd7ea6; xorp/cli/cli_command.cc From atanu@icir.org Sun Nov 13 16:55:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 16:55:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511131655.jADGtqKg020328@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 16:55:52 UTC XORP CVS repository Modified files: ospf auth.cc Log message: If there is simple password mismatch print the passwords. Revision Changes Path 1.4 +23 -1; commitid: 4f4d437770177ea6; xorp/ospf/auth.cc From atanu@icir.org Sun Nov 13 17:01:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 17:01:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511131701.jADH1N7J020428@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 17:01:23 UTC XORP CVS repository Modified files: ospf peer.cc Log message: When a hello packet arrived from a new neighbour new authentication state was created but reset() was not being called. Revision Changes Path 1.184 +2 -1; commitid: 4fb1437771617ea6; xorp/ospf/peer.cc From atanu@icir.org Sun Nov 13 19:25:34 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 19:25:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511131925.jADJPYCs021885@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 19:25:34 UTC XORP CVS repository Modified files: ospf TODO auth.cc auth.hh Log message: Documentation update for authentication. Revision Changes Path 1.58 +5 -1; commitid: 555e4377932e7ea6; xorp/ospf/TODO 1.5 +2 -2; commitid: 555e4377932e7ea6; xorp/ospf/auth.cc 1.5 +23 -3; commitid: 555e4377932e7ea6; xorp/ospf/auth.hh From atanu@icir.org Sun Nov 13 21:56:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 21:56:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511132156.jADLuFUR023155@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 21:56:15 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: If the state transition to ExStart is normal then send a data description packet immediately and start the retransmit timer. If the state transition to ExStart is due to an error just start the retransmit timer. Previously an error in the database exchange could cause back to back database description packets to be sent. Its possible this was the cause of the bug below. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=292 Revision Changes Path 1.185 +6 -4; commitid: 5a564377b67c7ea6; xorp/ospf/peer.cc 1.108 +7 -2; commitid: 5a564377b67c7ea6; xorp/ospf/peer.hh From mjh@icir.org Sun Nov 13 21:59:09 2005 From: mjh@icir.org (Mark Handley) Date: Sun, 13 Nov 2005 21:59:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511132159.jADLx9Jm023216@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-13 21:59:09 UTC XORP CVS repository Modified files: bgp aspath.cc aspath.hh parameter.cc parameter.hh Log message: A start at the code needed to support 4-byte AS numbers. Not tested at all, but this isn't yet connected, so shouldn't cause any problems. Revision Changes Path 1.27 +326 -1; commitid: 5a8f4377b6e77ea6; xorp/bgp/aspath.cc 1.21 +100 -7; commitid: 5a8f4377b6e77ea6; xorp/bgp/aspath.hh 1.29 +75 -1; commitid: 5a8f4377b6e77ea6; xorp/bgp/parameter.cc 1.19 +17 -1; commitid: 5a8f4377b6e77ea6; xorp/bgp/parameter.hh From pavlin@icir.org Sun Nov 13 22:13:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 13 Nov 2005 22:13:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511132213.jADMDSGu023557@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-13 22:13:28 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Ignore deleted config nodes when searching for a node whose value we are going to check or set. This fixes bugzilla entry #211 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=211 Revision Changes Path 1.100 +38 -11; commitid: 5be74377ba167ea6; xorp/rtrmgr/conf_tree_node.cc From zec@icir.org Sun Nov 13 22:49:21 2005 From: zec@icir.org (Marko Zec) Date: Sun, 13 Nov 2005 22:49:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511132249.jADMnLa5023886@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-13 22:49:21 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc bgp_varrw.hh Log message: Add varrw interface for checking whether a route was aggregated or not. Change method names *_aggr_pref_len() to *_aggregate_prefix_len(), to better reflect / match the policy template.o Remove an unnecessary printf(). Requested by: Pavlin Revision Changes Path 1.24 +28 -7; commitid: 5d214377c2197ea6; xorp/bgp/bgp_varrw.cc 1.16 +6 -3; commitid: 5d214377c2197ea6; xorp/bgp/bgp_varrw.hh From zec@icir.org Sun Nov 13 22:54:43 2005 From: zec@icir.org (Marko Zec) Date: Sun, 13 Nov 2005 22:54:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511132254.jADMshOY023956@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-13 22:54:43 UTC XORP CVS repository Modified files: bgp route_table_filter.cc Log message: Propagate aggregation flags to new SubnetRoutes. Teach NexthopRewriteFilter to rewrite the nexthop attribute on locally originated aggregate routes. Revision Changes Path 1.36 +5 -2; commitid: 5d7b4377c3827ea6; xorp/bgp/route_table_filter.cc From zec@icir.org Sun Nov 13 23:00:03 2005 From: zec@icir.org (Marko Zec) Date: Sun, 13 Nov 2005 23:00:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511132300.jADN03ap024059@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-13 23:00:03 UTC XORP CVS repository Modified files: bgp bgp.hh Log message: Add public method BGPMain::get_rib_handler() which returns a pointer to RibIpcHandler instance. Needed by aggregation code to properly mark aggregate routes as locally originated. Revision Changes Path 1.48 +2 -1; commitid: 5dcc4377c4b07ea6; xorp/bgp/bgp.hh From atanu@icir.org Sun Nov 13 23:48:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 13 Nov 2005 23:48:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511132348.jADNm91m024551@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-13 23:48:09 UTC XORP CVS repository Modified files: ospf peer.cc Log message: 1) When adding the LSA headers to a data description packet there is no need to add authentication state every time. 2) When moving to state Exchange put database description information in the packet even for the slave. 3) When in state ExStart and the router is the master compare the incoming sequence number with the value in the packet that was sent not in the _last_dd data structure which has just been reset with the incoming packets values. Bug found by: Hasso Tepper Revision Changes Path 1.186 +3 -4; commitid: 5fcb4377d0b87ea6; xorp/ospf/peer.cc From atanu@icir.org Mon Nov 14 03:43:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 14 Nov 2005 03:43:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511140343.jAE3hIU4027107@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-14 03:43:18 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Slight refactoring of the database exchange. The packet holding all the state of the last packet from the neighbour is no longer manipulated. The majority of the comparisons are now performed against the routers own packets rather than the last packet from the neighbour. The trace messages now contain neighbour information. Revision Changes Path 1.187 +23 -16; commitid: 69c8437807d57ea6; xorp/ospf/peer.cc From pavlin@icir.org Mon Nov 14 03:44:58 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 03:44:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/docs/user_manual xorp/rtrmgr Message-ID: <200511140344.jAE3iwLv027193@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 03:44:58 UTC XORP CVS repository Modified files: . RELEASE_NOTES docs/user_manual cli_intro.tex rtrmgr cli.cc cli.hh Log message: Rename XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT to XORP_PROMPT_OPERATIONAL and XORP_PROMPT_CONFIGURATION respectively. [The former naming was too random; the newer naming scheme is more systematic and is based on an old email/suggestion by Atanu Ghosh]. Revision Changes Path 1.89 +2 -2; commitid: 69a84378071a7ea6; xorp/RELEASE_NOTES 1.10 +5 -5; commitid: 69a84378071a7ea6; xorp/docs/user_manual/cli_intro.tex 1.107 +7 -7; commitid: 69a84378071a7ea6; xorp/rtrmgr/cli.cc 1.40 +3 -3; commitid: 69a84378071a7ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Mon Nov 14 03:49:31 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 13 Nov 2005 19:49:31 -0800 Subject: AW: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Pavlin Radoslavov of "Fri, 11 Nov 2005 09:38:52 PST." <200511111738.jABHcq2Q097616@possum.icir.org> Message-ID: <200511140349.jAE3nVgP002936@possum.icir.org> Just for the record, now XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT are renamed to XORP_PROMPT_OPERATIONAL and XORP_PROMPT_CONFIGURATION respectively. The former naming was too random; the newer naming scheme is more systematic and is based on an old email/suggestion by Atanu Ghosh. Pavlin > > Nice would I be possible to change Prompt in the way that the domain is > > stript off: on my system I see > > > > root@dedus033.rscdus.retail-sc.com> > > > > but it would be nicer to have: > > > > root@dedus033# > > I just checked with Juniper, and they don't strip the domain > part. Hence, for consistency reason I'd prefer to keep it the way it > is. > > > The Part with the Environment Vars. Is nice but when running as cli you > > don't have the chance to set this, wouldn't It be nicer to do this in the > > config somewhere below rtrmgr I think. > > Yes, we would like to make the xorpsh behavior more configurable, > but this will be a major task on its own and currently such task is > not high on our priority list. Once we have it implemented, > eventually it could allow you to reconfigure xorpsh to strip the > domain part. > In the mean time you could use a simple shell wrapper like this one > to call xorpsh and to set the prompt with the domain name > stripped-off: > > #!/bin/sh > > username=`id -un` > hostname=`hostname -s` > > export XORP_OPERATIONAL_MODE_PROMPT="${username}@${hostname}> " > export XORP_CONFIGURATION_MODE_PROMPT="${username}@${hostname}# " > /usr/local/xorp/bin/xorpsh > > > If you name the above script "xorpsh", just make sure that its > location is in your path before /usr/local/xorp/bin (or whatever > place the real xorpsh is installed in). > > Pavlin > > > > > Gruss > >    Patrick Marc Preuss > > > > > > -----Ursprüngliche Nachricht----- > > Von: xorp-cvs-admin@icir.org [mailto:xorp-cvs-admin@icir.org] Im Auftrag von > > Pavlin Radoslavov > > Gesendet: Freitag, 11. November 2005 05:39 > > An: xorp-cvs@icir.org > > Betreff: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr > > > > CVSROOT: /usr/local/share/doc/apache/cvs > > Module name: xorp > > Changes by: pavlin@xorpc.icir.org 2005-11-11 04:38:31 UTC > > > > XORP CVS repository > > > > > > Modified files: > > rtrmgr cli.cc cli.hh > > > > Log message: > > * Change the default operational and configuration mode prompts > > from "Xorp> " and "XORP> " to "user@host> " and "user@hostname# " > > respectively. > > > > * On startup check the environmental variables > > XORP_OPERATIONAL_MODE_PROMPT and XORP_CONFIGURATION_MODE_PROMPT > > and if defined use them to overwrite the operational and > > configuration mode prompts respectively. > > > > * Minor refactoring in getting the user name. > > > > This fixes bugzilla entry #188. > > > > Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=188 > > > > Revision Changes Path > > 1.106 +100 -27; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.cc > > 1.39 +6 -1; commitid: 12a8f43741c8d7ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Mon Nov 14 07:03:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 07:03:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200511140703.jAE73FWW029078@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 07:03:15 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: Bug fix in resetting the prompt after an error. This fixes bugzilla entry #272 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=272 Revision Changes Path 1.46 +2 -2; commitid: 71784378368b7ea6; xorp/cli/cli_client.cc From pavlin@icir.org Mon Nov 14 09:17:02 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 09:17:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200511140917.jAE9H2B0030595@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 09:17:02 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: Reverse-back the previous commit, because it is the wrong fix for bugzilla entry #272. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=272 Revision Changes Path 1.47 +2 -2; commitid: 776a437855d67ea6; xorp/cli/cli_client.cc From pavlin@icir.org Mon Nov 14 09:49:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 09:49:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511140949.jAE9nUoc030942@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 09:49:30 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Reverse-back the previous commit that attempted to fix bugzilla #211, because it creates some other issues. E.g., the following sequence of commands will fail: create interfaces interface eth1 vif eth1 commit delete interfaces interface eth1 vif eth1 commit Failed to expand XRL xrl $(interfaces.targetname)/ifmgr/0.1/delete_vif?tid:u32=$(interfaces.TID)&ifname:txt=$(interface.@)&vif:txt=$(@): failed to expand variable1 "$(@)" associated with node "eth1"[edit] Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=211 Revision Changes Path 1.101 +10 -37; commitid: 78bc43785d027ea6; xorp/rtrmgr/conf_tree_node.cc From mjh@icir.org Mon Nov 14 11:38:44 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 14 Nov 2005 11:38:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511141138.jAEBciEq032576@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-14 11:38:43 UTC XORP CVS repository Modified files: bgp parameter.cc parameter.hh Log message: Remove support for the BGP Authentication Information parameter. We never really supported it (just aborted if we received it), and it's deprecated in the latest spec. We couldn't support it if we wanted to, as it's not properly specified in the original RFC. Revision Changes Path 1.30 +4 -75; commitid: 7f17437876ed7ea6; xorp/bgp/parameter.cc 1.20 +1 -42; commitid: 7f17437876ed7ea6; xorp/bgp/parameter.hh From pavlin@icir.org Mon Nov 14 17:29:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 17:29:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/mrt/include Message-ID: <200511141729.jAEHTSxD040747@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 17:29:28 UTC XORP CVS repository Modified files: mrt/include ip_mroute.h Log message: Fix a comment. Revision Changes Path 1.13 +4 -3; commitid: 9f124378c9737ea6; xorp/mrt/include/ip_mroute.h From pavlin@icir.org Mon Nov 14 17:32:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 14 Nov 2005 17:32:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config xorp Message-ID: <200511141732.jAEHWhPF040880@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-14 17:32:43 UTC XORP CVS repository Modified files: config acipv4.m4 . configure Log message: On NetBSD and OpenBSD the definition of 'struct igmpmsg' and IGMPMSG_* is wrapped inside #ifdef _KERNEL hence we need to define _KERNEL before including . This fixed configure-time check on NetBSD and OpenBSD whether the system supports IPv4 multicast routing. Bug found by: Nerijus Ambrazas Revision Changes Path 1.5 +11 -2; commitid: 9f7c4378c9e97ea6; xorp/config/acipv4.m4 1.171 +10 -1; commitid: 9f7c4378c9e97ea6; xorp/configure From atanu@icir.org Mon Nov 14 19:33:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 14 Nov 2005 19:33:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511141933.jAEJXVUI042422@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-14 19:33:31 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in area_router.cc area_router.hh ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Added files: ospf vlink.cc vlink.hh Log message: Initial virtual link support. Revision Changes Path 1.23 +3 -1; commitid: a54d4378e6867ea6; xorp/ospf/Makefile.am 1.20 +4 -3; commitid: a54d4378e6867ea6; xorp/ospf/Makefile.in 1.145 +23 -1; commitid: a54d4378e6867ea6; xorp/ospf/area_router.cc 1.83 +11 -1; commitid: a54d4378e6867ea6; xorp/ospf/area_router.hh 1.53 +41 -1; commitid: a54d4378e6867ea6; xorp/ospf/ospf.cc 1.74 +23 -1; commitid: a54d4378e6867ea6; xorp/ospf/ospf.hh 1.77 +43 -1; commitid: a54d4378e6867ea6; xorp/ospf/peer_manager.cc 1.53 +23 -1; commitid: a54d4378e6867ea6; xorp/ospf/peer_manager.hh 1.1 +104 -0 xorp/ospf/vlink.cc (new) 1.1 +50 -0 xorp/ospf/vlink.hh (new) 1.23 +46 -1; commitid: a54d4378e6867ea6; xorp/ospf/xrl_target.cc 1.16 +36 -1; commitid: a54d4378e6867ea6; xorp/ospf/xrl_target.hh 1.11 +28 -1; commitid: a54d4378e6867ea6; xorp/xrl/interfaces/ospfv2.xif 1.12 +101 -1; commitid: a54d4378e6867ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.12 +75 -1; commitid: a54d4378e6867ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.14 +28 -1; commitid: a54d4378e6867ea6; xorp/xrl/targets/ospfv2.xrls 1.14 +93 -1; commitid: a54d4378e6867ea6; xorp/xrl/targets/ospfv2_base.cc 1.14 +48 -1; commitid: a54d4378e6867ea6; xorp/xrl/targets/ospfv2_base.hh From mjh@icir.org Mon Nov 14 20:01:40 2005 From: mjh@icir.org (Mark Handley) Date: Mon, 14 Nov 2005 20:01:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511142001.jAEK1edG042982@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-14 20:01:40 UTC XORP CVS repository Modified files: bgp aspath.cc aspath.hh path_attribute.cc path_attribute.hh plumbing.cc route_table_filter.cc route_table_filter.hh Log message: Add static filters for well known communities: NO_EXPORT, NO_ADVERTISE. Partial support for NO_EXPORT_SUBCONFED. Without these we wouldn't comply with RFC 1997. Fix a bug where we would abort when we got an AS_PATH containing a AS_CONFED_SET or AS_CONFED_SEQUENCE (which aren't yet supported), or any other undefined AS_SEGMENT type. Now we do the right thing, which is to send a Notification, and drop the peering. None of this has test suites yet, but it does pass all the tinderbox tests. Revision Changes Path 1.28 +34 -9; commitid: a7944378ec227ea6; xorp/bgp/aspath.cc 1.22 +15 -10; commitid: a7944378ec227ea6; xorp/bgp/aspath.hh 1.61 +10 -1; commitid: a7944378ec227ea6; xorp/bgp/path_attribute.cc 1.37 +6 -1; commitid: a7944378ec227ea6; xorp/bgp/path_attribute.hh 1.74 +5 -2; commitid: a7944378ec227ea6; xorp/bgp/plumbing.cc 1.37 +63 -1; commitid: a7944378ec227ea6; xorp/bgp/route_table_filter.cc 1.18 +20 -1; commitid: a7944378ec227ea6; xorp/bgp/route_table_filter.hh From atanu@icir.org Mon Nov 14 20:22:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 14 Nov 2005 20:22:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511142022.jAEKMnW9043407@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-14 20:22:49 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh peer_manager.cc Log message: Store the virtual link endpoint information in the area structure for use in the routing computation. Don't allow a virtual link to be configured through a stub or nssa area. Revision Changes Path 1.146 +27 -3; commitid: a9704378f2177ea6; xorp/ospf/area_router.cc 1.84 +2 -1; commitid: a9704378f2177ea6; xorp/ospf/area_router.hh 1.78 +8 -3; commitid: a9704378f2177ea6; xorp/ospf/peer_manager.cc From pavlin@icir.org Tue Nov 15 02:09:48 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 15 Nov 2005 02:09:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511150209.jAF29mZd046717@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-15 02:09:48 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Ignore config nodes from the new tree that are marked as deleted when calculating the deltas between the old and the new configuration. This fixed Bigzilla entry #282 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=282 Revision Changes Path 1.102 +9 -1; commitid: b65f437943017ea6; xorp/rtrmgr/conf_tree_node.cc From atanu@icir.org Tue Nov 15 04:14:57 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 04:14:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511150414.jAF4Ev8p047720@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 04:14:57 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow a virtual link to be configured. Revision Changes Path 1.25 +18 -1; commitid: ba4d437960c07ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Tue Nov 15 04:17:08 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 04:17:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511150417.jAF4H8wH047854@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 04:17:08 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Allow a peer to be created of type virtual link. Revision Changes Path 1.188 +1 -2; commitid: bad3437961437ea6; xorp/ospf/peer.cc From atanu@icir.org Tue Nov 15 04:29:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 04:29:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511150429.jAF4Tnmk048074@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 04:29:49 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Create a peering if the routing computation finds the virtual link endpoint. Revision Changes Path 1.79 +51 -8; commitid: bbad4379643c7ea6; xorp/ospf/peer_manager.cc 1.54 +22 -6; commitid: bbad4379643c7ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Tue Nov 15 09:03:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 09:03:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511150903.jAF935aT051005@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 09:03:05 UTC XORP CVS repository Modified files: ospf policy_varrw.hh Log message: Make the policy tags a reference so that changes to the policy tags are not lost. Import polices should now send modified policy tags through to the RIB. In particular exporting routes into another protocol from OSPF should now work. Bug found by: Andrea Bittau Revision Changes Path 1.5 +2 -3; commitid: c7224379a4487ea6; xorp/ospf/policy_varrw.hh From atanu@icir.org Tue Nov 15 09:12:26 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 09:12:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511150912.jAF9CQYc051238@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 09:12:26 UTC XORP CVS repository Modified files: ospf policy_varrw.hh Log message: Temporarily back out last change. Revision Changes Path 1.6 +2 -2; commitid: c80b4379a6797ea6; xorp/ospf/policy_varrw.hh From mjh@icir.org Tue Nov 15 11:44:05 2005 From: mjh@icir.org (Mark Handley) Date: Tue, 15 Nov 2005 11:44:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/libxorp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511151144.jAFBi5RR053811@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-15 11:44:05 UTC XORP CVS repository Modified files: bgp aspath.cc aspath.hh bgp.cc local_data.hh path_attribute.cc path_attribute.hh peer.cc peer.hh peer_data.cc peer_data.hh peer_handler.hh plumbing.cc rib_ipc_handler.hh route_table_filter.cc route_table_filter.hh test_cache.cc test_decision.cc test_deletion.cc test_dump.cc test_fanout.cc test_filter.cc test_nhlookup.cc test_peer_data.cc test_plumbing.cc test_ribin.cc test_ribout.cc xrl_shell_funcs.sh xrl_target.cc xrl_target.hh etc/templates bgp.tp libxorp asnum.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: Jumbo commit to integrate Tim Griffin's changes for BGP Confederations and BGP Route Reflectors (plus a couple of bug fixes). Pretty much all the code is here, but no test suites, and it's not clear that you can actually configure confederations. All the tinderbox tests succeed though. Revision Changes Path 1.29 +196 -15; commitid: d1724379c93b7ea6; xorp/bgp/aspath.cc 1.23 +28 -5; commitid: d1724379c93b7ea6; xorp/bgp/aspath.hh 1.59 +3 -2; commitid: d1724379c93b7ea6; xorp/bgp/bgp.cc 1.11 +38 -3; commitid: d1724379c93b7ea6; xorp/bgp/local_data.hh 1.62 +138 -2; commitid: d1724379c93b7ea6; xorp/bgp/path_attribute.cc 1.38 +41 -1; commitid: d1724379c93b7ea6; xorp/bgp/path_attribute.hh 1.103 +1 -8; commitid: d1724379c93b7ea6; xorp/bgp/peer.cc 1.28 +2 -2; commitid: d1724379c93b7ea6; xorp/bgp/peer.hh 1.25 +77 -10; commitid: d1724379c93b7ea6; xorp/bgp/peer_data.cc 1.17 +47 -4; commitid: d1724379c93b7ea6; xorp/bgp/peer_data.hh 1.19 +7 -2; commitid: d1724379c93b7ea6; xorp/bgp/peer_handler.hh 1.75 +18 -14; commitid: d1724379c93b7ea6; xorp/bgp/plumbing.cc 1.39 +4 -1; commitid: d1724379c93b7ea6; xorp/bgp/rib_ipc_handler.hh 1.38 +39 -29; commitid: d1724379c93b7ea6; xorp/bgp/route_table_filter.cc 1.19 +18 -12; commitid: d1724379c93b7ea6; xorp/bgp/route_table_filter.hh 1.26 +5 -3; commitid: d1724379c93b7ea6; xorp/bgp/test_cache.cc 1.34 +8 -8; commitid: d1724379c93b7ea6; xorp/bgp/test_decision.cc 1.25 +5 -3; commitid: d1724379c93b7ea6; xorp/bgp/test_deletion.cc 1.48 +7 -7; commitid: d1724379c93b7ea6; xorp/bgp/test_dump.cc 1.28 +7 -4; commitid: d1724379c93b7ea6; xorp/bgp/test_fanout.cc 1.31 +5 -3; commitid: d1724379c93b7ea6; xorp/bgp/test_filter.cc 1.28 +5 -3; commitid: d1724379c93b7ea6; xorp/bgp/test_nhlookup.cc 1.11 +2 -2; commitid: d1724379c93b7ea6; xorp/bgp/test_peer_data.cc 1.17 +9 -7; commitid: d1724379c93b7ea6; xorp/bgp/test_plumbing.cc 1.30 +9 -5; commitid: d1724379c93b7ea6; xorp/bgp/test_ribin.cc 1.27 +5 -5; commitid: d1724379c93b7ea6; xorp/bgp/test_ribout.cc 1.12 +2 -2; commitid: d1724379c93b7ea6; xorp/bgp/xrl_shell_funcs.sh 1.47 +17 -3; commitid: d1724379c93b7ea6; xorp/bgp/xrl_target.cc 1.33 +2 -1; commitid: d1724379c93b7ea6; xorp/bgp/xrl_target.hh 1.64 +7 -2; commitid: d1724379c93b7ea6; xorp/etc/templates/bgp.tp 1.12 +2 -2; commitid: d1724379c93b7ea6; xorp/libxorp/asnum.hh 1.26 +3 -1; commitid: d1724379c93b7ea6; xorp/xrl/interfaces/bgp.xif 1.38 +3 -1; commitid: d1724379c93b7ea6; xorp/xrl/interfaces/bgp_xif.cc 1.37 +4 -1; commitid: d1724379c93b7ea6; xorp/xrl/interfaces/bgp_xif.hh 1.41 +4 -2; commitid: d1724379c93b7ea6; xorp/xrl/targets/bgp.xrls 1.43 +4 -3; commitid: d1724379c93b7ea6; xorp/xrl/targets/bgp_base.cc 1.50 +4 -1; commitid: d1724379c93b7ea6; xorp/xrl/targets/bgp_base.hh From zec@icir.org Tue Nov 15 18:04:29 2005 From: zec@icir.org (Marko Zec) Date: Tue, 15 Nov 2005 18:04:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511151804.jAFI4TNH059846@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-15 18:04:29 UTC XORP CVS repository Added files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: Initial, very spartanic and still incomplete implementation of a BGP aggregation table. Revision Changes Path 1.1 +545 -0 xorp/bgp/route_table_aggregation.cc (new) 1.1 +171 -0 xorp/bgp/route_table_aggregation.hh (new) From zec@icir.org Tue Nov 15 18:07:30 2005 From: zec@icir.org (Marko Zec) Date: Tue, 15 Nov 2005 18:07:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511151807.jAFI7UgR059944@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-15 18:07:30 UTC XORP CVS repository Modified files: bgp Makefile.am Makefile.in plumbing.cc plumbing.hh Log message: Plumb in the new aggregation table before the fanout stage. Plug in / configure static filters to process products of the aggregation process. Revision Changes Path 1.40 +2 -1; commitid: e9db437a23347ea6; xorp/bgp/Makefile.am 1.54 +4 -2; commitid: e9db437a23347ea6; xorp/bgp/Makefile.in 1.76 +17 -9; commitid: e9db437a23347ea6; xorp/bgp/plumbing.cc 1.33 +3 -1; commitid: e9db437a23347ea6; xorp/bgp/plumbing.hh From atanu@icir.org Tue Nov 15 19:26:36 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 15 Nov 2005 19:26:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto Message-ID: <200511151926.jAFJQa33060731@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-15 19:26:36 UTC XORP CVS repository Modified files: libproto spt.hh test_spt.cc Log message: The SPT calculation returns the nexthop to each node that can be reached in the graph. It now also returns the previous node on the path to the node. Required by the virtual link calculation in OSPF. Revision Changes Path 1.10 +15 -6; commitid: ed1e437a366b7ea6; xorp/libproto/spt.hh 1.10 +22 -21; commitid: ed1e437a366b7ea6; xorp/libproto/test_spt.cc From pavlin@icir.org Tue Nov 15 20:16:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 15 Nov 2005 20:16:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511152016.jAFKGI1x061171@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-15 20:16:18 UTC XORP CVS repository Modified files: bgp route_table_aggregation.hh Log message: Comment-out stuff after "#endif" Revision Changes Path 1.2 +2 -2; commitid: eeda437a41ea7ea6; xorp/bgp/route_table_aggregation.hh From atanu@ICSI.Berkeley.EDU Tue Nov 15 20:34:45 2005 From: atanu@ICSI.Berkeley.EDU (Atanu Ghosh) Date: Tue, 15 Nov 2005 12:34:45 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp In-Reply-To: Message from Pavlin Radoslavov of "Tue, 15 Nov 2005 20:16:18 GMT." <200511152016.jAFKGI1x061171@xorpc.icir.org> Message-ID: <2895.1132086885@tigger.icir.org> Hi, The aggregation code does not compile with gcc34. I have sent Marko a patch, I didn't want to commit it while he is working on the code. Atanu. >>>>> "Pavlin" == Pavlin Radoslavov writes: Pavlin> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Pavlin> Changes by: pavlin@xorpc.icir.org 2005-11-15 20:16:18 UTC Pavlin> XORP CVS repository Pavlin> Modified files: bgp route_table_aggregation.hh Pavlin> Log message: Comment-out stuff after "#endif" Pavlin> Revision Changes Path 1.2 +2 -2; commitid: eeda437a41ea7ea6; Pavlin> xorp/bgp/route_table_aggregation.hh Pavlin> _______________________________________________ Xorp-cvs Pavlin> mailing list Xorp-cvs@icir.org Pavlin> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From zec@icir.org Tue Nov 15 22:00:16 2005 From: zec@icir.org (Marko Zec) Date: Tue, 15 Nov 2005 22:00:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511152200.jAFM0GMn061996@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-15 22:00:16 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: Fixes for correct compilation with gcc 3.4. Bug found by: Atanu Submitted by: Atanu Revision Changes Path 1.2 +35 -32; commitid: f1e6437a59f87ea6; xorp/bgp/route_table_aggregation.cc 1.3 +5 -4; commitid: f1e6437a59f87ea6; xorp/bgp/route_table_aggregation.hh From mjh@icir.org Wed Nov 16 00:10:06 2005 From: mjh@icir.org (Mark Handley) Date: Wed, 16 Nov 2005 00:10:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511160010.jAG0A6j4063947@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-16 00:10:06 UTC XORP CVS repository Modified files: bgp test_filter.cc test_filter.reference Log message: Add test for NO_EXPORT community Revision Changes Path 1.32 +52 -1; commitid: f98e437a78cf7ea6; xorp/bgp/test_filter.cc 1.5 +28 -0; commitid: f98e437a78cf7ea6; xorp/bgp/test_filter.reference From zec@icir.org Wed Nov 16 00:39:44 2005 From: zec@icir.org (Marko Zec) Date: Wed, 16 Nov 2005 00:39:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511160039.jAG0dioL064219@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-16 00:39:44 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc Log message: Use a cloning constructor for creating copies of the original routes, instead of a "from scratch" SubnetRoute constructor. Results in more compact sources and hopefully faster code. Revision Changes Path 1.3 +41 -72; commitid: faae437a7e397ea6; xorp/bgp/route_table_aggregation.cc From atanu@icir.org Wed Nov 16 00:51:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 00:51:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160051.jAG0p7s1064370@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 00:51:06 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Helper method to form an IPNet from the components in an LSA. Revision Changes Path 1.76 +15 -1; commitid: fb57437a827a7ea6; xorp/ospf/lsa.hh From atanu@icir.org Wed Nov 16 01:14:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 01:14:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160114.jAG1EIMt064573@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 01:14:18 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Search for virtual link endpoints during the routing computation make an upcall to create a virtual link if a new link is found or make an upcall to delete a link that no longer exists. Revision Changes Path 1.147 +134 -2; commitid: fc20437a87e87ea6; xorp/ospf/area_router.cc 1.85 +30 -2; commitid: fc20437a87e87ea6; xorp/ospf/area_router.hh From atanu@icir.org Wed Nov 16 01:26:08 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 01:26:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160126.jAG1Q8GX064741@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 01:26:08 UTC XORP CVS repository Modified files: ospf external.cc policy_varrw.cc policy_varrw.hh routing_table.cc routing_table.hh Log message: A modified policy tag in the import code should now be propagated through to the RIB. Should allow the exporting of routes from OSPF. Revision Changes Path 1.16 +3 -2; commitid: fcc2437a8aaf7ea6; xorp/ospf/external.cc 1.6 +2 -2; commitid: fcc2437a8aaf7ea6; xorp/ospf/policy_varrw.cc 1.7 +3 -3; commitid: fcc2437a8aaf7ea6; xorp/ospf/policy_varrw.hh 1.29 +2 -2; commitid: fcc2437a8aaf7ea6; xorp/ospf/routing_table.cc 1.28 +2 -2; commitid: fcc2437a8aaf7ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Wed Nov 16 03:05:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 16 Nov 2005 03:05:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511160305.jAG35hmd065815@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-16 03:05:43 UTC XORP CVS repository Modified files: rtrmgr xorpsh_main.cc xorpsh_main.hh Log message: Check for error when sending XRLs when registering/deregistering with the rtrmgr. This fixes a bug when the xorpsh blocks and must be killed by "kill -9" if the rtrmgr is gone (Bugzilla entry #314). Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=314 Revision Changes Path 1.56 +47 -35; commitid: 100e7437aa1aa7ea6; xorp/rtrmgr/xorpsh_main.cc 1.29 +4 -4; commitid: 100e7437aa1aa7ea6; xorp/rtrmgr/xorpsh_main.hh From pavlin@icir.org Wed Nov 16 03:46:35 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 16 Nov 2005 03:46:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511160346.jAG3kZxP066076@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-16 03:46:35 UTC XORP CVS repository Modified files: rtrmgr xorp_client.cc xorp_client.hh xorpsh_main.cc xorpsh_main.hh Log message: Minor refactoring of class XorpShell (now XorpShell inherits from class XrlStdRouter), so it can monitor when the Xrl Finder is gone: if it is gone, then print an error on stderr. Revision Changes Path 1.23 +4 -4; commitid: 101e2437aab347ea6; xorp/rtrmgr/xorp_client.cc 1.18 +3 -3; commitid: 101e2437aab347ea6; xorp/rtrmgr/xorp_client.hh 1.57 +40 -14; commitid: 101e2437aab347ea6; xorp/rtrmgr/xorpsh_main.cc 1.30 +20 -5; commitid: 101e2437aab347ea6; xorp/rtrmgr/xorpsh_main.hh From atanu@icir.org Wed Nov 16 05:20:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 05:20:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160520.jAG5KG26066905@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 05:20:16 UTC XORP CVS repository Modified files: ospf peer.cc peer_manager.cc peer_manager.hh Log message: If a packet arrives on an interface and its area for area 0.0.0.0 but this interface is not associated with area 0.0.0.0 punt the packet back up as its a virtual link candidate. Revision Changes Path 1.189 +8 -5; commitid: 1053a437ac18f7ea6; xorp/ospf/peer.cc 1.80 +12 -1; commitid: 1053a437ac18f7ea6; xorp/ospf/peer_manager.cc 1.55 +7 -1; commitid: 1053a437ac18f7ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Wed Nov 16 05:29:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 05:29:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160529.jAG5Tla7067030@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 05:29:47 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: A route is a candidate for summarisation into other areas if it is of type network or AS boundary router and the path-type is not type1 external or type2 external. The path-type test was not being correctly applied and network routes with type1 external paths were sneaking through, this hole has now been plugged. Revision Changes Path 1.81 +8 -6; commitid: 105bb437ac3ca7ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 07:43:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 07:43:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511160743.jAG7h5fp068150@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 07:43:05 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: A route is a candidate for summarisation into other areas if it is of type network or AS boundary router and the path-type is not type1 external or type2 external. The path-type test was not being correctly applied and network routes with type1 external paths were sneaking through, this hole has now been plugged. Revision Changes Path 1.82 +4 -1; commitid: 10a16437ae3087ea6; xorp/ospf/peer_manager.cc From abittau@icir.org Wed Nov 16 08:35:29 2005 From: abittau@icir.org (Andrea Bittau) Date: Wed, 16 Nov 2005 08:35:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200511160835.jAG8ZTcE068774@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-11-16 08:35:29 UTC XORP CVS repository Modified files: policy filter_manager.cc Log message: Consider route re-distribution from A->B. If A is dead when policy is configured and A comes up later, nothing worked. Now it does. I was feeling left out in the numerous commits ;D Revision Changes Path 1.8 +22 -19; commitid: 10c74437aeefe7ea6; xorp/policy/filter_manager.cc From zec@icir.org Wed Nov 16 09:47:21 2005 From: zec@icir.org (Marko Zec) Date: Wed, 16 Nov 2005 09:47:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511160947.jAG9lLg5069743@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-16 09:47:21 UTC XORP CVS repository Modified files: bgp plumbing.cc Log message: Tinderbox test_routing1.sh -l -t test5 is failing due to a bug in the aggregation path. Temporarily disable aggregation until this issue is resolved. Revision Changes Path 1.77 +14 -1; commitid: 11052437afff97ea6; xorp/bgp/plumbing.cc From zec@icir.org Wed Nov 16 10:13:48 2005 From: zec@icir.org (Marko Zec) Date: Wed, 16 Nov 2005 10:13:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511161013.jAGADmnT070133@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-16 10:13:48 UTC XORP CVS repository Modified files: bgp plumbing.cc route_table_aggregation.cc Log message: replace_route() in aggregation table, after deleting the old route, was announcing the same old route again, instead of the new one. Plumb back in the aggregation table. Revision Changes Path 1.78 +1 -14; commitid: 111bb437b05b27ea6; xorp/bgp/plumbing.cc 1.4 +3 -3; commitid: 111bb437b05b27ea6; xorp/bgp/route_table_aggregation.cc From zec@icir.org Wed Nov 16 11:37:35 2005 From: zec@icir.org (Marko Zec) Date: Wed, 16 Nov 2005 11:37:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511161137.jAGBbZ0L071519@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-16 11:37:34 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: Do not originate the aggregate when component routes have different MED attributes. Mark the component routes accordingly and propagate the marked routes downstream. Revision Changes Path 1.5 +94 -50; commitid: 1172b437b19177ea6; xorp/bgp/route_table_aggregation.cc 1.4 +16 -5; commitid: 1172b437b19177ea6; xorp/bgp/route_table_aggregation.hh From atanu@icir.org Wed Nov 16 11:45:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:45:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161145.jAGBjeIq071662@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:45:39 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Some debugging statements and a correction to the return value from find_interface_address_virtual_link(). Revision Changes Path 1.148 +12 -2; commitid: 117d3437b1bdf7ea6; xorp/ospf/area_router.cc From atanu@icir.org Wed Nov 16 11:47:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:47:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161147.jAGBl1ff071710@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:47:01 UTC XORP CVS repository Modified files: ospf ospf.hh Log message: Define the interface name of a virtual link. Revision Changes Path 1.75 +6 -1; commitid: 11803437b1c347ea6; xorp/ospf/ospf.hh From atanu@icir.org Wed Nov 16 11:49:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:49:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161149.jAGBnFjK071784@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:49:14 UTC XORP CVS repository Modified files: ospf ospf.cc Log message: When an interface is a virtual link return fake prefix length and mtu. Revision Changes Path 1.54 +7 -1; commitid: 1184d437b1cb97ea6; xorp/ospf/ospf.cc From mjh@icir.org Wed Nov 16 11:50:46 2005 From: mjh@icir.org (Mark Handley) Date: Wed, 16 Nov 2005 11:50:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511161150.jAGBokP9071873@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-16 11:50:46 UTC XORP CVS repository Modified files: bgp route_table_filter.cc route_table_filter.hh test_filter.cc test_filter.reference Log message: Add test of static filter versioning. This revealed that the previous test_filter code was buggy, but the bug wasn't being noticed by the FilterTable. Make the FilterTable more paranoid, so GenID bugs elsewhere in the code will now show up as a FilterTable assert. Revision Changes Path 1.39 +21 -6; commitid: 11849437b1c847ea6; xorp/bgp/route_table_filter.cc 1.20 +7 -1; commitid: 11849437b1c847ea6; xorp/bgp/route_table_filter.hh 1.33 +73 -24; commitid: 11849437b1c847ea6; xorp/bgp/test_filter.cc 1.6 +46 -0; commitid: 11849437b1c847ea6; xorp/bgp/test_filter.reference From atanu@icir.org Wed Nov 16 11:52:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:52:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161152.jAGBqtvj071909@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:52:54 UTC XORP CVS repository Modified files: ospf vlink.cc vlink.hh Log message: Provide the mapping from virtual links to physical interfaces. Also provide a generator method to return the virtual interface and vif names. Revision Changes Path 1.2 +96 -1; commitid: 118c8437b1d957ea6; xorp/ospf/vlink.cc 1.2 +52 -1; commitid: 118c8437b1d957ea6; xorp/ospf/vlink.hh From atanu@icir.org Wed Nov 16 11:55:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:55:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161155.jAGBtL7s072029@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:55:21 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: Virtual link support. Revision Changes Path 1.190 +19 -9; commitid: 11940437b1e277ea6; xorp/ospf/peer.cc 1.109 +14 -1; commitid: 11940437b1e277ea6; xorp/ospf/peer.hh From atanu@icir.org Wed Nov 16 11:58:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 11:58:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161158.jAGBwc26072103@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 11:58:37 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Packets transmitted by the peers are now re-directed through here so that the virtual interface and vif state can be substitued for physical interfaces and vifs. Revision Changes Path 1.83 +58 -5; commitid: 1198a437b1eec7ea6; xorp/ospf/peer_manager.cc 1.56 +8 -1; commitid: 1198a437b1eec7ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Wed Nov 16 18:52:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 18:52:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161852.jAGIq0ru078322@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 18:52:00 UTC XORP CVS repository Modified files: ospf trace.hh Log message: Add a trace variable for virtual links. Revision Changes Path 1.9 +6 -3; commitid: 131d7437b7fcf7ea6; xorp/ospf/trace.hh From atanu@icir.org Wed Nov 16 18:56:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 18:56:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161856.jAGIu0vn078453@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 18:56:00 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: When a peer is deleted notify the peer first then the area router. Previously the area router was notifed first and removed all state, then the peer would send a peer down to the area router for which it had no state. Tidy up the virtual link code and add some tracing. Revision Changes Path 1.84 +42 -13; commitid: 1325a437b80c07ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 19:00:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 19:00:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511161900.jAGJ0qGP078573@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 19:00:52 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: When deleting an interface the template variables were being sent. Adding $() seems to have solved the problem Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=320 Revision Changes Path 1.26 +2 -2; commitid: 132d2437b81e47ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Wed Nov 16 19:34:32 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 19:34:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511161934.jAGJYWkN079204@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 19:34:32 UTC XORP CVS repository Modified files: ospf vlink.cc vlink.hh Log message: Methods the return the stored PeerIDs. Revision Changes Path 1.3 +32 -1; commitid: 13547437b89c87ea6; xorp/ospf/vlink.cc 1.3 +12 -1; commitid: 13547437b89c87ea6; xorp/ospf/vlink.hh From atanu@icir.org Wed Nov 16 20:07:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 20:07:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162007.jAGK7VeD079667@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 20:07:31 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: When the configuration for a virtual link is removed notify the area that the virtual link goes through. Revision Changes Path 1.85 +17 -1; commitid: 13718437b91827ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 20:16:34 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 20:16:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162016.jAGKGYhC079930@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 20:16:34 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: If a virtual link is added or removed force a routing recomputation. Added some virtual link trace points. Revision Changes Path 1.149 +20 -9; commitid: 1381f437b93a07ea6; xorp/ospf/area_router.cc From atanu@icir.org Wed Nov 16 20:22:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 20:22:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162022.jAGKM7lh080076@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 20:22:07 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Invalidate the PeerID even though we are about to delete it. It is possible that the area router may still make an upcall. Revision Changes Path 1.86 +7 -1; commitid: 138b1437b94ee7ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 20:43:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 20:43:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162043.jAGKhIIg080357@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 20:43:17 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh peer_manager.cc Log message: On a virtual link the hello packet is supposed to have its mask field set to zero. Slight refactoring to allow a prefix lengh of zero to flow through the system, previously a prefix length of zero signified an error. Added a constant VLINK_MTU. Revision Changes Path 1.55 +10 -7; commitid: 139c6437b99e47ea6; xorp/ospf/ospf.cc 1.76 +8 -3; commitid: 139c6437b99e47ea6; xorp/ospf/ospf.hh 1.87 +3 -3; commitid: 139c6437b99e47ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 22:35:39 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 22:35:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162235.jAGMZdPg081487@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 22:35:39 UTC XORP CVS repository Modified files: ospf peer_manager.cc vlink.cc vlink.hh Log message: A virtual link is configured in area 0.0.0.0 but refers to a transit area. Depending on the order of the area statements in the configuration file a virtual area may be configured through an area before ospf has any knowledge of this area. On area creation and deletion check to see if virtual links should be installed in the new areas. An area being deleted and then being put back should also work correctly. The relevant methods in Vlink have all been made const. Revision Changes Path 1.88 +40 -12; commitid: 13e30437bb43a7ea6; xorp/ospf/peer_manager.cc 1.4 +71 -9; commitid: 13e30437bb43a7ea6; xorp/ospf/vlink.cc 1.4 +34 -7; commitid: 13e30437bb43a7ea6; xorp/ospf/vlink.hh From atanu@icir.org Wed Nov 16 23:08:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 23:08:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162308.jAGN8NLD081810@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 23:08:23 UTC XORP CVS repository Modified files: ospf vlink.cc Log message: Use the peer's router ID for the vif name. Should make it easier to directly configure the parameters from the template file. Revision Changes Path 1.5 +2 -2; commitid: 13f77437bbbe67ea6; xorp/ospf/vlink.cc From atanu@icir.org Wed Nov 16 23:29:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 23:29:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162329.jAGNTM4Z082102@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 23:29:22 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Accept packets on peers that have been configured as virtual links. Revision Changes Path 1.191 +1 -5; commitid: 1409b437bc0d17ea6; xorp/ospf/peer.cc From pavlin@icir.org Wed Nov 16 23:32:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 16 Nov 2005 23:32:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511162332.jAGNWB4h082174@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-16 23:32:11 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh slave_conf_tree.cc xorpsh_base.hh xorpsh_main.cc xorpsh_main.hh Log message: Always test inside xorpsh whether the sending of an XRL succeeds, and propagate the error properly. This should fix all cases of the xorpsh being blocked if the rtrmgr is gone. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=314 Revision Changes Path 1.108 +79 -20; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/cli.cc 1.41 +2 -2; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/cli.hh 1.33 +70 -15; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/slave_conf_tree.cc 1.2 +10 -10; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/xorpsh_base.hh 1.58 +74 -32; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/xorpsh_main.cc 1.31 +15 -12; commitid: 14097437bc0bc7ea6; xorp/rtrmgr/xorpsh_main.hh From atanu@icir.org Wed Nov 16 23:40:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 23:40:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162340.jAGNefed082287@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 23:40:41 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Feed packets that are virtual link candidates into the virtual links. Revision Changes Path 1.89 +7 -1; commitid: 14154437bc3787ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Nov 16 23:55:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 16 Nov 2005 23:55:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511162355.jAGNtwA8082472@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-16 23:55:58 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Missing newline in a debug_msg. Revision Changes Path 1.90 +2 -2; commitid: 1420d437bc70d7ea6; xorp/ospf/peer_manager.cc From pavlin@icir.org Thu Nov 17 08:25:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 17 Nov 2005 08:25:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511170825.jAH8PYEC086645@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-17 08:25:34 UTC XORP CVS repository Modified files: rtrmgr template.yy y.tplt_tab.cc Log message: Extend the template grammar to allow more than one "%foo" command on the same line. E.g., previously the syntax was strictly only: %foo: a b c; %bar: d e f; Now we allow the %bar command to be used as an attribute for %foo with syntax like: %foo: a b c %bar: d e f; Revision Changes Path 1.19 +6 -0; commitid: 1522e437c3da37ea6; xorp/rtrmgr/template.yy 1.26 +84 -68; commitid: 1522e437c3da37ea6; xorp/rtrmgr/y.tplt_tab.cc From pavlin@icir.org Thu Nov 17 08:31:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 17 Nov 2005 08:31:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/rtrmgr xorp/docs/rtrmgr Message-ID: <200511170831.jAH8Vvif086882@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-17 08:31:57 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp rip.tp ripng.tp rtrmgr template_base_command.cc template_base_command.hh docs/rtrmgr rtrmgr.tex Log message: * Modify the "%allow" syntax so now we can provide help string for each allowed value: OLD: %allow: $(@) "one" "two" "three"; NEW: %allow: $(@) "one" %help: "This is help for one"; %allow: $(@) "two" %help: "This is help for two"; %allow: $(@) "three" %help: "This is help for three"; * Minor variable renaming. Revision Changes Path 1.44 +18 -11; commitid: 152db437c3f6b7ea6; xorp/docs/rtrmgr/rtrmgr.tex 1.27 +11 -6; commitid: 152db437c3f6b7ea6; xorp/etc/templates/ospfv2.tp 1.27 +7 -3; commitid: 152db437c3f6b7ea6; xorp/etc/templates/rip.tp 1.26 +4 -2; commitid: 152db437c3f6b7ea6; xorp/etc/templates/ripng.tp 1.11 +111 -71; commitid: 152db437c3f6b7ea6; xorp/rtrmgr/template_base_command.cc 1.6 +10 -10; commitid: 152db437c3f6b7ea6; xorp/rtrmgr/template_base_command.hh From atanu@icir.org Thu Nov 17 16:53:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 16:53:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511171653.jAHGrju2094987@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 16:53:45 UTC XORP CVS repository Modified files: bgp Makefile.am Makefile.in Log message: Add route_table_aggregation.cc may have been causing compilation problems. Bug found by: Michael Larson Revision Changes Path 1.41 +2 -1; commitid: 172ee437cb5987ea6; xorp/bgp/Makefile.am 1.55 +4 -3; commitid: 172ee437cb5987ea6; xorp/bgp/Makefile.in From atanu@icir.org Thu Nov 17 17:13:33 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 17:13:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511171713.jAHHDXAN095335@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 17:13:33 UTC XORP CVS repository Modified files: ospf peer.cc Log message: When sending a data description packet on a virtual link set the MTU to 0. Revision Changes Path 1.192 +6 -1; commitid: 1744c437cba3c7ea6; xorp/ospf/peer.cc From atanu@icir.org Thu Nov 17 17:41:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 17:41:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511171741.jAHHfNl6095722@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 17:41:23 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: Stop the sending of AS-External-LSAs on virtual links. Shuffle the header and source files so send_lsa and queue_lsa are next to each other. Revision Changes Path 1.193 +78 -54; commitid: 175c9437cc0c27ea6; xorp/ospf/peer.cc 1.110 +42 -35; commitid: 175c9437cc0c27ea6; xorp/ospf/peer.hh From atanu@icir.org Thu Nov 17 17:43:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 17:43:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511171743.jAHHhwv4095819@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 17:43:58 UTC XORP CVS repository Modified files: ospf xrl_io.cc Log message: Remove the unconditional enabling of debugging. Revision Changes Path 1.26 +1 -8; commitid: 17630437cc15d7ea6; xorp/ospf/xrl_io.cc From atanu@icir.org Thu Nov 17 17:45:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 17:45:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511171745.jAHHjqQS095951@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 17:45:52 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: Add some additional debugging. Revision Changes Path 1.30 +11 -6; commitid: 176b4437cc1cf7ea6; xorp/ospf/routing_table.cc From atanu@icir.org Thu Nov 17 17:47:51 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 17 Nov 2005 17:47:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511171747.jAHHlpep096039@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-17 17:47:51 UTC XORP CVS repository Modified files: ospf xorp_ospfv2.cc Log message: NOOP. +// xlog_level_set_verbose(XLOG_LEVEL_TRACE, XLOG_VERBOSE_HIGH); Revision Changes Path 1.10 +2 -1; commitid: 1770c437cc2467ea6; xorp/ospf/xorp_ospfv2.cc From pavlin@icir.org Fri Nov 18 00:22:58 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 18 Nov 2005 00:22:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr xorp/rtrmgr xorp/etc/templates Message-ID: <200511180022.jAI0Mwk8004479@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-18 00:22:58 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex rtrmgr template_base_command.cc etc/templates bgp.tp fea.tp igmp.tp interfaces.tp mld.tp ospfv2.tp pimsm4.tp pimsm6.tp rip.tp ripng.tp static_routes.tp Log message: * Modify the "%allow-range" syntax so now we can provide help string for each allowed range (for consistency with the new %allow syntax): OLD: %allow-range: $(@) "1" "100"; NEW: %allow-range: $(@) "1" "100" %help: "This is a help string"; Currently the help string is not used, but it may be used in the future for command-line completion purpose. * Fixed minor typos in some of the pimsm4.tp and pimsm6.tp help strings. Revision Changes Path 1.45 +6 -3; commitid: 1102437d1e127ea6; xorp/docs/rtrmgr/rtrmgr.tex 1.65 +3 -3; commitid: 1102437d1e127ea6; xorp/etc/templates/bgp.tp 1.33 +2 -2; commitid: 1102437d1e127ea6; xorp/etc/templates/fea.tp 1.16 +6 -6; commitid: 1102437d1e127ea6; xorp/etc/templates/igmp.tp 1.23 +4 -4; commitid: 1102437d1e127ea6; xorp/etc/templates/interfaces.tp 1.16 +6 -6; commitid: 1102437d1e127ea6; xorp/etc/templates/mld.tp 1.28 +6 -6; commitid: 1102437d1e127ea6; xorp/etc/templates/ospfv2.tp 1.28 +13 -13; commitid: 1102437d1e127ea6; xorp/etc/templates/pimsm4.tp 1.28 +12 -12; commitid: 1102437d1e127ea6; xorp/etc/templates/pimsm6.tp 1.28 +2 -2; commitid: 1102437d1e127ea6; xorp/etc/templates/rip.tp 1.27 +2 -2; commitid: 1102437d1e127ea6; xorp/etc/templates/ripng.tp 1.28 +9 -9; commitid: 1102437d1e127ea6; xorp/etc/templates/static_routes.tp 1.12 +50 -17; commitid: 1102437d1e127ea6; xorp/rtrmgr/template_base_command.cc From pavlin@icir.org Fri Nov 18 00:47:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 18 Nov 2005 00:47:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes Message-ID: <200511180047.jAI0lUEE004712@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-18 00:47:30 UTC XORP CVS repository Modified files: devnotes routing-refs.txt Log message: Remove a note about the publication date of a book, because it has been published already. Revision Changes Path 1.3 +0 -1; commitid: 124f437d24647ea6; xorp/devnotes/routing-refs.txt From zec@icir.org Fri Nov 18 01:56:43 2005 From: zec@icir.org (Marko Zec) Date: Fri, 18 Nov 2005 01:56:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511180156.jAI1uhqd005315@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-18 01:56:43 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: When originating an aggregate route set the filter generation id of the aggregate to the genid value obtained from the first component route that triggered the generation of this aggregate. Required for proper operation of export filters. This can be safe if and only if all the existing routes are deleted prior to installation of new version of the policy filters. In other words, my assumption is that it shouldn't ever be possible to see two component routes in the aggregation table with two different filter genids at the same time. Correct / wrong? Revision Changes Path 1.6 +5 -4; commitid: 1469437d32407ea6; xorp/bgp/route_table_aggregation.cc 1.5 +11 -6; commitid: 1469437d32407ea6; xorp/bgp/route_table_aggregation.hh From zec@icir.org Fri Nov 18 01:59:20 2005 From: zec@icir.org (Marko Zec) Date: Fri, 18 Nov 2005 01:59:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511180159.jAI1xKXi005371@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-18 01:59:20 UTC XORP CVS repository Modified files: bgp bgp.hh Log message: Remove redundant method from BGPMain for obtaining RibIpcHandler *, because equivalent method is already available in BGPPlumbming. Revision Changes Path 1.49 +1 -2; commitid: 14d1437d34f27ea6; xorp/bgp/bgp.hh From atanu@icir.org Fri Nov 18 03:42:10 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 03:42:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511180342.jAI3gAtu006293@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 03:42:10 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: If a virtual link endpoint goes away record this fact so the peer manager can be notified when it comes back up. Revision Changes Path 1.150 +6 -2; commitid: 187a437d4d917ea6; xorp/ospf/area_router.cc From atanu@icir.org Fri Nov 18 04:23:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 04:23:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511180423.jAI4Nkrg006771@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 04:23:46 UTC XORP CVS repository Modified files: ospf peer_manager.hh routing_table.cc Log message: Move the code around so that all the configuration methods are together. Revision Changes Path 1.57 +57 -53; commitid: 1a56437d57527ea6; xorp/ospf/peer_manager.hh 1.31 +3 -3; commitid: 1a56437d57527ea6; xorp/ospf/routing_table.cc From atanu@icir.org Fri Nov 18 06:09:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 06:09:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511180609.jAI69ffq007778@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 06:09:41 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Move the code around so that all the configuration methods are together. Revision Changes Path 1.91 +76 -75; commitid: 1e47437d70247ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Fri Nov 18 06:11:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 06:11:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511180611.jAI6BTLo007894@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 06:11:29 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: Backout accidental commit. Revision Changes Path 1.32 +3 -3; commitid: 1ebb437d70917ea6; xorp/ospf/routing_table.cc From atanu@icir.org Fri Nov 18 06:16:26 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 06:16:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511180616.jAI6GQ8S008062@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 06:16:25 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: When putting a Router-LSA into the routing table extract its interface address from its adjacent router links don't use its router ID. Rename find_interface_address_virtual_link() to find_interface_address() as this method seems to have generic use. Revision Changes Path 1.151 +11 -13; commitid: 1f61437d71b97ea6; xorp/ospf/area_router.cc 1.86 +3 -3; commitid: 1f61437d71b97ea6; xorp/ospf/area_router.hh From pavlin@icir.org Fri Nov 18 08:44:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 18 Nov 2005 08:44:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200511180844.jAI8iBqJ009268@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-18 08:44:11 UTC XORP CVS repository Modified files: libxorp heap.cc Log message: Get rid of deprecated C++ feature: OLD: char *blanks=""; NEW: const char *blanks=""; Bug found by: Mark Doll Revision Changes Path 1.16 +2 -2; commitid: 241b437d93fb7ea6; xorp/libxorp/heap.cc From atanu@icir.org Fri Nov 18 19:38:24 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 19:38:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511181938.jAIJcO17019609@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 19:38:24 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: OSFP requires host routes in its internal routing table but it should send them to the RIB. The test for detecting host routes was incorrect. Revision Changes Path 1.33 +2 -2; commitid: 4c7e437e2dae7ea6; xorp/ospf/routing_table.cc From atanu@ICSI.Berkeley.EDU Fri Nov 18 19:41:16 2005 From: atanu@ICSI.Berkeley.EDU (Atanu Ghosh) Date: Fri, 18 Nov 2005 11:41:16 -0800 Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf In-Reply-To: Message from Atanu Ghosh of "Fri, 18 Nov 2005 19:38:24 GMT." <200511181938.jAIJcO17019609@xorpc.icir.org> Message-ID: <46349.1132342876@tigger.icir.org> The text should be should *not* send to RIB. Atanu. >>>>> "Atanu" == Atanu Ghosh writes: Atanu> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes Atanu> by: atanu@xorpc.icir.org 2005-11-18 19:38:24 UTC Atanu> XORP CVS repository Atanu> Modified files: ospf routing_table.cc Atanu> Log message: OSFP requires host routes in its internal Atanu> routing table but it should send them to the RIB. The test Atanu> for detecting host routes was incorrect. Atanu> Revision Changes Path 1.33 +2 -2; commitid: 4c7e437e2dae7ea6; Atanu> xorp/ospf/routing_table.cc Atanu> _______________________________________________ Xorp-cvs Atanu> mailing list Xorp-cvs@icir.org Atanu> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From atanu@icir.org Fri Nov 18 19:59:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 19:59:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511181959.jAIJxsHS019851@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 19:59:54 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Given a destination Router-LSA and a source Router-LSA or Network-LSA the method find_interface_address() finds the router link that connects the two LSAs. The is an edge condition that two adjacent Router-LSAs may be connected via a virtual link, consider a transit area with only two routers border routers. Therefore add a check for virtual links. Revision Changes Path 1.152 +15 -5; commitid: 4d70437e32b97ea6; xorp/ospf/area_router.cc From atanu@icir.org Fri Nov 18 20:19:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 18 Nov 2005 20:19:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511182019.jAIKJG8L020110@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-18 20:19:16 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: When deleting a route that was previously filtered don't return an error. Revision Changes Path 1.34 +5 -3; commitid: 4e73437e37447ea6; xorp/ospf/routing_table.cc From atanu@icir.org Sat Nov 19 03:35:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 03:35:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190335.jAJ3ZJ1d023910@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 03:35:19 UTC XORP CVS repository Modified files: ospf lsa.cc Log message: Correction when printing a type 2 router link the link ID field is the IP address of the designated routers not its router ID. Revision Changes Path 1.62 +2 -2; commitid: 5d4b437e9d767ea6; xorp/ospf/lsa.cc From atanu@icir.org Sat Nov 19 03:48:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 03:48:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190348.jAJ3mJgV024125@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 03:48:19 UTC XORP CVS repository Modified files: ospf area_router.cc trace.hh Log message: Add a new trace variable _find_interface_address. Revision Changes Path 1.153 +3 -3; commitid: 5e20437ea0827ea6; xorp/ospf/area_router.cc 1.10 +6 -3; commitid: 5e20437ea0827ea6; xorp/ospf/trace.hh From atanu@icir.org Sat Nov 19 04:06:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 04:06:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190406.jAJ46ctY024306@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 04:06:38 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When looking for the interface address consider two Router-LSAs that share a common network. Revision Changes Path 1.154 +31 -1; commitid: 5ed7437ea4cd7ea6; xorp/ospf/area_router.cc From atanu@icir.org Sat Nov 19 05:38:18 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 05:38:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190538.jAJ5cIN3025278@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 05:38:18 UTC XORP CVS repository Modified files: ospf peer.cc Log message: The list of neighbours carried in a Network-LSA is a list of Router IDs not the router interface addresses. Revision Changes Path 1.194 +2 -2; commitid: 62a3437eba497ea6; xorp/ospf/peer.cc From atanu@icir.org Sat Nov 19 05:50:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 05:50:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190550.jAJ5ogvC025474@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 05:50:42 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: The bidirectional test for router link to Network-LSA was incorrect. The router ID of the Router-LSA should be compared with the attached routers in the Network-LSA. The IP address of the designated router was being compared with the attached routers in the Network-LSA, which almost works if the interface address and Router IDs match. Revision Changes Path 1.155 +7 -5; commitid: 6365437ebd307ea6; xorp/ospf/area_router.cc 1.87 +3 -2; commitid: 6365437ebd307ea6; xorp/ospf/area_router.hh From atanu@icir.org Sat Nov 19 05:59:56 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 19 Nov 2005 05:59:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511190559.jAJ5xu2w025759@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-19 05:59:56 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Additional debugging. Revision Changes Path 1.92 +8 -3; commitid: 6484437ebf5b7ea6; xorp/ospf/peer_manager.cc From zec@icir.org Sat Nov 19 09:33:40 2005 From: zec@icir.org (Marko Zec) Date: Sat, 19 Nov 2005 09:33:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511190933.jAJ9XeJO027744@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-19 09:33:39 UTC XORP CVS repository Modified files: bgp route_table_filter.cc Log message: Temporarily comment out a recently introduced filter versioning assert which was breaking peering regression tests and more. Approved by: Atanu Revision Changes Path 1.40 +3 -1; commitid: 6c47437ef1017ea6; xorp/bgp/route_table_filter.cc From zec@icir.org Sat Nov 19 09:36:02 2005 From: zec@icir.org (Marko Zec) Date: Sat, 19 Nov 2005 09:36:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511190936.jAJ9a22f027805@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-19 09:36:02 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: Back out recently introduced and completely bogus and wrong genid state keeping in aggregation routes. Revision Changes Path 1.7 +3 -4; commitid: 6c68437ef18a7ea6; xorp/bgp/route_table_aggregation.cc 1.6 +2 -4; commitid: 6c68437ef18a7ea6; xorp/bgp/route_table_aggregation.hh From zec@icir.org Sun Nov 20 16:24:26 2005 From: zec@icir.org (Marko Zec) Date: Sun, 20 Nov 2005 16:24:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511201624.jAKGOQnI044867@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-20 16:24:26 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc route_table_aggregation.hh Log message: Add route_dump() method to AggregationTable. Necessary for proper dumping of routes marked as candidates for aggregation. Note that this does not yet provide the machinery for dumping the localy originated aggregate routes. Revision Changes Path 1.8 +94 -6; commitid: af224380a2b27ea6; xorp/bgp/route_table_aggregation.cc 1.7 +6 -1; commitid: af224380a2b27ea6; xorp/bgp/route_table_aggregation.hh From atanu@icir.org Sun Nov 20 19:16:30 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 19:16:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511201916.jAKJGUqU046439@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 19:16:30 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: OSPF no longer sends host routes through to the RIB, therefore host routes to loopback interfaces are also not being sent to the RIB. Temporarily comment out the test for loopback interfaces. Revision Changes Path 1.11 +2 -2; commitid: b54c4380cb8d7ea6; xorp/ospf/test_routing.cc From atanu@icir.org Sun Nov 20 20:33:53 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 20:33:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202033.jAKKXrm0047053@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 20:33:53 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Remove extra newlines from debugging messages. Revision Changes Path 1.93 +3 -3; commitid: b7b24380ddb07ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Sun Nov 20 21:11:26 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 21:11:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202111.jAKLBQ0g047383@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 21:11:26 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: The OSPF routing table contains routers, routes to these routers should not be sent to the RIB. The correct test for these routes is to see if they belong to routers. Previously host routes were filtered out which is incorrect and was also causing loopback routes to be dropped. When deleting a non-filtered route the summary was not being withdrawn. Add some debugging. Revision Changes Path 1.35 +16 -9; commitid: b8fc4380e67d7ea6; xorp/ospf/routing_table.cc From atanu@icir.org Sun Nov 20 21:13:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 21:13:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202113.jAKLDNK1047437@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 21:13:23 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: Enable test r2 (routing2) also correct the contents of the Network-LSA that should contain a list of router IDs not interface addresses. Revision Changes Path 1.12 +6 -6; commitid: b9324380e6f27ea6; xorp/ospf/test_routing.cc From atanu@icir.org Sun Nov 20 22:58:03 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 22:58:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202258.jAKMw3Va048552@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 22:58:03 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: When storing a routing table entry store it indexed by advertising router as well as by network. Revision Changes Path 1.36 +84 -5; commitid: bd8b4380ff797ea6; xorp/ospf/routing_table.cc 1.29 +63 -7; commitid: bd8b4380ff797ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sun Nov 20 23:09:36 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 23:09:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202309.jAKN9aaF048711@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 23:09:36 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: printf -> debug_msg. Revision Changes Path 1.37 +4 -4; commitid: be2c438102307ea6; xorp/ospf/routing_table.cc From atanu@icir.org Sun Nov 20 23:28:10 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 23:28:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202328.jAKNSA83048950@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 23:28:10 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: When storing the routes indexed by advertising router only consider the Router-LSAs. Revision Changes Path 1.38 +6 -5; commitid: bf1b438106897ea6; xorp/ospf/routing_table.cc From atanu@icir.org Sun Nov 20 23:30:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 23:30:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202330.jAKNUtTI049021@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 23:30:55 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Store the LSA along with the route. When performing the routing computation for AS External routes lookup by advertising router not interface address. Revision Changes Path 1.156 +3 -2; commitid: bf614381072e7ea6; xorp/ospf/area_router.cc From atanu@icir.org Sun Nov 20 23:42:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 20 Nov 2005 23:42:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511202342.jAKNgkRl049174@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-20 23:42:46 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: No longer consider multiple Router-LSAs originated by the same router a fatal error, just print a warning. In OSPFv3 multiple Router-LSAs from one router is legal. Revision Changes Path 1.39 +11 -2; commitid: bffb438109f57ea6; xorp/ospf/routing_table.cc From mjh@icir.org Sun Nov 20 23:55:15 2005 From: mjh@icir.org (Mark Handley) Date: Sun, 20 Nov 2005 23:55:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511202355.jAKNtFWV049351@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-11-20 23:55:15 UTC XORP CVS repository Modified files: bgp plumbing.cc route_table_filter.cc route_table_filter.hh test_filter.cc Log message: Remove versioning in outgoing static filter table - this isn't needed and didn't work right. Versioning is still needed in the incoming static filter table. Revision Changes Path 1.79 +3 -1; commitid: c09443810cab7ea6; xorp/bgp/plumbing.cc 1.41 +29 -26; commitid: c09443810cab7ea6; xorp/bgp/route_table_filter.cc 1.21 +4 -1; commitid: c09443810cab7ea6; xorp/bgp/route_table_filter.hh 1.34 +2 -1; commitid: c09443810cab7ea6; xorp/bgp/test_filter.cc From atanu@icir.org Mon Nov 21 01:16:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 01:16:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511210116.jAL1GwXZ050123@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 01:16:58 UTC XORP CVS repository Modified files: ospf ospf.cc trace.hh Log message: New trace point for routes being sent to the RIB. Revision Changes Path 1.56 +19 -6; commitid: c3ae4381200a7ea6; xorp/ospf/ospf.cc 1.11 +5 -3; commitid: c3ae4381200a7ea6; xorp/ospf/trace.hh From atanu@icir.org Mon Nov 21 01:17:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 01:17:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511210117.jAL1Hqer050178@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 01:17:52 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When generating a Network-LSA introduce the routers own router ID, not its interface address. Revision Changes Path 1.157 +2 -2; commitid: c3e74381203f7ea6; xorp/ospf/area_router.cc From zec@icir.org Mon Nov 21 17:36:36 2005 From: zec@icir.org (Marko Zec) Date: Mon, 21 Nov 2005 17:36:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511211736.jALHaamp061329@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-21 17:36:36 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc Log message: Don't set the changed flag on messages associated with routes for which we keep state in the aggregation table, i.e. for both the component and aggregate routes. Revision Changes Path 1.9 +2 -8; commitid: ef634382052c7ea6; xorp/bgp/route_table_aggregation.cc From atanu@icir.org Mon Nov 21 18:19:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 18:19:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511211819.jALIJGhx061846@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 18:19:16 UTC XORP CVS repository Modified files: ospf trace.hh Log message: Add comment to routes trace variable. Revision Changes Path 1.12 +2 -2; commitid: f17b43820fa37ea6; xorp/ospf/trace.hh From atanu@icir.org Mon Nov 21 18:30:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 18:30:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511211830.jALIUeBt062085@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 18:30:40 UTC XORP CVS repository Modified files: ospf external.cc Log message: When exporting routes from other protocols make the metric in the AS-External-LSA Type 2 by default. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=368 Revision Changes Path 1.17 +2 -2; commitid: f26a4382124f7ea6; xorp/ospf/external.cc From atanu@icir.org Mon Nov 21 18:44:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 18:44:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511211844.jALIilFN062541@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 18:44:47 UTC XORP CVS repository Modified files: etc/templates ospfv2.cmds Log message: The show commands now support type-7-LSAs (NSSA). Bugzilla URL: http://www.xorp.org/bugzilla/process_bug.cgi Revision Changes Path 1.6 +53 -1; commitid: f4324382159f7ea6; xorp/etc/templates/ospfv2.cmds From atanu@icir.org Mon Nov 21 18:56:37 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 21 Nov 2005 18:56:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511211856.jALIub0c062714@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-21 18:56:37 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: Test function submitted by Hasso Tepper to demonstrate that routes could be installed from dead LSAs. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=359 Revision Changes Path 1.13 +109 -1; commitid: f4df438218657ea6; xorp/ospf/test_routing.cc From zec@icir.org Mon Nov 21 23:55:07 2005 From: zec@icir.org (Marko Zec) Date: Mon, 21 Nov 2005 23:55:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511212355.jALNt73u065182@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-21 23:55:07 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: A temporary hack for testing whether a route was aggregated or not. Revision Changes Path 1.66 +8 -1; commitid: fe7643825d2f7ea6; xorp/etc/templates/bgp.tp From pavlin@icir.org Tue Nov 22 02:36:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 22 Nov 2005 02:36:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511220236.jAM2a08F066924@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-22 02:36:00 UTC XORP CVS repository Modified files: ospf policy_varrw.cc Log message: Initialize the metric and tag policy variables as ElemU32 instead of ElemInt32. The reason they have to be ElemU32 is probably because in the ospf policy template they are defined as u32range, and u32range is implemented by using ElemU32. This fixes an OSPF coredump problem when attempting to put the metric or tag in the "from" or "to" policy statements: [ 2005/11/21 17:53:40 TRACE xorp_ospfv2 OSPF ] [OSPF] Running filter: Export on route: 10.30.10.0/24 [ 2005/11/21 17:53:40 FATAL xorp_ospfv2:25048 POLICY +90 dispatcher.cc run ] Assertion (funct.bin) failed Revision Changes Path 1.7 +5 -5; commitid: 1050d438282e17ea6; xorp/ospf/policy_varrw.cc From zec@icir.org Tue Nov 22 13:25:55 2005 From: zec@icir.org (Marko Zec) Date: Tue, 22 Nov 2005 13:25:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511221325.jAMDPtNU073506@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-22 13:25:55 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc Log message: Remove numerous redundant / multiple calls to SubnetRoute unref(). Revision Changes Path 1.10 +1 -6; commitid: 11ef043831c147ea6; xorp/bgp/route_table_aggregation.cc From bms@icir.org Tue Nov 22 14:11:28 2005 From: bms@icir.org (Bruce Simpson) Date: Tue, 22 Nov 2005 14:11:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200511221411.jAMEBSJd074060@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-11-22 14:11:28 UTC XORP CVS repository Added files: libcomm test_connect.cc Log message: Add a regression test for non-blocking connect(), but do not add it to the build. Requested by: atanu (some time ago) Revision Changes Path 1.1 +210 -0 xorp/libcomm/test_connect.cc (new) From atanu@icir.org Tue Nov 22 18:50:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 22 Nov 2005 18:50:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511221850.jAMIoL88079849@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-22 18:50:21 UTC XORP CVS repository Modified files: bgp rib_ipc_handler.cc Log message: Don't print a warning message if the XRL subsystem doesn't accept an add or delete route. Revision Changes Path 1.69 +13 -13; commitid: 137ce4383686d7ea6; xorp/bgp/rib_ipc_handler.cc From atanu@icir.org Tue Nov 22 23:19:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 22 Nov 2005 23:19:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511222319.jAMNJFLY082693@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-22 23:19:15 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Add a copy constructor and an assignment operator to the internal routing table entry. The internal routing table entry can potentially store an entry for every area. The entry stores a pointer to the winning entry which was not being updated when the entry was copied. The failure mode was that bogus routes could be introduced or deleted. Revision Changes Path 1.30 +18 -1; commitid: 142ea4383a7727ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Wed Nov 23 03:13:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 23 Nov 2005 03:13:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200511230313.jAN3DfPl084833@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-23 03:13:41 UTC XORP CVS repository Modified files: policy/common element.hh Log message: Add missing operator== for ElemBool. Revision Changes Path 1.8 +3 -1; commitid: 14b484383de5a7ea6; xorp/policy/common/element.hh From pavlin@icir.org Wed Nov 23 03:20:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 23 Nov 2005 03:20:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/common Message-ID: <200511230320.jAN3KbGV084924@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-23 03:20:37 UTC XORP CVS repository Modified files: policy/common register_operations.cc Log message: Add missing == operation to the set of possible operations for ElemBool. This fixes the following assert in the policy manager if we add a boolean variable to a "from" or "to" policy block: [ 2005/11/22 17:53:11 FATAL xorp_policy:29375 POLICY +92 dispatcher.cc run ] Assertion (funct.bin) failed [ 2005/11/22 17:53:12 INFO xorp_rtrmgr:29372 RTRMGR +667 module_manager.cc killed ] Module abnormally killed: policy Revision Changes Path 1.15 +10 -9; commitid: 14b6f4383de887ea6; xorp/policy/common/register_operations.cc From atanu@icir.org Wed Nov 23 06:35:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 06:35:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511230635.jAN6Z1Cj086555@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 06:35:01 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: When a new route becomes the winning route but it has the same cost and nexthop as the previous route there is no reason to replace the route, it is important to copy the filtered flag from the previous route. The same route from different areas (virtual links) depending on the order of arrival could cause the filtered flag to be lost. The str() method of an internal route prints more information in particular the winning route is identified. More debugging. Revision Changes Path 1.40 +18 -11; commitid: 151fd43840d947ea6; xorp/ospf/routing_table.cc From atanu@icir.org Wed Nov 23 06:56:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 06:56:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511230656.jAN6usqx086935@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 06:56:54 UTC XORP CVS repository Modified files: ospf test_routing_table.cc Log message: Tests added while looking for the missing copy constructor in the internal route entry and the lost filter flag. Revision Changes Path 1.2 +242 -1; commitid: 1537c438412b57ea6; xorp/ospf/test_routing_table.cc From atanu@icir.org Wed Nov 23 08:29:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 08:29:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511230829.jAN8ToPI087963@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 08:29:50 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Minor refactoring. Revision Changes Path 1.158 +14 -14; commitid: 1577e4384287d7ea6; xorp/ospf/area_router.cc 1.88 +6 -6; commitid: 1577e4384287d7ea6; xorp/ospf/area_router.hh From atanu@icir.org Wed Nov 23 11:27:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 11:27:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511231127.jANBRl5i090369@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 11:27:46 UTC XORP CVS repository Modified files: ospf peer.hh Log message: Method to set the source/interface address of the peer, required for virtual links. Revision Changes Path 1.111 +10 -2; commitid: 160e6438452317ea6; xorp/ospf/peer.hh From atanu@icir.org Wed Nov 23 11:30:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 11:30:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511231130.jANBUk8Z090516@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 11:30:45 UTC XORP CVS repository Modified files: ospf vlink.cc vlink.hh Log message: Method to get the source and destination addresses back. No longer consider it an error of the source and destination address are not configured. Revision Changes Path 1.6 +21 -3; commitid: 16177438452e47ea6; xorp/ospf/vlink.cc 1.5 +6 -1; commitid: 16177438452e47ea6; xorp/ospf/vlink.hh From atanu@icir.org Wed Nov 23 11:32:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 11:32:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511231132.jANBW7rQ090573@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 11:32:07 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: The peer structure for virtual links always exists now making it easier to reconfigure. Revision Changes Path 1.94 +84 -38; commitid: 161b0438453367ea6; xorp/ospf/peer_manager.cc 1.58 +16 -1; commitid: 161b0438453367ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Wed Nov 23 12:07:12 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 12:07:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511231207.jANC7Cri090946@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 12:07:12 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow hello-interval, router-dead-interval, transit-delay (renamed form inftransdelay and authentication to be configured on a virtual link. Revision Changes Path 1.29 +46 -4; commitid: 1632743845b6e7ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Wed Nov 23 12:07:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 23 Nov 2005 12:07:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200511231207.jANC7o4d090999@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-23 12:07:50 UTC XORP CVS repository Modified files: ospf trace.hh Log message: Have input error tracing enabled by default. Revision Changes Path 1.13 +2 -2; commitid: 1635c43845b957ea6; xorp/ospf/trace.hh From pavlin@icir.org Thu Nov 24 20:02:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 24 Nov 2005 20:02:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511242002.jAOK2OnG011609@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-24 20:02:24 UTC XORP CVS repository Modified files: rtrmgr slave_conf_tree.hh Log message: Const-ify the commit_status() method. Submitted by: Marat Nepomnyashy Revision Changes Path 1.24 +2 -2; commitid: 2d4043861c2c7ea6; xorp/rtrmgr/slave_conf_tree.hh From pavlin@icir.org Sun Nov 27 05:22:59 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 27 Nov 2005 05:22:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511270522.jAR5Mxmt042566@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-27 05:22:59 UTC XORP CVS repository Modified files: rtrmgr config_operators.cc config_operators.hh Log message: Misc. cleanup Revision Changes Path 1.3 +13 -7; commitid: a62b438942ae7ea6; xorp/rtrmgr/config_operators.cc 1.4 +21 -17; commitid: a62b438942ae7ea6; xorp/rtrmgr/config_operators.hh From pavlin@icir.org Sun Nov 27 05:29:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 27 Nov 2005 05:29:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511270529.jAR5TfOi042680@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-27 05:29:41 UTC XORP CVS repository Modified files: rtrmgr module_command.cc module_command.hh Log message: * Redeclare methods expand_actions() and check_referred_variables() as virtual. * Minor cleanup. Revision Changes Path 1.34 +20 -19; commitid: a691438943aa7ea6; xorp/rtrmgr/module_command.cc 1.24 +3 -3; commitid: a691438943aa7ea6; xorp/rtrmgr/module_command.hh From pavlin@icir.org Sun Nov 27 05:43:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 27 Nov 2005 05:43:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511270543.jAR5hbnF042881@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-27 05:43:37 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc master_conf_tree_node.cc master_template_tree.cc master_template_tree.hh master_template_tree_node.cc master_template_tree_node.hh template_base_command.cc template_base_command.hh template_commands.cc template_commands.hh template_tree.cc template_tree.hh template_tree_node.cc template_tree_node.hh Log message: * Fix the %allow and %allow-range mechanism: - Check upfront the template file for errors (e.g., whether all referred variables exist, etc). - Return immediately an error when using "create" or "set" to assign a value if the value is not allowed. - Cross-node %allow and %allow-range referencing now works properly. * Store the help for each allowed value or range along with the value/range info so in the future it can be used for command-line completion. * Minor cleanup Revision Changes Path 1.103 +23 -17; commitid: a7354389461b7ea6; xorp/rtrmgr/conf_tree_node.cc 1.20 +4 -4; commitid: a7354389461b7ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.7 +11 -10; commitid: a7354389461b7ea6; xorp/rtrmgr/master_template_tree.cc 1.5 +5 -4; commitid: a7354389461b7ea6; xorp/rtrmgr/master_template_tree.hh 1.11 +21 -92; commitid: a7354389461b7ea6; xorp/rtrmgr/master_template_tree_node.cc 1.5 +4 -3; commitid: a7354389461b7ea6; xorp/rtrmgr/master_template_tree_node.hh 1.13 +341 -145; commitid: a7354389461b7ea6; xorp/rtrmgr/template_base_command.cc 1.7 +46 -24; commitid: a7354389461b7ea6; xorp/rtrmgr/template_base_command.hh 1.62 +92 -94; commitid: a7354389461b7ea6; xorp/rtrmgr/template_commands.cc 1.31 +12 -12; commitid: a7354389461b7ea6; xorp/rtrmgr/template_commands.hh 1.40 +40 -25; commitid: a7354389461b7ea6; xorp/rtrmgr/template_tree.cc 1.20 +7 -3; commitid: a7354389461b7ea6; xorp/rtrmgr/template_tree.hh 1.67 +284 -18; commitid: a7354389461b7ea6; xorp/rtrmgr/template_tree_node.cc 1.41 +20 -17; commitid: a7354389461b7ea6; xorp/rtrmgr/template_tree_node.hh From atanu@icir.org Sun Nov 27 06:10:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 27 Nov 2005 06:10:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511270610.jAR6A5Ik043280@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-27 06:10:05 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh local_data.hh peer.cc peer.hh peer_data.cc peer_data.hh peer_handler.hh plumbing.cc plumbing.hh route_table_aggregation.cc route_table_aggregation.hh test_cache.cc test_decision.cc test_deletion.cc test_dump.cc test_fanout.cc test_filter.cc test_nhlookup.cc test_peer_data.cc test_plumbing.cc test_ribin.cc test_ribout.cc xrl_shell_funcs.sh xrl_target.cc xrl_target.hh etc/templates bgp.tp xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: Allow route reflectors and confederations to be configured. It was possible to configure a route reflector client previously but once a peer was configured as a route reflector the state could not be changed. The constructor for a bgp peer data no longer takes the type of the peering. The determination of the type of peer computed by calling compute_peer_type(). The local data structure is now bound to the peer data structure to aid in the computation of the peer type. The AS number of the router is now found by calling my_AS_number() in the peer data structure, if a router is configured as part of a confederation it has two AS numbers one that is used with other confederation members and one that is used with other E-BGP peers, hence the requirement to get the routers own AS number from the peer data structure. Revision Changes Path 1.60 +59 -6; commitid: a87943894db47ea6; xorp/bgp/bgp.cc 1.50 +26 -1; commitid: a87943894db47ea6; xorp/bgp/bgp.hh 1.12 +12 -30; commitid: a87943894db47ea6; xorp/bgp/local_data.hh 1.104 +6 -3; commitid: a87943894db47ea6; xorp/bgp/peer.cc 1.29 +2 -2; commitid: a87943894db47ea6; xorp/bgp/peer.hh 1.26 +45 -18; commitid: a87943894db47ea6; xorp/bgp/peer_data.cc 1.18 +35 -13; commitid: a87943894db47ea6; xorp/bgp/peer_data.hh 1.20 +11 -1; commitid: a87943894db47ea6; xorp/bgp/peer_handler.hh 1.80 +3 -10; commitid: a87943894db47ea6; xorp/bgp/plumbing.cc 1.34 +1 -6; commitid: a87943894db47ea6; xorp/bgp/plumbing.hh 1.11 +3 -2; commitid: a87943894db47ea6; xorp/bgp/route_table_aggregation.cc 1.8 +4 -4; commitid: a87943894db47ea6; xorp/bgp/route_table_aggregation.hh 1.27 +3 -5; commitid: a87943894db47ea6; xorp/bgp/test_cache.cc 1.35 +9 -8; commitid: a87943894db47ea6; xorp/bgp/test_decision.cc 1.26 +3 -5; commitid: a87943894db47ea6; xorp/bgp/test_deletion.cc 1.49 +4 -7; commitid: a87943894db47ea6; xorp/bgp/test_dump.cc 1.29 +4 -7; commitid: a87943894db47ea6; xorp/bgp/test_fanout.cc 1.35 +3 -5; commitid: a87943894db47ea6; xorp/bgp/test_filter.cc 1.29 +3 -5; commitid: a87943894db47ea6; xorp/bgp/test_nhlookup.cc 1.12 +3 -2; commitid: a87943894db47ea6; xorp/bgp/test_peer_data.cc 1.18 +11 -11; commitid: a87943894db47ea6; xorp/bgp/test_plumbing.cc 1.31 +5 -9; commitid: a87943894db47ea6; xorp/bgp/test_ribin.cc 1.28 +6 -5; commitid: a87943894db47ea6; xorp/bgp/test_ribout.cc 1.13 +2 -2; commitid: a87943894db47ea6; xorp/bgp/xrl_shell_funcs.sh 1.48 +70 -15; commitid: a87943894db47ea6; xorp/bgp/xrl_target.cc 1.34 +22 -2; commitid: a87943894db47ea6; xorp/bgp/xrl_target.hh 1.67 +57 -3; commitid: a87943894db47ea6; xorp/etc/templates/bgp.tp 1.27 +47 -3; commitid: a87943894db47ea6; xorp/xrl/interfaces/bgp.xif 1.39 +115 -3; commitid: a87943894db47ea6; xorp/xrl/interfaces/bgp_xif.cc 1.38 +79 -4; commitid: a87943894db47ea6; xorp/xrl/interfaces/bgp_xif.hh 1.42 +26 -4; commitid: a87943894db47ea6; xorp/xrl/targets/bgp.xrls 1.44 +102 -4; commitid: a87943894db47ea6; xorp/xrl/targets/bgp_base.cc 1.51 +52 -4; commitid: a87943894db47ea6; xorp/xrl/targets/bgp_base.hh From pavlin@icir.org Sun Nov 27 06:45:12 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 27 Nov 2005 06:45:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511270645.jAR6jCD3043626@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-27 06:45:12 UTC XORP CVS repository Modified files: rtrmgr template_base_command.cc template_tree_node.cc Log message: Change the semantics for the cross-node %allow-range so when more than one range is applied for a node, the value of that node should belong to any of the corresponding ranges. This semantic change is for consistency with the %allow behavior. Revision Changes Path 1.14 +39 -10; commitid: aa22438955927ea6; xorp/rtrmgr/template_base_command.cc 1.68 +37 -9; commitid: aa22438955927ea6; xorp/rtrmgr/template_tree_node.cc From pavlin@icir.org Sun Nov 27 06:50:09 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 27 Nov 2005 06:50:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511270650.jAR6o9Wu043697@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-27 06:50:09 UTC XORP CVS repository Modified files: rtrmgr template_base_command.cc Log message: Bug fix in creating the error message when a value fails the check for all allowed ranges. Revision Changes Path 1.15 +3 -3; commitid: aa84438956ed7ea6; xorp/rtrmgr/template_base_command.cc From atanu@icir.org Sun Nov 27 17:44:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 27 Nov 2005 17:44:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511271744.jARHiVDb050162@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-27 17:44:31 UTC XORP CVS repository Modified files: bgp route_table_filter.hh Log message: Correct a typo in a comment. Revision Changes Path 1.22 +2 -2; commitid: c3d74389f07e7ea6; xorp/bgp/route_table_filter.hh From atanu@icir.org Sun Nov 27 19:45:43 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 27 Nov 2005 19:45:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511271945.jARJjhiQ051015@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-27 19:45:43 UTC XORP CVS repository Modified files: bgp path_attribute.cc path_attribute.hh Log message: Add methods to extract the originator ID and the cluster ID. Revision Changes Path 1.63 +21 -1; commitid: c72a438a0ce67ea6; xorp/bgp/path_attribute.cc 1.39 +3 -1; commitid: c72a438a0ce67ea6; xorp/bgp/path_attribute.hh From atanu@icir.org Mon Nov 28 04:45:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:45:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280445.jAS4j5Tr054864@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:45:05 UTC XORP CVS repository Modified files: bgp local_data.hh Log message: Store the route reflection status and the CLUSTER_ID. Revision Changes Path 1.13 +35 -2; commitid: d635438a8b4f7ea6; xorp/bgp/local_data.hh From atanu@icir.org Mon Nov 28 04:49:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:49:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280449.jAS4nwLX054965@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:49:58 UTC XORP CVS repository Modified files: bgp peer_data.cc Log message: For a peer to be considered a route reflector client the router must also be configured to be a router reflector. Revision Changes Path 1.27 +2 -2; commitid: d69a438a8c757ea6; xorp/bgp/peer_data.cc From atanu@icir.org Mon Nov 28 04:51:51 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:51:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280451.jAS4ppU4055063@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:51:51 UTC XORP CVS repository Modified files: bgp path_attribute.cc path_attribute.hh Log message: Add a contains() method to the CLUSTER_LIST attribute. Revision Changes Path 1.64 +10 -2; commitid: d6fa438a8ce67ea6; xorp/bgp/path_attribute.cc 1.40 +2 -1; commitid: d6fa438a8ce67ea6; xorp/bgp/path_attribute.hh From atanu@icir.org Mon Nov 28 04:55:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:55:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280455.jAS4t1Tg055121@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:55:01 UTC XORP CVS repository Modified files: bgp route_table_filter.cc route_table_filter.hh Log message: An input and output filter for route reflection processing. The input filter performs loop detection by checking the the ORIGINATOR_ID and CLUSTER_LIST. The output filter is a replacement for the IBGP loop filter when route reflection is enabled. Revision Changes Path 1.42 +148 -1; commitid: d734438a8da47ea6; xorp/bgp/route_table_filter.cc 1.23 +58 -1; commitid: d734438a8da47ea6; xorp/bgp/route_table_filter.hh From atanu@icir.org Mon Nov 28 04:56:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:56:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280456.jAS4uEK8055186@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:56:14 UTC XORP CVS repository Modified files: bgp plumbing.cc Log message: Plumb in the route reflection filters if route reflection is enabled. Revision Changes Path 1.81 +30 -4; commitid: d777438a8ded7ea6; xorp/bgp/plumbing.cc From atanu@icir.org Mon Nov 28 04:57:33 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:57:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280457.jAS4vXNr055243@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:57:33 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh Log message: Set the CLUSTER_ID and route reflection status. Revision Changes Path 1.61 +12 -1; commitid: d7ae438a8e3b7ea6; xorp/bgp/bgp.cc 1.51 +6 -1; commitid: d7ae438a8e3b7ea6; xorp/bgp/bgp.hh From atanu@icir.org Mon Nov 28 04:58:25 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 04:58:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511280458.jAS4wPiU055336@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 04:58:25 UTC XORP CVS repository Modified files: bgp xrl_target.cc xrl_target.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: Set the CLUSTER_ID and route reflection status. Revision Changes Path 1.49 +13 -1; commitid: d7d9438a8e6e7ea6; xorp/bgp/xrl_target.cc 1.35 +6 -1; commitid: d7d9438a8e6e7ea6; xorp/bgp/xrl_target.hh 1.28 +12 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/interfaces/bgp.xif 1.40 +35 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/interfaces/bgp_xif.cc 1.39 +26 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/interfaces/bgp_xif.hh 1.43 +10 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/targets/bgp.xrls 1.45 +32 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/targets/bgp_base.cc 1.52 +17 -1; commitid: d7d9438a8e6e7ea6; xorp/xrl/targets/bgp_base.hh From atanu@icir.org Mon Nov 28 05:00:04 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 05:00:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511280500.jAS504O7055404@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 05:00:04 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Allow the setting of the CLUSTER_ID and route reflection status. Revision Changes Path 1.68 +35 -1; commitid: d851438a8ed37ea6; xorp/etc/templates/bgp.tp From atanu@icir.org Mon Nov 28 06:41:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 06:41:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280641.jAS6ff3q056434@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 06:41:41 UTC XORP CVS repository Modified files: bgp xrl_target.cc Log message: Add newlines to the debugging messages. Revision Changes Path 1.50 +3 -3; commitid: dc57438aa6a47ea6; xorp/bgp/xrl_target.cc From atanu@icir.org Mon Nov 28 06:43:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 06:43:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280643.jAS6hwvN056503@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 06:43:57 UTC XORP CVS repository Modified files: bgp peer_handler.cc Log message: Comment out teh assert the checks for update packets going from IBGP peers to IBGP peers as this is legal when the router is a route reflector. Revision Changes Path 1.40 +7 -7; commitid: dc9c438aa72d7ea6; xorp/bgp/peer_handler.cc From atanu@icir.org Mon Nov 28 06:45:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 06:45:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280645.jAS6jFfu056629@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 06:45:15 UTC XORP CVS repository Modified files: bgp local_data.hh Log message: Don't pass the bool argument as a reference as the caller is negating the value. Revision Changes Path 1.14 +2 -2; commitid: dd1a438aa7787ea6; xorp/bgp/local_data.hh From atanu@icir.org Mon Nov 28 08:34:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 08:34:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280834.jAS8YSvu058016@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 08:34:28 UTC XORP CVS repository Modified files: bgp path_attribute.cc path_attribute.hh plumbing.cc route_table_filter.cc route_table_filter.hh Log message: Store the ORIGINATOR_ID and CLUSTER_LIST attributes as IPv4 not uint32_t, makes them easier to handle. Fix a problem when cloning a cluster list, going backwards through a list requires a reverse iterator. Revision Changes Path 1.65 +17 -20; commitid: e27d438ac1127ea6; xorp/bgp/path_attribute.cc 1.41 +9 -9; commitid: e27d438ac1127ea6; xorp/bgp/path_attribute.hh 1.82 +5 -5; commitid: e27d438ac1127ea6; xorp/bgp/plumbing.cc 1.43 +11 -12; commitid: e27d438ac1127ea6; xorp/bgp/route_table_filter.cc 1.24 +13 -13; commitid: e27d438ac1127ea6; xorp/bgp/route_table_filter.hh From atanu@icir.org Mon Nov 28 08:35:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 08:35:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280835.jAS8ZDbF058090@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 08:35:13 UTC XORP CVS repository Modified files: bgp test_packet.cc Log message: Add the ORIGINATOR_ID and CLUSTER_LIST attributes to the update packet test. Revision Changes Path 1.12 +6 -1; commitid: e2ce438ac1417ea6; xorp/bgp/test_packet.cc From atanu@icir.org Mon Nov 28 09:17:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 09:17:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511280917.jAS9HEK2059351@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 09:17:14 UTC XORP CVS repository Modified files: bgp path_attribute.cc Log message: Store the CLUSTER_LIST in the order that it arrived on the wire, not the reverse order. Revision Changes Path 1.66 +2 -2; commitid: e7b8438acb197ea6; xorp/bgp/path_attribute.cc From atanu@icir.org Mon Nov 28 09:21:27 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 09:21:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness xorp/docs/test_harness Message-ID: <200511280921.jAS9LRMr059468@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 09:21:27 UTC XORP CVS repository Modified files: bgp/harness peer.cc docs/test_harness test_harness.tex Log message: The path attributes ORIGINATOR_ID and CLUSTER_LIST can now be set in the test harness. Revision Changes Path 1.67 +12 -1; commitid: e81c438acc157ea6; xorp/bgp/harness/peer.cc 1.31 +2 -0; commitid: e81c438acc157ea6; xorp/docs/test_harness/test_harness.tex From atanu@icir.org Mon Nov 28 10:00:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 10:00:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511281000.jASA0NPt059922@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 10:00:23 UTC XORP CVS repository Added files: bgp/harness test_route_reflection1.sh Log message: Testing route reflection. Revision Changes Path 1.1 +367 -0 xorp/bgp/harness/test_route_reflection1.sh (new) From atanu@icir.org Mon Nov 28 15:38:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 28 Nov 2005 15:38:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511281538.jASFcjNf063848@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-28 15:38:45 UTC XORP CVS repository Modified files: bgp/harness Makefile.am Makefile.in Log message: Add route reflection test. Revision Changes Path 1.19 +2 -1; commitid: f94b438b24837ea6; xorp/bgp/harness/Makefile.am 1.34 +1 -1; commitid: f94b438b24837ea6; xorp/bgp/harness/Makefile.in From zec@icir.org Mon Nov 28 17:48:57 2005 From: zec@icir.org (Marko Zec) Date: Mon, 28 Nov 2005 17:48:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511281748.jASHmvsK066693@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-28 17:48:57 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Make "was-aggregated" flag on a route accessible as a proper bool type in policy expressions, and remove a hack that previously tried to emulate this using an u32 type comparisson against aggregate_prefix_len. Revision Changes Path 1.69 +5 -4; commitid: 1041b438b40cb7ea6; xorp/etc/templates/bgp.tp From pavlin@icir.org Tue Nov 29 01:48:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 29 Nov 2005 01:48:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/design_arch xorp/docs/design_arch/figs xorp/docs/fea xorp/docs/libxorp xorp/docs/mfea xorp/docs/mfea/figs xorp/docs/mld6igmp xorp/docs/multicast xorp/docs/multicast/figs xorp/docs/pim xorp/docs/pim/figs xorp/docs/pim_testsuite ... Message-ID: <200511290148.jAT1mfIr072345@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-29 01:48:41 UTC XORP CVS repository Modified files: docs/design_arch design_arch.tex error_handling.tex docs/design_arch/figs error_dependency.eps docs/fea fea.tex docs/libxorp libxorp_overview.tex docs/mfea mfea_arch.tex docs/mfea/figs mfea_design_overview.eps docs/mld6igmp mld6igmp_arch.tex docs/multicast multicast_arch.tex docs/multicast/figs mcast_modules_interaction.eps docs/pim pim_arch.tex docs/pim/figs pim_design_overview.eps docs/pim_testsuite pim_testsuite.tex docs/rib rib.tex docs/rtrmgr rtrmgr.tex docs/snmp snmp_overview.tex docs/user_manual user_manual.tex docs/xorpdev_101 xorpdev_101.tex Log message: Replace "\usepackage{psfig}" with "\usepackage{epsfig}", because psfig is obsolete and epsfig should be used instead. This fixes Bugzilla entry #378 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=378 Submitted by: hasso AT linux.ee (Hasso Tepper) Revision Changes Path 1.17 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/design_arch/design_arch.tex 1.35 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/design_arch/error_handling.tex 1.7 +1 -1; commitid: 11924438bb2da7ea6; xorp/docs/design_arch/figs/error_dependency.eps 1.16 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/fea/fea.tex 1.22 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/libxorp/libxorp_overview.tex 1.6 +1 -1; commitid: 11924438bb2da7ea6; xorp/docs/mfea/figs/mfea_design_overview.eps 1.20 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/mfea/mfea_arch.tex 1.16 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/mld6igmp/mld6igmp_arch.tex 1.8 +1 -1; commitid: 11924438bb2da7ea6; xorp/docs/multicast/figs/mcast_modules_interaction.eps 1.17 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/multicast/multicast_arch.tex 1.5 +1 -1; commitid: 11924438bb2da7ea6; xorp/docs/pim/figs/pim_design_overview.eps 1.20 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/pim/pim_arch.tex 1.39 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/pim_testsuite/pim_testsuite.tex 1.19 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/rib/rib.tex 1.46 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/rtrmgr/rtrmgr.tex 1.23 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/snmp/snmp_overview.tex 1.14 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/user_manual/user_manual.tex 1.13 +2 -2; commitid: 11924438bb2da7ea6; xorp/docs/xorpdev_101/xorpdev_101.tex From pavlin@icir.org Tue Nov 29 02:01:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 29 Nov 2005 02:01:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/libxipc Message-ID: <200511290201.jAT21b7p072480@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-29 02:01:37 UTC XORP CVS repository Modified files: docs/libxipc xrl_interfaces.tex Log message: Remove the old 0.21 listing behavior. This fixes Bugzilla entry #379 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=379 Submitted by: hasso AT linux.ee (Hasso Tepper) Revision Changes Path 1.17 +2 -2; commitid: 11af0438bb6177ea6; xorp/docs/libxipc/xrl_interfaces.tex From pavlin@icir.org Tue Nov 29 02:34:09 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 29 Nov 2005 02:34:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511290234.jAT2Y934072849@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-29 02:34:09 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.hh Log message: Add new methods allowed_values() and allowed_ranges() to obtain the maps with the allowed values and the allowed ranges respectively. Revision Changes Path 1.42 +5 -1; commitid: 11c78438bbe067ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Tue Nov 29 03:10:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 29 Nov 2005 03:10:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511290310.jAT3Af2M073358@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-29 03:10:41 UTC XORP CVS repository Modified files: rtrmgr command_tree.hh Log message: Const-ify some of the methods. Revision Changes Path 1.12 +3 -3; commitid: 11e75438bc6a97ea6; xorp/rtrmgr/command_tree.hh From atanu@icir.org Tue Nov 29 15:26:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 29 Nov 2005 15:26:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511291526.jATFQ0xD080858@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-29 15:26:00 UTC XORP CVS repository Modified files: bgp xrl_shell_funcs.sh Log message: Route reflector commands. Revision Changes Path 1.14 +13 -1; commitid: 13bbf438c73067ea6; xorp/bgp/xrl_shell_funcs.sh From zec@icir.org Tue Nov 29 17:46:21 2005 From: zec@icir.org (Marko Zec) Date: Tue, 29 Nov 2005 17:46:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511291746.jATHkL4J083742@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: zec@xorpc.icir.org 2005-11-29 17:46:21 UTC XORP CVS repository Modified files: bgp route_table_aggregation.cc Log message: Correctly handle conflict resolution when a component route and an aggregate are using the same prefix. In such a case aggregate wins. Revision Changes Path 1.12 +7 -4; commitid: 146ca438c931a7ea6; xorp/bgp/route_table_aggregation.cc From atanu@icir.org Tue Nov 29 19:19:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 29 Nov 2005 19:19:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200511291919.jATJJ9QW084763@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-29 19:19:09 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: In route reflection and confederations make the disable variable false by default (therefore no longer mandatory) and on deletion set to the complement of the default value. Requested by: Pavlin Revision Changes Path 1.70 +5 -7; commitid: 14b00438ca9ac7ea6; xorp/etc/templates/bgp.tp From atanu@icir.org Tue Nov 29 22:04:37 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 29 Nov 2005 22:04:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/bgp/harness Message-ID: <200511292204.jATM4bnf088352@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-29 22:04:37 UTC XORP CVS repository Modified files: bgp peer.cc peer.hh bgp/harness test_peering1.sh Log message: Implement Optional Session Attributes: AllowAutomaticStart, DampPeerOscillations, IdleHoldTime, IdleHoldTimer draft-ietf-idr-bgp4-26.txt: ---------------------------------------- An example of DampPeerOscillations logic is an increase of the IdleHoldTime value if a BGP peer oscillates connectivity (connected/disconnected) repeatedly within a time period. To engage this logic, a peer could connect and disconnect 10 times within 5 minutes. The IdleHoldTime value would be reset from 0 to 120 seconds. ---------------------------------------- The RFC leaves it up to the implementation to decide how to damp peer oscillations, but offers the above as a possible implementation. Revision Changes Path 1.36 +26 -2; commitid: 158ee438cd0737ea6; xorp/bgp/harness/test_peering1.sh 1.105 +114 -20; commitid: 158ee438cd0737ea6; xorp/bgp/peer.cc 1.30 +70 -5; commitid: 158ee438cd0737ea6; xorp/bgp/peer.hh From pavlin@icir.org Wed Nov 30 01:38:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 30 Nov 2005 01:38:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511300138.jAU1clf6090544@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-30 01:38:47 UTC XORP CVS repository Modified files: rtrmgr cli.cc cli.hh Log message: * Add command-line completion and help for "%allow" listed values. * Add help listing for "%allow-range" listed ranges. This fixes Bugzilla #134 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=134 Revision Changes Path 1.109 +146 -22; commitid: 16186438d01f47ea6; xorp/rtrmgr/cli.cc 1.42 +3 -2; commitid: 16186438d01f47ea6; xorp/rtrmgr/cli.hh From pavlin@icir.org Wed Nov 30 03:18:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 30 Nov 2005 03:18:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200511300318.jAU3Iga8091422@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-11-30 03:18:42 UTC XORP CVS repository Modified files: rtrmgr template_tree_node.cc template_tree_node.hh Log message: Add a flag to each template tree node to indicate whether it is %mandatory. Submitted by: Marat Nepomnyashy Revision Changes Path 1.69 +47 -3; commitid: 16503438d19c37ea6; xorp/rtrmgr/template_tree_node.cc 1.43 +4 -2; commitid: 16503438d19c37ea6; xorp/rtrmgr/template_tree_node.hh From atanu@icir.org Wed Nov 30 07:31:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 30 Nov 2005 07:31:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200511300731.jAU7VGkv093791@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-30 07:31:16 UTC XORP CVS repository Modified files: bgp/harness test_peering2.sh Log message: Add a delay to allow the IDLE holdtime transition. Revision Changes Path 1.48 +3 -1; commitid: 16e44438d55447ea6; xorp/bgp/harness/test_peering2.sh From atanu@icir.org Wed Nov 30 07:34:25 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 30 Nov 2005 07:34:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200511300734.jAU7YP6K093882@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-30 07:34:25 UTC XORP CVS repository Modified files: bgp peer.cc peer.hh Log message: When transitioning to the idle state the default is now automatic restart. The exception is the peering being manually brought up or taken down. Revision Changes Path 1.106 +18 -26; commitid: 16e9d438d56007ea6; xorp/bgp/peer.cc 1.31 +2 -2; commitid: 16e9d438d56007ea6; xorp/bgp/peer.hh From atanu@icir.org Wed Nov 30 08:08:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 30 Nov 2005 08:08:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200511300808.jAU88kdH094482@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-11-30 08:08:46 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh peer_data.cc peer_data.hh xrl_target.cc xrl_target.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: Allow the delay open time to be configured. Revision Changes Path 1.62 +23 -1; commitid: 170bb438d5e097ea6; xorp/bgp/bgp.cc 1.52 +11 -1; commitid: 170bb438d5e097ea6; xorp/bgp/bgp.hh 1.28 +2 -1; commitid: 170bb438d5e097ea6; xorp/bgp/peer_data.cc 1.19 +14 -1; commitid: 170bb438d5e097ea6; xorp/bgp/peer_data.hh 1.51 +29 -1; commitid: 170bb438d5e097ea6; xorp/bgp/xrl_target.cc 1.36 +9 -1; commitid: 170bb438d5e097ea6; xorp/bgp/xrl_target.hh 1.29 +19 -1; commitid: 170bb438d5e097ea6; xorp/xrl/interfaces/bgp.xif 1.41 +41 -1; commitid: 170bb438d5e097ea6; xorp/xrl/interfaces/bgp_xif.cc 1.40 +27 -1; commitid: 170bb438d5e097ea6; xorp/xrl/interfaces/bgp_xif.hh 1.44 +8 -1; commitid: 170bb438d5e097ea6; xorp/xrl/targets/bgp.xrls 1.46 +35 -1; commitid: 170bb438d5e097ea6; xorp/xrl/targets/bgp_base.cc 1.53 +18 -1; commitid: 170bb438d5e097ea6; xorp/xrl/targets/bgp_base.hh