From atanu@icir.org Sat Oct 1 04:09:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 03:09:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010309.j9139Jv0052491@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 03:09:19 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: The routing table can now hold a route from each participating area. The Path_type enumeration has been assigned values as it is required to select the best route. Revision Changes Path 1.7 +101 -16; commitid: ccee433dfddf7ea6; xorp/ospf/routing_table.cc 1.6 +52 -7; commitid: ccee433dfddf7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 04:22:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 03:22:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010322.j913MGjI052660@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 03:22:16 UTC XORP CVS repository Modified files: ospf area_router.cc routing_table.cc routing_table.hh Log message: When adding a route to the routing table pass in the originating area. Revision Changes Path 1.99 +6 -6; commitid: cd95433e00e77ea6; xorp/ospf/area_router.cc 1.8 +8 -6; commitid: cd95433e00e77ea6; xorp/ospf/routing_table.cc 1.7 +5 -4; commitid: cd95433e00e77ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 04:25:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 03:25:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010325.j913P1hM052712@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 03:25:01 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Fix a typo in a comment. Revision Changes Path 1.8 +2 -2; commitid: cdca433e018c7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 04:37:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 03:37:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010337.j913bZMe052873@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 03:37:35 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Move the adding, replacing and deleting of routes to the RIB into separate methods to allow the summary generation hooks. Revision Changes Path 1.9 +34 -9; commitid: ce6c433e047e7ea6; xorp/ospf/routing_table.cc 1.9 +5 -1; commitid: ce6c433e047e7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 06:10:39 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 05:10:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010510.j915AdsP053856@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 05:10:39 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Add a str() method to the RouteEntry. Revision Changes Path 1.10 +9 -1; commitid: d245433e1a4f7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 06:13:10 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 05:13:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010513.j915DAWC053960@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 05:13:10 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Hooks for Summary-LSA generation. Revision Changes Path 1.51 +22 -1; commitid: d2ab433e1ae57ea6; xorp/ospf/peer_manager.cc 1.34 +17 -1; commitid: d2ab433e1ae57ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Sat Oct 1 06:14:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 05:14:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010514.j915EVJ3054008@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 05:14:31 UTC XORP CVS repository Modified files: ospf peer_manager.hh Log message: Remove spurious blank line. Revision Changes Path 1.35 +1 -2; commitid: d2dd433e1b367ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Sat Oct 1 06:28:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 05:28:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010528.j915SVUJ054220@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 05:28:31 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Add the RouteEntry to the add and replace route methods, required for passing onto the summary generation methods. Revision Changes Path 1.10 +8 -6; commitid: d3af433e1e7e7ea6; xorp/ospf/routing_table.cc 1.11 +7 -3; commitid: d3af433e1e7e7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 1 06:42:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 1 Oct 2005 05:42:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510010542.j915gMnN054402@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-01 05:42:22 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: When a route is added or deleted from the RIB send the route to the peer manager for distribution to the area for possible summary generation. Revision Changes Path 1.11 +19 -10; commitid: d465433e21be7ea6; xorp/ospf/routing_table.cc 1.12 +7 -7; commitid: d465433e21be7ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Sun Oct 2 06:33:32 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 2 Oct 2005 05:33:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200510020533.j925XWxs067957@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-02 05:33:32 UTC XORP CVS repository Modified files: rib route.hh rt_tab_extint.cc rt_tab_extint.hh Log message: Fix a bug when deleting some unresolved RIB routes could take too long (up to 30ms). * Add new class UnresolvedIPRouteEntry and use it to store routing entries that have unresolved next-hop. * Refactor the mechanism for storing the unresolved routing entries in the ExtIntTable so now each entry contains the iterator for the multimap entry it belongs to. This refactoring makes the removal of an unresolved entry much faster. Previously, if there were 150K unresolved entries all of them pointing to the same (unresolved) next-hop router, deletion of a single (unresolved) route could take up to 30ms. Most of this time was spent inside ExtIntTable::delete_unresolved_nexthop() which practically scanned the whole multimap to find the matching entry that is to be deleted. After the refactoring deleting the same route now takes 60us. Revision Changes Path 1.19 +82 -1; commitid: 108f0433f6f007ea6; xorp/rib/route.hh 1.26 +32 -25; commitid: 108f0433f6f007ea6; xorp/rib/rt_tab_extint.cc 1.13 +5 -3; commitid: 108f0433f6f007ea6; xorp/rib/rt_tab_extint.hh From pavlin@icir.org Sun Oct 2 19:19:16 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 2 Oct 2005 18:19:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200510021819.j92IJGLE077709@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-02 18:19:16 UTC XORP CVS repository Modified files: policy policy_statement.cc policy_statement.hh term.cc term.hh Log message: Add support for adding policy terms or nodes that are received out-of-order. We need such support because the ConfigNodeIdMap container assumes that the entries are added in-order, but there is no guarantee that the XRLs that add the policy entries are originated in-order (the order depends on the specification in rtrmgr templates). Bug found by: Andrea Bittau Revision Changes Path 1.7 +114 -7; commitid: 12f69434023df7ea6; xorp/policy/policy_statement.cc 1.6 +22 -2; commitid: 12f69434023df7ea6; xorp/policy/policy_statement.hh 1.14 +70 -3; commitid: 12f69434023df7ea6; xorp/policy/term.cc 1.10 +5 -1; commitid: 12f69434023df7ea6; xorp/policy/term.hh From pavlin@icir.org Sun Oct 2 23:10:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 2 Oct 2005 22:10:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510022210.j92MANS2080245@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-02 22:10:23 UTC XORP CVS repository Modified files: rtrmgr lex.opcmd.cc op_commands.ll Log message: * Change the rules for parsing a string by taking the implementation from the rtrmgr template parser (template.ll) This fixes a bug that previously we couldn't add the C-style '\n' symbol to a comment if we want, say, the help for an operational command to contain '\n'. * Regenerate lex.opcmd.cc Note that this regeneration removes manually added Windows-related modifications like the following, so this may break the Windows compilation: #ifdef HOST_OS_WINDOWS #define isatty(x) _isatty(x) #define fileno(x) _fileno(x) #endif It is impossible to maintain such modifications in auto-generated files, and they should be added somewhere else (e.g., somewhere in libxorp). * Add a comment explaining the LITERAL rule syntax. Bug found by: "Michael Larson" Revision Changes Path 1.19 +193 -130; commitid: 13917434059747ea6; xorp/rtrmgr/lex.opcmd.cc 1.12 +44 -4; commitid: 13917434059747ea6; xorp/rtrmgr/op_commands.ll From abittau@icir.org Sun Oct 2 23:21:58 2005 From: abittau@icir.org (Andrea Bittau) Date: Sun, 2 Oct 2005 22:21:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/etc/templates xorp/fib2mrib xorp/policy xorp/policy/backend xorp/policy/common xorp/policy/test xorp/rib xorp/rip xorp/static_routes xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510022221.j92MLwxD080781@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-10-02 22:21:58 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc bgp_varrw.hh bgp_varrw_export.cc bgp_varrw_export.hh route_table_policy.cc route_table_policy.hh route_table_policy_ex.cc route_table_policy_ex.hh xrl_target.cc etc/templates bgp.tp rip.tp ripng.tp static_routes.tp fib2mrib fib2mrib_varrw.cc fib2mrib_varrw.hh policy code_generator.cc code_generator.hh configuration.cc configuration.hh export_code_generator.cc export_code_generator.hh filter_manager.cc node.hh policy_list.cc policy_target.cc policy_target.hh semantic_varrw.cc semantic_varrw.hh source_match_code_generator.cc source_match_code_generator.hh var_map.cc var_map.hh visitor.hh visitor_semantic.cc visitor_semantic.hh xrl_target.cc xrl_target.hh policy/backend Makefile.am Makefile.in backend.y instruction.hh iv_exec.cc iv_exec.hh policy_filter.cc policy_filter.hh policy_instr.hh policytags.cc single_varrw.cc single_varrw.hh term_instr.hh version_filter.cc version_filter.hh version_filters.cc version_filters.hh yacc.yy_policy_backend_parser.cc policy/common Makefile.am Makefile.in dispatcher.cc dispatcher.hh elem_null.hh elem_set.cc elem_set.hh element.cc element.hh element_base.hh operator.hh operator_base.hh register_elements.cc register_operations.cc varrw.cc varrw.hh policy/test compilepolicy.cc file_varrw.cc file_varrw.hh policy1.var policy2.var policyvarmap.conf rib rib_varrw.cc rib_varrw.hh rip rip_varrw.cc rip_varrw.hh static_routes static_routes_varrw.cc static_routes_varrw.hh xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Added files: policy/common elem_bgp.hh elem_filter.hh operator.cc Log message: First optimization pass for policy. Once upon at time: abittau[53c:68%]bgp$ ./policy_test 100000 policy_papername.txt Creating routes Owning... Elapsed: 27365ms abittau[66c:72%]bgp$ Now: abittau[60c:100%]bgp$ ./policy_test 100000 policy_paper20.txt Creating routes Owning... Elapsed: 4117ms abittau[60c:100%]bgp$ With -O2 -march=pentium4, it takes about 2 seconds. The program will filter 100000 against a bgp import policy which looks like: from { network4 != 10.0.0.0/24; nexthop4 != 10.0.66.1; } then { as-path-prepend: 6234; med += 1; } Let me know what breaks. The yacc generated file for the Windows port will break for example. Revision Changes Path 1.20 +129 -86; commitid: 139cf43405c957ea6; xorp/bgp/bgp_varrw.cc 1.13 +34 -13; commitid: 139cf43405c957ea6; xorp/bgp/bgp_varrw.hh 1.3 +3 -4; commitid: 139cf43405c957ea6; xorp/bgp/bgp_varrw_export.cc 1.2 +2 -5; commitid: 139cf43405c957ea6; xorp/bgp/bgp_varrw_export.hh 1.19 +24 -26; commitid: 139cf43405c957ea6; xorp/bgp/route_table_policy.cc 1.7 +4 -11; commitid: 139cf43405c957ea6; xorp/bgp/route_table_policy.hh 1.2 +6 -8; commitid: 139cf43405c957ea6; xorp/bgp/route_table_policy_ex.cc 1.2 +3 -10; commitid: 139cf43405c957ea6; xorp/bgp/route_table_policy_ex.hh 1.40 +3 -1; commitid: 139cf43405c957ea6; xorp/bgp/xrl_target.cc 1.56 +19 -14; commitid: 139cf43405c957ea6; xorp/etc/templates/bgp.tp 1.25 +6 -6; commitid: 139cf43405c957ea6; xorp/etc/templates/rip.tp 1.25 +5 -5; commitid: 139cf43405c957ea6; xorp/etc/templates/ripng.tp 1.24 +3 -3; commitid: 139cf43405c957ea6; xorp/etc/templates/static_routes.tp 1.6 +14 -14; commitid: 139cf43405c957ea6; xorp/fib2mrib/fib2mrib_varrw.cc 1.5 +11 -3; commitid: 139cf43405c957ea6; xorp/fib2mrib/fib2mrib_varrw.hh 1.6 +4 -2; commitid: 139cf43405c957ea6; xorp/policy/backend/Makefile.am 1.9 +5 -4; commitid: 139cf43405c957ea6; xorp/policy/backend/Makefile.in 1.7 +15 -2; commitid: 139cf43405c957ea6; xorp/policy/backend/backend.y 1.5 +8 -7; commitid: 139cf43405c957ea6; xorp/policy/backend/instruction.hh 1.7 +114 -65; commitid: 139cf43405c957ea6; xorp/policy/backend/iv_exec.cc 1.6 +21 -20; commitid: 139cf43405c957ea6; xorp/policy/backend/iv_exec.hh 1.7 +5 -4; commitid: 139cf43405c957ea6; xorp/policy/backend/policy_filter.cc 1.5 +3 -1; commitid: 139cf43405c957ea6; xorp/policy/backend/policy_filter.hh 1.3 +25 -7; commitid: 139cf43405c957ea6; xorp/policy/backend/policy_instr.hh 1.6 +3 -2; commitid: 139cf43405c957ea6; xorp/policy/backend/policytags.cc 1.9 +42 -47; commitid: 139cf43405c957ea6; xorp/policy/backend/single_varrw.cc 1.6 +11 -17; commitid: 139cf43405c957ea6; xorp/policy/backend/single_varrw.hh 1.3 +25 -6; commitid: 139cf43405c957ea6; xorp/policy/backend/term_instr.hh 1.3 +16 -14; commitid: 139cf43405c957ea6; xorp/policy/backend/version_filter.cc 1.2 +3 -3; commitid: 139cf43405c957ea6; xorp/policy/backend/version_filter.hh 1.2 +4 -8; commitid: 139cf43405c957ea6; xorp/policy/backend/version_filters.cc 1.2 +1 -5; commitid: 139cf43405c957ea6; xorp/policy/backend/version_filters.hh 1.7 +51 -35; commitid: 139cf43405c957ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc 1.7 +21 -7; commitid: 139cf43405c957ea6; xorp/policy/code_generator.cc 1.4 +13 -7; commitid: 139cf43405c957ea6; xorp/policy/code_generator.hh 1.5 +7 -3; commitid: 139cf43405c957ea6; xorp/policy/common/Makefile.am 1.8 +30 -7; commitid: 139cf43405c957ea6; xorp/policy/common/Makefile.in 1.8 +71 -71; commitid: 139cf43405c957ea6; xorp/policy/common/dispatcher.cc 1.6 +53 -43; commitid: 139cf43405c957ea6; xorp/policy/common/dispatcher.hh 1.1 +26 -0 xorp/policy/common/elem_bgp.hh (new) 1.1 +45 -0 xorp/policy/common/elem_filter.hh (new) 1.4 +8 -3; commitid: 139cf43405c957ea6; xorp/policy/common/elem_null.hh 1.8 +30 -4; commitid: 139cf43405c957ea6; xorp/policy/common/elem_set.cc 1.7 +8 -1; commitid: 139cf43405c957ea6; xorp/policy/common/elem_set.hh 1.6 +32 -4; commitid: 139cf43405c957ea6; xorp/policy/common/element.cc 1.7 +174 -40; commitid: 139cf43405c957ea6; xorp/policy/common/element.hh 1.3 +6 -17; commitid: 139cf43405c957ea6; xorp/policy/common/element_base.hh 1.1 +45 -0 xorp/policy/common/operator.cc (new) 1.5 +10 -11; commitid: 139cf43405c957ea6; xorp/policy/common/operator.hh 1.3 +9 -1; commitid: 139cf43405c957ea6; xorp/policy/common/operator_base.hh 1.8 +4 -1; commitid: 139cf43405c957ea6; xorp/policy/common/register_elements.cc 1.14 +67 -1; commitid: 139cf43405c957ea6; xorp/policy/common/register_operations.cc 1.5 +10 -4; commitid: 139cf43405c957ea6; xorp/policy/common/varrw.cc 1.7 +22 -7; commitid: 139cf43405c957ea6; xorp/policy/common/varrw.hh 1.10 +5 -3; commitid: 139cf43405c957ea6; xorp/policy/configuration.cc 1.8 +4 -2; commitid: 139cf43405c957ea6; xorp/policy/configuration.hh 1.6 +7 -6; commitid: 139cf43405c957ea6; xorp/policy/export_code_generator.cc 1.4 +4 -2; commitid: 139cf43405c957ea6; xorp/policy/export_code_generator.hh 1.5 +2 -2; commitid: 139cf43405c957ea6; xorp/policy/filter_manager.cc 1.6 +3 -2; commitid: 139cf43405c957ea6; xorp/policy/node.hh 1.5 +6 -6; commitid: 139cf43405c957ea6; xorp/policy/policy_list.cc 1.9 +5 -3; commitid: 139cf43405c957ea6; xorp/policy/policy_target.cc 1.8 +5 -2; commitid: 139cf43405c957ea6; xorp/policy/policy_target.hh 1.5 +4 -3; commitid: 139cf43405c957ea6; xorp/policy/semantic_varrw.cc 1.3 +4 -4; commitid: 139cf43405c957ea6; xorp/policy/semantic_varrw.hh 1.7 +13 -5; commitid: 139cf43405c957ea6; xorp/policy/source_match_code_generator.cc 1.5 +6 -2; commitid: 139cf43405c957ea6; xorp/policy/source_match_code_generator.hh 1.8 +7 -9; commitid: 139cf43405c957ea6; xorp/policy/test/compilepolicy.cc 1.5 +12 -7; commitid: 139cf43405c957ea6; xorp/policy/test/file_varrw.cc 1.3 +5 -11; commitid: 139cf43405c957ea6; xorp/policy/test/file_varrw.hh 1.4 +2 -2; commitid: 139cf43405c957ea6; xorp/policy/test/policy1.var 1.4 +3 -3; commitid: 139cf43405c957ea6; xorp/policy/test/policy2.var 1.3 +28 -28; commitid: 139cf43405c957ea6; xorp/policy/test/policyvarmap.conf 1.7 +60 -30; commitid: 139cf43405c957ea6; xorp/policy/var_map.cc 1.5 +26 -26; commitid: 139cf43405c957ea6; xorp/policy/var_map.hh 1.5 +1 -2; commitid: 139cf43405c957ea6; xorp/policy/visitor.hh 1.9 +23 -7; commitid: 139cf43405c957ea6; xorp/policy/visitor_semantic.cc 1.5 +8 -3; commitid: 139cf43405c957ea6; xorp/policy/visitor_semantic.hh 1.9 +4 -3; commitid: 139cf43405c957ea6; xorp/policy/xrl_target.cc 1.7 +3 -2; commitid: 139cf43405c957ea6; xorp/policy/xrl_target.hh 1.8 +14 -16; commitid: 139cf43405c957ea6; xorp/rib/rib_varrw.cc 1.7 +11 -6; commitid: 139cf43405c957ea6; xorp/rib/rib_varrw.hh 1.7 +21 -21; commitid: 139cf43405c957ea6; xorp/rip/rip_varrw.cc 1.7 +13 -4; commitid: 139cf43405c957ea6; xorp/rip/rip_varrw.hh 1.7 +14 -14; commitid: 139cf43405c957ea6; xorp/static_routes/static_routes_varrw.cc 1.6 +10 -3; commitid: 139cf43405c957ea6; xorp/static_routes/static_routes_varrw.hh 1.7 +4 -2; commitid: 139cf43405c957ea6; xorp/xrl/interfaces/policy.xif 1.9 +3 -1; commitid: 139cf43405c957ea6; xorp/xrl/interfaces/policy_xif.cc 1.8 +4 -1; commitid: 139cf43405c957ea6; xorp/xrl/interfaces/policy_xif.hh 1.9 +4 -2; commitid: 139cf43405c957ea6; xorp/xrl/targets/policy.xrls 1.9 +5 -4; commitid: 139cf43405c957ea6; xorp/xrl/targets/policy_base.cc 1.9 +5 -2; commitid: 139cf43405c957ea6; xorp/xrl/targets/policy_base.hh From pavlin@icir.org Mon Oct 3 05:49:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 3 Oct 2005 04:49:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510030449.j934nOmj085221@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-03 04:49:24 UTC XORP CVS repository Modified files: libxorp run_command.cc Log message: Print a better error message if there is an error. Revision Changes Path 1.9 +16 -2; commitid: 14ccc4340b8497ea6; xorp/libxorp/run_command.cc From pavlin@icir.org Mon Oct 3 06:05:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 3 Oct 2005 05:05:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510030505.j9355koX085511@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-03 05:05:46 UTC XORP CVS repository Modified files: libxorp asyncio.cc buffered_asyncio.cc selector.cc Log message: Reset errno before a system call or explicitly check that the system call failed before attempting to use errno. Otherwise, if the system call succeeded we may be reusing an obsolete value of errno (from the last system call that failed). This (probably) fixes bugzilla entry #224 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=224 Revision Changes Path 1.21 +3 -2; commitid: 14daa4340bb927ea6; xorp/libxorp/asyncio.cc 1.8 +2 -1; commitid: 14daa4340bb927ea6; xorp/libxorp/buffered_asyncio.cc 1.29 +2 -3; commitid: 14daa4340bb927ea6; xorp/libxorp/selector.cc From atanu@icir.org Mon Oct 3 19:34:33 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 3 Oct 2005 18:34:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510031834.j93IYX7a097270@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-03 18:34:33 UTC XORP CVS repository Modified files: bgp peer.cc Log message: The still connected assert was being triggered in the AcceptSession destructor, which as the very least catches a file descriptor being leaked. If the connection is closed while waiting from an open from the peer the socket is now disconnected. Problem caught in load tests on xorp12. Revision Changes Path 1.97 +2 -1; commitid: 17bdb434179b87ea6; xorp/bgp/peer.cc From atanu@icir.org Mon Oct 3 21:24:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 3 Oct 2005 20:24:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510032024.j93KO7XI098490@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-03 20:24:07 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: XRL support for adding/deleting/changing area ranges, plus requesting LSAs. Revision Changes Path 1.100 +34 -3; commitid: 1805f434193637ea6; xorp/ospf/area_router.cc 1.60 +28 -2; commitid: 1805f434193637ea6; xorp/ospf/area_router.hh 1.40 +31 -1; commitid: 1805f434193637ea6; xorp/ospf/ospf.cc 1.51 +17 -1; commitid: 1805f434193637ea6; xorp/ospf/ospf.hh 1.52 +56 -2; commitid: 1805f434193637ea6; xorp/ospf/peer_manager.cc 1.36 +16 -2; commitid: 1805f434193637ea6; xorp/ospf/peer_manager.hh 1.8 +70 -1; commitid: 1805f434193637ea6; xorp/ospf/xrl_target.cc 1.7 +52 -1; commitid: 1805f434193637ea6; xorp/ospf/xrl_target.hh 1.4 +43 -1; commitid: 1805f434193637ea6; xorp/xrl/interfaces/ospfv2.xif 1.5 +153 -1; commitid: 1805f434193637ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.5 +93 -1; commitid: 1805f434193637ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.6 +34 -1; commitid: 1805f434193637ea6; xorp/xrl/targets/ospfv2.xrls 1.6 +147 -1; commitid: 1805f434193637ea6; xorp/xrl/targets/ospfv2_base.cc 1.6 +68 -1; commitid: 1805f434193637ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Mon Oct 3 22:10:32 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 3 Oct 2005 21:10:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510032110.j93LAWT7099015@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-03 21:10:32 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Add the ability to configure of area ranges. Plus fix a typo in a help string. Revision Changes Path 1.7 +24 -2; commitid: 182ac43419e477ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Tue Oct 4 00:07:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 3 Oct 2005 23:07:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510032307.j93N79Ff000373@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-03 23:07:09 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow the toggling of the advertise state. Bug found by: Pavlin Radoslavov Revision Changes Path 1.8 +2 -5; commitid: 15a4341b99c7ea6; xorp/etc/templates/ospfv2.tp From pavlin@icir.org Tue Oct 4 00:33:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 3 Oct 2005 23:33:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/mibs Message-ID: <200510032333.j93NXnX1000656@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-03 23:33:49 UTC XORP CVS repository Modified files: . configure.in configure mibs configure configure.in Log message: Add --disable-compiler-pipe as a ./configure option so the compiler's "-pipe" option can be optionally disabled. This fixes bugzilla entry #248 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=248 Revision Changes Path 1.159 +14 -3; commitid: 25b4341bf167ea6; xorp/configure 1.143 +15 -4; commitid: 25b4341bf167ea6; xorp/configure.in 1.23 +14 -3; commitid: 25b4341bf167ea6; xorp/mibs/configure 1.12 +15 -4; commitid: 25b4341bf167ea6; xorp/mibs/configure.in From atanu@icir.org Tue Oct 4 05:11:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 04:11:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510040411.j944BZOo005573@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 04:11:35 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Some state related to stub areas; should summaries be introduced into stub areas and the stub default cost. Revision Changes Path 1.101 +2 -1; commitid: 15a8434200f67ea6; xorp/ospf/area_router.cc 1.61 +6 -1; commitid: 15a8434200f67ea6; xorp/ospf/area_router.hh From pavlin@icir.org Tue Oct 4 07:08:19 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 4 Oct 2005 06:08:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510040608.j9468JN7006867@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-04 06:08:19 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree.cc conf_tree_node.cc conf_tree_node.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_tree_node.cc template_tree_node.hh Log message: * Add support for read-only configuration/template nodes. If a template node is marked as: %read-only:; OR %read-only: "Optional reason for the node being read-only"; then its value (in case of a leaf node that contains a value) cannot be changed from the default template value. If a non-leaf node is marked as read-only, then its children (and the children's children) can be modified. However, it is unclear what exactly a read-only non-leaf node means. Currently, a read-only non-leaf node can be added as part of the initial configuration, but that node itself cannot be deleted or added later via xorpsh. * Allow to see the value of a leaf node (only) inside xorpsh by specifying the path to that node. Now we can see the node even if it has a default value. Revision Changes Path 1.96 +79 -23; commitid: 19a0434215107ea6; xorp/rtrmgr/cli.cc 1.44 +9 -1; commitid: 19a0434215107ea6; xorp/rtrmgr/conf_tree.cc 1.87 +80 -17; commitid: 19a0434215107ea6; xorp/rtrmgr/conf_tree_node.cc 1.49 +4 -1; commitid: 19a0434215107ea6; xorp/rtrmgr/conf_tree_node.hh 1.25 +26 -16; commitid: 19a0434215107ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.17 +5 -3; commitid: 19a0434215107ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.61 +27 -4; commitid: 19a0434215107ea6; xorp/rtrmgr/template_tree_node.cc 1.37 +7 -1; commitid: 19a0434215107ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Tue Oct 4 07:48:18 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 4 Oct 2005 06:48:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200510040648.j946mIgB007469@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-04 06:48:18 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: * Add a subsection that describes the new %read-only command. * Move an example for the %allow-range command inside the subsection that describes that command. * Fix a compilation error. Revision Changes Path 1.41 +41 -17; commitid: 1d0f4342257d7ea6; xorp/docs/rtrmgr/rtrmgr.tex From pavlin@icir.org Tue Oct 4 07:49:59 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 4 Oct 2005 06:49:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510040649.j946nxn2007508@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-04 06:49:59 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Add a release note for the new %read-only rtrmgr template command. Revision Changes Path 1.84 +4 -1; commitid: 1d3b434226027ea6; xorp/RELEASE_NOTES From atanu@icir.org Tue Oct 4 18:13:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 17:13:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510041713.j94HDZAg016091@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 17:13:35 UTC XORP CVS repository Modified files: ospf area_router.cc routing_table.cc routing_table.hh Log message: The RouteEntry now has methods to access it fields allows some sanity checks on which fields can be accessed. Delete route now takes the RouteEntry as an argument to pass onto the summarisation code. Revision Changes Path 1.102 +51 -49; commitid: 3ebc4342b83d7ea6; xorp/ospf/area_router.cc 1.12 +16 -12; commitid: 3ebc4342b83d7ea6; xorp/ospf/routing_table.cc 1.13 +129 -18; commitid: 3ebc4342b83d7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Tue Oct 4 18:19:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 17:19:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510041719.j94HJsBr016240@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 17:19:54 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: The original RouteEntry is provided even when withdrawing a summary to allow the peer_manager to detect if the route was a candidate for summarisation. The routes are also going to be stored in the peer manager. Thus when new areas are introduced the summarisation information can be fed into the new area. Also if a stub area that was previously not performing summarisation changes state all the route can be fed to the area on demand. Revision Changes Path 1.53 +22 -2; commitid: 3f534342b9b97ea6; xorp/ospf/peer_manager.cc 1.37 +20 -2; commitid: 3f534342b9b97ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Tue Oct 4 20:14:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 19:14:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510041914.j94JEKxi017559@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 19:14:20 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: The summary_candidate method now selects routes that are candidate for summarisation. Revision Changes Path 1.54 +25 -2; commitid: 447c4342d48b7ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Tue Oct 4 20:16:56 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 19:16:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510041916.j94JGuEH017665@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 19:16:56 UTC XORP CVS repository Modified files: ospf area_router.hh Log message: Fix typo in comment. Revision Changes Path 1.62 +2 -2; commitid: 44e64342d5277ea6; xorp/ospf/area_router.hh From atanu@icir.org Tue Oct 4 20:25:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 19:25:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510041925.j94JPtbH017818@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 19:25:55 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Stubs for accepting summary information into an area. Revision Changes Path 1.103 +29 -2; commitid: 457d4342d7427ea6; xorp/ospf/area_router.cc 1.63 +16 -1; commitid: 457d4342d7427ea6; xorp/ospf/area_router.hh From pavlin@icir.org Tue Oct 4 23:26:33 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 4 Oct 2005 22:26:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510042226.j94MQXwo019435@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-04 22:26:33 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Add a top-level %help string for ospf4 Revision Changes Path 1.9 +2 -1; commitid: 4bca434301837ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Wed Oct 5 00:04:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 4 Oct 2005 23:04:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510042304.j94N40uQ019882@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-04 23:04:00 UTC XORP CVS repository Modified files: etc/templates Makefile.am Makefile.in Removed files: etc/templates ospf.tp Log message: Remove the template file for the old OSPF. Revision Changes Path 1.16 +1 -2; commitid: 4d8b43430a3d7ea6; xorp/etc/templates/Makefile.am 1.24 +1 -1; commitid: 4d8b43430a3d7ea6; xorp/etc/templates/Makefile.in 1.18 +0 -133 xorp/etc/templates/ospf.tp (dead) From atanu@icir.org Wed Oct 5 01:30:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 5 Oct 2005 00:30:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510050030.j950UjNY020791@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-05 00:30:45 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Store the summary route information and only forward to the areas if the router is an area border router. Revision Changes Path 1.55 +16 -1; commitid: 511a43431eb47ea6; xorp/ospf/peer_manager.cc 1.38 +7 -1; commitid: 511a43431eb47ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Wed Oct 5 01:56:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 5 Oct 2005 00:56:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510050056.j950ulWU021075@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-05 00:56:47 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: Propagate route information to the area if the router is an area border router. Revision Changes Path 1.56 +9 -4; commitid: 5238434324ce7ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Wed Oct 5 04:16:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 5 Oct 2005 03:16:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510050316.j953GLQI022590@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-05 03:16:21 UTC XORP CVS repository Modified files: ospf TODO area_router.cc area_router.hh ospf.hh peer_manager.cc peer_manager.hh Log message: An area can now request all routes that are candidates for summarisation from the peer manager. Added a class Subsystem that has start() and shutdown() methods that can be called by the peer manager to start and shutdown an area. The request for the routes to summarise is made in start() method of an area. Revision Changes Path 1.53 +10 -1; commitid: 5819434345847ea6; xorp/ospf/TODO 1.104 +28 -3; commitid: 5819434345847ea6; xorp/ospf/area_router.cc 1.64 +24 -2; commitid: 5819434345847ea6; xorp/ospf/area_router.hh 1.52 +47 -1; commitid: 5819434345847ea6; xorp/ospf/ospf.hh 1.57 +32 -2; commitid: 5819434345847ea6; xorp/ospf/peer_manager.cc 1.39 +15 -2; commitid: 5819434345847ea6; xorp/ospf/peer_manager.hh From pavlin@icir.org Wed Oct 5 06:48:58 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 5 Oct 2005 05:48:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510050548.j955mw9G024115@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-05 05:48:58 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree_node.cc conf_tree_node.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_tree_node.cc template_tree_node.hh Log message: * Change the semantic for %read-only so it applies only for leaf nodes that have values. * Add support for new template keyword %permanent. A node marked %permanent cannot be deleted directly. However, deleting the parent of a parent node will delete the permanent node as well. Also, adding or deleting children of a permanent node is allowed. Revision Changes Path 1.97 +62 -66; commitid: 5d6f434365c87ea6; xorp/rtrmgr/cli.cc 1.88 +19 -1; commitid: 5d6f434365c87ea6; xorp/rtrmgr/conf_tree_node.cc 1.50 +3 -1; commitid: 5d6f434365c87ea6; xorp/rtrmgr/conf_tree_node.hh 1.26 +41 -32; commitid: 5d6f434365c87ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.18 +5 -3; commitid: 5d6f434365c87ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.62 +36 -6; commitid: 5d6f434365c87ea6; xorp/rtrmgr/template_tree_node.cc 1.38 +6 -1; commitid: 5d6f434365c87ea6; xorp/rtrmgr/template_tree_node.hh From pavlin@icir.org Wed Oct 5 07:00:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 5 Oct 2005 06:00:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510050600.j9560T04024281@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-05 06:00:29 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Comment-out code that was uncommented by accident by the previous commit. Revision Changes Path 1.98 +2 -2; commitid: 5ea943436bb07ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Wed Oct 5 07:12:03 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 5 Oct 2005 06:12:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200510050612.j956C3cK024467@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-05 06:12:03 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: * Change the description for the %read-only template command to reflect the fact that now this command applies only for leaf nodes that can have values. * Add description for the new %permanent template command. Revision Changes Path 1.42 +26 -8; commitid: 5f5b43436e2c7ea6; xorp/docs/rtrmgr/rtrmgr.tex From pavlin@icir.org Wed Oct 5 07:14:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 5 Oct 2005 06:14:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510050614.j956Egwu024526@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-05 06:14:42 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Mention the new %permanent template command in the release nodes. Revision Changes Path 1.85 +3 -3; commitid: 5fb043436f3f7ea6; xorp/RELEASE_NOTES From pavlin@icir.org Wed Oct 5 07:29:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 5 Oct 2005 06:29:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/rtrmgr Message-ID: <200510050629.j956Thwv024788@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-05 06:29:43 UTC XORP CVS repository Modified files: docs/rtrmgr rtrmgr.tex Log message: Add extra info for permanent nodes. Revision Changes Path 1.43 +4 -1; commitid: 60b4434372c57ea6; xorp/docs/rtrmgr/rtrmgr.tex From pavlin@icir.org Thu Oct 6 01:33:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 6 Oct 2005 00:33:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510060033.j960Xvx5078268@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-06 00:33:57 UTC XORP CVS repository Modified files: etc/templates static_routes.tp Log message: Change the static routes' metric range from 0--65535 to 1--65535 (for consistency with Juniper). Bug found by: Michael Larson Revision Changes Path 1.25 +9 -9; commitid: 1319d434470b77ea6; xorp/etc/templates/static_routes.tp From atanu@icir.org Thu Oct 6 04:17:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 03:17:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060317.j963He4Q079822@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 03:17:40 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: If an area is removed then all it routes need to be withdrawn and all other areas need to be informed so Summary-LSAs can be removed. A method remove_area() has been added that be called to initiate these actions. A transaction variable has been added to verify that routes are only added or replaced during a transaction. The reset_winner() method has been rewritten to handle the case of no routes. An new method empty() that allows the detection of no routes. Revision Changes Path 1.13 +50 -5; commitid: 137b1434497537ea6; xorp/ospf/routing_table.cc 1.14 +33 -2; commitid: 137b1434497537ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Thu Oct 6 07:04:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 6 Oct 2005 06:04:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510060604.j9664YFP081459@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-06 06:04:34 UTC XORP CVS repository Modified files: etc/templates misc.cmds Log message: Redirect the ping's stderr to stdout, in case some implementations of ping print some output to stderr. Requested by: "Michael Larson" Revision Changes Path 1.5 +7 -3; commitid: 13e1a4344be4e7ea6; xorp/etc/templates/misc.cmds From atanu@icir.org Thu Oct 6 08:23:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 07:23:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060723.j967NEXG082492@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 07:23:14 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: If the routing table is empty don't try and access its contents. Revision Changes Path 1.14 +4 -1; commitid: 142214344d0e27ea6; xorp/ospf/routing_table.cc From atanu@icir.org Thu Oct 6 08:24:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 07:24:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060724.j967OJ6s082545@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 07:24:19 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When an area is being shutdown it now notifies the routing table which can remove routes from this area and notify the other areas. Revision Changes Path 1.105 +2 -1; commitid: 142564344d1227ea6; xorp/ospf/area_router.cc From atanu@icir.org Thu Oct 6 08:38:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 07:38:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060738.j967cdis082779@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 07:38:39 UTC XORP CVS repository Modified files: ospf peer_manager.cc Log message: When withdrawing a summary don't bother to check if the router is still an area border router, if it was one in the past its important that the withdraws from the old area make it through. Revision Changes Path 1.58 +8 -3; commitid: 143404344d47f7ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Thu Oct 6 09:16:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 08:16:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060816.j968GfLR083294@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 08:16:41 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Add support for longest match lookup in the routing table required by the summary generation code. Revision Changes Path 1.15 +19 -1; commitid: 145414344dd687ea6; xorp/ospf/routing_table.cc 1.15 +12 -1; commitid: 145414344dd687ea6; xorp/ospf/routing_table.hh From atanu@icir.org Thu Oct 6 10:22:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 6 Oct 2005 09:22:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510060922.j969MwpQ084022@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-06 09:22:58 UTC XORP CVS repository Modified files: ospf area_router.hh Log message: A method backbone() that returns true if this area is the backbone. Methods to set and get the transit capability of this area. Revision Changes Path 1.65 +19 -1; commitid: 1481b4344ecf17ea6; xorp/ospf/area_router.hh From atanu@icir.org Fri Oct 7 08:09:11 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 7 Oct 2005 07:09:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510070709.j9779B3I003612@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-07 07:09:11 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Build Summary-LSAs. Revision Changes Path 1.106 +205 -4; commitid: dff43461f167ea6; xorp/ospf/area_router.cc 1.66 +23 -1; commitid: dff43461f167ea6; xorp/ospf/area_router.hh From atanu@icir.org Fri Oct 7 23:30:09 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 7 Oct 2005 22:30:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510072230.j97MU9sq025825@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-07 22:30:08 UTC XORP CVS repository Modified files: ospf area_router.cc routing_table.cc routing_table.hh Log message: The routing table can handle receiving routes from multiple areas. Previously at the start of a transaction all routes could be removed from that table, now the routes from other areas may be present they are preserved. Revision Changes Path 1.107 +2 -2; commitid: 64b14346f6ef7ea6; xorp/ospf/area_router.cc 1.16 +25 -2; commitid: 64b14346f6ef7ea6; xorp/ospf/routing_table.cc 1.16 +2 -2; commitid: 64b14346f6ef7ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Mon Oct 10 05:10:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 04:10:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/rtrmgr Message-ID: <200510100410.j9A4Aq4U057734@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 04:10:52 UTC XORP CVS repository Modified files: libxorp utils.hh utils.cc rtrmgr cli.cc conf_tree.cc conf_tree_node.cc main_rtrmgr.cc op_commands.cc template_commands.cc template_tree.cc template_tree_node.cc util.cc util.hh xorpsh_main.cc Log message: * Move the implementation of split() and xorp_basename() from rtrmgr/util.{hh,cc} to libxorp/utils.{hh,cc} so it can be used by the rest of the XORP code. * Update the implementation of xorp_basename() to use the OS-independent PATH_DELIMITER_CHAR instead of the hardcoded '/'. Revision Changes Path 1.5 +30 -1; commitid: e1244349e9567ea6; xorp/libxorp/utils.cc 1.9 +18 -1; commitid: e1244349e9567ea6; xorp/libxorp/utils.hh 1.99 +2 -2; commitid: e1244349e9567ea6; xorp/rtrmgr/cli.cc 1.45 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/conf_tree.cc 1.89 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/conf_tree_node.cc 1.65 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/main_rtrmgr.cc 1.57 +2 -2; commitid: e1244349e9567ea6; xorp/rtrmgr/op_commands.cc 1.61 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/template_commands.cc 1.39 +2 -2; commitid: e1244349e9567ea6; xorp/rtrmgr/template_tree.cc 1.63 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/template_tree_node.cc 1.19 +1 -30; commitid: e1244349e9567ea6; xorp/rtrmgr/util.cc 1.11 +1 -18; commitid: e1244349e9567ea6; xorp/rtrmgr/util.hh 1.53 +2 -1; commitid: e1244349e9567ea6; xorp/rtrmgr/xorpsh_main.cc From atanu@icir.org Mon Oct 10 05:38:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 04:38:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100438.j9A4cwS5058137@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 04:38:58 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Allow a route entry to be marked as a discard route. Revision Changes Path 1.17 +11 -1; commitid: e2fe4349f0627ea6; xorp/ospf/routing_table.hh From atanu@icir.org Mon Oct 10 05:40:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 04:40:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100440.j9A4exDc058219@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 04:40:59 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Allow the configuring of area ranges and compute discard routes if appropriate. Revision Changes Path 1.108 +111 -4; commitid: e34e4349f0d97ea6; xorp/ospf/area_router.cc 1.67 +14 -2; commitid: e34e4349f0d97ea6; xorp/ospf/area_router.hh From pavlin@icir.org Mon Oct 10 05:50:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 04:50:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/fea xorp/libxorp xorp/rtrmgr Message-ID: <200510100450.j9A4ooYF058446@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 04:50:50 UTC XORP CVS repository Modified files: etc/templates misc.cmds fea click_socket.cc click_socket.hh ifconfig_set.hh ifconfig_set_click.cc libxorp popen.cc popen.hh run_command.cc run_command.hh test_run_command.cc rtrmgr op_commands.cc op_commands.hh op_commands.yy task.cc task.hh y.opcmd_tab.cc Log message: * Modify the popen2() implementation so now it executes directly the command rather than running it via "sh -c". * Modify the popen2() API: - supply the arguments as a list of strings - add an extra flag "redirect_stderr_to_stdout" to specify whether the stderr should be redirected to stdout. * Apply few fixes to popen2(): use _exit(127) instead of exit(127), set the sockets in non-buffered mode, etc. * Refactor the implementation of class RunCommand: - Use the new popen2() implementation, so now class RunCommand is used to execute the command directly rather than via "sh -c" - Add a new class RunShellCommand that executes a command via "sh -c". * Update test_run_command.cc to reflect the above changes. Also, add additional testing. * Update the rest of the XORP code to use either the modified RunCommand or the new RunShellCommand. Basically, the FEA and the xorpsh operational commands use RunCommand, while the execution of configurational commands defined inside the rtrmgr *.tp use RunShellCommand. The reason the operational commands are executed directly is to prevent the user from sneaking-in extra commands (e.g., see Bugzilla entry 219). The reason the configurational commands are still executed via "sh -c" is to preserve the configurational flexibility (e.g., running more than one command, etc). This fixes bugzilla entry #219 * Now the stderr of all operational commands is redirected to stdout and printed inside the xorpsh. The reason is because some commands (e.g., ping and traceroute) print some of the result on stderr instead of stdout. Note that the redirection is done inside popen2() otherwise the stdout and stderr output may appear out-of-order inside xorpsh. * Remove the explicit stderr to stdout redirection inside the misc.cmds because it is not needed anymore (now the stderr to stdout redirection is enabled by default for all operational commands. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=219 Revision Changes Path 1.6 +7 -3; commitid: e2034349eadb7ea6; xorp/etc/templates/misc.cmds 1.27 +21 -10; commitid: e2034349eadb7ea6; xorp/fea/click_socket.cc 1.20 +3 -3; commitid: e2034349eadb7ea6; xorp/fea/click_socket.hh 1.39 +2 -2; commitid: e2034349eadb7ea6; xorp/fea/ifconfig_set.hh 1.29 +7 -4; commitid: e2034349eadb7ea6; xorp/fea/ifconfig_set_click.cc 1.6 +98 -36; commitid: e2034349eadb7ea6; xorp/libxorp/popen.cc 1.4 +6 -2; commitid: e2034349eadb7ea6; xorp/libxorp/popen.hh 1.10 +73 -36; commitid: e2034349eadb7ea6; xorp/libxorp/run_command.cc 1.7 +208 -25; commitid: e2034349eadb7ea6; xorp/libxorp/run_command.hh 1.8 +124 -31; commitid: e2034349eadb7ea6; xorp/libxorp/test_run_command.cc 1.58 +33 -26; commitid: e2034349eadb7ea6; xorp/rtrmgr/op_commands.cc 1.33 +9 -8; commitid: e2034349eadb7ea6; xorp/rtrmgr/op_commands.hh 1.15 +6 -6; commitid: e2034349eadb7ea6; xorp/rtrmgr/op_commands.yy 1.54 +25 -25; commitid: e2034349eadb7ea6; xorp/rtrmgr/task.cc 1.34 +36 -34; commitid: e2034349eadb7ea6; xorp/rtrmgr/task.hh 1.23 +6 -6; commitid: e2034349eadb7ea6; xorp/rtrmgr/y.opcmd_tab.cc From atanu@icir.org Mon Oct 10 06:04:11 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 05:04:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100504.j9A54BPI058658@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 05:04:11 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Remove the function summary_address_range() which was a placeholder until area ranges were supported. Replace calls to summary_addresss_range() with calls to area_range_covered(). Revision Changes Path 1.109 +2 -18; commitid: e5074349f64a7ea6; xorp/ospf/area_router.cc From atanu@icir.org Mon Oct 10 06:12:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 05:12:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100512.j9A5Ck8S058821@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 05:12:46 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Print a warning when an attempt is made to install a discard route. Revision Changes Path 1.17 +16 -4; commitid: e5a84349f84d7ea6; xorp/ospf/routing_table.cc 1.18 +2 -2; commitid: e5a84349f84d7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Mon Oct 10 06:44:57 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 05:44:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100544.j9A5ivvC059272@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 05:44:57 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh peer_manager.cc Log message: Summary_announce now takes a push flag so that an ordinary announce can be distinguished from a summary push. Revision Changes Path 1.110 +4 -4; commitid: e7694349ffd87ea6; xorp/ospf/area_router.cc 1.68 +8 -2; commitid: e7694349ffd87ea6; xorp/ospf/area_router.hh 1.59 +3 -3; commitid: e7694349ffd87ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Mon Oct 10 07:03:25 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 06:03:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100603.j9A63PNo059596@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 06:03:25 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Look up area ranges via the peer manager. Revision Changes Path 1.60 +17 -2; commitid: e8af434a042c7ea6; xorp/ospf/peer_manager.cc 1.40 +14 -1; commitid: e8af434a042c7ea6; xorp/ospf/peer_manager.hh From pavlin@icir.org Mon Oct 10 07:15:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 06:15:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510100615.j9A6FbPQ059780@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 06:15:37 UTC XORP CVS repository Modified files: etc/templates misc.cmds Log message: * Remove a test command that was committed by accident by the previous commit. * Remove comments that are obsolete. Revision Changes Path 1.7 +1 -15; commitid: e950434a06df7ea6; xorp/etc/templates/misc.cmds From atanu@icir.org Mon Oct 10 08:01:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 07:01:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100701.j9A71TfG060422@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 07:01:29 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Summary-LSAs for all path type can now be constructed. Use a common routine building network Summary-LSAs. The announce flag is no longer passed into the summary build routines but passed out to flag if a summary should be announced. Revision Changes Path 1.111 +61 -35; commitid: ebe9434a11c87ea6; xorp/ospf/area_router.cc 1.69 +10 -3; commitid: ebe9434a11c87ea6; xorp/ospf/area_router.hh From pavlin@icir.org Mon Oct 10 08:05:53 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 07:05:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510100705.j9A75rWR060539@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 07:05:53 UTC XORP CVS repository Modified files: rtrmgr op_commands.cc op_commands.hh op_commands.yy y.opcmd_tab.cc Log message: If the binary for an operational command specified in an *.cmds template file is not found, then just print a warning and don't add the corresponding command to the operational command tree. Previously, the xorpsh printed an error but refused to start. Revision Changes Path 1.59 +3 -2; commitid: ec43434a12647ea6; xorp/rtrmgr/op_commands.cc 1.34 +5 -1; commitid: ec43434a12647ea6; xorp/rtrmgr/op_commands.hh 1.16 +47 -32; commitid: ec43434a12647ea6; xorp/rtrmgr/op_commands.yy 1.24 +49 -34; commitid: ec43434a12647ea6; xorp/rtrmgr/y.opcmd_tab.cc From pavlin@icir.org Mon Oct 10 08:14:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 07:14:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510100714.j9A7EQoD060721@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 07:14:26 UTC XORP CVS repository Modified files: etc/templates misc.cmds Log message: Add ping6 and traceroute6 operational commands. Requested by: Tim Durack Revision Changes Path 1.8 +17 -1; commitid: ed18434a148e7ea6; xorp/etc/templates/misc.cmds From atanu@icir.org Mon Oct 10 09:31:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 08:31:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100831.j9A8Vg1b061888@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 08:31:42 UTC XORP CVS repository Modified files: ospf routing_table.cc Log message: Assert that the area field in the RouteEntry and the area that originated a route match. Revision Changes Path 1.18 +2 -1; commitid: f1a5434a26ed7ea6; xorp/ospf/routing_table.cc From atanu@icir.org Mon Oct 10 09:47:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 08:47:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100847.j9A8lSdf062218@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 08:47:28 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Set the originating area in the route entry. Revision Changes Path 1.112 +3 -2; commitid: f2ef434a2a9f7ea6; xorp/ospf/area_router.cc From atanu@icir.org Mon Oct 10 10:39:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 09:39:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510100939.j9A9dcfS063858@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 09:39:38 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Announce and withdraw Summary-LSAs. Revision Changes Path 1.113 +91 -8; commitid: f955434a36d87ea6; xorp/ospf/area_router.cc 1.70 +7 -1; commitid: f955434a36d87ea6; xorp/ospf/area_router.hh From atanu@icir.org Mon Oct 10 11:01:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 10:01:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510101001.j9AA1laa064403@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 10:01:47 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Minor refactoring to split Point2Multipoint from Virtual Link and NBMA. Revision Changes Path 1.161 +12 -1; commitid: fb78434a3c097ea6; xorp/ospf/peer.cc From atanu@icir.org Mon Oct 10 13:20:45 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:20:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510101220.j9ACKj1e066509@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:20:45 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/ospf/tools added to the repository From atanu@icir.org Mon Oct 10 13:21:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:21:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/ospf/tools Message-ID: <200510101221.j9ACLTjP066609@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:21:29 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc Added files: ospf/tools Makefile.am print_lsas.cc Log message: Support for printing LSAs. Revision Changes Path 1.114 +31 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/area_router.cc 1.71 +7 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/area_router.hh 1.41 +11 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/ospf.cc 1.53 +16 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/ospf.hh 1.61 +19 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/peer_manager.cc 1.41 +16 -1; commitid: 103f3434a5cc57ea6; xorp/ospf/peer_manager.hh 1.1 +41 -0 xorp/ospf/tools/Makefile.am (new) 1.1 +183 -0 xorp/ospf/tools/print_lsas.cc (new) 1.9 +5 -2; commitid: 103f3434a5cc57ea6; xorp/ospf/xrl_target.cc From atanu@icir.org Mon Oct 10 13:40:33 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:40:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510101240.j9ACeXhe066990@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:40:33 UTC XORP CVS repository Added files: etc/templates ospfv2.cmds Log message: Enable database command for OSPFv2. Revision Changes Path 1.1 +12 -0 xorp/etc/templates/ospfv2.cmds (new) From atanu@icir.org Mon Oct 10 13:50:11 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:50:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510101250.j9ACoBsN067287@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:50:11 UTC XORP CVS repository Modified files: . configure configure.in Log message: Add the Makefile for the OSPF tools directory. Revision Changes Path 1.160 +3 -2; commitid: 106ba434a63807ea6; xorp/configure 1.144 +3 -2; commitid: 106ba434a63807ea6; xorp/configure.in From atanu@icir.org Mon Oct 10 13:53:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:53:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510101253.j9ACr50D067388@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:53:05 UTC XORP CVS repository Added files: ospf/tools Makefile.in Log message: Add the Makefile for the OSPF tools directory. Revision Changes Path 1.1 +433 -0 xorp/ospf/tools/Makefile.in (new) From atanu@icir.org Mon Oct 10 13:59:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 12:59:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510101259.j9ACxcYg067540@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 12:59:38 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in Log message: Add the Makefile for the OSPF tools directory. Revision Changes Path 1.18 +2 -2; commitid: 107b7434a65b97ea6; xorp/ospf/Makefile.am 1.15 +1 -1; commitid: 107b7434a65b97ea6; xorp/ospf/Makefile.in From atanu@icir.org Mon Oct 10 14:19:02 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 10 Oct 2005 13:19:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510101319.j9ADJ2vj067876@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-10 13:19:02 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Too high was being set incorrectly as a consquence only the first LSA was being requested. Revision Changes Path 1.115 +5 -3; commitid: 10909434a6a457ea6; xorp/ospf/area_router.cc From pavlin@icir.org Mon Oct 10 18:01:56 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 17:01:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510101701.j9AH1umO071965@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 17:01:56 UTC XORP CVS repository Added files: ospf/tools .cvsignore Log message: Add .cvsignore that lists the files ignored by CVS. Revision Changes Path 1.1 +8 -0 xorp/ospf/tools/.cvsignore (new) From pavlin@icir.org Mon Oct 10 18:04:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 17:04:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510101704.j9AH4TIi072036@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 17:04:29 UTC XORP CVS repository Modified files: etc/templates Makefile.am Makefile.in Log message: Add ospfv2.cmds to the Makefile Revision Changes Path 1.17 +2 -2; commitid: 11949434a9f057ea6; xorp/etc/templates/Makefile.am 1.25 +1 -1; commitid: 11949434a9f057ea6; xorp/etc/templates/Makefile.in From pavlin@icir.org Mon Oct 10 19:37:03 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 10 Oct 2005 18:37:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510101837.j9AIb3Bd010626@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-10 18:37:03 UTC XORP CVS repository Modified files: etc/templates interfaces.tp Log message: Remove leftover test state. Revision Changes Path 1.19 +1 -4; commitid: 2969434ab4bf7ea6; xorp/etc/templates/interfaces.tp From pavlin@icir.org Tue Oct 11 04:47:58 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 03:47:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510110347.j9B3lwQ7015125@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-11 03:47:58 UTC XORP CVS repository Modified files: libxorp run_command.cc Log message: Bug fix in the intialization of RunShellCommand. Revision Changes Path 1.11 +4 -4; commitid: 3af7434b35cf7ea6; xorp/libxorp/run_command.cc From pavlin@icir.org Tue Oct 11 04:49:13 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 03:49:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510110349.j9B3nD1c015175@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-11 03:49:13 UTC XORP CVS repository Modified files: libxorp test_run_command.cc Log message: * Refactor the implementation of TestRunCommand to include support for RunShellCommand. * Add a test for RunShellCommand. Revision Changes Path 1.9 +110 -7; commitid: 3b2e434b36127ea6; xorp/libxorp/test_run_command.cc From atanu@icir.org Tue Oct 11 08:08:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 07:08:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510110708.j9B78cOL017549@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 07:08:38 UTC XORP CVS repository Modified files: ospf debug_io.hh Log message: The routes are now stored in a pseudo routing table allowing the regression tests to interrogate the table at the end of a test. Revision Changes Path 1.10 +81 -2; commitid: 4472434b64f67ea6; xorp/ospf/debug_io.hh From atanu@icir.org Tue Oct 11 08:10:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 07:10:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510110710.j9B7AEmH017634@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 07:10:14 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: Verify that the correct routes have been sent to the pseudo routing table. Revision Changes Path 1.4 +26 -1; commitid: 44c7434b65557ea6; xorp/ospf/test_routing.cc From atanu@icir.org Tue Oct 11 08:21:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 07:21:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510110721.j9B7LSgg017876@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 07:21:28 UTC XORP CVS repository Modified files: ospf peer.cc Log message: All multiple neighbours to be configured on Point-to-MultiPoint interfaces. Revision Changes Path 1.162 +2 -2; commitid: 45b9434b67f67ea6; xorp/ospf/peer.cc From atanu@icir.org Tue Oct 11 08:29:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 07:29:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510110729.j9B7Tejh018037@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 07:29:40 UTC XORP CVS repository Modified files: ospf peer.cc Log message: When a Point-to-MultiPoint interface comes up change the state to Point-to-Point and start the hello timer. Revision Changes Path 1.163 +2 -2; commitid: 465a434b69e37ea6; xorp/ospf/peer.cc From atanu@icir.org Tue Oct 11 08:43:48 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 07:43:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510110743.j9B7hmTo018309@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 07:43:48 UTC XORP CVS repository Modified files: ospf peer.cc Log message: On Point-to-MultiPoint interface send a hello packet to each neighbour. Revision Changes Path 1.164 +9 -2; commitid: 476a434b6d337ea6; xorp/ospf/peer.cc From pavlin@icir.org Tue Oct 11 18:59:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 17:59:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510111759.j9BHxhro027031@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-11 17:59:43 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh master_conf_tree.cc xorpsh_main.cc Log message: Add a new flag "preserve_node_id" to ConfigNodeId::merge_deltas() which can be used to specify whether the original node ID should be used when adding the new nodes or whether a new node ID should be generated. This fixes a bug with the generation of node IDs when loading a new configuration from a file. E.g., if the old configuration contains "interface eth0" and the new configuration contains "interface eth1": previously the node ID of "interface eth1" was same as the deleted "interface eth0", but now it contains an unique node ID. Revision Changes Path 1.46 +5 -3; commitid: 6940434bfc877ea6; xorp/rtrmgr/conf_tree.cc 1.27 +3 -2; commitid: 6940434bfc877ea6; xorp/rtrmgr/conf_tree.hh 1.90 +18 -5; commitid: 6940434bfc877ea6; xorp/rtrmgr/conf_tree_node.cc 1.51 +3 -2; commitid: 6940434bfc877ea6; xorp/rtrmgr/conf_tree_node.hh 1.62 +23 -12; commitid: 6940434bfc877ea6; xorp/rtrmgr/master_conf_tree.cc 1.54 +3 -2; commitid: 6940434bfc877ea6; xorp/rtrmgr/xorpsh_main.cc From pavlin@icir.org Tue Oct 11 20:22:08 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 19:22:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510111922.j9BJM8kE028020@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-11 19:22:08 UTC XORP CVS repository Modified files: etc/templates policy.tp Log message: Add missing %help strings. This fixes bugzilla entry #244 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=244 Revision Changes Path 1.16 +28 -3; commitid: 6d5b434c10c77ea6; xorp/etc/templates/policy.tp From atanu@icir.org Tue Oct 11 21:19:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 20:19:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510112019.j9BKJK7l028569@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 20:19:20 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Build the links that go into a Router-LSA for Point-to-MultiPoint interfaces. Revision Changes Path 1.165 +22 -4; commitid: 6f7e434c1e477ea6; xorp/ospf/peer.cc From atanu@icir.org Tue Oct 11 21:41:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 11 Oct 2005 20:41:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510112041.j9BKfTCH028863@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-11 20:41:29 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Allow a interface to be set to Point-2-Multipoint. Revision Changes Path 1.10 +3 -3; commitid: 70a4434c23797ea6; xorp/etc/templates/ospfv2.tp From bms@spc.org Tue Oct 11 23:41:44 2005 From: bms@spc.org (Bruce M Simpson) Date: Tue, 11 Oct 2005 23:41:44 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200510022210.j92MANS2080245@xorpc.icir.org> References: <200510022210.j92MANS2080245@xorpc.icir.org> Message-ID: <20051011224144.GD76582@empiric.icir.org> On Sun, Oct 02, 2005 at 10:10:23PM +0000, Pavlin Radoslavov wrote: > * Regenerate lex.opcmd.cc > Note that this regeneration removes manually added Windows-related > modifications like the following, so this may break the Windows > compilation: > > #ifdef HOST_OS_WINDOWS > #define isatty(x) _isatty(x) > #define fileno(x) _fileno(x) > #endif > > It is impossible to maintain such modifications in auto-generated > files, and they should be added somewhere else (e.g., somewhere > in libxorp). %%% This is ugly. We need to decide what we're more comfortable with -- the cost of possibly misusing emulation functions, or making lexer regens slightly more complex. We could remove -D_NO_OLDNAMES from Windows compilation, but this creates a situation where MSVCRT.DLL library functions which imitate UNIX syscalls may be used without explicit reference, perhaps in error. During the porting process I made a deliberate decision to use -D_NO_OLDNAMES, to weed out cases where we might be doing things the UNIX way, when they needed to be done the Windows way. On the other hand, we could use modified lex templates when regenerating the lexer, but this has additional maintenance cost. These particular two functions have very specific actions, and fileno()'s use is quite different from the UNIX world because of the 3-tier file descriptor dance which is happening in MSVCRT.DLL (stdio, 'file descriptor', and underlying Win32 file handle). isatty() in the Windows case actually ends up calling into the console mode subsystem to determine if a given file handle points to a console window. BMS From pavlin@icir.org Wed Oct 12 00:08:17 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 16:08:17 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Bruce M Simpson of "Tue, 11 Oct 2005 23:41:44 BST." <20051011224144.GD76582@empiric.icir.org> Message-ID: <200510112308.j9BN8HJe021896@possum.icir.org> > On Sun, Oct 02, 2005 at 10:10:23PM +0000, Pavlin Radoslavov wrote: > > * Regenerate lex.opcmd.cc > > Note that this regeneration removes manually added Windows-related > > modifications like the following, so this may break the Windows > > compilation: > > > > #ifdef HOST_OS_WINDOWS > > #define isatty(x) _isatty(x) > > #define fileno(x) _fileno(x) > > #endif > > > > It is impossible to maintain such modifications in auto-generated > > files, and they should be added somewhere else (e.g., somewhere > > in libxorp). > %%% > > This is ugly. > > We need to decide what we're more comfortable with -- the cost of possibly > misusing emulation functions, or making lexer regens slightly more complex. > > We could remove -D_NO_OLDNAMES from Windows compilation, but this creates a > situation where MSVCRT.DLL library functions which imitate UNIX syscalls may > be used without explicit reference, perhaps in error. > > During the porting process I made a deliberate decision to use -D_NO_OLDNAMES, > to weed out cases where we might be doing things the UNIX way, when they > needed to be done the Windows way. > > On the other hand, we could use modified lex templates when regenerating > the lexer, but this has additional maintenance cost. > > These particular two functions have very specific actions, and fileno()'s > use is quite different from the UNIX world because of the 3-tier > file descriptor dance which is happening in MSVCRT.DLL (stdio, > 'file descriptor', and underlying Win32 file handle). > > isatty() in the Windows case actually ends up calling into the console > mode subsystem to determine if a given file handle points to a > console window. If the above #define is a working (and acceptable) solution, then what is the issue with moving them to some header file inside libxorp? BTW, in this particular case if we add "%option never-interactive" to the *.ll file, then the code that uses isatty() and fileno() inside the auto-generated *.cc file is commented out: #if YY_NEVER_INTERACTIVE b->yy_is_interactive = 0; #else b->yy_is_interactive = file ? (isatty( fileno(file) ) > 0) : 0; #endif Hence, in case of all *.ll files we can use "%option never-interactive" and we don't have to redefine isatty() and fileno(). Pavlin From bms@icir.org Wed Oct 12 00:33:36 2005 From: bms@icir.org (Bruce Simpson) Date: Tue, 11 Oct 2005 23:33:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510112333.j9BNXa3L030573@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-11 23:33:36 UTC XORP CVS repository Modified files: libxorp popen.cc Log message: Put back a const_cast to fix compilation under Win32 Revision Changes Path 1.7 +3 -2; commitid: 7754434c4bbe7ea6; xorp/libxorp/popen.cc From bms@icir.org Wed Oct 12 00:34:43 2005 From: bms@icir.org (Bruce Simpson) Date: Tue, 11 Oct 2005 23:34:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510112334.j9BNYhlT030609@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-11 23:34:42 UTC XORP CVS repository Modified files: libxorp run_command.cc Log message: Fix compilation under Windows. This is most likely not the correct fix -- a full Win32 style path to MSYS's SH.EXE is probably needed. Revision Changes Path 1.12 +5 -1; commitid: 7777434c4bf57ea6; xorp/libxorp/run_command.cc From bms@icir.org Wed Oct 12 00:37:27 2005 From: bms@icir.org (Bruce Simpson) Date: Tue, 11 Oct 2005 23:37:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/backend Message-ID: <200510112337.j9BNbRfv030691@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-11 23:37:27 UTC XORP CVS repository Modified files: policy/backend single_varrw.cc Log message: Use memset() instead of importable bzero() Revision Changes Path 1.10 +4 -4; commitid: 77ca434c4cac7ea6; xorp/policy/backend/single_varrw.cc From pavlin@icir.org Wed Oct 12 00:57:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 23:57:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510112357.j9BNvBIn030967@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-11 23:57:11 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh Log message: Add new method ConfigTreeNode::is_multi_value_node() Revision Changes Path 1.91 +13 -3; commitid: 78da434c512e7ea6; xorp/rtrmgr/conf_tree_node.cc 1.52 +2 -1; commitid: 78da434c512e7ea6; xorp/rtrmgr/conf_tree_node.hh From bms@icir.org Wed Oct 12 01:55:31 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 12 Oct 2005 00:55:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510120055.j9C0tVGD031465@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-12 00:55:31 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Fix compilation on Win32; use definition of struct ip shipped in xorp/fea/ip.h Revision Changes Path 1.166 +4 -1; commitid: 7ad0434c5ef17ea6; xorp/ospf/peer.cc From bms@spc.org Wed Oct 12 02:11:59 2005 From: bms@spc.org (Bruce M Simpson) Date: Wed, 12 Oct 2005 02:11:59 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200510112308.j9BN8HJe021896@possum.icir.org> References: <20051011224144.GD76582@empiric.icir.org> <200510112308.j9BN8HJe021896@possum.icir.org> Message-ID: <20051012011159.GG76582@empiric.icir.org> On Tue, Oct 11, 2005 at 04:08:17PM -0700, Pavlin Radoslavov wrote: > > > #ifdef HOST_OS_WINDOWS > > > #define isatty(x) _isatty(x) > > > #define fileno(x) _fileno(x) > > > #endif I'm going to do this the ugly way for the time being, and push these down into the appropriate *.l files. I would rather spend time fixing the issue at source later so that I can try to get some tinderbox coverage up on xorpv ASAP. BMS From pavlin@icir.org Wed Oct 12 02:20:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 18:20:42 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Bruce M Simpson of "Wed, 12 Oct 2005 02:11:59 BST." <20051012011159.GG76582@empiric.icir.org> Message-ID: <200510120120.j9C1Kg7s023406@possum.icir.org> > On Tue, Oct 11, 2005 at 04:08:17PM -0700, Pavlin Radoslavov wrote: > > > > #ifdef HOST_OS_WINDOWS > > > > #define isatty(x) _isatty(x) > > > > #define fileno(x) _fileno(x) > > > > #endif > > I'm going to do this the ugly way for the time being, and push these > down into the appropriate *.l files. Bruce, I have the feeling we are cross-talking here. What I was suggesting/asking was: 1. If the above #define is an acceptable solution from Windows point of view, then why don't we add this to some of the common header files inside libxorp. This will solve the problem across all files, because I came across the above #define in a number of places. 2. For the *.ll case specifically, I am planning to add now the "%option never-interactive" option to each *.l and *.ll file so they won't require any isatty() or fileno() solutions. In either case, there is no need to hack the *.l and *.ll files. Pavlin > I would rather spend time fixing the issue at source later so that I > can try to get some tinderbox coverage up on xorpv ASAP. > > BMS > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs@icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From bms@icir.org Wed Oct 12 02:25:33 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 12 Oct 2005 01:25:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/fea xorp/libxorp xorp/ospf xorp/policy xorp/policy/backend xorp/policy/test Message-ID: <200510120125.j9C1PXNm031947@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-12 01:25:33 UTC XORP CVS repository Modified files: cli cli_node_net.cc fea rawsock.cc libxorp run_command.cc ospf peer.cc policy lex.yy_policy_parser.cc policy.l policy/backend backend.l lex.yy_policy_backend_parser.cc policy/test compilepolicy.l lex.yy_compile_policy.cc Log message: Guerrilla fixes for Win32 compilation. Push _isatty/_fileno cruft into *.l and generated files. Don't grope for telnet.h yanked from cli. Wrap lpwsaRecvMsg in HAVE_IPV6, not ready for primetime yet in rawsock.cc. Revision Changes Path 1.44 +9 -4; commitid: 7c2e434c65f77ea6; xorp/cli/cli_node_net.cc 1.7 +6 -1; commitid: 7c2e434c65f77ea6; xorp/fea/rawsock.cc 1.13 +6 -1; commitid: 7c2e434c65f77ea6; xorp/libxorp/run_command.cc 1.167 +4 -1; commitid: 7c2e434c65f77ea6; xorp/ospf/peer.cc 1.5 +5 -0; commitid: 7c2e434c65f77ea6; xorp/policy/backend/backend.l 1.6 +6 -1; commitid: 7c2e434c65f77ea6; xorp/policy/backend/lex.yy_policy_backend_parser.cc 1.10 +5 -1; commitid: 7c2e434c65f77ea6; xorp/policy/lex.yy_policy_parser.cc 1.10 +5 -0; commitid: 7c2e434c65f77ea6; xorp/policy/policy.l 1.5 +2 -0; commitid: 7c2e434c65f77ea6; xorp/policy/test/compilepolicy.l 1.6 +3 -1; commitid: 7c2e434c65f77ea6; xorp/policy/test/lex.yy_compile_policy.cc From bms@spc.org Wed Oct 12 02:25:06 2005 From: bms@spc.org (Bruce M Simpson) Date: Wed, 12 Oct 2005 02:25:06 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200510120120.j9C1Kg7s023406@possum.icir.org> References: <20051012011159.GG76582@empiric.icir.org> <200510120120.j9C1Kg7s023406@possum.icir.org> Message-ID: <20051012012506.GH76582@empiric.icir.org> On Tue, Oct 11, 2005 at 06:20:42PM -0700, Pavlin Radoslavov wrote: > 2. For the *.ll case specifically, I am planning to add now the > "%option never-interactive" option to each *.l and *.ll file > so they won't require any isatty() or fileno() solutions. > > In either case, there is no need to hack the *.l and *.ll files. 2 solves the problem. Blessed be! BMS From bms@icir.org Wed Oct 12 02:37:43 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 12 Oct 2005 01:37:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/libxorp xorp/mibs Message-ID: <200510120137.j9C1bhba032122@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-12 01:37:43 UTC XORP CVS repository Modified files: . config.h.in configure configure.in libxorp eventloop.cc eventloop.hh mibs configure Log message: Set default behaviour under Win32 to use the 'known good', but IPv4 and timers only, SelectorList based event dispatch path. Add a configure-time option, --with-windows-dispatcher, to switch over to using the WinDispatcher class (which tries to deal with native Win32 pipes and other animals necessary for operational mode and/or IPv6 to work). Note that the WinDispatcher code is subject to change and is quite buggy. Regen. Revision Changes Path 1.47 +3 -0; commitid: 7d31434c68cf7ea6; xorp/config.h.in 1.161 +14 -2; commitid: 7d31434c68cf7ea6; xorp/configure 1.145 +10 -2; commitid: 7d31434c68cf7ea6; xorp/configure.in 1.12 +5 -5; commitid: 7d31434c68cf7ea6; xorp/libxorp/eventloop.cc 1.16 +2 -2; commitid: 7d31434c68cf7ea6; xorp/libxorp/eventloop.hh 1.24 +1 -1; commitid: 7d31434c68cf7ea6; xorp/mibs/configure From bms@icir.org Wed Oct 12 02:38:46 2005 From: bms@icir.org (Bruce Simpson) Date: Wed, 12 Oct 2005 01:38:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510120138.j9C1ckpl032165@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-12 01:38:46 UTC XORP CVS repository Modified files: ospf peer.cc Log message: Fix botched merge from patch(1) Noticed by: atanu Pointy-hat-to: bms Revision Changes Path 1.168 +1 -4; commitid: 7d8c434c690f7ea6; xorp/ospf/peer.cc From bms@spc.org Wed Oct 12 02:42:43 2005 From: bms@spc.org (Bruce M Simpson) Date: Wed, 12 Oct 2005 02:42:43 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <20051012012506.GH76582@empiric.icir.org> References: <20051012011159.GG76582@empiric.icir.org> <200510120120.j9C1Kg7s023406@possum.icir.org> <20051012012506.GH76582@empiric.icir.org> Message-ID: <20051012014243.GI76582@empiric.icir.org> On Wed, Oct 12, 2005 at 02:25:06AM +0100, Bruce M Simpson wrote: > On Tue, Oct 11, 2005 at 06:20:42PM -0700, Pavlin Radoslavov wrote: > > 2. For the *.ll case specifically, I am planning to add now the > > "%option never-interactive" option to each *.l and *.ll file > > so they won't require any isatty() or fileno() solutions. > > > > In either case, there is no need to hack the *.l and *.ll files. > 2 solves the problem. Blessed be! The remaining Win32 tree breakage is *.l related in rtrmgr/, everything else compiles now. So if you wish to make this change now, please go ahead, I will get ssh ready in the xorpv image. BMS From pavlin@icir.org Wed Oct 12 03:10:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 02:10:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/backend xorp/policy/test xorp/rtrmgr Message-ID: <200510120210.j9C2AvMp033069@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 02:10:57 UTC XORP CVS repository Modified files: policy lex.yy_policy_parser.cc policy.l policy/backend backend.l lex.yy_policy_backend_parser.cc policy/test compilepolicy.l lex.yy_compile_policy.cc rtrmgr boot.ll lex.boot.cc lex.opcmd.cc lex.tplt.cc op_commands.ll template.ll Log message: * Add "%option never-interactive" to all *.l and *.ll files so we don't need anymore the following #define embedded inside the lex files: #ifdef HOST_OS_WINDOWS #define fileno(file) _fileno(file) #define isatty(fd) _isatty(fd) #endif * Minor cleanup of some of the included header files. Revision Changes Path 1.6 +1 -7; commitid: 80ac434c70717ea6; xorp/policy/backend/backend.l 1.7 +43 -49; commitid: 80ac434c70717ea6; xorp/policy/backend/lex.yy_policy_backend_parser.cc 1.11 +54 -66; commitid: 80ac434c70717ea6; xorp/policy/lex.yy_policy_parser.cc 1.11 +1 -6; commitid: 80ac434c70717ea6; xorp/policy/policy.l 1.6 +4 -7; commitid: 80ac434c70717ea6; xorp/policy/test/compilepolicy.l 1.7 +37 -40; commitid: 80ac434c70717ea6; xorp/policy/test/lex.yy_compile_policy.cc 1.27 +1 -0; commitid: 80ac434c70717ea6; xorp/rtrmgr/boot.ll 1.21 +49 -48; commitid: 80ac434c70717ea6; xorp/rtrmgr/lex.boot.cc 1.20 +34 -33; commitid: 80ac434c70717ea6; xorp/rtrmgr/lex.opcmd.cc 1.20 +67 -82; commitid: 80ac434c70717ea6; xorp/rtrmgr/lex.tplt.cc 1.13 +1 -0; commitid: 80ac434c70717ea6; xorp/rtrmgr/op_commands.ll 1.17 +1 -0; commitid: 80ac434c70717ea6; xorp/rtrmgr/template.ll From pavlin@icir.org Wed Oct 12 03:12:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 11 Oct 2005 19:12:25 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: Message from Bruce M Simpson of "Wed, 12 Oct 2005 02:42:43 BST." <20051012014243.GI76582@empiric.icir.org> Message-ID: <200510120212.j9C2CPEv024422@possum.icir.org> > On Wed, Oct 12, 2005 at 02:25:06AM +0100, Bruce M Simpson wrote: > > On Tue, Oct 11, 2005 at 06:20:42PM -0700, Pavlin Radoslavov wrote: > > > 2. For the *.ll case specifically, I am planning to add now the > > > "%option never-interactive" option to each *.l and *.ll file > > > so they won't require any isatty() or fileno() solutions. > > > > > > In either case, there is no need to hack the *.l and *.ll files. > > 2 solves the problem. Blessed be! > > The remaining Win32 tree breakage is *.l related in rtrmgr/, everything else > compiles now. So if you wish to make this change now, please go ahead, I > will get ssh ready in the xorpv image. OK, I added the "%option never-interactive" to all *.l and *.ll files and nuked the following embedded #define from those files: #ifdef HOST_OS_WINDOWS #define fileno(file) _fileno(file) #define isatty(fd) _isatty(fd) #endif Pavlin From pavlin@icir.org Wed Oct 12 04:12:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 03:12:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510120312.j9C3CS4e033787@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 03:12:28 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc conf_tree.hh conf_tree_node.cc conf_tree_node.hh master_conf_tree.cc Log message: Fix the mechanism for calculating the deltas between configurations. Previously whe loading a new configuration from a file, the deleted branches were miscalculated and some of the branches were left incorectly in the result tree. This fixes Bugzilla entry #218 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=218 Revision Changes Path 1.47 +9 -1; commitid: 83b7434c7e417ea6; xorp/rtrmgr/conf_tree.cc 1.28 +3 -1; commitid: 83b7434c7e417ea6; xorp/rtrmgr/conf_tree.hh 1.92 +75 -1; commitid: 83b7434c7e417ea6; xorp/rtrmgr/conf_tree_node.cc 1.53 +3 -1; commitid: 83b7434c7e417ea6; xorp/rtrmgr/conf_tree_node.hh 1.63 +2 -2; commitid: 83b7434c7e417ea6; xorp/rtrmgr/master_conf_tree.cc From bms@spc.org Wed Oct 12 04:50:25 2005 From: bms@spc.org (Bruce M Simpson) Date: Wed, 12 Oct 2005 04:50:25 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr In-Reply-To: <200510120212.j9C2CPEv024422@possum.icir.org> References: <20051012014243.GI76582@empiric.icir.org> <200510120212.j9C2CPEv024422@possum.icir.org> Message-ID: <20051012035024.GJ76582@empiric.icir.org> On Tue, Oct 11, 2005 at 07:12:25PM -0700, Pavlin Radoslavov wrote: > OK, I added the "%option never-interactive" to all *.l and *.ll > files and nuked the following embedded #define from those files: Thank you! BMS From pavlin@icir.org Wed Oct 12 06:39:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 05:39:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510120539.j9C5dixY019263@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 05:39:44 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc module_manager.cc module_manager.hh task.cc task.hh Log message: Introduce a new flag "is_verification" and propagate it around when executing new tasks. The main purpose of that flag is to suppress duplicated and confusingXLOG_INFO() messages. Bug found by: Atanu Ghosh Revision Changes Path 1.64 +3 -3; commitid: 4b19434ca14e7ea6; xorp/rtrmgr/master_conf_tree.cc 1.48 +11 -7; commitid: 4b19434ca14e7ea6; xorp/rtrmgr/module_manager.cc 1.34 +13 -7; commitid: 4b19434ca14e7ea6; xorp/rtrmgr/module_manager.hh 1.55 +20 -7; commitid: 4b19434ca14e7ea6; xorp/rtrmgr/task.cc 1.35 +6 -2; commitid: 4b19434ca14e7ea6; xorp/rtrmgr/task.hh From atanu@icir.org Wed Oct 12 07:11:06 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 06:11:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510120611.j9C6B6bp019696@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 06:11:06 UTC XORP CVS repository Modified files: ospf peer.cc peer.hh Log message: Refactor the initialisation of links that are included in Router-LSAs. In the case of Point-2-Point links set the link id to the neighbours router ID and not its interface address. Also generate a stub link that describes the network or host route to the neighbour, the stub link was previously being generated but not making it to the Router-LSA. Comment out get_p2p_neighbour_address() which is no longer required. Revision Changes Path 1.169 +60 -19; commitid: 4cd3434ca8f97ea6; xorp/ospf/peer.cc 1.102 +3 -1; commitid: 4cd3434ca8f97ea6; xorp/ospf/peer.hh From atanu@icir.org Wed Oct 12 08:24:28 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 07:24:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510120724.j9C7OSaE020858@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 07:24:28 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: When creating a p2p link pass in the value of the link data rather than adding 1 to the link id. Revision Changes Path 1.5 +46 -13; commitid: 515f434cba2b7ea6; xorp/ospf/test_routing.cc From pavlin@icir.org Wed Oct 12 09:50:24 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 08:50:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510120850.j9C8oOlQ022084@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 08:50:24 UTC XORP CVS repository Modified files: fea iftree.cc iftree.hh Log message: Add new class IfTree::prepare_replacement_state() that can be used to prepare configuration for pushing and replacing previous configuration. Revision Changes Path 1.29 +131 -1; commitid: 5615434cce367ea6; xorp/fea/iftree.cc 1.30 +21 -1; commitid: 5615434cce367ea6; xorp/fea/iftree.hh From pavlin@icir.org Wed Oct 12 09:51:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 08:51:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510120851.j9C8psu2022140@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 08:51:54 UTC XORP CVS repository Modified files: fea ifconfig.cc ifconfig.hh Log message: Restore the original config on shutdown (disabled by default). Revision Changes Path 1.48 +19 -1; commitid: 565d434cce9a7ea6; xorp/fea/ifconfig.cc 1.45 +25 -1; commitid: 565d434cce9a7ea6; xorp/fea/ifconfig.hh From pavlin@icir.org Wed Oct 12 10:15:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:15:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510120915.j9C9Fbnn022552@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:15:37 UTC XORP CVS repository Modified files: rtrmgr test_module_manager.cc Log message: Add the missing "is_verification" flag-argument to start_module() Revision Changes Path 1.16 +2 -2; commitid: 57f6434cd41f7ea6; xorp/rtrmgr/test_module_manager.cc From pavlin@icir.org Wed Oct 12 10:21:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:21:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/fea xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510120921.j9C9Lcfv022690@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:21:38 UTC XORP CVS repository Modified files: etc/templates interfaces.tp fea xrl_target.cc xrl_target.hh xrl/interfaces fea_ifmgr.xif fea_ifmgr_xif.cc fea_ifmgr_xif.hh xrl/targets fea.xrls fea_base.cc fea_base.hh Log message: Add configuration support to enable the flag to restore the original interface configuration on FEA shutdown: - Add new XRL "set_restore_original_config_on_shutdown". - Add new configuration statement restore_original_config_on_shutdown inside the fea configuration block. The addition of this configuration flag fixes bugzilla entry #150 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=150 Revision Changes Path 1.20 +9 -1; commitid: 5786434cd2d67ea6; xorp/etc/templates/interfaces.tp 1.76 +12 -1; commitid: 5786434cd2d67ea6; xorp/fea/xrl_target.cc 1.54 +5 -1; commitid: 5786434cd2d67ea6; xorp/fea/xrl_target.hh 1.15 +3 -1; commitid: 5786434cd2d67ea6; xorp/xrl/interfaces/fea_ifmgr.xif 1.26 +33 -1; commitid: 5786434cd2d67ea6; xorp/xrl/interfaces/fea_ifmgr_xif.cc 1.23 +15 -1; commitid: 5786434cd2d67ea6; xorp/xrl/interfaces/fea_ifmgr_xif.hh 1.52 +3 -1; commitid: 5786434cd2d67ea6; xorp/xrl/targets/fea.xrls 1.56 +31 -1; commitid: 5786434cd2d67ea6; xorp/xrl/targets/fea_base.cc 1.58 +7 -1; commitid: 5786434cd2d67ea6; xorp/xrl/targets/fea_base.hh From pavlin@icir.org Wed Oct 12 10:25:40 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:25:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510120925.j9C9Pe0U022848@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:25:40 UTC XORP CVS repository Modified files: rtrmgr module_manager.cc Log message: Replace fprintf(stderr, ...) leftover with debug_msg() Revision Changes Path 1.49 +2 -2; commitid: 5927434cd6857ea6; xorp/rtrmgr/module_manager.cc From pavlin@icir.org Wed Oct 12 10:35:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:35:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510120935.j9C9ZkO4023006@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:35:46 UTC XORP CVS repository Modified files: etc/templates interfaces.tp Log message: Replace restore_original_config_on_shutdown with restore-original-config-on-shutdown to reflect the configuration statements convention. Revision Changes Path 1.21 +3 -3; commitid: 59c0434cd8ce7ea6; xorp/etc/templates/interfaces.tp From pavlin@icir.org Wed Oct 12 10:39:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:39:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/rtrmgr Message-ID: <200510120939.j9C9dT2a023095@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:39:29 UTC XORP CVS repository Modified files: . RELEASE_NOTES rtrmgr config.boot.sample Log message: * Add restore-original-config-on-shutdown to the sample configuration * Mention the new restore-original-config-on-shutdown configuration statement in the release notes. Revision Changes Path 1.86 +7 -1; commitid: 5a09434cd9ac7ea6; xorp/RELEASE_NOTES 1.31 +3 -1; commitid: 5a09434cd9ac7ea6; xorp/rtrmgr/config.boot.sample From pavlin@icir.org Wed Oct 12 10:58:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:58:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200510120958.j9C9wU1w023365@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:58:30 UTC XORP CVS repository Modified files: docs/user_manual config_overview.tex interfaces.tex Log message: Add documentation description for restore-original-config-on-shutdown flag in the interfaces configuration section. Revision Changes Path 1.15 +2 -1; commitid: 5b2a434cde1a7ea6; xorp/docs/user_manual/config_overview.tex 1.8 +11 -2; commitid: 5b2a434cde1a7ea6; xorp/docs/user_manual/interfaces.tex From pavlin@icir.org Wed Oct 12 10:59:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 09:59:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510120959.j9C9xoa9023434@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-12 09:59:50 UTC XORP CVS repository Modified files: rtrmgr config.boot.sample Log message: Move the position of flag restore-original-config-on-shutdown. Revision Changes Path 1.32 +2 -3; commitid: 5b6c434cde6b7ea6; xorp/rtrmgr/config.boot.sample From pavlin@icir.org Wed Oct 12 11:00:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 12 Oct 2005 10:00:29 GMT Subject: [Xorp-cvs] XORP cvs commit: www www/html_src Message-ID: <200510121000.j9CA0TfV023547@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: www Changes by: pavlin@xorpc.icir.org 2005-10-12 10:00:29 UTC XORP CVS repository Modified files: . getting_started.html html_src getting_started.html Log message: Add documentation description for restore-original-config-on-shutdown flag in the interfaces configuration section. Revision Changes Path 1.51 +2 -1; commitid: 5bc3434cdeaf7ea6; www/getting_started.html 1.25 +1 -0; commitid: 5bc3434cdeaf7ea6; www/html_src/getting_started.html From atanu@icir.org Wed Oct 12 12:28:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 11:28:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510121128.j9CBS0Oc025206@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 11:28:00 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: The first update to the routing table was working subsequent updates were failing. Looping through the routing table was failing as the code was iterating from begin() to begin(), now goes from begin() to end(). Also added a str() method to the internal routing table entry. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=226 Revision Changes Path 1.19 +17 -3; commitid: 6259434cf33e7ea6; xorp/ospf/routing_table.cc 1.19 +2 -1; commitid: 6259434cf33e7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Wed Oct 12 12:30:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 11:30:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510121130.j9CBUeN9025286@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 11:30:40 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When adding an LSA to the database if the empty slot to be used was after the current end pointer the end pointer was not updated. Could cause LSAs to be lost. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=226 Revision Changes Path 1.116 +6 -2; commitid: 62ab434cf3de7ea6; xorp/ospf/area_router.cc From atanu@icir.org Wed Oct 12 12:32:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 11:32:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510121132.j9CBWob8025366@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 11:32:50 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: Add a regression test for this bug. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=226 Revision Changes Path 1.6 +228 -36; commitid: 62fb434cf4607ea6; xorp/ospf/test_routing.cc From atanu@icir.org Wed Oct 12 17:54:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 12 Oct 2005 16:54:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510121654.j9CGsDZK030437@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-12 16:54:13 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When returning a LSA that has been requested via an XRL update the age field. The show database command should now show the LSAs aging. Revision Changes Path 1.117 +6 -2; commitid: 76ca434d3fb47ea6; xorp/ospf/area_router.cc From mjh@icir.org Wed Oct 12 23:32:53 2005 From: mjh@icir.org (Mark Handley) Date: Wed, 12 Oct 2005 22:32:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510122232.j9CMWrbU033707@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-10-12 22:32:53 UTC XORP CVS repository Modified files: bgp open_packet.cc packet.cc Log message: Tighten up the checks on BGP open messages. Approved by: Atanu Revision Changes Path 1.24 +21 -3; commitid: 838b434d8ee37ea6; xorp/bgp/open_packet.cc 1.13 +2 -1; commitid: 838b434d8ee37ea6; xorp/bgp/packet.cc From atanu@icir.org Thu Oct 13 03:33:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 02:33:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510130233.j9D2X0cN035929@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 02:33:00 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Only update the age of the LSA when if it isn't already set to MaxAge. Revision Changes Path 1.118 +3 -2; commitid: 8c3e434dc75b7ea6; xorp/ospf/area_router.cc From pavlin@icir.org Thu Oct 13 04:19:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 03:19:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libfeaclient Message-ID: <200510130319.j9D3J0Df036529@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 03:19:00 UTC XORP CVS repository Modified files: libfeaclient ifmgr_cmds.cc Log message: * If we try to remove an entity and it is not in the tree anymore, then this is not a failure and return success (previously we were returning an error). * Minor edits. Revision Changes Path 1.14 +85 -85; commitid: 8e58434dd1967ea6; xorp/libfeaclient/ifmgr_cmds.cc From pavlin@icir.org Thu Oct 13 04:22:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 03:22:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510130322.j9D3Ms05036600@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 03:22:54 UTC XORP CVS repository Modified files: fea ifconfig_set.cc Log message: If an interface is marked as disabled or deleted, then mark all vifs and addresses that belong to it as disabled or deleted respectively. The same logic is applied if a vif is marked as disabled or deleted: all addresses that belong to it are also marked as disabled or deleted respectively. This fixes a bug when deleting an interface (e.g, via xorpsh): previously the interface status in the kernel was marked as DOWN, but the addresses were still there. Now the addresses are deleted properly. Revision Changes Path 1.33 +29 -10; commitid: 8ecb434dd2417ea6; xorp/fea/ifconfig_set.cc From pavlin@icir.org Thu Oct 13 04:41:50 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 03:41:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510130341.j9D3foM1036854@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 03:41:50 UTC XORP CVS repository Modified files: rtrmgr master_conf_tree.cc Log message: * Bug fix in the ordering of the second and third argument of fwrite() * Use "sizeof(char)" instead of "1" as the second argument to of fwrite(). Bug found by: Michael Larson Revision Changes Path 1.65 +4 -4; commitid: 8fdd434dd7407ea6; xorp/rtrmgr/master_conf_tree.cc From atanu@icir.org Thu Oct 13 09:20:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 08:20:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510130820.j9D8Kngu063932@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 08:20:49 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Every LSA now provides its own name. Revision Changes Path 1.66 +41 -1; commitid: f9a1434e18e07ea6; xorp/ospf/lsa.hh From atanu@icir.org Thu Oct 13 09:21:25 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 08:21:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510130821.j9D8LPkP063980@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 08:21:25 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Provide a brief view for LSAs. Revision Changes Path 1.2 +47 -8; commitid: f9d1434e19047ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Thu Oct 13 09:22:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 08:22:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510130822.j9D8MDOo064029@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 08:22:13 UTC XORP CVS repository Modified files: etc/templates ospfv2.cmds Log message: Provide brief and detailed outputs. Revision Changes Path 1.2 +14 -2; commitid: fa01434e19347ea6; xorp/etc/templates/ospfv2.cmds From pavlin@icir.org Thu Oct 13 11:49:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 10:49:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy/backend Message-ID: <200510131049.j9DAnYHj009868@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 10:49:34 UTC XORP CVS repository Modified files: policy/backend backend.y yacc.yy_policy_backend_parser.cc Log message: Fix the error check after strtoul(). We must check for an error before we have deallocated the memory for the original string, othersise the result is unpredicted. This fixes a run-time error on Linux. Revision Changes Path 1.8 +10 -4; commitid: 2655434e3b4d7ea6; xorp/policy/backend/backend.y 1.8 +35 -32; commitid: 2655434e3b4d7ea6; xorp/policy/backend/yacc.yy_policy_backend_parser.cc From pavlin@icir.org Thu Oct 13 12:15:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 11:15:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rip Message-ID: <200510131115.j9DBFN5O010202@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 11:15:22 UTC XORP CVS repository Modified files: rip test_outputs.cc Log message: Add missing virtual destructor to base class NoHorizonValidator (which already contains pure virtual methods), because gcc-4.0.0 on Fedora Core4 requires it. Revision Changes Path 1.24 +2 -1; commitid: 27a6434e41747ea6; xorp/rip/test_outputs.cc From atanu@icir.org Thu Oct 13 17:39:06 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 16:39:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/ospf/tools xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510131639.j9DGd6T3024792@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 16:39:06 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh ospf/tools print_lsas.cc xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Pass back a flag signifying if an LSA is self originated. Revision Changes Path 1.119 +4 -2; commitid: 6068434e8da57ea6; xorp/ospf/area_router.cc 1.72 +2 -2; commitid: 6068434e8da57ea6; xorp/ospf/area_router.hh 1.42 +3 -3; commitid: 6068434e8da57ea6; xorp/ospf/ospf.cc 1.54 +3 -2; commitid: 6068434e8da57ea6; xorp/ospf/ospf.hh 1.62 +4 -3; commitid: 6068434e8da57ea6; xorp/ospf/peer_manager.cc 1.42 +3 -2; commitid: 6068434e8da57ea6; xorp/ospf/peer_manager.hh 1.3 +5 -2; commitid: 6068434e8da57ea6; xorp/ospf/tools/print_lsas.cc 1.10 +5 -4; commitid: 6068434e8da57ea6; xorp/ospf/xrl_target.cc 1.8 +4 -1; commitid: 6068434e8da57ea6; xorp/ospf/xrl_target.hh 1.5 +3 -1; commitid: 6068434e8da57ea6; xorp/xrl/interfaces/ospfv2.xif 1.6 +9 -7; commitid: 6068434e8da57ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.6 +2 -2; commitid: 6068434e8da57ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.7 +4 -2; commitid: 6068434e8da57ea6; xorp/xrl/targets/ospfv2.xrls 1.7 +4 -1; commitid: 6068434e8da57ea6; xorp/xrl/targets/ospfv2_base.cc 1.7 +4 -1; commitid: 6068434e8da57ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Thu Oct 13 17:49:06 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 16:49:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510131649.j9DGn6F7024955@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 16:49:06 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Dereference self. Revision Changes Path 1.4 +2 -2; commitid: 6160434e8fee7ea6; xorp/ospf/tools/print_lsas.cc From pavlin@icir.org Thu Oct 13 20:59:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 19:59:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510131959.j9DJxvkJ026828@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 19:59:57 UTC XORP CVS repository Modified files: libxorp selector.cc Log message: * Don't use a NULL pointer as a second argument for fstat(). This fixes a compilation error on Fedora Core 4 with gcc-4.0.0 * Minor edits: fix comments, etc. Bug found by: Nick Feamster Revision Changes Path 1.30 +19 -8; commitid: 68a1434ebc547ea6; xorp/libxorp/selector.cc From pavlin@icir.org Thu Oct 13 21:02:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 20:02:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510132002.j9DK2gtN026904@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 20:02:42 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Add Linux Fedora Core4 to the list of platforms that XORP can be built on. Revision Changes Path 1.31 +4 -1; commitid: 68ff434ebd497ea6; xorp/BUILD_NOTES From atanu@icir.org Thu Oct 13 21:41:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 13 Oct 2005 20:41:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510132041.j9DKf0p5047603@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-13 20:41:00 UTC XORP CVS repository Modified files: ospf lsa.cc Log message: When requested to update the age and sequence number fields nothing would be done if the LSA had not been trasnmitted. This logic was incorrect the age field must be uncondtionally updated. Revision Changes Path 1.56 +3 -3; commitid: b9d8434ec65a7ea6; xorp/ospf/lsa.cc From pavlin@icir.org Thu Oct 13 23:24:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 13 Oct 2005 22:24:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510132224.j9DMOfbl048603@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-13 22:24:41 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: * Fix the format of the printed message when there are other users in configuration mode. This fixes bugzilla entry #227 * Remove bogus "else" statements which result in failure to print some of the users when there are 3+ users. * Simplify some of the code by reducing some of the #ifdef statements. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=227 Revision Changes Path 1.100 +6 -14; commitid: bdb3434eddc17ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Fri Oct 14 01:27:07 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 00:27:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510140027.j9E0R7Aa049703@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 00:27:07 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Add Mac OS X 10.4.2 to the list of systems that can be used to run XORP. Revision Changes Path 1.32 +11 -4; commitid: c20c434efafa7ea6; xorp/BUILD_NOTES From pavlin@icir.org Fri Oct 14 04:06:41 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 03:06:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510140306.j9E36fE9050849@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 03:06:41 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: * Add gcc-4.0.1 to the list of compilers that are OK with Fedora Core4 * Minor nits Revision Changes Path 1.33 +7 -6; commitid: c683434f20a37ea6; xorp/BUILD_NOTES From pavlin@icir.org Fri Oct 14 05:33:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 04:33:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510140433.j9E4X5p7051667@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 04:33:05 UTC XORP CVS repository Modified files: rtrmgr master_template_tree_node.cc Log message: Improve a bit the text of an error message. Revision Changes Path 1.9 +2 -2; commitid: c9ba434f34e77ea6; xorp/rtrmgr/master_template_tree_node.cc From atanu@icir.org Fri Oct 14 16:52:11 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 14 Oct 2005 15:52:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510141552.j9EFqBT0061054@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-14 15:52:11 UTC XORP CVS repository Modified files: bgp xrl_target.cc Log message: The code to delete a peer has never been fully implemented. Deleting a peer should just take the peering down. We had a report recently that deleting a peer left it configured. The problem was code in xrl_target still believed that deleting a peer wasn't implmented so didn't propogate the call through to the main bgp processing code. The call is now propogated. Bug found by: Kristian Larsson Revision Changes Path 1.41 +10 -2; commitid: ee63434fd42a7ea6; xorp/bgp/xrl_target.cc From atanu@icir.org Fri Oct 14 18:53:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 14 Oct 2005 17:53:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/targets Message-ID: <200510141753.j9EHrtPd062489@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-14 17:53:54 UTC XORP CVS repository Modified files: ospf xrl_target.cc xrl_target.hh xrl/targets ospfv2.tgt ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Accept policy XRLs. Revision Changes Path 1.11 +49 -1; commitid: f3d9434ff0b07ea6; xorp/ospf/xrl_target.cc 1.9 +66 -1; commitid: f3d9434ff0b07ea6; xorp/ospf/xrl_target.hh 1.3 +6 -1; commitid: f3d9434ff0b07ea6; xorp/xrl/targets/ospfv2.tgt 1.8 +50 -1; commitid: f3d9434ff0b07ea6; xorp/xrl/targets/ospfv2.xrls 1.8 +158 -1; commitid: f3d9434ff0b07ea6; xorp/xrl/targets/ospfv2_base.cc 1.8 +86 -1; commitid: f3d9434ff0b07ea6; xorp/xrl/targets/ospfv2_base.hh From pavlin@icir.org Fri Oct 14 18:56:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 17:56:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510141756.j9EHuNP5062612@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 17:56:23 UTC XORP CVS repository Modified files: rtrmgr module_manager.cc Log message: Remove commented-out include file. Revision Changes Path 1.50 +1 -2; commitid: f47b434ff13d7ea6; xorp/rtrmgr/module_manager.cc From pavlin@icir.org Fri Oct 14 18:58:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 17:58:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510141758.j9EHwiGf062672@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 17:58:44 UTC XORP CVS repository Modified files: rtrmgr op_commands.cc op_commands.hh op_commands.yy y.opcmd_tab.cc Log message: Bug fix in expanding the "$0" positional argument (i.e., all arguments) for operational commands. Bug found by: Kristian Larsson , Atanu Ghosh Revision Changes Path 1.60 +20 -21; commitid: f4a6434ff14d7ea6; xorp/rtrmgr/op_commands.cc 1.35 +11 -6; commitid: f4a6434ff14d7ea6; xorp/rtrmgr/op_commands.hh 1.17 +3 -2; commitid: f4a6434ff14d7ea6; xorp/rtrmgr/op_commands.yy 1.25 +5 -4; commitid: f4a6434ff14d7ea6; xorp/rtrmgr/y.opcmd_tab.cc From pavlin@icir.org Fri Oct 14 19:12:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 18:12:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/targets Message-ID: <200510141812.j9EICSLK062924@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 18:12:28 UTC XORP CVS repository Modified files: xrl/targets Makefile.am Makefile.in Log message: Add the following files to the list of files that ospfv2_base.{hh,cc} depend on: $(INTERFACES_DIR)/policy_backend.xif $(INTERFACES_DIR)/policy_redist4.xif Revision Changes Path 1.58 +3 -1; commitid: f5b1434ff4997ea6; xorp/xrl/targets/Makefile.am 1.73 +2 -0; commitid: f5b1434ff4997ea6; xorp/xrl/targets/Makefile.in From atanu@icir.org Fri Oct 14 20:17:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 14 Oct 2005 19:17:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510141917.j9EJHgkr063992@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-14 19:17:42 UTC XORP CVS repository Modified files: ospf area_router.cc ospf.hh Log message: Move the defines MAX_AGE_IN_DATABASE and PARANOIA into ospf.hh from area_router.hh. Revision Changes Path 1.120 +1 -14; commitid: f9d0435004547ea6; xorp/ospf/area_router.cc 1.55 +15 -1; commitid: f9d0435004547ea6; xorp/ospf/ospf.hh From atanu@icir.org Fri Oct 14 21:02:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 14 Oct 2005 20:02:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510142002.j9EK2xkI064440@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-14 20:02:59 UTC XORP CVS repository Modified files: ospf TODO ospf.hh peer.cc Log message: No longer define MAX_AGE_IN_DATABASE. Check on the retransmission list for a duplicate LSA, hopefully there is no longer a reason to keep an LSA that has reached MaxAge in the database. Revision Changes Path 1.54 +6 -1; commitid: fb9943500ef17ea6; xorp/ospf/TODO 1.56 +3 -2; commitid: fb9943500ef17ea6; xorp/ospf/ospf.hh 1.170 +29 -1; commitid: fb9943500ef17ea6; xorp/ospf/peer.cc From pavlin@icir.org Fri Oct 14 22:39:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 14 Oct 2005 21:39:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510142139.j9ELd0U6065481@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-14 21:39:00 UTC XORP CVS repository Modified files: fea xrl_ifmanager.cc Log message: Fix the mechanism for restoring the previous interface configuration if the commit of the new configuration fails. Revision Changes Path 1.18 +5 -3; commitid: ffa5435025427ea6; xorp/fea/xrl_ifmanager.cc From pavlin@icir.org Sun Oct 16 08:01:12 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 16 Oct 2005 07:01:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510160701.j9G71CNc086978@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-16 07:01:12 UTC XORP CVS repository Modified files: . config.h.in configure configure.in Log message: Add checks for header files and Revision Changes Path 1.48 +6 -0; commitid: 1539d4351fa917ea6; xorp/config.h.in 1.162 +5 -3; commitid: 1539d4351fa917ea6; xorp/configure 1.146 +4 -4; commitid: 1539d4351fa917ea6; xorp/configure.in From pavlin@icir.org Sun Oct 16 08:10:40 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 16 Oct 2005 07:10:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/tools xorp/libfeaclient xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510160710.j9G7AexS087283@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-16 07:10:40 UTC XORP CVS repository Modified files: fea Makefile.am Makefile.in ifconfig_get_iphelper.cc ifconfig_get_proc_linux.cc ifconfig_parse_ifaddrs.cc ifconfig_parse_ifreq.cc ifconfig_parse_nlm.cc ifconfig_parse_rtm.cc iftree.cc iftree.hh libfeaclient_bridge.cc xrl_target.cc xrl_target.hh fea/tools show_interfaces.cc libfeaclient ifmgr_atoms.cc ifmgr_atoms.hh ifmgr_cmd_queue.cc ifmgr_cmds.cc ifmgr_cmds.hh ifmgr_xrl_mirror.cc test_local_copy.cc test_remote_copy.cc xrl/interfaces fea_ifmgr.xif fea_ifmgr_mirror.xif fea_ifmgr_mirror_xif.cc fea_ifmgr_mirror_xif.hh fea_ifmgr_xif.cc fea_ifmgr_xif.hh xrl/targets fea.xrls fea_base.cc fea_base.hh fea_ifmgr_mirror.xrls fea_ifmgr_mirror_base.cc fea_ifmgr_mirror_base.hh Added files: fea ifconfig_media.cc ifconfig_media.hh Log message: Add initial support for reading the interface link status (i.e., whether the Ethernet cable is connected). Currently, the support is incomplete: e.g., any changes in the link status that are caught by the interface observer are not propagated (yet) to the interested parties. Revision Changes Path 1.64 +3 -1; commitid: 154254351fc407ea6; xorp/fea/Makefile.am 1.79 +4 -2; commitid: 154254351fc407ea6; xorp/fea/Makefile.in 1.4 +48 -1; commitid: 154254351fc407ea6; xorp/fea/ifconfig_get_iphelper.cc 1.23 +13 -2; commitid: 154254351fc407ea6; xorp/fea/ifconfig_get_proc_linux.cc 1.1 +167 -0 xorp/fea/ifconfig_media.cc (new) 1.1 +24 -0 xorp/fea/ifconfig_media.hh (new) 1.25 +47 -2; commitid: 154254351fc407ea6; xorp/fea/ifconfig_parse_ifaddrs.cc 1.26 +20 -1; commitid: 154254351fc407ea6; xorp/fea/ifconfig_parse_ifreq.cc 1.20 +13 -1; commitid: 154254351fc407ea6; xorp/fea/ifconfig_parse_nlm.cc 1.25 +68 -1; commitid: 154254351fc407ea6; xorp/fea/ifconfig_parse_rtm.cc 1.30 +7 -4; commitid: 154254351fc407ea6; xorp/fea/iftree.cc 1.31 +8 -1; commitid: 154254351fc407ea6; xorp/fea/iftree.hh 1.16 +8 -1; commitid: 154254351fc407ea6; xorp/fea/libfeaclient_bridge.cc 1.14 +7 -1; commitid: 154254351fc407ea6; xorp/fea/tools/show_interfaces.cc 1.77 +31 -1; commitid: 154254351fc407ea6; xorp/fea/xrl_target.cc 1.55 +13 -1; commitid: 154254351fc407ea6; xorp/fea/xrl_target.hh 1.11 +2 -1; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_atoms.cc 1.20 +6 -2; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_atoms.hh 1.11 +2 -1; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_cmd_queue.cc 1.15 +36 -1; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_cmds.cc 1.12 +23 -1; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_cmds.hh 1.18 +19 -1; commitid: 154254351fc407ea6; xorp/libfeaclient/ifmgr_xrl_mirror.cc 1.9 +6 -2; commitid: 154254351fc407ea6; xorp/libfeaclient/test_local_copy.cc 1.14 +6 -2; commitid: 154254351fc407ea6; xorp/libfeaclient/test_remote_copy.cc 1.16 +5 -1; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr.xif 1.6 +1 -0; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr_mirror.xif 1.12 +35 -1; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr_mirror_xif.cc 1.10 +16 -1; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr_mirror_xif.hh 1.27 +81 -1; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr_xif.cc 1.24 +29 -1; commitid: 154254351fc407ea6; xorp/xrl/interfaces/fea_ifmgr_xif.hh 1.53 +5 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea.xrls 1.57 +89 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea_base.cc 1.59 +17 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea_base.hh 1.10 +3 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea_ifmgr_mirror.xrls 1.14 +32 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea_ifmgr_mirror_base.cc 1.11 +8 -1; commitid: 154254351fc407ea6; xorp/xrl/targets/fea_ifmgr_mirror_base.hh From pavlin@icir.org Sun Oct 16 08:16:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 16 Oct 2005 07:16:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510160716.j9G7GFqw087459@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-16 07:16:15 UTC XORP CVS repository Modified files: fea ifconfig_media.cc Log message: Remove bogus "static" keyword. Revision Changes Path 1.2 +1 -1; commitid: 155854351fe267ea6; xorp/fea/ifconfig_media.cc From pavlin@icir.org Sun Oct 16 08:25:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 16 Oct 2005 07:25:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510160725.j9G7Psgr098938@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-16 07:25:54 UTC XORP CVS repository Modified files: ospf .cvsignore Log message: Add test_routing to .cvsignore Revision Changes Path 1.3 +1 -0; commitid: 18090435200747ea6; xorp/ospf/.cvsignore From pavlin@icir.org Sun Oct 16 11:06:32 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 16 Oct 2005 10:06:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli/libtecla Message-ID: <200510161006.j9GA6WhK080830@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-16 10:06:32 UTC XORP CVS repository Modified files: cli/libtecla configure configure.in Log message: Check for the existence of the following headers: sys/ioctl.h, unistd.h, termios.h This fixes a compilation error for NetBSD-2.0 Revision Changes Path 1.9 +328 -0; commitid: 13b88435225d37ea6; xorp/cli/libtecla/configure 1.2 +7 -0; commitid: 13b88435225d37ea6; xorp/cli/libtecla/configure.in From atanu@icir.org Sun Oct 16 23:22:32 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 16 Oct 2005 22:22:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510162222.j9GMMW6o090656@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-16 22:22:32 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Support for AS-External-LSAs from other areas or as part of redistribution from the RIB. Revision Changes Path 1.121 +56 -1; commitid: 162034352d2a67ea6; xorp/ospf/area_router.cc 1.73 +35 -2; commitid: 162034352d2a67ea6; xorp/ospf/area_router.hh From atanu@icir.org Mon Oct 17 00:32:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 16 Oct 2005 23:32:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510162332.j9GNW1hX091181@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-16 23:32:01 UTC XORP CVS repository Modified files: ospf xrl_target.cc Log message: Typo. Revision Changes Path 1.12 +2 -2; commitid: 164124352e2f07ea6; xorp/ospf/xrl_target.cc From atanu@icir.org Mon Oct 17 00:59:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 16 Oct 2005 23:59:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510162359.j9GNxxWA091488@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-16 23:59:59 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Don't accept AS-External-LSAs into stub and nssa areas. Revision Changes Path 1.122 +32 -1; commitid: 165434352e97d7ea6; xorp/ospf/area_router.cc 1.74 +6 -1; commitid: 165434352e97d7ea6; xorp/ospf/area_router.hh From atanu@icir.org Mon Oct 17 01:01:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 00:01:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170001.j9H017eJ091578@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 00:01:07 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: Entry points for generating and propogating AS-External-LSAs. Revision Changes Path 1.63 +54 -1; commitid: 1659d4352e9c27ea6; xorp/ospf/peer_manager.cc 1.43 +43 -1; commitid: 1659d4352e9c27ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Mon Oct 17 01:16:14 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 00:16:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170016.j9H0GEhp091758@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 00:16:14 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: On startup request that any AS-External-LSAs that have arrived from other areas are sent to this new area. Revision Changes Path 1.123 +10 -4; commitid: 166534352ed4d7ea6; xorp/ospf/area_router.cc From atanu@icir.org Mon Oct 17 01:44:17 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 00:44:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170044.j9H0iH5f092067@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 00:44:17 UTC XORP CVS repository Modified files: ospf area_router.cc area_router.hh Log message: Send all AS-External-LSAs that are received from the wire upto the peer manager to be sent to other areas. No longer deal with an AS-External-LSA reaching MaxAge, previously the timer management for AS-External-LSAs would be performed by areas themselves. It is now going to managed externally to deal with the case that an AS-External-LSA arrives and is propogated to other areas and then the area is removed, previously the timer routines would have pointed at the deleted area. Revision Changes Path 1.124 +17 -11; commitid: 167864352f3e07ea6; xorp/ospf/area_router.cc 1.75 +7 -7; commitid: 167864352f3e07ea6; xorp/ospf/area_router.hh From atanu@icir.org Mon Oct 17 02:02:04 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 01:02:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170102.j9H1245f092288@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 01:02:04 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in ospf.hh peer_manager.hh Added files: ospf external.cc external.hh Log message: Class for handling AS-External-LSAs. Revision Changes Path 1.19 +3 -1; commitid: 1685b4352f80b7ea6; xorp/ospf/Makefile.am 1.16 +6 -5; commitid: 1685b4352f80b7ea6; xorp/ospf/Makefile.in 1.1 +20 -0 xorp/ospf/external.cc (new) 1.1 +29 -0 xorp/ospf/external.hh (new) 1.57 +2 -1; commitid: 1685b4352f80b7ea6; xorp/ospf/ospf.hh 1.44 +4 -1; commitid: 1685b4352f80b7ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Mon Oct 17 04:37:58 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 03:37:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170337.j9H3bwpH097341@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 03:37:58 UTC XORP CVS repository Modified files: ospf external.cc Log message: Class for handling AS-External-LSAs. Revision Changes Path 1.2 +22 -1; commitid: 17c2243531c967ea6; xorp/ospf/external.cc From atanu@icir.org Mon Oct 17 07:52:48 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 06:52:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170652.j9H6qmIG000812@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 06:52:48 UTC XORP CVS repository Modified files: ospf external.cc external.hh peer_manager.cc peer_manager.hh Log message: AS-External-LSAs are now stored in a separate database for introduction into the various areas. Revision Changes Path 1.3 +142 -1; commitid: 30b43534a3f7ea6; xorp/ospf/external.cc 1.2 +81 -1; commitid: 30b43534a3f7ea6; xorp/ospf/external.hh 1.64 +17 -3; commitid: 30b43534a3f7ea6; xorp/ospf/peer_manager.cc 1.45 +4 -4; commitid: 30b43534a3f7ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Mon Oct 17 08:06:02 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 07:06:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170706.j9H762i6001007@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 07:06:02 UTC XORP CVS repository Modified files: ospf ospf.hh Log message: Include an instance of a policy filter. Revision Changes Path 1.58 +3 -1; commitid: 3d443534d597ea6; xorp/ospf/ospf.hh From atanu@icir.org Mon Oct 17 08:25:36 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 07:25:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170725.j9H7PaNV001357@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 07:25:36 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh xrl_target.cc Log message: Hook up the XRLs to the policy filters. Revision Changes Path 1.43 +22 -1; commitid: 52e435351ef7ea6; xorp/ospf/ospf.cc 1.59 +21 -1; commitid: 52e435351ef7ea6; xorp/ospf/ospf.hh 1.13 +23 -7; commitid: 52e435351ef7ea6; xorp/ospf/xrl_target.cc From atanu@icir.org Mon Oct 17 09:03:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 08:03:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170803.j9H83xgh001824@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 08:03:59 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc Log message: Redistributed routes will now make it all the way to the peer manager. Revision Changes Path 1.44 +18 -1; commitid: 6fd43535aed7ea6; xorp/ospf/ospf.cc 1.60 +25 -1; commitid: 6fd43535aed7ea6; xorp/ospf/ospf.hh 1.65 +4 -3; commitid: 6fd43535aed7ea6; xorp/ospf/peer_manager.cc 1.46 +4 -3; commitid: 6fd43535aed7ea6; xorp/ospf/peer_manager.hh 1.14 +12 -8; commitid: 6fd43535aed7ea6; xorp/ospf/xrl_target.cc From atanu@icir.org Mon Oct 17 09:38:15 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 08:38:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510170838.j9H8cF6E002327@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 08:38:15 UTC XORP CVS repository Modified files: ospf external.cc external.hh ospf.cc ospf.hh peer_manager.cc peer_manager.hh Log message: Pass the policy tags all the way through to the external class that will announce or withdraw AS-External-LSAs. Revision Changes Path 1.4 +18 -1; commitid: 8f2435362f67ea6; xorp/ospf/external.cc 1.3 +12 -1; commitid: 8f2435362f67ea6; xorp/ospf/external.hh 1.45 +3 -3; commitid: 8f2435362f67ea6; xorp/ospf/ospf.cc 1.61 +3 -3; commitid: 8f2435362f67ea6; xorp/ospf/ospf.hh 1.66 +5 -8; commitid: 8f2435362f67ea6; xorp/ospf/peer_manager.cc 1.47 +3 -2; commitid: 8f2435362f67ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Mon Oct 17 11:01:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 10:01:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510171001.j9HA1DRl003923@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 10:01:13 UTC XORP CVS repository Modified files: ospf external.cc external.hh Log message: Generate AS-External-LSAs for redistributing. Revision Changes Path 1.5 +121 -4; commitid: f36435376667ea6; xorp/ospf/external.cc 1.4 +13 -1; commitid: f36435376667ea6; xorp/ospf/external.hh From atanu@icir.org Mon Oct 17 11:22:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 10:22:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510171022.j9HAMfjL004542@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 10:22:41 UTC XORP CVS repository Modified files: ospf external.cc external.hh peer_manager.cc Log message: Previously the router could never be an AS boundary router as it could not originate AS-External-LSAs. If any routes are being redistributed from other protocols the as_boundary_router_p() will now return true. Revision Changes Path 1.6 +6 -2; commitid: 119f43537b6f7ea6; xorp/ospf/external.cc 1.5 +11 -2; commitid: 119f43537b6f7ea6; xorp/ospf/external.hh 1.67 +2 -4; commitid: 119f43537b6f7ea6; xorp/ospf/peer_manager.cc From pavlin@icir.org Mon Oct 17 12:14:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 11:14:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/mld6igmp xorp/pim Message-ID: <200510171114.j9HBENcc005482@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 11:14:23 UTC XORP CVS repository Modified files: fea ifconfig.hh ifconfig.cc fea.cc mld6igmp test_mld6igmp.cc pim test_pim.cc Log message: * Add inside class IfConfig a pointer to the current configuration tree. * Set the above pointer as appropriate during the FEA initialization. Revision Changes Path 1.52 +8 -2; commitid: 1501435387047ea6; xorp/fea/fea.cc 1.49 +2 -1; commitid: 1501435387047ea6; xorp/fea/ifconfig.cc 1.46 +5 -1; commitid: 1501435387047ea6; xorp/fea/ifconfig.hh 1.47 +8 -2; commitid: 1501435387047ea6; xorp/mld6igmp/test_mld6igmp.cc 1.57 +8 -2; commitid: 1501435387047ea6; xorp/pim/test_pim.cc From pavlin@icir.org Mon Oct 17 12:16:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 11:16:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510171116.j9HBGQiE005598@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 11:16:26 UTC XORP CVS repository Modified files: fea iftree.cc iftree.hh Log message: Add new method +IfTree::track_live_config_state() that can be used for tracking modifications from the live config state as read from the kernel. Revision Changes Path 1.31 +43 -1; commitid: 15b9435387e77ea6; xorp/fea/iftree.cc 1.32 +22 -1; commitid: 15b9435387e77ea6; xorp/fea/iftree.hh From pavlin@icir.org Mon Oct 17 12:17:00 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 11:17:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510171117.j9HBH0aQ005643@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 11:17:00 UTC XORP CVS repository Modified files: fea test_mfea.cc Log message: * Add inside class IfConfig a pointer to the current configuration tree. * Set the above pointer as appropriate during the FEA initialization. Revision Changes Path 1.25 +8 -2; commitid: 15f2435388217ea6; xorp/fea/test_mfea.cc From pavlin@icir.org Mon Oct 17 12:27:52 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 11:27:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510171127.j9HBRqZM005828@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 11:27:52 UTC XORP CVS repository Modified files: fea ifconfig_observer_iphelper.cc ifconfig_observer_netlink.cc ifconfig_observer_rtsock.cc Log message: If the live config state as read from the kernel is modified by an observer, then propagate the changes from the live config to the local config. This modification propagates the "no_carrier" flag changes that may come from the kernel. This change completes the fix for Bugzilla entry #167, so now the "show interfaces" operational command can be used to show the link state of the interfaces. E.g., if the Ethernet cable is not plugged, then the "NO-CARRIER" flag would be shown: Xorp> show interfaces fxp0/fxp0: Flags: mtu 1500 ... xl0/xl0: Flags: mtu 1500 ... Note that the asyncronous upcall notification by the kernel about link state changes exists on Linux, NetBSD and OpenBSD, but (currently) it doesn't appear to exist on FreeBSD and MacOS X. Hence, on the latter systems the link state is read on startup, but any future changes to the link state may never be caught and propagated by the FEA to the interested parties. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=167 Revision Changes Path 1.4 +8 -1; commitid: 163b435388b07ea6; xorp/fea/ifconfig_observer_iphelper.cc 1.13 +11 -2; commitid: 163b435388b07ea6; xorp/fea/ifconfig_observer_netlink.cc 1.13 +11 -2; commitid: 163b435388b07ea6; xorp/fea/ifconfig_observer_rtsock.cc From bms@spc.org Mon Oct 17 18:14:02 2005 From: bms@spc.org (Bruce M Simpson) Date: Mon, 17 Oct 2005 18:14:02 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/fea In-Reply-To: <200510171127.j9HBRqZM005828@xorpc.icir.org> References: <200510171127.j9HBRqZM005828@xorpc.icir.org> Message-ID: <20051017171402.GB745@empiric.icir.org> On Mon, Oct 17, 2005 at 11:27:52AM +0000, Pavlin Radoslavov wrote: > Note that the asyncronous upcall notification by the kernel about > link state changes exists on Linux, NetBSD and OpenBSD, but > (currently) it doesn't appear to exist on FreeBSD and MacOS X. > Hence, on the latter systems the link state is read on startup, but > any future changes to the link state may never be caught and propagated > by the FEA to the interested parties. This means we need to process RTM_IFINFO in the routing socket observer. There's ifm->ifm_data.ifi_link_state under FreeBSD, but there's also ifm_active in struct ifmediareq which ifconfig parses and prints as 'active' or 'no carrier' if IFM_ACTIVE is set (FreeBSD uses the ifmedia interface). BMS From atanu@icir.org Mon Oct 17 19:57:57 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 18:57:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510171857.j9HIvvZa011682@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 18:57:57 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: Only set a LSA to MaxAge if its not already at MaxAge. Revision Changes Path 1.125 +3 -2; commitid: 2d874353f4337ea6; xorp/ospf/area_router.cc From pavlin@icir.org Mon Oct 17 20:33:35 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 12:33:35 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/fea In-Reply-To: Message from Bruce M Simpson of "Mon, 17 Oct 2005 18:14:02 BST." <20051017171402.GB745@empiric.icir.org> Message-ID: <200510171933.j9HJXZbL027211@possum.icir.org> > On Mon, Oct 17, 2005 at 11:27:52AM +0000, Pavlin Radoslavov wrote: > > Note that the asyncronous upcall notification by the kernel about > > link state changes exists on Linux, NetBSD and OpenBSD, but > > (currently) it doesn't appear to exist on FreeBSD and MacOS X. > > Hence, on the latter systems the link state is read on startup, but > > any future changes to the link state may never be caught and propagated > > by the FEA to the interested parties. > > This means we need to process RTM_IFINFO in the routing socket observer. > > There's ifm->ifm_data.ifi_link_state under FreeBSD, but there's also Thanks for the info. I was doing this already for NetBSD and OpenBSD, but the FreeBSD versions I checked (4.10 and 5.1) didn't have ifi_link_state. After some investigation I found that it is available only in FreeBSD-5.3 and later. The mechanism seems exactly same as in Net/OpenBSD, so the existing code observer should work out-of-the-box for FreeBSD-5.3 and later. I am afraid there is not much we can do to get asyncronous updates of the link state for MacOS X and for earlier versions of FreeBSD simply because the kernel doesn't have the support for it. > ifm_active in struct ifmediareq which ifconfig parses and prints as > 'active' or 'no carrier' if IFM_ACTIVE is set (FreeBSD uses the ifmedia > interface). Yes, I was using this mechanism already when we explicitly query the link state from the kernel. This mechanism exists even for earlier versions of FreeBSD, so at least on startup we get the link state right :) Pavlin From atanu@icir.org Mon Oct 17 20:47:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 19:47:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510171947.j9HJlTlK012309@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 19:47:29 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When removing a summary LSA the LSA that was constructed for the search did not have the advertising router field set so it was not being found. Unconditionally check that an LSA is not already in the database before announcing. Revision Changes Path 1.126 +9 -7; commitid: 2ffa4353ffd07ea6; xorp/ospf/area_router.cc From pavlin@icir.org Mon Oct 17 23:09:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 22:09:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510172209.j9HM9YJS014375@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 22:09:34 UTC XORP CVS repository Modified files: . ERRATA Log message: Add an ERRATA entry for the FEA that the link status monitoring may not work for FreeBSD-5.2 and earlier, and for MacOS X. Revision Changes Path 1.22 +8 -1; commitid: 380e435420eb7ea6; xorp/ERRATA From pavlin@icir.org Mon Oct 17 23:20:51 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 22:20:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510172220.j9HMKp5Y014504@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 22:20:51 UTC XORP CVS repository Modified files: . ERRATA Log message: Minor text editing. Revision Changes Path 1.23 +6 -5; commitid: 388f435423be7ea6; xorp/ERRATA From atanu@icir.org Mon Oct 17 23:22:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 22:22:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510172222.j9HMMGNx014552@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 22:22:16 UTC XORP CVS repository Modified files: ospf xrl_target.cc Log message: The debugging message no longer prints unset (output) parameters. Revision Changes Path 1.15 +5 -3; commitid: 38bd435424177ea6; xorp/ospf/xrl_target.cc From pavlin@icir.org Mon Oct 17 23:26:13 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 22:26:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510172226.j9HMQDF1014631@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 22:26:13 UTC XORP CVS repository Modified files: . ERRATA Log message: Clarify the Windows status for tracking the network link media. Revision Changes Path 1.24 +3 -2; commitid: 390e435424e27ea6; xorp/ERRATA From atanu@icir.org Mon Oct 17 23:53:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 17 Oct 2005 22:53:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510172253.j9HMrcUT015004@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-17 22:53:38 UTC XORP CVS repository Modified files: ospf Makefile.am Makefile.in Added files: ospf policy_varrw.cc policy_varrw.hh Log message: Policy variable manipulation. Revision Changes Path 1.20 +3 -1; commitid: 3a7b43542b717ea6; xorp/ospf/Makefile.am 1.17 +4 -2; commitid: 3a7b43542b717ea6; xorp/ospf/Makefile.in 1.1 +44 -0 xorp/ospf/policy_varrw.cc (new) 1.1 +22 -0 xorp/ospf/policy_varrw.hh (new) From pavlin@icir.org Tue Oct 18 00:14:30 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Mon, 17 Oct 2005 23:14:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510172314.j9HNEUSI015273@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-17 23:14:30 UTC XORP CVS repository Modified files: fea ifconfig_set_click.cc Log message: Bug fix in the ordering of some of the arguments of fwrite(). Revision Changes Path 1.30 +2 -2; commitid: 3b90435430457ea6; xorp/fea/ifconfig_set_click.cc From pavlin@icir.org Tue Oct 18 02:03:19 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 18 Oct 2005 01:03:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/tools Message-ID: <200510180103.j9I13JfX016300@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-18 01:03:19 UTC XORP CVS repository Modified files: fea ifconfig_set.cc fea/tools show_interfaces.cc Log message: * Don't explicitly disable the vif inside the iftree with the configuration if the interface is disabled, because such internal modification will result in FEA configuration that is out-of-sync from the rtrmgr configuration. Similarly, don't explicitly disable the interface addresses inside the iftree if the vif is disabled. In any case, when we are pushing the interface configuration, we consider the interface "enabled" flag when we manipulate the vifs, and we consider the interface and vif "enabled" flags when we manipulate the addresses so we don't need to modify the iftree itself. * When printing the network interface status by the "show_interfaces" command, an interface/vif is printed as ENABLED only if both the interface and the vif "enabled" flags are true. This fixes bugzilla entry #196 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=196 Revision Changes Path 1.34 +1 -10; commitid: 3f58435448a77ea6; xorp/fea/ifconfig_set.cc 1.15 +2 -2; commitid: 3f58435448a77ea6; xorp/fea/tools/show_interfaces.cc From pavlin@icir.org Tue Oct 18 02:25:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 18 Oct 2005 01:25:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libfeaclient Message-ID: <200510180125.j9I1PjCX016528@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-18 01:25:45 UTC XORP CVS repository Modified files: libfeaclient ifmgr_atoms.hh Log message: Add missing initializations inside the IfMgrIfAtom and IfMgrVIfAtom constructors. Revision Changes Path 1.21 +4 -3; commitid: 407743544f077ea6; xorp/libfeaclient/ifmgr_atoms.hh From pavlin@icir.org Tue Oct 18 05:15:15 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 18 Oct 2005 04:15:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510180415.j9I4FFoi020803@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-18 04:15:15 UTC XORP CVS repository Modified files: fea iftree.cc iftree.hh Log message: * Change slightly the semantics of IfTree::align_with(). Previously, if the item in the local tree is "disabled", then the state is not modified. Now, if an item is "disabled", its state is copied from the other tree, but the state is still marked as "disabled". This fixes a bug when, say, the state for a disabled network interface in the interface configuration tree is not filled-up with the information read from the kernel (e.g., MTU, MAC, etc). * Minor variable renaming. Revision Changes Path 1.32 +72 -30; commitid: 50d0435475e07ea6; xorp/fea/iftree.cc 1.33 +4 -3; commitid: 50d0435475e07ea6; xorp/fea/iftree.hh From pavlin@icir.org Tue Oct 18 05:16:55 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 18 Oct 2005 04:16:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/tools Message-ID: <200510180416.j9I4GtZO020856@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-18 04:16:55 UTC XORP CVS repository Modified files: fea/tools show_interfaces.cc Log message: Bug fix: print interface-related information even if there are no vifs for that interface. Revision Changes Path 1.16 +35 -3; commitid: 515f4354771c7ea6; xorp/fea/tools/show_interfaces.cc From pavlin@icir.org Tue Oct 18 06:04:08 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 18 Oct 2005 05:04:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510180504.j9I548wK021279@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-18 05:04:08 UTC XORP CVS repository Modified files: fea ifconfig_set.cc xrl_ifmanager.cc Log message: * Fix a bug with resetting the local interface tree in case there is an error with committing the new configuration, and there is also an error with restoring to the previous state. * Bug fix when committing the interface state: ignore deleted interfaces that are not recognized. Thus, we can restore to the original state if, say, the user tries to commit an interface that is not recognized by the system. The above bug fixes address some of the issues triggered by bugzilla entry #213 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=213 Revision Changes Path 1.35 +11 -1; commitid: 52d4435481327ea6; xorp/fea/ifconfig_set.cc 1.19 +2 -2; commitid: 52d4435481327ea6; xorp/fea/xrl_ifmanager.cc From atanu@icir.org Tue Oct 18 16:10:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 18 Oct 2005 15:10:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510181510.j9IFAqPE030268@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-18 15:10:52 UTC XORP CVS repository Modified files: ospf ospf.hh Log message: A method to access the policy filter. Revision Changes Path 1.62 +6 -1; commitid: 76214355107b7ea6; xorp/ospf/ospf.hh From atanu@icir.org Tue Oct 18 16:12:16 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 18 Oct 2005 15:12:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510181512.j9IFCGwU030350@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-18 15:12:16 UTC XORP CVS repository Modified files: ospf policy_varrw.cc policy_varrw.hh Log message: Read some of the variables from an AS-External-LSA. Revision Changes Path 1.2 +133 -3; commitid: 7671435510cf7ea6; xorp/ospf/policy_varrw.cc 1.2 +43 -1; commitid: 7671435510cf7ea6; xorp/ospf/policy_varrw.hh From atanu@icir.org Tue Oct 18 16:14:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 18 Oct 2005 15:14:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510181514.j9IFEDql030447@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-18 15:14:13 UTC XORP CVS repository Modified files: ospf external.cc external.hh Log message: A method to filter AS-External-LSAs inserted into the outbound path. Revision Changes Path 1.7 +28 -2; commitid: 76d2435511457ea6; xorp/ospf/external.cc 1.6 +6 -1; commitid: 76d2435511457ea6; xorp/ospf/external.hh From atanu@icir.org Tue Oct 18 16:28:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 18 Oct 2005 15:28:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510181528.j9IFSq40030709@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-18 15:28:52 UTC XORP CVS repository Modified files: ospf external.cc external.hh Log message: Add a comment about the memory management of an AS-External-LSA. Rename prime() to start_refresh_timer(). Revision Changes Path 1.8 +6 -4; commitid: 77d8435514b47ea6; xorp/ospf/external.cc 1.7 +3 -3; commitid: 77d8435514b47ea6; xorp/ospf/external.hh From atanu@icir.org Wed Oct 19 10:17:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 19 Oct 2005 09:17:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510190917.j9J9HD2Y040921@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-19 09:17:13 UTC XORP CVS repository Modified files: ospf external.cc Log message: Add debugging for redistributed routes. Revision Changes Path 1.9 +4 -1; commitid: 9fbe43560f187ea6; xorp/ospf/external.cc From atanu@icir.org Wed Oct 19 10:19:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 19 Oct 2005 09:19:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510190919.j9J9Jsst041004@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-19 09:19:54 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Hooks for import and exporting policy, only exporting is currently supported. Revision Changes Path 1.11 +18 -1; commitid: a01143560fb97ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Thu Oct 20 01:27:44 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 20 Oct 2005 00:27:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510200027.j9K0RimM051265@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-20 00:27:44 UTC XORP CVS repository Modified files: ospf xrl_io.cc Log message: Don't consider it to be a fatal error for a send to fail. Revision Changes Path 1.19 +2 -2; commitid: c8264356e47f7ea6; xorp/ospf/xrl_io.cc From bms@icir.org Thu Oct 20 11:58:26 2005 From: bms@icir.org (Bruce Simpson) Date: Thu, 20 Oct 2005 10:58:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510201058.j9KAwQ2K056197@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-20 10:58:26 UTC XORP CVS repository Modified files: libxorp buffered_asyncio.cc Log message: Explicitly handle IOT_DISCONNECT events on Win32; required for operation when using native event dispatch. Revision Changes Path 1.9 +22 -1; commitid: db6a435778457ea6; xorp/libxorp/buffered_asyncio.cc From bms@icir.org Thu Oct 20 12:00:08 2005 From: bms@icir.org (Bruce Simpson) Date: Thu, 20 Oct 2005 11:00:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510201100.j9KB08Bj056254@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-20 11:00:08 UTC XORP CVS repository Modified files: libxorp run_command.cc Log message: Use a native Win32 path to MSYS /bin/sh. TODO: Be smarter about locating it. Currently hardcoded to D:\MSYS\BIN\SH.EXE. Revision Changes Path 1.14 +2 -2; commitid: db99435778a37ea6; xorp/libxorp/run_command.cc From pavlin@icir.org Thu Oct 20 19:31:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 20 Oct 2005 18:31:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510201831.j9KIVgmq065846@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-20 18:31:42 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Add a note about FreeBSD-5.4, that XORP compiles on it and the the internal tests succeed. Revision Changes Path 1.34 +2 -6; commitid: 101044357e2087ea6; xorp/BUILD_NOTES From atanu@icir.org Thu Oct 20 23:10:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 20 Oct 2005 22:10:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510202210.j9KMANbQ068201@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-20 22:10:23 UTC XORP CVS repository Modified files: ospf peer.cc Log message: When flooding LSAs if the LSA originally came from the DR or BDR on this interface the chances are high that the other routers have already seen this LSA (the spec says don't flood on such an interface). This check was being performed even if the interface was not supposed to elect a DR or BDR as in the case of Point-To-Multipoint. Bug found by: Nick Feamster Revision Changes Path 1.171 +2 -2; commitid: 10a4e435815ce7ea6; xorp/ospf/peer.cc From atanu@icir.org Fri Oct 21 10:34:49 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 09:34:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510210934.j9L9YnLN074510@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 09:34:49 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: If a potential route has the nexthop falling inside the network being advertised don't try and install the route. Revision Changes Path 1.127 +9 -2; commitid: 122f34358b6377ea6; xorp/ospf/area_router.cc From atanu@icir.org Fri Oct 21 11:06:51 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 10:06:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510211006.j9LA6pqA075101@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 10:06:51 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: The name returned by an AS-External-LSA has been changed from "ASExternal" to "ASExt-1" or "ASExt-2". Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=275 Requested by: Patrick Marc Preuss Revision Changes Path 1.67 +2 -2; commitid: 125424358bdb97ea6; xorp/ospf/lsa.hh From atanu@icir.org Fri Oct 21 19:37:00 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 18:37:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510211837.j9LIb0nl083990@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 18:37:00 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Send the OSPFv2 targetname "ospfv2" to the policy manager not the config name "ospf4". Revision Changes Path 1.12 +6 -7; commitid: 147fb4359354b7ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Fri Oct 21 19:43:19 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 18:43:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510211843.j9LIhJNB084134@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 18:43:19 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Second attempt. The name returned by an AS-External-LSA has been changed from "ASExternal" to "ASExt-1" or "ASExt-2". Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=275 Requested by: Patrick Marc Preuss Revision Changes Path 1.68 +2 -2; commitid: 1488b435936c67ea6; xorp/ospf/lsa.hh From pavlin@icir.org Fri Oct 21 20:58:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 21 Oct 2005 19:58:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510211958.j9LJwji7085079@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-21 19:58:45 UTC XORP CVS repository Modified files: libxorp popen.cc Log message: Set stdout and stderr of the child process to unbuffered. Revision Changes Path 1.8 +4 -1; commitid: 14c3e435948657ea6; xorp/libxorp/popen.cc From pavlin@icir.org Fri Oct 21 21:00:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 21 Oct 2005 20:00:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510212000.j9LK0kiS085187@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-21 20:00:46 UTC XORP CVS repository Modified files: libxorp run_command.cc run_command.hh Log message: Refactor the implementation of RunCommandBase::append_data() so now it reads appropriately stderr if the executed command prints on stderr and exits immediately. Bug found by: Nick Feamster Revision Changes Path 1.15 +69 -62; commitid: 14c91435948987ea6; xorp/libxorp/run_command.cc 1.8 +4 -1; commitid: 14c91435948987ea6; xorp/libxorp/run_command.hh From pavlin@icir.org Fri Oct 21 21:01:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 21 Oct 2005 20:01:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510212001.j9LK1nBc085238@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-21 20:01:49 UTC XORP CVS repository Modified files: fea click_socket.cc Log message: Fix the formatting of the printed error message if the execution of userland Click fails. Revision Changes Path 1.28 +10 -3; commitid: 14cdd435949057ea6; xorp/fea/click_socket.cc From atanu@icir.org Fri Oct 21 21:51:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 20:51:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510212051.j9LKpl3s085726@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 20:51:47 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: The area router class should not attempt to age AS-External-LSAs they will be aged by the external class. Discovered by the assert in maxage_reached in the area router class being triggered. Revision Changes Path 1.128 +3 -2; commitid: 14ec3435954e27ea6; xorp/ospf/area_router.cc From atanu@icir.org Fri Oct 21 22:24:55 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 21:24:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510212124.j9LLOtDT086076@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 21:24:55 UTC XORP CVS repository Modified files: ospf area_router.hh Log message: The method "refresh_router_lsa" is now externally visable allowing external entities to force the generation of a new Router-LSA. A Router-LSA carries three flags; is this a border router, is this an AS boudary router, is this a virtual link endpoint. If the states of any of these flags changes a new Router-LSA has to be generated. Revision Changes Path 1.76 +9 -8; commitid: 1502143595ca67ea6; xorp/ospf/area_router.hh From atanu@icir.org Fri Oct 21 22:27:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 21:27:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510212127.j9LLRV9i086180@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 21:27:31 UTC XORP CVS repository Modified files: ospf peer_manager.cc peer_manager.hh Log message: A new method "refresh_router_lsas" that causes a new Router-LSA to be generated in all areas. The method "refresh_router_lsa" is now externally visable allowing external entities to force the generation of a new Router-LSA. A Router-LSA carries three flags; is this a border router, is this an AS boudary router, is this a virtual link endpoint. If the states of any of these flags changes a new Router-LSA has to be generated. Revision Changes Path 1.68 +11 -1; commitid: 1508743595d427ea6; xorp/ospf/peer_manager.cc 1.48 +7 -1; commitid: 1508743595d427ea6; xorp/ospf/peer_manager.hh From atanu@icir.org Fri Oct 21 23:09:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 21 Oct 2005 22:09:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510212209.j9LM9VP5086718@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-21 22:09:31 UTC XORP CVS repository Modified files: ospf external.cc Log message: 1) When the first route is redistributed cause the generation of a new Router-LSA with BIT E set. When the last route is withdrawn generate a new Router-LSA with BIT E unset. 2) Passing 0 instead of A::ZERO(). 3) maxage_reached() has an over aggresive assert that only non self originated AS-External-LSAs can reach MaxAge. The method is also used to withdraw self originated AS-External-LSAs. 4) Typo, testing for != end() as opposed to == end(). Revision Changes Path 1.10 +8 -4; commitid: 152a34359671b7ea6; xorp/ospf/external.cc From pavlin@icir.org Sat Oct 22 02:00:49 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 22 Oct 2005 01:00:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510220100.j9M10nvT088160@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-22 01:00:49 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc util.cc util.hh Log message: Add new function is_quotable_string() and use it instead of has_empty_space() to decide whether to print quotes around the value of a multi-value node instance of type TEXT. This fixes bugzilla entry #154. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=154 Revision Changes Path 1.93 +2 -2; commitid: 1581143598ebd7ea6; xorp/rtrmgr/conf_tree_node.cc 1.20 +15 -1; commitid: 1581143598ebd7ea6; xorp/rtrmgr/util.cc 1.12 +13 -3; commitid: 1581143598ebd7ea6; xorp/rtrmgr/util.hh From pavlin@icir.org Sat Oct 22 02:41:45 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 22 Oct 2005 01:41:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/rtrmgr Message-ID: <200510220141.j9M1fjmT088565@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-22 01:41:45 UTC XORP CVS repository Modified files: libxorp utils.cc utils.hh rtrmgr op_commands.yy util.cc util.hh y.opcmd_tab.cc Log message: Move the implementation of strip_empty_spaces() and has_empty_space() from rtrmgr/util.{hh,cc} to libxorp/utils.{hh,cc} Revision Changes Path 1.6 +38 -1; commitid: 159b5435998a57ea6; xorp/libxorp/utils.cc 1.10 +17 -1; commitid: 159b5435998a57ea6; xorp/libxorp/utils.hh 1.18 +1 -0; commitid: 159b5435998a57ea6; xorp/rtrmgr/op_commands.yy 1.21 +1 -38; commitid: 159b5435998a57ea6; xorp/rtrmgr/util.cc 1.13 +1 -17; commitid: 159b5435998a57ea6; xorp/rtrmgr/util.hh 1.26 +20 -19; commitid: 159b5435998a57ea6; xorp/rtrmgr/y.opcmd_tab.cc From pavlin@icir.org Sat Oct 22 02:44:34 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 22 Oct 2005 01:44:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200510220144.j9M1iYBE088645@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-22 01:44:34 UTC XORP CVS repository Modified files: cli cli_client.cc Log message: If we try to print the help for an unrecognized command, then print an error that the command is not recognized. This fixes bugzilla entry #156. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=156 Revision Changes Path 1.42 +9 -3; commitid: 15a2c435999407ea6; xorp/cli/cli_client.cc From atanu@icir.org Sat Oct 22 04:38:02 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 03:38:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220338.j9M3c2FM091352@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 03:38:02 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: When an LSA arrives on an interface and it matches an older LSA in the database update_lsa() is called to replace the the LSA in the database. There is an assert in update_lsa() to verify that the original LSA is still valid. If the arriving LSA is an AS-External-LSA the external class invalidates the LSA and the assert trips. Never use update_lsa() when the arriving LSA is an AS-External-LSA, use add_lsa() having first verified that the original LSA is invalid. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=274 Revision Changes Path 1.129 +14 -5; commitid: 164bd4359b4187ea6; xorp/ospf/area_router.cc From atanu@icir.org Sat Oct 22 04:53:46 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 03:53:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220353.j9M3rklP091568@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 03:53:46 UTC XORP CVS repository Modified files: ospf TODO peer_manager.cc Log message: When the router becomes or stops being an area border router force the generation of a new Router-LSA. Remember to introduce equivalent code for the addition and deletion of virtual links. Revision Changes Path 1.55 +8 -1; commitid: 165934359b7c97ea6; xorp/ospf/TODO 1.69 +15 -2; commitid: 165934359b7c97ea6; xorp/ospf/peer_manager.cc From atanu@icir.org Sat Oct 22 05:43:43 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 04:43:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220443.j9M4hhUL092106@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 04:43:43 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Initialise all the member variables of ASExternalLSA. Revision Changes Path 1.69 +4 -2; commitid: 167af4359c37e7ea6; xorp/ospf/lsa.hh From atanu@icir.org Sat Oct 22 07:15:30 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 06:15:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220615.j9M6FU68093045@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 06:15:30 UTC XORP CVS repository Modified files: ospf external.cc external.hh policy_varrw.cc policy_varrw.hh Log message: Previously the policy variable took a LSA it now takes component variables. The refactoring makes a cleaner implementation and should make it easier to use for import policies. Revision Changes Path 1.11 +12 -11; commitid: 16b544359d8fe7ea6; xorp/ospf/external.cc 1.8 +6 -4; commitid: 16b544359d8fe7ea6; xorp/ospf/external.hh 1.3 +16 -65; commitid: 16b544359d8fe7ea6; xorp/ospf/policy_varrw.cc 1.3 +8 -14; commitid: 16b544359d8fe7ea6; xorp/ospf/policy_varrw.hh From atanu@icir.org Sat Oct 22 07:53:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 06:53:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220653.j9M6r5dP093433@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 06:53:05 UTC XORP CVS repository Modified files: ospf policy_varrw.cc Log message: Support for writing policy variables. Revision Changes Path 1.4 +27 -7; commitid: 16cde4359e1d07ea6; xorp/ospf/policy_varrw.cc From atanu@icir.org Sat Oct 22 09:01:56 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 08:01:56 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220801.j9M81uXa094268@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 08:01:56 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Add a filtered flag to the routing table entry. Revision Changes Path 1.20 +14 -2; commitid: 170214359f1f37ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 22 09:49:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 08:49:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510220849.j9M8nlkU094786@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 08:49:47 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Entry point for import filters. Revision Changes Path 1.20 +16 -5; commitid: 172254359fd2a7ea6; xorp/ospf/routing_table.cc 1.21 +7 -1; commitid: 172254359fd2a7ea6; xorp/ospf/routing_table.hh From atanu@icir.org Sat Oct 22 18:35:04 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 17:35:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510221735.j9MHZ4tL002072@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 17:35:04 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Tell the policy manager about all the policy variables. Revision Changes Path 1.13 +5 -1; commitid: 7fd435a78477ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Sat Oct 22 18:40:36 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 17:40:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510221740.j9MHeZNY002173@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 17:40:35 UTC XORP CVS repository Modified files: ospf external.cc Log message: Set the external routing tag and bit E so any modification made by policy are reflected in the AS-External-LSA. Revision Changes Path 1.12 +3 -1; commitid: 862435a79937ea6; xorp/ospf/external.cc From atanu@icir.org Sat Oct 22 19:44:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 18:44:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510221844.j9MIiqWP002824@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 18:44:52 UTC XORP CVS repository Modified files: ospf xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Put in the hooks to get the list of configured areas. Revision Changes Path 1.16 +7 -1; commitid: ab9435a88a27ea6; xorp/ospf/xrl_target.cc 1.10 +8 -1; commitid: ab9435a88a27ea6; xorp/ospf/xrl_target.hh 1.6 +8 -1; commitid: ab9435a88a27ea6; xorp/xrl/interfaces/ospfv2.xif 1.7 +39 -1; commitid: ab9435a88a27ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.7 +20 -1; commitid: ab9435a88a27ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.9 +6 -1; commitid: ab9435a88a27ea6; xorp/xrl/targets/ospfv2.xrls 1.9 +44 -1; commitid: ab9435a88a27ea6; xorp/xrl/targets/ospfv2_base.cc 1.9 +12 -1; commitid: ab9435a88a27ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Sat Oct 22 23:45:42 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sat, 22 Oct 2005 22:45:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510222245.j9MMjguE006368@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-22 22:45:42 UTC XORP CVS repository Modified files: ospf ospf.cc ospf.hh peer_manager.cc peer_manager.hh xrl_target.cc xrl_target.hh Log message: Allow the retrieval of the list of areas by XRL. Revision Changes Path 1.46 +11 -2; commitid: 18bb435ac1157ea6; xorp/ospf/ospf.cc 1.63 +6 -1; commitid: 18bb435ac1157ea6; xorp/ospf/ospf.hh 1.70 +12 -1; commitid: 18bb435ac1157ea6; xorp/ospf/peer_manager.cc 1.49 +6 -1; commitid: 18bb435ac1157ea6; xorp/ospf/peer_manager.hh 1.17 +11 -2; commitid: 18bb435ac1157ea6; xorp/ospf/xrl_target.cc 1.11 +3 -5; commitid: 18bb435ac1157ea6; xorp/ospf/xrl_target.hh From atanu@icir.org Sun Oct 23 04:51:44 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 03:51:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510230351.j9N3pieF008809@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 03:51:44 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: 1) If an area is not supplied then fetch the list of areas and print them all. 2) Add support for filtering so a specific LS type can be selected. Revision Changes Path 1.5 +170 -50; commitid: 224e435b08cf7ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Sun Oct 23 04:59:01 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 03:59:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510230359.j9N3x1fq008930@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 03:59:01 UTC XORP CVS repository Modified files: etc/templates ospfv2.cmds Log message: Add more database commands specifically support for filtering on LSA type. Revision Changes Path 1.3 +228 -8; commitid: 22c7435b0a857ea6; xorp/etc/templates/ospfv2.cmds From atanu@icir.org Sun Oct 23 10:27:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 09:27:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510230927.j9N9RcxQ012004@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 09:27:38 UTC XORP CVS repository Modified files: ospf lsa.hh Log message: Return the name of an LSA given a type ID. Revision Changes Path 1.70 +10 -1; commitid: 2ec9435b57897ea6; xorp/ospf/lsa.hh From atanu@icir.org Sun Oct 23 10:29:48 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 09:29:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510230929.j9N9TmFJ012096@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 09:29:48 UTC XORP CVS repository Modified files: ospf ospf.hh xorp_ospfv2.cc xorp_ospfv3.cc Log message: Move the XRL target name into the header file so it can be shared by the operational commands. Revision Changes Path 1.64 +7 -1; commitid: 2f21435b580b7ea6; xorp/ospf/ospf.hh 1.9 +2 -2; commitid: 2f21435b580b7ea6; xorp/ospf/xorp_ospfv2.cc 1.10 +2 -2; commitid: 2f21435b580b7ea6; xorp/ospf/xorp_ospfv3.cc From atanu@icir.org Sun Oct 23 10:33:39 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 09:33:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510230933.j9N9XdIw012196@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 09:33:39 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Support for printing a summary and OSPFv3 support. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=275 Revision Changes Path 1.6 +107 -17; commitid: 2f89435b58f37ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Sun Oct 23 10:52:29 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 23 Oct 2005 09:52:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510230952.j9N9qTmd012423@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-23 09:52:29 UTC XORP CVS repository Modified files: etc/templates ospfv2.cmds Log message: Summary commands for LSA databases. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=275 Revision Changes Path 1.4 +75 -1; commitid: 306c435b5d5c7ea6; xorp/etc/templates/ospfv2.cmds From pavlin@icir.org Sun Oct 23 19:47:25 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 23 Oct 2005 18:47:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510231847.j9NIlPcr019701@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-23 18:47:25 UTC XORP CVS repository Modified files: libxorp run_command.cc run_command.hh Log message: Refactor the mechanism for generating the error messages if there is an error. Submitted by: Marat Nepomnyashy Revision Changes Path 1.16 +28 -20; commitid: 4cd5435bda757ea6; xorp/libxorp/run_command.cc 1.9 +6 -3; commitid: 4cd5435bda757ea6; xorp/libxorp/run_command.hh From pavlin@icir.org Sun Oct 23 19:48:04 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 23 Oct 2005 18:48:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510231848.j9NIm4O1019745@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-23 18:48:04 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: Print a better formatted error message if an operation command fails. Submitted by: Marat Nepomnyashy Revision Changes Path 1.101 +7 -4; commitid: 4d07435bdac67ea6; xorp/rtrmgr/cli.cc From abittau@icir.org Sun Oct 23 21:41:40 2005 From: abittau@icir.org (Andrea Bittau) Date: Sun, 23 Oct 2005 20:41:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/etc/templates xorp/policy xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510232041.j9NKfeHY020910@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-10-23 20:41:40 UTC XORP CVS repository Modified files: . configure etc/templates static_routes.tp policy Makefile.am Makefile.in filter_manager.cc filter_manager.hh policy_target.cc policy_target.hh process_watch.cc process_watch.hh xrl_target.cc xrl_target.hh xrl/interfaces policy.xif policy_xif.cc policy_xif.hh xrl/targets policy.xrls policy_base.cc policy_base.hh Log message: support for a map protocol<->process. i.e. the protocol in policy no longer needs to be the XORP process name. Interanlly, the policy uses only the logical name. The XORP process name is used only in XRL stuff. static_routes are now referred to as "static" in policy for example. To use this feature execute this as the FIRST command in policy [before varmap]: %create: xrl "$(policy.targetname)/policy/0.1/set_proto_target?protocol:txt=static&target:txt=static_routes"; it should be quite self explanatory Revision Changes Path 1.163 +1 -1; commitid: 510e435bf4c27ea6; xorp/configure 1.26 +4 -3; commitid: 510e435bf4c27ea6; xorp/etc/templates/static_routes.tp 1.11 +3 -1; commitid: 510e435bf4c27ea6; xorp/policy/Makefile.am 1.29 +4 -2; commitid: 510e435bf4c27ea6; xorp/policy/Makefile.in 1.6 +28 -20; commitid: 510e435bf4c27ea6; xorp/policy/filter_manager.cc 1.3 +9 -16; commitid: 510e435bf4c27ea6; xorp/policy/filter_manager.hh 1.10 +10 -3; commitid: 510e435bf4c27ea6; xorp/policy/policy_target.cc 1.9 +10 -1; commitid: 510e435bf4c27ea6; xorp/policy/policy_target.hh 1.4 +28 -20; commitid: 510e435bf4c27ea6; xorp/policy/process_watch.cc 1.3 +11 -17; commitid: 510e435bf4c27ea6; xorp/policy/process_watch.hh 1.10 +11 -3; commitid: 510e435bf4c27ea6; xorp/policy/xrl_target.cc 1.8 +7 -3; commitid: 510e435bf4c27ea6; xorp/policy/xrl_target.hh 1.8 +9 -1; commitid: 510e435bf4c27ea6; xorp/xrl/interfaces/policy.xif 1.10 +35 -1; commitid: 510e435bf4c27ea6; xorp/xrl/interfaces/policy_xif.cc 1.9 +26 -1; commitid: 510e435bf4c27ea6; xorp/xrl/interfaces/policy_xif.hh 1.10 +10 -1; commitid: 510e435bf4c27ea6; xorp/xrl/targets/policy.xrls 1.10 +32 -1; commitid: 510e435bf4c27ea6; xorp/xrl/targets/policy_base.cc 1.10 +17 -1; commitid: 510e435bf4c27ea6; xorp/xrl/targets/policy_base.hh From abittau@icir.org Sun Oct 23 21:49:19 2005 From: abittau@icir.org (Andrea Bittau) Date: Sun, 23 Oct 2005 20:49:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200510232049.j9NKnJ4a021030@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-10-23 20:49:19 UTC XORP CVS repository Added files: policy protocol_map.cc protocol_map.hh Log message: these files might aid compilation. Revision Changes Path 1.1 +69 -0 xorp/policy/protocol_map.cc (new) 1.1 +68 -0 xorp/policy/protocol_map.hh (new) From atanu@icir.org Mon Oct 24 08:26:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 24 Oct 2005 07:26:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510240726.j9O7QxIk027598@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-24 07:26:59 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Add allow-range statement for priority, hello-interval, router-dead-interval, interface-cost and inftransdelay. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=293 Revision Changes Path 1.14 +12 -1; commitid: 6bb3435c8cc27ea6; xorp/etc/templates/ospfv2.tp From bms@icir.org Mon Oct 24 13:34:09 2005 From: bms@icir.org (Bruce Simpson) Date: Mon, 24 Oct 2005 12:34:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510241234.j9OCY9X1032110@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-24 12:34:09 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Add information to BUILD_NOTES about building and using XORP on Windows Server 2003. Point out that the --with-windows-dispatcher code is currently for experimental use only. Revision Changes Path 1.35 +36 -1; commitid: 7d41435cd4a17ea6; xorp/BUILD_NOTES From bms@icir.org Mon Oct 24 13:43:39 2005 From: bms@icir.org (Bruce Simpson) Date: Mon, 24 Oct 2005 12:43:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510241243.j9OChdfH032279@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-24 12:43:39 UTC XORP CVS repository Modified files: libxorp timer.cc Log message: TimerList::system_sleep() accepts a TimeVal containing the amount of time to sleep. In Win32's SetWaitableTimer() terms, this is a relative timestamp, and thus needs to be negative, so multiply the 64-bit LARGE_INTEGER passed to it by -1. Revision Changes Path 1.27 +2 -1; commitid: 7dfe435cd6f47ea6; xorp/libxorp/timer.cc From bms@icir.org Mon Oct 24 13:57:05 2005 From: bms@icir.org (Bruce Simpson) Date: Mon, 24 Oct 2005 12:57:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510241257.j9OCv5oo032500@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-24 12:57:05 UTC XORP CVS repository Modified files: libxorp win_dispatcher.cc Log message: This is the third rewrite of the Win32 native I/O dispatcher. Cut over to WSAEventSelect() from WSAAsyncSelect(). Use a Win32 Event object (in POSIX threads terminology, a condition variable). This is an improvement on the relatively large latency of dealing with a PostMessage() from a WinSock2 helper thread and should improve stability at the XRL layer. WSAEnumNetworkEvents() is used to poll each socket against the Event it was registered against for WinSock asynchronous events. Cut over from MsgWaitForMultipleObjectsEx() to WaitForMultipleObjectsEx(). TODO: Stop linking against USER32.DLL if we don't need it. TODO: Use a pool of event objects and stripe across them if it buys us anything. Other changes: - Nuke imported definitions from the Platform SDK. - Nuke message pump code. - Nuke message window creation code. - Style. Obtained from: p4://depot/user/bms/xorp_win/... Revision Changes Path 1.4 +95 -122; commitid: 7eda435cd9ff7ea6; xorp/libxorp/win_dispatcher.cc From atanu@icir.org Mon Oct 24 18:39:30 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 24 Oct 2005 17:39:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto xorp/ospf Message-ID: <200510241739.j9OHdU6S037129@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-24 17:39:30 UTC XORP CVS repository Modified files: libproto spt.hh test_spt.cc ospf area_router.cc trace.hh Log message: The SPT library was unconditionally printing out warning messages if a node was not reachable. Unreachable nodes in a real network will be a common occurence. Change the warning to a conditional trace message, add a trace variable to OSPF to allow the message to be enabled/disabled, leave it enabled for the time being. Revision Changes Path 1.9 +11 -6; commitid: 90d5435d1c507ea6; xorp/libproto/spt.hh 1.8 +13 -13; commitid: 90d5435d1c507ea6; xorp/libproto/test_spt.cc 1.130 +2 -2; commitid: 90d5435d1c507ea6; xorp/ospf/area_router.cc 1.5 +4 -2; commitid: 90d5435d1c507ea6; xorp/ospf/trace.hh From atanu@icir.org Mon Oct 24 19:08:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 24 Oct 2005 18:08:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510241808.j9OI8LKC037578@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-24 18:08:21 UTC XORP CVS repository Modified files: bgp peer.cc Log message: If a notify is received in response to an open then it highly likely that a mis-configuration has occured, take the state to IDLE and leave it there. Revision Changes Path 1.98 +4 -1; commitid: 92af435d23147ea6; xorp/bgp/peer.cc From atanu@icir.org Mon Oct 24 19:40:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 24 Oct 2005 18:40:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510241840.j9OIesxT037972@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-24 18:40:54 UTC XORP CVS repository Modified files: bgp bgp.cc bgp.hh peer_list.cc peer_list.hh xrl_target.cc Log message: Allow the BGP ID or the routers AS number to be changed. If either of the above is changed bounce all peerings. The all_stop() method now takes a restart flag to allow it to used for bouncing peerings. When bouncing the peerings if the state of the peer is IDLE and its administrative state is START kick the peering by sending a start event. If a misconfiguration has taken the peering to idle sending the start will resume connection attempts. Return the admin status of the peer (previously START was returned unconditionally). Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=100 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=104 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=277 Revision Changes Path 1.56 +23 -20; commitid: 9431435d2ab47ea6; xorp/bgp/bgp.cc 1.45 +11 -11; commitid: 9431435d2ab47ea6; xorp/bgp/bgp.hh 1.20 +7 -3; commitid: 9431435d2ab47ea6; xorp/bgp/peer_list.cc 1.8 +2 -2; commitid: 9431435d2ab47ea6; xorp/bgp/peer_list.hh 1.42 +5 -5; commitid: 9431435d2ab47ea6; xorp/bgp/xrl_target.cc From pavlin@icir.org Tue Oct 25 18:19:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 25 Oct 2005 17:19:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510251719.j9PHJl6x053446@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-25 17:19:47 UTC XORP CVS repository Modified files: libxorp selector.cc Log message: Bug fix in SelectorList::Node::is_empty() OLD: return (_mask[SEL_RD_IDX] == _mask[SEL_WR_IDX] == _mask[SEL_EX_IDX] == 0); This is wrong, because "0 == 1 == 2 == 0" also returns true. NEW: return ((_mask[SEL_RD_IDX] == 0) && (_mask[SEL_WR_IDX] == 0) && (_mask[SEL_EX_IDX] == 0)); Bug found by: Mark Doll Revision Changes Path 1.31 +3 -2; commitid: d0a2435e68a17ea6; xorp/libxorp/selector.cc From atanu@icir.org Tue Oct 25 19:11:27 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 25 Oct 2005 18:11:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510251811.j9PIBRAJ054218@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-25 18:11:27 UTC XORP CVS repository Modified files: bgp xrl_target.cc xrl_target.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: The XRL hooks for changing peer variables. Revision Changes Path 1.43 +81 -1; commitid: d37b435e754c7ea6; xorp/bgp/xrl_target.cc 1.30 +33 -1; commitid: d37b435e754c7ea6; xorp/bgp/xrl_target.hh 1.23 +69 -1; commitid: d37b435e754c7ea6; xorp/xrl/interfaces/bgp.xif 1.35 +161 -1; commitid: d37b435e754c7ea6; xorp/xrl/interfaces/bgp_xif.cc 1.34 +135 -1; commitid: d37b435e754c7ea6; xorp/xrl/interfaces/bgp_xif.hh 1.38 +59 -1; commitid: d37b435e754c7ea6; xorp/xrl/targets/bgp.xrls 1.40 +137 -1; commitid: d37b435e754c7ea6; xorp/xrl/targets/bgp_base.cc 1.47 +99 -1; commitid: d37b435e754c7ea6; xorp/xrl/targets/bgp_base.hh From pavlin@icir.org Tue Oct 25 21:02:44 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Tue, 25 Oct 2005 20:02:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510252002.j9PK2igs055506@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-25 20:02:44 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh template_base_command.cc Log message: * Add new method ConfigTreeNode::expand_variable_to_full_varname() * Use the above method to compose better error messages when attempting to assign an invalid value to a variable. Revision Changes Path 1.94 +50 -3; commitid: d8b5435e8f197ea6; xorp/rtrmgr/conf_tree_node.cc 1.54 +3 -1; commitid: d8b5435e8f197ea6; xorp/rtrmgr/conf_tree_node.hh 1.8 +13 -7; commitid: d8b5435e8f197ea6; xorp/rtrmgr/template_base_command.cc From atanu@icir.org Tue Oct 25 21:44:35 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 25 Oct 2005 20:44:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510252044.j9PKiZBi056070@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-25 20:44:35 UTC XORP CVS repository Modified files: bgp xrl_target.cc xrl_target.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: The XRL hooks for changing peer variables. Revision Changes Path 1.44 +61 -1; commitid: dab7435e99307ea6; xorp/bgp/xrl_target.cc 1.31 +25 -1; commitid: dab7435e99307ea6; xorp/bgp/xrl_target.hh 1.24 +55 -2; commitid: dab7435e99307ea6; xorp/xrl/interfaces/bgp.xif 1.36 +121 -1; commitid: dab7435e99307ea6; xorp/xrl/interfaces/bgp_xif.cc 1.35 +82 -2; commitid: dab7435e99307ea6; xorp/xrl/interfaces/bgp_xif.hh 1.39 +25 -2; commitid: dab7435e99307ea6; xorp/xrl/targets/bgp.xrls 1.41 +103 -1; commitid: dab7435e99307ea6; xorp/xrl/targets/bgp_base.cc 1.48 +55 -2; commitid: dab7435e99307ea6; xorp/xrl/targets/bgp_base.hh From atanu@icir.org Tue Oct 25 22:22:30 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 25 Oct 2005 21:22:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510252122.j9PLMURs056467@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-25 21:22:30 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Allow peer variables to be set/changed. Revision Changes Path 1.57 +8 -7; commitid: dc78435ea2167ea6; xorp/etc/templates/bgp.tp From atanu@icir.org Tue Oct 25 22:25:51 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 25 Oct 2005 21:25:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510252125.j9PLPpEs056550@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-25 21:25:51 UTC XORP CVS repository Modified files: etc/templates bgp.tp Log message: Comment out setting of MD5 variables as the backing code doesn't exist. Revision Changes Path 1.58 +6 -2; commitid: dccb435ea2de7ea6; xorp/etc/templates/bgp.tp From atanu@icir.org Tue Oct 25 23:28:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Tue, 25 Oct 2005 22:28:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510252228.j9PMSLXv057308@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-25 22:28:21 UTC XORP CVS repository Modified files: bgp xrl_target.cc xrl_target.hh xrl/interfaces bgp.xif bgp_xif.cc bgp_xif.hh xrl/targets bgp.xrls bgp_base.cc bgp_base.hh Log message: Removing a setting that makes no sense. Revision Changes Path 1.45 +1 -21; commitid: df8d435eb1827ea6; xorp/bgp/xrl_target.cc 1.32 +1 -9; commitid: df8d435eb1827ea6; xorp/bgp/xrl_target.hh 1.25 +1 -18; commitid: df8d435eb1827ea6; xorp/xrl/interfaces/bgp.xif 1.37 +1 -41; commitid: df8d435eb1827ea6; xorp/xrl/interfaces/bgp_xif.cc 1.36 +1 -35; commitid: df8d435eb1827ea6; xorp/xrl/interfaces/bgp_xif.hh 1.40 +1 -16; commitid: df8d435eb1827ea6; xorp/xrl/targets/bgp.xrls 1.42 +1 -35; commitid: df8d435eb1827ea6; xorp/xrl/targets/bgp_base.cc 1.49 +1 -26; commitid: df8d435eb1827ea6; xorp/xrl/targets/bgp_base.hh From pavlin@icir.org Wed Oct 26 05:52:20 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 04:52:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510260452.j9Q4qKqB060579@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 04:52:20 UTC XORP CVS repository Modified files: fea ifmanager_transaction.hh Log message: Add a comment about the min and max MTU. Revision Changes Path 1.13 +2 -1; commitid: ec8a435f0b7b7ea6; xorp/fea/ifmanager_transaction.hh From pavlin@icir.org Wed Oct 26 08:02:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 07:02:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510260702.j9Q72kQ3061954@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 07:02:46 UTC XORP CVS repository Modified files: etc/templates interfaces.tp Log message: Add %allow-range for the interface mtu (as defined in RFC 791 and RFC 1191). This also is needed as part of the fix for bugzilla entry #155 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=155 Revision Changes Path 1.22 +3 -1; commitid: f1d5435f29a27ea6; xorp/etc/templates/interfaces.tp From pavlin@icir.org Wed Oct 26 08:06:29 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 07:06:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510260706.j9Q76TCg062054@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 07:06:29 UTC XORP CVS repository Modified files: rtrmgr cli.cc conf_tree.cc conf_tree_node.cc conf_tree_node.hh slave_conf_tree_node.cc slave_conf_tree_node.hh template_base_command.cc template_base_command.hh Log message: Check the value of a variable whether it is valid when it is set (via xorpsh) instead of during commit time. This fixes bugzilla entry #155 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=155 Revision Changes Path 1.102 +40 -8; commitid: f21a435f2a637ea6; xorp/rtrmgr/cli.cc 1.48 +19 -9; commitid: f21a435f2a637ea6; xorp/rtrmgr/conf_tree.cc 1.95 +74 -8; commitid: f21a435f2a637ea6; xorp/rtrmgr/conf_tree_node.cc 1.55 +5 -3; commitid: f21a435f2a637ea6; xorp/rtrmgr/conf_tree_node.hh 1.27 +1 -30; commitid: f21a435f2a637ea6; xorp/rtrmgr/slave_conf_tree_node.cc 1.19 +1 -2; commitid: f21a435f2a637ea6; xorp/rtrmgr/slave_conf_tree_node.hh 1.9 +61 -24; commitid: f21a435f2a637ea6; xorp/rtrmgr/template_base_command.cc 1.4 +14 -2; commitid: f21a435f2a637ea6; xorp/rtrmgr/template_base_command.hh From atanu@icir.org Wed Oct 26 08:41:21 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 26 Oct 2005 07:41:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510260741.j9Q7fLBu062483@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-26 07:41:21 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Refactor to make it simpler to add printers. Revision Changes Path 1.7 +226 -9; commitid: f3f8435f33217ea6; xorp/ospf/tools/print_lsas.cc From pavlin@icir.org Wed Oct 26 08:52:39 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 07:52:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes Message-ID: <200510260752.j9Q7qdQ0062648@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 07:52:39 UTC XORP CVS repository Added files: devnotes routing-refs.txt Log message: Add a new file that will contain a list of routing references. For now it contains two IS-IS books (one of them suggested by bugzilla entry #158). Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=158 Revision Changes Path 1.1 +16 -0 xorp/devnotes/routing-refs.txt (new) From atanu@icir.org Wed Oct 26 08:53:44 2005 From: atanu@icir.org (Atanu Ghosh) Date: Wed, 26 Oct 2005 07:53:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510260753.j9Q7ridZ062696@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-26 07:53:44 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Delete all the dead code. Revision Changes Path 1.8 +3 -143; commitid: f4cd435f36087ea6; xorp/ospf/tools/print_lsas.cc From pavlin@icir.org Wed Oct 26 09:55:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 08:55:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes Message-ID: <200510260855.j9Q8tBm0063434@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 08:55:11 UTC XORP CVS repository Modified files: devnotes routing-refs.txt Log message: Add two more books by Jeff Doyle. Submitted by: Patrick Marc Preuss Revision Changes Path 1.2 +8 -0; commitid: f79d435f44377ea6; xorp/devnotes/routing-refs.txt From pavlin@icir.org Wed Oct 26 20:11:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 19:11:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp xorp/fea Message-ID: <200510261911.j9QJBBeq081607@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 19:11:11 UTC XORP CVS repository Modified files: libxorp utility.h fea fticonfig_entry_set_rtsock.cc Log message: Apply pointers-casting fixes for Sparc64. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=267 Revision Changes Path 1.32 +3 -3; commitid: 13e95435fd4a27ea6; xorp/fea/fticonfig_entry_set_rtsock.cc 1.11 +2 -2; commitid: 13e95435fd4a27ea6; xorp/libxorp/utility.h From pavlin@icir.org Wed Oct 26 21:13:37 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 20:13:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510262013.j9QKDboQ082184@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 20:13:37 UTC XORP CVS repository Modified files: fea ifconfig_media.cc mfea_mrouter.cc mfea_proto_comm.cc rawsock.cc Log message: Replace C-style pointer casting "(struct foo *)" with the C++ style: "reinterpret_cast(bar)" Revision Changes Path 1.3 +1 -1; commitid: 140df435fe3397ea6; xorp/fea/ifconfig_media.cc 1.38 +5 -5; commitid: 140df435fe3397ea6; xorp/fea/mfea_mrouter.cc 1.37 +14 -14; commitid: 140df435fe3397ea6; xorp/fea/mfea_proto_comm.cc 1.8 +16 -15; commitid: 140df435fe3397ea6; xorp/fea/rawsock.cc From pavlin@icir.org Wed Oct 26 21:17:21 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 20:17:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510262017.j9QKHL54082300@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 20:17:21 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc Log message: Don't show the default values for new configuration nodes that are not committed yet. This feature was explicitly added earlier, and is probably useful, but is confusing because is not consistent with the behavior when displaying already committed configuration. This fixes bugzilla entry #159 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=159 Approved by: Atanu Ghosh Revision Changes Path 1.96 +3 -4; commitid: 14128435fe3997ea6; xorp/rtrmgr/conf_tree_node.cc From pavlin@icir.org Wed Oct 26 23:33:26 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 22:33:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510262233.j9QMXQlJ083500@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 22:33:26 UTC XORP CVS repository Modified files: rtrmgr cli.cc Log message: * Explicitly check that there is no more than one value per leaf node. * Bug fix in cleaning-up when there is an error. This fixes bugzilla entry #160 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=160 Revision Changes Path 1.103 +17 -13; commitid: 14609436003b27ea6; xorp/rtrmgr/cli.cc From pavlin@icir.org Wed Oct 26 23:59:39 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Wed, 26 Oct 2005 22:59:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510262259.j9QMxdsW083717@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-26 22:59:39 UTC XORP CVS repository Modified files: etc/templates rib.cmds Log message: Add missing nodes with the appropriate help messages for the "show route" commands. This fixes issue 3 in Bugzilla entry #161 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=161 Revision Changes Path 1.5 +44 -2; commitid: 146ea436009d07ea6; xorp/etc/templates/rib.cmds From pavlin@icir.org Thu Oct 27 02:55:51 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 01:55:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/rib/tools Message-ID: <200510270155.j9R1tp4Y085193@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 01:55:51 UTC XORP CVS repository Modified files: etc/templates rib.cmds rib/tools show_routes.cc Log message: * Add "-b" flag to the "show_routes" command to print the routes using a brief format. * Add "... final brief" operational commands to print the final table in brief format. The above modifications are based on a patch by Patrick Marc Preuss from bugzilla entry #161 (attachment id=19). Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=161 Revision Changes Path 1.6 +25 -1; commitid: 14c55436032287ea6; xorp/etc/templates/rib.cmds 1.13 +53 -4; commitid: 14c55436032287ea6; xorp/rib/tools/show_routes.cc From pavlin@icir.org Thu Oct 27 04:31:03 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 03:31:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510270331.j9R3V3ha086112@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 03:31:03 UTC XORP CVS repository Modified files: . config.h.in configure configure.in Log message: * Check for the existence of header file * Define HOST_OS_NAME as a string with the name of the OS. E.g.: #define HOST_OS_NAME "FreeBSD" Requested by: Atanu Ghosh Revision Changes Path 1.49 +6 -0; commitid: 1502f436049947ea6; xorp/config.h.in 1.164 +43 -2; commitid: 1502f436049947ea6; xorp/configure 1.147 +11 -3; commitid: 1502f436049947ea6; xorp/configure.in From pavlin@icir.org Thu Oct 27 06:05:42 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 05:05:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib xorp/rib/tools xorp/rip xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510270505.j9R55gNU087212@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 05:05:42 UTC XORP CVS repository Modified files: rib redist_xrl.cc rib/tools show_routes.cc rip xrl_target_common.hh xrl_target_rip.cc xrl_target_rip.hh xrl_target_ripng.cc xrl_target_ripng.hh xrl/interfaces redist4.xif redist4_xif.cc redist4_xif.hh redist6.xif redist6_xif.cc redist6_xif.hh xrl/targets rip.xrls rip_base.cc rip_base.hh ripng.xrls ripng_base.cc ripng_base.hh show_routes.xrls show_routes_base.cc show_routes_base.hh Log message: * Add protocol_origin field to the following XRLs: redist4/0.1/add_route redist4/0.1/delete_route redist6/0.1/add_route redist6/0.1/delete_route This field contains the name of the protocol that originated the routing entry. Note that the corresponding similar XRLs to the redist_transaction{4,6} XRL interface already have this field. * Show the protocol origin by the RIB's "show_routes" operational command by using the above protocol_origin XRL field, and remove the hack for using the admin distance to get the protocol origin. [Bug found by: "Patrick Preuss" ] * Reformat the "show route" output to accomodate the additional information per route. OLD: Xorp> show route table ipv4 unicast final Network 10.10.0.0/16 Nexthop := 192.150.187.1 Metric := 1 Protocol := static Interface := rl0 Vif := rl0 Network 192.150.187.0/25 Nexthop := 192.150.187.67 Metric := 0 Protocol := connected Interface := rl0 Vif := rl0 NEW: Xorp> show route table ipv4 unicast final Network 10.10.0.0/16 Nexthop := 192.150.187.1 Interface := rl0 Vif := rl0 Metric := 1 Protocol := static Admin distance := 1 Network 192.150.187.0/25 Nexthop := 192.150.187.67 Interface := rl0 Vif := rl0 Metric := 0 Protocol := connected Admin distance := 0 Bug found by: "Patrick Preuss" Revision Changes Path 1.21 +5 -1; commitid: 153a243605d2a7ea6; xorp/rib/redist_xrl.cc 1.14 +46 -70; commitid: 153a243605d2a7ea6; xorp/rib/tools/show_routes.cc 1.21 +9 -5; commitid: 153a243605d2a7ea6; xorp/rip/xrl_target_common.hh 1.23 +6 -4; commitid: 153a243605d2a7ea6; xorp/rip/xrl_target_rip.cc 1.17 +5 -3; commitid: 153a243605d2a7ea6; xorp/rip/xrl_target_rip.hh 1.23 +6 -4; commitid: 153a243605d2a7ea6; xorp/rip/xrl_target_ripng.cc 1.18 +5 -3; commitid: 153a243605d2a7ea6; xorp/rip/xrl_target_ripng.hh 1.8 +9 -3; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist4.xif 1.11 +5 -1; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist4_xif.cc 1.9 +7 -1; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist4_xif.hh 1.8 +9 -3; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist6.xif 1.11 +5 -1; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist6_xif.cc 1.9 +7 -1; commitid: 153a243605d2a7ea6; xorp/xrl/interfaces/redist6_xif.hh 1.20 +7 -3; commitid: 153a243605d2a7ea6; xorp/xrl/targets/rip.xrls 1.20 +9 -7; commitid: 153a243605d2a7ea6; xorp/xrl/targets/rip_base.cc 1.21 +9 -3; commitid: 153a243605d2a7ea6; xorp/xrl/targets/rip_base.hh 1.22 +7 -3; commitid: 153a243605d2a7ea6; xorp/xrl/targets/ripng.xrls 1.22 +9 -7; commitid: 153a243605d2a7ea6; xorp/xrl/targets/ripng_base.cc 1.23 +9 -3; commitid: 153a243605d2a7ea6; xorp/xrl/targets/ripng_base.hh 1.7 +13 -5; commitid: 153a243605d2a7ea6; xorp/xrl/targets/show_routes.xrls 1.7 +17 -13; commitid: 153a243605d2a7ea6; xorp/xrl/targets/show_routes_base.cc 1.7 +17 -5; commitid: 153a243605d2a7ea6; xorp/xrl/targets/show_routes_base.hh From pavlin@icir.org Thu Oct 27 06:09:17 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 05:09:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510270509.j9R59Hp0087323@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 05:09:17 UTC XORP CVS repository Modified files: . config.h.in configure configure.in Log message: Add a check for uname(3) library function. Requested by: Atanu Ghosh Revision Changes Path 1.50 +3 -0; commitid: 154fe436060e67ea6; xorp/config.h.in 1.165 +77 -1; commitid: 154fe436060e67ea6; xorp/configure 1.148 +3 -2; commitid: 154fe436060e67ea6; xorp/configure.in From pavlin@icir.org Thu Oct 27 08:13:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 07:13:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510270713.j9R7DlWq088760@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 07:13:47 UTC XORP CVS repository Modified files: etc/templates rib.cmds Log message: Add "brief" version for all "show route table" commands. Revision Changes Path 1.7 +149 -17; commitid: 15a9a43607e1a7ea6; xorp/etc/templates/rib.cmds From atanu@icir.org Thu Oct 27 19:22:07 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 18:22:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510271822.j9RIM7Wj098243@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 18:22:07 UTC XORP CVS repository Added files: libxorp tlv.hh Log message: Helper class to read and write TLV records. Revision Changes Path 1.1 +118 -0 xorp/libxorp/tlv.hh (new) From atanu@icir.org Thu Oct 27 19:34:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 18:34:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510271834.j9RIYoxD098416@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 18:34:50 UTC XORP CVS repository Modified files: libxorp tlv.hh Log message: Update the documentation strings. Revision Changes Path 1.2 +49 -1; commitid: 1805543611dc97ea6; xorp/libxorp/tlv.hh From atanu@icir.org Thu Oct 27 19:37:53 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 18:37:53 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510271837.j9RIbr9X098532@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 18:37:52 UTC XORP CVS repository Modified files: libxorp Makefile.am Makefile.in Log message: Add tlv.hh. Revision Changes Path 1.39 +2 -1; commitid: 180c743611e7f7ea6; xorp/libxorp/Makefile.am 1.52 +1 -1; commitid: 180c743611e7f7ea6; xorp/libxorp/Makefile.in From atanu@icir.org Thu Oct 27 19:41:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 18:41:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510271841.j9RIfKDg098625@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 18:41:20 UTC XORP CVS repository Modified files: ospf test_common.hh Log message: TLV defines to use to save LSAs to a file. Revision Changes Path 1.2 +11 -2; commitid: 1812843611f507ea6; xorp/ospf/test_common.hh From atanu@icir.org Thu Oct 27 19:42:31 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 18:42:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510271842.j9RIgVxT098672@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 18:42:31 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Initial support for saving the LSA database to a file. Revision Changes Path 1.9 +62 -4; commitid: 1815743611f967ea6; xorp/ospf/tools/print_lsas.cc From pavlin@icir.org Thu Oct 27 20:49:17 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 19:49:17 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510271949.j9RJnHV8099402@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 19:49:16 UTC XORP CVS repository Modified files: fea fticonfig_table_parse_rtm.cc routing_socket_utils.cc Log message: Move the marking of a route as unresolved to RtmUtils::rtm_get_to_fte_cfg() where the rtm message is processed. Previously the marking was done in FtiConfigTableGet::parse_buffer_rtm(), but was missing from FtiConfigEntryGet::parse_buffer_rtm(). Revision Changes Path 1.15 +4 -12; commitid: 1842243612edf7ea6; xorp/fea/fticonfig_table_parse_rtm.cc 1.29 +21 -3; commitid: 1842243612edf7ea6; xorp/fea/routing_socket_utils.cc From pavlin@icir.org Thu Oct 27 20:54:54 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Thu, 27 Oct 2005 19:54:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510271954.j9RJssiF099491@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-27 19:54:54 UTC XORP CVS repository Modified files: fea routing_socket_utils.cc Log message: Refactor some #ifdef code because gcc-2.95.x doesn't like it. Revision Changes Path 1.30 +13 -8; commitid: 1848a4361306b7ea6; xorp/fea/routing_socket_utils.cc From atanu@icir.org Thu Oct 27 21:25:20 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 20:25:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510272025.j9RKPK8G099810@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 20:25:20 UTC XORP CVS repository Modified files: ospf area_router.cc Log message: A Router-LSA for the router itself always exists unconditionally in the area database. An LSA in the database can be marked as unavailable, an example would be no router links. If an area is configured and all the interfaces are disabled then the Router-LSa is not available. The get_lsa() interface used by the show database operational command was not checking for availability and returning all LSAs unconditionally. The LSA code itself checks for availability before returning an LSA and the assert in this code was being triggered. Revision Changes Path 1.131 +6 -1; commitid: 185c7436137af7ea6; xorp/ospf/area_router.cc From atanu@icir.org Thu Oct 27 21:31:52 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 20:31:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510272031.j9RKVqsP099965@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 20:31:52 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: Put the operating system name in the database file. Revision Changes Path 1.10 +23 -7; commitid: 18662436139387ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Thu Oct 27 21:39:50 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 20:39:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510272039.j9RKdoIb000219@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 20:39:50 UTC XORP CVS repository Modified files: libxorp tlv.hh Log message: fclose() returns 0 on success, the code was expecting anything but 0 on success. Bug found by: Pavlin Radoslavov Revision Changes Path 1.3 +2 -2; commitid: c043613b157ea6; xorp/libxorp/tlv.hh From bms@icir.org Thu Oct 27 22:00:42 2005 From: bms@icir.org (Bruce Simpson) Date: Thu, 27 Oct 2005 21:00:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto Message-ID: <200510272100.j9RL0gTh000547@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms@xorpc.icir.org 2005-10-27 21:00:42 UTC XORP CVS repository Modified files: libproto test_config_node_id.cc Log message: Fix compilation under Win32: conditional #include Revision Changes Path 1.4 +5 -1; commitid: 20a43613fe67ea6; xorp/libproto/test_config_node_id.cc From atanu@icir.org Thu Oct 27 23:31:05 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 22:31:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf/tools Message-ID: <200510272231.j9RMV5Wn001312@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 22:31:05 UTC XORP CVS repository Modified files: ospf/tools print_lsas.cc Log message: LSAs can now be saved in a file. Revision Changes Path 1.11 +18 -4; commitid: 505436155297ea6; xorp/ospf/tools/print_lsas.cc From atanu@icir.org Fri Oct 28 00:07:38 2005 From: atanu@icir.org (Atanu Ghosh) Date: Thu, 27 Oct 2005 23:07:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf xorp/ospf/tools Message-ID: <200510272307.j9RN7cNQ001683@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-27 23:07:38 UTC XORP CVS repository Modified files: ospf test_common.hh ospf/tools print_lsas.cc Log message: Put the version of OSPF into the saved database file. Revision Changes Path 1.3 +4 -3; commitid: 66343615db97ea6; xorp/ospf/test_common.hh 1.12 +13 -3; commitid: 66343615db97ea6; xorp/ospf/tools/print_lsas.cc From pavlin@icir.org Fri Oct 28 02:11:11 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 01:11:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rip/tools Message-ID: <200510280111.j9S1BBdL002916@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 01:11:11 UTC XORP CVS repository Modified files: rip/tools xrl_rip_shell_funcs.sh xrl_ripng_shell_funcs.sh Log message: Regenerate after changes to some of the XRLs. Revision Changes Path 1.9 +6 -6; commitid: b4143617a867ea6; xorp/rip/tools/xrl_rip_shell_funcs.sh 1.9 +6 -6; commitid: b4143617a867ea6; xorp/rip/tools/xrl_ripng_shell_funcs.sh From pavlin@icir.org Fri Oct 28 02:23:28 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 01:23:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200510280123.j9S1NSnp003066@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 01:23:28 UTC XORP CVS repository Modified files: libxorp ipnet.hh Log message: Fix some of the methods to consider the case when the address family is different. The result of this is that the "<" operator behavior is more consistent. Revision Changes Path 1.19 +13 -1; commitid: bdc43617d267ea6; xorp/libxorp/ipnet.hh From pavlin@icir.org Fri Oct 28 03:08:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 02:08:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510280208.j9S28NCY005482@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 02:08:23 UTC XORP CVS repository Modified files: rtrmgr conf_tree_node.cc conf_tree_node.hh master_conf_tree_node.cc slave_conf_tree_node.cc Log message: * Reorder the assignment of some of the fields related to the status of a node (the deleted flag, etc), so things are a bit more consistent. * Add missing _modification_time initialization in the ConfigTreeNode constructors. * Add missing assignment of the _deleted and the _committed_operator fields in MasterConfigTreeNode::finalize_commit() and SlaveConfigTreeNode::finalize_commit(). [Note that the _deleted assignment is redundant but is there for consistency]. * Add missing assignments of the _committed_foo fields in the ConfigTreeNode::mark_subtree_as_committed() method. This fixes bugzilla entry #174 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=174 Revision Changes Path 1.97 +13 -6; commitid: 150e436186b77ea6; xorp/rtrmgr/conf_tree_node.cc 1.56 +2 -3; commitid: 150e436186b77ea6; xorp/rtrmgr/conf_tree_node.hh 1.17 +3 -1; commitid: 150e436186b77ea6; xorp/rtrmgr/master_conf_tree_node.cc 1.28 +3 -1; commitid: 150e436186b77ea6; xorp/rtrmgr/slave_conf_tree_node.cc From atanu@icir.org Fri Oct 28 08:31:40 2005 From: atanu@icir.org (Atanu Ghosh) Date: Fri, 28 Oct 2005 07:31:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510280731.j9S7Verl008905@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-28 07:31:40 UTC XORP CVS repository Modified files: ospf test_routing.cc Log message: Read a saved LSA database and feed it into the routing computation. Revision Changes Path 1.7 +154 -3; commitid: 22ae4361d3dc7ea6; xorp/ospf/test_routing.cc From pavlin@icir.org Fri Oct 28 09:40:03 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 08:40:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510280840.j9S8e3p8009807@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 08:40:03 UTC XORP CVS repository Modified files: fea xrl_fti.cc Log message: Fix a bug in the mechanism for sending FIB updates from the top of the queue to the FIB client(s). Previously, an unresolved entry (that popped-up from the kernel) would stall the queue if the FIB client wasn't interested in unresolved entries. This fixes the large memory usage increase that has been noticed with the FEA recently (when the fib2mrib was also running). Revision Changes Path 1.19 +41 -23; commitid: 260b4361e2ff7ea6; xorp/fea/xrl_fti.cc From mjh@icir.org Fri Oct 28 10:13:34 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 28 Oct 2005 09:13:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510280913.j9S9DYjM010405@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-10-28 09:13:34 UTC XORP CVS repository Modified files: bgp route_table_filter.cc route_table_filter.hh Log message: Add the capability to the static filter to maintain old versions of filters (in a similar manner to that used for policy filters). This is to allow a peering to be reconfigured. The assumption is that you take the peering down, call reconfigure, add back the filters, and bring the peering back up. Revision Changes Path 1.34 +221 -67; commitid: 28504361eb477ea6; xorp/bgp/route_table_filter.cc 1.16 +43 -2; commitid: 28504361eb477ea6; xorp/bgp/route_table_filter.hh From pavlin@icir.org Fri Oct 28 18:05:16 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 17:05:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config Message-ID: <200510281705.j9SH5Gev017424@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 17:05:16 UTC XORP CVS repository Modified files: config acipv4.m4 Log message: Fix a comment. Revision Changes Path 1.4 +2 -2; commitid: 43f743625a477ea6; xorp/config/acipv4.m4 From pavlin@icir.org Fri Oct 28 18:06:57 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 17:06:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config xorp xorp/mibs Message-ID: <200510281706.j9SH6vnb017527@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 17:06:57 UTC XORP CVS repository Modified files: config acipv6.m4 . configure mibs configure Log message: Fix the test for IPv6 multicast routing to conditionally include some of the header files. Revision Changes Path 1.21 +12 -4; commitid: 442743625a777ea6; xorp/config/acipv6.m4 1.166 +219 -3; commitid: 442743625a777ea6; xorp/configure 1.25 +218 -2; commitid: 442743625a777ea6; xorp/mibs/configure From pavlin@icir.org Fri Oct 28 18:35:46 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 17:35:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/mibs xorp/config Message-ID: <200510281735.j9SHZkqT017833@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 17:35:46 UTC XORP CVS repository Modified files: . configure mibs configure config acipv6.m4 Log message: Conditionally include in the test for HAVE_IPV6_MULTICAST_ROUTING Revision Changes Path 1.22 +5 -1; commitid: 45664362614d7ea6; xorp/config/acipv6.m4 1.167 +109 -0; commitid: 45664362614d7ea6; xorp/configure 1.26 +109 -0; commitid: 45664362614d7ea6; xorp/mibs/configure From pavlin@icir.org Fri Oct 28 19:55:35 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Fri, 28 Oct 2005 18:55:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510281855.j9SItZ70018493@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-28 18:55:35 UTC XORP CVS repository Modified files: rtrmgr config.boot.sample Log message: Fix a typo in the path to the Click config generator: "/user" -> "/usr" Bug found by: Zhaoyu Chi Revision Changes Path 1.33 +3 -3; commitid: 4810436273f37ea6; xorp/rtrmgr/config.boot.sample From mjh@icir.org Fri Oct 28 23:09:29 2005 From: mjh@icir.org (Mark Handley) Date: Fri, 28 Oct 2005 22:09:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200510282209.j9SM9Tu1019949@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: mjh@xorpc.icir.org 2005-10-28 22:09:29 UTC XORP CVS repository Modified files: bgp plumbing.cc plumbing.hh Log message: Reload the static filter banks every time a peering comes up. This will allow us to change settings on a peering. Revision Changes Path 1.73 +148 -62; commitid: 4dd24362a1747ea6; xorp/bgp/plumbing.cc 1.32 +7 -1; commitid: 4dd24362a1747ea6; xorp/bgp/plumbing.hh From pavlin@icir.org Sat Oct 29 03:05:06 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 02:05:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200510290205.j9T256jk021759@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 02:05:06 UTC XORP CVS repository Modified files: rtrmgr master_template_tree_node.cc Log message: Add an explicit check that the multi-value nodes are excluded as %mandatory (as already is described in the rtrmgr documentation). Bug found by: Michael Larson Revision Changes Path 1.10 +27 -3; commitid: 54b34362d5567ea6; xorp/rtrmgr/master_template_tree_node.cc From pavlin@icir.org Sat Oct 29 06:26:38 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 05:26:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib/tools Message-ID: <200510290526.j9T5QcfA023133@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 05:26:38 UTC XORP CVS repository Modified files: rib/tools show_routes.cc Log message: * Add support for terse output of the routes (shown by the -t command line option). * Add "-d" as a command line option to print the routes with detailed format. * Minot refactoring. Changes based on a patch by Patrick Marc Preuss Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=162 Submitted by: Patrick Marc Preuss Revision Changes Path 1.15 +148 -38; commitid: 5a0c436306337ea6; xorp/rib/tools/show_routes.cc From pavlin@icir.org Sat Oct 29 06:51:10 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 05:51:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510290551.j9T5pAsp023325@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 05:51:10 UTC XORP CVS repository Modified files: etc/templates rib.cmds Log message: Add entries for "detail" and "terse" versions of each command. Changes based on a patch by Patrick Marc Preuss Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=162 Submitted by: Patrick Marc Preuss Revision Changes Path 1.8 +313 -1; commitid: 5ae143630d477ea6; xorp/etc/templates/rib.cmds From pavlin@icir.org Sat Oct 29 09:06:47 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 08:06:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200510290806.j9T86lIl024340@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 08:06:47 UTC XORP CVS repository Modified files: cli cli_command.cc Log message: Fix a bug with the formatting of the listed command completions after hitting if is one of the possible completions. This fixes a bug that was noted in one of the messages inside Bugzilla entry #161. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=161 Revision Changes Path 1.20 +6 -2; commitid: 5ee243632d057ea6; xorp/cli/cli_command.cc From pavlin@icir.org Sat Oct 29 18:42:20 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 17:42:20 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli Message-ID: <200510291742.j9THgKpe030336@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 17:42:20 UTC XORP CVS repository Modified files: cli cli_client.cc cli_command_pipe.cc cli_command_pipe.hh Log message: Add a mechanism to start/stop each pipe command, to verify that each pipe command has the necessary arguments, and to stop the processing if the initialization of any of the pipe command fails. This fixes bugzilla entry #232 Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=232 Revision Changes Path 1.43 +19 -2; commitid: 76414363b3907ea6; xorp/cli/cli_client.cc 1.10 +373 -37; commitid: 76414363b3907ea6; xorp/cli/cli_command_pipe.cc 1.10 +42 -21; commitid: 76414363b3907ea6; xorp/cli/cli_command_pipe.hh From pavlin@icir.org Sat Oct 29 19:09:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 18:09:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib/tools Message-ID: <200510291809.j9TI9a6A030676@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 18:09:36 UTC XORP CVS repository Modified files: rib/tools show_routes.cc Log message: Changed the default routes output format from "detail" to "brief" (for consistency with Juniper), and by user request (see comment #9 in bugzilla entry #162). The original detailed output is available by using the "detail" option after the particular CLI command. E.g., now "show route table ipv4 unicast final" will show the routes using the brief format, while "show route table ipv4 unicast final detail" will show the routes by using the detailed format. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=162 Revision Changes Path 1.16 +2 -2; commitid: 77ac4363b9fa7ea6; xorp/rib/tools/show_routes.cc From pavlin@icir.org Sat Oct 29 21:33:36 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 20:33:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510292033.j9TKXaEF031816@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 20:33:36 UTC XORP CVS repository Modified files: rib rib.cc rib.hh xrl_target.cc xrl_target.hh xrl/interfaces rib.xif rib_xif.cc rib_xif.hh xrl/targets rib.xrls rib_base.cc rib_base.hh Log message: Add a new XRL rib/0.1/get_registered_protocols to get the list of protocols registered with the RIB. Revision Changes Path 1.56 +15 -1; commitid: 7bf74363dc867ea6; xorp/rib/rib.cc 1.33 +8 -1; commitid: 7bf74363dc867ea6; xorp/rib/rib.hh 1.53 +45 -1; commitid: 7bf74363dc867ea6; xorp/rib/xrl_target.cc 1.31 +38 -1; commitid: 7bf74363dc867ea6; xorp/rib/xrl_target.hh 1.20 +26 -1; commitid: 7bf74363dc867ea6; xorp/xrl/interfaces/rib.xif 1.30 +53 -1; commitid: 7bf74363dc867ea6; xorp/xrl/interfaces/rib_xif.cc 1.29 +34 -1; commitid: 7bf74363dc867ea6; xorp/xrl/interfaces/rib_xif.hh 1.32 +28 -1; commitid: 7bf74363dc867ea6; xorp/xrl/targets/rib.xrls 1.35 +57 -1; commitid: 7bf74363dc867ea6; xorp/xrl/targets/rib_base.cc 1.38 +42 -1; commitid: 7bf74363dc867ea6; xorp/xrl/targets/rib_base.hh From pavlin@icir.org Sat Oct 29 21:42:04 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 20:42:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510292042.j9TKg4YB031935@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 20:42:04 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Add a release note about RIB. Revision Changes Path 1.87 +3 -2; commitid: 7ca64363de967ea6; xorp/RELEASE_NOTES From deathdealer@gmx.net Sat Oct 29 22:33:41 2005 From: deathdealer@gmx.net (Patrick Preuss) Date: Sat, 29 Oct 2005 23:33:41 +0200 Subject: AW: [Xorp-cvs] XORP cvs commit: xorp/cli In-Reply-To: <200510290806.j9T86lIl024340@xorpc.icir.org> Message-ID: <001d01c5dcd0$6eede580$1608000a@dedus737> Hello Pavlin, I have seen you have submitted the patch witch I have posted a while ago. I think this fixes bug 228 (http://www.xorp.org/bugzilla/show_bug.cgi?id=228). Gruss    Patrick Marc Preuss -----Ursprüngliche Nachricht----- Von: xorp-cvs-admin@icir.org [mailto:xorp-cvs-admin@icir.org] Im Auftrag von Pavlin Radoslavov Gesendet: Samstag, 29. Oktober 2005 10:07 An: xorp-cvs@icir.org Betreff: [Xorp-cvs] XORP cvs commit: xorp/cli CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-29 08:06:47 UTC XORP CVS repository Modified files: cli cli_command.cc Log message: Fix a bug with the formatting of the listed command completions after hitting if is one of the possible completions. This fixes a bug that was noted in one of the messages inside Bugzilla entry #161. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=161 Revision Changes Path 1.20 +6 -2; commitid: 5ee243632d057ea6; xorp/cli/cli_command.cc _______________________________________________ Xorp-cvs mailing list Xorp-cvs@icir.org http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin@icir.org Sun Oct 30 02:02:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sat, 29 Oct 2005 19:02:01 -0700 Subject: AW: [Xorp-cvs] XORP cvs commit: xorp/cli In-Reply-To: Message from "Patrick Preuss" of "Sat, 29 Oct 2005 23:33:41 +0200." <001d01c5dcd0$6eede580$1608000a@dedus737> Message-ID: <200510300202.j9U221Et034997@possum.icir.org> > I have seen you have submitted the patch witch I have posted a while ago. > > I think this fixes bug 228 > (http://www.xorp.org/bugzilla/show_bug.cgi?id=228). Thanks for the info. I just marked bug 228 as FIXED. Pavlin > -----Ursprüngliche Nachricht----- > Von: xorp-cvs-admin@icir.org [mailto:xorp-cvs-admin@icir.org] Im Auftrag von > Pavlin Radoslavov > Gesendet: Samstag, 29. Oktober 2005 10:07 > An: xorp-cvs@icir.org > Betreff: [Xorp-cvs] XORP cvs commit: xorp/cli > > CVSROOT: /usr/local/share/doc/apache/cvs > Module name: xorp > Changes by: pavlin@xorpc.icir.org 2005-10-29 08:06:47 UTC > > XORP CVS repository > > > Modified files: > cli cli_command.cc > > Log message: > Fix a bug with the formatting of the listed command completions > after hitting if is one of the possible completions. > > This fixes a bug that was noted in one of the messages inside > Bugzilla entry #161. > > Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=161 > > Revision Changes Path > 1.20 +6 -2; commitid: 5ee243632d057ea6; xorp/cli/cli_command.cc From pavlin@icir.org Sun Oct 30 05:15:01 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 05:15:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config xorp xorp/mibs Message-ID: <200510300515.j9U5F1w9034903@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 05:15:01 UTC XORP CVS repository Modified files: config acipv6.m4 . configure mibs configure Log message: Fix the check whether the system supports IPv6 multicast routing so now the check works with the Linux IPv6 multicast forwarding patch: http://clarinet.u-strasbg.fr/~hoerdt/linux_ipv6_mforwarding/ [Tested on Linux Fedora Core 4] Revision Changes Path 1.23 +5 -2; commitid: 8808436455bc7ea6; xorp/config/acipv6.m4 1.168 +4 -1; commitid: 8808436455bc7ea6; xorp/configure 1.27 +4 -1; commitid: 8808436455bc7ea6; xorp/mibs/configure From atanu@icir.org Sun Oct 30 07:33:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 30 Oct 2005 07:33:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510300733.j9U7Xs0e035783@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-30 07:33:54 UTC XORP CVS repository Modified files: ospf trace.hh Log message: Add a method all() that allows all the trace variables to set to the same value, useful for the regression tests to be able to enable/disable all tracing. Revision Changes Path 1.6 +9 -1; commitid: 8bac436477617ea6; xorp/ospf/trace.hh From atanu@icir.org Sun Oct 30 07:37:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 30 Oct 2005 07:37:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510300737.j9U7bDO8035865@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-30 07:37:13 UTC XORP CVS repository Modified files: ospf area_router.hh Log message: New method to verify that the Router-LSA that is referenced in the Network-LSA has a transit router link pointing back to the Network-LSA. Revision Changes Path 1.77 +11 -1; commitid: 8bfe436478287ea6; xorp/ospf/area_router.hh From atanu@icir.org Sun Oct 30 09:25:47 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 30 Oct 2005 09:25:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510300925.j9U9Plxj036700@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-30 09:25:47 UTC XORP CVS repository Modified files: ospf area_router.cc test_routing.cc Log message: When the router was the designated router and a neighbouring router on a broadcast interface was a border router or an AS boundary router a host route to the router itself was being installed. R1 <--> N1 <--> R2 Router R1 generates a Network-LSA (N1) that is the next vertex towards R2. the Vertex N1 has as its nexthop R1. A route to R2 was therefore returning R1 as the nexthop. When the router is a designated router on an interface put in direct edges to each neighbour. Allow host routes for router vertexs. When processing AS-External-LSAs use the advertising router field to perform the lookup in the routing table not the network. The forwarding entry in the LSA is now being honoured. Add a regression test routing4() that verifies that the correct routes are introduced. Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=295 Bug found by: Patrick Marc Preuss Revision Changes Path 1.132 +134 -20; commitid: 8f3f436491997ea6; xorp/ospf/area_router.cc 1.8 +127 -2; commitid: 8f3f436491997ea6; xorp/ospf/test_routing.cc From pavlin@icir.org Sun Oct 30 21:15:23 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:15:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510302115.j9ULFNKn043442@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:15:23 UTC XORP CVS repository Modified files: . acconfig.h Log message: Remove KAME-related mld_hdr/mld6_hdr related definition, because it is not needed anymore (the rest of XORP doesn't really need mld_hdr). Revision Changes Path 1.15 +1 -8; commitid: a983436537a97ea6; xorp/acconfig.h From pavlin@icir.org Sun Oct 30 21:18:43 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:18:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config Message-ID: <200510302118.j9ULIhbx043574@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:18:43 UTC XORP CVS repository Modified files: config ahxorp.m4 Log message: Remove KAME-related mld_hdr/mld6_hdr related definition, because it is not needed anymore (the rest of XORP doesn't really need mld_hdr). Revision Changes Path 1.2 +2 -9; commitid: aa1d436538af7ea6; xorp/config/ahxorp.m4 From pavlin@icir.org Sun Oct 30 21:21:40 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:21:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200510302121.j9ULLeCx043679@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:21:40 UTC XORP CVS repository Modified files: . config.h.in configure configure.in Log message: * Add check whether file exists * Regenerate files "config.h.in" and "configure". Revision Changes Path 1.51 +4 -8; commitid: aa824365393b7ea6; xorp/config.h.in 1.169 +2 -1; commitid: aa824365393b7ea6; xorp/configure 1.149 +3 -3; commitid: aa824365393b7ea6; xorp/configure.in From pavlin@icir.org Sun Oct 30 21:23:39 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:23:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/mrt/include Message-ID: <200510302123.j9ULNdvM043736@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:23:39 UTC XORP CVS repository Modified files: mrt/include ip_mroute.h Log message: * Conditionally include header file * Minor stylistic changes Revision Changes Path 1.12 +38 -33; commitid: aabf436539c27ea6; xorp/mrt/include/ip_mroute.h From pavlin@icir.org Sun Oct 30 21:27:59 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:27:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/mld6igmp Message-ID: <200510302127.j9ULRxDp043883@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:27:59 UTC XORP CVS repository Modified files: fea mfea_osdep.hh mld6igmp mld6_proto.h Log message: Cleanup the MLD-related definitions, and define some of the constant values locally in case they are missing. We need to add local definitions, because the Linux system header files are in big mess. Revision Changes Path 1.8 +43 -11; commitid: ab2643653a397ea6; xorp/fea/mfea_osdep.hh 1.9 +41 -11; commitid: ab2643653a397ea6; xorp/mld6igmp/mld6_proto.h From pavlin@icir.org Sun Oct 30 21:29:48 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:29:48 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510302129.j9ULTmEs043995@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:29:48 UTC XORP CVS repository Modified files: fea mfea_mrouter.cc mfea_proto_comm.cc rawsock.cc Log message: Use MLD_MINLEN instead of sizeof(struct mld_hdr) when checking whether the received MLD packet is of minimum length. Revision Changes Path 1.39 +3 -4; commitid: ab9243653b067ea6; xorp/fea/mfea_mrouter.cc 1.38 +3 -4; commitid: ab9243653b067ea6; xorp/fea/mfea_proto_comm.cc 1.9 +11 -4; commitid: ab9243653b067ea6; xorp/fea/rawsock.cc From atanu@icir.org Sun Oct 30 21:36:13 2005 From: atanu@icir.org (Atanu Ghosh) Date: Sun, 30 Oct 2005 21:36:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510302136.j9ULaDIu044142@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-30 21:36:13 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: An InternalRouteEntry can store a route for each area typically it only needs to return the winning route. When processing an AS-External-LSA the route from the area under consideration is required. The InternalRouteEntry can now return the route for a specific area if it exisits. Revision Changes Path 1.21 +15 -1; commitid: ac4c43653ccb7ea6; xorp/ospf/routing_table.cc 1.22 +11 -1; commitid: ac4c43653ccb7ea6; xorp/ospf/routing_table.hh From pavlin@icir.org Sun Oct 30 21:58:05 2005 From: pavlin@icir.org (Pavlin Radoslavov) Date: Sun, 30 Oct 2005 21:58:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200510302158.j9ULw54b044435@xorpc.icir.org> CVSROOT: /usr/local/share/doc/apache/cvs Module name: xorp Changes by: pavlin@xorpc.icir.org 2005-10-30 21:58:04 UTC XORP CVS repository Modified files: fea mfea_mrouter.cc mfea_proto_comm.cc rawsock.cc Log message: Add missing size_t casting to MLD_MINSIZE when comparing it against a size_t argument. Revision Changes Path 1.40 +3 -2; commitid: ad6a436541c37ea6; xorp/fea/mfea_mrouter.cc 1.39 +3 -2; commitid: ad6a436541c37ea6; xorp/fea/mfea_proto_comm.cc 1.10 +3 -2; commitid: ad6a436541c37ea6; xorp/fea/rawsock.cc From atanu@icir.org Mon Oct 31 01:09:26 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 01:09:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510310109.j9V19Qq7046018@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 01:09:26 UTC XORP CVS repository Modified files: ospf area_router.cc routing_table.cc routing_table.hh Log message: An InternalRouteEntry can store a route for each area typically it only needs to return the winning route. When processing an AS-External-LSA the route from the area under consideration is required. The InternalRouteEntry can now return the route for a specific area if it exisits. The processing of AS-External-LSAs is now done using this interface. Revision Changes Path 1.133 +3 -6; commitid: b3a343656ec57ea6; xorp/ospf/area_router.cc 1.22 +24 -3; commitid: b3a343656ec57ea6; xorp/ospf/routing_table.cc 1.23 +12 -1; commitid: b3a343656ec57ea6; xorp/ospf/routing_table.hh From atanu@icir.org Mon Oct 31 01:16:54 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 01:16:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510310116.j9V1GsdF061860@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 01:16:54 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Add the mapping to the policy manager of the OSPFv2 name "ospf4" to the targetname "ospfv2". Revision Changes Path 1.15 +2 -1; commitid: f189436570867ea6; xorp/etc/templates/ospfv2.tp From atanu@icir.org Mon Oct 31 03:07:23 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 03:07:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/ospf xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200510310307.j9V37Ntw035889@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 03:07:23 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp ospf trace.hh xrl_target.cc xrl_target.hh xrl/interfaces ospfv2.xif ospfv2_xif.cc ospfv2_xif.hh xrl/targets ospfv2.xrls ospfv2_base.cc ospfv2_base.hh Log message: Add the XRLs to toggle all the trace variables. Allow the trace variables to configured in the configuration file. All the trace variables are now disabled by default as they can be enabled in the config file. Add the XRLs to fetch neighbour information. Revision Changes Path 1.16 +26 -1; commitid: 8bcb43658a677ea6; xorp/etc/templates/ospfv2.tp 1.7 +5 -8; commitid: 8bcb43658a677ea6; xorp/ospf/trace.hh 1.18 +40 -1; commitid: 8bcb43658a677ea6; xorp/ospf/xrl_target.cc 1.12 +66 -1; commitid: 8bcb43658a677ea6; xorp/ospf/xrl_target.hh 1.7 +51 -1; commitid: 8bcb43658a677ea6; xorp/xrl/interfaces/ospfv2.xif 1.8 +135 -1; commitid: 8bcb43658a677ea6; xorp/xrl/interfaces/ospfv2_xif.cc 1.8 +67 -1; commitid: 8bcb43658a677ea6; xorp/xrl/interfaces/ospfv2_xif.hh 1.10 +46 -1; commitid: 8bcb43658a677ea6; xorp/xrl/targets/ospfv2.xrls 1.10 +152 -1; commitid: 8bcb43658a677ea6; xorp/xrl/targets/ospfv2_base.cc 1.10 +78 -1; commitid: 8bcb43658a677ea6; xorp/xrl/targets/ospfv2_base.hh From atanu@icir.org Mon Oct 31 07:33:59 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 07:33:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200510310733.j9V7XxVV038003@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 07:33:59 UTC XORP CVS repository Modified files: etc/templates ospfv2.tp Log message: Comment out the installing of the ospf protocol to targetname mapping. Seems to be causing the exporting of routes to fail. Revision Changes Path 1.17 +2 -2; commitid: 94584365c8e77ea6; xorp/etc/templates/ospfv2.tp From abittau@icir.org Mon Oct 31 07:48:39 2005 From: abittau@icir.org (Andrea Bittau) Date: Mon, 31 Oct 2005 07:48:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200510310748.j9V7mdmX038243@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau@xorpc.icir.org 2005-10-31 07:48:39 UTC XORP CVS repository Modified files: policy filter_manager.cc Log message: forgot to change the human readable protocol to xrl target in the RIB map. route redistribution should now work. Revision Changes Path 1.7 +3 -2; commitid: 953c4365cc387ea6; xorp/policy/filter_manager.cc From atanu@icir.org Mon Oct 31 07:58:41 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 07:58:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510310758.j9V7wfE9038439@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 07:58:40 UTC XORP CVS repository Modified files: ospf debug_io.hh io.hh ospf.cc ospf.hh policy_varrw.hh routing_table.cc routing_table.hh test_routing.cc xrl_io.cc xrl_io.hh Log message: Pass policy tags all the way through the systems for an add/delete/replace route. Put a hack in do_filter() to stop host routes being sent to the RIB. The OSPF internal routing table needs this state for AS-External-LSAs but there is no need to send them to the RIB. Modify the the regression test routing4() to not expect the host route. Revision Changes Path 1.11 +10 -6; commitid: 95fa4365ceae7ea6; xorp/ospf/debug_io.hh 1.14 +5 -3; commitid: 95fa4365ceae7ea6; xorp/ospf/io.hh 1.47 +10 -9; commitid: 95fa4365ceae7ea6; xorp/ospf/ospf.cc 1.65 +7 -5; commitid: 95fa4365ceae7ea6; xorp/ospf/ospf.hh 1.4 +3 -1; commitid: 95fa4365ceae7ea6; xorp/ospf/policy_varrw.hh 1.23 +24 -8; commitid: 95fa4365ceae7ea6; xorp/ospf/routing_table.cc 1.24 +3 -2; commitid: 95fa4365ceae7ea6; xorp/ospf/routing_table.hh 1.9 +5 -2; commitid: 95fa4365ceae7ea6; xorp/ospf/test_routing.cc 1.20 +11 -13; commitid: 95fa4365ceae7ea6; xorp/ospf/xrl_io.cc 1.14 +9 -5; commitid: 95fa4365ceae7ea6; xorp/ospf/xrl_io.hh From atanu@icir.org Mon Oct 31 08:14:22 2005 From: atanu@icir.org (Atanu Ghosh) Date: Mon, 31 Oct 2005 08:14:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200510310814.j9V8EMYR038693@xorpc.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu@xorpc.icir.org 2005-10-31 08:14:22 UTC XORP CVS repository Modified files: ospf routing_table.cc routing_table.hh Log message: Pass the policy tags into the do_filtering() method. Revision Changes Path 1.24 +4 -3; commitid: 97084365d25d7ea6; xorp/ospf/routing_table.cc 1.25 +2 -2; commitid: 97084365d25d7ea6; xorp/ospf/routing_table.hh