[Xorp-cvs] XORP cvs commit: xorp/rtrmgr

[Pavlin Radoslavov]

> On Tue, Oct 11, 2005 at 04:08:17PM -0700, Pavlin Radoslavov wrote:
> > > > 	#ifdef HOST_OS_WINDOWS
> > > > 	#define isatty(x) _isatty(x)
> > > > 	#define fileno(x) _fileno(x)
> > > > 	#endif
> 
> I'm going to do this the ugly way for the time being, and push these
> down into the appropriate *.l files.

Bruce,

I have the feeling we are cross-talking here.

What I was suggesting/asking was:

1. If the above #define is an acceptable solution from Windows point
   of view, then why don't we add this to some of the common header
   files inside libxorp.
   This will solve the problem across all files, because I came
   across the above #define in a number of places.

2. For the *.ll case specifically, I am planning to add now the
   "%option never-interactive" option to each *.l and *.ll file
   so they won't require any isatty() or fileno() solutions.

In either case, there is no need to hack the *.l and *.ll files.

Pavlin

> I would rather spend time fixing the issue at source later so that I
> can try to get some tinderbox coverage up on xorpv ASAP.
> 
> BMS
> _______________________________________________
> Xorp-cvs mailing list
> Xorp-cvs@icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs