[Xorp-cvs] XORP cvs commit: xorp/bgp xorp/fib2mrib xorp/policy/backend xorp/rib xorp/rip xorp/static_routes

[Atanu Ghosh]

Hi,

Thanks for doing this I think that XLOG_FATAL is too brutal. Can't we
just print a warning and ignore the enabling of tracing?

     Atanu.

>>>>> "Andrea" == Andrea Bittau <abittau@icir.org> writes:

    Andrea> CVSROOT:	/usr/local/www/data/cvs
    Andrea> Module name:	xorp
    Andrea> Changes by:	abittau@xorpc.icir.org	2005-09-04 18:35:51 UTC

    Andrea> XORP CVS repository


    Andrea> Modified files:
    Andrea> bgp           bgp_varrw.cc bgp_varrw.hh route_table_policy.cc 
    Andrea> fib2mrib      fib2mrib_varrw.cc fib2mrib_varrw.hh 
    Andrea> policy/backend single_varrw.cc single_varrw.hh 
    Andrea> rib           rib_varrw.cc rib_varrw.hh 
    Andrea> rip           rip_varrw.cc rip_varrw.hh 
    Andrea> static_routes static_routes_varrw.cc static_routes_varrw.hh 

    Andrea> Log message:
    Andrea> * Hopefully speeded up policy in BGP.  Reads and writes are done via callbacks.
    Andrea> So no more if (variable == x) then, if variable == y then... it's a map lookup
    Andrea> and a function pointer.
	
    Andrea> * Added an XLOG_FATAL if people try to use tracing in BGP---it is broken.  Will
    Andrea> need to code a proper on/off for tracing.  [actually it shouldn't be too
    Andrea> hard].
	
    Andrea> Let me know if anything broke.  [possibly BGP policy]

    Andrea> Revision  Changes                                  Path
    Andrea> 1.19      +328 -183;  commitid: 1f81431b3e207ea6;  xorp/bgp/bgp_varrw.cc
    Andrea> 1.11      +57 -37;  commitid: 1f81431b3e207ea6;    xorp/bgp/bgp_varrw.hh
    Andrea> 1.14      +3 -1;  commitid: 1f81431b3e207ea6;      xorp/bgp/route_table_policy.cc
    Andrea> 1.5       +7 -1;  commitid: 1f81431b3e207ea6;      xorp/fib2mrib/fib2mrib_varrw.cc
    Andrea> 1.3       +4 -4;  commitid: 1f81431b3e207ea6;      xorp/fib2mrib/fib2mrib_varrw.hh
    Andrea> 1.7       +5 -2;  commitid: 1f81431b3e207ea6;      xorp/policy/backend/single_varrw.cc
    Andrea> 1.5       +12 -1;  commitid: 1f81431b3e207ea6;     xorp/policy/backend/single_varrw.hh
    Andrea> 1.7       +7 -1;  commitid: 1f81431b3e207ea6;      xorp/rib/rib_varrw.cc
    Andrea> 1.6       +3 -1;  commitid: 1f81431b3e207ea6;      xorp/rib/rib_varrw.hh
    Andrea> 1.6       +9 -8;  commitid: 1f81431b3e207ea6;      xorp/rip/rip_varrw.cc
    Andrea> 1.6       +2 -1;  commitid: 1f81431b3e207ea6;      xorp/rip/rip_varrw.hh
    Andrea> 1.6       +7 -3;  commitid: 1f81431b3e207ea6;      xorp/static_routes/static_routes_varrw.cc
    Andrea> 1.5       +2 -2;  commitid: 1f81431b3e207ea6;      xorp/static_routes/static_routes_varrw.hh
    Andrea> _______________________________________________
    Andrea> Xorp-cvs mailing list
    Andrea> Xorp-cvs@icir.org
    Andrea> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs