[Xorp-cvs] XORP cvs commit: xorp/ospf

[Atanu Ghosh]

Should be fixed now.

       Atanu.

>>>>> "Pavlin" == Pavlin Radoslavov <pavlin@icir.org> writes:

    >> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by:
    >> atanu@xorpc.icir.org 2005-09-19 23:33:51 UTC
    >> 
    >> XORP CVS repository
    >> 
    >> 
    >> Modified files: ospf peer.cc peer.hh
    >> 
    >> Log message: The specification recommends that IP packets are not
    >> fragmented. The code that tried to ensure that the OSPF packet
    >> fitted within a MTU did not take into account the size of the IP
    >> header or router alert option.
    >> 
    >> A new method get_frame_size() now takes into account length the
    >> IP header and router alert fields.

    Pavlin> Atanu,

    Pavlin> I believe that the "Router Alert" adjustment of
    Pavlin> "4*sizeof(uint8_t)" needs to be applied for IPv6 as well
    Pavlin> (i.e., the OspfTypes::V3 case inside method
    Pavlin> PeerOut<A>::get_frame_size()).

    Pavlin> Pavlin

    >>  Bugzilla URL: http://www.xorp.org/bugzilla/show_bug.cgi?id=221
    >> Bug found by: Patrick Marc Preuss
    >> 
    >> Revision Changes Path 1.154 +39 -6; commitid: 11ed4432f4add7ea6;
    >> xorp/ospf/peer.cc 1.101 +17 -1; commitid: 11ed4432f4add7ea6;
    >> xorp/ospf/peer.hh _______________________________________________
    >> Xorp-cvs mailing list Xorp-cvs@icir.org
    >> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs