[Xorp-cvs] XORP cvs commit: xorp/rtrmgr

[Bruce Simpson]

CVSROOT:	/usr/local/www/data/cvs
Module name:	xorp
Changes by:	bms@xorpc.icir.org	2006-03-14 13:34:10 UTC

XORP CVS repository


Modified files:
	rtrmgr        module_manager.cc module_manager.hh 

Log message:
	Resolve a problem with launching binaries for the Microsoft Windows
	Server port of XORP 1.2.
	
	On Windows, we cannot rely on the presence of a POSIX shell when
	launching XORP system modules such as the RIB and FEA from the module
	manager code in xorp_rtrmgr.exe.
	
	In fact, the win_quote_args() function is intended to only be used
	with non-UNIX style invocation, i.e. a direct call to CreateProcess().
	Argument vectors passed to this function are munged in a manner which
	allows them to be passed, as a single string argument for
	CreateProcess(), to a Microsoft Visual C Runtime application, with
	the correct quoting of backslashes and other Win32 metacharacters.
	
	It should be considered whether RunShellCommand is needed at all,
	and what it means to run something 'under the shell' on Win32.
	
	Pavlin's patch is intended for a more general case but it is an
	almost exact fix for the above issues under Win32.
	
	Submitted by:   pavlin
	Approved by:    atanu (implicitly)
	Bugzilla ID:    http://www.xorp.org/bugzilla/show_bug.cgi?id=559
	See also:       http://www.xorp.org/bugzilla/show_bug.cgi?id=505

Revision  Changes                              Path
1.60      +11 -8;  commitid: 6f44416c5f27ea6;  xorp/rtrmgr/module_manager.cc
1.39      +7 -7;  commitid: 6f44416c5f27ea6;   xorp/rtrmgr/module_manager.hh