[Xorp-cvs] XORP cvs commit: xorp/libxorp

Pavlin Radoslavov pavlin@icir.org
Sat, 25 Mar 2006 03:37:00 -0800


> CVSROOT:	/usr/local/www/data/cvs
> Module name:	xorp
> Changes by:	bms@xorpc.icir.org	2006-03-25 00:05:37 UTC
> 
> XORP CVS repository
> 
> 
> Added files:
> 	libxorp       test_random_uniform.cc 
> 
> Log message:
> 	Add a regression test for the TimeVal::random_uniform() method,
> 	but do not connect to the build.
> 	
> 	Requested by:   atanu
> 
> Revision  Changes    Path
> 1.1       +174 -0    xorp/libxorp/test_random_uniform.cc (new)

Is there a reason to add a new test file when the above TimeVal test
can be added to the existing libxorp/test_timeval.cc file?
Typically, the tests inside libxorp are organized per class. E.g.,
class TimeVal is tested inside test_timeval.cc, class IPv4 is tested
inside test_ipv4.cc and so on.

Indeed, global function random_uniform() is not a TimeVal method,
but is declared inside libxorp/timeval.hh and closely related to
TimeVal, hence I believe it should belong to
libxorp/test_timeval.cc.

Pavlin