From pavlin at icir.org Thu Apr 10 17:19:33 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Fri, 11 Apr 2008 00:19:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804110019.m3B0JX0t033382@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-11 00:19:33 UTC XORP CVS repository Modified files: fea xrl_fea_node.cc xrl_fea_target.cc xrl_fea_target.hh Log message: Minor refactoring of the XrlFeaTarget implementation: reduce the number of arguments to its constructor. Revision Changes Path 1.17 +2 -4; commitid: 823d47feae4841a7; xorp/fea/xrl_fea_node.cc 1.39 +124 -137; commitid: 823d47feae4841a7; xorp/fea/xrl_fea_target.cc 1.26 +3 -21; commitid: 823d47feae4841a7; xorp/fea/xrl_fea_target.hh From pavlin at icir.org Thu Apr 10 19:36:05 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Fri, 11 Apr 2008 02:36:05 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/data_plane/fibconfig Message-ID: <200804110236.m3B2a5dF034633@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-11 02:36:05 UTC XORP CVS repository Modified files: fea fibconfig.hh fibconfig_entry_get.hh fibconfig_entry_set.hh fibconfig_table_get.hh fibconfig_table_set.hh fibconfig_transaction.hh fea/data_plane/fibconfig fibconfig_entry_get_click.hh fibconfig_entry_get_dummy.hh fibconfig_entry_get_iphelper.hh fibconfig_entry_get_netlink_socket.hh fibconfig_entry_get_routing_socket.hh fibconfig_entry_get_rtmv2.hh fibconfig_entry_observer_netlink_socket.cc fibconfig_entry_parse_netlink_socket.cc fibconfig_entry_parse_routing_socket.cc fibconfig_entry_set_click.hh fibconfig_entry_set_dummy.hh fibconfig_entry_set_iphelper.hh fibconfig_entry_set_netlink_socket.hh fibconfig_entry_set_routing_socket.hh fibconfig_entry_set_rtmv2.hh fibconfig_table_get_click.hh fibconfig_table_get_dummy.hh fibconfig_table_get_iphelper.hh fibconfig_table_get_netlink_socket.hh fibconfig_table_get_sysctl.hh fibconfig_table_observer_netlink_socket.cc fibconfig_table_set_click.hh fibconfig_table_set_dummy.hh fibconfig_table_set_iphelper.hh fibconfig_table_set_netlink_socket.hh fibconfig_table_set_routing_socket.hh fibconfig_table_set_rtmv2.hh Log message: Fix kdoc comments. Revision Changes Path 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_click.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_dummy.hh 1.7 +6 -6; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_iphelper.hh 1.7 +6 -6; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_netlink_socket.hh 1.7 +7 -7; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_routing_socket.hh 1.7 +6 -6; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_get_rtmv2.hh 1.11 +3 -3; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_observer_netlink_socket.cc 1.12 +2 -2; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_parse_netlink_socket.cc 1.14 +2 -2; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_parse_routing_socket.cc 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_click.hh 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_dummy.hh 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_iphelper.hh 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_netlink_socket.hh 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_routing_socket.hh 1.7 +13 -8; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_entry_set_rtmv2.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_get_click.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_get_dummy.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_get_iphelper.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_get_netlink_socket.hh 1.7 +5 -5; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_get_sysctl.hh 1.14 +3 -3; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_observer_netlink_socket.cc 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_click.hh 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_dummy.hh 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_iphelper.hh 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_netlink_socket.hh 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_routing_socket.hh 1.7 +12 -10; commitid: 86e147fece8941a7; xorp/fea/data_plane/fibconfig/fibconfig_table_set_rtmv2.hh 1.17 +31 -21; commitid: 86e147fece8941a7; xorp/fea/fibconfig.hh 1.15 +5 -5; commitid: 86e147fece8941a7; xorp/fea/fibconfig_entry_get.hh 1.14 +13 -8; commitid: 86e147fece8941a7; xorp/fea/fibconfig_entry_set.hh 1.15 +5 -5; commitid: 86e147fece8941a7; xorp/fea/fibconfig_table_get.hh 1.13 +11 -9; commitid: 86e147fece8941a7; xorp/fea/fibconfig_table_set.hh 1.6 +7 -7; commitid: 86e147fece8941a7; xorp/fea/fibconfig_transaction.hh From pavlin at icir.org Thu Apr 10 19:52:15 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Fri, 11 Apr 2008 02:52:15 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804110252.m3B2qFpH034792@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-11 02:52:15 UTC XORP CVS repository Modified files: fea fibconfig.hh fibconfig_entry_set.hh fibconfig_table_set.hh Log message: Kdoc nits. Revision Changes Path 1.18 +4 -3; commitid: 87cd47fed25a41a7; xorp/fea/fibconfig.hh 1.15 +4 -3; commitid: 87cd47fed25a41a7; xorp/fea/fibconfig_entry_set.hh 1.14 +4 -3; commitid: 87cd47fed25a41a7; xorp/fea/fibconfig_table_set.hh From pavlin at icir.org Fri Apr 11 11:37:40 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Fri, 11 Apr 2008 18:37:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804111837.m3BIbeZi041664@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-11 18:37:40 UTC XORP CVS repository Modified files: fea fte.hh Log message: Kdoc nits. Revision Changes Path 1.24 +4 -7; commitid: a2a947ffafee41a7; xorp/fea/fte.hh From pavlin at icir.org Fri Apr 11 11:38:08 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Fri, 11 Apr 2008 18:38:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804111838.m3BIc8vR041711@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-11 18:38:08 UTC XORP CVS repository Modified files: fea fibconfig_transaction.cc fibconfig_transaction.hh ifconfig_transaction.hh Log message: Minor cleanup and refactoring. Revision Changes Path 1.6 +16 -30; commitid: a2d447ffb00941a7; xorp/fea/fibconfig_transaction.cc 1.7 +86 -25; commitid: a2d447ffb00941a7; xorp/fea/fibconfig_transaction.hh 1.18 +37 -7; commitid: a2d447ffb00941a7; xorp/fea/ifconfig_transaction.hh From pavlin at icir.org Mon Apr 21 16:47:19 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 21 Apr 2008 23:47:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rtrmgr Message-ID: <200804212347.m3LNlJfh053260@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-21 23:47:19 UTC XORP CVS repository Modified files: rtrmgr conf_tree.cc Log message: Added missing secondary parsing for NODE_INT. Revision Changes Path 1.54 +14 -1; commitid: cff5480d277341a7; xorp/rtrmgr/conf_tree.cc From bms at icir.org Tue Apr 22 05:49:49 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 12:49:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto Message-ID: <200804221249.m3MCnngc058561@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 12:49:49 UTC XORP CVS repository Modified files: libproto spt.hh test_spt.cc Log message: Fix memory leakage in the Spt meta-class. * Add an Spt::clear() method. The _nodes container is repeatedly walked until emptied. Whilst using a depth first search may be quicker, Spt has no notion of Node's degree. * Add an explicit destructor Spt::~Spt which invokes this method. The data members are not PoD, they have special semantics, see next. * In Spt::garbage_collect(), use a reference to the NodeRef, which defeats the ref_ptr reference count. We are, after all, garbage collecting the Node, so we do NOT want a dangling reference. The NodeRefs are candidates for Boost++ shared_ptr and weak_ptr. Obtained from: XORP/OLSR Verified with: valgrind Sponsored by: CenGen, Inc. Revision Changes Path 1.20 +51 -4; commitid: e4a8480ddede41a7; xorp/libproto/spt.hh 1.18 +9 -8; commitid: e4a8480ddede41a7; xorp/libproto/test_spt.cc From bms at icir.org Tue Apr 22 05:50:18 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 12:50:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto Message-ID: <200804221250.m3MCoI9M058618@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 12:50:18 UTC XORP CVS repository Modified files: libproto test_spt.cc Log message: Forced commit to document: Ensure that function names and logging are turned on for the Spt regression test, by defining their manifest constants *before* including libxorp/debug.h. Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.19 +1 -1; commitid: e4d2480ddefa41a7; xorp/libproto/test_spt.cc From bms at icir.org Tue Apr 22 06:13:45 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 13:13:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200804221313.m3MDDjgr058799@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 13:13:45 UTC XORP CVS repository Modified files: libxorp random.c Log message: Fix an uninitialized variable warning in gcc 4.2. Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.15 +2 -2; commitid: e598480de48141a7; xorp/libxorp/random.c From bms at icir.org Tue Apr 22 06:31:21 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 13:31:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rib Message-ID: <200804221331.m3MDVLLI058959@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 13:31:21 UTC XORP CVS repository Modified files: rib rib.cc Log message: In RIB::get_protocol_admin_distance(), demote the ERROR to a WARNING. It is possible that the routing process which causes this method to be called hasn't registered its admin distance yet. The RIB currently lacks support for recomputing an OriginTable when the admin distance changes. Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.72 +3 -3; commitid: e638480de88c41a7; xorp/rib/rib.cc From bms at icir.org Tue Apr 22 06:53:02 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 13:53:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200804221353.m3MDr2ap059128@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 13:53:02 UTC XORP CVS repository Modified files: libcomm comm_api.h comm_sock.c comm_user.c Log message: Import libcomm enhancements which are needed by OLSRv1 for generating IPv4 limited broadcast traffic (255.255.255.255). * Most IP stacks have certain quirks regarding how IPv4 broadcasts are sent and received, because the BSD socket API did not historically handle them with completeness. * For example, like a multicast channel (S,G), the limited broadcast address on its own does not supply enough information to the BSD kernel ip_output() function. * These inconsistencies have been addressed since, by deprecating the use of limited broadcast in favour of link-scope multicast. In the case of IPv6, limited broadcast has been completely eliminated from the network layer protocol. * Unfortunately, protocols such as OLSRv1 and RIPv1 have seen operational deployment WITHOUT being updated to use link-scope multicast, therefore we need to make the appropriate changes to support this behaviour. * Add functions: * comm_set_send_broadcast() Most implementations require that SO_BROADCAST is set to permit the transmission of broadcast messages on a socket. * comm_set_unicast_ttl() Set the TTL field or hop-count field in outgoing IPv4/IPv6 messages. * comm_set_tos() Set the TOS field in outgoing IPv4 messages. * The following functions MUST NOT be used by user routing processes. They exist only to address the specific issue described above regarding the addressing of limited broadcasts. * comm_set_onesbcast() BSD specific. Enables a kernel feature whereby sends to the network broadcast address configured on a vif, are automatically rewritten to contain the limited broadcast address. * comm_set_bindtodevice() Linux specific. Bind a socket to a link-layer device for all receives and transmits. Operates independently of the socket API function bind(). * comm_set_receive_broadcast() Windows Vista and Windows Server 2003 specific. The new TCP/IP implementation requires that processes explicitly request to receive broadcast messages. Windows creates a separate connected FIB entry for each NDIS interface with the TCPIP.SYS transport bound to it which points to the limited broadcast address. * Additionally add *_present() functions to allow libcomm clients to test for the presence of these features. * These functions may potentially be used by RIPv1 at a later date. * The FEA support will come in a later patch. Note: In the XORP/OLSR branch, the new function for setting the TTL on an IPV4 socket is named "comm_set_ttl()". This clashes with the existing function in CVS, which sets the multicast ttl. Therefore the following functions are renamed in this CVS commit: the import of this change set is atomic in CVS: comm_ttl_present -> comm_unicast_ttl_present comm_set_ttl -> comm_set_unicast_ttl Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.31 +94 -1; commitid: e6dd480ded6641a7; xorp/libcomm/comm_api.h 1.45 +218 -8; commitid: e6dd480ded6641a7; xorp/libcomm/comm_sock.c 1.32 +41 -1; commitid: e6dd480ded6641a7; xorp/libcomm/comm_user.c From pavlin at icir.org Tue Apr 22 08:36:45 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 15:36:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libproto Message-ID: <200804221536.m3MFajGi059900@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-22 15:36:45 UTC XORP CVS repository Modified files: libproto spt.hh Log message: XORP coding style bug fix (see devnotes/codying-style.txt): Type & var; -> Type& var; Revision Changes Path 1.21 +3 -3; commitid: e9cd480e059641a7; xorp/libproto/spt.hh From pavlin at ICSI.Berkeley.EDU Tue Apr 22 08:45:17 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 08:45:17 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221313.m3MDDjgr058799@chum.icir.org> References: <200804221313.m3MDDjgr058799@chum.icir.org> Message-ID: <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> Bruce Simpson wrote: > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms at chum.icir.org 2008-04-22 13:13:45 UTC > > XORP CVS repository > > > Modified files: > libxorp random.c > > Log message: > Fix an uninitialized variable warning in gcc 4.2. > > Obtained from: XORP/OLSR > Sponsored by: CenGen, Inc. > > Revision Changes Path > 1.15 +2 -2; commitid: e598480de48141a7; xorp/libxorp/random.c Bruce, The above commit fixes the compilation error, but doesn't fix the problem. In the original code, variable "junk_seed" has been intentionally left uninitialized so when used it will increase the unpredictability in the randomness. In fact, "junk_seed" has been used to feed the unpredicted value into variable "junk" as a compiler work-around. Is there any way to rewrite the code to keep the gcc-4.2 compiler happy and keep junk_seed unintialized? E.g., maybe by using a pointer to "junk_seed" or an array of 1-2 elements of type "long" or something like this. Thanks, Pavlin From pavlin at icir.org Tue Apr 22 09:03:43 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 16:03:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/data_plane/io xorp/libcomm xorp/rip/tools Message-ID: <200804221603.m3MG3h6b060285@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-22 16:03:43 UTC XORP CVS repository Modified files: fea/data_plane/io io_tcpudp_socket.cc libcomm comm_api.h comm_sock.c rip/tools rip_announcer.cc ripng_announcer.cc Log message: Renamed libcomm function comm_set_ttl() to comm_set_multicast_ttl() to reflect the recent addition of a new function named comm_set_unicast_ttl(). Revision Changes Path 1.23 +3 -3; commitid: eb3c480e0c0d41a7; xorp/fea/data_plane/io/io_tcpudp_socket.cc 1.32 +2 -2; commitid: eb3c480e0c0d41a7; xorp/libcomm/comm_api.h 1.46 +2 -2; commitid: eb3c480e0c0d41a7; xorp/libcomm/comm_sock.c 1.15 +3 -3; commitid: eb3c480e0c0d41a7; xorp/rip/tools/rip_announcer.cc 1.14 +3 -3; commitid: eb3c480e0c0d41a7; xorp/rip/tools/ripng_announcer.cc From bms at icir.org Tue Apr 22 09:54:53 2008 From: bms at icir.org (Bruce M. Simpson) Date: Tue, 22 Apr 2008 17:54:53 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> Message-ID: <480E185D.90901@icir.org> Pavlin Radoslavov wrote: > The above commit fixes the compilation error, but doesn't fix the > problem. > In the original code, variable "junk_seed" has been intentionally > left uninitialized so when used it will increase the > unpredictability in the randomness. > In fact, "junk_seed" has been used to feed the unpredicted value > into variable "junk" as a compiler work-around. > Is there any way to rewrite the code to keep the gcc-4.2 compiler > happy and keep junk_seed unintialized? > E.g., maybe by using a pointer to "junk_seed" or an array of 1-2 > elements of type "long" or something like this. Without compiler pragmas, it is difficult to do so without changing compiler options on a per-file basis -- unless we turn off -Werror, and that ain't gonna happen. Boost.Build will allow changing CFLAGS on a per-file basis, it has a different syntax for this. We could in theory do same with automake... I could back it out, but that breaks g++ 4.2 compilation w/-Werror. BMS From bms at incunabulum.net Tue Apr 22 09:55:43 2008 From: bms at incunabulum.net (Bruce M Simpson) Date: Tue, 22 Apr 2008 17:55:43 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/data_plane/io xorp/libcomm xorp/rip/tools In-Reply-To: <200804221603.m3MG3h6b060285@chum.icir.org> References: <200804221603.m3MG3h6b060285@chum.icir.org> Message-ID: <480E188F.9070104@incunabulum.net> Pavlin Radoslavov wrote: > Log message: > Renamed libcomm function comm_set_ttl() to comm_set_multicast_ttl() > to reflect the recent addition of a new function named > comm_set_unicast_ttl(). > Thanks. [I was going to do this in the next pass, but better to fix the udp_listen issues first] cheers BMS From greearb at candelatech.com Tue Apr 22 09:08:40 2008 From: greearb at candelatech.com (Ben Greear) Date: Tue, 22 Apr 2008 09:08:40 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> Message-ID: <480E0D88.1060509@candelatech.com> Pavlin Radoslavov wrote: > Bruce Simpson wrote: > > >> CVSROOT: /usr/local/www/data/cvs >> Module name: xorp >> Changes by: bms at chum.icir.org 2008-04-22 13:13:45 UTC >> >> XORP CVS repository >> >> >> Modified files: >> libxorp random.c >> >> Log message: >> Fix an uninitialized variable warning in gcc 4.2. >> >> Obtained from: XORP/OLSR >> Sponsored by: CenGen, Inc. >> >> Revision Changes Path >> 1.15 +2 -2; commitid: e598480de48141a7; xorp/libxorp/random.c >> > > Bruce, > > The above commit fixes the compilation error, but doesn't fix the > problem. > In the original code, variable "junk_seed" has been intentionally > left uninitialized so when used it will increase the > unpredictability in the randomness. > In fact, "junk_seed" has been used to feed the unpredicted value > into variable "junk" as a compiler work-around. > Is there any way to rewrite the code to keep the gcc-4.2 compiler > happy and keep junk_seed unintialized? > E.g., maybe by using a pointer to "junk_seed" or an array of 1-2 > elements of type "long" or something like this. > That's a scary way to get randomness (these things are usually the same between each start of the system, I have found)...maybe pull from a /dev/random or similar things on other OS? Thanks, Ben > Thanks, > Pavlin > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > -- Ben Greear Candela Technologies Inc http://www.candelatech.com From pavlin at ICSI.Berkeley.EDU Tue Apr 22 10:19:55 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 10:19:55 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <480E0D88.1060509@candelatech.com> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E0D88.1060509@candelatech.com> Message-ID: <200804221719.m3MHJuVW014520@fruitcake.ICSI.Berkeley.EDU> > >> Modified files: > >> libxorp random.c Log message: > >> Fix an uninitialized variable warning in gcc 4.2. > >> > >> Obtained from: XORP/OLSR > >> Sponsored by: CenGen, Inc. > >> > >> Revision Changes Path > >> 1.15 +2 -2; commitid: e598480de48141a7; xorp/libxorp/random.c > >> > > > > Bruce, > > > > The above commit fixes the compilation error, but doesn't fix the > > problem. > > In the original code, variable "junk_seed" has been intentionally > > left uninitialized so when used it will increase the > > unpredictability in the randomness. > > In fact, "junk_seed" has been used to feed the unpredicted value > > into variable "junk" as a compiler work-around. > > Is there any way to rewrite the code to keep the gcc-4.2 compiler > > happy and keep junk_seed unintialized? > > E.g., maybe by using a pointer to "junk_seed" or an array of 1-2 > > elements of type "long" or something like this. > > > That's a scary way to get randomness (these things are usually the same > between each > start of the system, I have found)...maybe pull from a /dev/random or similar > things on other OS? No, we don't relay on the uninitalized value itself only the get the randomness. Actually, inside libxorp/random.c we are using /dev/random :) The uninitialized "junk" variable in combination with gettimeofday() and getpid() is used in case /dev/random doesn't exist. Note that the "junk" variable is allocated on the stack, so it might or might not add some additional unpredictability. Regards, Pavlin From pavlin at ICSI.Berkeley.EDU Tue Apr 22 10:42:42 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 10:42:42 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <480E185D.90901@icir.org> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> Message-ID: <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> > Pavlin Radoslavov wrote: > > The above commit fixes the compilation error, but doesn't fix the > > problem. > > In the original code, variable "junk_seed" has been intentionally > > left uninitialized so when used it will increase the > > unpredictability in the randomness. > > In fact, "junk_seed" has been used to feed the unpredicted value > > into variable "junk" as a compiler work-around. > > Is there any way to rewrite the code to keep the gcc-4.2 compiler > > happy and keep junk_seed unintialized? > > E.g., maybe by using a pointer to "junk_seed" or an array of 1-2 > > elements of type "long" or something like this. > > Without compiler pragmas, it is difficult to do so without changing > compiler options on a per-file basis -- unless we turn off -Werror, and > that ain't gonna happen. > > Boost.Build will allow changing CFLAGS on a per-file basis, it has a > different syntax for this. We could in theory do same with automake... > > I could back it out, but that breaks g++ 4.2 compilation w/-Werror. No, I wasn't thinking of doing something about CFLAGS for this particular file, and I don't think you should back it out and break the g++ 4.2 compilation. I was thinking about trivial work-around in the code itself like: unsigned long junk = 0; unsigned long junk_seed[2]; junk = junk_seed[1]; What OS and compiler version are you using? I have FreeBSD-7.0 (amd64) with the following compiler version and the original code was compiling for me without a warning: gcc (GCC) 4.2.1 20070719 [FreeBSD] Pavlin From greearb at candelatech.com Tue Apr 22 11:00:19 2008 From: greearb at candelatech.com (Ben Greear) Date: Tue, 22 Apr 2008 11:00:19 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> Message-ID: <480E27B3.8050506@candelatech.com> Pavlin Radoslavov wrote: > I was thinking about trivial work-around in the code itself like: > > unsigned long junk = 0; > unsigned long junk_seed[2]; > > junk = junk_seed[1]; > > > What OS and compiler version are you using? > I have FreeBSD-7.0 (amd64) with the following compiler version > and the original code was compiling for me without a warning: > > gcc (GCC) 4.2.1 20070719 [FreeBSD] That's still referencing un-init memory (which is what you are trying to do, after all). Whenever someone fixes the compiler (or uses something to detect bogus memory accesses), it will break again. Maybe instead just use the low-order bits of gettimeofday by itself? Surely that is random enough by itself? Thanks, Ben > > Pavlin > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs -- Ben Greear Candela Technologies Inc http://www.candelatech.com From pavlin at ICSI.Berkeley.EDU Tue Apr 22 11:11:39 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 11:11:39 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <480E27B3.8050506@candelatech.com> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> Message-ID: <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> > > I was thinking about trivial work-around in the code itself like: > > > > unsigned long junk = 0; > > unsigned long junk_seed[2]; > > > > junk = junk_seed[1]; > > > > > > What OS and compiler version are you using? > > I have FreeBSD-7.0 (amd64) with the following compiler version > > and the original code was compiling for me without a warning: > > > > gcc (GCC) 4.2.1 20070719 [FreeBSD] > > That's still referencing un-init memory (which is what you > are trying to do, after all). Whenever someone fixes the compiler > (or uses something to detect bogus memory accesses), > it will break again. I don't have the environment to trigger the warning that Bruce saw so I can play a bit with this, but even if the compiler complains about the uninitialized junk_seed, using something like the following might pacify it: junk_seed[0] = 0; The idea is that with an array we can leave some uninitialized holes, and I doubt that even future versions of the compilers are going to track the initialization of all elements in an array. > Maybe instead just use the low-order bits of gettimeofday > by itself? Surely that is random enough by itself? This is relatively random (as relative as time itself :) The idea is to add a low-complexity solution to get a bit better randomness. Anyway, I think we are spending too much time about a small issue. Bruce, please try the array-with-a-hole work-around and see whether it pacifies your compiler. Thanks, Pavlin From bms at icir.org Tue Apr 22 12:10:18 2008 From: bms at icir.org (Bruce M. Simpson) Date: Tue, 22 Apr 2008 20:10:18 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> Message-ID: <480E381A.6070407@icir.org> Pavlin Radoslavov wrote: > Anyway, I think we are spending too much time about a small issue. > Bruce, please try the array-with-a-hole work-around and see whether > it pacifies your compiler. > Actually, all of the approaches seem to work fine with gcc version 4.2.4 20080409 (prerelease). I can't remember now which gcc 4.2.x version was giving me the problem, there have been a few snapshots since. later BMS From pavlin at icir.org Tue Apr 22 12:38:39 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 19:38:39 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200804221938.m3MJcdKq061668@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-22 19:38:39 UTC XORP CVS repository Modified files: libxorp random.c Log message: Reverse the previous change and use junk_seed[2] array (with an uninitialized element) to get around a compilation warning with some of the gcc-4.2 compilers about uninitialized value. Revision Changes Path 1.16 +5 -4; commitid: f0cd480e3e6c41a7; xorp/libxorp/random.c From pavlin at ICSI.Berkeley.EDU Tue Apr 22 12:40:34 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 22 Apr 2008 12:40:34 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <480E381A.6070407@icir.org> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> <480E381A.6070407@icir.org> Message-ID: <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> Bruce M. Simpson wrote: > Pavlin Radoslavov wrote: > > Anyway, I think we are spending too much time about a small issue. > > Bruce, please try the array-with-a-hole work-around and see whether > > it pacifies your compiler. > > > > Actually, all of the approaches seem to work fine with gcc version 4.2.4 > 20080409 (prerelease). I can't remember now which gcc 4.2.x version was > giving me the problem, there have been a few snapshots since. OK, in that case I committed the array-based solution. If you run across another compilation warning, please record the version of the compiler and let me know. Thanks, Pavlin From bms at icir.org Tue Apr 22 14:14:30 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 22 Apr 2008 21:14:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200804222114.m3MLEUto062317@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-22 21:14:30 UTC XORP CVS repository Modified files: libxipc xrl_pf_stcp.cc xrl_pf_stcp.hh Log message: Rate limit the transmission of STCP keep-alives. There is a clearly reproducible problem in the XRL layer during times of high system load. Whilst I have not examined the problem in detail, the symptom and the fix are reproducible and consistent. This change is an adaptation of the one originally attached to the Bugzilla entry. With the change to use CLOCK_MONOTONIC in the SystemClock class, this fixes the bug, as all timestamps used by the XORP scheduler are now relative to a central clock source independent of the wall-clock time. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=157 Bug found by: Michael Larson Revision Changes Path 1.60 +14 -1; commitid: f354480e547441a7; xorp/libxipc/xrl_pf_stcp.cc 1.29 +2 -1; commitid: f354480e547441a7; xorp/libxipc/xrl_pf_stcp.hh From atanu at icir.org Tue Apr 22 20:29:44 2008 From: atanu at icir.org (Atanu Ghosh) Date: Wed, 23 Apr 2008 03:29:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200804230329.m3N3TihW065064@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-04-23 03:29:44 UTC XORP CVS repository Modified files: bgp bgp.cc Log message: If a BGP peering is bounced due to the interface address changing print an info message. One of the tests was failing because the peering was being bounced. Revision Changes Path 1.92 +5 -2; commitid: fe0f480ead2741a7; xorp/bgp/bgp.cc From atanu at icir.org Tue Apr 22 20:43:23 2008 From: atanu at icir.org (Atanu Ghosh) Date: Wed, 23 Apr 2008 03:43:23 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp xorp/tests/bgp Message-ID: <200804230343.m3N3hNIQ065272@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-04-23 03:43:23 UTC XORP CVS repository Modified files: bgp bgp_varrw.cc tests/bgp test_bgp_config.py test_bgp_reports1.py Log message: Routes that have been introduced by the RIB do not have an originating neighbour. Attempts by the policy filters to lookup the neighbour caused an null peer pointer to be dereferenced. Before looking for the neighbour that a route came from check that the route was not self originated. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=740 Bug found by: Stefan Gula Revision Changes Path 1.34 +2 -2; commitid: feca480eb05941a7; xorp/bgp/bgp_varrw.cc 1.22 +37 -1; commitid: feca480eb05941a7; xorp/tests/bgp/test_bgp_config.py 1.9 +31 -1; commitid: feca480eb05941a7; xorp/tests/bgp/test_bgp_reports1.py From bms at icir.org Wed Apr 23 08:22:41 2008 From: bms at icir.org (Bruce Simpson) Date: Wed, 23 Apr 2008 15:22:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/data_plane/io xorp/xrl/interfaces Message-ID: <200804231522.m3NFMfvO070329@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-23 15:22:41 UTC XORP CVS repository Modified files: fea io_tcpudp.hh io_tcpudp_manager.cc io_tcpudp_manager.hh xrl_fea_target.cc xrl_fea_target.hh fea/data_plane/io io_ip_socket.cc io_tcpudp_dummy.cc io_tcpudp_dummy.hh io_tcpudp_socket.cc io_tcpudp_socket.hh xrl/interfaces socket4.xif socket4_xif.cc socket4_xif.hh socket6.xif socket6_xif.hh Log message: Import the FEA support code for UDP/IPv4 broadcast sockets, as they are required for operational deployment of OLSRv1 and RIPv1. The following XRLs are added to socket4/0.1: * udp_open_bind_broadcast Create a UDP broadcast socket, performing any platform-specific initialization required. NOTE: There is currently no backend regression test for this XRL. * udp_enable_recv Enable reception on a UDP socket if not already enabled. * set_socket_option_txt Set a socket option which has a textual value. Currently the only option accepted by this XRL is the "bindtodevice" option. It is Linux specific and MUST NOT be used by user routing processes. The following XRLs are changed in socket4/0.1: * set_socket_option now accepts the following additional options: "onesbcast" Change broadcasts to all-ones. BSD. "receive_broadcast" Windows specific. "reuseport" Enable SO_REUSEPORT. "send_broadcast" Enable SO_BROADCAST. "tos" Set the IPv4 type-of-service. "ttl" Set the Ipv4 unicast TTL. The addition of "tos" resolves bug 716. * Certain FEA internal functions have been refactored to use the libcomm APIs added to support these XRLs. * The OLSRv1 code has been refactored to use udp_open_bind_broadcast, it will come in a later merge. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=716 Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.20 +25 -50; commitid: 11264480f542a41a7; xorp/fea/data_plane/io/io_ip_socket.cc 1.6 +43 -1; commitid: 11264480f542a41a7; xorp/fea/data_plane/io/io_tcpudp_dummy.cc 1.7 +41 -4; commitid: 11264480f542a41a7; xorp/fea/data_plane/io/io_tcpudp_dummy.hh 1.24 +324 -5; commitid: 11264480f542a41a7; xorp/fea/data_plane/io/io_tcpudp_socket.cc 1.11 +54 -3; commitid: 11264480f542a41a7; xorp/fea/data_plane/io/io_tcpudp_socket.hh 1.9 +50 -2; commitid: 11264480f542a41a7; xorp/fea/io_tcpudp.hh 1.9 +182 -1; commitid: 11264480f542a41a7; xorp/fea/io_tcpudp_manager.cc 1.10 +116 -5; commitid: 11264480f542a41a7; xorp/fea/io_tcpudp_manager.hh 1.40 +76 -1; commitid: 11264480f542a41a7; xorp/fea/xrl_fea_target.cc 1.27 +88 -3; commitid: 11264480f542a41a7; xorp/fea/xrl_fea_target.hh 1.14 +85 -4; commitid: 11264480f542a41a7; xorp/xrl/interfaces/socket4.xif 1.23 +123 -1; commitid: 11264480f542a41a7; xorp/xrl/interfaces/socket4_xif.cc 1.22 +116 -5; commitid: 11264480f542a41a7; xorp/xrl/interfaces/socket4_xif.hh 1.14 +3 -2; commitid: 11264480f542a41a7; xorp/xrl/interfaces/socket6.xif 1.22 +3 -3; commitid: 11264480f542a41a7; xorp/xrl/interfaces/socket6_xif.hh From pavlin at icir.org Wed Apr 23 09:51:50 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 23 Apr 2008 16:51:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/interfaces Message-ID: <200804231651.m3NGpoEx071275@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-23 16:51:50 UTC XORP CVS repository Modified files: xrl/interfaces socket6.xif Log message: Updated the kdoc comments to include "reuseport" to the list of valid option names. Revision Changes Path 1.15 +2 -1; commitid: 11648480f68f841a7; xorp/xrl/interfaces/socket6.xif From pavlin at icir.org Wed Apr 23 09:57:14 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 23 Apr 2008 16:57:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200804231657.m3NGvE2K071372@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-23 16:57:14 UTC XORP CVS repository Modified files: xrl/interfaces socket6_xif.hh xrl/targets fea.xrls fea_base.cc fea_base.hh Log message: Updated the kdoc comments to include "reuseport" to the list of valid option names. Revision Changes Path 1.23 +3 -3; commitid: 1169e480f6a3141a7; xorp/xrl/interfaces/socket6_xif.hh 1.81 +67 -8; commitid: 1169e480f6a3141a7; xorp/xrl/targets/fea.xrls 1.84 +114 -1; commitid: 1169e480f6a3141a7; xorp/xrl/targets/fea_base.cc 1.90 +97 -8; commitid: 1169e480f6a3141a7; xorp/xrl/targets/fea_base.hh From pavlin at icir.org Wed Apr 23 09:58:45 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 23 Apr 2008 16:58:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/data_plane/io Message-ID: <200804231658.m3NGwjNP071446@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-23 16:58:44 UTC XORP CVS repository Modified files: fea io_tcpudp.hh io_tcpudp_manager.hh xrl_fea_target.hh fea/data_plane/io io_tcpudp_dummy.hh io_tcpudp_socket.hh Log message: Updated the kdoc comments for method set_socket_option() Revision Changes Path 1.8 +10 -2; commitid: 116e0480f6a9b41a7; xorp/fea/data_plane/io/io_tcpudp_dummy.hh 1.12 +5 -5; commitid: 116e0480f6a9b41a7; xorp/fea/data_plane/io/io_tcpudp_socket.hh 1.10 +9 -2; commitid: 116e0480f6a9b41a7; xorp/fea/io_tcpudp.hh 1.11 +5 -5; commitid: 116e0480f6a9b41a7; xorp/fea/io_tcpudp_manager.hh 1.28 +5 -2; commitid: 116e0480f6a9b41a7; xorp/fea/xrl_fea_target.hh From bms at icir.org Thu Apr 24 04:06:42 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 11:06:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200804241106.m3OB6gDh078798@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 11:06:42 UTC XORP CVS repository Modified files: . Jamrules.in Log message: In the FTJam build: * Always substitute configure's notion of LIBS into the Jam LINKLIBS variable. We were missing essential libraries in Win32. * Check for C++ compilers named g++*, when forcing the C++ compiler driver to be used as the linker driver (as GNU C++ requires). Sponsored by: CenGen, Inc. Revision Changes Path 1.10 +4 -5; commitid: 133b7481069bb41a7; xorp/Jamrules.in From bms at icir.org Thu Apr 24 04:16:16 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 11:16:16 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/rip Message-ID: <200804241116.m3OBGGcP078900@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 11:16:16 UTC XORP CVS repository Modified files: rip xrl_port_io.hh Log message: Remove a forward declaration for a non-existent class. Sponsored by: CenGen, Inc. Revision Changes Path 1.15 +1 -2; commitid: 1341d48106bf141a7; xorp/rip/xrl_port_io.hh From bms at icir.org Thu Apr 24 06:47:55 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 13:47:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual/figs Message-ID: <200804241347.m3ODltxL079905@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 13:47:55 UTC XORP CVS repository Added files: docs/user_manual/figs cd1.png cd2.png cd3.png cd4.png Log message: Add PNG versions of the CD figures. A default installation of Kile for FreeBSD uses teTeX, and its default package configuration does not seem to recognise GIF files. Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.1 +6 -0 xorp/docs/user_manual/figs/cd1.png (new) 1.1 +10 -0 xorp/docs/user_manual/figs/cd2.png (new) 1.1 +4 -0 xorp/docs/user_manual/figs/cd3.png (new) 1.1 +21 -0 xorp/docs/user_manual/figs/cd4.png (new) From bms at icir.org Thu Apr 24 07:58:00 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 14:58:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr Message-ID: <200804241458.m3OEw0XI080389@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 14:58:00 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/contrib/olsr added to the repository From bms at icir.org Thu Apr 24 07:58:08 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 14:58:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr/tools Message-ID: <200804241458.m3OEw83C080406@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 14:58:08 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/contrib/olsr/tools added to the repository From bms at icir.org Thu Apr 24 07:58:32 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 14:58:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr/regression Message-ID: <200804241458.m3OEwWXr080423@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 14:58:32 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/contrib/olsr/regression added to the repository From bms at icir.org Thu Apr 24 07:58:38 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 14:58:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr/doxy Message-ID: <200804241458.m3OEwcOd080440@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 14:58:38 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/contrib/olsr/doxy added to the repository From bms at icir.org Thu Apr 24 08:01:55 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 15:01:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/olsr Message-ID: <200804241501.m3OF1txA080520@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 15:01:55 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/docs/olsr added to the repository From bms at icir.org Thu Apr 24 08:20:37 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 15:20:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/bgp xorp/bgp/harness xorp/bgp/tools xorp/cli xorp/cli/tools xorp/contrib xorp/contrib/olsr xorp/contrib/olsr/doxy xorp/contrib/olsr/regression xorp/contrib/olsr/tools xorp/docs xorp/docs/bgp xorp/docs/design_arch xorp/docs/fea ... Message-ID: <200804241520.m3OFKbqd082252@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 15:20:37 UTC XORP CVS repository Modified files: . Makefile.in MakefileRootCheck.in configure configure.in bgp Makefile.in bgp/harness Makefile.in bgp/tools Makefile.in cli Makefile.in cli/tools Makefile.in contrib Makefile.am Makefile.in docs Makefile.am Makefile.in docs/bgp Makefile.in docs/design_arch Makefile.in docs/fea Makefile.in docs/libxipc Makefile.in docs/libxorp Makefile.in docs/mfea Makefile.in docs/mld6igmp Makefile.in docs/multicast Makefile.in docs/pim Makefile.in docs/pim_testsuite Makefile.in docs/rib Makefile.in docs/rtrmgr Makefile.in docs/slides Makefile.in docs/slides/status_2004_02 Makefile.in docs/snmp Makefile.in docs/test_harness Makefile.in docs/user_manual Makefile.in docs/xorpdev_101 Makefile.in etc Makefile.in etc/templates Makefile.am Makefile.in policy.tp rib.cmds fea Makefile.in MakefileRootCheck.in fea/data_plane Makefile.in fea/data_plane/control_socket Makefile.in fea/data_plane/fibconfig Makefile.in fea/data_plane/ifconfig Makefile.in fea/data_plane/io Makefile.in fea/data_plane/managers Makefile.in fea/tools Makefile.in fib2mrib Makefile.in libcomm Makefile.in libfeaclient Makefile.in libproto Makefile.in libxipc Jamfile Makefile.in libxorp Makefile.in task.cc task.hh timer.cc mibs configure mld6igmp Makefile.in mrt Makefile.in ospf Jamfile Makefile.in ospf/tools Makefile.in pim Makefile.in policy Makefile.in policy/backend Makefile.in policy/common Makefile.in policy/test Makefile.in rib Makefile.in rib/tools Makefile.in rip Makefile.in rip/tools Makefile.in rtrmgr Makefile.in rtrmgr/config Makefile.in static_routes Makefile.in utils Makefile.in utils/flower_malloc Makefile.in xrl Makefile.in xrl/interfaces Jamfile Makefile.am Makefile.in xrl/targets Jamfile Makefile.am Makefile.in xrl/tests Makefile.in Added files: contrib/olsr Doxyfile Jamfile Makefile.am Makefile.in NOTES README TODO debug_io.cc debug_io.hh emulate_net.cc emulate_net.hh exceptions.hh external.cc external.hh face.cc face.hh face_manager.cc face_manager.hh io.hh link.cc link.hh message.cc message.hh neighbor.cc neighbor.hh neighborhood.cc neighborhood.hh olsr.cc olsr.hh olsr_module.h olsr_types.cc olsr_types.hh policy_varrw.cc policy_varrw.hh profile_vars.cc profile_vars.hh route_manager.cc route_manager.hh test_args.hh test_common.hh test_faces.cc test_message.cc test_olsr_types.cc test_routing1.py test_simulator.cc topology.cc topology.hh trace.hh twohop.cc twohop.hh vertex.hh xorp_olsr.cc xorp_olsr4_wrapper.sh xrl_io.cc xrl_io.hh xrl_port.cc xrl_port.hh xrl_queue.cc xrl_queue.hh xrl_target.cc xrl_target.hh contrib/olsr/doxy doxyfiles-footer.html doxyfiles-header.html contrib/olsr/regression hello_empty_ok_ipv4.data hello_multi_ok_ipv4.data hello_single_ok_ipv4.data hna_ok_ipv4.data mid_ok_ipv4.data multi_msg_ok_ipv4.data tc_ok_ipv4.data contrib/olsr/tools Jamfile Makefile.am Makefile.in clear_database.cc print_databases.cc docs/olsr Makefile.am Makefile.in olsr.tex olsr_manual.tex preface.tex xorp_toc.sty etc/templates olsr4.cmds olsr4.tp xrl/interfaces olsr4.xif olsr4_xif.cc olsr4_xif.hh xrl/targets olsr4.tgt olsr4.xrls olsr4_base.cc olsr4_base.hh Log message: Import OLSRv1 for XORP. This is a from-scratch implementation of OLSRv1 (RFC 3626) in C++ for XORP: * This work was kindly supported by CenGen, Inc. * A protocol simulator and a reasonably complete set of regression tests is provided. * Policy route redistribution is supported. Routes from other XORP protocols may be redistributed into OLSRv1-HNA; tested with OSPFv2. * Currently the ETX link metric extension is NOT supported. There are two conflicting goals here: * XORP developers strongly prefer that new protocols be first placed in contrib. * Individuals using the OLSRv1 implementation in XORP need the ability to run xorp_olsr without performing a full installation, for testing purposes. The following limitations mean that the import of this code cannot be solely confined to the contrib directory: * The Automake-based build system does not easily facilitate building XRL client and target stubs outside of the XRL directories. * This limitation is addressed in FTJam and Boost.BuildV2, however the change of build system has not yet been accepted. * The Router Manager does not currently accept additional arguments for the XRL and template directory paths, therefore certain OLSR specific files are installed even when OLSR is not built. The compromise is to place the code drop itself in the contrib directory, with the following files becoming part of the main tree, for now: * The router manager template files: etc/templates/olsr4.cmds etc/templates/olsr4.tp * The OLSR XRL interface: xrl/interfaces/olsr4.xif xrl/interfaces/olsr4_xif.cc xrl/interfaces/olsr4_xif.hh * The OLSR XRL target: xrl/targets/olsr4.tgt xrl/targets/olsr4.xrls xrl/targets/olsr4_base.cc xrl/targets/olsr4_base.hh The user manual for OLSRv1 is built separately from the XORP user manual. Like SNMP, it is an optional component, however all of the documentation is built by default when TeX documentation is being built. Some additional changes to the Autotools build system are needed in order to build OLSRv1 as a component using that build system: * Split AC_OUTPUT(..files..) into AC_CONFIG_FILES([..files..]) and AC_OUTPUT, as the first use has been deprecated since autoconf 2.57. * Remove the creation of stamp-h from AC_OUTPUT. The use of stamp-h has been deprecated since autoconf 2.57. See: http://osdir.com/ml/sysutils.automake.patches/2002-04/msg00062.html * Refactor to use a new internal variable, CONTRIB_SUBDIRS, which is propagated to SUBDIRS in contrib/Makefile.am. * This variable controls which subdirectories in contrib will form part of a "gmake" or "gmake check". * However, the logic for substitution currently resides in the top-level configure.in as a case..esac conditional. * This is to defer the developer overhead of parceling off contrib components into separate autoconf packages, when they largely share the same build characteristics as the rest of the tree. * The exception to this is snmp, which needs to be a separate libtool package to ensure it is always built as a shared library, therefore it remains in AC_CONFIG_SUBDIRS() with its own configure.in. * The Makefile.in files throughout the XORP tree are regenerated as part of this commit. Obtained from: XORP/OLSR Sponsored by: CenGen, Inc. Revision Changes Path 1.56 +1 -0; commitid: 13b274810a46941a7; xorp/Makefile.in 1.18 +1 -0; commitid: 13b274810a46941a7; xorp/MakefileRootCheck.in 1.70 +1 -0; commitid: 13b274810a46941a7; xorp/bgp/Makefile.in 1.48 +1 -0; commitid: 13b274810a46941a7; xorp/bgp/harness/Makefile.in 1.38 +1 -0; commitid: 13b274810a46941a7; xorp/bgp/tools/Makefile.in 1.35 +1 -0; commitid: 13b274810a46941a7; xorp/cli/Makefile.in 1.14 +1 -0; commitid: 13b274810a46941a7; xorp/cli/tools/Makefile.in 1.278 +63 -31; commitid: 13b274810a46941a7; xorp/configure 1.215 +56 -9; commitid: 13b274810a46941a7; xorp/configure.in 1.3 +4 -1; commitid: 13b274810a46941a7; xorp/contrib/Makefile.am 1.14 +200 -37; commitid: 13b274810a46941a7; xorp/contrib/Makefile.in 1.1 +1327 -0 xorp/contrib/olsr/Doxyfile (new) 1.1 +104 -0 xorp/contrib/olsr/Jamfile (new) 1.1 +133 -0 xorp/contrib/olsr/Makefile.am (new) 1.1 +835 -0 xorp/contrib/olsr/Makefile.in (new) 1.1 +353 -0 xorp/contrib/olsr/NOTES (new) 1.1 +36 -0 xorp/contrib/olsr/README (new) 1.1 +119 -0 xorp/contrib/olsr/TODO (new) 1.1 +355 -0 xorp/contrib/olsr/debug_io.cc (new) 1.1 +210 -0 xorp/contrib/olsr/debug_io.hh (new) 1.1 +7 -0 xorp/contrib/olsr/doxy/doxyfiles-footer.html (new) 1.1 +14 -0 xorp/contrib/olsr/doxy/doxyfiles-header.html (new) 1.1 +286 -0 xorp/contrib/olsr/emulate_net.cc (new) 1.1 +170 -0 xorp/contrib/olsr/emulate_net.hh (new) 1.1 +158 -0 xorp/contrib/olsr/exceptions.hh (new) 1.1 +694 -0 xorp/contrib/olsr/external.cc (new) 1.1 +520 -0 xorp/contrib/olsr/external.hh (new) 1.1 +126 -0 xorp/contrib/olsr/face.cc (new) 1.1 +360 -0 xorp/contrib/olsr/face.hh (new) 1.1 +1346 -0 xorp/contrib/olsr/face_manager.cc (new) 1.1 +733 -0 xorp/contrib/olsr/face_manager.hh (new) 1.1 +340 -0 xorp/contrib/olsr/io.hh (new) 1.1 +161 -0 xorp/contrib/olsr/link.cc (new) 1.1 +274 -0 xorp/contrib/olsr/link.hh (new) 1.1 +892 -0 xorp/contrib/olsr/message.cc (new) 1.1 +826 -0 xorp/contrib/olsr/message.hh (new) 1.1 +330 -0 xorp/contrib/olsr/neighbor.cc (new) 1.1 +333 -0 xorp/contrib/olsr/neighbor.hh (new) 1.1 +2312 -0 xorp/contrib/olsr/neighborhood.cc (new) 1.1 +1255 -0 xorp/contrib/olsr/neighborhood.hh (new) 1.1 +350 -0 xorp/contrib/olsr/olsr.cc (new) 1.1 +588 -0 xorp/contrib/olsr/olsr.hh (new) 1.1 +26 -0 xorp/contrib/olsr/olsr_module.h (new) 1.1 +96 -0 xorp/contrib/olsr/olsr_types.cc (new) 1.1 +382 -0 xorp/contrib/olsr/olsr_types.hh (new) 1.1 +126 -0 xorp/contrib/olsr/policy_varrw.cc (new) 1.1 +67 -0 xorp/contrib/olsr/policy_varrw.hh (new) 1.1 +46 -0 xorp/contrib/olsr/profile_vars.cc (new) 1.1 +38 -0 xorp/contrib/olsr/profile_vars.hh (new) 1.1 +22 -0 xorp/contrib/olsr/regression/hello_empty_ok_ipv4.data (new) 1.1 +36 -0 xorp/contrib/olsr/regression/hello_multi_ok_ipv4.data (new) 1.1 +28 -0 xorp/contrib/olsr/regression/hello_single_ok_ipv4.data (new) 1.1 +21 -0 xorp/contrib/olsr/regression/hna_ok_ipv4.data (new) 1.1 +22 -0 xorp/contrib/olsr/regression/mid_ok_ipv4.data (new) 1.1 +34 -0 xorp/contrib/olsr/regression/multi_msg_ok_ipv4.data (new) 1.1 +21 -0 xorp/contrib/olsr/regression/tc_ok_ipv4.data (new) 1.1 +681 -0 xorp/contrib/olsr/route_manager.cc (new) 1.1 +456 -0 xorp/contrib/olsr/route_manager.hh (new) 1.1 +221 -0 xorp/contrib/olsr/test_args.hh (new) 1.1 +38 -0 xorp/contrib/olsr/test_common.hh (new) 1.1 +476 -0 xorp/contrib/olsr/test_faces.cc (new) 1.1 +760 -0 xorp/contrib/olsr/test_message.cc (new) 1.1 +205 -0 xorp/contrib/olsr/test_olsr_types.cc (new) 1.1 +1743 -0 xorp/contrib/olsr/test_routing1.py (new) 1.1 +2508 -0 xorp/contrib/olsr/test_simulator.cc (new) 1.1 +26 -0 xorp/contrib/olsr/tools/Jamfile (new) 1.1 +45 -0 xorp/contrib/olsr/tools/Makefile.am (new) 1.1 +614 -0 xorp/contrib/olsr/tools/Makefile.in (new) 1.1 +133 -0 xorp/contrib/olsr/tools/clear_database.cc (new) 1.1 +1485 -0 xorp/contrib/olsr/tools/print_databases.cc (new) 1.1 +1097 -0 xorp/contrib/olsr/topology.cc (new) 1.1 +621 -0 xorp/contrib/olsr/topology.hh (new) 1.1 +105 -0 xorp/contrib/olsr/trace.hh (new) 1.1 +141 -0 xorp/contrib/olsr/twohop.cc (new) 1.1 +334 -0 xorp/contrib/olsr/twohop.hh (new) 1.1 +303 -0 xorp/contrib/olsr/vertex.hh (new) 1.1 +84 -0 xorp/contrib/olsr/xorp_olsr.cc (new) 1.1 +44 -0 xorp/contrib/olsr/xorp_olsr4_wrapper.sh (new) 1.1 +1125 -0 xorp/contrib/olsr/xrl_io.cc (new) 1.1 +462 -0 xorp/contrib/olsr/xrl_io.hh (new) 1.1 +279 -0 xorp/contrib/olsr/xrl_port.cc (new) 1.1 +201 -0 xorp/contrib/olsr/xrl_port.hh (new) 1.1 +237 -0 xorp/contrib/olsr/xrl_queue.cc (new) 1.1 +116 -0 xorp/contrib/olsr/xrl_queue.hh (new) 1.1 +1226 -0 xorp/contrib/olsr/xrl_target.cc (new) 1.1 +884 -0 xorp/contrib/olsr/xrl_target.hh (new) 1.8 +2 -2; commitid: 13b274810a46941a7; xorp/docs/Makefile.am 1.32 +2 -1; commitid: 13b274810a46941a7; xorp/docs/Makefile.in 1.29 +1 -0; commitid: 13b274810a46941a7; xorp/docs/bgp/Makefile.in 1.29 +1 -0; commitid: 13b274810a46941a7; xorp/docs/design_arch/Makefile.in 1.29 +1 -0; commitid: 13b274810a46941a7; xorp/docs/fea/Makefile.in 1.30 +1 -0; commitid: 13b274810a46941a7; xorp/docs/libxipc/Makefile.in 1.29 +1 -0; commitid: 13b274810a46941a7; xorp/docs/libxorp/Makefile.in 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/mfea/Makefile.in 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/mld6igmp/Makefile.in 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/multicast/Makefile.in 1.1 +21 -0 xorp/docs/olsr/Makefile.am (new) 1.1 +517 -0 xorp/docs/olsr/Makefile.in (new) 1.1 +533 -0 xorp/docs/olsr/olsr.tex (new) 1.1 +110 -0 xorp/docs/olsr/olsr_manual.tex (new) 1.1 +87 -0 xorp/docs/olsr/preface.tex (new) 1.1 +633 -0 xorp/docs/olsr/xorp_toc.sty (new) 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/pim/Makefile.in 1.43 +1 -0; commitid: 13b274810a46941a7; xorp/docs/pim_testsuite/Makefile.in 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/rib/Makefile.in 1.31 +1 -0; commitid: 13b274810a46941a7; xorp/docs/rtrmgr/Makefile.in 1.16 +1 -0; commitid: 13b274810a46941a7; xorp/docs/slides/Makefile.in 1.16 +1 -0; commitid: 13b274810a46941a7; xorp/docs/slides/status_2004_02/Makefile.in 1.29 +1 -0; commitid: 13b274810a46941a7; xorp/docs/snmp/Makefile.in 1.28 +1 -0; commitid: 13b274810a46941a7; xorp/docs/test_harness/Makefile.in 1.24 +1 -0; commitid: 13b274810a46941a7; xorp/docs/user_manual/Makefile.in 1.16 +1 -0; commitid: 13b274810a46941a7; xorp/docs/xorpdev_101/Makefile.in 1.18 +1 -0; commitid: 13b274810a46941a7; xorp/etc/Makefile.in 1.21 +2 -1; commitid: 13b274810a46941a7; xorp/etc/templates/Makefile.am 1.38 +6 -5; commitid: 13b274810a46941a7; xorp/etc/templates/Makefile.in 1.1 +104 -0 xorp/etc/templates/olsr4.cmds (new) 1.1 +383 -0 xorp/etc/templates/olsr4.tp (new) 1.26 +2 -1; commitid: 13b274810a46941a7; xorp/etc/templates/policy.tp 1.12 +54 -1; commitid: 13b274810a46941a7; xorp/etc/templates/rib.cmds 1.125 +1 -0; commitid: 13b274810a46941a7; xorp/fea/Makefile.in 1.17 +1 -0; commitid: 13b274810a46941a7; xorp/fea/MakefileRootCheck.in 1.6 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/Makefile.in 1.5 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/control_socket/Makefile.in 1.6 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/fibconfig/Makefile.in 1.9 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/ifconfig/Makefile.in 1.7 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/io/Makefile.in 1.3 +1 -0; commitid: 13b274810a46941a7; xorp/fea/data_plane/managers/Makefile.in 1.14 +1 -0; commitid: 13b274810a46941a7; xorp/fea/tools/Makefile.in 1.21 +1 -0; commitid: 13b274810a46941a7; xorp/fib2mrib/Makefile.in 1.36 +1 -0; commitid: 13b274810a46941a7; xorp/libcomm/Makefile.in 1.26 +1 -0; commitid: 13b274810a46941a7; xorp/libfeaclient/Makefile.in 1.42 +1 -0; commitid: 13b274810a46941a7; xorp/libproto/Makefile.in 1.4 +2 -2; commitid: 13b274810a46941a7; xorp/libxipc/Jamfile 1.73 +1 -0; commitid: 13b274810a46941a7; xorp/libxipc/Makefile.in 1.73 +1 -0; commitid: 13b274810a46941a7; xorp/libxorp/Makefile.in 1.9 +14 -1; commitid: 13b274810a46941a7; xorp/libxorp/task.cc 1.11 +3 -1; commitid: 13b274810a46941a7; xorp/libxorp/task.hh 1.41 +9 -1; commitid: 13b274810a46941a7; xorp/libxorp/timer.cc 1.61 +1 -1; commitid: 13b274810a46941a7; xorp/mibs/configure 1.61 +1 -0; commitid: 13b274810a46941a7; xorp/mld6igmp/Makefile.in 1.34 +1 -0; commitid: 13b274810a46941a7; xorp/mrt/Makefile.in 1.6 +15 -6; commitid: 13b274810a46941a7; xorp/ospf/Jamfile 1.33 +1 -0; commitid: 13b274810a46941a7; xorp/ospf/Makefile.in 1.12 +1 -0; commitid: 13b274810a46941a7; xorp/ospf/tools/Makefile.in 1.64 +1 -0; commitid: 13b274810a46941a7; xorp/pim/Makefile.in 1.39 +1 -0; commitid: 13b274810a46941a7; xorp/policy/Makefile.in 1.19 +1 -0; commitid: 13b274810a46941a7; xorp/policy/backend/Makefile.in 1.18 +1 -0; commitid: 13b274810a46941a7; xorp/policy/common/Makefile.in 1.19 +1 -0; commitid: 13b274810a46941a7; xorp/policy/test/Makefile.in 1.64 +1 -0; commitid: 13b274810a46941a7; xorp/rib/Makefile.in 1.15 +1 -0; commitid: 13b274810a46941a7; xorp/rib/tools/Makefile.in 1.63 +1 -0; commitid: 13b274810a46941a7; xorp/rip/Makefile.in 1.16 +1 -0; commitid: 13b274810a46941a7; xorp/rip/tools/Makefile.in 1.79 +1 -0; commitid: 13b274810a46941a7; xorp/rtrmgr/Makefile.in 1.4 +1 -0; commitid: 13b274810a46941a7; xorp/rtrmgr/config/Makefile.in 1.22 +1 -0; commitid: 13b274810a46941a7; xorp/static_routes/Makefile.in 1.37 +1 -0; commitid: 13b274810a46941a7; xorp/utils/Makefile.in 1.17 +1 -0; commitid: 13b274810a46941a7; xorp/utils/flower_malloc/Makefile.in 1.26 +1 -0; commitid: 13b274810a46941a7; xorp/xrl/Makefile.in 1.6 +3 -1; commitid: 13b274810a46941a7; xorp/xrl/interfaces/Jamfile 1.38 +5 -1; commitid: 13b274810a46941a7; xorp/xrl/interfaces/Makefile.am 1.61 +29 -17; commitid: 13b274810a46941a7; xorp/xrl/interfaces/Makefile.in 1.1 +576 -0 xorp/xrl/interfaces/olsr4.xif (new) 1.1 +1930 -0 xorp/xrl/interfaces/olsr4_xif.cc (new) 1.1 +1155 -0 xorp/xrl/interfaces/olsr4_xif.hh (new) 1.5 +4 -1; commitid: 13b274810a46941a7; xorp/xrl/targets/Jamfile 1.70 +14 -1; commitid: 13b274810a46941a7; xorp/xrl/targets/Makefile.am 1.92 +45 -26; commitid: 13b274810a46941a7; xorp/xrl/targets/Makefile.in 1.1 +17 -0 xorp/xrl/targets/olsr4.tgt (new) 1.1 +696 -0 xorp/xrl/targets/olsr4.xrls (new) 1.1 +2813 -0 xorp/xrl/targets/olsr4_base.cc (new) 1.1 +1287 -0 xorp/xrl/targets/olsr4_base.hh (new) 1.33 +1 -0; commitid: 13b274810a46941a7; xorp/xrl/tests/Makefile.in From bms at incunabulum.net Thu Apr 24 08:23:52 2008 From: bms at incunabulum.net (Bruce M Simpson) Date: Thu, 24 Apr 2008 16:23:52 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/bgp xorp/bgp/harness xorp/bgp/tools xorp/cli xorp/cli/tools xorp/contrib xorp/contrib/olsr xorp/contrib/olsr/doxy xorp/contrib/olsr/regression xorp/contrib/olsr/tools xorp/docs xorp/docs/bgp xorp/docs/design_arch xorp/docs/fea ... In-Reply-To: <200804241520.m3OFKbqd082252@chum.icir.org> References: <200804241520.m3OFKbqd082252@chum.icir.org> Message-ID: <4810A608.6040106@incunabulum.net> To build the optional OLSR routing process, pass --with-olsr to configure. regards BMS From bms at icir.org Thu Apr 24 10:48:24 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 24 Apr 2008 17:48:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/etc/templates Message-ID: <200804241748.m3OHmOdR083603@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-24 17:48:23 UTC XORP CVS repository Modified files: . configure configure.in etc/templates Makefile.am Makefile.in Log message: Resolve issue with olsr4.tp/olsr4.cmds being installed unconditionally; install them from etc/templates only if --with-olsr was passed to top-level configure. Requested by: Atanu Ghosh Revision Changes Path 1.279 +46 -25; commitid: 146634810c78041a7; xorp/configure 1.216 +5 -2; commitid: 146634810c78041a7; xorp/configure.in 1.22 +5 -2; commitid: 146634810c78041a7; xorp/etc/templates/Makefile.am 1.39 +6 -5; commitid: 146634810c78041a7; xorp/etc/templates/Makefile.in From atanu at icir.org Thu Apr 24 17:25:43 2008 From: atanu at icir.org (Atanu Ghosh) Date: Fri, 25 Apr 2008 00:25:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200804250025.m3P0Phpr086654@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-04-25 00:25:43 UTC XORP CVS repository Modified files: bgp/harness harness.py Log message: Add an argument to support IPv6 connections. Revision Changes Path 1.2 +20 -6; commitid: 152654811250641a7; xorp/bgp/harness/harness.py From bms at icir.org Fri Apr 25 08:51:01 2008 From: bms at icir.org (Bruce M. Simpson) Date: Fri, 25 Apr 2008 16:51:01 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> <480E381A.6070407@icir.org> <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> Message-ID: <4811FDE5.8030506@icir.org> Pavlin Radoslavov wrote: > OK, in that case I committed the array-based solution. > If you run across another compilation warning, please > record the version of the compiler and let me know. Breaks under Gentoo. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: fnord.txt Url: http://mailman.ICSI.Berkeley.EDU/pipermail/xorp-cvs/attachments/20080425/251b7045/attachment.txt From atanu at icir.org Fri Apr 25 12:10:01 2008 From: atanu at icir.org (Atanu Ghosh) Date: Fri, 25 Apr 2008 19:10:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200804251910.m3PJA134094669@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-04-25 19:10:01 UTC XORP CVS repository Modified files: bgp/harness test_peering2.sh Log message: Add support for easily playing saved IPv6 feeds. Revision Changes Path 1.62 +66 -4; commitid: 171b448122c8941a7; xorp/bgp/harness/test_peering2.sh From pavlin at ICSI.Berkeley.EDU Fri Apr 25 16:05:16 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Fri, 25 Apr 2008 16:05:16 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <4811FDE5.8030506@icir.org> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> <480E381A.6070407@icir.org> <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> <4811FDE5.8030506@icir.org> Message-ID: <200804252305.m3PN5G1k018740@fruitcake.ICSI.Berkeley.EDU> Bruce M. Simpson wrote: > Pavlin Radoslavov wrote: > > OK, in that case I committed the array-based solution. > > If you run across another compilation warning, please > > record the version of the compiler and let me know. > Breaks under Gentoo. Which Gentoo version are you using? Gentoo 2007.0 or 2008.0_beta1 or something else? Thanks, Pavlin > > > anglepoise:~/hg/xorp-olsr/libxorp % jam > ...found 380 target(s)... > ...using 41 temp target(s)... > ...updating 2 target(s)... > Cc random.o > cc1: warnings being treated as errors > random.c: In function ???xorp_srandomdev???: > random.c:386: warning: ???junk_seed[1]??? is used uninitialized in this function > > gcc -c -o random.o -g -Werror -W -Wall -Wwrite-strings -Wbad-function-cast > -Wmissing-prototypes -Wcast-qual -Wmissing-declarations -Wpointer-arith > -Wcast-align -Wstrict-prototypes -Wnested-externs -pipe -O -I. -I. -I.. > random.c > > ...failed Cc random.o ... > ...skipped libxorp.a for lack of libxorp.a(random.o)... > ...failed updating 1 target(s)... > ...skipped 1 target(s)... > Exit 1 > anglepoise:~/hg/xorp-olsr/libxorp % gcc -v > Using built-in specs. > Target: i686-pc-linux-gnu > Configured with: /var/tmp/portage/sys-devel/gcc-4.1.2/work/gcc-4.1.2/configure > --prefix=/usr --bindir=/usr/i686-pc-linux-gnu/gcc-bin/4.1.2 > --includedir=/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/include > --datadir=/usr/share/gcc-data/i686-pc-linux-gnu/4.1.2 > --mandir=/usr/share/gcc-data/i686-pc-linux-gnu/4.1.2/man > --infodir=/usr/share/gcc-data/i686-pc-linux-gnu/4.1.2/info > --with-gxx-include-dir=/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/include/g++-v4 > --host=i686-pc-linux-gnu --build=i686-pc-linux-gnu --disable-altivec > --enable-nls --without-included-gettext --with-system-zlib --disable-checking > --disable-werror --enable-secureplt --disable-libunwind-exceptions > --disable-multilib --enable-libmudflap --disable-libssp --disable-libgcj > --enable-languages=c,c++,fortran --enable-shared --enable-threads=posix > --enable-__cxa_atexit --enable-clocale=gnu > Thread model: posix > gcc version 4.1.2 (Gentoo 4.1.2) > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin at icir.org Fri Apr 25 17:30:18 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 00:30:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/data_plane/firewall Message-ID: <200804260030.m3Q0UI70098242@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 00:30:18 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/fea/data_plane/firewall added to the repository From pavlin at icir.org Fri Apr 25 17:37:06 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 00:37:06 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/config Message-ID: <200804260037.m3Q0b6Za098364@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 00:37:06 UTC XORP CVS repository Modified files: config aciolink.m4 Log message: Fix a typo. Revision Changes Path 1.6 +2 -2; commitid: 180254812792c41a7; xorp/config/aciolink.m4 From pavlin at icir.org Fri Apr 25 17:59:52 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 00:59:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/config xorp/etc/templates xorp/fea xorp/fea/data_plane xorp/fea/data_plane/firewall xorp/fea/data_plane/managers xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200804260059.m3Q0xq4n098841@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 00:59:52 UTC XORP CVS repository Modified files: . ERRATA config.h.in configure configure.in config acfirewall.m4 etc/templates Jamfile Makefile.am Makefile.in fea.tp fea Jamfile Makefile.am Makefile.in fea_data_plane_manager.cc fea_data_plane_manager.hh fea_node.cc fea_node.hh xrl_fea_node.cc xrl_fea_node.hh xrl_fea_target.cc xrl_fea_target.hh fea/data_plane Jamfile Makefile.am Makefile.in fea/data_plane/managers fea_data_plane_manager_bsd.cc fea_data_plane_manager_click.cc fea_data_plane_manager_click.hh fea_data_plane_manager_dummy.cc fea_data_plane_manager_linux.cc xrl/interfaces Jamfile Makefile.am Makefile.in xrl/targets Jamfile Makefile.am Makefile.in fea.tgt fea.xrls fea_base.cc fea_base.hh Added files: etc/templates firewall.tp fea firewall_entry.cc firewall_entry.hh firewall_get.hh firewall_manager.cc firewall_manager.hh firewall_set.hh firewall_transaction.cc firewall_transaction.hh fea/data_plane/firewall .cvsignore Jamfile Makefile.am Makefile.in firewall_get_dummy.cc firewall_get_dummy.hh firewall_get_ipfw2.cc firewall_get_ipfw2.hh firewall_get_netfilter.cc firewall_get_netfilter.hh firewall_get_pf.cc firewall_get_pf.hh firewall_set_dummy.cc firewall_set_dummy.hh firewall_set_ipfw2.cc firewall_set_ipfw2.hh firewall_set_netfilter.cc firewall_set_netfilter.hh firewall_set_pf.cc firewall_set_pf.hh xrl/interfaces fea_firewall.xif fea_firewall_xif.cc fea_firewall_xif.hh Removed files: fea pa_backend.hh pa_backend_dummy.cc pa_backend_dummy.hh pa_backend_ipfw2.cc pa_backend_ipfw2.hh pa_backend_nf.cc pa_backend_nf.hh pa_backend_pf.cc pa_backend_pf.hh pa_entry.cc pa_entry.hh pa_table.cc pa_table.hh pa_transaction.cc pa_transaction.hh xrl_packet_acl.cc xrl_packet_acl.hh xrl/interfaces packet_acl.xif packet_acl_xif.cc packet_acl_xif.hh xrl/targets packet_acl.tgt packet_acl.xrls packet_acl_base.cc packet_acl_base.hh Log message: * Added a firewall implementation that fits with the new plugin-based FEA architecture. The implemented plugins are: - ipfw2 (FreeBSD) - pf (BSD) - netfilter (Linux) Currently, the firewall support is very basic: - IPv4 and IPv6 - rules numbering/ordering - protocol number - incoming interface - source and destination network address - source and destination port range (for TCP and UDP) The implementation should be considered alpha version that needs more work, improvements and testing. Note that the Linux netfilter plugin won't be compiled by default because of broken system header files. See ERRATA for information how to fix the header files. * Removed the older firewall backend. Revision Changes Path 1.41 +36 -1; commitid: 180444812794b41a7; xorp/ERRATA 1.95 +35 -12; commitid: 180444812794b41a7; xorp/config.h.in 1.3 +300 -46; commitid: 180444812794b41a7; xorp/config/acfirewall.m4 1.280 +1203 -33; commitid: 180444812794b41a7; xorp/configure 1.217 +3 -2; commitid: 180444812794b41a7; xorp/configure.in 1.4 +2 -1; commitid: 180444812794b41a7; xorp/etc/templates/Jamfile 1.23 +2 -1; commitid: 180444812794b41a7; xorp/etc/templates/Makefile.am 1.40 +5 -5; commitid: 180444812794b41a7; xorp/etc/templates/Makefile.in 1.41 +2 -2; commitid: 180444812794b41a7; xorp/etc/templates/fea.tp 1.4 +184 -0 xorp/etc/templates/firewall.tp (new) 1.26 +5 -8; commitid: 180444812794b41a7; xorp/fea/Jamfile 1.105 +11 -17; commitid: 180444812794b41a7; xorp/fea/Makefile.am 1.126 +23 -28; commitid: 180444812794b41a7; xorp/fea/Makefile.in 1.5 +2 -1; commitid: 180444812794b41a7; xorp/fea/data_plane/Jamfile 1.4 +2 -2; commitid: 180444812794b41a7; xorp/fea/data_plane/Makefile.am 1.7 +1 -1; commitid: 180444812794b41a7; xorp/fea/data_plane/Makefile.in 1.1 +7 -0 xorp/fea/data_plane/firewall/.cvsignore (new) 1.1 +24 -0 xorp/fea/data_plane/firewall/Jamfile (new) 1.1 +38 -0 xorp/fea/data_plane/firewall/Makefile.am (new) 1.1 +493 -0 xorp/fea/data_plane/firewall/Makefile.in (new) 1.1 +124 -0 xorp/fea/data_plane/firewall/firewall_get_dummy.cc (new) 1.1 +79 -0 xorp/fea/data_plane/firewall/firewall_get_dummy.hh (new) 1.1 +402 -0 xorp/fea/data_plane/firewall/firewall_get_ipfw2.cc (new) 1.1 +92 -0 xorp/fea/data_plane/firewall/firewall_get_ipfw2.hh (new) 1.1 +504 -0 xorp/fea/data_plane/firewall/firewall_get_netfilter.cc (new) 1.1 +95 -0 xorp/fea/data_plane/firewall/firewall_get_netfilter.hh (new) 1.1 +365 -0 xorp/fea/data_plane/firewall/firewall_get_pf.cc (new) 1.1 +94 -0 xorp/fea/data_plane/firewall/firewall_get_pf.hh (new) 1.1 +187 -0 xorp/fea/data_plane/firewall/firewall_set_dummy.cc (new) 1.1 +145 -0 xorp/fea/data_plane/firewall/firewall_set_dummy.hh (new) 1.1 +460 -0 xorp/fea/data_plane/firewall/firewall_set_ipfw2.cc (new) 1.1 +127 -0 xorp/fea/data_plane/firewall/firewall_set_ipfw2.hh (new) 1.1 +1068 -0 xorp/fea/data_plane/firewall/firewall_set_netfilter.cc (new) 1.1 +222 -0 xorp/fea/data_plane/firewall/firewall_set_netfilter.hh (new) 1.1 +558 -0 xorp/fea/data_plane/firewall/firewall_set_pf.cc (new) 1.1 +183 -0 xorp/fea/data_plane/firewall/firewall_set_pf.hh (new) 1.9 +19 -1; commitid: 180444812794b41a7; xorp/fea/data_plane/managers/fea_data_plane_manager_bsd.cc 1.8 +37 -5; commitid: 180444812794b41a7; xorp/fea/data_plane/managers/fea_data_plane_manager_click.cc 1.9 +7 -7; commitid: 180444812794b41a7; xorp/fea/data_plane/managers/fea_data_plane_manager_click.hh 1.10 +7 -1; commitid: 180444812794b41a7; xorp/fea/data_plane/managers/fea_data_plane_manager_dummy.cc 1.9 +10 -1; commitid: 180444812794b41a7; xorp/fea/data_plane/managers/fea_data_plane_manager_linux.cc 1.10 +136 -2; commitid: 180444812794b41a7; xorp/fea/fea_data_plane_manager.cc 1.11 +27 -1; commitid: 180444812794b41a7; xorp/fea/fea_data_plane_manager.hh 1.16 +9 -3; commitid: 180444812794b41a7; xorp/fea/fea_node.cc 1.15 +11 -14; commitid: 180444812794b41a7; xorp/fea/fea_node.hh 1.1 +55 -0 xorp/fea/firewall_entry.cc (new) 1.1 +196 -0 xorp/fea/firewall_entry.hh (new) 1.1 +114 -0 xorp/fea/firewall_get.hh (new) 1.1 +838 -0 xorp/fea/firewall_manager.cc (new) 1.1 +489 -0 xorp/fea/firewall_manager.hh (new) 1.1 +226 -0 xorp/fea/firewall_set.hh (new) 1.1 +49 -0 xorp/fea/firewall_transaction.cc (new) 1.1 +249 -0 xorp/fea/firewall_transaction.hh (new) 1.9 +0 -106 xorp/fea/pa_backend.hh (dead) 1.10 +0 -111 xorp/fea/pa_backend_dummy.cc (dead) 1.9 +0 -92 xorp/fea/pa_backend_dummy.hh (dead) 1.13 +0 -624 xorp/fea/pa_backend_ipfw2.cc (dead) 1.9 +0 -178 xorp/fea/pa_backend_ipfw2.hh (dead) 1.6 +0 -447 xorp/fea/pa_backend_nf.cc (dead) 1.5 +0 -117 xorp/fea/pa_backend_nf.hh (dead) 1.8 +0 -476 xorp/fea/pa_backend_pf.cc (dead) 1.8 +0 -148 xorp/fea/pa_backend_pf.hh (dead) 1.7 +0 -53 xorp/fea/pa_entry.cc (dead) 1.7 +0 -182 xorp/fea/pa_entry.hh (dead) 1.8 +0 -210 xorp/fea/pa_table.cc (dead) 1.8 +0 -185 xorp/fea/pa_table.hh (dead) 1.15 +0 -217 xorp/fea/pa_transaction.cc (dead) 1.9 +0 -318 xorp/fea/pa_transaction.hh (dead) 1.18 +1 -19; commitid: 180444812794b41a7; xorp/fea/xrl_fea_node.cc 1.13 +1 -4; commitid: 180444812794b41a7; xorp/fea/xrl_fea_node.hh 1.41 +350 -1; commitid: 180444812794b41a7; xorp/fea/xrl_fea_target.cc 1.29 +338 -1; commitid: 180444812794b41a7; xorp/fea/xrl_fea_target.hh 1.11 +0 -671 xorp/fea/xrl_packet_acl.cc (dead) 1.9 +0 -404 xorp/fea/xrl_packet_acl.hh (dead) 1.7 +3 -3; commitid: 180444812794b41a7; xorp/xrl/interfaces/Jamfile 1.39 +5 -5; commitid: 180444812794b41a7; xorp/xrl/interfaces/Makefile.am 1.62 +30 -30; commitid: 180444812794b41a7; xorp/xrl/interfaces/Makefile.in 1.1 +255 -0 xorp/xrl/interfaces/fea_firewall.xif (new) 1.1 +594 -0 xorp/xrl/interfaces/fea_firewall_xif.cc (new) 1.1 +446 -0 xorp/xrl/interfaces/fea_firewall_xif.hh (new) 1.3 +0 -200 xorp/xrl/interfaces/packet_acl.xif (dead) 1.10 +0 -570 xorp/xrl/interfaces/packet_acl_xif.cc (dead) 1.9 +0 -409 xorp/xrl/interfaces/packet_acl_xif.hh (dead) 1.6 +1 -4; commitid: 180444812794b41a7; xorp/xrl/targets/Jamfile 1.71 +2 -9; commitid: 180444812794b41a7; xorp/xrl/targets/Makefile.am 1.93 +22 -34; commitid: 180444812794b41a7; xorp/xrl/targets/Makefile.in 1.18 +3 -1; commitid: 180444812794b41a7; xorp/xrl/targets/fea.tgt 1.82 +232 -1; commitid: 180444812794b41a7; xorp/xrl/targets/fea.xrls 1.85 +572 -1; commitid: 180444812794b41a7; xorp/xrl/targets/fea_base.cc 1.91 +384 -1; commitid: 180444812794b41a7; xorp/xrl/targets/fea_base.hh 1.4 +0 -7 xorp/xrl/targets/packet_acl.tgt (dead) 1.8 +0 -175 xorp/xrl/targets/packet_acl.xrls (dead) 1.10 +0 -758 xorp/xrl/targets/packet_acl_base.cc (dead) 1.10 +0 -380 xorp/xrl/targets/packet_acl_base.hh (dead) From pavlin at icir.org Fri Apr 25 18:19:22 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 01:19:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/interfaces Message-ID: <200804260119.m3Q1JMpa099068@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 01:19:22 UTC XORP CVS repository Modified files: xrl/interfaces socket6_xif.cc socket6_xif.hh Log message: Forced commit to fix a timestamp problem that triggers file regeneration. Revision Changes Path 1.22 +1 -1; commitid: 182e3481282fb41a7; xorp/xrl/interfaces/socket6_xif.cc 1.24 +1 -1; commitid: 182e3481282fb41a7; xorp/xrl/interfaces/socket6_xif.hh From bms at icir.org Fri Apr 25 18:24:05 2008 From: bms at icir.org (Bruce M. Simpson) Date: Sat, 26 Apr 2008 02:24:05 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200804252305.m3PN5G1k018740@fruitcake.ICSI.Berkeley.EDU> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> <480E381A.6070407@icir.org> <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> <4811FDE5.8030506@icir.org> <200804252305.m3PN5G1k018740@fruitcake.ICSI.Berkeley.EDU> Message-ID: <48128435.1070704@icir.org> Pavlin Radoslavov wrote: > Which Gentoo version are you using? > Gentoo 2007.0 or 2008.0_beta1 or something else? > 2008.1 off the top of my head, the machine's shut down just now. I don't recall if it rebuilt gcc when I switched to the new profile, or not. BMS From pavlin at icir.org Fri Apr 25 18:51:00 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 01:51:00 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804260151.m3Q1p0DG099371@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 01:51:00 UTC XORP CVS repository Modified files: fea fea_node.cc Log message: If the firewall manager fails to start then just print an error in case the firewall support int he underlying system is not enabled. Revision Changes Path 1.17 +6 -2; commitid: 1841448128a5d41a7; xorp/fea/fea_node.cc From pavlin at icir.org Fri Apr 25 19:06:35 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 02:06:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/data_plane/firewall Message-ID: <200804260206.m3Q26ZW0099530@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 02:06:35 UTC XORP CVS repository Modified files: fea/data_plane/firewall firewall_get_ipfw2.cc firewall_set_ipfw2.cc Log message: Simplify the "#define IPFW2" usage to avoid the FreeBSD conditioning. Revision Changes Path 1.2 +7 -6; commitid: 184b148128df841a7; xorp/fea/data_plane/firewall/firewall_get_ipfw2.cc 1.2 +7 -6; commitid: 184b148128df841a7; xorp/fea/data_plane/firewall/firewall_set_ipfw2.cc From pavlin at icir.org Fri Apr 25 19:07:27 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 02:07:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea/data_plane/firewall Message-ID: <200804260207.m3Q27R7U099573@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 02:07:27 UTC XORP CVS repository Modified files: fea/data_plane/firewall firewall_get_ipfw2.cc Log message: Bug fix: HAVE_INET6 -> HAVE_IPV6 Revision Changes Path 1.3 +2 -2; commitid: 184de48128e5241a7; xorp/fea/data_plane/firewall/firewall_get_ipfw2.cc From pavlin at icir.org Fri Apr 25 20:41:47 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 03:41:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200804260341.m3Q3flXS000376@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 03:41:47 UTC XORP CVS repository Modified files: libxorp random.c Log message: Use memset() to initialize part of junk_seed. This is needed to pacify a warning generated by the gcc-4.1.2 compiler on Gentoo 2008.0_beta1 and using "jam" for the compilation. It appears that the warning was generated only if the "-O" and "-g" compiler flags were used. Apparently, the "-0" flag is added by "jam", but is not added when using the default "gmake" compilation. Bug found by: Bruce M. Simpson Revision Changes Path 1.17 +2 -2; commitid: 1494812a3b841a7; xorp/libxorp/random.c From pavlin at ICSI.Berkeley.EDU Fri Apr 25 20:48:19 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Fri, 25 Apr 2008 20:48:19 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <48128435.1070704@icir.org> References: <200804221313.m3MDDjgr058799@chum.icir.org> <200804221545.m3MFjHjQ022005@fruitcake.ICSI.Berkeley.EDU> <480E185D.90901@icir.org> <200804221742.m3MHggKQ019828@fruitcake.ICSI.Berkeley.EDU> <480E27B3.8050506@candelatech.com> <200804221811.m3MIBdTv026055@fruitcake.ICSI.Berkeley.EDU> <480E381A.6070407@icir.org> <200804221940.m3MJeYF4016498@fruitcake.ICSI.Berkeley.EDU> <4811FDE5.8030506@icir.org> <200804252305.m3PN5G1k018740@fruitcake.ICSI.Berkeley.EDU> <48128435.1070704@icir.org> Message-ID: <200804260348.m3Q3mJ5V018834@fruitcake.ICSI.Berkeley.EDU> > Pavlin Radoslavov wrote: > > Which Gentoo version are you using? > > Gentoo 2007.0 or 2008.0_beta1 or something else? > > > 2008.1 off the top of my head, the machine's shut down just now. > > I don't recall if it rebuilt gcc when I switched to the new profile, or not. Thanks for the update. I ended installing Gentoo 2008.0_beta1 under VMware and was finally able to reproduce the problem. It turned to be that the warning is generated only if you use "jam" to compile XORP instead of the default "gmake". The difference was that "jam" was adding the "-O" compiler flag which actually was the trigger. I just committed a fix that used memset() to zero only the first emement of junk_seed[2] : Revision Changes Path 1.17 +2 -2; commitid: 1494812a3b841a7; xorp/libxorp/random.c Please let me know if you still see compilation warnings. Thanks, Pavlin From pavlin at icir.org Fri Apr 25 21:22:30 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 04:22:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/mibs Message-ID: <200804260422.m3Q4MUFc000752@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 04:22:30 UTC XORP CVS repository Modified files: mibs configure configure.in Log message: Apply some of the changes from the top-level configure.in * Split AC_OUTPUT(files) into AC_CONFIG_FILES(files) and AC_OUTPUT() since the first one has been deprecated since autoconf 2.57 * Removed the creation of stamp-h from AC_OUTPUT, because stamp-h has been deprecated since autoconf 2.57 Obtained from: Bruce M. Simpson's changes to xorp/configure.in rev 1.215 Revision Changes Path 1.62 +10 -8; commitid: 2b14812ace041a7; xorp/mibs/configure 1.29 +13 -10; commitid: 2b14812ace041a7; xorp/mibs/configure.in From pavlin at icir.org Sat Apr 26 00:31:10 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sat, 26 Apr 2008 07:31:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200804260731.m3Q7VANx002016@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-26 07:31:10 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Added a note for Ubuntu. Revision Changes Path 1.101 +3 -1; commitid: 7c64812da3241a7; xorp/BUILD_NOTES From mjh at icir.org Sun Apr 27 01:09:32 2008 From: mjh at icir.org (Mark Handley) Date: Sun, 27 Apr 2008 08:09:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200804270809.m3R89WFE013587@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: mjh at chum.icir.org 2008-04-27 08:09:32 UTC XORP CVS repository Modified files: bgp path_attribute.cc Log message: Fix bug in Community Attribute comparison that would lead to data structure corruptions if two path attribute lists only differed in the set of communities. Thanks to Atanu for isolating the test case. Revision Changes Path 1.92 +5 -5; commitid: 34fc4814343541a7; xorp/bgp/path_attribute.cc From pavlin at icir.org Sun Apr 27 16:08:07 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 27 Apr 2008 23:08:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates xorp/fea xorp/fea/data_plane/firewall xorp/xrl/interfaces xorp/xrl/targets Message-ID: <200804272308.m3RN8715019699@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-27 23:08:07 UTC XORP CVS repository Modified files: etc/templates firewall.tp fea firewall_manager.cc firewall_manager.hh firewall_set.hh firewall_transaction.hh xrl_fea_target.cc xrl_fea_target.hh fea/data_plane/firewall firewall_set_dummy.cc firewall_set_dummy.hh firewall_set_ipfw2.cc firewall_set_ipfw2.hh firewall_set_netfilter.cc firewall_set_netfilter.hh firewall_set_pf.cc firewall_set_pf.hh xrl/interfaces fea_firewall.xif fea_firewall_xif.cc fea_firewall_xif.hh xrl/targets fea.xrls fea_base.cc fea_base.hh Log message: Added support to replace/update existing firewall entries. Revision Changes Path 1.5 +3 -3; commitid: 4c704815070f41a7; xorp/etc/templates/firewall.tp 1.2 +16 -2; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_dummy.cc 1.2 +13 -1; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_dummy.hh 1.3 +15 -1; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_ipfw2.cc 1.2 +13 -1; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_ipfw2.hh 1.2 +16 -2; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_netfilter.cc 1.2 +13 -1; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_netfilter.hh 1.2 +16 -2; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_pf.cc 1.2 +13 -1; commitid: 4c704815070f41a7; xorp/fea/data_plane/firewall/firewall_set_pf.hh 1.2 +23 -1; commitid: 4c704815070f41a7; xorp/fea/firewall_manager.cc 1.2 +11 -1; commitid: 4c704815070f41a7; xorp/fea/firewall_manager.hh 1.2 +13 -1; commitid: 4c704815070f41a7; xorp/fea/firewall_set.hh 1.2 +45 -1; commitid: 4c704815070f41a7; xorp/fea/firewall_transaction.hh 1.42 +81 -1; commitid: 4c704815070f41a7; xorp/fea/xrl_fea_target.cc 1.30 +89 -1; commitid: 4c704815070f41a7; xorp/fea/xrl_fea_target.hh 1.2 +68 -1; commitid: 4c704815070f41a7; xorp/xrl/interfaces/fea_firewall.xif 1.2 +109 -1; commitid: 4c704815070f41a7; xorp/xrl/interfaces/fea_firewall_xif.cc 1.2 +115 -1; commitid: 4c704815070f41a7; xorp/xrl/interfaces/fea_firewall_xif.hh 1.83 +61 -1; commitid: 4c704815070f41a7; xorp/xrl/targets/fea.xrls 1.86 +83 -1; commitid: 4c704815070f41a7; xorp/xrl/targets/fea_base.cc 1.92 +97 -1; commitid: 4c704815070f41a7; xorp/xrl/targets/fea_base.hh From pavlin at icir.org Sun Apr 27 22:21:07 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 28 Apr 2008 05:21:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea xorp/fea/data_plane/firewall Message-ID: <200804280521.m3S5L7Sp030325@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-28 05:21:07 UTC XORP CVS repository Modified files: fea firewall_manager.cc firewall_manager.hh firewall_set.hh fea/data_plane/firewall firewall_set_dummy.cc firewall_set_dummy.hh firewall_set_ipfw2.cc firewall_set_ipfw2.hh firewall_set_netfilter.cc firewall_set_netfilter.hh firewall_set_pf.cc firewall_set_pf.hh Log message: Refactor the API between the FirewallManager and the FirewallSet plugin. After the refactoring the firewall entries update is atomic and doesn't have the extra overhead of pushing the entries one-by-one. Revision Changes Path 1.3 +93 -63; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_dummy.cc 1.3 +39 -35; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_dummy.hh 1.4 +101 -73; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_ipfw2.cc 1.3 +39 -35; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_ipfw2.hh 1.3 +116 -79; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_netfilter.cc 1.3 +39 -35; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_netfilter.hh 1.3 +190 -167; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_pf.cc 1.3 +40 -35; commitid: 761f48155dbf41a7; xorp/fea/data_plane/firewall/firewall_set_pf.hh 1.3 +41 -80; commitid: 761f48155dbf41a7; xorp/fea/firewall_manager.cc 1.3 +25 -27; commitid: 761f48155dbf41a7; xorp/fea/firewall_manager.hh 1.3 +12 -106; commitid: 761f48155dbf41a7; xorp/fea/firewall_set.hh From pavlin at icir.org Mon Apr 28 08:56:28 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 28 Apr 2008 15:56:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804281556.m3SFuSg1034790@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-28 15:56:28 UTC XORP CVS repository Modified files: fea firewall_manager.cc firewall_manager.hh Log message: Removed trivial code that is not used currently. If it is needed in the future it will be easy to add it back at that time. Revision Changes Path 1.4 +1 -45; commitid: 87a84815f30141a7; xorp/fea/firewall_manager.cc 1.4 +1 -101; commitid: 87a84815f30141a7; xorp/fea/firewall_manager.hh From pavlin at icir.org Mon Apr 28 09:25:37 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 28 Apr 2008 16:25:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200804281625.m3SGPbfO035052@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-28 16:25:37 UTC XORP CVS repository Modified files: . BUILD_NOTES Log message: Added a note about MacOS X 10.2 Revision Changes Path 1.102 +5 -1; commitid: 88d54815fa6c41a7; xorp/BUILD_NOTES From bms at icir.org Mon Apr 28 15:37:51 2008 From: bms at icir.org (Bruce Simpson) Date: Mon, 28 Apr 2008 22:37:51 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/contrib/olsr xorp/contrib/olsr/tools xorp/etc/templates xorp/mibs Message-ID: <200804282237.m3SMbph0037548@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-28 22:37:51 UTC XORP CVS repository Modified files: . configure configure.in contrib/olsr Makefile.am Makefile.in contrib/olsr/tools Makefile.am Makefile.in etc/templates olsr4.cmds mibs configure Log message: Build OLSR by default. * Update paths in olsr4.cmds to quiesce the Router Manager warnings, both when olsr is installed, and when it is run, but not installed. * Relocate olsr when installed to contrib/olsr. * Rerun bootstrap. Requested by: Atanu Ghosh Revision Changes Path 1.281 +5 -5; commitid: 92424816512d41a7; xorp/configure 1.218 +7 -7; commitid: 92424816512d41a7; xorp/configure.in 1.2 +2 -2; commitid: 92424816512d41a7; xorp/contrib/olsr/Makefile.am 1.2 +1 -1; commitid: 92424816512d41a7; xorp/contrib/olsr/Makefile.in 1.2 +2 -2; commitid: 92424816512d41a7; xorp/contrib/olsr/tools/Makefile.am 1.2 +1 -1; commitid: 92424816512d41a7; xorp/contrib/olsr/tools/Makefile.in 1.2 +10 -10; commitid: 92424816512d41a7; xorp/etc/templates/olsr4.cmds 1.63 +1 -1; commitid: 92424816512d41a7; xorp/mibs/configure From pavlin at ICSI.Berkeley.EDU Mon Apr 28 16:12:12 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Mon, 28 Apr 2008 16:12:12 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/contrib/olsr xorp/contrib/olsr/tools xorp/etc/templates xorp/mibs In-Reply-To: <200804282237.m3SMbph0037548@chum.icir.org> References: <200804282237.m3SMbph0037548@chum.icir.org> Message-ID: <200804282312.m3SNCCoX017140@fruitcake.ICSI.Berkeley.EDU> Bruce Simpson wrote: > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms at chum.icir.org 2008-04-28 22:37:51 UTC > > XORP CVS repository > > > Modified files: > . configure configure.in > contrib/olsr Makefile.am Makefile.in > contrib/olsr/tools Makefile.am Makefile.in > etc/templates olsr4.cmds > mibs configure > > Log message: > Build OLSR by default. > * Update paths in olsr4.cmds to quiesce the Router Manager warnings, > both when olsr is installed, and when it is run, but not installed. > * Relocate olsr when installed to contrib/olsr. Based on the above change, shouldn't etc/templates.olsr4.tp be modifed as well to point to contrib/olsr/xorp_olsr4 (the %modinfo: path line)? Thanks, Pavlin > * Rerun bootstrap. > > Requested by: Atanu Ghosh > > Revision Changes Path > 1.281 +5 -5; commitid: 92424816512d41a7; xorp/configure > 1.218 +7 -7; commitid: 92424816512d41a7; xorp/configure.in > 1.2 +2 -2; commitid: 92424816512d41a7; xorp/contrib/olsr/Makefile.am > 1.2 +1 -1; commitid: 92424816512d41a7; xorp/contrib/olsr/Makefile.in > 1.2 +2 -2; commitid: 92424816512d41a7; xorp/contrib/olsr/tools/Makefile.am > 1.2 +1 -1; commitid: 92424816512d41a7; xorp/contrib/olsr/tools/Makefile.in > 1.2 +10 -10; commitid: 92424816512d41a7; xorp/etc/templates/olsr4.cmds > 1.63 +1 -1; commitid: 92424816512d41a7; xorp/mibs/configure > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From bms at icir.org Mon Apr 28 16:40:34 2008 From: bms at icir.org (Bruce Simpson) Date: Mon, 28 Apr 2008 23:40:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/etc/templates Message-ID: <200804282340.m3SNeYIL038076@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-28 23:40:34 UTC XORP CVS repository Modified files: etc/templates olsr4.tp Log message: Update path in template file. Bug found by: Pavlin Radoslavov Revision Changes Path 1.2 +3 -3; commitid: 94a54816606741a7; xorp/etc/templates/olsr4.tp From pavlin at icir.org Mon Apr 28 18:37:07 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 29 Apr 2008 01:37:07 GMT Subject: [Xorp-cvs] XORP cvs commit: CVSROOT Message-ID: <200804290137.m3T1b7BD038981@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: CVSROOT Changes by: pavlin at chum.icir.org 2008-04-29 01:37:07 UTC XORP CVS repository Modified files: . cvsignore Log message: Added .svn to the list of globally ignored files. This is the directory used by Subversion for housekeeping. Revision Changes Path 1.2 +2 -0; commitid: 982e48167b8241a7; CVSROOT/cvsignore From pavlin at icir.org Mon Apr 28 18:53:44 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 29 Apr 2008 01:53:44 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes Message-ID: <200804290153.m3T1riPj039129@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-29 01:53:44 UTC XORP CVS repository Modified files: devnotes update_cvsroot.sh Log message: Replaced "echo -n" with "echo", because the former doesn't work as expected on MacOS X 10.2 with the following /bin/sh version: GNU bash, version 3.2.17(1)-release (i386-apple-darwin9.0) Interestingly, the corresponding /bin/bash is fine: user at host[3] sh sh-3.2$ echo -n FOO -n FOO <------ WRONG sh-3.2$ exit user at host[4] bash bash-3.2$ echo -n FOO FOObash-3.2$ <------- OK Revision Changes Path 1.4 +2 -2; commitid: 98a848167dfb41a7; xorp/devnotes/update_cvsroot.sh From pavlin at icir.org Tue Apr 29 08:17:10 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 29 Apr 2008 15:17:10 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr Message-ID: <200804291517.m3TFHAJf044749@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-29 15:17:10 UTC XORP CVS repository Modified files: contrib/olsr test_routing1.py Log message: Forced commit, because now the execution bit of this file is enabled (inside CVS). Revision Changes Path 1.2 +1 -1; commitid: aeb648173bc741a7; xorp/contrib/olsr/test_routing1.py From bms at incunabulum.net Tue Apr 29 08:31:07 2008 From: bms at incunabulum.net (Bruce M Simpson) Date: Tue, 29 Apr 2008 16:31:07 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr In-Reply-To: <200804291517.m3TFHAJf044749@chum.icir.org> References: <200804291517.m3TFHAJf044749@chum.icir.org> Message-ID: <48173F3B.2070806@incunabulum.net> Pavlin Radoslavov wrote: > Log message: > Forced commit, because now the execution bit of this file is enabled > (inside CVS). > Thanks for the catch. From kristian at spritelink.net Tue Apr 29 11:09:58 2008 From: kristian at spritelink.net (Kristian Larsson) Date: Tue, 29 Apr 2008 20:09:58 +0200 Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes In-Reply-To: <200804290153.m3T1riPj039129@chum.icir.org> References: <200804290153.m3T1riPj039129@chum.icir.org> Message-ID: <20080429180958.GA60664@spritelink.se> On Tue, Apr 29, 2008 at 01:53:44AM +0000, Pavlin Radoslavov wrote: > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: pavlin at chum.icir.org 2008-04-29 01:53:44 UTC > > XORP CVS repository > > > Modified files: > devnotes update_cvsroot.sh > > Log message: > Replaced "echo -n" with "echo", because the former doesn't > work as expected on MacOS X 10.2 with the following /bin/sh > version: > > GNU bash, version 3.2.17(1)-release (i386-apple-darwin9.0) > > Interestingly, the corresponding /bin/bash is fine: > > user at host[3] sh > sh-3.2$ echo -n FOO > -n FOO <------ WRONG > sh-3.2$ exit > > user at host[4] bash > bash-3.2$ echo -n FOO > FOObash-3.2$ <------- OK I don't have my MacBook in front of me right now, but could this possible be bash builtin echo vs /bin/echo or equivalent ? Kristian. -- Kristian Larsson KLL-RIPE Network Engineer & Peering Coordinator SpriteLink [AS39525] +46 704 910401 kll at spritelink.net From pavlin at ICSI.Berkeley.EDU Tue Apr 29 12:02:03 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 29 Apr 2008 12:02:03 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes In-Reply-To: <20080429180958.GA60664@spritelink.se> References: <200804290153.m3T1riPj039129@chum.icir.org> <20080429180958.GA60664@spritelink.se> Message-ID: <200804291902.m3TJ23hI018178@fruitcake.ICSI.Berkeley.EDU> Kristian Larsson wrote: > On Tue, Apr 29, 2008 at 01:53:44AM +0000, Pavlin Radoslavov wrote: > > CVSROOT: /usr/local/www/data/cvs > > Module name: xorp > > Changes by: pavlin at chum.icir.org 2008-04-29 01:53:44 UTC > > > > XORP CVS repository > > > > > > Modified files: > > devnotes update_cvsroot.sh > > > > Log message: > > Replaced "echo -n" with "echo", because the former doesn't > > work as expected on MacOS X 10.2 with the following /bin/sh > > version: > > > > GNU bash, version 3.2.17(1)-release (i386-apple-darwin9.0) > > > > Interestingly, the corresponding /bin/bash is fine: > > > > user at host[3] sh > > sh-3.2$ echo -n FOO > > -n FOO <------ WRONG > > sh-3.2$ exit > > > > user at host[4] bash > > bash-3.2$ echo -n FOO > > FOObash-3.2$ <------- OK > > I don't have my MacBook in front of me right now, > but could this possible be bash builtin echo vs > /bin/echo or equivalent ? > Good point! It looks like the builtin echo in /bin/sh is the one with the problem: user at host[70] /bin/sh sh-3.2$ /bin/echo -n FOO FOOsh-3.2$ echo -n FOO -n FOO sh-3.2$ Though, according to the FreeBSD echo(1) manual page, printf(1) instead of "echo -n" should be used for maximum portability, so I am inclined to just use "echo" instead of "/bin/echo -n" or printf(1). Thanks, Pavlin > Kristian. > > -- > Kristian Larsson KLL-RIPE > Network Engineer & Peering Coordinator SpriteLink [AS39525] > +46 704 910401 kll at spritelink.net > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin at ICSI.Berkeley.EDU Tue Apr 29 12:07:04 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Tue, 29 Apr 2008 12:07:04 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp/devnotes In-Reply-To: <200804291902.m3TJ23hI018178@fruitcake.ICSI.Berkeley.EDU> References: <200804290153.m3T1riPj039129@chum.icir.org> <20080429180958.GA60664@spritelink.se> <200804291902.m3TJ23hI018178@fruitcake.ICSI.Berkeley.EDU> Message-ID: <200804291907.m3TJ74Pj019333@fruitcake.ICSI.Berkeley.EDU> Pavlin Radoslavov wrote: > Kristian Larsson wrote: > > > On Tue, Apr 29, 2008 at 01:53:44AM +0000, Pavlin Radoslavov wrote: > > > CVSROOT: /usr/local/www/data/cvs > > > Module name: xorp > > > Changes by: pavlin at chum.icir.org 2008-04-29 01:53:44 UTC > > > > > > XORP CVS repository > > > > > > > > > Modified files: > > > devnotes update_cvsroot.sh > > > > > > Log message: > > > Replaced "echo -n" with "echo", because the former doesn't > > > work as expected on MacOS X 10.2 with the following /bin/sh > > > version: > > > > > > GNU bash, version 3.2.17(1)-release (i386-apple-darwin9.0) > > > > > > Interestingly, the corresponding /bin/bash is fine: > > > > > > user at host[3] sh > > > sh-3.2$ echo -n FOO > > > -n FOO <------ WRONG > > > sh-3.2$ exit > > > > > > user at host[4] bash > > > bash-3.2$ echo -n FOO > > > FOObash-3.2$ <------- OK > > > > I don't have my MacBook in front of me right now, > > but could this possible be bash builtin echo vs > > /bin/echo or equivalent ? > > > > Good point! > > It looks like the builtin echo in /bin/sh is the one with the > problem: > > user at host[70] /bin/sh > sh-3.2$ /bin/echo -n FOO > FOOsh-3.2$ echo -n FOO > -n FOO > sh-3.2$ > > Though, according to the FreeBSD echo(1) manual page, printf(1) > instead of "echo -n" should be used for maximum portability, > so I am inclined to just use "echo" instead of "/bin/echo -n" > or printf(1). A clarification: after some testings it appears that in the particular script the newline suppression is not important, hence "echo" (no arguments) itself will do the job. Pavlin > Thanks, > Pavlin > > > Kristian. > > > > -- > > Kristian Larsson KLL-RIPE > > Network Engineer & Peering Coordinator SpriteLink [AS39525] > > +46 704 910401 kll at spritelink.net > > > > _______________________________________________ > > Xorp-cvs mailing list > > Xorp-cvs at icir.org > > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From pavlin at icir.org Wed Apr 30 12:31:36 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 30 Apr 2008 19:31:36 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200804301931.m3UJVae0065464@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-30 19:31:36 UTC XORP CVS repository Modified files: . bootstrap Log message: * Cleanup aclocal.m4 auto-generated files at the end of the script. Those files are needed only for the generation of "configure". * Minor refactroring in the cleanup code at the beginning of the script Revision Changes Path 1.31 +14 -9; commitid: ff814818c8a241a7; xorp/bootstrap From bms at icir.org Wed Apr 30 13:53:38 2008 From: bms at icir.org (Bruce Simpson) Date: Wed, 30 Apr 2008 20:53:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/fea xorp/xrl/targets Message-ID: <200804302053.m3UKrcm7066131@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-30 20:53:38 UTC XORP CVS repository Modified files: . configure fea Jamfile Makefile.am Makefile.in xrl/targets Jamfile Makefile.am Makefile.in Added files: fea test_fea_rawlink.cc test_fea_rawlink.sh Log message: Add a regression test for link layer access. The test is enabled only for FreeBSD and Linux hosts. In FreeBSD, the edsc(4) driver is used, and the test must be run as root to instantiate an instance as it's a cloneable interface. In Linux, the lo(4) driver may be used for link-layer loopback. Regen bootstrap. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=508 Revision Changes Path 1.282 +1 -1; commitid: 1020a4818dbd241a7; xorp/configure 1.27 +17 -1; commitid: 1020a4818dbd241a7; xorp/fea/Jamfile 1.106 +18 -1; commitid: 1020a4818dbd241a7; xorp/fea/Makefile.am 1.127 +38 -5; commitid: 1020a4818dbd241a7; xorp/fea/Makefile.in 1.1 +815 -0 xorp/fea/test_fea_rawlink.cc (new) 1.1 +132 -0 xorp/fea/test_fea_rawlink.sh (new) 1.7 +4 -1; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Jamfile 1.72 +10 -1; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Makefile.am 1.94 +21 -4; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Makefile.in From pavlin at icir.org Wed Apr 30 14:04:07 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 30 Apr 2008 21:04:07 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804302104.m3UL47PG066317@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-30 21:04:07 UTC XORP CVS repository Modified files: fea .cvsignore Log message: Added binary file test_fea_rawlink to the list of files ignored by CVS. Revision Changes Path 1.10 +1 -0; commitid: 102f64818deb641a7; xorp/fea/.cvsignore From pavlin at ICSI.Berkeley.EDU Wed Apr 30 14:06:57 2008 From: pavlin at ICSI.Berkeley.EDU (Pavlin Radoslavov) Date: Wed, 30 Apr 2008 14:06:57 -0700 Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/fea xorp/xrl/targets In-Reply-To: <200804302053.m3UKrcm7066131@chum.icir.org> References: <200804302053.m3UKrcm7066131@chum.icir.org> Message-ID: <200804302106.m3UL6wdR002574@fruitcake.ICSI.Berkeley.EDU> Bruce Simpson wrote: > CVSROOT: /usr/local/www/data/cvs > Module name: xorp > Changes by: bms at chum.icir.org 2008-04-30 20:53:38 UTC > > XORP CVS repository > > > Modified files: > . configure > fea Jamfile Makefile.am Makefile.in > xrl/targets Jamfile Makefile.am Makefile.in > > Added files: > fea test_fea_rawlink.cc test_fea_rawlink.sh > > Log message: > Add a regression test for link layer access. > > The test is enabled only for FreeBSD and Linux hosts. In FreeBSD, > the edsc(4) driver is used, and the test must be run as root > to instantiate an instance as it's a cloneable interface. In Linux, > the lo(4) driver may be used for link-layer loopback. > > Regen bootstrap. > > Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=508 It looks like file xrl/target/test_fea_rawlink.tgt (and the corresponding auto-generated *.cc and *.hh) is missing so please commit it as well. Thanks, Pavlin > Revision Changes Path > 1.282 +1 -1; commitid: 1020a4818dbd241a7; xorp/configure > 1.27 +17 -1; commitid: 1020a4818dbd241a7; xorp/fea/Jamfile > 1.106 +18 -1; commitid: 1020a4818dbd241a7; xorp/fea/Makefile.am > 1.127 +38 -5; commitid: 1020a4818dbd241a7; xorp/fea/Makefile.in > 1.1 +815 -0 xorp/fea/test_fea_rawlink.cc (new) > 1.1 +132 -0 xorp/fea/test_fea_rawlink.sh (new) > 1.7 +4 -1; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Jamfile > 1.72 +10 -1; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Makefile.am > 1.94 +21 -4; commitid: 1020a4818dbd241a7; xorp/xrl/targets/Makefile.in > > _______________________________________________ > Xorp-cvs mailing list > Xorp-cvs at icir.org > http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs From bms at icir.org Wed Apr 30 14:09:38 2008 From: bms at icir.org (Bruce Simpson) Date: Wed, 30 Apr 2008 21:09:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/xrl/targets Message-ID: <200804302109.m3UL9cEo066415@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-04-30 21:09:38 UTC XORP CVS repository Added files: xrl/targets test_fea_rawlink.tgt test_fea_rawlink.xrls test_fea_rawlink_base.cc test_fea_rawlink_base.hh Log message: Add XRL target files for test_fea_rawlink. Bug found by: Pavlin Radoslavov Revision Changes Path 1.1 +5 -0 xorp/xrl/targets/test_fea_rawlink.tgt (new) 1.1 +49 -0 xorp/xrl/targets/test_fea_rawlink.xrls (new) 1.1 +250 -0 xorp/xrl/targets/test_fea_rawlink_base.cc (new) 1.1 +144 -0 xorp/xrl/targets/test_fea_rawlink_base.hh (new) From bms at icir.org Wed Apr 30 14:12:21 2008 From: bms at icir.org (Bruce M. Simpson) Date: Wed, 30 Apr 2008 22:12:21 +0100 Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/fea xorp/xrl/targets In-Reply-To: <200804302106.m3UL6wdR002574@fruitcake.ICSI.Berkeley.EDU> References: <200804302053.m3UKrcm7066131@chum.icir.org> <200804302106.m3UL6wdR002574@fruitcake.ICSI.Berkeley.EDU> Message-ID: <4818E0B5.1000604@icir.org> Pavlin Radoslavov wrote: > It looks like file xrl/target/test_fea_rawlink.tgt (and the > corresponding auto-generated *.cc and *.hh) is missing so > please commit it as well. > Thanks. I was trying to get this killed off quickly so I did it in an Hg branch w/o checking it in, and it looks like I forgot to "hg add" those files to the pending changes. FWIW the auto-generated stuff gets the correct dependency graph treatment in the Boost.BuildV2 fork. In Jam it still has to be referenced from the xrl/targets directory. From pavlin at icir.org Wed Apr 30 14:19:01 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 30 Apr 2008 21:19:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200804302119.m3ULJ12P066608@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-04-30 21:19:01 UTC XORP CVS repository Modified files: fea test_fea_rawlink.sh Log message: Forced commit to fix the file execution bit setup. Revision Changes Path 1.2 +1 -1; commitid: 104004818e1ce41a7; xorp/fea/test_fea_rawlink.sh From atanu at icir.org Wed Apr 30 18:10:08 2008 From: atanu at icir.org (Atanu Ghosh) Date: Thu, 1 May 2008 01:10:08 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/contrib/olsr Message-ID: <200805010110.m411A8iU069017@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-05-01 01:10:08 UTC XORP CVS repository Modified files: contrib/olsr topology.cc xrl_io.cc Log message: Fix some issues that cropped up when compiling with: -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC Revision Changes Path 1.2 +3 -5; commitid: 10d7e4819186f41a7; xorp/contrib/olsr/topology.cc 1.2 +1 -2; commitid: 10d7e4819186f41a7; xorp/contrib/olsr/xrl_io.cc From pavlin at icir.org Wed Apr 30 20:10:42 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Thu, 1 May 2008 03:10:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200805010310.m413Agmj070198@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-05-01 03:10:42 UTC XORP CVS repository Modified files: fea test_fea_rawlink.sh Log message: The test must be run as root on Linux, so