[Xorp-cvs] XORP cvs commit: xorp/libxorp

[Pavlin Radoslavov]

Andrea Bittau <abittau at icir.org> wrote:

> CVSROOT:	/usr/local/www/data/cvs
> Module name:	xorp
> Changes by:	abittau at chum.icir.org	2008-07-01 21:45:08 UTC
> 
> XORP CVS repository
> 
> 
> Modified files:
> 	libxorp       test_run_command.cc 
> 
> Log message:
> 	Fix test on systems that have awk installed in /bin (e.g., Arch Linux).  A
> 	proper fix would search for awk based on $PATH, rather than just attempting
> 	/usr/bin and /bin.
> 	
> 	I haven't included headers nominally required by stat() in order to avoid
> 	breaking compilation across platforms.  I believe that autoconf / other headers
> 	deal with this and indeed it works on my Linux system without explicit includes.

On FreeBSD-7.0 stat(2) requires <sys/types.h> and <sys/stat.h> .
Both files are already included conditionally by libxorp/xorp.h so
this shouldn't be an issue. If there are compilation issues on other
OS-es, those should be caught by the tinderbox.

Pavlin

> Revision  Changes                               Path
> 1.20      +11 -3;  commitid: 641d486aa45941a7;  xorp/libxorp/test_run_command.cc
> 
> _______________________________________________
> Xorp-cvs mailing list
> Xorp-cvs at icir.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs