[Xorp-cvs] XORP cvs commit: xorp xorp/cli xorp/libxorp xorp/rtrmgr

[Pavlin Radoslavov]

> > > With this change the router manager can now be configured to use syslog,
> > > what about the XORP processes that the router manager starts? Each XORP
> > > process individually initialises the logging facility. In the current
> > > scheme any output generated by a child process will not be subject to
> > > syslog. We need a mechanism to tell all the child processes to use
> > > syslog if the router manager has been configured to use syslog.
> > > 
> > > 	Atanu.
> > 
> > I believe the stdout/stderr XLOG output for each child process is
> > intercepted by the parent rtrmgr process and then printed by the
> > rtrmgr itself. Hence the output from the child processes will end up
> > in syslog (via the rtrmgr), but obviously this needs to be verified
> > in practice.
> > 
> > Pavlin
> 
> In which case isn't the type (INFO,FATAL...) information lost?

Correct.

Now that I looked into the rtrmgr code itself, what I said above
about the child output going to syslog is not correct, because the
rtrmgr actually uses fprintf(stdout, ...) and fprintf(stderr, ...)
to print the child process output as-is (see methods
ModuleManager::Process::stdout_cb() and
ModuleManager::Process::stderr_cb() inside rtrmgr/module_manager.cc).

So yes, we need a mechanism for the rtrmgr to pass the syslog config
to the child processes.

Pavlin