[Xorp-cvs] XORP cvs commit: xorp/ospf

[Atanu Ghosh]

CVSROOT:	/usr/local/www/data/cvs
Module name:	xorp
Changes by:	atanu at chum.icir.org	2008-03-19 22:42:10 UTC

XORP CVS repository


Modified files:
	ospf          area_router.cc lsa.hh 

Log message:
	When a LSA is removed from the database the timer associated with it
	should be stopped.
	
	In the past whenever a LSA was removed from the database it would also
	be invalidated which would cause the timer to be stopped. It is now
	possible to remove an LSA from the database and not have to invalidate
	it, which means that the timer may not be stopped. It is possible for
	a LSA to be removed from the database and the timer to still be
	running, when the timer fires a sanity check in the timer code
	verifies that the LSA is still in the database (at the same index). It
	has been reported that this verification is failing.
	
	The new code now unconditionally calls invalidate which unconditionally stops
	the timer, which fixes an obvious problem.
	
	I have not been able to reproduce problem.
	
	Bugzilla URL:   http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=737
	Bug found by:   Ben Greear <greearb AT candelatech.com>

Revision  Changes                              Path
1.296     +3 -3;  commitid: ed9647e196bc41a7;  xorp/ospf/area_router.cc
1.111     +8 -3;  commitid: ed9647e196bc41a7;  xorp/ospf/lsa.hh