From pavlin at icir.org Sat Nov 1 22:15:02 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 2 Nov 2008 05:15:02 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811020515.mA25F2kr067861@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-02 05:15:02 UTC XORP CVS repository Modified files: libxorp eventloop.cc eventloop.hh selector.cc selector.hh Log message: Added methods set_debug() and is_debug() to the EventLoop and Selector classes. Those methods can be used to set/reset a run-time flag to indicate run-time debugging. Currently the methods are unused; the debug statements that use those flags will be added in the future. Revision Changes Path 1.48 +2 -2; commitid: 108c6490d354241a7; xorp/libxorp/eventloop.cc 1.39 +5 -1; commitid: 108c6490d354241a7; xorp/libxorp/eventloop.hh 1.53 +3 -2; commitid: 108c6490d354241a7; xorp/libxorp/selector.cc 1.35 +5 -1; commitid: 108c6490d354241a7; xorp/libxorp/selector.hh From pavlin at icir.org Sat Nov 1 22:17:33 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 2 Nov 2008 05:17:33 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811020517.mA25HXhB067929@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-02 05:17:33 UTC XORP CVS repository Modified files: libxorp buffered_asyncio.cc buffered_asyncio.hh Log message: Added eventloop task priority to the BufferedAsyncReader, with default value of XorpTask::PRIORITY_DEFAULT. Revision Changes Path 1.17 +10 -6; commitid: 10940490d37c341a7; xorp/libxorp/buffered_asyncio.cc 1.11 +5 -2; commitid: 10940490d37c341a7; xorp/libxorp/buffered_asyncio.hh From atanu at icir.org Sun Nov 2 10:35:58 2008 From: atanu at icir.org (Atanu Ghosh) Date: Sun, 2 Nov 2008 18:35:58 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200811021835.mA2IZw7k074027@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-02 18:35:58 UTC XORP CVS repository Modified files: libxipc xrl.cc xrl.hh xrl_router.cc xrl_router.hh Log message: A problem was introduced in the performance enhancements: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=808 A pointer was held in an Xrl to a FinderDBEntry the entry contains the resolved Xrl. The FinderDBEntry is held in a map so it is not valid to hold a pointer to it, as any changes to the map could cause the invalidate the pointer. Another problem was that if the target of the Xrl died then the cached FinderDBEntry would not be uncached. A solution to the problem may be to hold the FinderDBEntry as a pointer in the map so that updates would not move the pointer. Another solution is to hold a pointer to the resolved Xrl in the unresolved Xrl and not have the intermediate FinderDBEntry. The FinderDBEntry holds a list of resolved Xrls, it is not clear why it is a list and not a single entry as they all resolve the same target, unless it is a list to hold multiple request responses, in which case the list shouldn't be exposed outside the FinderClient. The code has been reverted to not caching the FinderDBEntry but the XrlPFSender is now being cached in the Xrl and resolved is now a bool not a FinderDBEntry. There will be a slight drop in performance doing the FinderDBEntry each time but this is not the correct pointer to hold. The FinderClient needs to be reworked to return an Xrl pointer that can be safely stored. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=800 Revision Changes Path 1.31 +5 -3; commitid: 1210c490df30d41a7; xorp/libxipc/xrl.cc 1.33 +14 -10; commitid: 1210c490df30d41a7; xorp/libxipc/xrl.hh 1.70 +33 -16; commitid: 1210c490df30d41a7; xorp/libxipc/xrl_router.cc 1.49 +2 -2; commitid: 1210c490df30d41a7; xorp/libxipc/xrl_router.hh From pavlin at icir.org Sun Nov 2 12:14:59 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 2 Nov 2008 20:14:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200811022014.mA2KExJ5074961@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-02 20:14:59 UTC XORP CVS repository Modified files: bgp/harness test_peer.cc Log message: Set the priority for the peer file descriptors to XorpTask::PRIORITY_LOWEST, so high volume data from BGP is served after the data received on XRL file descriptors. Otherwise, the BGP data could starve the processing of the XRL file descriptors. This fixes the XRL keepalive timeout problem in Bugzilla entry #800, but exposes another issue: now the periodic hello XRLs from the Finder are not processed. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=800 Approved by: Atanu Ghosh Revision Changes Path 1.54 +10 -7; commitid: 124a8490e092541a7; xorp/bgp/harness/test_peer.cc From pavlin at icir.org Sun Nov 2 12:38:09 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 2 Nov 2008 20:38:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811022038.mA2Kc9vs075158@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-02 20:38:09 UTC XORP CVS repository Modified files: libxorp selector.cc Log message: Serious bug fix in the storage of the selector masks inside SelectorList::Node::add_okay(). There are arrays like _priority[SEL_MAX_IDX], _cb[SEL_MAX_IDX], _iot[SEL_MAX_IDX] and _mask[SEL_MAX_IDX] which are used for storing event registration information per file descriptor: priority, callback, I/O event type, and SelectorMask. In some parts of the Selector code there is the assumption that array index SEL_RD_IDX is used for storing information related to READ I/O registration, SEL_WR_IDX is used for storing information related to WRITE I/O, and so on. However, inside SelectorList::Node::add_okay() Step 2, the original code selected the first _empty_ bin to store the information which seems inconsistent with the above-mentioned assumption. After the fix, READ I/O registration goes into [SEL_RD_IDX], WRITE I/O registration goes into [SEL_WR_IDX], and so on. The rest of the Selector code is not modified: it still looks for various masks in all array bins which is sub-optimal. A side note: internally, we don't need the concept of SelectorMask, because outside of the EventLoop we can register only for a particular event type: IOT_READ, IOT_WRITE, etc. The only exception is IOT_ANY, and that one is used only when remove_ioevent_cb() is called to remove all callbacks for a file descriptor. If SelectorMask is removed, this will simplify the implementation, and will speed-up the eventloop processing. This fixes the remaining issue in Bugzilla entry #800 Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=800 Approved by: Atanu Ghosh Revision Changes Path 1.54 +30 -13; commitid: 12503490e0b6241a7; xorp/libxorp/selector.cc From atanu at icir.org Sun Nov 2 20:39:49 2008 From: atanu at icir.org (Atanu Ghosh) Date: Mon, 3 Nov 2008 04:39:49 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200811030439.mA34dncu078624@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-03 04:39:49 UTC XORP CVS repository Modified files: libxipc test_finder_events.cc Log message: As noted by Bruce and Pavlin this test has been failing for two reasons one the burst size of 50 is too high and secondly the scheduling code in drip_run did not correctly cater for slow systems. The failure in the test was not a problem with the finder subsystem but a problem with the tests. The tests are now totally event driven, previously they were a mix of event and timer driven and on a slow system the timer code broke the tests. The burst size has been reduced to 25. Now the tests are totally event driven to protect against a missing event a watchdog of 1 minute is started to guard against missing event. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=799 Revision Changes Path 1.31 +50 -42; commitid: 13307490e809441a7; xorp/libxipc/test_finder_events.cc From abittau at icir.org Mon Nov 3 00:31:57 2008 From: abittau at icir.org (Andrea Bittau) Date: Mon, 3 Nov 2008 08:31:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200811030831.mA38Vv3U080455@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-03 08:31:57 UTC XORP CVS repository Modified files: policy filter_manager.cc Log message: Fix bug 793. This actually fixes another bug which indirectly fixes 793. When a process is born, we reconfigure its filters and then push routes. Before, the logic would not push routes to avoid extra work (pushing is expensive) because the project just started so it has no routes. Well, there's no guarantee that the process doesn't aquire routes by the time the filters are actually configured. We therefore have to push routes anyway. Processes that want to avoid this extra work can wait, while booting up, for this push message which implicitly indicates that filter configuration has finished. BGP does this for example. Bug 793 existed becuase BGP would wait for this message that was never sent due to the policy manager "optimization" (aka. avoid push bug). In practice this bug is difficult to trigger because BGP always configures its filters (even with a "null" configuration) which will causse a route push. However if the policy manager received BGP's configuration prior to the notification of BGP's birth, the bug is triggered. Typically the events occur in reverse order (hence not causing the bug), but this is purely based on scheduling. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=793 Revision Changes Path 1.23 +8 -4; commitid: 13a2d490eb6a241a7; xorp/policy/filter_manager.cc From bms at incunabulum.net Mon Nov 3 01:47:23 2008 From: bms at incunabulum.net (Bruce M Simpson) Date: Mon, 03 Nov 2008 09:47:23 +0000 Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp In-Reply-To: <200811022038.mA2Kc9vs075158@chum.icir.org> References: <200811022038.mA2Kc9vs075158@chum.icir.org> Message-ID: <490EC8AB.5010707@incunabulum.net> Pavlin Radoslavov wrote: > However, inside SelectorList::Node::add_okay() Step 2, the original > code selected the first _empty_ bin to store the information which > seems inconsistent with the above-mentioned assumption. > This issue was exposed in my testing for bug 799 on Friday, as you probably saw. The code was using an invalid SEL_XX_IDX of -1 in some situations. > > After the fix, READ I/O registration goes into [SEL_RD_IDX], > WRITE I/O registration goes into [SEL_WR_IDX], and so on. > The rest of the Selector code is not modified: it still looks > for various masks in all array bins which is sub-optimal. > > A side note: internally, we don't need the concept of > SelectorMask, because outside of the EventLoop we can > register only for a particular event type: IOT_READ, IOT_WRITE, etc. > The only exception is IOT_ANY, and that one is used only > when remove_ioevent_cb() is called to remove all callbacks for > a file descriptor. > If SelectorMask is removed, this will simplify the implementation, > and will speed-up the eventloop processing. > Yes, that can probably go... One of the goals for Windows refactoring was to avoid modifying the UNIX code path if at all possible. thanks BMS From pavlin at icir.org Mon Nov 3 18:12:31 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 4 Nov 2008 02:12:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200811040212.mA42CVTu088630@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-04 02:12:31 UTC XORP CVS repository Modified files: libxipc test_finder_events.cc Log message: Add an artificial delay of 3 seconds when running the tests. This fixes a problem with the test_finder_deaths.sh wrapper shell script which waits for 2 seconds before checking that the test actually started. On very fast machines, test_finder_events will finish in less than 2 seconds, and test_finder_deaths.sh failed to detect that. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=799 Submitted by: Bruce M. Simpson Approved by: Syed Khalid Revision Changes Path 1.32 +9 -1; commitid: 159ec490faed341a7; xorp/libxipc/test_finder_events.cc From bms at icir.org Tue Nov 4 04:58:41 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 4 Nov 2008 12:58:41 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811041258.mA4CwfFk093182@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-04 12:58:41 UTC XORP CVS repository Modified files: libxorp eventloop.hh Log message: Fix tinderbox breakage: In EventLoop::set_debug(), do not attempt to access _selector_list when HOST_OS_WINDOWS is defined, as it is not defined there. Revision Changes Path 1.40 +8 -2; commitid: 16be7491046fa41a7; xorp/libxorp/eventloop.hh From bms at icir.org Tue Nov 4 06:59:37 2008 From: bms at icir.org (Bruce Simpson) Date: Tue, 4 Nov 2008 14:59:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/windows_port Message-ID: <200811041459.mA4Exbog093951@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-04 14:59:37 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/docs/windows_port added to the repository From pavlin at icir.org Tue Nov 4 09:38:13 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Tue, 4 Nov 2008 17:38:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200811041738.mA4HcDsd095592@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-04 17:38:13 UTC XORP CVS repository Modified files: . BUILD_NOTES RELEASE_NOTES Log message: XORP now compiles and "gmake check" passes on Linux Ubuntu 8.10 and OpenBSD-4.4. Revision Changes Path 1.110 +23 -2; commitid: 1754f4910887341a7; xorp/BUILD_NOTES 1.220 +3 -2; commitid: 1754f4910887341a7; xorp/RELEASE_NOTES From atanu at icir.org Tue Nov 4 14:56:28 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 4 Nov 2008 22:56:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/cli xorp/libxorp xorp/rtrmgr Message-ID: <200811042256.mA4MuS8R097919@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-04 22:56:28 UTC XORP CVS repository Modified files: cli cli_node.cc cli_node_net.cc libxorp run_command.cc run_command.hh rtrmgr op_commands.cc Log message: The output from a show command had the same priority as keyboard input so a command that generates a lot of output like "show bgp routes" could stop the xorpsh from listening to keyboard input. The priority of Keyboard input has been increased and the priority of show commands has been decreased. Show commands are run by RunCommand and a constructor argument has been added to select the priority of the stdout and stdin. Bugzilla URL: http://bugzilla.xorp.org/show_bug.cgi?id=809 Submitted by: Pavlin Radoslavov Approved by: Syed Khalid Revision Changes Path 1.44 +3 -2; commitid: 17e3c4910d31a41a7; xorp/cli/cli_node.cc 1.70 +5 -3; commitid: 17e3c4910d31a41a7; xorp/cli/cli_node_net.cc 1.37 +15 -9; commitid: 17e3c4910d31a41a7; xorp/libxorp/run_command.cc 1.20 +20 -4; commitid: 17e3c4910d31a41a7; xorp/libxorp/run_command.hh 1.73 +3 -2; commitid: 17e3c4910d31a41a7; xorp/rtrmgr/op_commands.cc From atanu at icir.org Thu Nov 6 11:45:04 2008 From: atanu at icir.org (Atanu Ghosh) Date: Thu, 6 Nov 2008 19:45:04 GMT Subject: [Xorp-cvs] XORP cvs commit: CVSROOT Message-ID: <200811061945.mA6Jj4u9016986@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: CVSROOT Changes by: atanu at chum.icir.org 2008-11-06 19:45:04 UTC XORP CVS repository Modified files: . access.core Log message: Give the following commit rights: ravij jtc llu strinh Revision Changes Path 1.7 +5 -1; commitid: 42414913493e41a7; CVSROOT/access.core From strinh at icir.org Thu Nov 6 13:27:54 2008 From: strinh at icir.org (Susan Trinh) Date: Thu, 6 Nov 2008 21:27:54 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/etc/templates Message-ID: <200811062127.mA6LRsna017718@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: strinh at chum.icir.org 2008-11-06 21:27:54 UTC XORP CVS repository Modified files: . RELEASE_NOTES etc/templates rib.cmds Log message: Fix bug 812. In the CLI command to show the RIB administrative distance, we used 2 keywords: 'distance' and 'distances'. The RIB administrative distance keyword is now consolidated to just use 'distance'. The command to show RIB administrative distance is now just 'show route admin distance'. Also, I have updated the release notes, under the RIB heading to call out this change in the CLI. Revision Changes Path 1.221 +6 -2; commitid: 450c4913615941a7; xorp/RELEASE_NOTES 1.13 +5 -5; commitid: 450c4913615941a7; xorp/etc/templates/rib.cmds From pavlin at icir.org Thu Nov 6 14:04:26 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Thu, 6 Nov 2008 22:04:26 GMT Subject: [Xorp-cvs] XORP cvs commit: CVSROOT Message-ID: <200811062204.mA6M4QcK018074@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: CVSROOT Changes by: pavlin at chum.icir.org 2008-11-06 22:04:26 UTC XORP CVS repository Modified files: . access.core Log message: Corrected Lixin's email address Revision Changes Path 1.8 +2 -2; commitid: 4681491369b741a7; CVSROOT/access.core From strinh at icir.org Thu Nov 6 17:24:59 2008 From: strinh at icir.org (Susan Trinh) Date: Fri, 7 Nov 2008 01:24:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200811070124.mA71OxZC025836@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: strinh at chum.icir.org 2008-11-07 01:24:59 UTC XORP CVS repository Modified files: docs/user_manual unicast_routing.tex Log message: Fix for bug 812, user manual portion. Updated the user manual to include CLI commands to show the RIB administrative distances for IPv4/IPv6 and unicast/multicast combinations. Revision Changes Path 1.14 +37 -1; commitid: 64d5491398eb41a7; xorp/docs/user_manual/unicast_routing.tex From abittau at icir.org Fri Nov 7 13:44:50 2008 From: abittau at icir.org (Andrea Bittau) Date: Fri, 7 Nov 2008 21:44:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811072144.mA7LioHK036165@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-07 21:44:50 UTC XORP CVS repository Modified files: libxorp .cvsignore Jamfile Makefile.am Makefile.in Added files: libxorp test_sched.cc Log message: Add a program for testing the scheduler. For now it only has a simple file descriptor handling starvation test. It triggers bug 814. Revision Changes Path 1.16 +1 -0; commitid: 8d264914b6cf41a7; xorp/libxorp/.cvsignore 1.4 +2 -1; commitid: 8d264914b6cf41a7; xorp/libxorp/Jamfile 1.56 +8 -1; commitid: 8d264914b6cf41a7; xorp/libxorp/Makefile.am 1.77 +35 -19; commitid: 8d264914b6cf41a7; xorp/libxorp/Makefile.in 1.1 +303 -0 xorp/libxorp/test_sched.cc (new) From abittau at icir.org Fri Nov 7 13:48:42 2008 From: abittau at icir.org (Andrea Bittau) Date: Fri, 7 Nov 2008 21:48:42 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811072148.mA7LmgEC036220@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-07 21:48:42 UTC XORP CVS repository Modified files: libxorp test_sched.cc Log message: Create a new test (that fails): read and write from the same socket with same priority. Currently the scheduler runs only one operation (read) starving the other one (write). They scheduler should alternate between the two. Revision Changes Path 1.2 +194 -52; commitid: 8d654914b7b841a7; xorp/libxorp/test_sched.cc From abittau at icir.org Fri Nov 7 13:49:31 2008 From: abittau at icir.org (Andrea Bittau) Date: Fri, 7 Nov 2008 21:49:31 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811072149.mA7LnVgV036251@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-07 21:49:31 UTC XORP CVS repository Modified files: libxorp test_sched.cc Log message: Add a new test that fails. Have two low priority readers and introduce a high priority one every other round. I.e., this alternates reads between a low priority FD, and the high priority one (when it is introduced). Between them, the low priority FDs should get served round robin. Instead, they currently do not and they get starved. Revision Changes Path 1.3 +110 -12; commitid: 8d844914b7e941a7; xorp/libxorp/test_sched.cc From abittau at icir.org Fri Nov 7 13:49:50 2008 From: abittau at icir.org (Andrea Bittau) Date: Fri, 7 Nov 2008 21:49:50 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811072149.mA7Lnotv036282@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-07 21:49:50 UTC XORP CVS repository Modified files: libxorp test_sched.cc Log message: mark tests that fail and don't run them by default Revision Changes Path 1.4 +35 -5; commitid: 8da34914b7fc41a7; xorp/libxorp/test_sched.cc From abittau at icir.org Fri Nov 7 13:52:59 2008 From: abittau at icir.org (Andrea Bittau) Date: Fri, 7 Nov 2008 21:52:59 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811072152.mA7Lqxa7036381@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-07 21:52:59 UTC XORP CVS repository Modified files: libxorp selector.cc selector.hh Log message: (Mostly) fix bug 814. When serving file descriptors with the same priority, serve them round robin rather than favoring one and starving others. This fix keeps minimal state (last served FD) so there are still scenarios where FDs with the same priority can be starved. For example, a high priority FD can effectively "reset" the last served FD variable, so that when low priority descriptors are served again in the future, the process is restarted rather than resumed from the last served (low priority) FD, hence favoring the first FD selected. Patch provided by Pavlin. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=814 Revision Changes Path 1.55 +33 -6; commitid: 8e044914b89641a7; xorp/libxorp/selector.cc 1.36 +3 -1; commitid: 8e044914b89641a7; xorp/libxorp/selector.hh From abittau at icir.org Fri Nov 7 16:41:03 2008 From: abittau at icir.org (Andrea Bittau) Date: Sat, 8 Nov 2008 00:41:03 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811080041.mA80f39s037674@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-08 00:41:03 UTC XORP CVS repository Modified files: libxorp Makefile.am Makefile.in test_sched.cc Log message: don't make test_sched depend on libcomm so make check (without a prior build) works. The code of libcomm is included in test_sched. Revision Changes Path 1.57 +1 -5; commitid: 930f4914dff741a7; xorp/libxorp/Makefile.am 1.78 +2 -6; commitid: 930f4914dff741a7; xorp/libxorp/Makefile.in 1.5 +15 -7; commitid: 930f4914dff741a7; xorp/libxorp/test_sched.cc From atanu at icir.org Fri Nov 7 16:46:45 2008 From: atanu at icir.org (Atanu Ghosh) Date: Sat, 8 Nov 2008 00:46:45 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811080046.mA80kjAj037748@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-08 00:46:45 UTC XORP CVS repository Modified files: bgp socket.cc Log message: If a user takes a peering down the socket disconnect code can be re-entered causing an XLOG_ASSERT. A comment already in the code describes this possible situation and suggests it is safe to just return in the case of the problem being seen. The code now returns when re-entered rather than asserting. Bug found by: Mark Handley Approved by: Syed Khalid Revision Changes Path 1.58 +4 -2; commitid: 935b4914e17441a7; xorp/bgp/socket.cc From atanu at icir.org Fri Nov 7 21:31:25 2008 From: atanu at icir.org (Atanu Ghosh) Date: Sat, 8 Nov 2008 05:31:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxorp Message-ID: <200811080531.mA85VPej040535@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-08 05:31:25 UTC XORP CVS repository Modified files: libxorp eventloop.cc eventloop.hh Log message: Don't let selector events starve each task events. When a selector and task event have the same priority try and alternate between the selector and the task. This should alleviate BGP scheduling issues. Reviewed by: Mark Handley Revision Changes Path 1.49 +30 -4; commitid: 9e3c4915242d41a7; xorp/libxorp/eventloop.cc 1.41 +3 -1; commitid: 9e3c4915242d41a7; xorp/libxorp/eventloop.hh From mjh at icir.org Fri Nov 7 22:15:13 2008 From: mjh at icir.org (Mark Handley) Date: Sat, 8 Nov 2008 06:15:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/bgp xorp/bgp/harness xorp/bgp/tools xorp/cli xorp/cli/tools xorp/contrib xorp/contrib/mld6igmp_lite xorp/contrib/olsr xorp/contrib/olsr/tools xorp/docs xorp/docs/bgp xorp/docs/design_arch xorp/docs/fea xorp/docs/libxipc ... Message-ID: <200811080615.mA86FDXT042589@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: mjh at chum.icir.org 2008-11-08 06:15:13 UTC XORP CVS repository Modified files: . Makefile.in MakefileRootCheck.in configure bgp Makefile.am Makefile.in TODO attribute_manager.cc attribute_manager.hh bgp.cc bgp.hh bgp_trie.cc bgp_trie.hh bgp_varrw.cc bgp_varrw.hh bgp_varrw_export.cc bgp_varrw_export.hh exceptions.hh internal_message.cc internal_message.hh packet.hh path_attribute.cc path_attribute.hh peer.cc peer.hh peer_data.hh peer_handler.cc peer_handler.hh peer_handler_debug.cc peer_handler_debug.hh plumbing.cc plumbing.hh rib_ipc_handler.cc rib_ipc_handler.hh route_queue.hh route_table_aggregation.cc route_table_aggregation.hh route_table_base.cc route_table_base.hh route_table_cache.cc route_table_cache.hh route_table_damping.cc route_table_damping.hh route_table_debug.cc route_table_debug.hh route_table_decision.cc route_table_decision.hh route_table_deletion.cc route_table_deletion.hh route_table_dump.cc route_table_dump.hh route_table_fanout.cc route_table_fanout.hh route_table_filter.cc route_table_filter.hh route_table_nhlookup.cc route_table_nhlookup.hh route_table_policy.cc route_table_policy.hh route_table_policy_ex.cc route_table_policy_im.cc route_table_policy_im.hh route_table_ribin.cc route_table_ribin.hh route_table_ribout.cc route_table_ribout.hh socket.cc subnet_route.cc subnet_route.hh test_cache.cc test_cache.reference test_decision.cc test_decision.reference test_deletion.cc test_dump.cc test_dump.reference test_fanout.cc test_filter.cc test_main.cc test_nhlookup.cc test_packet.cc test_packet_coding.cc test_plumbing.cc test_plumbing.hh test_policy.cc test_policy_dump.reference test_ribin.cc test_ribout.cc test_subnet_route.cc update_packet.cc update_test.cc bgp/harness Makefile.am Makefile.in bgppp.cc lookup.py peer.cc test_path_attribute1.sh test_path_attribute2.sh test_peer.cc test_peering1.sh test_peering2.sh test_route_reflection1.sh test_routing1.sh test_trie.cc trie.cc trie_payload.hh bgp/tools Makefile.in cli Makefile.in cli/tools Makefile.in contrib Makefile.in contrib/mld6igmp_lite Makefile.in contrib/olsr Makefile.in contrib/olsr/tools Makefile.in docs Makefile.in docs/bgp Makefile.in docs/design_arch Makefile.in docs/fea Makefile.in docs/libxipc Makefile.in docs/libxorp Makefile.in docs/mfea Makefile.in docs/mld6igmp Makefile.in docs/multicast Makefile.in docs/olsr Makefile.in docs/pim Makefile.in docs/pim_testsuite Makefile.in docs/rib Makefile.in docs/rtrmgr Makefile.in docs/slides Makefile.in docs/slides/status_2004_02 Makefile.in docs/snmp Makefile.in docs/test_harness Makefile.in docs/user_manual Makefile.in docs/xorpdev_101 Makefile.in etc Makefile.in etc/templates Makefile.in fea Makefile.in MakefileRootCheck.in fea/data_plane Makefile.in fea/data_plane/control_socket Makefile.in fea/data_plane/fibconfig Makefile.in fea/data_plane/firewall Makefile.in fea/data_plane/ifconfig Makefile.in fea/data_plane/io Makefile.in fea/data_plane/managers Makefile.in fea/tools Makefile.in fib2mrib Makefile.in libcomm Makefile.in libfeaclient Makefile.in libproto Makefile.in libxipc Makefile.in libxorp Makefile.in mibs Makefile.in configure mibs/snmpdscripts Makefile.in mibs/tests Makefile.in mld6igmp Makefile.in mrt Makefile.in ospf Makefile.in ospf/tools Makefile.in pim Makefile.in policy Makefile.in policy/backend Makefile.in policy/common Makefile.in policy/test Makefile.am Makefile.in policybench.cc rib Makefile.in rib/tools Makefile.in rip Makefile.in rip/tools Makefile.in rtrmgr Makefile.in rtrmgr/config Makefile.in static_routes Makefile.in utils Makefile.in vrrp Makefile.in vrrp/test Makefile.in xrl Makefile.in xrl/interfaces Makefile.in xrl/targets Makefile.in xrl/tests Makefile.in Log message: Rewrite classes dealing with Path Attribute Lists. First stage of re-writes to improve performance by doing fewer copies and use less memory. Approved by: John Tavs Revision Changes Path 1.60 +64 -68; commitid: a00249152da441a7; xorp/Makefile.in 1.20 +64 -68; commitid: a00249152da441a7; xorp/MakefileRootCheck.in 1.48 +2 -2; commitid: a00249152da441a7; xorp/bgp/Makefile.am 1.72 +96 -100; commitid: a00249152da441a7; xorp/bgp/Makefile.in 1.21 +17 -3; commitid: a00249152da441a7; xorp/bgp/TODO 1.18 +28 -29; commitid: a00249152da441a7; xorp/bgp/attribute_manager.cc 1.12 +12 -8; commitid: a00249152da441a7; xorp/bgp/attribute_manager.hh 1.95 +11 -1; commitid: a00249152da441a7; xorp/bgp/bgp.cc 1.73 +13 -12; commitid: a00249152da441a7; xorp/bgp/bgp.hh 1.26 +4 -9; commitid: a00249152da441a7; xorp/bgp/bgp_trie.cc 1.22 +14 -7; commitid: a00249152da441a7; xorp/bgp/bgp_trie.hh 1.39 +59 -114; commitid: a00249152da441a7; xorp/bgp/bgp_varrw.cc 1.26 +15 -6; commitid: a00249152da441a7; xorp/bgp/bgp_varrw.hh 1.10 +9 -14; commitid: a00249152da441a7; xorp/bgp/bgp_varrw_export.cc 1.8 +9 -14; commitid: a00249152da441a7; xorp/bgp/bgp_varrw_export.hh 1.16 +23 -6; commitid: a00249152da441a7; xorp/bgp/exceptions.hh 1.23 +31 -6; commitid: a00249152da441a7; xorp/bgp/harness/Makefile.am 1.50 +143 -93; commitid: a00249152da441a7; xorp/bgp/harness/Makefile.in 1.19 +3 -2; commitid: a00249152da441a7; xorp/bgp/harness/bgppp.cc 1.4 +2 -2; commitid: a00249152da441a7; xorp/bgp/harness/lookup.py 1.90 +27 -13; commitid: a00249152da441a7; xorp/bgp/harness/peer.cc 1.12 +22 -9; commitid: a00249152da441a7; xorp/bgp/harness/test_path_attribute1.sh 1.2 +2 -2; commitid: a00249152da441a7; xorp/bgp/harness/test_path_attribute2.sh 1.55 +4 -1; commitid: a00249152da441a7; xorp/bgp/harness/test_peer.cc 1.67 +12 -6; commitid: a00249152da441a7; xorp/bgp/harness/test_peering1.sh 1.65 +3 -1; commitid: a00249152da441a7; xorp/bgp/harness/test_peering2.sh 1.8 +8 -7; commitid: a00249152da441a7; xorp/bgp/harness/test_route_reflection1.sh 1.27 +2 -1; commitid: a00249152da441a7; xorp/bgp/harness/test_routing1.sh 1.29 +31 -2; commitid: a00249152da441a7; xorp/bgp/harness/test_trie.cc 1.25 +19 -6; commitid: a00249152da441a7; xorp/bgp/harness/trie.cc 1.15 +2 -2; commitid: a00249152da441a7; xorp/bgp/harness/trie_payload.hh 1.17 +25 -3; commitid: a00249152da441a7; xorp/bgp/internal_message.cc 1.14 +35 -4; commitid: a00249152da441a7; xorp/bgp/internal_message.hh 1.48 +23 -31; commitid: a00249152da441a7; xorp/bgp/packet.hh 1.98 +1024 -289; commitid: a00249152da441a7; xorp/bgp/path_attribute.cc 1.53 +347 -53; commitid: a00249152da441a7; xorp/bgp/path_attribute.hh 1.150 +29 -28; commitid: a00249152da441a7; xorp/bgp/peer.cc 1.53 +3 -3; commitid: a00249152da441a7; xorp/bgp/peer.hh 1.28 +43 -1; commitid: a00249152da441a7; xorp/bgp/peer_data.hh 1.50 +292 -204; commitid: a00249152da441a7; xorp/bgp/peer_handler.cc 1.31 +21 -7; commitid: a00249152da441a7; xorp/bgp/peer_handler.hh 1.16 +54 -13; commitid: a00249152da441a7; xorp/bgp/peer_handler_debug.cc 1.12 +25 -11; commitid: a00249152da441a7; xorp/bgp/peer_handler_debug.hh 1.109 +64 -49; commitid: a00249152da441a7; xorp/bgp/plumbing.cc 1.46 +14 -7; commitid: a00249152da441a7; xorp/bgp/plumbing.hh 1.80 +30 -49; commitid: a00249152da441a7; xorp/bgp/rib_ipc_handler.cc 1.51 +15 -5; commitid: a00249152da441a7; xorp/bgp/rib_ipc_handler.hh 1.18 +12 -5; commitid: a00249152da441a7; xorp/bgp/route_queue.hh 1.29 +68 -46; commitid: a00249152da441a7; xorp/bgp/route_table_aggregation.cc 1.19 +21 -17; commitid: a00249152da441a7; xorp/bgp/route_table_aggregation.hh 1.15 +2 -2; commitid: a00249152da441a7; xorp/bgp/route_table_base.cc 1.21 +8 -7; commitid: a00249152da441a7; xorp/bgp/route_table_base.hh 1.44 +232 -246; commitid: a00249152da441a7; xorp/bgp/route_table_cache.cc 1.32 +10 -7; commitid: a00249152da441a7; xorp/bgp/route_table_cache.hh 1.13 +11 -9; commitid: a00249152da441a7; xorp/bgp/route_table_damping.cc 1.8 +8 -7; commitid: a00249152da441a7; xorp/bgp/route_table_damping.hh 1.19 +37 -17; commitid: a00249152da441a7; xorp/bgp/route_table_debug.cc 1.16 +11 -7; commitid: a00249152da441a7; xorp/bgp/route_table_debug.hh 1.51 +64 -53; commitid: a00249152da441a7; xorp/bgp/route_table_decision.cc 1.29 +24 -11; commitid: a00249152da441a7; xorp/bgp/route_table_decision.hh 1.30 +18 -10; commitid: a00249152da441a7; xorp/bgp/route_table_deletion.cc 1.25 +8 -7; commitid: a00249152da441a7; xorp/bgp/route_table_deletion.hh 1.44 +10 -9; commitid: a00249152da441a7; xorp/bgp/route_table_dump.cc 1.27 +8 -7; commitid: a00249152da441a7; xorp/bgp/route_table_dump.hh 1.66 +51 -14; commitid: a00249152da441a7; xorp/bgp/route_table_fanout.cc 1.27 +11 -10; commitid: a00249152da441a7; xorp/bgp/route_table_fanout.hh 1.57 +207 -562; commitid: a00249152da441a7; xorp/bgp/route_table_filter.cc 1.33 +32 -59; commitid: a00249152da441a7; xorp/bgp/route_table_filter.hh 1.32 +58 -42; commitid: a00249152da441a7; xorp/bgp/route_table_nhlookup.cc 1.20 +20 -16; commitid: a00249152da441a7; xorp/bgp/route_table_nhlookup.hh 1.29 +44 -113; commitid: a00249152da441a7; xorp/bgp/route_table_policy.cc 1.15 +14 -17; commitid: a00249152da441a7; xorp/bgp/route_table_policy.hh 1.10 +3 -1; commitid: a00249152da441a7; xorp/bgp/route_table_policy_ex.cc 1.21 +61 -65; commitid: a00249152da441a7; xorp/bgp/route_table_policy_im.cc 1.10 +2 -2; commitid: a00249152da441a7; xorp/bgp/route_table_policy_im.hh 1.54 +96 -74; commitid: a00249152da441a7; xorp/bgp/route_table_ribin.cc 1.31 +19 -8; commitid: a00249152da441a7; xorp/bgp/route_table_ribin.hh 1.38 +49 -19; commitid: a00249152da441a7; xorp/bgp/route_table_ribout.cc 1.21 +7 -6; commitid: a00249152da441a7; xorp/bgp/route_table_ribout.hh 1.59 +2 -2; commitid: a00249152da441a7; xorp/bgp/socket.cc 1.27 +43 -63; commitid: a00249152da441a7; xorp/bgp/subnet_route.cc 1.28 +292 -82; commitid: a00249152da441a7; xorp/bgp/subnet_route.hh 1.38 +44 -24; commitid: a00249152da441a7; xorp/bgp/test_cache.cc 1.6 +0 -67; commitid: a00249152da441a7; xorp/bgp/test_cache.reference 1.47 +392 -1112; commitid: a00249152da441a7; xorp/bgp/test_decision.cc 1.13 +0 -142; commitid: a00249152da441a7; xorp/bgp/test_decision.reference 1.37 +54 -191; commitid: a00249152da441a7; xorp/bgp/test_deletion.cc 1.61 +187 -834; commitid: a00249152da441a7; xorp/bgp/test_dump.cc 1.17 +0 -195; commitid: a00249152da441a7; xorp/bgp/test_dump.reference 1.40 +22 -12; commitid: a00249152da441a7; xorp/bgp/test_fanout.cc 1.46 +43 -39; commitid: a00249152da441a7; xorp/bgp/test_filter.cc 1.27 +2 -1; commitid: a00249152da441a7; xorp/bgp/test_main.cc 1.40 +21 -13; commitid: a00249152da441a7; xorp/bgp/test_nhlookup.cc 1.20 +24 -8; commitid: a00249152da441a7; xorp/bgp/test_packet.cc 1.24 +91 -79; commitid: a00249152da441a7; xorp/bgp/test_packet_coding.cc 1.28 +43 -61; commitid: a00249152da441a7; xorp/bgp/test_plumbing.cc 1.13 +4 -4; commitid: a00249152da441a7; xorp/bgp/test_plumbing.hh 1.14 +78 -57; commitid: a00249152da441a7; xorp/bgp/test_policy.cc 1.4 +0 -2; commitid: a00249152da441a7; xorp/bgp/test_policy_dump.reference 1.43 +69 -208; commitid: a00249152da441a7; xorp/bgp/test_ribin.cc 1.38 +19 -12; commitid: a00249152da441a7; xorp/bgp/test_ribout.cc 1.14 +14 -12; commitid: a00249152da441a7; xorp/bgp/test_subnet_route.cc 1.40 +74 -73; commitid: a00249152da441a7; xorp/bgp/tools/Makefile.in 1.49 +64 -33; commitid: a00249152da441a7; xorp/bgp/update_packet.cc 1.22 +10 -3; commitid: a00249152da441a7; xorp/bgp/update_test.cc 1.37 +91 -92; commitid: a00249152da441a7; xorp/cli/Makefile.in 1.18 +66 -65; commitid: a00249152da441a7; xorp/cli/tools/Makefile.in 1.301 +534 -716; commitid: a00249152da441a7; xorp/configure 1.16 +59 -60; commitid: a00249152da441a7; xorp/contrib/Makefile.in 1.2 +76 -74; commitid: a00249152da441a7; xorp/contrib/mld6igmp_lite/Makefile.in 1.4 +115 -102; commitid: a00249152da441a7; xorp/contrib/olsr/Makefile.in 1.4 +67 -65; commitid: a00249152da441a7; xorp/contrib/olsr/tools/Makefile.in 1.34 +59 -60; commitid: a00249152da441a7; xorp/docs/Makefile.in 1.31 +45 -43; commitid: a00249152da441a7; xorp/docs/bgp/Makefile.in 1.31 +45 -43; commitid: a00249152da441a7; xorp/docs/design_arch/Makefile.in 1.31 +45 -43; commitid: a00249152da441a7; xorp/docs/fea/Makefile.in 1.32 +45 -43; commitid: a00249152da441a7; xorp/docs/libxipc/Makefile.in 1.31 +45 -43; commitid: a00249152da441a7; xorp/docs/libxorp/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/mfea/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/mld6igmp/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/multicast/Makefile.in 1.4 +45 -43; commitid: a00249152da441a7; xorp/docs/olsr/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/pim/Makefile.in 1.45 +45 -43; commitid: a00249152da441a7; xorp/docs/pim_testsuite/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/rib/Makefile.in 1.33 +45 -43; commitid: a00249152da441a7; xorp/docs/rtrmgr/Makefile.in 1.18 +59 -60; commitid: a00249152da441a7; xorp/docs/slides/Makefile.in 1.18 +45 -43; commitid: a00249152da441a7; xorp/docs/slides/status_2004_02/Makefile.in 1.31 +45 -43; commitid: a00249152da441a7; xorp/docs/snmp/Makefile.in 1.30 +45 -43; commitid: a00249152da441a7; xorp/docs/test_harness/Makefile.in 1.28 +45 -43; commitid: a00249152da441a7; xorp/docs/user_manual/Makefile.in 1.18 +45 -43; commitid: a00249152da441a7; xorp/docs/xorpdev_101/Makefile.in 1.20 +59 -60; commitid: a00249152da441a7; xorp/etc/Makefile.in 1.42 +45 -45; commitid: a00249152da441a7; xorp/etc/templates/Makefile.in 1.131 +101 -107; commitid: a00249152da441a7; xorp/fea/Makefile.in 1.19 +47 -47; commitid: a00249152da441a7; xorp/fea/MakefileRootCheck.in 1.9 +59 -60; commitid: a00249152da441a7; xorp/fea/data_plane/Makefile.in 1.7 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/control_socket/Makefile.in 1.8 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/fibconfig/Makefile.in 1.3 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/firewall/Makefile.in 1.11 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/ifconfig/Makefile.in 1.9 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/io/Makefile.in 1.5 +62 -63; commitid: a00249152da441a7; xorp/fea/data_plane/managers/Makefile.in 1.16 +76 -71; commitid: a00249152da441a7; xorp/fea/tools/Makefile.in 1.23 +74 -72; commitid: a00249152da441a7; xorp/fib2mrib/Makefile.in 1.38 +82 -80; commitid: a00249152da441a7; xorp/libcomm/Makefile.in 1.28 +76 -72; commitid: a00249152da441a7; xorp/libfeaclient/Makefile.in 1.44 +83 -83; commitid: a00249152da441a7; xorp/libproto/Makefile.in 1.79 +139 -137; commitid: a00249152da441a7; xorp/libxipc/Makefile.in 1.79 +131 -131; commitid: a00249152da441a7; xorp/libxorp/Makefile.in 1.55 +88 -112; commitid: a00249152da441a7; xorp/mibs/Makefile.in 1.71 +525 -713; commitid: a00249152da441a7; xorp/mibs/configure 1.19 +48 -51; commitid: a00249152da441a7; xorp/mibs/snmpdscripts/Makefile.in 1.19 +38 -43; commitid: a00249152da441a7; xorp/mibs/tests/Makefile.in 1.63 +76 -74; commitid: a00249152da441a7; xorp/mld6igmp/Makefile.in 1.36 +82 -80; commitid: a00249152da441a7; xorp/mrt/Makefile.in 1.36 +96 -100; commitid: a00249152da441a7; xorp/ospf/Makefile.in 1.14 +68 -66; commitid: a00249152da441a7; xorp/ospf/tools/Makefile.in 1.66 +76 -74; commitid: a00249152da441a7; xorp/pim/Makefile.in 1.46 +84 -87; commitid: a00249152da441a7; xorp/policy/Makefile.in 1.23 +62 -63; commitid: a00249152da441a7; xorp/policy/backend/Makefile.in 1.21 +65 -66; commitid: a00249152da441a7; xorp/policy/common/Makefile.in 1.8 +18 -18; commitid: a00249152da441a7; xorp/policy/test/Makefile.am 1.23 +87 -109; commitid: a00249152da441a7; xorp/policy/test/Makefile.in 1.12 +5 -4; commitid: a00249152da441a7; xorp/policy/test/policybench.cc 1.66 +127 -108; commitid: a00249152da441a7; xorp/rib/Makefile.in 1.17 +66 -62; commitid: a00249152da441a7; xorp/rib/tools/Makefile.in 1.66 +227 -249; commitid: a00249152da441a7; xorp/rip/Makefile.in 1.18 +74 -70; commitid: a00249152da441a7; xorp/rip/tools/Makefile.in 1.81 +107 -105; commitid: a00249152da441a7; xorp/rtrmgr/Makefile.in 1.6 +44 -43; commitid: a00249152da441a7; xorp/rtrmgr/config/Makefile.in 1.24 +74 -72; commitid: a00249152da441a7; xorp/static_routes/Makefile.in 1.40 +83 -84; commitid: a00249152da441a7; xorp/utils/Makefile.in 1.7 +84 -87; commitid: a00249152da441a7; xorp/vrrp/Makefile.in 1.3 +63 -62; commitid: a00249152da441a7; xorp/vrrp/test/Makefile.in 1.28 +59 -60; commitid: a00249152da441a7; xorp/xrl/Makefile.in 1.65 +121 -122; commitid: a00249152da441a7; xorp/xrl/interfaces/Makefile.in 1.97 +99 -100; commitid: a00249152da441a7; xorp/xrl/targets/Makefile.in 1.35 +68 -69; commitid: a00249152da441a7; xorp/xrl/tests/Makefile.in From abittau at icir.org Sun Nov 9 00:17:29 2008 From: abittau at icir.org (Andrea Bittau) Date: Sun, 9 Nov 2008 08:17:29 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm xorp/libxorp Message-ID: <200811090817.mA98HTWx053388@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: abittau at chum.icir.org 2008-11-09 08:17:29 UTC XORP CVS repository Modified files: libcomm comm_user.c libxorp test_sched.cc Log message: attempt to fix compilation on windows Revision Changes Path 1.39 +3 -3; commitid: d06249169c8e41a7; xorp/libcomm/comm_user.c 1.6 +5 -1; commitid: d06249169c8e41a7; xorp/libxorp/test_sched.cc From pavlin at icir.org Sun Nov 9 02:18:22 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Sun, 9 Nov 2008 10:18:22 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libcomm Message-ID: <200811091018.mA9AIM8Q054381@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-09 10:18:22 UTC XORP CVS repository Modified files: libcomm comm_user.c Log message: Return XORP_BAD_SOCKET instead of casted XORP_ERROR. Revision Changes Path 1.40 +2 -2; commitid: d4564916b8d841a7; xorp/libcomm/comm_user.c From bms at icir.org Sun Nov 9 12:06:30 2008 From: bms at icir.org (Bruce Simpson) Date: Sun, 9 Nov 2008 20:06:30 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/windows_port/figs Message-ID: <200811092006.mA9K6Uv5068235@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-09 20:06:30 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/docs/windows_port/figs added to the repository From bms at icir.org Sun Nov 9 12:23:52 2008 From: bms at icir.org (Bruce Simpson) Date: Sun, 9 Nov 2008 20:23:52 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/tex Message-ID: <200811092023.mA9KNqhX068382@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-09 20:23:52 UTC XORP CVS repository Modified files: docs/tex xorp.bib Log message: Add Windows-related bibliography entries. Revision Changes Path 1.20 +86 -1; commitid: 10b07491746ca41a7; xorp/docs/tex/xorp.bib From bms at icir.org Sun Nov 9 12:47:57 2008 From: bms at icir.org (Bruce Simpson) Date: Sun, 9 Nov 2008 20:47:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/windows_port xorp/docs/windows_port/figs Message-ID: <200811092047.mA9KlvBo068594@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-09 20:47:57 UTC XORP CVS repository Added files: docs/windows_port .cvsignore Makefile.am windows_port.tex docs/windows_port/figs windispatcher.svg Log message: Import the Windows development document. Not yet connected to the build. This is a technically rigorous and (hopefully) fairly complete engineering document, which describes in detail how XORP has been ported to the Windows platform. Note: The UML figures are in SVG format. This is not yet supported natively in LaTeX, conversion will be needed, so they are stubbed out. Requested by: Atanu Ghosh Revision Changes Path 1.1 +16 -0 xorp/docs/windows_port/.cvsignore (new) 1.1 +20 -0 xorp/docs/windows_port/Makefile.am (new) 1.1 +140 -0 xorp/docs/windows_port/figs/windispatcher.svg (new) 1.1 +1762 -0 xorp/docs/windows_port/windows_port.tex (new) From bms at icir.org Sun Nov 9 16:08:21 2008 From: bms at icir.org (Bruce Simpson) Date: Mon, 10 Nov 2008 00:08:21 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/windows_port xorp/docs/windows_port/figs Message-ID: <200811100008.mAA08LPX070293@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-10 00:08:21 UTC XORP CVS repository Modified files: docs/windows_port windows_port.tex Added files: docs/windows_port/figs windispatcher.pdf Log message: Fix typos from proofread. Include BOUML output as a PDF, as SVG is not natively supported yet by LaTex, and Inkscape generates buggy EPS from the SVG output. Revision Changes Path 1.1 +281 -0 xorp/docs/windows_port/figs/windispatcher.pdf (new) 1.2 +19 -7; commitid: 1126b49177b6941a7; xorp/docs/windows_port/windows_port.tex From bms at icir.org Mon Nov 10 09:59:04 2008 From: bms at icir.org (Bruce Simpson) Date: Mon, 10 Nov 2008 17:59:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/windows_port Message-ID: <200811101759.mAAHx4v0079709@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-10 17:59:04 UTC XORP CVS repository Modified files: docs/windows_port windows_port.tex Log message: Add conditional inclusion of graphicx package with dvipdf. Use an explicit scale and bounding box in the includegraphics command. The diagram is still present in the PDFLaTeX output, and both PDFLaTeX and LaTeX can now build the file. However, page 5 is currently blank in the PostScript output; the diagram does not appear when the DVI is viewed manually. The workaround to achieve PostScript output is to export PostScript from the PDF generated with PDFLaTeX. The real solution for this issue is to wait for native SVG support in LaTeX. Revision Changes Path 1.3 +8 -8; commitid: 137464918765f41a7; xorp/docs/windows_port/windows_port.tex From atanu at icir.org Tue Nov 11 14:39:24 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 11 Nov 2008 22:39:24 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200811112239.mABMdOLP094136@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-11 22:39:23 UTC XORP CVS repository Modified files: libxipc xrl_router.cc Log message: A pointer can be kept in an Xrl to a resolved Xrl, it should not used in the Xrl that belongs to the finder client. When a connection goes down this state is not cleared. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=818 Approved by: Syed Khalid Revision Changes Path 1.71 +7 -1; commitid: 16f9f491a099b41a7; xorp/libxipc/xrl_router.cc From mjh at icir.org Tue Nov 11 14:52:13 2008 From: mjh at icir.org (Mark Handley) Date: Tue, 11 Nov 2008 22:52:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811112252.mABMqDKu094289@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: mjh at chum.icir.org 2008-11-11 22:52:13 UTC XORP CVS repository Modified files: bgp route_table_nhlookup.cc Log message: Initialize a pointer to stop the Gentoo compiler generating spurious warnings. Approved by: Syed Revision Changes Path 1.33 +2 -2; commitid: 1703a491a0c5f41a7; xorp/bgp/route_table_nhlookup.cc From jtc at icir.org Wed Nov 12 15:10:40 2008 From: jtc at icir.org (JT Conklin) Date: Wed, 12 Nov 2008 23:10:40 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811122310.mACNAe9S005235@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: jtc at chum.icir.org 2008-11-12 23:10:40 UTC XORP CVS repository Modified files: bgp route_table_debug.cc Log message: Changed fprintf(_ostream, s.c_str()) to fputs(s.c_str(), _ostream), as the former can trigger g++'s *printf format directive checking warnings (I saw this on ubuntu 8.10). Reviewed by: mjh Revision Changes Path 1.20 +2 -2; commitid: 1444491b617541a7; xorp/bgp/route_table_debug.cc From jtc at icir.org Wed Nov 12 18:03:26 2008 From: jtc at icir.org (JT Conklin) Date: Thu, 13 Nov 2008 02:03:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811130203.mAD23Q1t006393@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: jtc at chum.icir.org 2008-11-13 02:03:26 UTC XORP CVS repository Modified files: bgp route_table_debug.cc Log message: Change fputs(s.c_str(), _ofile) to fprintf(_ofile, "%s", s.c_str()) at Pavlin's request, to be consistent with the rest of the code. Revision Changes Path 1.21 +2 -2; commitid: 18e2491b8a5d41a7; xorp/bgp/route_table_debug.cc From bms at icir.org Thu Nov 13 05:11:27 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 13 Nov 2008 13:11:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/tex Message-ID: <200811131311.mADDBRIk011094@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-13 13:11:27 UTC XORP CVS repository Modified files: docs/tex xorp.bib Log message: fix typos Revision Changes Path 1.21 +3 -3; commitid: 2b3f491c277941a7; xorp/docs/tex/xorp.bib From pavlin at icir.org Thu Nov 13 10:15:14 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Thu, 13 Nov 2008 18:15:14 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp xorp/bgp xorp/bgp/harness xorp/bgp/tools xorp/cli xorp/cli/tools xorp/contrib xorp/contrib/mld6igmp_lite xorp/contrib/olsr xorp/contrib/olsr/tools xorp/docs xorp/docs/bgp xorp/docs/design_arch xorp/docs/fea xorp/docs/libxipc ... Message-ID: <200811131815.mADIFEeL014535@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-13 18:15:14 UTC XORP CVS repository Modified files: . Makefile.in MakefileRootCheck.in configure bgp Makefile.in bgp/harness Makefile.in bgp/tools Makefile.in cli Makefile.in cli/tools Makefile.in contrib Makefile.in contrib/mld6igmp_lite Makefile.in contrib/olsr Makefile.in contrib/olsr/tools Makefile.in docs Makefile.in docs/bgp Makefile.in docs/design_arch Makefile.in docs/fea Makefile.in docs/libxipc Makefile.in docs/libxorp Makefile.in docs/mfea Makefile.in docs/mld6igmp Makefile.in docs/multicast Makefile.in docs/olsr Makefile.in docs/pim Makefile.in docs/pim_testsuite Makefile.in docs/rib Makefile.in docs/rtrmgr Makefile.in docs/slides Makefile.in docs/slides/status_2004_02 Makefile.in docs/snmp Makefile.in docs/test_harness Makefile.in docs/user_manual Makefile.in docs/xorpdev_101 Makefile.in etc Makefile.in etc/templates Makefile.in fea Makefile.in MakefileRootCheck.in fea/data_plane Makefile.in fea/data_plane/control_socket Makefile.in fea/data_plane/fibconfig Makefile.in fea/data_plane/firewall Makefile.in fea/data_plane/ifconfig Makefile.in fea/data_plane/io Makefile.in fea/data_plane/managers Makefile.in fea/tools Makefile.in fib2mrib Makefile.in libcomm Makefile.in libfeaclient Makefile.in libproto Makefile.in libxipc Makefile.in libxorp Makefile.in mibs Makefile.in configure mibs/snmpdscripts Makefile.in mibs/tests Makefile.in mld6igmp Makefile.in mrt Makefile.in ospf Makefile.in ospf/tools Makefile.in pim Makefile.in policy Makefile.in policy/backend Makefile.in policy/common Makefile.in policy/test Makefile.in rib Makefile.in rib/tools Makefile.in rip Makefile.in rip/tools Makefile.in rtrmgr Makefile.in rtrmgr/config Makefile.in static_routes Makefile.in utils Makefile.in vrrp Makefile.in vrrp/test Makefile.in xrl Makefile.in xrl/interfaces Makefile.in xrl/targets Makefile.in xrl/tests Makefile.in Log message: Re-generate all Makefile.in with automake-1.10, the version that is currently supported and is specified in README. An earlier commit had regenerated all the Makefile.in with automake-1.9.6. Revision Changes Path 1.61 +68 -64; commitid: 330d491c6d5f41a7; xorp/Makefile.in 1.21 +68 -64; commitid: 330d491c6d5f41a7; xorp/MakefileRootCheck.in 1.73 +98 -94; commitid: 330d491c6d5f41a7; xorp/bgp/Makefile.in 1.51 +75 -74; commitid: 330d491c6d5f41a7; xorp/bgp/harness/Makefile.in 1.41 +73 -74; commitid: 330d491c6d5f41a7; xorp/bgp/tools/Makefile.in 1.38 +92 -91; commitid: 330d491c6d5f41a7; xorp/cli/Makefile.in 1.19 +65 -66; commitid: 330d491c6d5f41a7; xorp/cli/tools/Makefile.in 1.302 +716 -534; commitid: 330d491c6d5f41a7; xorp/configure 1.17 +60 -59; commitid: 330d491c6d5f41a7; xorp/contrib/Makefile.in 1.3 +74 -76; commitid: 330d491c6d5f41a7; xorp/contrib/mld6igmp_lite/Makefile.in 1.5 +102 -115; commitid: 330d491c6d5f41a7; xorp/contrib/olsr/Makefile.in 1.5 +65 -67; commitid: 330d491c6d5f41a7; xorp/contrib/olsr/tools/Makefile.in 1.35 +60 -59; commitid: 330d491c6d5f41a7; xorp/docs/Makefile.in 1.32 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/bgp/Makefile.in 1.32 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/design_arch/Makefile.in 1.32 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/fea/Makefile.in 1.33 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/libxipc/Makefile.in 1.32 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/libxorp/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/mfea/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/mld6igmp/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/multicast/Makefile.in 1.5 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/olsr/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/pim/Makefile.in 1.46 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/pim_testsuite/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/rib/Makefile.in 1.34 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/rtrmgr/Makefile.in 1.19 +60 -59; commitid: 330d491c6d5f41a7; xorp/docs/slides/Makefile.in 1.19 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/slides/status_2004_02/Makefile.in 1.32 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/snmp/Makefile.in 1.31 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/test_harness/Makefile.in 1.29 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/user_manual/Makefile.in 1.19 +43 -45; commitid: 330d491c6d5f41a7; xorp/docs/xorpdev_101/Makefile.in 1.21 +60 -59; commitid: 330d491c6d5f41a7; xorp/etc/Makefile.in 1.43 +45 -45; commitid: 330d491c6d5f41a7; xorp/etc/templates/Makefile.in 1.132 +107 -101; commitid: 330d491c6d5f41a7; xorp/fea/Makefile.in 1.20 +47 -47; commitid: 330d491c6d5f41a7; xorp/fea/MakefileRootCheck.in 1.10 +60 -59; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/Makefile.in 1.8 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/control_socket/Makefile.in 1.9 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/fibconfig/Makefile.in 1.4 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/firewall/Makefile.in 1.12 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/ifconfig/Makefile.in 1.10 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/io/Makefile.in 1.6 +63 -62; commitid: 330d491c6d5f41a7; xorp/fea/data_plane/managers/Makefile.in 1.17 +71 -76; commitid: 330d491c6d5f41a7; xorp/fea/tools/Makefile.in 1.24 +72 -74; commitid: 330d491c6d5f41a7; xorp/fib2mrib/Makefile.in 1.39 +80 -82; commitid: 330d491c6d5f41a7; xorp/libcomm/Makefile.in 1.29 +72 -76; commitid: 330d491c6d5f41a7; xorp/libfeaclient/Makefile.in 1.45 +83 -83; commitid: 330d491c6d5f41a7; xorp/libproto/Makefile.in 1.80 +137 -139; commitid: 330d491c6d5f41a7; xorp/libxipc/Makefile.in 1.80 +131 -131; commitid: 330d491c6d5f41a7; xorp/libxorp/Makefile.in 1.56 +112 -88; commitid: 330d491c6d5f41a7; xorp/mibs/Makefile.in 1.72 +713 -525; commitid: 330d491c6d5f41a7; xorp/mibs/configure 1.20 +51 -48; commitid: 330d491c6d5f41a7; xorp/mibs/snmpdscripts/Makefile.in 1.20 +43 -38; commitid: 330d491c6d5f41a7; xorp/mibs/tests/Makefile.in 1.64 +74 -76; commitid: 330d491c6d5f41a7; xorp/mld6igmp/Makefile.in 1.37 +80 -82; commitid: 330d491c6d5f41a7; xorp/mrt/Makefile.in 1.37 +100 -96; commitid: 330d491c6d5f41a7; xorp/ospf/Makefile.in 1.15 +66 -68; commitid: 330d491c6d5f41a7; xorp/ospf/tools/Makefile.in 1.67 +74 -76; commitid: 330d491c6d5f41a7; xorp/pim/Makefile.in 1.47 +87 -84; commitid: 330d491c6d5f41a7; xorp/policy/Makefile.in 1.24 +63 -62; commitid: 330d491c6d5f41a7; xorp/policy/backend/Makefile.in 1.22 +66 -65; commitid: 330d491c6d5f41a7; xorp/policy/common/Makefile.in 1.24 +68 -66; commitid: 330d491c6d5f41a7; xorp/policy/test/Makefile.in 1.67 +108 -127; commitid: 330d491c6d5f41a7; xorp/rib/Makefile.in 1.18 +62 -66; commitid: 330d491c6d5f41a7; xorp/rib/tools/Makefile.in 1.67 +249 -227; commitid: 330d491c6d5f41a7; xorp/rip/Makefile.in 1.19 +70 -74; commitid: 330d491c6d5f41a7; xorp/rip/tools/Makefile.in 1.82 +105 -107; commitid: 330d491c6d5f41a7; xorp/rtrmgr/Makefile.in 1.7 +43 -44; commitid: 330d491c6d5f41a7; xorp/rtrmgr/config/Makefile.in 1.25 +72 -74; commitid: 330d491c6d5f41a7; xorp/static_routes/Makefile.in 1.41 +84 -83; commitid: 330d491c6d5f41a7; xorp/utils/Makefile.in 1.8 +87 -84; commitid: 330d491c6d5f41a7; xorp/vrrp/Makefile.in 1.4 +62 -63; commitid: 330d491c6d5f41a7; xorp/vrrp/test/Makefile.in 1.29 +60 -59; commitid: 330d491c6d5f41a7; xorp/xrl/Makefile.in 1.66 +122 -121; commitid: 330d491c6d5f41a7; xorp/xrl/interfaces/Makefile.in 1.98 +100 -99; commitid: 330d491c6d5f41a7; xorp/xrl/targets/Makefile.in 1.36 +69 -68; commitid: 330d491c6d5f41a7; xorp/xrl/tests/Makefile.in From bms at icir.org Thu Nov 13 11:24:34 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 13 Nov 2008 19:24:34 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811131924.mADJOYKa015046@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-13 19:24:34 UTC XORP CVS repository Modified files: bgp packet.hh Log message: Fix compilation under OpenBSD 4.2 / gcc 3.3.5: Dependent qualified names referring to templates must use the "template" keyword in their last component. Please refer to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9887 http://womble.decadentplace.org.uk/c++/template-faq.html#disambiguation Requested by: Pavlin Radoslavov Revision Changes Path 1.49 +3 -3; commitid: 3aaf491c7e7041a7; xorp/bgp/packet.hh From bms at icir.org Thu Nov 13 11:28:35 2008 From: bms at icir.org (Bruce Simpson) Date: Thu, 13 Nov 2008 19:28:35 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp Message-ID: <200811131928.mADJSZ7i015111@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-13 19:28:35 UTC XORP CVS repository Modified files: bgp path_attribute.cc Log message: Fix compilation under OpenBSD 4.2 / gcc 3.3.5: Dependent qualified names referring to templates must use the "template" keyword in their last component. Please refer to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9887 http://womble.decadentplace.org.uk/c++/template-faq.html#disambiguation Requested by: Pavlin Radoslavov Revision Changes Path 1.99 +5 -5; commitid: 3af0491c7fd141a7; xorp/bgp/path_attribute.cc From bms at icir.org Fri Nov 14 04:44:19 2008 From: bms at icir.org (Bruce Simpson) Date: Fri, 14 Nov 2008 12:44:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200811141244.mAECiJ8j023540@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-14 12:44:19 UTC XORP CVS repository Modified files: ospf debug_io.hh io.hh ospf.cc ospf.hh peer_manager.cc xrl_io.cc xrl_io.hh Log message: Fix an issue with OSPF virtual links, where packets destined for a virtual link endpoint would contain a TTL of 1, resulting in them being dropped as they transited the network. The downcall to the FEA to transmit a packet destined for a virtual link endpoint would rely on the FEA to set the TTL of the outer IPv4 header. As the OSPF process passes the ip_network_control flag true to the FEA when it sends the tranmission XRL, and a ttl of -1 to let the FEA choose the IPv4 TTL, this resulted in the FEA setting the TTL to 1 internally every time. The fix is to explicitly set the TTL for tranmission from within the OSPF PeerManager::transmit() method, as it has knowledge of whether or not the endpoint is virtual. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=824 Reviewed by: Pavlin Radoslavov Revision Changes Path 1.30 +3 -2; commitid: 5bc4491d728041a7; xorp/ospf/debug_io.hh 1.31 +2 -2; commitid: 5bc4491d728041a7; xorp/ospf/io.hh 1.101 +8 -7; commitid: 5bc4491d728041a7; xorp/ospf/ospf.cc 1.115 +2 -2; commitid: 5bc4491d728041a7; xorp/ospf/ospf.hh 1.160 +7 -3; commitid: 5bc4491d728041a7; xorp/ospf/peer_manager.cc 1.53 +7 -7; commitid: 5bc4491d728041a7; xorp/ospf/xrl_io.cc 1.35 +2 -2; commitid: 5bc4491d728041a7; xorp/ospf/xrl_io.hh From pavlin at icir.org Mon Nov 17 08:06:43 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 17 Nov 2008 16:06:43 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/fea Message-ID: <200811171606.mAHG6hno058523@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-17 16:06:43 UTC XORP CVS repository Modified files: fea test_fea_rawlink.cc Log message: Run test_fea_rawlink test only if HAVE_PCAP is defined. Installing L2 I/O mechanism like pcap(3) is optional, while test_fea_rawlink was always run (if the user was root). Approved by: Syed Khalid Revision Changes Path 1.7 +7 -1; commitid: e46c492195fd41a7; xorp/fea/test_fea_rawlink.cc From bms at icir.org Mon Nov 17 09:32:32 2008 From: bms at icir.org (Bruce Simpson) Date: Mon, 17 Nov 2008 17:32:32 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200811171732.mAHHWWgW059165@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: bms at chum.icir.org 2008-11-17 17:32:32 UTC XORP CVS repository Modified files: bgp/harness test_trie.cc Log message: Fix compilation under OpenBSD 4.2 / gcc 3.3.5: Dependent qualified names referring to templates must use the "template" keyword in their last component. Please refer to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9887 http://womble.decadentplace.org.uk/c++/template-faq.html#disambiguation Requested by: Pavlin Radoslavov Revision Changes Path 1.30 +4 -4; commitid: e7064921aaa341a7; xorp/bgp/harness/test_trie.cc From bms at incunabulum.net Mon Nov 17 09:36:26 2008 From: bms at incunabulum.net (Bruce M. Simpson) Date: Mon, 17 Nov 2008 17:36:26 +0000 Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness In-Reply-To: <200811171732.mAHHWWgW059165@chum.icir.org> References: <200811171732.mAHHWWgW059165@chum.icir.org> Message-ID: <4921AB9A.3070208@incunabulum.net> This is low hanging fruit to fix the Tinderbox . From pavlin at icir.org Mon Nov 17 10:14:01 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 17 Nov 2008 18:14:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/bgp/harness Message-ID: <200811171814.mAHIE1Z0059540@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-17 18:14:01 UTC XORP CVS repository Modified files: bgp/harness test_trie.cc Log message: * Fix compilation under OpenBSD 4.2 / gcc 3.3.5: Dependent qualified names referring to templates must use the "template" keyword in their last component. Please refer to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9887 http://womble.decadentplace.org.uk/c++/template-faq.html#disambiguation * Added "new lines" as appropriate at end of statements and removed extra empty space. Revision Changes Path 1.31 +8 -4; commitid: e8704921b3a841a7; xorp/bgp/harness/test_trie.cc From atanu at icir.org Tue Nov 18 10:14:47 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 18:14:47 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181814.mAIIElMJ070781@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 18:14:47 UTC XORP CVS repository Modified files: examples/usermgr Makefile.am Log message: The source file xrl_target.cc was not being compiled correct this and other lines. Revision Changes Path 1.3 +6 -6; commitid: 114644923061641a7; xorp/examples/usermgr/Makefile.am From atanu at icir.org Tue Nov 18 10:15:57 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 18:15:57 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181815.mAIIFvNB070858@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 18:15:56 UTC XORP CVS repository Modified files: examples/usermgr Makefile.in Log message: The source file xrl_target.cc was not being compiled correct this and other lines. Revision Changes Path 1.2 +98 -210; commitid: 114b14923065c41a7; xorp/examples/usermgr/Makefile.in From atanu at icir.org Tue Nov 18 10:16:46 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 18:16:46 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181816.mAIIGkP3070904@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 18:16:46 UTC XORP CVS repository Modified files: examples/usermgr README.INSTALL Log message: Correct path names as usermgr is below examples. Revision Changes Path 1.3 +5 -5; commitid: 114df4923068d41a7; xorp/examples/usermgr/README.INSTALL From atanu at icir.org Tue Nov 18 11:08:13 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 19:08:13 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181908.mAIJ8DaG071348@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 19:08:13 UTC XORP CVS repository Modified files: examples/usermgr usermgr.tp Log message: Correct path names as usermgr is below examples. Revision Changes Path 1.3 +2 -2; commitid: 1169b4923129d41a7; xorp/examples/usermgr/usermgr.tp From atanu at icir.org Tue Nov 18 11:15:09 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 19:15:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181915.mAIJF9jb071520@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 19:15:09 UTC XORP CVS repository Modified files: examples/usermgr usermgr.cc usermgr.hh Log message: Reformat to conform with coding style. Remove spurious "void" arguments, not required in C++. Commented out unnecesary constructors and destructors. Replaced "describe" methods that used printf with "str" a method that returns a string. We don't use "printf" and "str" is the preferred debugging method. Remove unnecesary casts. Revision Changes Path 1.3 +34 -19; commitid: 117454923143d41a7; xorp/examples/usermgr/usermgr.cc 1.3 +95 -78; commitid: 117454923143d41a7; xorp/examples/usermgr/usermgr.hh From atanu at icir.org Tue Nov 18 11:17:19 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 19:17:19 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181917.mAIJHJfu071573@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 19:17:19 UTC XORP CVS repository Modified files: examples/usermgr test_usermgr.cc Log message: Modify test program to use the testing framework. Revision Changes Path 1.3 +62 -10; commitid: 1177c492314be41a7; xorp/examples/usermgr/test_usermgr.cc From atanu at icir.org Tue Nov 18 11:26:12 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 19:26:12 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811181926.mAIJQCJl071755@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 19:26:12 UTC XORP CVS repository Modified files: examples/usermgr Makefile.am Makefile.in Log message: Running "gmake check" will now run the test program. Revision Changes Path 1.4 +4 -2; commitid: 11830492316d341a7; xorp/examples/usermgr/Makefile.am 1.3 +89 -14; commitid: 11830492316d341a7; xorp/examples/usermgr/Makefile.in From atanu at icir.org Tue Nov 18 14:57:09 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 22:57:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811182257.mAIMv9rF073221@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 22:57:09 UTC XORP CVS repository Modified files: examples/usermgr usermgr.cc usermgr.hh Log message: Commented out unnecessary constructor and destructors. Use initializers in constructors. Pass string arguments by reference. Constify methods. Put the "str" method last in the declaration. Revision Changes Path 1.4 +12 -12; commitid: 11dea4923484341a7; xorp/examples/usermgr/usermgr.cc 1.4 +48 -41; commitid: 11dea4923484341a7; xorp/examples/usermgr/usermgr.hh From atanu at icir.org Tue Nov 18 15:08:09 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 23:08:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811182308.mAIN89MT073382@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 23:08:09 UTC XORP CVS repository Modified files: examples/usermgr xorp_usermgr.cc Log message: XrlStdRouter only requires two arguments. Revision Changes Path 1.3 +2 -3; commitid: 11e8d49234ad841a7; xorp/examples/usermgr/xorp_usermgr.cc From atanu at icir.org Tue Nov 18 15:11:09 2008 From: atanu at icir.org (Atanu Ghosh) Date: Tue, 18 Nov 2008 23:11:09 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811182311.mAINB9fD073500@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-18 23:11:09 UTC XORP CVS repository Added files: examples/usermgr .cvsignore Log message: Files to ignore. Revision Changes Path 1.1 +8 -0 xorp/examples/usermgr/.cvsignore (new) From pavlin at icir.org Wed Nov 19 15:07:28 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 19 Nov 2008 23:07:28 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/pim Message-ID: <200811192307.mAJN7SPq083974@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-19 23:07:28 UTC XORP CVS repository Modified files: pim pim_proto_bootstrap.cc pim_proto_cand_rp_adv.cc Log message: Don't accept or transmit PIM-SM Bootstrap messages if the Bootstrap mechanism is not explicitly configured. For example, now there must be a "boostrap {}" block to explicitly enable the reception of the PIM-SM Bootstrap messages. Before the Bootstrap messages were accepted and forwarded even if the "bootstrap {}" block was missing. This fixes a bug that prevented users from rejecting Bootstrap messages in network setup with static RP configuration only. Bug found by: Marian Durkovic Approved by: Syed Khalid Revision Changes Path 1.28 +14 -2; commitid: 147ab49249a6241a7; xorp/pim/pim_proto_bootstrap.cc 1.25 +13 -1; commitid: 147ab49249a6241a7; xorp/pim/pim_proto_cand_rp_adv.cc From pavlin at icir.org Wed Nov 19 15:19:01 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Wed, 19 Nov 2008 23:19:01 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200811192319.mAJNJ1Fh084072@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-19 23:19:01 UTC XORP CVS repository Modified files: . RELEASE_NOTES Log message: Add a release note regarding the PIM-SM Bootstrap configuration. Revision Changes Path 1.222 +22 -2; commitid: 1485149249eb741a7; xorp/RELEASE_NOTES From pavlin at icir.org Wed Nov 19 18:43:26 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Thu, 20 Nov 2008 02:43:26 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/docs/user_manual Message-ID: <200811200243.mAK2hQU0085382@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-20 02:43:26 UTC XORP CVS repository Modified files: docs/user_manual pimsm.tex Log message: Added documentation clarifying that the bootstrap {} block is needed to enable the Bootstrap mechanism. Revision Changes Path 1.34 +6 -1; commitid: 14d6f4924ceaa41a7; xorp/docs/user_manual/pimsm.tex From atanu at icir.org Thu Nov 20 08:30:04 2008 From: atanu at icir.org (Atanu Ghosh) Date: Thu, 20 Nov 2008 16:30:04 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/examples/usermgr Message-ID: <200811201630.mAKGU4FK093142@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-20 16:30:04 UTC XORP CVS repository Modified files: examples/usermgr usermgr.tp Log message: Add a comment noting that "%list" is not implemented. Revision Changes Path 1.4 +3 -1; commitid: 16bbd4925908b41a7; xorp/examples/usermgr/usermgr.tp From atanu at icir.org Thu Nov 20 16:07:55 2008 From: atanu at icir.org (Atanu Ghosh) Date: Fri, 21 Nov 2008 00:07:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200811210007.mAL07t8U097755@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-21 00:07:55 UTC XORP CVS repository Modified files: ospf auth.hh Log message: Add a destructor to the Auth class to free the memory for the _auth_handler. Should solve this issue detected by valgrind. ==9545== 16 bytes in 2 blocks are definitely lost in loss record 1 of 34 ==9545== at 0x4023294: operator new(unsigned) (vg_replace_malloc.c:224) ==9545== by 0x80CC825: Auth::set_method(std::string const&) (auth.hh:565) ==9545== by 0x80CCA21: Auth::Auth(EventLoop&) (auth.hh:555) ==9545== by 0x80CD1FC: Peer::Peer(Ospf&, PeerOut&, unsigned, OspfTypes::AreaType) (peer.hh:572) ==9545== by 0x80CD5DF: PeerOut::PeerOut(Ospf&, std::string, std::string, unsigned, IPv4, OspfTypes::LinkType, unsigned, OspfTypes::AreaType) (peer.cc:111) ==9545== by 0x80A12CC: PeerManager::create_peer(std::string const&, std::string const&, IPv4, OspfTypes::LinkType, u nsigned) (peer_manager.cc:490) = =9545== by 0x810C064: XrlOspfV2Target::ospfv2_0_1_create_peer(std::string const&, std::string const&, IPv4 const&, std::st ring const&, IPv4 const&) (xrl_target.cc:578) ==9545== by 0x8194B3C: XrlOspfv2TargetBase::handle_ospfv2_0_1_create_peer(XrlArgs const&, XrlArgs*) (ospfv2_base.cc:521) ==9545== by 0x8198630: XorpMemberCallback2B0::dispatch(X rlArgs const&, XrlArgs*) (callback_nodebug.hh:4616) ==9545== by 0x828BE12: XrlCmdEntry::dispatch(XrlArgs const&, XrlArgs*) const (xrl_cmd_map.hh:43) ==9545== by 0x8292857: XrlDispatcher::dispatch_xrl_fast(XrlDispatcher::XI const&, XrlArgs&) const (xrl_dispatcher.cc:83) ==9545== by 0x829B98A: STCPRequestHandler::do_dispatch(unsigned char const*, unsigned, XrlArgs&) (xrl_pf_stcp.cc:264) ==9545== by 0x829BA49: STCPRequestHandler::dispatch_request(unsigned, bool, unsigned char const*, unsigned) (xrl_pf_stcp.c c:276) ==9545== by 0x829C099: STCPRequestHandler::read_event(BufferedAsyncReader*, BufferedAsyncReader::Event, unsigned char*, un signed) (xrl_pf_stcp.cc:210) ==9545== by 0x829DA1D: XorpMemberCallback4B0::dispatch(BufferedAsyncReader*, BufferedAsyncReader::Event, unsigned char*, unsigned) (callback_node bug.hh:8966) ==9545== by 0x82C6B90: BufferedAsyncReader::announce_event(BufferedAsyncReader::Event) (buffered_asyncio.cc:261) ==9545== by 0x82C6F34: BufferedAsyncReader::io_event(XorpFd, IoEventType) (buffered_asyncio.cc:214) ==9545== by 0x82C77F9: XorpMemberCallback2B0::dispatch(XorpFd, IoEventType ) (callback_nodebug.hh:4636) ==9545== by 0x82DA8B7: SelectorList::Node::run_hooks(SelectorMask, XorpFd) (selector.cc:172) ==9545== by 0x82D984B: SelectorList::wait_and_dispatch(TimeVal&) (selector.cc:483) ==9545== Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=832 Revision Changes Path 1.16 +8 -1; commitid: 17dc24925fbdb41a7; xorp/ospf/auth.hh From atanu at icir.org Thu Nov 20 16:32:11 2008 From: atanu at icir.org (Atanu Ghosh) Date: Fri, 21 Nov 2008 00:32:11 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/ospf Message-ID: <200811210032.mAL0WBkg097996@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-21 00:32:11 UTC XORP CVS repository Modified files: ospf routing_table.hh Log message: Add a destructor to the RoutingTable class to free the memory for _current and _previous. Should solve this issue detected by valgrind. ==9545== 528 (16 direct, 512 indirect) bytes in 2 blocks are definitely lost in loss record 8 of 34 ==9545== at 0x4023294: operator new(unsigned) (vg_replace_malloc.c:224) ==9545== by 0x80F0FAD: RoutingTable::begin(unsigned) (routing_table.cc:64) ==9545== by 0x8125311: AreaRouter::routing_total_recomputeV2() (area_router.cc:3989) ==9545== by 0x817064B: AreaRouter::routing_total_recompute() (area_router.cc:3890) ==9545== by 0x817066C: AreaRouter::routing_timer() (area_router.cc:3881) ==9545== by 0x812C5CE: XorpMemberCallback0B0 >::dispatch() (callback_nodebug.hh:306) ==9545== by 0x82E01BD: OneoffTimerNode2::expire(XorpTimer&, void*) (timer.cc:167) ==9545== by 0x82DF3BA: TimerList::expire_one(int) (timer.cc:441) ==9545== by 0x82DF535: TimerList::run() (timer.cc:389) ==9545== by 0x82C8F32: EventLoop::do_work(bool) (eventloop.cc:153) ==9545== by 0x82C92A4: EventLoop::run() (eventloop.cc:99) ==9545== by 0x804C507: main (xorp_ospfv2.cc:77) Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=832 Revision Changes Path 1.49 +8 -1; commitid: 17eb34926018b41a7; xorp/ospf/routing_table.hh From atanu at icir.org Fri Nov 21 13:57:18 2008 From: atanu at icir.org (Atanu Ghosh) Date: Fri, 21 Nov 2008 21:57:18 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/libxipc Message-ID: <200811212157.mALLvIjT006892@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: atanu at chum.icir.org 2008-11-21 21:57:18 UTC XORP CVS repository Modified files: libxipc xrl_router.cc Log message: Plug another path where a bad cached value is used for sending an XRL. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=818 Approved by: Syed Khalid Revision Changes Path 1.72 +5 -2; commitid: 1ad349272ebd41a7; xorp/libxipc/xrl_router.cc From jtc at icir.org Fri Nov 21 14:29:27 2008 From: jtc at icir.org (JT Conklin) Date: Fri, 21 Nov 2008 22:29:27 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/backend xorp/policy/test Message-ID: <200811212229.mALMTR4l007307@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: jtc at chum.icir.org 2008-11-21 22:29:27 UTC XORP CVS repository Modified files: policy yacc.yy_policy_parser.cc policy/backend yacc.yy_policy_backend_parser.cc policy/test yacc.yy_compile_policy.cc Log message: Changed code to use #ident preprocessor directive rather than a const char array qualified with an __unused macro for the yacc skeleton RCS Id. This avoids problems on platforms where __unused is #defined but can not be used in the same way as on FreeBSD (where yacc was invoked). This is a partial fix for bugzilla issue #807. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=807 Revision Changes Path 1.17 +1 -5; commitid: 1c004927350d41a7; xorp/policy/backend/yacc.yy_policy_backend_parser.cc 1.12 +1 -5; commitid: 1c004927350d41a7; xorp/policy/test/yacc.yy_compile_policy.cc 1.22 +1 -5; commitid: 1c004927350d41a7; xorp/policy/yacc.yy_policy_parser.cc From jtc at icir.org Fri Nov 21 15:00:25 2008 From: jtc at icir.org (JT Conklin) Date: Fri, 21 Nov 2008 23:00:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy xorp/policy/backend xorp/policy/test Message-ID: <200811212300.mALN0PWJ007685@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: jtc at chum.icir.org 2008-11-21 23:00:25 UTC XORP CVS repository Modified files: policy Makefile.am Makefile.in policy/backend Makefile.am Makefile.in policy/test Makefile.am Makefile.in Log message: Added "lex" and "yacc" targets to policy/Makefile.am, policy/backend/Makefile.am, and policy/test/Makefile.am automake templates to regenerate C source and header files from lex and yacc sources; and re- generated the corresponding Makefile.in files. This will ensure that the same lex/yacc options will used each time the lexer/parser specifications are changed. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=807 Revision Changes Path 1.17 +15 -2; commitid: 1d7549273c1041a7; xorp/policy/Makefile.am 1.48 +15 -0; commitid: 1d7549273c1041a7; xorp/policy/Makefile.in 1.9 +15 -1; commitid: 1d7549273c1041a7; xorp/policy/backend/Makefile.am 1.25 +15 -0; commitid: 1d7549273c1041a7; xorp/policy/backend/Makefile.in 1.9 +16 -1; commitid: 1d7549273c1041a7; xorp/policy/test/Makefile.am 1.25 +34 -19; commitid: 1d7549273c1041a7; xorp/policy/test/Makefile.in From pavlin at icir.org Mon Nov 24 10:51:25 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Mon, 24 Nov 2008 18:51:25 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/policy Message-ID: <200811241851.mAOIpPDl047245@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-24 18:51:25 UTC XORP CVS repository Modified files: policy policy.y yacc.yy_policy_parser.cc Log message: * Removed a comment in policy.y that seems to be obsolete, and that confuses the utils/rcsid2ident.sh script. * Regenerated yacc.yy_policy_parser.cc and edited it by hand to remove the following statements that are incorrectly left-in by the utils/rcsid2ident.sh script: #ifdef __unused __unused #endif This addresses an yacc auto-generation issue that is related to Bugzilla entry 807. Bugzilla URL: http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=807 Revision Changes Path 1.17 +0 -3; commitid: b856492af6b741a7; xorp/policy/policy.y 1.23 +55 -58; commitid: b856492af6b741a7; xorp/policy/yacc.yy_policy_parser.cc From jtc at icir.org Mon Nov 24 13:41:37 2008 From: jtc at icir.org (JT Conklin) Date: Mon, 24 Nov 2008 21:41:37 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/utils Message-ID: <200811242141.mAOLfbYe048408@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: jtc at chum.icir.org 2008-11-24 21:41:37 UTC XORP CVS repository Modified files: utils rcsid2ident.sh Log message: Changed the rcsid2ident.sh script to remove #ifdef __undef __undef #endif as well as tranform the yyrcsid[] definition to use the #ident preprocessor directive. Last remaining part of bugzilla issue #807. Bugzilla URL: http://bugzilla.xorp.org/show_bug.cgi?id=807 Bug found by: jt.conklin at xorp.net Revision Changes Path 1.2 +4 -6; commitid: bc16492b16b541a7; xorp/utils/rcsid2ident.sh From paulz at icir.org Tue Nov 25 13:40:55 2008 From: paulz at icir.org (Paul Zeldin) Date: Tue, 25 Nov 2008 21:40:55 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp/swig Message-ID: <200811252140.mAPLetm4058775@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: paulz at chum.icir.org 2008-11-25 21:40:55 UTC XORP CVS repository Log message: Directory /usr/local/www/data/cvs/xorp/swig added to the repository From jtc at icir.org Wed Nov 26 11:15:07 2008 From: jtc at icir.org (JT Conklin) Date: Wed, 26 Nov 2008 19:15:07 GMT Subject: [Xorp-cvs] XORP cvs commit: www/html_src Message-ID: <200811261915.mAQJF773067327@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: www Changes by: jtc at chum.icir.org 2008-11-26 19:15:07 UTC XORP CVS repository Modified files: html_src downloads.html Log message: Add back MD5 signitures for xorp-1.4.tar.gz and xorp-1.4-setup.exe that were lost in the 1.5 release process. Revision Changes Path 1.52 +4 -0; commitid: 106d0492d9fe441a7; www/html_src/downloads.html From jtc at icir.org Wed Nov 26 11:52:26 2008 From: jtc at icir.org (JT Conklin) Date: Wed, 26 Nov 2008 19:52:26 GMT Subject: [Xorp-cvs] XORP cvs commit: www Message-ID: <200811261952.mAQJqQEH067693@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: www Changes by: jtc at chum.icir.org 2008-11-26 19:52:26 UTC XORP CVS repository Modified files: . about.html advisories.html architecture.html contributing.html cvs.html design_docs.html downloads.html empty.html faq.html getting_started.html index.html license.html livecd.html mailing_lists.html mirror_operation.html mirrors.html news.html papers.html people.html porting.html roadmap.html snmp.html xorp_vision.html Log message: Check in generated files. Revision Changes Path 1.10 +3 -2; commitid: 1082a492da8ee41a7; www/about.html 1.13 +3 -2; commitid: 1082a492da8ee41a7; www/advisories.html 1.6 +3 -2; commitid: 1082a492da8ee41a7; www/architecture.html 1.44 +3 -2; commitid: 1082a492da8ee41a7; www/contributing.html 1.42 +3 -2; commitid: 1082a492da8ee41a7; www/cvs.html 1.33 +3 -2; commitid: 1082a492da8ee41a7; www/design_docs.html 1.87 +7 -2; commitid: 1082a492da8ee41a7; www/downloads.html 1.26 +3 -2; commitid: 1082a492da8ee41a7; www/empty.html 1.38 +3 -2; commitid: 1082a492da8ee41a7; www/faq.html 1.87 +3 -2; commitid: 1082a492da8ee41a7; www/getting_started.html 1.92 +3 -2; commitid: 1082a492da8ee41a7; www/index.html 1.41 +3 -2; commitid: 1082a492da8ee41a7; www/license.html 1.70 +3 -2; commitid: 1082a492da8ee41a7; www/livecd.html 1.32 +3 -2; commitid: 1082a492da8ee41a7; www/mailing_lists.html 1.20 +3 -2; commitid: 1082a492da8ee41a7; www/mirror_operation.html 1.58 +3 -2; commitid: 1082a492da8ee41a7; www/mirrors.html 1.74 +3 -2; commitid: 1082a492da8ee41a7; www/news.html 1.30 +3 -2; commitid: 1082a492da8ee41a7; www/papers.html 1.41 +3 -2; commitid: 1082a492da8ee41a7; www/people.html 1.24 +3 -2; commitid: 1082a492da8ee41a7; www/porting.html 1.31 +3 -2; commitid: 1082a492da8ee41a7; www/roadmap.html 1.24 +3 -2; commitid: 1082a492da8ee41a7; www/snmp.html 1.25 +3 -2; commitid: 1082a492da8ee41a7; www/xorp_vision.html From pavlin at icir.org Wed Nov 26 22:36:38 2008 From: pavlin at icir.org (Pavlin Radoslavov) Date: Thu, 27 Nov 2008 06:36:38 GMT Subject: [Xorp-cvs] XORP cvs commit: xorp Message-ID: <200811270636.mAR6acph072232@chum.icir.org> CVSROOT: /usr/local/www/data/cvs Module name: xorp Changes by: pavlin at chum.icir.org 2008-11-27 06:36:38 UTC XORP CVS repository Modified files: . BUILD_NOTES RELEASE_NOTES Log message: XORP now builds on inux Red Hat Enterprise Linux Server release 5 (Tikanga), and Linux Fedora 10. Revision Changes Path 1.111 +18 -1; commitid: 11a0f492e3fdf41a7; xorp/BUILD_NOTES 1.223 +3 -2; commitid: 11a0f492e3fdf41a7; xorp/RELEASE_NOTES