[Xorp-cvs] XORP cvs commit: xorp/ospf

Bruce Simpson bms at icir.org
Fri Nov 14 04:44:19 PST 2008


CVSROOT:	/usr/local/www/data/cvs
Module name:	xorp
Changes by:	bms at chum.icir.org	2008-11-14 12:44:19 UTC

XORP CVS repository


Modified files:
	ospf          debug_io.hh io.hh ospf.cc ospf.hh peer_manager.cc 
	              xrl_io.cc xrl_io.hh 

Log message:
	Fix an issue with OSPF virtual links, where packets destined for
	a virtual link endpoint would contain a TTL of 1, resulting in them
	being dropped as they transited the network.
	
	The downcall to the FEA to transmit a packet destined for a virtual
	link endpoint would rely on the FEA to set the TTL of the outer IPv4
	header.
	
	As the OSPF process passes the ip_network_control flag true to the
	FEA when it sends the tranmission XRL, and a ttl of -1 to let the FEA
	choose the IPv4 TTL, this resulted in the FEA setting the TTL to 1
	internally every time.
	
	The fix is to explicitly set the TTL for tranmission from within the
	OSPF PeerManager::transmit() method, as it has knowledge of whether or
	not the endpoint is virtual.
	
	Bugzilla URL:   http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=824
	Reviewed by:    Pavlin Radoslavov

Revision  Changes                              Path
1.30      +3 -2;  commitid: 5bc4491d728041a7;  xorp/ospf/debug_io.hh
1.31      +2 -2;  commitid: 5bc4491d728041a7;  xorp/ospf/io.hh
1.101     +8 -7;  commitid: 5bc4491d728041a7;  xorp/ospf/ospf.cc
1.115     +2 -2;  commitid: 5bc4491d728041a7;  xorp/ospf/ospf.hh
1.160     +7 -3;  commitid: 5bc4491d728041a7;  xorp/ospf/peer_manager.cc
1.53      +7 -7;  commitid: 5bc4491d728041a7;  xorp/ospf/xrl_io.cc
1.35      +2 -2;  commitid: 5bc4491d728041a7;  xorp/ospf/xrl_io.hh



More information about the Xorp-cvs mailing list