[Xorp-cvs] XORP cvs commit: xorp/libxipc

Pavlin Radoslavov pavlin at icir.org
Sun Oct 12 19:06:58 PDT 2008


CVSROOT:	/usr/local/www/data/cvs
Module name:	xorp
Changes by:	pavlin at chum.icir.org	2008-10-13 02:06:58 UTC

XORP CVS repository


Modified files:
	libxipc       test_stcp.cc xrl_pf_stcp.cc xrl_pf_stcp.hh 

Log message:
	Use TimeVal instead of ms (milliseconds) for time computation and
	event scheduling.
	
	This fixes a critical bug on certain systems (e.g., OpenBSD-4.3)
	where the ms delta computation inside XrlPFSTCPSender::send_keepalive()
	could result in integer overflow during startup; as a result of that
	the XRL keepalives were never sent, and after 3-4 minutes there would
	be errors like the following:
	
	[ 2008/10/10 11:36:06  ERROR xorp_fea:21542 XRL +379 xrl_pf_stcp.cc die ]
	STCPRequestHandler died: life timer expired
	
	This fixes Bugzilla entry #788
	
	Bugzilla URL:   http://bugzilla.xorp.org/bugzilla/show_bug.cgi?id=788

Revision  Changes                                Path
1.25      +9 -8;  commitid: 7b5a48f2abbc41a7;    xorp/libxipc/test_stcp.cc
1.72      +18 -20;  commitid: 7b5a48f2abbc41a7;  xorp/libxipc/xrl_pf_stcp.cc
1.36      +4 -4;  commitid: 7b5a48f2abbc41a7;    xorp/libxipc/xrl_pf_stcp.hh



More information about the Xorp-cvs mailing list