[Xorp-cvs] SF.net SVN: xorp:[11538] trunk/xorp/bgp/socket.cc

bms_fbsd at users.sourceforge.net bms_fbsd at users.sourceforge.net
Wed Sep 2 18:03:16 PDT 2009


Revision: 11538
          http://xorp.svn.sourceforge.net/xorp/?rev=11538&view=rev
Author:   bms_fbsd
Date:     2009-09-03 01:03:15 +0000 (Thu, 03 Sep 2009)

Log Message:
-----------
Comment out a paranoid assertion which existed to catch socket recycling
problems with BGP under Windows.

Reported by:	Tafi Makamure

Modified Paths:
--------------
    trunk/xorp/bgp/socket.cc

Modified: trunk/xorp/bgp/socket.cc
===================================================================
--- trunk/xorp/bgp/socket.cc	2009-09-03 00:59:35 UTC (rev 11537)
+++ trunk/xorp/bgp/socket.cc	2009-09-03 01:03:15 UTC (rev 11538)
@@ -197,7 +197,9 @@
 	      get_remote_host());
 
     // Assert that socket doesn't already exist, as we are about to create it.
-    XLOG_ASSERT(!get_sock().is_valid());
+    // XXX: This paranoid assertion existed to catch socket recycling
+    // issues on the Windows platform; commented out for now.
+    //XLOG_ASSERT(!get_sock().is_valid());
 
     size_t len;
     create_socket(get_local_socket(len), COMM_SOCK_BLOCKING);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.



More information about the Xorp-cvs mailing list