From noreply at github.com Tue Aug 10 12:46:32 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 10 Aug 2010 12:46:32 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] be379f: Update notes for installing proper packages on Ubu... Message-ID: <20100810194632.0407C4204F@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: be379f43660818db6a49a8a1398e9e933a612ce6 http://github.com/greearb/xorp.ct/commit/be379f43660818db6a49a8a1398e9e933a612ce6 Author: Ben Greear Date: 2010-08-10 (Tue, 10 Aug 2010) Changed paths: M xorp/site_scons/config/allconfig.py Log Message: ----------- Update notes for installing proper packages on Ubuntu. Signed-off-by: Ben Greear From noreply at github.com Tue Aug 10 14:21:59 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 10 Aug 2010 14:21:59 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 41902e: xrl: Chmod xrl file to be g+rwx, u+rwx and suid. Message-ID: <20100810212158.F363D422C6@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 41902e946de036fb0048d6d737713e46dce60af8 http://github.com/greearb/xorp.ct/commit/41902e946de036fb0048d6d737713e46dce60af8 Author: Ben Greear Date: 2010-08-10 (Tue, 10 Aug 2010) Changed paths: M xorp/libxipc/xrl_pf_unix.cc Log Message: ----------- xrl: Chmod xrl file to be g+rwx, u+rwx and suid. Previously, it wasn't group writable. Signed-off-by: Ben Greear From noreply at github.com Tue Aug 10 14:22:07 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 10 Aug 2010 14:22:07 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 73cd93: bsd: Enable -Werror compile flag Message-ID: <20100810212207.C54A5422BB@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 73cd93cffcc8fa95df0103400c468a2b6a252624 http://github.com/greearb/xorp.ct/commit/73cd93cffcc8fa95df0103400c468a2b6a252624 Author: Ben Greear Date: 2010-08-10 (Tue, 10 Aug 2010) Changed paths: M xorp/SConstruct Log Message: ----------- bsd: Enable -Werror compile flag Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 11:04:45 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 11:04:45 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 9d74c3: fea: Remove sockets from eventloop in io-ip-socke... Message-ID: <20100816180445.08D0442173@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 9d74c34f3370c33e6e86ab9fdc3888a45ebf3d70 http://github.com/greearb/xorp.ct/commit/9d74c34f3370c33e6e86ab9fdc3888a45ebf3d70 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/fea/data_plane/io/io_ip_socket.cc M xorp/fea/data_plane/io/io_ip_socket.hh M xorp/fea/io_ip_manager.hh Log Message: ----------- fea: Remove sockets from eventloop in io-ip-socket destructor. Fixes SEGV crash on graceful shutdown of fea. Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 11:59:57 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 11:59:57 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 58e2fa: pim: Fix crash due to calling pure-virtual method... Message-ID: <20100816185957.08C4342193@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 58e2faedc785d89faa61383400e388c2bd4f2159 http://github.com/greearb/xorp.ct/commit/58e2faedc785d89faa61383400e388c2bd4f2159 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/pim/xorp_pimsm4.cc M xorp/pim/xorp_pimsm6.cc M xorp/pim/xrl_pim_node.hh Log Message: ----------- pim: Fix crash due to calling pure-virtual method. The pim-xrl-node destructors caused some recursive actions that then called a virtual method on the pim-xrl-node. This is invalid and caused an abort. Fix this by partially open-coding some of the destuctor logic in xrl-pim-node before actually destroying the node. Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 12:44:00 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 12:44:00 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] e9f50d: libxorp/heap: Fix long-standing memory corruption... Message-ID: <20100816194400.AFE4D421B6@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: e9f50df436d634c819a5e8eb2fb9e4084d02fe37 http://github.com/greearb/xorp.ct/commit/e9f50df436d634c819a5e8eb2fb9e4084d02fe37 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/libxorp/heap.cc M xorp/libxorp/heap.hh M xorp/libxorp/timer.cc Log Message: ----------- libxorp/heap: Fix long-standing memory corruption. We used to leak Heap objects on purpose because destroying them caused crashes. It seems the crash was either because of un-initialized memory or (more likely I think), using memset() on this in the constructor. Either way, this patch appears to fix the problem and we run clean under valgrind (as far as Heaps are concerned, at least). Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 17:06:32 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 17:06:32 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] ac3710: bgp: Debugging & decrease timeouts in destructor. Message-ID: <20100817000632.D53A142171@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: ac3710bdd7616b213fea27503db24feedcc0e179 http://github.com/greearb/xorp.ct/commit/ac3710bdd7616b213fea27503db24feedcc0e179 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/bgp/bgp.cc M xorp/bgp/harness/test_routing1.sh M xorp/bgp/peer.cc M xorp/libxipc/xrl_pf.cc M xorp/libxipc/xrl_pf.hh M xorp/libxipc/xrl_pf_stcp.cc M xorp/libxipc/xrl_pf_stcp.hh M xorp/libxipc/xrl_pf_unix.hh M xorp/libxipc/xrl_router.cc M xorp/libxipc/xrl_router.hh M xorp/libxipc/xrl_std_router.cc M xorp/libxipc/xrl_std_router.hh M xorp/libxorp/asyncio.cc M xorp/libxorp/asyncio.hh M xorp/libxorp/buffered_asyncio.hh M xorp/libxorp/xorpfd.hh Log Message: ----------- bgp: Debugging & decrease timeouts in destructor. Decrease wait time for tearing down xrl_router stuff in event loop. Makes self tests work better. Also, add lots of toString() debug methods to help understand current state of xrl logic. A bit of code bloat..would accept patches to #ifdef out toString logic, assuming compiler doesn't know how to get rid of it already if logging is compiled out. Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 19:07:08 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 19:07:08 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] b0a321: Update release notes. Message-ID: <20100817020708.41D7042174@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: b0a321a0790e42b46ad93c5ad0a45dfefa1fdde4 http://github.com/greearb/xorp.ct/commit/b0a321a0790e42b46ad93c5ad0a45dfefa1fdde4 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/RELEASE_NOTES Log Message: ----------- Update release notes. Signed-off-by: Ben Greear From noreply at github.com Mon Aug 16 22:02:34 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 16 Aug 2010 22:02:34 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 904d97: Update rls notes. Message-ID: <20100817050234.3A59542193@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 904d9732832b41b2490e9c6d908594c58d41aac1 http://github.com/greearb/xorp.ct/commit/904d9732832b41b2490e9c6d908594c58d41aac1 Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: M xorp/RELEASE_NOTES Log Message: ----------- Update rls notes. Signed-off-by: Ben Greear Commit: 42136cff4df21b09f6a85a960071b5726d14483c http://github.com/greearb/xorp.ct/commit/42136cff4df21b09f6a85a960071b5726d14483c Author: Ben Greear Date: 2010-08-16 (Mon, 16 Aug 2010) Changed paths: R xorp/fea/ip.h M xorp/libxorp/utility.h M xorp/libxorp/xorp.h M xorp/mrt/netstream_access.h M xorp/rtrmgr/main_rtrmgr.cc M xorp/site_scons/config/allconfig.py M xorp/vrrp/vrrp_packet.hh Log Message: ----------- endian: Minimize use of hand-crafted endian checks. Use endian.h if it exists..guess on other platforms. This should help cross-compiling, but might not fix it in all cases. Signed-off-by: Ben Greear From noreply at github.com Tue Aug 17 09:09:34 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 17 Aug 2010 09:09:34 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 08c5d3: bsd/endian: Fix up endian logic for systems that ... Message-ID: <20100817160934.183EA422E0@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 08c5d352fdc15e39d34682c6d70a27e95823f53d http://github.com/greearb/xorp.ct/commit/08c5d352fdc15e39d34682c6d70a27e95823f53d Author: Ben Greear Date: 2010-08-17 (Tue, 17 Aug 2010) Changed paths: M xorp/libxorp/xorp.h Log Message: ----------- bsd/endian: Fix up endian logic for systems that don't have Looks like BSD has , will try to enable that next, but we still need these fixes for systems w/out endian.h Signed-off-by: Ben Greear From noreply at github.com Tue Aug 17 09:12:11 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 17 Aug 2010 09:12:11 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 3d3293: Fix cruft left in by last commit. Message-ID: <20100817161211.70995422E0@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 3d3293a830fd8b6384bae17d679627996ea416a9 http://github.com/greearb/xorp.ct/commit/3d3293a830fd8b6384bae17d679627996ea416a9 Author: Ben Greear Date: 2010-08-17 (Tue, 17 Aug 2010) Changed paths: M xorp/libxorp/xorp.h Log Message: ----------- Fix cruft left in by last commit. Signed-off-by: Ben Greear From noreply at github.com Tue Aug 17 09:59:09 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 17 Aug 2010 09:59:09 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] ffd75f: bgp: Fix another potential hang when shutting dow... Message-ID: <20100817165909.DEE7C421A2@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: ffd75f7b4f3b3d4eeb8c2bf409257947931fdf6d http://github.com/greearb/xorp.ct/commit/ffd75f7b4f3b3d4eeb8c2bf409257947931fdf6d Author: Ben Greear Date: 2010-08-17 (Tue, 17 Aug 2010) Changed paths: M xorp/bgp/bgp.cc Log Message: ----------- bgp: Fix another potential hang when shutting down BGP. Signed-off-by: Ben Greear From noreply at github.com Tue Aug 17 21:21:10 2010 From: noreply at github.com (noreply at github.com) Date: Tue, 17 Aug 2010 21:21:10 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 4c211c: bgp/socket: Make BGP error message slightly more ... Message-ID: <20100818042110.E3E414230E@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 4c211cdde0daa4b93a7ff858294edae9e7ab495b http://github.com/greearb/xorp.ct/commit/4c211cdde0daa4b93a7ff858294edae9e7ab495b Author: Ben Greear Date: 2010-08-17 (Tue, 17 Aug 2010) Changed paths: M xorp/bgp/xrl_target.cc M xorp/libcomm/comm_sock.c Log Message: ----------- bgp/socket: Make BGP error message slightly more useful. Also, don't warn about missing BINDTODEVICE on BSD. It simply isn't supported there, so no need to fill logs with warnings users can do nothing about. Signed-off-by: Ben Greear From noreply at github.com Thu Aug 19 17:06:28 2010 From: noreply at github.com (noreply at github.com) Date: Thu, 19 Aug 2010 17:06:28 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 08a594: livecd: Update web docs for live-cd. Message-ID: <20100820000628.0CC934232E@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 08a5948fbeb20f283791f43d547df83be2f7271d http://github.com/greearb/xorp.ct/commit/08a5948fbeb20f283791f43d547df83be2f7271d Author: Ben Greear Date: 2010-08-19 (Thu, 19 Aug 2010) Changed paths: M www/html_src/livecd.html M www/scripts/XorpOrgGenerator.py Log Message: ----------- livecd: Update web docs for live-cd. Signed-off-by: Ben Greear From noreply at github.com Fri Aug 20 12:09:53 2010 From: noreply at github.com (noreply at github.com) Date: Fri, 20 Aug 2010 12:09:53 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 153b1a: fea/firewall: Enable firewall support on linux. Message-ID: <20100820190953.7C9A642171@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 153b1a3f6764d81e08707d1b0c0f00cc0c5363fe http://github.com/greearb/xorp.ct/commit/153b1a3f6764d81e08707d1b0c0f00cc0c5363fe Author: Ben Greear Date: 2010-08-20 (Fri, 20 Aug 2010) Changed paths: M xorp/site_scons/config/allconfig.py Log Message: ----------- fea/firewall: Enable firewall support on linux. Was missing some logic in the conversion to scons it seems. Also, you have to hack on /usr/include/linux/netfilter_ipv6/ip6_tables.h, line 222 or so and /usr/include/linux/netfilter_ipv4/ip_tables.h, line 282 or so to make the methods look something like this: /* Helper functions */ static __inline__ struct ipt_entry_target * ipt_get_target(struct ipt_entry *e) { /* BEN: Was void* */ return (struct ipt_entry_target *)e + e->target_offset; } I'll try to get a fix to the linux kernel headers pushed upstream, but that could take a long time. Signed-off-by: Ben Greear From noreply at github.com Fri Aug 20 15:39:33 2010 From: noreply at github.com (noreply at github.com) Date: Fri, 20 Aug 2010 15:39:33 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 01574c: Update rls notes to note enabling firewall logic. Message-ID: <20100820223933.78297422D6@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 01574c9e656a2d58502f7e106de30fdc0f7ae23f http://github.com/greearb/xorp.ct/commit/01574c9e656a2d58502f7e106de30fdc0f7ae23f Author: Ben Greear Date: 2010-08-20 (Fri, 20 Aug 2010) Changed paths: M xorp/RELEASE_NOTES Log Message: ----------- Update rls notes to note enabling firewall logic. Signed-off-by: Ben Greear From noreply at github.com Mon Aug 23 09:50:32 2010 From: noreply at github.com (noreply at github.com) Date: Mon, 23 Aug 2010 09:50:32 -0700 Subject: [Xorp-cvs] [greearb/xorp.ct] 27def6: firewall: Fix suggested code patch for iptables.h Message-ID: <20100823165032.93E9D42037@smtp1.rs.github.com> Branch: refs/heads/master Home: http://github.com/greearb/xorp.ct Commit: 27def60952c557ba508dd607e12020d10feb592a http://github.com/greearb/xorp.ct/commit/27def60952c557ba508dd607e12020d10feb592a Author: Ben Greear Date: 2010-08-23 (Mon, 23 Aug 2010) Changed paths: M xorp/site_scons/config/allconfig.py Log Message: ----------- firewall: Fix suggested code patch for iptables.h Previous suggestion was evidently broken due to pointer arithmetic issues. Signed-off-by: Ben Greear