[Xorp-hackers] First-cut IP filtering XIF.

Eddie Kohler kohler@CS.UCLA.EDU
Mon, 23 Aug 2004 16:42:57 -0700


>> 	 * @param src Source IPv4 address with network prefix.
>> 	 * @param dst Destination IPv4 address with network prefix.
>> 	 * @param proto IP protocol number for match (actually u8).
>> 	 * @param sport Source TCP/UDP port (actually u16).
>> 	 * @param dport Destination TCP/UDP port (actually u16).
>
> The name "sport" may be a bit confusing due to the fact there is
> already a word spelled exactly same way :)
> I'd recommend the following renaming:
>
> sport -> src_port
> dport -> dst_port

"sport" and "dport" are well-known actually..

Minor, but whatever :)
E